Re: [PATCH] powerpc/pseries: Make request_ras_irqs() available to other pseries code

2010-05-19 Thread Mark Nelson
Hi Michael, Thanks for looking over these patches! On Tuesday 18 May 2010 22:40:51 Michael Ellerman wrote: On Mon, 2010-05-17 at 22:33 +1000, Mark Nelson wrote: At the moment only the RAS code uses event-sources interrupts (for EPOW events and internal errors) so request_ras_irqs() (which

Re: [PATCH] powerpc/pseries: Make request_ras_irqs() available to other pseries code

2010-05-19 Thread Michael Ellerman
On Wed, 2010-05-19 at 16:35 +1000, Mark Nelson wrote: Hi Michael, Thanks for looking over these patches! .. Existing code I know, but the error handling in here is a little lax, what's not going to work if we miss some or all of the interrupts? That's a good point. For the existing

Re: [PATCH] powerpc/pseries: Make request_ras_irqs() available to other pseries code

2010-05-19 Thread Mark Nelson
On Wednesday 19 May 2010 16:35:54 Michael Ellerman wrote: On Wed, 2010-05-19 at 16:35 +1000, Mark Nelson wrote: Hi Michael, Thanks for looking over these patches! .. Existing code I know, but the error handling in here is a little lax, what's not going to work if we miss some or

Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-05-19 Thread Andre Prendel
On Tue, May 18, 2010 at 10:35:21AM -0400, Jeff Angielski wrote: On 05/18/2010 07:38 AM, Andre Prendel wrote: I'd prefer starting i with 0 and as condition i data-channels - 1. for (i = 0; i data-channels -1; i++) { data-nfactor[i] = i2c_smbus_read_byte_data(client,

[PATCH v2] powerpc/pseries: Make request_ras_irqs() available to other pseries code

2010-05-19 Thread Mark Nelson
At the moment only the RAS code uses event-sources interrupts (for EPOW events and internal errors) so request_ras_irqs() (which actually requests the event-sources interrupts) is found in ras.c and is static. We want to be able to use event-sources interrupts in other pseries code, so let's

Re: [PATCH] need check for devices with bad status status property in __of_scan_bus()

2010-05-19 Thread Sonny Rao
On Mon, May 10, 2010 at 08:13:41PM -0500, Sonny Rao wrote: Hi Ben, we ran into an issue where it looks like we're not properly ignoring a pci device with a non-good status property when we walk the device tree and create our device nodes. However, the EEH init code does look for the property

Re: PATA/legacy IDE subsystem on PowerMac

2010-05-19 Thread jjDaNiMoTh
2010/5/18 Benjamin Herrenschmidt b...@kernel.crashing.org: [cut] Nothing obvious... the disk seem to be detected properly. Do you have the support for mac partitions and the SCSI disk driver (BLK_DEV_SD) enabled ? The PATA modules was built statically, and BLK_DEV_SD as a module (and not

Re: [PATCH] powerpc/pseries: Add support for IO Event interrupt drivers

2010-05-19 Thread Mark Nelson
On Tuesday 18 May 2010 23:37:31 Michael Ellerman wrote: On Mon, 2010-05-17 at 22:53 +1000, Mark Nelson wrote: This patch adds support for handling IO Event interrupts which come through at the /event-sources/ibm,io-events device tree node. Hi Mark, You'll have to explain to me offline

[PATCH] net/mpc52xx_phy: Various code cleanups

2010-05-19 Thread Wolfram Sang
- don't free bus-irq (obsoleted by ca816d98170942371535b3e862813b0aba9b7d90) - don't dispose irqs (should be done in of_mdiobus_register()) - use fec-pointer consistently in transfer() - use resource_size() - cosmetic fixes Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely

Re: [PATCH] powerpc/pseries: Add support for IO Event interrupt drivers

2010-05-19 Thread Mark Nelson
On Wednesday 19 May 2010 14:27:44 Sonny Rao wrote: On Tue, 18 May 2010 23:37:31 +1000, Michael Ellerman wrote: On Mon, 2010-05-17 at 22:53 +1000, Mark Nelson wrote: This patch adds support for handling IO Event interrupts which come through at the /event-sources/ibm,io-events device

Re: [PATCH]460EX on-chip SATA driver Kernel 2.6.33 resubmission

2010-05-19 Thread Alan Cox
On Wed, 19 May 2010 10:49:59 +0900 Jassi Brar jassisinghb...@gmail.com wrote: On Thu, May 6, 2010 at 2:57 AM, Rupjyoti Sarmah rsar...@amcc.com wrote: This patch enables the on-chip DWC SATA controller of the AppliedMicro processor 460EX. The controller seems to be a thrid party IP (from

Re: [PATCH]460EX on-chip SATA driver Kernel 2.6.33 resubmission

2010-05-19 Thread Jassi Brar
On Wed, May 19, 2010 at 6:53 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Wed, 19 May 2010 10:49:59 +0900 Jassi Brar jassisinghb...@gmail.com wrote: On Thu, May 6, 2010 at 2:57 AM, Rupjyoti Sarmah rsar...@amcc.com wrote: This patch enables the on-chip DWC SATA controller of the

enabling PCIe on powerpc device tree

2010-05-19 Thread Thirumalai
Hi, How to enable PCIe interrupt on device tree. I am using linux-2.6.30 on MPC8640D based Target board. -Thirumalai ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/pseries: Add support for IO Event interrupt drivers

2010-05-19 Thread Michael Ellerman
On Wed, 2010-05-19 at 20:24 +1000, Mark Nelson wrote: On Tuesday 18 May 2010 23:37:31 Michael Ellerman wrote: On Mon, 2010-05-17 at 22:53 +1000, Mark Nelson wrote: + /* check to see if we've already registered this function with + * this scope. If we have, don't register it again

Re: [PATCH] powerpc/pseries: Add support for IO Event interrupt drivers

2010-05-19 Thread Michael Ellerman
On Tue, 2010-05-18 at 23:27 -0500, Sonny Rao wrote: On Tue, 18 May 2010 23:37:31 +1000, Michael Ellerman wrote: On Mon, 2010-05-17 at 22:53 +1000, Mark Nelson wrote: This patch adds support for handling IO Event interrupts which come through at the /event-sources/ibm,io-events device

[PATCH] rtasd: Don't start event scan if scan rate is zero

2010-05-19 Thread Michael Ellerman
There appear to be Pegasos systems which have the rtas-event-scan RTAS tokens, but on which the event scan always fails. They also have an event-scan-rate property containing 0, which means call event scan 0 times per minute. So interpret a scan rate of 0 to mean don't scan at all. This fixes the

[PATCH] device-tree: Drop properties with / in their name

2010-05-19 Thread Michael Ellerman
Some bogus firmwares include properties with / in their name. This causes problems when creating the /proc/device-tree file system, because the slash is taken to indicate a directory. We don't care about those properties, and we don't want to encourage them, so just throw them away when creating

[PATCH] powerpc: Use common cpu_die (fixes SMP+SUSPEND build)

2010-05-19 Thread Anton Vorontsov
From: Milton Miller milt...@bga.com Configuring a powerpc 32 bit kernel for both SMP and SUSPEND turns on CPU_HOTPLUG to enable disable_nonboot_cpus to be called by the common suspend code. Previously the definition of cpu_die for ppc32 was in the powermac platform code, causing it to be

Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-05-19 Thread Jean Delvare
Hi Andre, On Wed, 19 May 2010 09:26:59 +0200, Andre Prendel wrote: Jean, should we describe this interface in Documentation/hwmon/sysfs-interface too? For the moment tmp421 is the only driver implementing it. If the values are expressed in a standard unit (i.e. not raw register values) then

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Darren Hart
On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: On 05/18/2010 02:52 PM, Brian King wrote: Is IRQF_NODELAY something specific to the RT kernel? I don't see it in mainline... Yes, it basically says don't make this handler threaded. That

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Thomas Gleixner
On Wed, 19 May 2010, Darren Hart wrote: On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: On 05/18/2010 02:52 PM, Brian King wrote: Is IRQF_NODELAY something specific to the RT kernel? I don't see it in mainline... Yes, it

Re: [PATCH] powerpc: Add i8042 keyboard and mouse irq parsing

2010-05-19 Thread Grant Likely
On Fri, May 14, 2010 at 4:39 AM, Martyn Welch martyn.we...@ge.com wrote: Martyn Welch wrote: Currently the irqs for the i8042, which historically provides keyboard and mouse (aux) support, is hardwired in the driver rather than parsing the dts. In addition the interrupts are provided in the

Re: [Patch v2 1/2] 5200/mpc: improve i2c bus error recovery

2010-05-19 Thread Grant Likely
On Sun, May 16, 2010 at 11:47 AM, Albrecht Dreß albrecht.dr...@arcor.de wrote: Am 06.05.10 20:06 schrieb(en) Grant Likely: I think, though, the whole stuff has been discussed in depth in February, so I do not understand why it's still pending as new.  Grant, did we miss something here?

Re: [PATCH] [RFC] Xilinx Virtex 4 FX Soft FPU support

2010-05-19 Thread Grant Likely
On Fri, Mar 19, 2010 at 9:49 AM, Sergey Temerkhanov temerkha...@cifronik.ru wrote: The patch. Regards, Resgey Temerkhanov Hi Sergey. Comments below. diff -r 9d9ac97e095d .config --- a/.config Thu Feb 25 21:23:42 2010 +0300 +++ b/.config Thu Feb 25 21:49:02 2010 +0300 .config changes

Re: [lm-sensors] [PATCH] hwmon: (tmp421) Add nfactor support (2nd attempt)

2010-05-19 Thread Jeff Angielski
On 05/19/2010 03:26 AM, Andre Prendel wrote: Ok, so there is only one remaining task :) Please update the documentation under Documentation/hwmon/tmp421. Then you will get my Acked-by. Documentation is updated in this patch along with the source file. There is a small cosmetic change in this

Re: [PATCH] powerpc/pseries: Add support for IO Event interrupt drivers

2010-05-19 Thread Sonny Rao
On Wed, May 19, 2010 at 10:10:58PM +1000, Michael Ellerman wrote: snip The checks the scope requires an RTAS call, which takes a global lock (and you add another) - these aren't going to be used for anything performance critical I hope? Nope it shouldn't be performance critical, but

[PATCH] powerpc: make the padding for the device tree a configurable option

2010-05-19 Thread Timur Tabi
Add the DTS_PADDING Kconfig option, which allows users and board defconfig files to specify a padding value when compiling device trees. When a device tree source (DTS) is compiled into a binary (DTB), a hard-coded padding of 1024 bytes is used (i.e. dtc command-line parameter -p 1024). Although

Re: [PATCH 1/4] powerpc/fsl_soc.c: prepare for addition of mpc5121 USB code

2010-05-19 Thread Grant Likely
On Thu, May 6, 2010 at 1:18 PM, Anatolij Gustschin ag...@denx.de wrote: Hi Grant, On Tue, 27 Apr 2010 10:51:21 -0600 Grant Likely grant.lik...@secretlab.ca wrote: On Tue, Apr 27, 2010 at 10:11 AM, Anatolij Gustschin ag...@denx.de wrote: Factor out common code for registering a FSL EHCI

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Thomas Gleixner
On Wed, 19 May 2010, Thomas Gleixner wrote: I'm still not clear on why the ultimate solution wasn't to have XICS report edge triggered as edge triggered. Probably some complexity of the entire power stack that I am ignorant of. Apart from the issue of loosing interrupts there is

Re: [PATCH 1/3] video: add support for getting video mode from device tree

2010-05-19 Thread Grant Likely
On Wed, Apr 28, 2010 at 7:43 AM, Anatolij Gustschin ag...@denx.de wrote: On Mon, 01 Mar 2010 14:45:20 +1100 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Sat, 2010-02-27 at 22:44 -1000, Mitch Bradley wrote: As it turns out, I'm doing exactly that - exporting verbatim EDID data

Re: [PATCH] powerpc: make the padding for the device tree a configurable option

2010-05-19 Thread Benjamin Herrenschmidt
On Wed, 2010-05-19 at 14:53 -0500, Timur Tabi wrote: Add the DTS_PADDING Kconfig option, which allows users and board defconfig files to specify a padding value when compiling device trees. When a device tree source (DTS) is compiled into a binary (DTB), a hard-coded padding of 1024 bytes is

Re: [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board

2010-05-19 Thread Grant Likely
On Mon, May 3, 2010 at 10:34 AM, Scott Wood scottw...@freescale.com wrote: Grant Likely wrote: +               // IPIC +               // interrupts cell = intr #, sense +               // sense values match linux IORESOURCE_IRQ_* defines: +               // sense == 8: Level, low assertion

Re: [PATCH] powerpc: make the padding for the device tree a configurable option

2010-05-19 Thread Timur Tabi
Benjamin Herrenschmidt wrote: So to accommodate future boards where more padding is needed, we make the option for the -p parameter configurable. Can't u-boot just allocate more space ? Yes and no. U-Boot has functions to increase the size of an fdt, but these functions can't be sure that

Re: [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board

2010-05-19 Thread Scott Wood
On 05/19/2010 04:27 PM, Grant Likely wrote: On Mon, May 3, 2010 at 10:34 AM, Scott Woodscottw...@freescale.com wrote: Grant Likely wrote: + // IPIC + // interrupts cell =intr #, sense + // sense values match linux IORESOURCE_IRQ_* defines: +

Re: [PATCH 2/2] powerpc/mpc5121: add initial support for PDM360NG board

2010-05-19 Thread Grant Likely
On Wed, May 19, 2010 at 3:37 PM, Scott Wood scottw...@freescale.com wrote: On 05/19/2010 04:27 PM, Grant Likely wrote: On Mon, May 3, 2010 at 10:34 AM, Scott Woodscottw...@freescale.com  wrote: Grant Likely wrote: +               // IPIC +               // interrupts cell =intr #, sense

Re: [PATCH] powerpc: make the padding for the device tree a configurable option

2010-05-19 Thread Benjamin Herrenschmidt
On Wed, 2010-05-19 at 16:33 -0500, Timur Tabi wrote: Benjamin Herrenschmidt wrote: So to accommodate future boards where more padding is needed, we make the option for the -p parameter configurable. Can't u-boot just allocate more space ? Yes and no. U-Boot has functions to

Re: [PATCH] powerpc: make the padding for the device tree a configurable option

2010-05-19 Thread Timur Tabi
On Wed, May 19, 2010 at 5:44 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: It's still not kernel business to have to deal with u-boot memory allocation constraints. I agree, but it still makes sense to me to allow the padding to be configurable. The padding in the kernel built

Re: [PATCH] powerpc: make the padding for the device tree a configurable option

2010-05-19 Thread Benjamin Herrenschmidt
On Wed, 2010-05-19 at 19:03 -0500, Timur Tabi wrote: The problem is that the code which allocates a block for the fdt is completely distinct from the code that manipulates the fdt. We'd need to put in either some kind of funky callback mechanism, or insist that every fdt exist in a block of

Re: [PATCH] powerpc: make the padding for the device tree a configurable option

2010-05-19 Thread M. Warner Losh
In message: aanlktilefxxcmnwqksultu88r4d9w98adhlhxvuwi...@mail.gmail.com Timur Tabi ti...@freescale.com writes: : I'm stuck between a rock and a hard place, it seems. No one is : willing to compromise on any of my ideas. It's hard to convince our : BSP developers that they should be

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Michael Ellerman
On Wed, 2010-05-19 at 07:16 -0700, Darren Hart wrote: On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: On 05/18/2010 02:52 PM, Brian King wrote: Is IRQF_NODELAY something specific to the RT kernel? I don't see it in mainline...

Re: [PATCH] powerpc: make the padding for the device tree a configurable option

2010-05-19 Thread David Gibson
On Wed, May 19, 2010 at 07:03:17PM -0500, Timur Tabi wrote: On Wed, May 19, 2010 at 5:44 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: It's still not kernel business to have to deal with u-boot memory allocation constraints. I agree, but it still makes sense to me to allow

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Michael Ellerman
On Wed, 2010-05-19 at 16:38 +0200, Thomas Gleixner wrote: On Wed, 19 May 2010, Darren Hart wrote: On 05/18/2010 06:25 PM, Michael Ellerman wrote: On Tue, 2010-05-18 at 15:22 -0700, Darren Hart wrote: On 05/18/2010 02:52 PM, Brian King wrote: Is IRQF_NODELAY something specific to

Re: [PATCH RT] ehea: make receive irq handler non-threaded (IRQF_NODELAY)

2010-05-19 Thread Michael Ellerman
On Wed, 2010-05-19 at 23:08 +0200, Thomas Gleixner wrote: On Wed, 19 May 2010, Thomas Gleixner wrote: I'm still not clear on why the ultimate solution wasn't to have XICS report edge triggered as edge triggered. Probably some complexity of the entire power stack that I am

Re: [PATCH] powerpc: make the padding for the device tree a configurable option

2010-05-19 Thread Timur Tabi
On Wed, May 19, 2010 at 8:18 PM, David Gibson da...@gibson.dropbear.id.au wrote: Couldn't you use the configurable padding, but put the stuff to do it into u-boot.  i.e. repad the dtb at u-boot build time, rather than u-boot runtime. That's what I was trying to do. Take a look at this

Re: [PATCH] powerpc: Fix string library functions

2010-05-19 Thread Paul Mackerras
On Tue, May 18, 2010 at 08:15:21PM +0200, Andreas Schwab wrote: The powerpc strncmp implementation does not correctly handle a zero length, despite the claim in 0119536cd314ef95553604208c25bc35581f7f0a (Add hand-coded assembly strcmp). Additionally, all the length arguments are size_t, not

Re: [Patch 2/2] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2010-05-19 Thread K.Prasad
On Mon, May 17, 2010 at 10:32:41PM +1000, Paul Mackerras wrote: On Fri, May 14, 2010 at 12:25:31PM +0530, K.Prasad wrote: Okay. I will re-use single_step_exception() after modifications; it appearsto have no in-kernel users for it. It's called from exceptions-64s.S, head_32.S and