Re: [PATCH v6 08/15] memory-hotplug: Common APIs to support page tables hot-remove

2013-01-29 Thread Simon Jeons
On Wed, 2013-01-30 at 13:55 +0800, Tang Chen wrote: > On 01/30/2013 11:27 AM, Simon Jeons wrote: > > On Wed, 2013-01-30 at 10:16 +0800, Tang Chen wrote: > >> On 01/29/2013 09:04 PM, Simon Jeons wrote: > >>> Hi Tang, > >>> On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: > From: Wen Congyang

Re: [PATCH] powerpc/mm: Fix hash computation function

2013-01-29 Thread Mike Qiu
With the fix, the machine can boot up successfully Tested-by: Mike Qiu 于 2013/1/30 13:40, Aneesh Kumar K.V 写道: > From: "Aneesh Kumar K.V" > > The ASM version of hash computation function was truncating the upper bit. > Make the ASM version similar to hpt_hash function. Remove masking vsid bits.

Re: [PATCH v6 08/15] memory-hotplug: Common APIs to support page tables hot-remove

2013-01-29 Thread Tang Chen
On 01/30/2013 11:27 AM, Simon Jeons wrote: On Wed, 2013-01-30 at 10:16 +0800, Tang Chen wrote: On 01/29/2013 09:04 PM, Simon Jeons wrote: Hi Tang, On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: From: Wen Congyang When memory is removed, the corresponding pagetables should alse be removed

[PATCH] powerpc/mm: Fix hash computation function

2013-01-29 Thread Aneesh Kumar K.V
From: "Aneesh Kumar K.V" The ASM version of hash computation function was truncating the upper bit. Make the ASM version similar to hpt_hash function. Remove masking vsid bits. Without this patch, we observed hang during bootup due to not satisfying page fault request correctly. The fault handler

Re: [PATCH v6 08/15] memory-hotplug: Common APIs to support page tables hot-remove

2013-01-29 Thread Simon Jeons
On Wed, 2013-01-30 at 10:16 +0800, Tang Chen wrote: > On 01/29/2013 09:04 PM, Simon Jeons wrote: > > Hi Tang, > > On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: > >> From: Wen Congyang > >> > >> When memory is removed, the corresponding pagetables should alse be > >> removed. > >> This patch

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-29 Thread Tang Chen
On 01/30/2013 10:48 AM, Simon Jeons wrote: On Wed, 2013-01-30 at 10:32 +0800, Tang Chen wrote: On 01/29/2013 08:52 PM, Simon Jeons wrote: Hi Tang, On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: Here is the physical memory hot-remove patch-set based on 3.8rc-2. Hi Simon, I'll summarize

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-29 Thread Simon Jeons
On Wed, 2013-01-30 at 10:32 +0800, Tang Chen wrote: > On 01/29/2013 08:52 PM, Simon Jeons wrote: > > Hi Tang, > > > > On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: > >> Here is the physical memory hot-remove patch-set based on 3.8rc-2. > > Hi Simon, > > I'll summarize all the info and answe

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-29 Thread Tang Chen
On 01/29/2013 08:52 PM, Simon Jeons wrote: Hi Tang, On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: Here is the physical memory hot-remove patch-set based on 3.8rc-2. Hi Simon, I'll summarize all the info and answer you later. :) Thanks for asking. :) Some questions ask you, not has

Re: [PATCH v6 08/15] memory-hotplug: Common APIs to support page tables hot-remove

2013-01-29 Thread Tang Chen
On 01/29/2013 09:04 PM, Simon Jeons wrote: Hi Tang, On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: From: Wen Congyang When memory is removed, the corresponding pagetables should alse be removed. This patch introduces some common APIs to support vmemmap pagetable and x86_64 architecture pag

Re: [PATCH v6 08/15] memory-hotplug: Common APIs to support page tables hot-remove

2013-01-29 Thread Simon Jeons
On Wed, 2013-01-30 at 09:53 +0800, Jianguo Wu wrote: > On 2013/1/29 21:02, Simon Jeons wrote: > > > Hi Tang, > > On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: > >> From: Wen Congyang > >> > >> When memory is removed, the corresponding pagetables should alse be > >> removed. > >> This patch

Re: [PATCH v6 08/15] memory-hotplug: Common APIs to support page tables hot-remove

2013-01-29 Thread Jianguo Wu
On 2013/1/29 21:02, Simon Jeons wrote: > Hi Tang, > On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: >> From: Wen Congyang >> >> When memory is removed, the corresponding pagetables should alse be removed. >> This patch introduces some common APIs to support vmemmap pagetable and >> x86_64 >>

Re: [PATCH 4/5] net: mvmdio: allow Device Tree and platform device to coexist

2013-01-29 Thread Florian Fainelli
Le mardi 29 janvier 2013 18:59:12, Jason Gunthorpe a écrit : > On Tue, Jan 29, 2013 at 04:24:07PM +0100, Florian Fainelli wrote: > > - dev->err_interrupt = irq_of_parse_and_map(pdev->dev.of_node, 0); > > + if (pdev->dev.of_node) { > > + dev->regs = of_iomap(pdev->dev.of_node, 0); > >

Re: [PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver

2013-01-29 Thread Florian Fainelli
Le mardi 29 janvier 2013 19:13:06, Jason Gunthorpe a écrit : > On Tue, Jan 29, 2013 at 04:24:08PM +0100, Florian Fainelli wrote: > > This patch converts the Marvell MV643XX ethernet driver to use the > > Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms > > registering the Marvell M

Re: [PATCH 2/2] pseries/iommu: remove DDW on kexec

2013-01-29 Thread Nishanth Aravamudan
Hi Michael, On 29.01.2013 [21:58:28 +1100], Michael Ellerman wrote: > On Mon, 2013-01-28 at 18:03 -0800, Nishanth Aravamudan wrote: > > pseries/iommu: remove DDW on kexec > > ... > > > > I believe the simplest, easiest-to-maintain fix is to just change our > > initcall to, rather than detect

Re: [PATCH 4/5] net: mvmdio: allow Device Tree and platform device to coexist

2013-01-29 Thread Jason Gunthorpe
On Tue, Jan 29, 2013 at 04:24:07PM +0100, Florian Fainelli wrote: > - dev->err_interrupt = irq_of_parse_and_map(pdev->dev.of_node, 0); > + if (pdev->dev.of_node) { > + dev->regs = of_iomap(pdev->dev.of_node, 0); > + if (!dev->regs) { > + dev_er

Re: [PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver

2013-01-29 Thread Jason Gunthorpe
On Tue, Jan 29, 2013 at 04:24:08PM +0100, Florian Fainelli wrote: > This patch converts the Marvell MV643XX ethernet driver to use the > Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms > registering the Marvell MV643XX ethernet driver are also updated to > register a Marvell Orion

Re: [PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver

2013-01-29 Thread Thomas Petazzoni
Dear Florian Fainelli, On Tue, 29 Jan 2013 17:27:56 +0100, Florian Fainelli wrote: > It looks like I introduced two redundant mvmdio instances as ge01 > refers to the ge00 smi bus (the same applies to ge11 and ge10). > Thanks for spotting this. Ok, good. > If you take a closer look at mv643xx_e

Re: [PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver

2013-01-29 Thread Florian Fainelli
On 01/29/2013 05:01 PM, Thomas Petazzoni wrote: Dear Florian Fainelli, On Tue, 29 Jan 2013 16:24:08 +0100, Florian Fainelli wrote: This patch converts the Marvell MV643XX ethernet driver to use the Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms registering the Marvell MV643XX

Re: [PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver

2013-01-29 Thread Thomas Petazzoni
Dear Florian Fainelli, On Tue, 29 Jan 2013 16:24:08 +0100, Florian Fainelli wrote: > This patch converts the Marvell MV643XX ethernet driver to use the > Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms > registering the Marvell MV643XX ethernet driver are also updated to > regist

Re: [PATCH 4/5] net: mvmdio: allow Device Tree and platform device to coexist

2013-01-29 Thread Thomas Petazzoni
Dear Florian Fainelli, On Tue, 29 Jan 2013 16:24:07 +0100, Florian Fainelli wrote: > This patch changes the Marvell MDIO driver to be registered by using > both Device Tree and platform device methods. The driver voluntarily > does not use devm_ioremap() to share the same error path for Device Tre

Re: [PATCH 2/5] net: mvmdio: rename base register cookie from smireg to regs

2013-01-29 Thread Thomas Petazzoni
Dear Florian Fainelli, On Tue, 29 Jan 2013 16:24:05 +0100, Florian Fainelli wrote: > This patch renames the base register cookie in the mvmdio drive from > "smireg" to "regs" since a subsequent patch is going to use an ioremap() > cookie whose size is larger than a single register of 4 bytes. No >

Re: [PATCH 1/5] net: mvmdio: unmap base register address at driver removal

2013-01-29 Thread Thomas Petazzoni
Dear Florian Fainelli, On Tue, 29 Jan 2013 16:24:04 +0100, Florian Fainelli wrote: > Fix the driver remove callback to unmap the base register address and > not leak this mapping after the driver has been removed. > > Signed-off-by: Florian Fainelli What about using devm_request_and_ioremap() i

Re: [PATCH 3/5] net: mvmdio: enhance driver to support SMI error/done interrupts

2013-01-29 Thread Thomas Petazzoni
Dear Florian Fainelli, On Tue, 29 Jan 2013 16:24:06 +0100, Florian Fainelli wrote: > #define MVMDIO_SMI_DATA_SHIFT 0 > #define MVMDIO_SMI_PHY_ADDR_SHIFT 16 > @@ -36,12 +40,28 @@ > #define MVMDIO_SMI_WRITE_OPERATION 0 > #define MVMDIO_SMI_READ_VALID B

Re: [PATCH 1/5] net: mvmdio: unmap base register address at driver removal

2013-01-29 Thread Florian Fainelli
On 01/29/2013 04:32 PM, Thomas Petazzoni wrote: Dear Florian Fainelli, On Tue, 29 Jan 2013 16:24:04 +0100, Florian Fainelli wrote: Fix the driver remove callback to unmap the base register address and not leak this mapping after the driver has been removed. Signed-off-by: Florian Fainelli Wh

[PATCH 4/5] net: mvmdio: allow Device Tree and platform device to coexist

2013-01-29 Thread Florian Fainelli
This patch changes the Marvell MDIO driver to be registered by using both Device Tree and platform device methods. The driver voluntarily does not use devm_ioremap() to share the same error path for Device Tree and non-Device Tree cases. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/m

[PATCH 5/5] mv643xx_eth: convert to use the Marvell Orion MDIO driver

2013-01-29 Thread Florian Fainelli
This patch converts the Marvell MV643XX ethernet driver to use the Marvell Orion MDIO driver. As a result, PowerPC and ARM platforms registering the Marvell MV643XX ethernet driver are also updated to register a Marvell Orion MDIO driver. This driver voluntarily overlaps with the Marvell Ethernet s

[PATCH 2/5] net: mvmdio: rename base register cookie from smireg to regs

2013-01-29 Thread Florian Fainelli
This patch renames the base register cookie in the mvmdio drive from "smireg" to "regs" since a subsequent patch is going to use an ioremap() cookie whose size is larger than a single register of 4 bytes. No functionnal code change introduced. Signed-off-by: Florian Fainelli --- drivers/net/ethe

[PATCH 3/5] net: mvmdio: enhance driver to support SMI error/done interrupts

2013-01-29 Thread Florian Fainelli
This patch enhances the "mvmdio" to support a SMI error/done interrupt line which can be used along with a wait queue instead of doing busy-waiting on the registers. This is a feature which is available in the mv643xx_eth SMI code and thus reduces again the gap between the two. Signed-off-by: Flor

[PATCH 1/5] net: mvmdio: unmap base register address at driver removal

2013-01-29 Thread Florian Fainelli
Fix the driver remove callback to unmap the base register address and not leak this mapping after the driver has been removed. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/marvell/mvmdio.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/marvell/mvmdio.c

[PATCH 0/5] mv643xx_eth: use mvmdio MDIO bus driver

2013-01-29 Thread Florian Fainelli
Hi all, This patch converts the mv643xx_eth driver to use the mvmdio MDIO bus driver instead of rolling its own implementation. As a result, all users of this mv643xx_eth driver are converted to register an "orion-mdio" platform_device. The mvmdio driver is also updated to support an interrupt lin

Re: [git pull] Please pull powerpc.git merge branch

2013-01-29 Thread Geert Uytterhoeven
On Tue, Jan 29, 2013 at 1:09 AM, Benjamin Herrenschmidt wrote: > On Mon, 2013-01-28 at 16:03 -0800, Linus Torvalds wrote: >> I'll have you know that I haven't quite even left for Au yet, and I >> have LCA before diving. So no snarky "in between dives" comments, >> please. > > It wasn't meant to be

Re: [PATCH v6 08/15] memory-hotplug: Common APIs to support page tables hot-remove

2013-01-29 Thread Simon Jeons
Hi Tang, On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: > From: Wen Congyang > > When memory is removed, the corresponding pagetables should alse be removed. > This patch introduces some common APIs to support vmemmap pagetable and x86_64 > architecture pagetable removing. Why don't need to

Re: [PATCH v6 08/15] memory-hotplug: Common APIs to support page tables hot-remove

2013-01-29 Thread Simon Jeons
Hi Tang, On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: > From: Wen Congyang > > When memory is removed, the corresponding pagetables should alse be removed. > This patch introduces some common APIs to support vmemmap pagetable and x86_64 > architecture pagetable removing. > When page tabl

Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory

2013-01-29 Thread Simon Jeons
Hi Tang, On Wed, 2013-01-09 at 17:32 +0800, Tang Chen wrote: > Here is the physical memory hot-remove patch-set based on 3.8rc-2. Some questions ask you, not has relationship with this patchset, but is memory hotplug stuff. 1. In function node_states_check_changes_online: comments: * If we don'

Re: [PATCH v5 04/45] percpu_rwlock: Implement the core design of Per-CPU Reader-Writer Locks

2013-01-29 Thread Namhyung Kim
On Thu, 24 Jan 2013 10:00:04 +0530, Srivatsa S. Bhat wrote: > On 01/24/2013 01:27 AM, Tejun Heo wrote: >> On Thu, Jan 24, 2013 at 01:03:52AM +0530, Srivatsa S. Bhat wrote: >>> CPU 0 CPU 1 >>> >>> read_lock(&rwlock) >>> >>> write_lock(&rwlock) /

Re: [PATCH v5 07/45] CPU hotplug: Provide APIs to prevent CPU offline from atomic context

2013-01-29 Thread Namhyung Kim
Hi Srivatsa, On Tue, 22 Jan 2013 13:04:54 +0530, Srivatsa S. Bhat wrote: > @@ -246,15 +291,21 @@ struct take_cpu_down_param { > static int __ref take_cpu_down(void *_param) > { > struct take_cpu_down_param *param = _param; > - int err; > + unsigned long flags; > + int err = 0;

Re: [git pull] Please pull powerpc.git merge branch

2013-01-29 Thread Linus Torvalds
On Mon, Jan 28, 2013 at 4:09 PM, Benjamin Herrenschmidt < b...@kernel.crashing.org> wrote: > > It wasn't meant to be "snarky", sorry about that... I'm kidding, I'm kidding, you can be as snarky as you want. It's not like I'm some fragile flower. > My usual problem with git request-pull when the m

Re: [PATCH 2/2] pseries/iommu: remove DDW on kexec

2013-01-29 Thread Michael Ellerman
On Mon, 2013-01-28 at 18:03 -0800, Nishanth Aravamudan wrote: > pseries/iommu: remove DDW on kexec > ... > > I believe the simplest, easiest-to-maintain fix is to just change our > initcall to, rather than detecting and updating the new kernel's DDW > knowledge, just remove all DDW configurat

[PATCH] powerpc/512x: initialize clocks before bus probing

2013-01-29 Thread Anatolij Gustschin
Early driver probing can fail due to not available clocks (clk_get() fails) since the clk API init didn't take place yet. Move clocks init before bus probing. Signed-off-by: Anatolij Gustschin --- arch/powerpc/platforms/512x/mpc512x_shared.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)