Re: [PATCH v2] of: Specify initrd location using 64-bit
On Mon, 01 Jul 2013 16:34:26 -0500, Rob Herring robherri...@gmail.com wrote: On 07/01/2013 01:20 PM, Santosh Shilimkar wrote: On some PAE architectures, the entire range of physical memory could reside outside the 32-bit limit. These systems need the ability to specify the initrd location using 64-bit numbers. This patch globally modifies the early_init_dt_setup_initrd_arch() function to use 64-bit numbers instead of the current unsigned long. There has been quite a bit of debate about whether to use u64 or phys_addr_t. It was concluded to stick to u64 to be consistent with rest of the device tree code. As summarized by Geert, The address to load the initrd is decided by the bootloader/user and set at that point later in time. The dtb should not be tied to the kernel you are booting That was quoting me. Otherwise: Acked-by: Rob Herring rob.herr...@calxeda.com Unless Grant feels compelled to pick this up for 3.11, I think it has to wait for 3.12. Nope, 3.12 is fine. Applied. g. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: therm_pm72 units, interface
Hi,
On Sat, Jul 20, 2013 at 09:16:49AM +1000, Benjamin Herrenschmidt wrote:
On Fri, 2013-07-19 at 20:43 +0300, Aaro Koskinen wrote:
I booted a Xserve today with 3.11-rc1, and noticed the noise is coming
from slots-fan (PCI fan?) which is always 99%, although the slots-temp is
just 33. Is it on purpose the rm31 slots PID params are totally different
from therm_pm72 slots params? It seems like they have been copied from
pm72 drive bay PID params instead.
Could be my mistake. What happens if you change them to match the old code ?
I tried the change below (use SLOTS_PID_* values from therm_pm72.h),
and the noise level is considerably lower. The slots-fan stays at 19%,
and slots-temp rises to 42'C but not higher after running couple of hours.
diff --git a/drivers/macintosh/windfarm_rm31.c
b/drivers/macintosh/windfarm_rm31.c
index 0b9a79b..82fc86a 100644
--- a/drivers/macintosh/windfarm_rm31.c
+++ b/drivers/macintosh/windfarm_rm31.c
@@ -439,15 +439,15 @@ static void backside_setup_pid(void)
/* Slots fan */
static const struct wf_pid_param slots_param = {
- .interval = 5,
- .history_len= 2,
- .gd = 30 20,
- .gp = 5 20,
- .gr = 0,
- .itarget= 40 16,
- .additive = 1,
- .min= 300,
- .max= 4000,
+ .interval = 1,
+ .history_len= 20,
+ .gd = 0,
+ .gp = 0,
+ .gr = 0x0010,
+ .itarget= 320,
+ .additive = 0,
+ .min= 20,
+ .max= 100,
};
static void slots_fan_tick(void)
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Re: therm_pm72 units, interface
On Sat, 2013-07-20 at 23:33 +0300, Aaro Koskinen wrote:
Hi,
On Sat, Jul 20, 2013 at 09:16:49AM +1000, Benjamin Herrenschmidt wrote:
On Fri, 2013-07-19 at 20:43 +0300, Aaro Koskinen wrote:
I booted a Xserve today with 3.11-rc1, and noticed the noise is coming
from slots-fan (PCI fan?) which is always 99%, although the slots-temp is
just 33. Is it on purpose the rm31 slots PID params are totally different
from therm_pm72 slots params? It seems like they have been copied from
pm72 drive bay PID params instead.
Could be my mistake. What happens if you change them to match the old code ?
I tried the change below (use SLOTS_PID_* values from therm_pm72.h),
and the noise level is considerably lower. The slots-fan stays at 19%,
and slots-temp rises to 42'C but not higher after running couple of hours.
Thanks. I'll give it a quick dbl check asap (about to head out of town
now), in the meantime, can you send it with the appropriate
Signed-off-by: etc... ?
Thanks,
Ben.
diff --git a/drivers/macintosh/windfarm_rm31.c
b/drivers/macintosh/windfarm_rm31.c
index 0b9a79b..82fc86a 100644
--- a/drivers/macintosh/windfarm_rm31.c
+++ b/drivers/macintosh/windfarm_rm31.c
@@ -439,15 +439,15 @@ static void backside_setup_pid(void)
/* Slots fan */
static const struct wf_pid_param slots_param = {
- .interval = 5,
- .history_len= 2,
- .gd = 30 20,
- .gp = 5 20,
- .gr = 0,
- .itarget= 40 16,
- .additive = 1,
- .min= 300,
- .max= 4000,
+ .interval = 1,
+ .history_len= 20,
+ .gd = 0,
+ .gp = 0,
+ .gr = 0x0010,
+ .itarget= 320,
+ .additive = 0,
+ .min= 20,
+ .max= 100,
};
static void slots_fan_tick(void)
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
[PATCH] powerpc/windfarm: fix noisy slots-fan on Xserve (rm31)
slots-fan on G5 Xserve is always running at full speed with windfarm_rm31
driver, resulting in a very high acoustic noise level. It seems the fan
parameters are incorrect, and have been copied from the Drive Bay fan
(RPM, not present on rm31) of the legacy therm_pm72 driver. This patch
changes the parameters to match the Slots fan (PWM) of therm_pm72. With
the patch, slots-fan speed drops from 99% to 19% during normal use,
and slots-temp settle to ~42'C.
Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi
---
drivers/macintosh/windfarm_rm31.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/macintosh/windfarm_rm31.c
b/drivers/macintosh/windfarm_rm31.c
index 0b9a79b..82fc86a 100644
--- a/drivers/macintosh/windfarm_rm31.c
+++ b/drivers/macintosh/windfarm_rm31.c
@@ -439,15 +439,15 @@ static void backside_setup_pid(void)
/* Slots fan */
static const struct wf_pid_param slots_param = {
- .interval = 5,
- .history_len= 2,
- .gd = 30 20,
- .gp = 5 20,
- .gr = 0,
- .itarget= 40 16,
- .additive = 1,
- .min= 300,
- .max= 4000,
+ .interval = 1,
+ .history_len= 20,
+ .gd = 0,
+ .gp = 0,
+ .gr = 0x0010,
+ .itarget= 320,
+ .additive = 0,
+ .min= 20,
+ .max= 100,
};
static void slots_fan_tick(void)
--
1.8.3.2
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
