Re: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread “tiejun.chen”
On 08/01/2013 07:12 PM, Bharat Bhushan wrote: KVM uses same WIM tlb attributes as the corresponding qemu pte. For this we now search the linux pte for the requested page and get these cache caching/coherency attributes from pte. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com ---

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread “tiejun.chen”
On 08/01/2013 07:12 PM, Bharat Bhushan wrote: KVM need to lookup linux pte for getting TLB attributes (WIMGE). This is similar to how book3s does. This will be used in follow-up patches. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- v1-v2 - This is a new change in this

Re: [PATCH 3/6 v2] kvm: powerpc: allow guest control G attribute in mas2

2013-08-02 Thread “tiejun.chen”
On 08/01/2013 07:12 PM, Bharat Bhushan wrote: G bit in MAS2 indicates whether the page is Guarded. There is no reason to stop guest setting E, so allow him. Could we merge patch 2 and 3 into only one. Tiejun Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- v1-v2 - no

[PATCH v4 1/3] powerpc/85xx: Add SEC6.0 device tree

2013-08-02 Thread Po Liu
From: Mingkai Hu mingkai...@freescale.com Add device tree for SEC 6.0 used on C29x silicon. Signed-off-by: Mingkai Hu mingkai...@freescale.com Signed-off-by: Po Liu po@freescale.com --- Changes for v2: - Remove the compatible sec v4.0/v4.4/v5.0; - Add the device tree binding

[PATCH v4 2/3] powerpc/85xx: Add silicon device tree for C293

2013-08-02 Thread Po Liu
From: Mingkai Hu mingkai...@freescale.com Signed-off-by: Mingkai Hu mingkai...@freescale.com Signed-off-by: Po Liu po@freescale.com --- Changes for v2: - None Changes for v3: - None Changes for v4: - None arch/powerpc/boot/dts/fsl/c293si-post.dtsi | 193

[PATCH v4 3/3] powerpc/85xx: Add C293PCIE board support

2013-08-02 Thread Po Liu
From: Mingkai Hu mingkai...@freescale.com C293PCIE board is a series of Freescale PCIe add-in cards to perform as public key crypto accelerator or secure key management module. - 512KB platform SRAM in addition to 512K L2 Cache/SRAM - 512MB soldered DDR3 32bit memory - CPLD System Logic -

[PATCH] powerpc/pci: Change the DECLARE_PCI_FIXUP_{HEADER = EARLY} macro of pci quirk

2013-08-02 Thread Chunhe Lan
Freescale platform has class code = 0x0b2000, when it boots. This makes kernel PCI bus code to setup these devices resulting into the following notice information when trying to enable them: pci :00:00.0: ignoring class 0x0b2000 (doesn't match header type 01) The above information is

Re: therm_pm72 units, interface

2013-08-02 Thread Michel Dänzer
On Sam, 2013-07-20 at 23:33 +0300, Aaro Koskinen wrote: Hi, On Sat, Jul 20, 2013 at 09:16:49AM +1000, Benjamin Herrenschmidt wrote: On Fri, 2013-07-19 at 20:43 +0300, Aaro Koskinen wrote: I booted a Xserve today with 3.11-rc1, and noticed the noise is coming from slots-fan (PCI fan?)

Re: [linux-pm] [PATCH 1/3] cpuidle/powernv: cpuidle backend driver for powernv

2013-08-02 Thread Preeti U Murthy
Hi Daniel, On 07/27/2013 10:57 AM, Daniel Lezcano wrote: On 07/23/2013 11:01 AM, Deepthi Dharwar wrote: This patch implements a back-end cpuidle driver for powernv calling power7_nap and snooze idle states. This can be extended by adding more idle states in the future to the existing

Re: therm_pm72 units, interface

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 12:03 +0200, Michel Dänzer wrote: Could a similar change fix the same problem on desktop G5s? The same values for slots_param in windfarm_pm112.c don't help, unfortunately. You have a 11,2 and a noisy fan ? Odd, mine(s) don't I can dbl check the values vs. what Darwin

[PATCH v2 0/2] drivers/crypto/nx: fixes when input data is too large

2013-08-02 Thread Marcelo Cerri
This series of patches fixes two bugs that are triggered when the input data is too large. The first one is caused by the miscalculation of physical addresses and the second one by some limits that the co-processor has to the input data. Changes in v2: * Replace Signed-Off-By tags with

[PATCH v2 1/2] drivers/crypto/nx: fix physical addresses added to sg lists

2013-08-02 Thread Marcelo Cerri
The co-processor receives data to be hashed through scatter/gather lists pointing to physical addresses. When a vmalloc'ed data is given, the driver must calculate the physical address to each page of the data. However the current version of it just calculates the physical address once and keeps

[PATCH v2 2/2] drivers/crypto/nx: fix limits to sg lists for SHA-2

2013-08-02 Thread Marcelo Cerri
The co-processor has several limits regarding the length of scatter/gather lists and the total number of bytes in it. These limits are available in the device tree, as following: - ibm,max-sg-len: maximum number of bytes of each scatter/gather list. - ibm,max-sync-cop: used for synchronous

Re: therm_pm72 units, interface

2013-08-02 Thread Michel Dänzer
On Fre, 2013-08-02 at 22:51 +1000, Benjamin Herrenschmidt wrote: On Fri, 2013-08-02 at 12:03 +0200, Michel Dänzer wrote: Could a similar change fix the same problem on desktop G5s? The same values for slots_param in windfarm_pm112.c don't help, unfortunately. You have a 11,2 and a noisy

Re: Inbound PCI and Memory Corruption

2013-08-02 Thread Peter LaDow
On Wed, Jul 24, 2013 at 11:13 PM, Peter LaDow pet...@gocougs.wsu.edu wrote: There are other items, such as drivers for our custom hardware modules implemented on the FPGA. Perhaps I'll pull our drivers and run a stock kernel. Maybe a stock 83xx configuration (such as the MPC8349E-MITX). If

Re: therm_pm72 units, interface

2013-08-02 Thread Aaro Koskinen
On Fri, Aug 02, 2013 at 04:47:51PM +0200, Michel Dänzer wrote: On Fre, 2013-08-02 at 22:51 +1000, Benjamin Herrenschmidt wrote: On Fri, 2013-08-02 at 12:03 +0200, Michel Dänzer wrote: Could a similar change fix the same problem on desktop G5s? The same values for slots_param in

Re: therm_pm72 units, interface

2013-08-02 Thread Michel Dänzer
On Fre, 2013-08-02 at 18:58 +0300, Aaro Koskinen wrote: On Fri, Aug 02, 2013 at 04:47:51PM +0200, Michel Dänzer wrote: On Fre, 2013-08-02 at 22:51 +1000, Benjamin Herrenschmidt wrote: On Fri, 2013-08-02 at 12:03 +0200, Michel Dänzer wrote: Could a similar change fix the same problem on

Re: [PATCH 1/8] register bootmem pages for powerpc when sparse vmemmap is not defined

2013-08-02 Thread Nathan Fontenot
On 08/01/2013 09:27 PM, Michael Ellerman wrote: On Wed, Jul 24, 2013 at 01:35:11PM -0500, Nathan Fontenot wrote: Previous commit 46723bfa540... introduced a new config option HAVE_BOOTMEM_INFO_NODE that ended up breaking memory hot-remove for powerpc when sparse vmemmap is not defined. So

Re: [PATCH 2/8] Mark powerpc memory resources as busy

2013-08-02 Thread Nathan Fontenot
On 08/01/2013 09:28 PM, Michael Ellerman wrote: On Wed, Jul 24, 2013 at 01:36:34PM -0500, Nathan Fontenot wrote: Memory I/O resources need to be marked as busy or else we cannot remove them when doing memory hot remove. I would have thought it was the opposite? Me too. As it turns out the

windfarm_fcu_controls: cpu-pump-0 HW FAULT

2013-08-02 Thread Andreas Schwab
wf_fcu_fan_get_rpm is returning EFAULT when reading the values for the cpu pump controls on the PowerMac7,3. Also, wf_fcu_get_pump_minmax is unable to get the real limits and falls back to using the defaults. Here is the output when DEBUG is defined: wf_fcu: FCU Initialized, RPM fan shift is 3

Re: [PATCH 3/8] Add all memory via sysfs probe interface at once

2013-08-02 Thread Nathan Fontenot
On 08/01/2013 09:32 PM, Michael Ellerman wrote: On Wed, Jul 24, 2013 at 01:37:47PM -0500, Nathan Fontenot wrote: When doing memory hot add via the 'probe' interface in sysfs we do not need to loop through and add memory one section at a time. I think this was originally done for powerpc, but

Re: [PATCH V3 0/3] networking: Use ETH_ALEN where appropriate

2013-08-02 Thread David Miller
From: Joe Perches j...@perches.com Date: Thu, 1 Aug 2013 16:17:46 -0700 Convert the uses mac addresses to ETH_ALEN so it's easier to find and verify where mac addresses need to be __aligned(2) Series applied to net-next, thanks. ___ Linuxppc-dev

Re: therm_pm72 units, interface

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 16:47 +0200, Michel Dänzer wrote: On Fre, 2013-08-02 at 22:51 +1000, Benjamin Herrenschmidt wrote: On Fri, 2013-08-02 at 12:03 +0200, Michel Dänzer wrote: Could a similar change fix the same problem on desktop G5s? The same values for slots_param in windfarm_pm112.c

Re: therm_pm72 units, interface

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 18:52 +0200, Michel Dänzer wrote: Thanks for the suggestion. The same windfarm modules were loaded in both cases, but i2c_powermac wasn't loaded with the newer kernels. Loading it manually fixes the problem. How is i2c_powermac supposed to get loaded with current

Re: therm_pm72 units, interface

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 22:56 +0200, Ben Hutchings wrote: Yes. Do you have all the windfarm modules loaded ? What about i2c-powermac ? (It's typical that the latter is missed, I think it doesn't auto-load, which we never fixed, we used to request distros to just built it in) We built it

Re: [PATCH] drivers/crypto/nx: saves chaining value from co-processor

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 15:58 -0500, Fionnuala Gunter wrote: The chaining value from co-processor was not being saved. This value is needed because it is used as the IV, for example by cts i.e. cts(cbc(aes)). Signed-off-by: Fionnuala Gunter f...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri

Re: therm_pm72 units, interface

2013-08-02 Thread Ben Hutchings
On Sat, 2013-08-03 at 06:47 +1000, Benjamin Herrenschmidt wrote: On Fri, 2013-08-02 at 16:47 +0200, Michel Dänzer wrote: On Fre, 2013-08-02 at 22:51 +1000, Benjamin Herrenschmidt wrote: On Fri, 2013-08-02 at 12:03 +0200, Michel Dänzer wrote: Could a similar change fix the same problem on

[PATCH] drivers/crypto/nx: saves chaining value from co-processor

2013-08-02 Thread Fionnuala Gunter
The chaining value from co-processor was not being saved. This value is needed because it is used as the IV, for example by cts i.e. cts(cbc(aes)). Signed-off-by: Fionnuala Gunter f...@linux.vnet.ibm.com Signed-off-by: Marcelo Cerri mhce...@linux.vnet.ibm.com --- drivers/crypto/nx/nx-aes-cbc.c |

Re: [PATCH 00/11] Add compression support to pstore

2013-08-02 Thread Tony Luck
On Thu, Aug 1, 2013 at 4:42 PM, Luck, Tony tony.l...@intel.com wrote: when I rebuilt a plain 3.11-rc3 it didn't log anything via pstore either :-( Well this turned out to be operator error on my part. 3.11-rc3 does in fact log errors to pstore and allows them to be retrieved and cleared. So

Re: [PATCH] drivers/crypto/nx: saves chaining value from co-processor

2013-08-02 Thread Fionnuala Gunter
On Sat, 2013-08-03 at 07:09 +1000, Benjamin Herrenschmidt wrote: On Fri, 2013-08-02 at 15:58 -0500, Fionnuala Gunter wrote: The chaining value from co-processor was not being saved. This value is needed because it is used as the IV, for example by cts i.e. cts(cbc(aes)). Signed-off-by:

Re: [PATCH] drivers/crypto/nx: saves chaining value from co-processor

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 16:55 -0500, Fionnuala Gunter wrote: Sorry, I thought linuxppc-dev was the right tree since the patch is for a ppc driver and you've carried previous nx driver submissions upstream. I want to submit to the proper place, so what is your preference? Well, that's the

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-08-02 Thread Mike Turquette
Quoting Nicolas Pitre (2013-07-18 10:47:22) On Thu, 18 Jul 2013, Russell King - ARM Linux wrote: 1. clk_get() and clk_put() are NOT part of the common clock API. They're separate - they're part of the clk API, and the infrastructure behind that is clkdev, which is a separately owned

Re: windfarm_fcu_controls: cpu-pump-0 HW FAULT

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 21:08 +0200, Andreas Schwab wrote: wf_fcu_fan_get_rpm is returning EFAULT when reading the values for the cpu pump controls on the PowerMac7,3. Also, wf_fcu_get_pump_minmax is unable to get the real limits and falls back to using the defaults. Here is the output when

Re: [PATCH 00/11] Add compression support to pstore

2013-08-02 Thread Tony Luck
A quick experiment to use your patchset - but with compression disabled by tweaking this line in pstore_dump(): zipped_len = -1; //zip_data(dst, hsize + len); turned out well. This kernel dumps uncompressed dmesg blobs into pstore and gets them back out again. So it seems likely that the

Re: [PATCH] drivers/crypto/nx: saves chaining value from co-processor

2013-08-02 Thread Fionnuala Gunter
On Sat, 2013-08-03 at 07:59 +1000, Benjamin Herrenschmidt wrote: On Fri, 2013-08-02 at 16:55 -0500, Fionnuala Gunter wrote: Sorry, I thought linuxppc-dev was the right tree since the patch is for a ppc driver and you've carried previous nx driver submissions upstream. I want to

[git pull] Please pull powerpc.git merge branch

2013-08-02 Thread Benjamin Herrenschmidt
[ resent in case you missed it ] Hi Linus ! Here is not quite a handful of powerpc fixes for rc3. The windfarm fix is a regression fix (though not a new one), the PMU interrupt rename is not a fix per-se but has been submitted a long time ago and I kept forgetting to put it in (it puts us back

Re: [PATCH v3 13/31] clk: wrap I/O access for improved portability

2013-08-02 Thread Mike Turquette
Quoting Gerhard Sittig (2013-07-22 05:14:40) the common clock drivers were motivated/initiated by ARM development and apparently assume little endian peripherals wrap register/peripherals access in the common code (div, gate, mux) in preparation of adding COMMON_CLK support for other

Re: [PATCH v3 15/31] dts: mpc512x: introduce dt-bindings/clock/ header

2013-08-02 Thread Mike Turquette
Quoting Gerhard Sittig (2013-07-22 05:14:42) introduce a dt-bindings/ header file for MPC512x clocks, providing symbolic identifiers for those SoC clocks which clients will reference from their device tree nodes Signed-off-by: Gerhard Sittig g...@denx.de ---

Re: [PATCH v3 16/31] dts: mpc512x: add clock related device tree specs

2013-08-02 Thread Mike Turquette
Quoting Gerhard Sittig (2013-07-22 05:14:43) this addresses the clock driver aka provider's side of clocks - prepare for future 'clks ID' phandle references for device tree based clock lookup in client drivers - introduce a 'clocks' subtree with an 'osc' node for the crystal or oscillator

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Scott Wood
On Thu, 2013-08-01 at 16:42 +0530, Bharat Bhushan wrote: KVM need to lookup linux pte for getting TLB attributes (WIMGE). This is similar to how book3s does. This will be used in follow-up patches. Signed-off-by: Bharat Bhushan bharat.bhus...@freescale.com --- v1-v2 - This is a new

Re: [PATCH v3 17/31] clk: mpc512x: introduce COMMON_CLK for MPC512x

2013-08-02 Thread Mike Turquette
Quoting Gerhard Sittig (2013-07-23 06:14:06) [ summary: shared gate support desirable? approach acceptable? ] On Mon, Jul 22, 2013 at 14:14 +0200, Gerhard Sittig wrote: this change implements a clock driver for the MPC512x PowerPC platform which follows the COMMON_CLK approach and uses

Re: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread Scott Wood
On Thu, Aug 01, 2013 at 04:42:38PM +0530, Bharat Bhushan wrote: diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index 17722d8..eb2 100644 --- a/arch/powerpc/kvm/booke.c +++ b/arch/powerpc/kvm/booke.c @@ -697,7 +697,7 @@ int kvmppc_vcpu_run(struct kvm_run *kvm_run, struct

Re: [PATCH v3 18/31] dts: mpc512x: add clock specs for client lookups

2013-08-02 Thread Mike Turquette
Quoting Gerhard Sittig (2013-07-22 05:14:45) this addresses the client side of device tree based clock lookups add clock specifiers to the mbx, nfc, mscan, sdhc, i2c, axe, diu, viu, mdio, fec, usb, pata, psc, psc fifo, and pci nodes in the shared mpc5121.dtsi include these specs map

Re: [PATCH v3 17/31] clk: mpc512x: introduce COMMON_CLK for MPC512x

2013-08-02 Thread Mike Turquette
Quoting Gerhard Sittig (2013-07-22 05:14:44) this change implements a clock driver for the MPC512x PowerPC platform which follows the COMMON_CLK approach and uses common clock drivers shared with other platforms this driver implements the publicly announced set of clocks (which can get

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Benjamin Herrenschmidt
On Fri, 2013-08-02 at 17:58 -0500, Scott Wood wrote: What about 64-bit PTEs on 32-bit kernels? In any case, this code does not belong in KVM. It should be in the main PPC mm code, even if KVM is the only user. Also don't we do similar things in BookS KVM ? At the very least that sutff

RE: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Bhushan Bharat-R65777
-Original Message- From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] Sent: Saturday, August 03, 2013 4:47 AM To: Wood Scott-B07421 Cc: Bhushan Bharat-R65777; ag...@suse.de; kvm-...@vger.kernel.org; k...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Bhushan

RE: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread Bhushan Bharat-R65777
-Original Message- From: Wood Scott-B07421 Sent: Saturday, August 03, 2013 5:05 AM To: Bhushan Bharat-R65777 Cc: b...@kernel.crashing.org; ag...@suse.de; kvm-...@vger.kernel.org; k...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Bhushan Bharat-R65777 Subject: Re: [PATCH 6/6 v2]

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-02 Thread Benjamin Herrenschmidt
On Sat, 2013-08-03 at 02:58 +, Bhushan Bharat-R65777 wrote: One of the problem I saw was that if I put this code in asm/pgtable-32.h and asm/pgtable-64.h then pte_persent() and other friend function (on which this code depends) are defined in pgtable.h. And pgtable.h includes

Re: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-02 Thread Benjamin Herrenschmidt
On Sat, 2013-08-03 at 03:11 +, Bhushan Bharat-R65777 wrote: Could you explain why we need to set dirty/referenced on the PTE, when we didn't need to do that before? All we're getting from the PTE is wimg. We have MMU notifiers to take care of the page being unmapped, and we've