Re: Failure to detect PCI card

2013-08-05 Thread David Hawkins
Hi Pete, On Mon, Aug 5, 2013 at 4:07 PM, Peter LaDow wrote: However, replacing the 82540 based card with either a 3com 3C905TXM or the Netgear FA331, there is no response on the 0x10 IDSEL line. Thus it appears these cards are NOT responding to configuration reads. I think I have to break ou

Re: [PATCH v2 7/8] powerpc/fsl_booke: make sure PAGE_OFFSET map to memstart_addr for relocatable kernel

2013-08-05 Thread Kevin Hao
On Mon, Aug 05, 2013 at 07:14:00PM -0500, Scott Wood wrote: > On Thu, 2013-07-04 at 20:54 +0800, Kevin Hao wrote: > > @@ -1222,6 +1266,9 @@ _GLOBAL(switch_to_as1) > > /* > > * Restore to the address space 0 and also invalidate the tlb entry created > > * by switch_to_as1. > > + * r3 - the tlb

Re: [PATCH v2 7/8] powerpc/fsl_booke: make sure PAGE_OFFSET map to memstart_addr for relocatable kernel

2013-08-05 Thread Kevin Hao
On Mon, Aug 05, 2013 at 07:10:06PM -0500, Scott Wood wrote: > On Sun, 2013-08-04 at 08:50 +0800, Kevin Hao wrote: > > On Fri, Jul 26, 2013 at 07:17:57PM -0500, Scott Wood wrote: > > > >diff --git a/arch/powerpc/mm/fsl_booke_mmu.c > > > >b/arch/powerpc/mm/fsl_booke_mmu.c > > > >index 8f60ef8..dd283f

Re: [PATCH v2 6/8] powerpc: introduce early_get_first_memblock_info

2013-08-05 Thread Kevin Hao
On Mon, Aug 05, 2013 at 06:59:28PM -0500, Scott Wood wrote: > On Sun, 2013-08-04 at 08:45 +0800, Kevin Hao wrote: > > memblock_add(base, size); > > } > > I think it'd be clearer for it to be an external variable that gets set > by the relocation code -- plus, the above wouldn't work if thi

RE: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-05 Thread Bhushan Bharat-R65777
> -Original Message- > From: Wood Scott-B07421 > Sent: Tuesday, August 06, 2013 12:49 AM > To: Bhushan Bharat-R65777 > Cc: Benjamin Herrenschmidt; Wood Scott-B07421; ag...@suse.de; kvm- > p...@vger.kernel.org; k...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > Subject: Re: [PATCH 5/6 v

Re: [PATCH v2 7/8] powerpc/fsl_booke: make sure PAGE_OFFSET map to memstart_addr for relocatable kernel

2013-08-05 Thread Scott Wood
On Thu, 2013-07-04 at 20:54 +0800, Kevin Hao wrote: > @@ -1222,6 +1266,9 @@ _GLOBAL(switch_to_as1) > /* > * Restore to the address space 0 and also invalidate the tlb entry created > * by switch_to_as1. > + * r3 - the tlb entry which should be invalidated > + * r4 - __pa(PAGE_OFFSET in AS0) -

Re: [PATCH v2 7/8] powerpc/fsl_booke: make sure PAGE_OFFSET map to memstart_addr for relocatable kernel

2013-08-05 Thread Scott Wood
On Sun, 2013-08-04 at 08:50 +0800, Kevin Hao wrote: > On Fri, Jul 26, 2013 at 07:17:57PM -0500, Scott Wood wrote: > > >diff --git a/arch/powerpc/mm/fsl_booke_mmu.c > > >b/arch/powerpc/mm/fsl_booke_mmu.c > > >index 8f60ef8..dd283fd 100644 > > >--- a/arch/powerpc/mm/fsl_booke_mmu.c > > >+++ b/arch/po

Re: [PATCH v2 6/8] powerpc: introduce early_get_first_memblock_info

2013-08-05 Thread Scott Wood
On Sun, 2013-08-04 at 08:45 +0800, Kevin Hao wrote: > On Fri, Jul 26, 2013 at 07:18:01PM -0500, Scott Wood wrote: > > >+ * This function run before early_init_devtree, so we have to init > > >+ * initial_boot_params. Since early_init_dt_scan_memory_ppc will be > > >+ * executed again in early_init_

Re: Failure to detect PCI card

2013-08-05 Thread Peter LaDow
On Mon, Aug 5, 2013 at 4:07 PM, Peter LaDow wrote: > However, replacing the 82540 based card with either a 3com 3C905TXM or > the Netgear FA331, there is no response on the 0x10 IDSEL line. Thus > it appears these cards are NOT responding to configuration reads. I > think I have to break out the

Re: Failure to detect PCI card

2013-08-05 Thread Peter LaDow
On Mon, Aug 5, 2013 at 1:27 PM, David Hawkins wrote: > 2. Have you probed the PCI bus using a bus analyzer or scope? Ok. I managed to find someone with a bus extender, and have connected both our analyzer and card. With a working card (the 82540EM based card), I see configuration reads on 0x000

Re: [PATCH] Add device file bindings for MAPLE

2013-08-05 Thread Kumar Gala
On Aug 5, 2013, at 4:11 PM, Scott Wood wrote: > On Thu, 2013-08-01 at 11:05 -0500, Kumar Gala wrote: >> On Aug 1, 2013, at 6:02 AM, Shaveta Leekha wrote: >> >>> Signed-off-by: Shaveta Leekha >>> --- >>> .../devicetree/bindings/powerpc/fsl/maple.txt | 30 >>> >>> 1 fi

Re: [PATCH] Add device file bindings for MAPLE

2013-08-05 Thread Scott Wood
On Thu, 2013-08-01 at 16:32 +0530, Shaveta Leekha wrote: > Signed-off-by: Shaveta Leekha > --- > .../devicetree/bindings/powerpc/fsl/maple.txt | 30 > > 1 files changed, 30 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/powerpc/f

Re: Failure to detect PCI card

2013-08-05 Thread Peter LaDow
On Mon, Aug 5, 2013 at 2:08 PM, David Hawkins wrote: > My analyzer has an extender card that you first plug in, and then > plug the board into that ... any chance someone in your organization > has one of those cards? Alternatively, confirm the board works in > a machine that has more than one slo

Re: [PATCH 00/11] Add compression support to pstore

2013-08-05 Thread Tony Luck
This patch seems to fix the garbage at the end problem. Booting an old kernel and using openssl decodes them OK. Still have problems booting if there are any compressed images in ERST to be inflated. -Tony ___ Linuxppc-dev mailing list Linuxppc-dev@lis

Re: Failure to detect PCI card

2013-08-05 Thread David Hawkins
Hi Pete, Actually, before going down that route, I would get a PCI extender that you can use to trace the traffic with your board. Does the network card use 33MHz or 66MHz? I wonder if something like this board: http://www.logicsupply.com/products/pci122_dflex can be used to make a single P

Re: [PATCH] Add device file bindings for MAPLE

2013-08-05 Thread Scott Wood
On Thu, 2013-08-01 at 11:05 -0500, Kumar Gala wrote: > On Aug 1, 2013, at 6:02 AM, Shaveta Leekha wrote: > > > Signed-off-by: Shaveta Leekha > > --- > > .../devicetree/bindings/powerpc/fsl/maple.txt | 30 > > > > 1 files changed, 30 insertions(+), 0 deletions(-) > > cr

Re: Failure to detect PCI card

2013-08-05 Thread David Hawkins
Hi Pete, 1. Have you checked the power supplies on the PCI board? PCI boards can be powered from 3.3V or 5V, or both. I've had old PCs that only supply one or the other rail, and various evaluation boards that only supply 3.3V. If you can put together a "working" x86 setup that

Re: Failure to detect PCI card

2013-08-05 Thread Peter LaDow
On Mon, Aug 5, 2013 at 1:27 PM, David Hawkins wrote: > 1. Have you checked the power supplies on the PCI board? > >PCI boards can be powered from 3.3V or 5V, or both. I've had >old PCs that only supply one or the other rail, and various >evaluation boards that only supply 3.3V. > >

Re: Failure to detect PCI card

2013-08-05 Thread David Hawkins
Hi Pete, On Mon, Aug 5, 2013 at 11:25 AM, Anatolij Gustschin wrote: Maybe this card needs bigger delay to respond after PCI reset. You can try to re-build U-Boot with defined CONFIG_PCI_BOOTDELAY. Use 1000 for CONFIG_PCI_BOOTDELAY in the first step and if detection works, try to decrease this

Re: Failure to detect PCI card

2013-08-05 Thread Peter LaDow
On Mon, Aug 5, 2013 at 11:25 AM, Anatolij Gustschin wrote: > Maybe this card needs bigger delay to respond after PCI reset. You can > try to re-build U-Boot with defined CONFIG_PCI_BOOTDELAY. Use 1000 > for CONFIG_PCI_BOOTDELAY in the first step and if detection works, > try to decrease this value

[PATCH v3 1/2] powerpc: Add smp_generic_cpu_bootable

2013-08-05 Thread Andy Fleming
Cell and PSeries both implemented their own versions of a cpu_bootable smp_op which do the same thing (well, the PSeries one has support for more than 2 threads). Copy the PSeries one to generic code, and rename it smp_generic_cpu_bootable. Signed-off-by: Andy Fleming --- v3: Removed EXPORT_SYMBO

[PATCH v3 2/2] powerpc: Convert platforms to smp_generic_cpu_bootable

2013-08-05 Thread Andy Fleming
T4, Cell, powernv, and pseries had the same implementation, so switch them to use a generic version. A2 apparently had a version, but removed it at some point, so we remove the declaration, too. Signed-off-by: Andy Fleming --- v3: No change v2: Removed Change-Id arch/powerpc/platforms/85xx/smp.

Re: [PATCH 00/11] Add compression support to pstore

2013-08-05 Thread Aruna Balakrishnaiah
Hi Tony, On Monday 05 August 2013 11:52 PM, Tony Luck wrote: See attachment for what I actually applied - I think I got what you suggested (I added a declaration for "total_len"). Forcing a panic worked some things were logged to pstore. But on reboot with your patches applied I'm still seeing

Re: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-05 Thread Scott Wood
On Mon, 2013-08-05 at 09:27 -0500, Bhushan Bharat-R65777 wrote: > > > -Original Message- > > From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] > > Sent: Saturday, August 03, 2013 9:54 AM > > To: Bhushan Bharat-R65777 > > Cc: Wood Scott-B07421; ag...@suse.de; kvm-...@vger.kerne

Re: Failure to detect PCI card

2013-08-05 Thread Peter LaDow
On Mon, Aug 5, 2013 at 11:25 AM, Anatolij Gustschin wrote: > Maybe this card needs bigger delay to respond after PCI reset. You can > try to re-build U-Boot with defined CONFIG_PCI_BOOTDELAY. Use 1000 > for CONFIG_PCI_BOOTDELAY in the first step and if detection works, > try to decrease this value

Re: Failure to detect PCI card

2013-08-05 Thread Wolfgang Denk
Dear Peter LaDow, In message you wrote: > I have a PCI card (a Netgear FA331, vendor:device 100b:0020) that is > failing to be detected by our PPC platform. This device works just > fine in a PC, and other cards work just fine in the same PCI slot (we > have an Intel 82540EM based card that wor

Re: Failure to detect PCI card

2013-08-05 Thread Anatolij Gustschin
On Mon, 5 Aug 2013 10:58:01 -0700 Peter LaDow wrote: > I have a PCI card (a Netgear FA331, vendor:device 100b:0020) that is > failing to be detected by our PPC platform. This device works just > fine in a PC, and other cards work just fine in the same PCI slot (we > have an Intel 82540EM based c

Re: [PATCH 00/11] Add compression support to pstore

2013-08-05 Thread Tony Luck
See attachment for what I actually applied - I think I got what you suggested (I added a declaration for "total_len"). Forcing a panic worked some things were logged to pstore. But on reboot with your patches applied I'm still seeing a GP fault when pstore is mounted and we find compressed record

Failure to detect PCI card

2013-08-05 Thread Peter LaDow
I have a PCI card (a Netgear FA331, vendor:device 100b:0020) that is failing to be detected by our PPC platform. This device works just fine in a PC, and other cards work just fine in the same PCI slot (we have an Intel 82540EM based card that works). But for some reason, neither u-boot nor the k

Re: [PATCH 03/10] vfio: add external user support

2013-08-05 Thread Alex Williamson
On Tue, 2013-07-23 at 19:07 +1000, Alexey Kardashevskiy wrote: > On 07/23/2013 12:23 PM, Alex Williamson wrote: > > On Tue, 2013-07-16 at 10:53 +1000, Alexey Kardashevskiy wrote: > >> VFIO is designed to be used via ioctls on file descriptors > >> returned by VFIO. > >> > >> However in some situati

Re: [PATCH v3 17/31] clk: mpc512x: introduce COMMON_CLK for MPC512x

2013-08-05 Thread Mike Turquette
Quoting Gerhard Sittig (2013-08-03 07:39:56) > [ we are strictly talking about clocks and source code again, > I have trimmed the CC: list to not spam the device tree ML or > subsystem maintainers ] > > On Fri, Aug 02, 2013 at 16:30 -0700, Mike Turquette wrote: > > > > Quoting Gerhard Sittig

Re: [PATCH 00/11] Add compression support to pstore

2013-08-05 Thread Aruna Balakrishnaiah
Hi Tony, Thank you very much for testing my patches. On Saturday 03 August 2013 03:42 AM, Tony Luck wrote: A quick experiment to use your patchset - but with compression disabled by tweaking this line in pstore_dump(): zipped_len = -1; //zip_data(dst, hsize + len); turned out well. This

Re: [PATCH v3 17/31] clk: mpc512x: introduce COMMON_CLK for MPC512x

2013-08-05 Thread Gerhard Sittig
On Mon, Aug 05, 2013 at 12:37 +0100, Mark Rutland wrote: > > On Mon, Jul 22, 2013 at 01:14:44PM +0100, Gerhard Sittig wrote: > > this change implements a clock driver for the MPC512x PowerPC platform > > which follows the COMMON_CLK approach and uses common clock drivers > > shared with other plat

Re: [PATCH 00/11] Add compression support to pstore

2013-08-05 Thread Tony Luck
One more experiment - removed previous hack that disabled compression. Added a new hack to skip decompression. System died cleanly when I forced a panic. On reboot I found 3 files in pstore: -r--r--r-- 1 root root 3972 Aug 5 09:24 dmesg-erst-5908671953186586625 -r--r--r-- 1 root root 2565 Aug

Re: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-05 Thread Scott Wood
On Fri, 2013-08-02 at 22:11 -0500, Bhushan Bharat-R65777 wrote: > > How does wimg get set in the pfnmap case? > > Pfnmap is not kernel managed pages, right? So should we set I+G there ? It could depend on ppc_md.phys_mem_access_prot(). Can't you pull it from the PTE regardless of pfnmap? -Scott

Re: [PATCH 6/6 v2] kvm: powerpc: use caching attributes as per linux pte

2013-08-05 Thread Scott Wood
On Sat, 2013-08-03 at 14:25 +1000, Benjamin Herrenschmidt wrote: > On Sat, 2013-08-03 at 03:11 +, Bhushan Bharat-R65777 wrote: > > > > > > > > Could you explain why we need to set dirty/referenced on the PTE, when we > > > didn't > > > need to do that before? All we're getting from the PTE i

Re: PCIE device errors after linux kernel upgrade

2013-08-05 Thread Bjorn Helgaas
[+cc linuxppc-dev] On Mon, Aug 5, 2013 at 5:17 AM, Leon Ravich wrote: > Hi all , > I am trying to upgrade ours embedded device (freescale powerPC P2020 cpu) > linux kernel , till now we used 2.6.32 I am trying to upgrade to 3.8.13 . > I took the source from freescale git: > git://git.freescale.c

Re: [PATCH v3 17/31] clk: mpc512x: introduce COMMON_CLK for MPC512x

2013-08-05 Thread Mark Rutland
On Mon, Jul 22, 2013 at 01:14:44PM +0100, Gerhard Sittig wrote: > this change implements a clock driver for the MPC512x PowerPC platform > which follows the COMMON_CLK approach and uses common clock drivers > shared with other platforms > > this driver implements the publicly announced set of clock

RE: [PATCH 5/6 v2] kvm: powerpc: booke: Add linux pte lookup like booke3s

2013-08-05 Thread Bhushan Bharat-R65777
> -Original Message- > From: Benjamin Herrenschmidt [mailto:b...@kernel.crashing.org] > Sent: Saturday, August 03, 2013 9:54 AM > To: Bhushan Bharat-R65777 > Cc: Wood Scott-B07421; ag...@suse.de; kvm-...@vger.kernel.org; > k...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org > Subject: Re:

Re: [PATCH v3 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-05 Thread Nicolin Chen
Hi Philipp, Thanks for the comments! I'll revise it and send a v4. Here is my reply to some parts of your question. On Mon, Aug 05, 2013 at 12:07:02PM +0200, Philipp Zabel wrote: > This looks to me like a case of configuration data in the device tree. > Couldn't the tx/rx clock source be de

[PATCH v2 3/3] powerpc: Correctly context switch DSCR on POWER8

2013-08-05 Thread Michael Neuling
POWER8 allows the DSCR to be accessed directly from userspace via a new SPR number 0x3 (Rather than 0x11. DSCR SPR number 0x11 is still used on POWER8 but like POWER7, is only accessible in HV and OS modes). Currently, we allow this by setting H/FSCR DSCR bit on boot. Unfortunately this doesn't

Re: therm_pm72 units, interface

2013-08-05 Thread Benjamin Herrenschmidt
On Mon, 2013-08-05 at 12:32 +0200, Michel Dänzer wrote: > > I did that, sorry should have mentioned that. > > > > > @@ -468,5 +478,3 @@ static struct platform_driver > i2c_powermac_driver > > > = > > > { > > > }; > > > > > > module_platform_driver(i2c_powermac_driver); > > > - > > > -MODULE_A

Re: therm_pm72 units, interface

2013-08-05 Thread Michel Dänzer
On Mon, 2013-08-05 at 19:22 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2013-08-05 at 11:13 +0200, Michel Dänzer wrote: > > > The version below builds, but the module still doesn't get loaded > > automagically (unless I'm missing some command I need to run between > > copying the new module to

Re: [PATCH v3 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-05 Thread Philipp Zabel
Hi Nicolin, Am Montag, den 05.08.2013, 15:29 +0800 schrieb Nicolin Chen: > This patch add S/PDIF controller driver for Freescale SoC. > > Signed-off-by: Nicolin Chen > --- > .../devicetree/bindings/sound/fsl,spdif.txt| 62 + > sound/soc/fsl/Kconfig |3

Re: [PATCH 3/3] powerpc: Correctly context switch DSCR on POWER8

2013-08-05 Thread Michael Neuling
> > > }; > > > - char *facility, *prefix; > > > + char *facility; > > > u64 value; > > > + u8 status; > > > + bool hv; > > > > > > if (regs->trap == 0xf60) { > > > value = mfspr(SPRN_FSCR); > > > - prefix = ""; > > > + hv = false; > > > } else { > > > v

Re: [PATCH 3/3] powerpc: Correctly context switch DSCR on POWER8

2013-08-05 Thread Michael Neuling
Stephen Rothwell wrote: > [This time from a good email address :-)] > > Hi Mikey, > > On Mon, 5 Aug 2013 17:28:06 +1000 Michael Neuling > wrote: > > > > +++ b/arch/powerpc/kernel/traps.c > > @@ -1296,43 +1294,56 @@ void vsx_unavailable_exception(struct pt_regs *regs) > > die("Unrecoverabl

Re: therm_pm72 units, interface

2013-08-05 Thread Benjamin Herrenschmidt
On Mon, 2013-08-05 at 11:13 +0200, Michel Dänzer wrote: > > static struct platform_driver i2c_powermac_driver = { > > .probe = i2c_powermac_probe, > > .remove = i2c_powermac_remove, > > + .id_table = *i2c_powermac_id, > > This fails to build: > > CC [M] drivers/i2c/busses/i2c-

Re: therm_pm72 units, interface

2013-08-05 Thread Michel Dänzer
On Sam, 2013-08-03 at 07:02 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2013-08-02 at 18:52 +0200, Michel Dänzer wrote: > > > Thanks for the suggestion. The same windfarm modules were loaded in both > > cases, but i2c_powermac wasn't loaded with the newer kernels. Loading it > > manually fixes

Re: [PATCH 3/3] powerpc: Correctly context switch DSCR on POWER8

2013-08-05 Thread Stephen Rothwell
[This time from a good email address :-)] Hi Mikey, On Mon, 5 Aug 2013 17:28:06 +1000 Michael Neuling wrote: > > +++ b/arch/powerpc/kernel/traps.c > @@ -1296,43 +1294,56 @@ void vsx_unavailable_exception(struct pt_regs *regs) > die("Unrecoverable VSX Unavailable Exception", regs, SIGABRT)

[PATCH 3/3] powerpc: Correctly context switch DSCR on POWER8

2013-08-05 Thread Michael Neuling
POWER8 allows the DSCR to be accessed directly from userspace via a new SPR number 0x3 (Rather than 0x11. DSCR SPR number 0x11 is still used on POWER8 but like POWER7, is only accessible in HV and OS modes). Currently, we allow this by setting H/FSCR DSCR bit on boot. Unfortunately this doesn't

[PATCH 1/3] powerpc: Rework setting up H/FSCR bit definitions

2013-08-05 Thread Michael Neuling
This reworks the Facility Status and Control Regsiter (FSCR) config bit definitions so that we can access the bit numbers. This will be useful when looking at the status in the facility unavailable interrupt. HFSCR and FSCR versions are the same, so reuse them. Signed-off-by: Michael Neuling --

[PATCH 2/3] powerpc: Fix hypervisor facility unavaliable vector number

2013-08-05 Thread Michael Neuling
Currently if we take hypervisor facility unavaliable (from 0xf80/0x4f80) we mark it as an OS facility unavaliable (0xf60) as the two share the same code path. The becomes a problem in facility_unavailable_exception() as we aren't able to see the hypervisor facility unavailable exceptions. Below f

[PATCH v3 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-05 Thread Nicolin Chen
Add S/PDIF machine driver for Freescale i.MX series SoC. Signed-off-by: Nicolin Chen --- .../devicetree/bindings/sound/imx-audio-spdif.txt | 29 + sound/soc/fsl/Kconfig | 11 ++ sound/soc/fsl/Makefile |2 + sound/soc/fsl/imx-s

[PATCH v3 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-05 Thread Nicolin Chen
This patch add S/PDIF controller driver for Freescale SoC. Signed-off-by: Nicolin Chen --- .../devicetree/bindings/sound/fsl,spdif.txt| 62 + sound/soc/fsl/Kconfig |3 + sound/soc/fsl/Makefile |2 + sound/soc/fsl/fsl_spdi

[PATCH v3 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-05 Thread Nicolin Chen
Changelog: v2->v3: * Removed a wrong tag from the commit of patch-1. v1->v2: * Dropped one applied patch for spdif dummy codec drivers. * Use generic DMA DT binding. * Let spdif controller driver calculate the clock div. * Added one optional clock source for spdif tx. * Reivsed documentation

Re: [alsa-devel] [PATCH v2 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-05 Thread Nicolin Chen
On Mon, Aug 05, 2013 at 09:12:01AM +0200, Lars-Peter Clausen wrote: > You are supposed to only add tags (Acked-by, Reviewed-by, Signed-off-by, > etc.) for other people if they have explicitly said they are OK with it. > Reviewed-by means that the person has looked at the current patch and thinks >

Re: [alsa-devel] [PATCH v2 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-05 Thread Lars-Peter Clausen
On 08/05/2013 08:09 AM, Nicolin Chen wrote: > This patch add S/PDIF controller driver for Freescale SoC. > > Reviewed-by: Lars-Peter Clausen You are supposed to only add tags (Acked-by, Reviewed-by, Signed-off-by, etc.) for other people if they have explicitly said they are OK with it. Reviewed-