Re: [PATCHv2 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-11-06 Thread Shawn Guo
On Wed, Nov 06, 2013 at 03:53:24AM +, Li Xiubo wrote: If there are any comments that say PPC but are not PPC-specific, that should be fixed. Yes, find it. The comments is in sound/soc/fsl/Makefile : +++ # Freescale PowerPC SSI/DMA Platform Support ---

RE: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-06 Thread Li Xiubo
On VF610 series there are no regulators used, and now whether the CONFIG_REGULATOR mirco is enabled or not, for the VF610 audio patch series, the board cannot be probe successfully. And this patch will solve this issue. I don't understand what this is for at all, you're just saying

RE: [PATCHv2 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-11-06 Thread Li Xiubo
If there are any comments that say PPC but are not PPC-specific, that should be fixed. Yes, find it. The comments is in sound/soc/fsl/Makefile : +++ # Freescale PowerPC SSI/DMA Platform Support --- But fsl-spdif.o is also under it. And

[PATCH V6 1/2] powerpc/85xx: Add QE common init function

2013-11-06 Thread Xie Xiaobo
Define a QE init function in common file, and avoid the same codes being duplicated in board files. Signed-off-by: Xie Xiaobo x@freescale.com --- V6 - V5: add of_device_is_available check. V5 - V4: add the board files modification, remove the qe_pic_init. V4 - V3: Nochange

[PATCH V6 2/2] powerpc/85xx: Add TWR-P1025 board support

2013-11-06 Thread Xie Xiaobo
TWR-P1025 Overview - 512Mbyte DDR3 (on board DDR) 64MB Nor Flash eTSEC1: Connected to RGMII PHY AR8035 eTSEC3: Connected to RGMII PHY AR8035 Two USB2.0 Type A One microSD Card slot One mini-PCIe slot One mini-USB TypeB dual UART Signed-off-by: Michael Johnston

Re: [PATCHv2 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-11-06 Thread Mark Brown
On Tue, Nov 05, 2013 at 03:21:49AM +, Li Xiubo wrote: As your opinions, should I move the four register writing operations to .set_sysclk/set_clkdiv/... functions too ? Or just add a clk_disable_unprepare() after them here, and then add clk_prepare_enable in one of

Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-06 Thread Mark Brown
On Wed, Nov 06, 2013 at 08:59:53AM +, Li Xiubo wrote: Please fix your mailer to word wrap within paragraphs. The SGTL5000 is based on regulators and when it is disabled, there will be an error returns directly while the SGTL5000 codec is probing. What makes you say this? That's not how

Re: [PATCH] powerpc: memcpy optimization for 64bit LE

2013-11-06 Thread Philippe Bergheaud
Michael Neuling wrote: Philippe Bergheaud fe...@linux.vnet.ibm.com wrote: Unaligned stores take alignment exceptions on POWER7 running in little-endian. This is a dumb little-endian base memcpy that prevents unaligned stores. It is replaced by the VMX memcpy at boot. Is this any faster

Re: [RFC] arch: Introduce new TSO memory barrier smp_tmb()

2013-11-06 Thread Will Deacon
On Tue, Nov 05, 2013 at 06:49:43PM +, Peter Zijlstra wrote: On Tue, Nov 05, 2013 at 02:05:48PM +, Will Deacon wrote: + +#define smp_store_release(p, v) \ +do { \

Re: [PATCH 2/3] powerpc/kvm: fix rare but potential deadlock scene

2013-11-06 Thread Paul Mackerras
On Wed, Nov 06, 2013 at 02:02:07PM +0800, Liu ping fan wrote: On Wed, Nov 6, 2013 at 1:04 PM, Paul Mackerras pau...@samba.org wrote: On Tue, Nov 05, 2013 at 03:42:43PM +0800, Liu Ping Fan wrote: Since kvmppc_hv_find_lock_hpte() is called from both virtmode and realmode, so it can trigger

Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-06 Thread Alexander Graf
On 05.11.2013, at 08:42, Liu Ping Fan kernelf...@gmail.com wrote: Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com Patch description missing. Please add Paul's ack in the next revision of this patch :). Alex --- arch/powerpc/kvm/book3s_64_mmu_hv.c | 1 - 1 file changed, 1

Re: [RFC] arch: Introduce new TSO memory barrier smp_tmb()

2013-11-06 Thread Peter Zijlstra
Subject: arch: Introduce smp_load_acquire(), smp_store_release() From: Peter Zijlstra pet...@infradead.org Date: Mon, 4 Nov 2013 20:18:11 +0100 A number of situations currently require the heavyweight smp_mb(), even though there is no need to order prior stores against later loads. Many

Re: [RFC] arch: Introduce new TSO memory barrier smp_tmb()

2013-11-06 Thread Geert Uytterhoeven
On Wed, Nov 6, 2013 at 1:39 PM, Peter Zijlstra pet...@infradead.org wrote: Documentation/memory-barriers.txt | 157 +- arch/alpha/include/asm/barrier.h | 15 +++ arch/arc/include/asm/barrier.h| 15 +++ arch/arm/include/asm/barrier.h

Re: [RFC] arch: Introduce new TSO memory barrier smp_tmb()

2013-11-06 Thread Peter Zijlstra
On Wed, Nov 06, 2013 at 01:51:10PM +0100, Geert Uytterhoeven wrote: This is screaming for a default implementation in asm-generic. Right you are... how about a little something like this? There's a few archs I didn't fully merge with the generic one because of weird nop implementations. asm

Re: [RFC PATCH] ehci-platform: Merge ppc-of EHCI driver into the ehci-platform driver

2013-11-06 Thread Alan Stern
On Wed, 6 Nov 2013, Alistair Popple wrote: Currently the ppc-of driver uses the compatibility string usb-ehci. This means platforms that use device-tree and implement an EHCI compatible interface have to either use the ppc-of driver or add a compatible line to the ehci-platform driver. It

Re: [PATCH 3/7] IBM Akebono: Add support for a new PHY to the IBM emac driver

2013-11-06 Thread Ben Hutchings
On Wed, 2013-11-06 at 12:34 +1100, Alistair Popple wrote: On Tue, 5 Nov 2013 23:11:50 Ben Hutchings wrote: On Wed, 2013-11-06 at 06:54 +1100, Benjamin Herrenschmidt wrote: [snip] It's an SoC bit so there's little point making it generally selectable by the user. I think a better

Re: [PATCH v3 1/1] powerpc/embedded6xx: Add support for Motorola/Emerson MVME5100

2013-11-06 Thread Alessio Igor Bogani
On lun, 2013-11-04 at 08:07 +1100, Stephen Chivers wrote: Add support for the Motorola/Emerson MVME5100 Single Board Computer. The MVME5100 is a 6U form factor VME64 computer with: - A single MPC7410 or MPC750 CPU - A HAWK Processor Host Bridge (CPU to PCI) and

Re: [RFC] arch: Introduce new TSO memory barrier smp_tmb()

2013-11-06 Thread Paul E. McKenney
On Wed, Nov 06, 2013 at 02:57:36PM +0100, Peter Zijlstra wrote: On Wed, Nov 06, 2013 at 01:51:10PM +0100, Geert Uytterhoeven wrote: This is screaming for a default implementation in asm-generic. Right you are... how about a little something like this? There's a few archs I didn't fully

Re: [RFC] arch: Introduce new TSO memory barrier smp_tmb()

2013-11-06 Thread Peter Zijlstra
On Wed, Nov 06, 2013 at 10:48:48AM -0800, Paul E. McKenney wrote: A few nits on Documentation/memory-barriers.txt and some pointless comments elsewhere. With the suggested Documentation/memory-barriers.txt fixes: Reviewed-by: Paul E. McKenney paul...@linux.vnet.ibm.com Thanks, I think I'll

Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-06 Thread Benjamin Herrenschmidt
On Wed, 2013-11-06 at 12:24 +0100, Alexander Graf wrote: On 05.11.2013, at 08:42, Liu Ping Fan kernelf...@gmail.com wrote: Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com Patch description missing. Do you really need a description for trivial one-lines whose subject is a perfectly

Re: [PATCH V7 2/7] pseries/cpuidle: Use cpuidle_register() for initialisation.

2013-11-06 Thread Daniel Lezcano
On 10/29/2013 12:01 PM, Deepthi Dharwar wrote: This patch replaces the cpuidle driver and devices initialisation calls with a single generic cpuidle_register() call and also includes minor refactoring of the code around it. Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com Acked-by:

Re: [PATCH V7 3/7] pseries/cpuidle: Make pseries_idle backend driver a non-module.

2013-11-06 Thread Daniel Lezcano
On 10/29/2013 12:01 PM, Deepthi Dharwar wrote: Currently pseries_idle cpuidle backend driver cannot be built as a module due to dependencies. Therefore the driver has to be built in. The dependency is around update_snooze_delay() defined in cpuidle driver and called from kernel/sysfs.c. This

Re: [PATCH V7 4/7] pseries/cpuidle: Remove MAX_IDLE_STATE macro.

2013-11-06 Thread Daniel Lezcano
On 10/29/2013 12:01 PM, Deepthi Dharwar wrote: This patch removes the usage of MAX_IDLE_STATE macro and dead code around it. The number of states are determined at run time based on the cpuidle state table selected on a given platform Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com

Re: [PATCH V7 5/7] POWER/cpuidle: Generic POWER CPUIDLE driver supporting PSERIES.

2013-11-06 Thread Daniel Lezcano
On 10/29/2013 12:01 PM, Deepthi Dharwar wrote: This patch includes cleanup and refactoring of the existing code to make the driver POWER generic. * Re-naming the functions from pseries to generic power. * Re-naming the backend driver from pseries_idle to ibm-power-idle. Signed-off-by:

Re: [PATCH V7 6/7] POWER/cpuidle: Enable powernv cpuidle support.

2013-11-06 Thread Daniel Lezcano
On 10/29/2013 12:01 PM, Deepthi Dharwar wrote: The following patch extends the current power backend idle driver to the powernv platform. Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com Acked-by: Daniel Lezcano daniel.lezc...@linaro.org --- drivers/cpuidle/cpuidle-ibm-power.c |

Re: [PATCH V7 7/7] powernv/cpuidle: Enable idle powernv cpu to call into the cpuidle framework.

2013-11-06 Thread Daniel Lezcano
On 10/29/2013 12:02 PM, Deepthi Dharwar wrote: This patch enables idle cpu on the powernv platform to hook on to the cpuidle framework, if available, else call on to default idle platform code. Signed-off-by: Deepthi Dharwar deep...@linux.vnet.ibm.com Acked-by: Daniel Lezcano

Re: [PATCH v5 4/4] powerpc/85xx: add sysfs for pw20 state and altivec idle

2013-11-06 Thread Scott Wood
On Wed, 2013-11-06 at 01:50 -0600, Wang Dongsheng-B40534 wrote: -Original Message- From: Bhushan Bharat-R65777 Sent: Wednesday, November 06, 2013 1:25 PM To: Wang Dongsheng-B40534; Wood Scott-B07421 Cc: linuxppc-dev@lists.ozlabs.org Subject: RE: [PATCH v5 4/4] powerpc/85xx:

[PATCH 4/4] powerpc: ELF2 binaries signal handling

2013-11-06 Thread Rusty Russell
For the ELFv2 ABI, the hander is the entry point, not a function descriptor. We also need to set up r12, and fortunately the fast_exception_return exit path restores r12 for us so nothing else is required. Signed-off-by: Rusty Russell ru...@rustcorp.com.au --- arch/powerpc/kernel/signal_64.c |

[PATCH 3/4] powerpc: ELF2 binaries launched directly.

2013-11-06 Thread Rusty Russell
No function descriptor, but we set r12 up and set TIF_RESTOREALL as it normally isn't restored on return from syscall. Signed-off-by: Rusty Russell ru...@rustcorp.com.au --- arch/powerpc/kernel/process.c | 50 ++- 1 file changed, 35 insertions(+), 15

[PATCH 1/4] powerpc: Add TIF_ELF2ABI flag.

2013-11-06 Thread Rusty Russell
Little endian ppc64 is getting an exciting new ABI. This is reflected by the bottom two bits of e_flags in the ELF header: 0 == legacy binaries (v1 ABI) 1 == binaries using the old ABI (compiled with a new toolchain) 2 == binaries using the new ABI. We store this in a

[PATCH 2/4] powerpc: Set eflags correctly for ELF ABIv2 core dumps.

2013-11-06 Thread Rusty Russell
We leave it at zero (though it could be 1) for old tasks. Signed-off-by: Rusty Russell ru...@rustcorp.com.au --- arch/powerpc/include/asm/elf.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/include/asm/elf.h b/arch/powerpc/include/asm/elf.h index 54c7445..8b89268 100644 ---

Re: [PATCH] powerpc: memcpy optimization for 64bit LE

2013-11-06 Thread Anton Blanchard
Hi, Unaligned stores take alignment exceptions on POWER7 running in little-endian. This is a dumb little-endian base memcpy that prevents unaligned stores. It is replaced by the VMX memcpy at boot. Is this any faster than the generic version? Once booted the feature fixup code switches

Re: [PATCH] powerpc: memcpy optimization for 64bit LE

2013-11-06 Thread Michael Neuling
OK, can you add that and/or maybe antons description to the patch changelog? Mikey On Wed, Nov 6, 2013 at 9:21 PM, Philippe Bergheaud fe...@linux.vnet.ibm.com wrote: Michael Neuling wrote: Philippe Bergheaud fe...@linux.vnet.ibm.com wrote: Unaligned stores take alignment exceptions on

Re: [RFC PATCH] ehci-platform: Merge ppc-of EHCI driver into the ehci-platform driver

2013-11-06 Thread Alistair Popple
On Wed, 6 Nov 2013 11:14:44 Alan Stern wrote: On Wed, 6 Nov 2013, Alistair Popple wrote: [snip] + /* Initialise platform data from device tree if available. */ + if (!dn) { Shouldn't this be if (dn)? Yep. Thanks. + if (of_get_property(dn, big-endian, NULL)) { +

Re: [RFC PATCH] ehci-platform: Merge ppc-of EHCI driver into the ehci-platform driver

2013-11-06 Thread Alistair Popple
On Thu, 7 Nov 2013 06:57:00 Benjamin Herrenschmidt wrote: On Wed, 2013-11-06 at 18:39 +1100, Alistair Popple wrote: [snip] I would go even further and add the 44x workarounds to the normal platform device, with a compatible check in there. That isn't the first time we add quirks to an

Re: [PATCH 2/3] powerpc/kvm: fix rare but potential deadlock scene

2013-11-06 Thread Liu ping fan
On Wed, Nov 6, 2013 at 7:18 PM, Paul Mackerras pau...@samba.org wrote: On Wed, Nov 06, 2013 at 02:02:07PM +0800, Liu ping fan wrote: On Wed, Nov 6, 2013 at 1:04 PM, Paul Mackerras pau...@samba.org wrote: On Tue, Nov 05, 2013 at 03:42:43PM +0800, Liu Ping Fan wrote: Since

Re: [PATCH 3/7] IBM Akebono: Add support for a new PHY to the IBM emac driver

2013-11-06 Thread Alistair Popple
On Wed, 6 Nov 2013 16:40:10 Ben Hutchings wrote: On Wed, 2013-11-06 at 12:34 +1100, Alistair Popple wrote: On Tue, 5 Nov 2013 23:11:50 Ben Hutchings wrote: On Wed, 2013-11-06 at 06:54 +1100, Benjamin Herrenschmidt wrote: [snip] It's an SoC bit so there's little point making it

RE: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-06 Thread Li Xiubo
The SGTL5000 is based on regulators and when it is disabled, there will be an error returns directly while the SGTL5000 codec is probing. What makes you say this? From the code: File path: sound/soc/codecs/sgtl5000.c == #ifdef CONFIG_REGULATOR . #else static int

RE: [PATCH v5 4/4] powerpc/85xx: add sysfs for pw20 state and altivec idle

2013-11-06 Thread Dongsheng Wang
-Original Message- From: Wood Scott-B07421 Sent: Thursday, November 07, 2013 9:20 AM To: Wang Dongsheng-B40534 Cc: Bhushan Bharat-R65777; Wood Scott-B07421; linuxppc- d...@lists.ozlabs.org Subject: Re: [PATCH v5 4/4] powerpc/85xx: add sysfs for pw20 state and altivec idle On

[PATCH 1/3] powerpc/p1010rdb:add P1010RDB-PB platform support

2013-11-06 Thread Zhao Qiang
The P1010RDB-PB is similar to P1010RDB(P1010RDB-PA). So, P1010RDB-PB use the same platform file as P1010RDB. Then Add support for P1010RDB-PB platform. Signed-off-by: Zhao Qiang b45...@freescale.com --- arch/powerpc/platforms/85xx/p1010rdb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 3/3] powerpc/p1010rdb:update mtd of nand to adapt to both old and new p1010rdb

2013-11-06 Thread Zhao Qiang
P1010rdb-pa and p1010rdb-pb have different mtd of nand. So update dts to adapt to both p1010rdb-pa and p1010rdb-pb. Move the nand-mtd from p1010rdb.dtsi to p1010rdb-pa*.dts. Remove nand-mtd for p1010rdb-pb, whick will use mtdparts from u-boot instead of nand-mtd in device tree. Signed-off-by:

[PATCH 2/3] powerpc/p1010rdb:update dts to adapt to both old and new p1010rdb

2013-11-06 Thread Zhao Qiang
P1010rdb-pa and p1010rdb-pb have different phy interrupts. So update dts to adapt to both p1010rdb-pa and p1010rdb-pb. Signed-off-by: Shengzhou Liu shengzhou@freescale.com Signed-off-by: Zhao Qiang b45...@freescale.com --- arch/powerpc/boot/dts/p1010rdb-pa.dts | 35

Re: [PATCH 4/7] IBM Akebono: Add support to the OHCI platform driver for Akebono

2013-11-06 Thread Alistair Popple
On Tue, 5 Nov 2013 10:04:02 Alan Stern wrote: [snip] + /* Platforms using DT don't always provide platform data. +* This should provide reasonable defaults. */ /* * The accepted format for multi-line * comments is like this. */ Ok, I'll fix that

Re: [PATCH V7 5/7] POWER/cpuidle: Generic POWER CPUIDLE driver supporting PSERIES.

2013-11-06 Thread Deepthi Dharwar
On 11/07/2013 02:35 AM, Daniel Lezcano wrote: On 10/29/2013 12:01 PM, Deepthi Dharwar wrote: This patch includes cleanup and refactoring of the existing code to make the driver POWER generic. * Re-naming the functions from pseries to generic power. * Re-naming the backend driver from

Re: [PATCH 4/7] IBM Akebono: Add support to the OHCI platform driver for Akebono

2013-11-06 Thread Benjamin Herrenschmidt
On Thu, 2013-11-07 at 14:34 +1100, Alistair Popple wrote: Thanks. Based on the discussion for the EHCI driver I would like to change the compatibility string to usb-ochi (instead of ibm,akebono-ohci). Are you still happy for me to add the Acked-by with the alternate compatibility (and of

Re: [PATCH V7 5/7] POWER/cpuidle: Generic POWER CPUIDLE driver supporting PSERIES.

2013-11-06 Thread Benjamin Herrenschmidt
On Thu, 2013-11-07 at 09:45 +0530, Deepthi Dharwar wrote: 'powerpc' would be very generic arch and would comprise of all platforms including embedded 32/64 bit to server 64 bit (similar to that of ARM). This driver does not intend to support complete powerpc arch, but just PSERIES and POWERNV

Re: [PATCH V7 5/7] POWER/cpuidle: Generic POWER CPUIDLE driver supporting PSERIES.

2013-11-06 Thread Deepthi Dharwar
On 11/07/2013 10:31 AM, Benjamin Herrenschmidt wrote: On Thu, 2013-11-07 at 09:45 +0530, Deepthi Dharwar wrote: 'powerpc' would be very generic arch and would comprise of all platforms including embedded 32/64 bit to server 64 bit (similar to that of ARM). This driver does not intend to

[PATCH v2 1/2] powerpc/kvm: fix rare but potential deadlock scene

2013-11-06 Thread Liu Ping Fan
Since kvmppc_hv_find_lock_hpte() is called from both virtmode and realmode, so it can trigger the deadlock. Suppose the following scene: Two physical cpuM, cpuN, two VM instances A, B, each VM has a group of vcpus. If on cpuM, vcpu_A_1 holds bitlock X (HPTE_V_HVLOCK), then is switched out, and

[PATCH v2 2/2] powerpc/kvm: remove redundant assignment

2013-11-06 Thread Liu Ping Fan
ret is assigned twice with the same value, so remove the later one. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com Acked-by: Paul Mackerras pau...@samba.org --- arch/powerpc/kvm/book3s_64_mmu_hv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c

[PATCH] powerpc/85xx: don't init the mpic ipi for the SoC which has doorbell support

2013-11-06 Thread Kevin Hao
It makes no sense to initialize the mpic ipi for the SoC which has doorbell support. So set the smp_85xx_ops.probe to NULL for this case. Since the smp_85xx_ops.probe is also used in function smp_85xx_setup_cpu() to check if we need to invoke mpic_setup_this_cpu(), we introduce a new setup_cpu

Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-06 Thread Alexander Graf
Am 06.11.2013 um 20:58 schrieb Benjamin Herrenschmidt b...@kernel.crashing.org: On Wed, 2013-11-06 at 12:24 +0100, Alexander Graf wrote: On 05.11.2013, at 08:42, Liu Ping Fan kernelf...@gmail.com wrote: Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com Patch description missing.

Re: [PATCH 3/3] powerpc/kvm: remove redundant assignment

2013-11-06 Thread Benjamin Herrenschmidt
On Thu, 2013-11-07 at 08:52 +0100, Alexander Graf wrote: Am 06.11.2013 um 20:58 schrieb Benjamin Herrenschmidt b...@kernel.crashing.org: On Wed, 2013-11-06 at 12:24 +0100, Alexander Graf wrote: On 05.11.2013, at 08:42, Liu Ping Fan kernelf...@gmail.com wrote: Signed-off-by: Liu Ping