Re: [PATCH v2] powerpc/kernel: Remove error message in pcibios_setup_phb_resources()

2017-02-07 Thread Andrew Donnellan
On 08/02/17 14:11, Gavin Shan wrote: The CAPI driver creates virtual PHB (vPHB) from the CAPI adapter. The vPHB's IO and memory windows aren't built from device-tree node as we do for normal PHBs. A error message is thrown in below path when trying to probe AFUs contained in the adapter. The

Re: [PATCH V3 3/4] arch/powerpc: Implement Optprobes

2017-02-07 Thread Anju T Sudhakar
Hi Michael, Thank you so much for the review. On Wednesday 01 February 2017 04:23 PM, Michael Ellerman wrote: Anju T Sudhakar writes: Detour buffer contains instructions to create an in memory pt_regs. After the execution of the pre-handler, a call is made for

[PATCH v2] powerpc/opal-irqchip: Use interrupt names if present

2017-02-07 Thread Michael Ellerman
From: Benjamin Herrenschmidt Recent versions of OPAL can provide names for the various OPAL interrupts, so let's use them. This also modernises the code that fetches the interrupt array to use the helpers provided by the generic code instead of hand-parsing the

Re: [PATCH] powerpc/mm: Fix typo in set_pte_at()

2017-02-07 Thread Gavin Shan
On Mon, Feb 06, 2017 at 08:03:57AM +0530, Aneesh Kumar K.V wrote: >Gavin Shan writes: > >> This fixes the typo about the _PAGE_PTE in set_pte_at() by changing >> "tryint" to "trying to". >> >> Fixes: 6a119eae942 ("powerpc/mm: Add a _PAGE_PTE bit") > >I guess this is not

[PATCH v2] powerpc/mm: Fix typo in set_pte_at()

2017-02-07 Thread Gavin Shan
This fixes the typo about the _PAGE_PTE in set_pte_at() by changing "tryint" to "trying to". Signed-off-by: Gavin Shan --- v2: Removed "Fixes" tag --- arch/powerpc/mm/pgtable.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH v2] powerpc/kernel: Remove error message in pcibios_setup_phb_resources()

2017-02-07 Thread Gavin Shan
The CAPI driver creates virtual PHB (vPHB) from the CAPI adapter. The vPHB's IO and memory windows aren't built from device-tree node as we do for normal PHBs. A error message is thrown in below path when trying to probe AFUs contained in the adapter. The error message is confusing and

Re: [RFC] powerpc/pseries: Increase busy loop in pseries_cpu_die

2017-02-07 Thread Michael Ellerman
Thiago Jung Bauermann writes: > Am Dienstag, 7. Februar 2017, 08:26:45 BRST schrieb Balbir Singh: >> On Mon, Feb 06, 2017 at 04:58:16PM -0200, Thiago Jung Bauermann wrote: >> > [ 447.714064] Querying DEAD? cpu 134 (134) shows 2 >> > cpu 0x86: Vector: 300 (Data

Re: [PATCH] drivers/misc/cxl: Avoid unnecessary error message

2017-02-07 Thread Gavin Shan
On Wed, Feb 08, 2017 at 01:41:19PM +1100, Michael Ellerman wrote: >Gavin Shan writes: > >> On Wed, Feb 08, 2017 at 10:39:55AM +1100, Andrew Donnellan wrote: >>>On 08/02/17 10:21, Gavin Shan wrote: On Tue, Feb 07, 2017 at 10:12:48PM +1100, Michael Ellerman wrote:

Re: [PATCH] drivers/misc/cxl: Avoid unnecessary error message

2017-02-07 Thread Michael Ellerman
Gavin Shan writes: > On Wed, Feb 08, 2017 at 10:39:55AM +1100, Andrew Donnellan wrote: >>On 08/02/17 10:21, Gavin Shan wrote: >>>On Tue, Feb 07, 2017 at 10:12:48PM +1100, Michael Ellerman wrote: Andrew Donnellan writes: >>> >>>.../...

Re: [PATCH 1/3] kprobes: introduce weak variant of kprobe_exceptions_notify

2017-02-07 Thread Masami Hiramatsu
On Wed, 8 Feb 2017 01:24:14 +0530 "Naveen N. Rao" wrote: > kprobe_exceptions_notify() is not used on some of the architectures such > as arm[64] and powerpc anymore. Introduce a weak variant for such > architectures. > Good catch! Acked-by: Masami Hiramatsu

Re: [v2] powerpc/powernv: Remove separate entry for OPAL real mode calls

2017-02-07 Thread Michael Ellerman
On Tue, 2017-02-07 at 05:03:17 UTC, Paul Mackerras wrote: > From: Benjamin Herrenschmidt > > All entry points already read the MSR so they can easily do > the right thing. > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Paul

Re: powerpc/64: CONFIG_RELOCATABLE support for hmi interrupts

2017-02-07 Thread Michael Ellerman
On Fri, 2017-01-27 at 04:24:33 UTC, Nicholas Piggin wrote: > The branch from hmi_exception_early to hmi_exception_realmode must use > a "relocatable-style" branch, because it is branching from unrelocated > exception code to beyond __end_interrupts. > > Signed-off-by: Nicholas Piggin

Re: [PATCH] drivers/misc/cxl: Avoid unnecessary error message

2017-02-07 Thread Gavin Shan
On Wed, Feb 08, 2017 at 10:39:55AM +1100, Andrew Donnellan wrote: >On 08/02/17 10:21, Gavin Shan wrote: >>On Tue, Feb 07, 2017 at 10:12:48PM +1100, Michael Ellerman wrote: >>>Andrew Donnellan writes: >> >>.../... >> The effect of this patch is to copy the memory

Re: [PATCH] powerpc/mm: Fix RECLAIM_DISTANCE

2017-02-07 Thread Gavin Shan
On Tue, Jan 31, 2017 at 04:01:05PM +1100, Gavin Shan wrote: >On Tue, Jan 31, 2017 at 08:11:39AM +1100, Michael Ellerman wrote: >>Gavin Shan writes: >> >>I'd like to see some test results from multi-node systems. >> >>I'd also like to understand what has changed since we

Re: [PATCH] drivers/misc/cxl: Avoid unnecessary error message

2017-02-07 Thread Andrew Donnellan
On 08/02/17 10:21, Gavin Shan wrote: On Tue, Feb 07, 2017 at 10:12:48PM +1100, Michael Ellerman wrote: Andrew Donnellan writes: .../... The effect of this patch is to copy the memory resources from the *real* PHB to the vPHB, as given through the device tree.

Re: [PATCH] drivers/misc/cxl: Avoid unnecessary error message

2017-02-07 Thread Gavin Shan
On Tue, Feb 07, 2017 at 10:12:48PM +1100, Michael Ellerman wrote: >Andrew Donnellan writes: .../... >> The effect of this patch is to copy the memory resources from the *real* >> PHB to the vPHB, as given through the device tree. It shouldn't have any >>

Re: [PATCH] drivers/misc/cxl: Avoid unnecessary error message

2017-02-07 Thread Gavin Shan
On Tue, Feb 07, 2017 at 07:14:33PM +1100, Andrew Donnellan wrote: >On 31/01/17 14:43, Gavin Shan wrote: >>The following error message was observed. It's complaining M32 >>memory window is missed on virtual PHB, which is a bit confusing. >>The problem is the memory windows are never updated from

[PATCH 3/3] powerpc: kprobes: remove kprobe_exceptions_notify()

2017-02-07 Thread Naveen N. Rao
... as the weak variant will do. Signed-off-by: Naveen N. Rao --- arch/powerpc/kernel/kprobes.c | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/powerpc/kernel/kprobes.c b/arch/powerpc/kernel/kprobes.c index 45e4f82b230d..fce05a38851c 100644 ---

[PATCH 2/3] arm: kprobes: remove kprobe_exceptions_notify

2017-02-07 Thread Naveen N. Rao
... as the weak variant will do. Signed-off-by: Naveen N. Rao --- arch/arm/probes/kprobes/core.c | 10 -- arch/arm64/kernel/probes/kprobes.c | 6 -- 2 files changed, 16 deletions(-) diff --git a/arch/arm/probes/kprobes/core.c

[PATCH 1/3] kprobes: introduce weak variant of kprobe_exceptions_notify

2017-02-07 Thread Naveen N. Rao
kprobe_exceptions_notify() is not used on some of the architectures such as arm[64] and powerpc anymore. Introduce a weak variant for such architectures. Signed-off-by: Naveen N. Rao --- kernel/kprobes.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

Re: [PATCH kernel] vfio/spapr_tce: Set window when adding additional groups to container

2017-02-07 Thread Alex Williamson
On Tue, 7 Feb 2017 17:26:57 +1100 Alexey Kardashevskiy wrote: > If a container already has a group attached, attaching a new group > should just program already created IOMMU tables to the hardware via > the iommu_table_group_ops::set_window() callback. > > However 6f01cc692

Re: [PATCH] Documentation: powerpc/fsl: Update compatible for l2cache binding

2017-02-07 Thread Rob Herring
On Fri, Feb 03, 2017 at 01:43:16PM +1300, Chris Packham wrote: > List all the current valid compatible strings for the l2cache binding. > This should stop checkpatch.pl from complaining and will hopefully save > someone from having to debug a typo in their dts. > > Signed-off-by: Chris Packham

Re: [PATCH 2/2] powerpc/powernv: Add more BPF in defconfig

2017-02-07 Thread Naveen N. Rao
On 2017/02/07 10:00PM, Michael Ellerman wrote: > > I'll mush the patches all together and turn them all on across > pseries/ppc64/powernv. Here's a version that does that. I have merged all the patches (including UPROBE_EVENT since that is very useful with bcc anyway). I have also added

Re: [PATCH] cxl: fix nested locking hang during EEH hotplug

2017-02-07 Thread Frederic Barrat
Le 06/02/2017 à 02:07, Andrew Donnellan a écrit : Commit 14a3ae34bfd0 ("cxl: Prevent read/write to AFU config space while AFU not configured") introduced a rwsem to fix an invalid memory access that occurred when someone attempts to access the config space of an AFU on a vPHB whilst the AFU is

[PATCH -next] KVM: PPC: Fix error return code in kvm_vm_ioctl_create_spapr_tce()

2017-02-07 Thread Wei Yongjun
From: Wei Yongjun Fix to return error code -ENOMEM from the memory alloc error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- arch/powerpc/kvm/book3s_64_vio.c | 8 ++-- 1 file changed, 6

Re: [RFC] powerpc/pseries: Increase busy loop in pseries_cpu_die

2017-02-07 Thread Thiago Jung Bauermann
Am Dienstag, 7. Februar 2017, 08:26:45 BRST schrieb Balbir Singh: > On Mon, Feb 06, 2017 at 04:58:16PM -0200, Thiago Jung Bauermann wrote: > > [ 447.714064] Querying DEAD? cpu 134 (134) shows 2 > > cpu 0x86: Vector: 300 (Data Access) at [c7b0fd40] > > > > pc: 1ec3072c > >

Re: [PATCH v1 1/2] fadump: reduce memory consumption for capture kernel

2017-02-07 Thread Hari Bathini
Hi Mahesh, On Tuesday 31 January 2017 01:05 AM, Mahesh Jagannath Salgaonkar wrote: On 01/30/2017 10:14 PM, Hari Bathini wrote: In case of fadump, capture (fadump) kernel boots like a normal kernel. While this has its advantages, the capture kernel would initialize all the components like

[PATCH 1/1] powerpc/xmon: Dump memory in native endian format.

2017-02-07 Thread Douglas Miller
Extend dump command to allow display of 2, 4, and 8 byte words in native endian format. Also adds dump command for "1 byte words" for the sake of symmetry. New commands are: d1 dump 8 bit values d2 dump 16 bit values d4 dump 32 bit values d8

[PATCH v2 2/2] fadump: update documentation about introduction of handover area

2017-02-07 Thread Hari Bathini
Update documentation about introduction of handover area that includes configuration details like extra parameters to append to capture kernel. Signed-off-by: Hari Bathini --- Documentation/powerpc/firmware-assisted-dump.txt | 83 ++ 1 file

[PATCH v2 1/2] fadump: reduce memory consumption for capture kernel

2017-02-07 Thread Hari Bathini
In case of fadump, capture (fadump) kernel boots like a normal kernel. While this has its advantages, the capture kernel would initialize all the components like normal kernel, which may not necessarily be needed for a typical dump capture kernel. So, fadump capture kernel ends up needing more

Re: [PATCH] drivers/misc/cxl: Avoid unnecessary error message

2017-02-07 Thread Michael Ellerman
Andrew Donnellan writes: > On 31/01/17 14:43, Gavin Shan wrote: >> The following error message was observed. It's complaining M32 >> memory window is missed on virtual PHB, which is a bit confusing. >> The problem is the memory windows are never updated from its >>

Re: [PATCH 2/2] powerpc/powernv: Add more BPF in defconfig

2017-02-07 Thread Michael Ellerman
"Naveen N. Rao" writes: > On 2017/02/07 11:10AM, Michael Ellerman wrote: >> Michael Neuling writes: >> > diff --git a/arch/powerpc/configs/powernv_defconfig >> > b/arch/powerpc/configs/powernv_defconfig >> > index 7028dbc753..911b43e2c7 100644

[PATCH] powerpc/powernv: Fix opal_exit tracepoint opcode

2017-02-07 Thread Michael Ellerman
Currently the opal_exit tracepoint usually shows the opcode as 0: -0 [047] d.h. 635.654292: opal_entry: opcode=63 -0 [047] d.h. 635.654296: opal_exit: opcode=0 retval=0 kopald-1209 [019] d... 636.420943: opal_entry: opcode=10 kopald-1209 [019] d... 636.420959: opal_exit:

Re: Timekeeping oddities on MacMini G4s

2017-02-07 Thread Hal Murray
> What do I do if I don't have an existing ntp.conf ? Assuming ntpsec builds... There are sample config files in config/ contrib/ntp.conf.log.sample has logging which you probably want. it has lots of comments. It is setup to use us.pool.ntp.org If you aren't in the us, you should probably

[PATCH 2/2] soc/fsl/qe: get rid of immrbar_virt_to_phys()

2017-02-07 Thread Christophe Leroy
immrbar_virt_to_phys() is not used anymore Signed-off-by: Christophe Leroy --- drivers/soc/fsl/qe/qe.c | 4 +--- include/soc/fsl/qe/immap_qe.h | 19 --- 2 files changed, 1 insertion(+), 22 deletions(-) diff --git a/drivers/soc/fsl/qe/qe.c

[PATCH 1/2] net: ethernet: ucc_geth: fix MEM_PART_MURAM mode

2017-02-07 Thread Christophe Leroy
Since commit 5093bb965a163 ("powerpc/QE: switch to the cpm_muram implementation"), muram area is not part of immrbar mapping anymore so immrbar_virt_to_phys() is not usable anymore. Fixes: 5093bb965a163 ("powerpc/QE: switch to the cpm_muram implementation) Signed-off-by: Christophe Leroy

[PATCH 0/2] get rid of immrbar_virt_to_phys()

2017-02-07 Thread Christophe Leroy
ucc_geth ethernet driver is the only driver using immrbar_virt_to_phys() and it uses it incorrectly. This patch fixes ucc_geth driver then removes immrbar_virt_to_phys() Christophe Leroy (2): net: ethernet: ucc_geth: fix MEM_PART_MURAM mode soc/fsl/qe: get rid of immrbar_virt_to_phys()

Re: [PATCH v4 13/15] livepatch: change to a per-task consistency model

2017-02-07 Thread Miroslav Benes
> > And finally, the section "Limitations" has this text under the first > > bullet: > > > > + The patch must not change the semantic of the patched functions. > > > > The current implementation guarantees only that either the old > > or the new function is called. The functions are

Re: [PATCH] drivers/misc/cxl: Avoid unnecessary error message

2017-02-07 Thread Andrew Donnellan
On 31/01/17 14:43, Gavin Shan wrote: The following error message was observed. It's complaining M32 memory window is missed on virtual PHB, which is a bit confusing. The problem is the memory windows are never updated from its device-tree node. PCI: Memory resource 0 not set for host bridge