Re: [PATCH] powerpc64/hw_breakpoints: Handle data breakpoints in radix mode

2017-06-15 Thread Michael Ellerman
"Naveen N. Rao" writes: > diff --git a/arch/powerpc/kernel/exceptions-64s.S > b/arch/powerpc/kernel/exceptions-64s.S > index ae418b85c17c..17ee701b8336 100644 > --- a/arch/powerpc/kernel/exceptions-64s.S > +++ b/arch/powerpc/kernel/exceptions-64s.S > @@ -1442,7

Re: [PATCH] ppc64/perf: Fix oops when kthread execs user process

2017-06-15 Thread Michael Ellerman
Ravi Bangoria writes: > When a kthread makes a call_usermodehelper() call the steps are: > a. allocates current->mm > b. load_elf_binary() > c. populates current->thread.regs > > While doing this, interrupts are not disabled. If there is a perf > interrupt in

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-15 Thread Ravi Bangoria
Works like a charm with Milian's patch. Acked-by: Ravi Bangoria Note: I still see very minor differences between libunwind and libdw. Also, second last function gets repeated two times in every callchain but it can be fixed later on. Otherwise all looks good!

Re: [Oops][next-20170614][] powerpc boot fails with WARNING: CPU: 12 PID: 0 at mm/memblock.c

2017-06-15 Thread Stephen Rothwell
Hi all, On Fri, 16 Jun 2017 11:13:35 +1000 Stephen Rothwell wrote: > > On Fri, 16 Jun 2017 10:57:22 +1000 Michael Ellerman > wrote: > > > > "Rowand, Frank" writes: > > > > > On Thursday, June 15, 2017 2:25 AM, Abdul Haleem

Re: [PATCH] ppc64/perf: Fix oops when kthread execs user process

2017-06-15 Thread Ravi Bangoria
Thanks Naveen, On Thursday 15 June 2017 08:57 PM, Naveen N. Rao wrote: > Hmm... are you sure it's the same issue? The above commit only went into > v4.7, which means we weren't able to use --call-graph=dwarf till v4.7. Yes sorry. It's from v4.7 onwards. -Ravi

Re: [Oops][next-20170614][] powerpc boot fails with WARNING: CPU: 12 PID: 0 at mm/memblock.c

2017-06-15 Thread Stephen Rothwell
Hi Michael, On Fri, 16 Jun 2017 10:57:22 +1000 Michael Ellerman wrote: > > "Rowand, Frank" writes: > > > On Thursday, June 15, 2017 2:25 AM, Abdul Haleem > > [mailto:abdha...@linux.vnet.ibm.com] wrote: > >> > >> On Thu, 2017-06-15 at 11:30 +0530,

RE: [Oops][next-20170614][] powerpc boot fails with WARNING: CPU: 12 PID: 0 at mm/memblock.c

2017-06-15 Thread Michael Ellerman
"Rowand, Frank" writes: > On Thursday, June 15, 2017 2:25 AM, Abdul Haleem > [mailto:abdha...@linux.vnet.ibm.com] wrote: >> >> On Thu, 2017-06-15 at 11:30 +0530, Abdul Haleem wrote: >>> Hi, >>> >>> linux-next fails to boot on powerpc Bare-metal with these warnings. >>>

Re: [PATCH 31/44] hexagon: remove arch-specific dma_supported implementation

2017-06-15 Thread Richard Kuo
On Thu, Jun 08, 2017 at 03:25:56PM +0200, Christoph Hellwig wrote: > This implementation is simply bogus - hexagon only has a simple > direct mapped DMA implementation and thus doesn't care about the > address. > > Signed-off-by: Christoph Hellwig > --- >

Re: [PATCH 17/44] hexagon: switch to use ->mapping_error for error reporting

2017-06-15 Thread Richard Kuo
On Thu, Jun 08, 2017 at 03:25:42PM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > arch/hexagon/include/asm/dma-mapping.h | 2 -- > arch/hexagon/kernel/dma.c | 12 +--- > arch/hexagon/kernel/hexagon_ksyms.c| 1 - > 3 files

Re: [Oops][next-20170614][] powerpc boot fails with WARNING: CPU: 12 PID: 0 at mm/memblock.c

2017-06-15 Thread Benjamin Herrenschmidt
On Thu, 2017-06-15 at 17:06 +, Rowand, Frank wrote: > On Thursday, June 15, 2017 2:25 AM, Abdul Haleem > [mailto:abdha...@linux.vnet.ibm.com] wrote: > > > > On Thu, 2017-06-15 at 11:30 +0530, Abdul Haleem wrote: > > > Hi, > > > > > > linux-next fails to boot on powerpc Bare-metal with

Re: powernv/npu-dma.c: Remove spurious WARN_ON when a PCI device has no of_node

2017-06-15 Thread Michael Ellerman
On Wed, 2017-06-14 at 04:47:50 UTC, Alistair Popple wrote: > "4c3b89e powerpc/powernv: Add sanity checks to pnv_pci_get_{gpu|npu}_dev" > introduced explicit warnings in pnv_pci_get_npu_dev() when a PCIe device > has no associated device-tree node. However not all PCIe devices have an > of_node and

Re: powerpc/xive: Fix offset for store EOI MMIOs

2017-06-15 Thread Michael Ellerman
On Wed, 2017-06-14 at 00:19:25 UTC, Benjamin Herrenschmidt wrote: > Architecturally we should apply a 0x400 offset for these. Not doing > it will break future HW implementations. > > Signed-off-by: Benjamin Herrenschmidt Applied to powerpc fixes, thanks.

[RESEND PATCH v5 16/16] powerpc/44x: Add generic compatible string for I2C EEPROM

2017-06-15 Thread Javier Martinez Canillas
The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries. But when matching using an OF table, both the vendor and device has to be taken

[RESEND PATCH v5 15/16] powerpc/83xx: Add generic compatible string for I2C EEPROM

2017-06-15 Thread Javier Martinez Canillas
The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries. But when matching using an OF table, both the vendor and device has to be taken

[RESEND PATCH v5 14/16] powerpc/512x: Add generic compatible string for I2C EEPROM

2017-06-15 Thread Javier Martinez Canillas
The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries. But when matching using an OF table, both the vendor and device has to be taken

[RESEND PATCH v5 13/16] powerpc/fsl: Add generic compatible string for I2C EEPROM

2017-06-15 Thread Javier Martinez Canillas
The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries. But when matching using an OF table, both the vendor and device has to be taken

[RESEND PATCH v5 12/16] powerpc/5200: Add generic compatible string for I2C EEPROM

2017-06-15 Thread Javier Martinez Canillas
The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries. But when matching using an OF table, both the vendor and device has to be taken

[RESEND PATCH v5 00/16] eeprom: at24: Add OF device ID table

2017-06-15 Thread Javier Martinez Canillas
Hello Wolfram, This series is a follow-up to patch [0] that added an OF device ID table to the at24 EEPROM driver. As you suggested [1], this version instead of adding entries for every used tuple, only adds a single entry for each chip type using the "atmel" vendor as a generic

RE: [Oops][next-20170614][] powerpc boot fails with WARNING: CPU: 12 PID: 0 at mm/memblock.c

2017-06-15 Thread Rowand, Frank
On Thursday, June 15, 2017 2:25 AM, Abdul Haleem [mailto:abdha...@linux.vnet.ibm.com] wrote: > > On Thu, 2017-06-15 at 11:30 +0530, Abdul Haleem wrote: >> Hi, >> >> linux-next fails to boot on powerpc Bare-metal with these warnings. >> >> machine booted fine on next-20170613 > > Thanks Michael,

Re: [PATCH 2/2] powerpc: Fix emulation of mfocrf in emulate_step()

2017-06-15 Thread Naveen N. Rao
On 2017/06/15 09:46AM, Anton Blanchard wrote: > From: Anton Blanchard > > From POWER4 onwards, mfocrf() only places the specified CR field into > the destination GPR, and the rest of it is set to 0. The PowerPC AS > from version 3.0 now requires this behaviour. > > The

Re: [PATCH 1/2] powerpc: Fix emulation of mcrf in emulate_step()

2017-06-15 Thread Naveen N. Rao
On 2017/06/15 09:46AM, Anton Blanchard wrote: > From: Anton Blanchard > > The mcrf emulation code was looking at the CR fields in the reverse > order. It also relied on reserved fields being zero which is somewhat > fragile, so fix that too. Yikes! Amazing catch! Acked-by:

Re: [PATCH v2 1/6] integrity: Small code improvements

2017-06-15 Thread Mimi Zohar
On Wed, 2017-06-07 at 22:49 -0300, Thiago Jung Bauermann wrote: > These changes are too small to warrant their own patches: > > The keyid and sig_size members of struct signature_v2_hdr are in BE format, > so use a type that makes this assumption explicit. Also, use beXX_to_cpu > instead of

Re: [PATCH v2 3/6] ima: Log the same audit cause whenever a file has no signature

2017-06-15 Thread Mimi Zohar
On Wed, 2017-06-07 at 22:49 -0300, Thiago Jung Bauermann wrote: > If the file doesn't have an xattr, ima_appraise_measurement sets cause to > "missing-hash" while if there's an xattr but it's a digest instead of a > signature it sets cause to "IMA-signature-required". > > Fix it by setting cause

Re: [PATCH v2 2/6] ima: Simplify policy_func_show.

2017-06-15 Thread Mimi Zohar
On Wed, 2017-06-07 at 22:49 -0300, Thiago Jung Bauermann wrote: > If the func_tokens array uses the same indices as enum ima_hooks, > policy_func_show can be a lot simpler, and the func_* enum becomes > unnecessary. > > Also, if we use the same macro trick used by kernel_read_file_id_str we can >

Re: [PATCH v2 3/4] powerpc/kprobes_on_ftrace: Skip livepatch_handler() for jprobes

2017-06-15 Thread Naveen N. Rao
On 2017/06/15 09:19PM, Michael Ellerman wrote: > "Naveen N. Rao" writes: > > > diff --git a/arch/powerpc/kernel/trace/ftrace_64_mprofile.S > > b/arch/powerpc/kernel/trace/ftrace_64_mprofile.S > > index fa0921410fa4..e6837e85ec28 100644 > > ---

Re: [PATCH] ppc64/perf: Fix oops when kthread execs user process

2017-06-15 Thread Naveen N. Rao
On 2017/06/15 07:16PM, Ravi Bangoria wrote: > When a kthread makes a call_usermodehelper() call the steps are: > a. allocates current->mm > b. load_elf_binary() > c. populates current->thread.regs > > While doing this, interrupts are not disabled. If there is a perf > interrupt in the middle

[PATCH] ppc64/perf: Fix oops when kthread execs user process

2017-06-15 Thread Ravi Bangoria
When a kthread makes a call_usermodehelper() call the steps are: a. allocates current->mm b. load_elf_binary() c. populates current->thread.regs While doing this, interrupts are not disabled. If there is a perf interrupt in the middle of this process (i.e. step 'a' has completed but not yet

Re: [PATCH V2] cxl: Export library to support IBM XSL

2017-06-15 Thread Frederic Barrat
Salut Christophe, A few comments below, nothing major... Le 14/06/2017 à 15:29, Christophe Lombard a écrit : This patch exports a in-kernel 'library' API which can be called by other drivers to help interacting with an IBM XSL on a POWER9 system. The XSL (Translation Service Layer) is a

Re: [PATCH v2] perf: libdw support for powerpc

2017-06-15 Thread Jiri Olsa
On Thu, Jun 01, 2017 at 12:24:41PM +0200, Paolo Bonzini wrote: > Porting PPC to libdw only needs an architecture-specific hook to move > the register state from perf to libdw. > > The ARM and x86 architectures already use libdw, and it is useful to > have as much common code for the unwinder as

Re: [PATCH 07/13] powerpc/64s: idle avoid SRR usage in idle sleep/wake paths

2017-06-15 Thread Nicholas Piggin
On Tue, 13 Jun 2017 23:05:51 +1000 Nicholas Piggin wrote: > Idle code now always runs at the 0xc... effective address whether > in real or virtual mode. This means rfid can be ditched, along > with a lot of SRR manipulations. > > In the wakeup path, carry SRR1 around in r12.

Re: [PATCH v2 3/4] powerpc/kprobes_on_ftrace: Skip livepatch_handler() for jprobes

2017-06-15 Thread Michael Ellerman
"Naveen N. Rao" writes: > diff --git a/arch/powerpc/kernel/trace/ftrace_64_mprofile.S > b/arch/powerpc/kernel/trace/ftrace_64_mprofile.S > index fa0921410fa4..e6837e85ec28 100644 > --- a/arch/powerpc/kernel/trace/ftrace_64_mprofile.S > +++

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-15 Thread Mark Wielaard
On Thu, 2017-06-15 at 10:46 +0200, Milian Wolff wrote: > Just a quick question: Have you guys applied my recent patch: > > commit 5ea0416f51cc93436bbe497c62ab49fd9cb245b6 > Author: Milian Wolff > Date: Thu Jun 1 23:00:21 2017 +0200 > > perf report: Include partial

Re: [PATCH kernel 2/3] pci-ioda: Set PCI_BUS_FLAGS_MSI_REMAP for IODA host bridge

2017-06-15 Thread Benjamin Herrenschmidt
On Thu, 2017-06-15 at 19:25 +1000, Michael Ellerman wrote: > Alexey Kardashevskiy writes: > > > From: Yongji Xie > > > > Any IODA host bridge have the capability of IRQ remapping. > > So we set PCI_BUS_FLAGS_MSI_REMAP when this kind of host birdge > > is

Re: [PATCH] Revert "powerpc: Handle simultaneous interrupts at once"

2017-06-15 Thread Benjamin Herrenschmidt
On Thu, 2017-06-15 at 16:28 +1000, Michael Ellerman wrote: > This reverts commit 45cb08f4791ce6a15c54598b4cb73db4b4b8294f. > > For some reason this is causing IRQ problems on Freescale Book3E > machines, eg on my p5020ds: This looks like a driver bug it could be that you get hammered by an

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-15 Thread Milian Wolff
On Tuesday, June 13, 2017 5:55:09 PM CEST Ravi Bangoria wrote: > Hi Mark, > > On Tuesday 13 June 2017 05:14 PM, Mark Wielaard wrote: > > I see the same on very short runs. But when doing a slightly longer run, > > even just using ls -lahR, which does some more work, then I do see user > >

Re: [PATCH 12/13] powerpc/64: runlatch CTRL[RUN] set optimisation

2017-06-15 Thread Michael Ellerman
Nicholas Piggin writes: > diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c > index baae104b16c7..f587c1fdf981 100644 > --- a/arch/powerpc/kernel/process.c > +++ b/arch/powerpc/kernel/process.c > @@ -1960,11 +1960,25 @@ void show_stack(struct

Re: [Oops][next-20170614][] powerpc boot fails with WARNING: CPU: 12 PID: 0 at mm/memblock.c

2017-06-15 Thread Abdul Haleem
On Thu, 2017-06-15 at 11:30 +0530, Abdul Haleem wrote: > Hi, > > linux-next fails to boot on powerpc Bare-metal with these warnings. > > machine booted fine on next-20170613 Thanks Michael, Yes it is (75fe04e59 of: remove *phandle properties from expanded device tree) Frank, would you please

Re: [PATCH kernel 2/3] pci-ioda: Set PCI_BUS_FLAGS_MSI_REMAP for IODA host bridge

2017-06-15 Thread Michael Ellerman
Alexey Kardashevskiy writes: > From: Yongji Xie > > Any IODA host bridge have the capability of IRQ remapping. > So we set PCI_BUS_FLAGS_MSI_REMAP when this kind of host birdge > is detected. Where's the code that actually enforces this property? It would

Re: [PATCH 1/2] powerpc: Fix emulation of mcrf in emulate_step()

2017-06-15 Thread Segher Boessenkool
On Thu, Jun 15, 2017 at 04:47:29PM +1000, Anton Blanchard wrote: > > Maybe there should be (inline) > > helper function to insert/extract CR fields? > > That would be nice, there are quite a few places that could use it. Like patch 2/2, hint hint. Segher

Re: [PATCH 1/2] powerpc: Fix emulation of mcrf in emulate_step()

2017-06-15 Thread Anton Blanchard
Hi Segher, > On Thu, Jun 15, 2017 at 09:46:38AM +1000, Anton Blanchard wrote: > > The mcrf emulation code was looking at the CR fields in the reverse > > order. It also relied on reserved fields being zero which is > > somewhat fragile, so fix that too. > > It masked out the reserved bits. I

[PATCH] Revert "powerpc: Handle simultaneous interrupts at once"

2017-06-15 Thread Michael Ellerman
This reverts commit 45cb08f4791ce6a15c54598b4cb73db4b4b8294f. For some reason this is causing IRQ problems on Freescale Book3E machines, eg on my p5020ds: irq 25: nobody cared (try booting with the "irqpoll" option) CPU: 0 PID: 1 Comm: swapper/0 Not tainted

Re: [PATCH kernel] powerpc/debug: Add missing warn flag to WARN_ON's non-builtin path

2017-06-15 Thread Michael Ellerman
Alexey Kardashevskiy writes: > On 14/06/17 21:04, Michael Ellerman wrote: >> Alexey Kardashevskiy writes: >> >>> When trapped on WARN_ON(), report_bug() is expected to return >>> BUG_TRAP_TYPE_WARN so the caller could increment NIP by 4 and continue. >>> The

Re: [PATCH] powerpc/uprobes: Implement arch_uretprobe_is_alive()

2017-06-15 Thread Srikar Dronamraju
Adding Oleg and Pratyush to the cc. > This helper is used to detect if a uprobe'd function has returned > through a setjmp/longjmp, rather than branching to the LR that was > updated previously by us. This fixes a SIGSEGV that gets generated when > programs use setjmp/longjmp with uretprobes. >

[Oops][next-20170614] powerpc boot fails with WARNING: CPU: 12 PID: 0 at mm/memblock.c

2017-06-15 Thread Abdul Haleem
Hi, linux-next fails to boot on powerpc Bare-metal with these warnings. machine booted fine on next-20170613 Test: Boot Machine type: Power8 Bare-metal Kernel : 4.12.0-rc5-next-20170614 config: attached Trace logs: --- numa: NODE_DATA [mem 0x3fff50a300-0x3fff513fff] numa: