Re: a3b2cb30 broken panic reporting for qemu guests

2017-12-03 Thread David Gibson
On Mon, Dec 04, 2017 at 04:12:06PM +1000, Nicholas Piggin wrote: > On Mon, 4 Dec 2017 16:49:14 +1100 > David Gibson wrote: > > > On Fri, Dec 01, 2017 at 09:40:38PM +1000, Nicholas Piggin wrote: > > > On Fri, 01 Dec 2017 22:11:50 +1100 > > > Michael Ellerman

Re: [PATCH 0/4] Fix use after free in HPT resizing code and related minor improvements

2017-12-03 Thread David Gibson
On Wed, Nov 29, 2017 at 11:38:22AM -0500, Serhii Popovych wrote: > It is possible to trigger use after free during HPT resize > causing host kernel to crash. More details and analysis of > the problem can be found in change with corresponding subject > (KVM: PPC: Book3S HV: Fix use after free in

Re: a3b2cb30 broken panic reporting for qemu guests

2017-12-03 Thread Nicholas Piggin
On Mon, 4 Dec 2017 16:49:14 +1100 David Gibson wrote: > On Fri, Dec 01, 2017 at 09:40:38PM +1000, Nicholas Piggin wrote: > > On Fri, 01 Dec 2017 22:11:50 +1100 > > Michael Ellerman wrote: > > > > > David Gibson

Re: [PATCH 2/4] powerpc/64: do not trace irqs-off at interrupt return to soft-disabled context

2017-12-03 Thread Nicholas Piggin
On Mon, 04 Dec 2017 16:09:57 +1100 Michael Ellerman wrote: > Nicholas Piggin writes: > > > When an interrupt is returning to a soft-disabled context (which can > > happen for non-maskable interrupts or synchronous interrupts), it goes > > through the

[PATCH V2] powerpc/mm: Invalidate subpage_prot() system call on radix platforms

2017-12-03 Thread Anshuman Khandual
Radix enabled platforms don't support subpage_prot() system calls. But at present the system call goes through without an error and fails later on while validating expected subpage accesses. Lets not allow the system call on powerpc radix platforms to begin with to prevent this confusion in user

Re: a3b2cb30 broken panic reporting for qemu guests

2017-12-03 Thread David Gibson
On Fri, Dec 01, 2017 at 10:11:50PM +1100, Michael Ellerman wrote: > David Gibson writes: > > > On Wed, Nov 29, 2017 at 02:23:43PM +1000, Nicholas Piggin wrote: > >> On Wed, 29 Nov 2017 15:06:52 +1100 > >> David Gibson wrote: > >> > >> >

Re: a3b2cb30 broken panic reporting for qemu guests

2017-12-03 Thread David Gibson
On Fri, Dec 01, 2017 at 09:40:38PM +1000, Nicholas Piggin wrote: > On Fri, 01 Dec 2017 22:11:50 +1100 > Michael Ellerman wrote: > > > David Gibson writes: > > > > > On Wed, Nov 29, 2017 at 02:23:43PM +1000, Nicholas Piggin wrote: > > >> On

Re: a3b2cb30 broken panic reporting for qemu guests

2017-12-03 Thread David Gibson
On Wed, Nov 29, 2017 at 02:23:43PM +1000, Nicholas Piggin wrote: > On Wed, 29 Nov 2017 15:06:52 +1100 > David Gibson wrote: > > > a3b2cb30 "powerpc: Do not call ppc_md.panic in fadump panic notifier" > > purports to fix a problem when the kernel panics with fadump

[PATCH] Revert "powerpc: Do not call ppc_md.panic in fadump panic notifier"

2017-12-03 Thread David Gibson
This reverts commit a3b2cb30f252b21a6f962e0dd107c8b897ca65e4. The earlier patch tried to fix problems with panic on powerpc in certain circumstances, where some output from the generic panic code was being dropped. Unfortunately, it breaks things worse in other circumstances. In particular when

Re: [PATCH V3 0/9] powerpc: Support for ibm,dynamic-memory-v2

2017-12-03 Thread Michael Ellerman
Nathan Fontenot writes: > This patch set provides a series of updates to de-couple the LMB > information provided in the device tree property from the device > tree property format. This eases the ability to support a new > format for the dynamic memory property,

Re: [PATCH 2/4] powerpc/64: do not trace irqs-off at interrupt return to soft-disabled context

2017-12-03 Thread Michael Ellerman
Nicholas Piggin writes: > When an interrupt is returning to a soft-disabled context (which can > happen for non-maskable interrupts or synchronous interrupts), it goes > through the motions of soft-disabling again, including calling > TRACE_DISABLE_INTS (i.e.,

Re: [PATCH v5 0/3] Prepartion for SR-IOV PowerVM Enablement

2017-12-03 Thread Russell Currey
On Thu, 2017-11-09 at 08:00 -0600, Bryant G. Ly wrote: > v1 - Initial patch > v2 - Addressed Bjorn's comment on creating a highly platform > dependent global exported symbol. > v3 - Based patch off linux-ppc/master > v4 - Using the sriov-drivers_autoprobe mechanism per Bjorn's request > v5 -

Re: [PATCH] powerpc/40x: acadia: Fix the 'interrupt-parent' property

2017-12-03 Thread Michael Ellerman
Fabio Estevam writes: > Hi Michael, > > On Tue, Oct 17, 2017 at 11:01 AM, Fabio Estevam wrote: >> 'interrupts-parent' property does not exist. Fix the typo. >> >> Fixes: 00f3ca740a9c26 ("powerpc/40x: AMCC PowerPC 405EZ Acadia DTS") >> Signed-off-by:

Re: [PATCH v1] PCI: Make PCI_SCAN_ALL_PCIE_DEVS work for Root as well as Downstream Ports

2017-12-03 Thread Michael Ellerman
Bjorn Helgaas writes: > On Fri, Dec 01, 2017 at 06:27:10PM -0600, Bjorn Helgaas wrote: >> From: Bjorn Helgaas >> >> PCIe Downstream Ports normally have only a Device 0 below them. To >> optimize enumeration, we don't scan for other devices *unless* the

Re: [PATCH] powerpc/powernv : Add support to enable sensor groups

2017-12-03 Thread Stewart Smith
Shilpasri G Bhat writes: > On 11/28/2017 05:07 PM, Michael Ellerman wrote: >> Shilpasri G Bhat writes: >> >>> Adds support to enable/disable a sensor group. This can be used to >>> select the sensor groups that needs to be copied

Re: [rfc] powernv/kdump: Fix cases where the kdump kernel can get HMI's

2017-12-03 Thread Nicholas Piggin
On Mon, 4 Dec 2017 11:37:01 +1100 Balbir Singh wrote: > On Sun, Dec 3, 2017 at 1:36 PM, Nicholas Piggin wrote: > > Seems like a reasonable approach. Why do we only do this for > > powernv? It seems like a good idea in general to pull all > > offlined

[PATCH v2] powerpc/64s: ISAv3 initialize MMU registers before setting partition table

2017-12-03 Thread Nicholas Piggin
kexec can leave MMU registers set when booting into a new kernel, PIDR in particular. The boot sequence does not zero PIDR, so it only gets set when CPUs first switch to a userspace processes (until then it's running a kernel thread with effective PID = 0). This leaves a window where a process

[PATCH 3/3] powerpc/mm/ Add proper pte access check helper

2017-12-03 Thread Aneesh Kumar K.V
pte_access_premitted get called in get_user_pages_fast path. If we have marked the pte PROT_NONE, we should not allow a read access on the address. With the current implementation we are not checking the READ and only check for WRITE. This is needed on archs like ppc64 that implement PROT_NONE

[PATCH 2/3] powerpc/mm/book3s/64: Add proper pte access check helper

2017-12-03 Thread Aneesh Kumar K.V
pte_access_premitted get called in get_user_pages_fast path. If we have marked the pte PROT_NONE, we should not allow a read access on the address. With the current implementation we are not checking the READ and only check for WRITE. This is needed on archs like ppc64 that implement PROT_NONE

[PATCH 1/3] arch/powerpc/hugetlb: Use pte_access_permitted for hugetlb access check

2017-12-03 Thread Aneesh Kumar K.V
No functional change in this patch. This update gup_hugepte to use the helper. This will help later when we add memory keys. Signed-off-by: Aneesh Kumar K.V --- arch/powerpc/mm/hugetlbpage.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH] KVM: PPC: Book3S HV: check for XIVE device before executing the XICS hcalls

2017-12-03 Thread Paul Mackerras
On Mon, Nov 27, 2017 at 08:30:17AM +0100, Cédric Le Goater wrote: > When QEMU is started with the option kernel_irqchip=òff, the kvm XICS > hcalls are being used even though a kvm XICS device has not been > created on the host, resulting quickly in a failure and a broken > guest. > > The test

Re: [rfc] powernv/kdump: Fix cases where the kdump kernel can get HMI's

2017-12-03 Thread Balbir Singh
On Sun, Dec 3, 2017 at 1:36 PM, Nicholas Piggin wrote: > Seems like a reasonable approach. Why do we only do this for > powernv? It seems like a good idea in general to pull all > offlined CPUs out and into the same state for all platforms > and for all shutdown/restart/crash

Re: Memory corruption in powerpc guests with virtio_balloon (was Re: [PATCH v3] virtio_balloon: fix deadlock on OOM)

2017-12-03 Thread Michael Ellerman
"Michael S. Tsirkin" writes: > On Fri, Dec 01, 2017 at 11:31:08PM +1100, Michael Ellerman wrote: >> "Michael S. Tsirkin" writes: >> >> > fill_balloon doing memory allocations under balloon_lock >> > can cause a deadlock when leak_balloon is called from >> >

[PATCH] SB600 for the Nemo board has non-zero devices on non-root bus

2017-12-03 Thread Christian Zigotzky
On 3. Dec 2017, at 00:02, Olof Johansson wrote: > >> On Sat, Dec 2, 2017 at 3:00 PM, Olof Johansson wrote: >> >> The below patch, together with Bjorn's, should do it. Christian, can you test >> and report back? >> >> I'm guessing it won't do any harm to set