Re: [PATCH 2/2] x86, powerpc: remove -funit-at-a-time compiler option entirely

2018-12-07 Thread Masahiro Yamada
x86 maintainers, Ping. On Mon, Nov 12, 2018 at 8:23 PM Michael Ellerman wrote: > > Masahiro Yamada writes: > > > GCC 4.6 manual says: > > > > -funit-at-a-time > > This option is left for compatibility reasons. -funit-at-a-time has > > no effect, while -fno-unit-at-a-time implies

Re: [PATCH 1/2] um: remove -fno-unit-at-a-time workaround for pre-4.0 GCC

2018-12-07 Thread Masahiro Yamada
x86 maintainers, Ping. On Tue, Nov 13, 2018 at 6:48 PM Richard Weinberger wrote: > > Am Montag, 12. November 2018, 03:35:19 CET schrieb Masahiro Yamada: > > Commit cafa0010cd51 ("Raise the minimum required gcc version to 4.6") > > bumped the minimum GCC version to 4.6 for all architectures.

Re: [PATCH v2 01/34] kbuild: Add support for DT binding schema checks

2018-12-07 Thread Masahiro Yamada
Hi Rob, On Tue, Dec 4, 2018 at 6:32 AM Rob Herring wrote: > > This adds the build infrastructure for checking DT binding schema > documents and validating dts files using the binding schema. > > Check DT binding schema documents: > make dt_binding_check > > Build dts files and check using DT

Re: [PATCH] pseries/hotplug: Add more delay in pseries_cpu_die while waiting for rtas-stop

2018-12-07 Thread Thiago Jung Bauermann
Gautham R Shenoy writes: > On Fri, Dec 07, 2018 at 04:13:11PM +0530, Gautham R Shenoy wrote: >> Sure. I will test the patch and report back. > > I added the following debug patch on top of your patch, and after an > hour's run, the system crashed. Appending the log at the end. Thank you very

Re: [PATCH v2 18/34] dt-bindings: arm: Convert FSL board/soc bindings to json-schema

2018-12-07 Thread Shawn Guo
On Thu, Dec 06, 2018 at 05:33:13PM -0600, Rob Herring wrote: > On Wed, Dec 5, 2018 at 8:32 PM Shawn Guo wrote: > > > > On Mon, Dec 03, 2018 at 03:32:07PM -0600, Rob Herring wrote: > > > Convert Freescale SoC bindings to DT schema format using json-schema. > > > > > > Cc: Shawn Guo > > > Cc: Mark

Re: [PATCH V3 updated] arch/powerpc/mm/hugetlb: NestMMU workaround for hugetlb mprotect RW upgrade

2018-12-07 Thread kbuild test robot
Hi Aneesh, I love your patch! Yet something to improve: [auto build test ERROR on powerpc/next] [also build test ERROR on v4.20-rc5 next-20181207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH V4 0/3] * mm/kvm/vfio/ppc64: Migrate compound pages out of CMA region

2018-12-07 Thread Andrew Morton
On Wed, 21 Nov 2018 14:52:56 +0530 "Aneesh Kumar K.V" wrote: > Subject: [PATCH V4 0/3] * mm/kvm/vfio/ppc64: Migrate compound pages out of > CMA region Asterisk in title is strange? > ppc64 use CMA area for the allocation of guest page table (hash page table). > We won't > be able to start

Re: [PATCH] crypto/testmgr: fix skcipher test with CONFIG_VMAP_STACK

2018-12-07 Thread Ard Biesheuvel
On Fri, 7 Dec 2018 at 18:33, Christophe Leroy wrote: > > [2.364486] WARNING: CPU: 0 PID: 60 at ./arch/powerpc/include/asm/io.h:837 > dma_nommu_map_page+0x44/0xd4 > [2.373579] CPU: 0 PID: 60 Comm: cryptomgr_test Tainted: GW > 4.20.0-rc5-00560-g6bfb52e23a00-dirty #531 > [

error: no previous prototype for ‘pt_regs_check’

2018-12-07 Thread Mathieu Malaterre
Michael, I have been wondering for a while now, but I failed to make sense of this function: pt_regs_check (commit 002af9391bfbe). What is this function meant for ? Background, it breaks my W=1 build with: ../arch/powerpc/kernel/ptrace.c:3339:13: error: no previous prototype for ‘pt_regs_check’

[PATCH v6] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call

2018-12-07 Thread Dmitry V. Levin
From: Elvira Khabirova Arch code should use tracehook_*() helpers, as documented in include/linux/tracehook.h, ptrace_report_syscall() is not expected to be used outside that file. Co-authored-by: Dmitry V. Levin Fixes: 5521eb4bca2d ("powerpc/ptrace: Add support for PTRACE_SYSEMU") Cc: Michael

Re: [PATCH RFC 4/7] riscv/vdso: don't clear PG_reserved

2018-12-07 Thread Palmer Dabbelt
On Wed, 05 Dec 2018 04:28:48 PST (-0800), da...@redhat.com wrote: The VDSO is part of the kernel image and therefore the struct pages are marked as reserved during boot. As we install a special mapping, the actual struct pages will never be exposed to MM via the page tables. We can therefore

Re: [PATCH v4] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call

2018-12-07 Thread Dmitry V. Levin
On Fri, Dec 07, 2018 at 05:34:10PM +0100, Oleg Nesterov wrote: > On 12/07, Dmitry V. Levin wrote: > > On Fri, Dec 07, 2018 at 10:12:49PM +1100, Michael Ellerman wrote: > > > > > > Sorry, this patch does not work, please ignore it. > > > > > > Hmm OK. Why exactly? > > > > Unfortunately, I have no

Re: [REPOST PATCH v6 0/4] kgdb: Fix kgdb_roundup_cpus()

2018-12-07 Thread Doug Anderson
Hi, On Fri, Dec 7, 2018 at 9:42 AM Catalin Marinas wrote: > > On Tue, Dec 04, 2018 at 07:38:24PM -0800, Douglas Anderson wrote: > > Douglas Anderson (4): > > kgdb: Remove irq flags from roundup > > kgdb: Fix kgdb_roundup_cpus() for arches who used smp_call_function() > > kgdb: Don't round

Re: use generic DMA mapping code in powerpc V4

2018-12-07 Thread Christian Zigotzky
Next step: 13c1fdec5682b6e13257277fa16aa31f342d167d (powerpc/dma: move pci_dma_dev_setup_swiotlb to fsl_pci.c) git checkout 13c1fdec5682b6e13257277fa16aa31f342d167d Result: The PASEMI onboard ethernet works and the X5000 boots. — Christian Sent from my iPhone > On 7. Dec 2018, at 14:45,

[PATCH] powerpc: implement CONFIG_DEBUG_VIRTUAL

2018-12-07 Thread Christophe Leroy
This patch implements CONFIG_DEBUG_VIRTUAL to warn about incorrect use of virt_to_phys() and page_to_phys() Below is the result of test_debug_virtual: [1.438746] WARNING: CPU: 0 PID: 1 at ./arch/powerpc/include/asm/io.h:808 test_debug_virtual_init+0x3c/0xd4 [1.448156] CPU: 0 PID: 1

Re: [REPOST PATCH v6 0/4] kgdb: Fix kgdb_roundup_cpus()

2018-12-07 Thread Catalin Marinas
On Tue, Dec 04, 2018 at 07:38:24PM -0800, Douglas Anderson wrote: > Douglas Anderson (4): > kgdb: Remove irq flags from roundup > kgdb: Fix kgdb_roundup_cpus() for arches who used smp_call_function() > kgdb: Don't round up a CPU that failed rounding up before > kdb: Don't back trace on a

[PATCH] crypto/testmgr: fix skcipher test with CONFIG_VMAP_STACK

2018-12-07 Thread Christophe Leroy
[2.364486] WARNING: CPU: 0 PID: 60 at ./arch/powerpc/include/asm/io.h:837 dma_nommu_map_page+0x44/0xd4 [2.373579] CPU: 0 PID: 60 Comm: cryptomgr_test Tainted: GW 4.20.0-rc5-00560-g6bfb52e23a00-dirty #531 [2.384740] NIP: c000c540 LR: c000c584 CTR: [

Re: [PATCH v3 00/12] perf/core: Generalise event exclusion checking

2018-12-07 Thread Will Deacon
On Thu, Dec 06, 2018 at 04:47:17PM +, Andrew Murray wrote: > Many PMU drivers do not have the capability to exclude counting events > that occur in specific contexts such as idle, kernel, guest, etc. These > drivers indicate this by returning an error in their event_init upon > testing the

Re: [PATCH v4] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call

2018-12-07 Thread Oleg Nesterov
On 12/07, Dmitry V. Levin wrote: > > On Fri, Dec 07, 2018 at 10:12:49PM +1100, Michael Ellerman wrote: > > > > Sorry, this patch does not work, please ignore it. > > > > Hmm OK. Why exactly? > > Unfortunately, I have no idea why it doesn't work. > All I can say is it breaks strace because the

[PATCH v5] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call

2018-12-07 Thread Dmitry V. Levin
From: Elvira Khabirova Arch code should use tracehook_*() helpers, as documented in include/linux/tracehook.h, ptrace_report_syscall() is not expected to be used outside that file. The patch does not look very nice, but at least it is correct and opens the way for PTRACE_GET_SYSCALL_INFO API.

Re: [PATCH v4] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call

2018-12-07 Thread Dmitry V. Levin
On Fri, Dec 07, 2018 at 10:12:49PM +1100, Michael Ellerman wrote: > "Dmitry V. Levin" writes: > > On Mon, Dec 03, 2018 at 06:18:23AM +0300, Dmitry V. Levin wrote: > >> From: Elvira Khabirova > >> > >> Arch code should use tracehook_*() helpers, as documented > >> in include/linux/tracehook.h, >

Re: [PATCH] bpf: fix overflow of bpf_jit_limit when PAGE_SIZE >= 64K

2018-12-07 Thread Michael Roth
Quoting Michael Ellerman (2018-12-07 06:31:13) > Michael Roth writes: > > > Commit ede95a63b5 introduced a bpf_jit_limit tuneable to limit BPF > > JIT allocations. At compile time it defaults to PAGE_SIZE * 4, > > and is adjusted again at init time if MODULES_VADDR is defined. > > > > For

Re: [PATCH 01/34] powerpc: use mm zones more sensibly

2018-12-07 Thread Christian Zigotzky
I will work at the weekend to figure out where the problematic commit is. — Christian Sent from my iPhone > On 7. Dec 2018, at 15:09, Christoph Hellwig wrote: > >> On Fri, Dec 07, 2018 at 11:18:18PM +1100, Michael Ellerman wrote: >> Christoph Hellwig writes: >> >>> Ben / Michael, >>> >>>

Re: [PATCH 01/34] powerpc: use mm zones more sensibly

2018-12-07 Thread Christoph Hellwig
On Fri, Dec 07, 2018 at 11:18:18PM +1100, Michael Ellerman wrote: > Christoph Hellwig writes: > > > Ben / Michael, > > > > can we get this one queued up for 4.21 to prepare for the DMA work later > > on? > > I was hoping the PASEMI / NXP regressions could be solved before > merging. > > My

Re: [PATCH 3/4] powerpc/tm: Unset MSR[TS] if not recheckpointing

2018-12-07 Thread Michal Suchánek
On Mon, 26 Nov 2018 18:12:00 -0200 Breno Leitao wrote: > There is a TM Bad Thing bug that can be caused when you return from a > signal context in a suspended transaction but with ucontext MSR[TS] unset. > > This forces regs->msr[TS] to be set at syscall entrance (since the CPU > state is

Re: [PATCH 4/4] selftests/powerpc: Add checks for transactional sigreturn

2018-12-07 Thread Michal Suchánek
On Mon, 26 Nov 2018 18:12:01 -0200 Breno Leitao wrote: Hello > + > +int main(int argc, char **argv) > +{ > + test_harness(tm_signal_sigreturn_nt, "tm_signal_sigreturn_nt"); Should be something like return test_harness(tm_signal_sigreturn_nt, "tm_signal_sigreturn_nt"); > +} > + Thanks

Re: use generic DMA mapping code in powerpc V4

2018-12-07 Thread Christian Zigotzky
On 06 December 2018 at 11:55AM, Christian Zigotzky wrote: On 05 December 2018 at 3:05PM, Christoph Hellwig wrote: Thanks.  Can you try a few stepping points in the tree? First just with commit 7fd3bb05b73beea1f9840b505aa09beb9c75a8c6 (the first one) applied? Second with all commits up to

[PATCH] gpio: max7301: fix driver for use with CONFIG_VMAP_STACK

2018-12-07 Thread Christophe Leroy
spi_read() and spi_write() require DMA-safe memory. When CONFIG_VMAP_STACK is selected, those functions cannot be used with buffers on stack. This patch replaces calls to spi_read() and spi_write() by spi_write_then_read() which doesn't require DMA-safe buffers. Fixes: 0c36ec314735 ("gpio: gpio

Re: [1/7] drivers/cpufreq: change CONFIG_6xx to CONFIG_PPC_BOOK3S_32

2018-12-07 Thread Michael Ellerman
On Sat, 2018-11-17 at 10:24:54 UTC, Christophe Leroy wrote: > Today, powerpc has three CONFIG labels which means exactly the same: > - CONFIG_6xx > - CONFIG_PPC_BOOK3S_32 > - CONFIG_PPC_STD_MMU_32 > > By consistency with PPC64, CONFIG_PPC_BOOK3S_32 is the preferred one. > Using a label with

Re: misc: cxl: Use device_type helpers to access the node type

2018-12-07 Thread Michael Ellerman
On Fri, 2018-11-16 at 22:11:02 UTC, Rob Herring wrote: > Remove directly accessing device_node.type pointer and use the accessors > instead. This will eventually allow removing the type pointer. > > Cc: Frederic Barrat > Cc: Andrew Donnellan > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc:

Re: macintosh: Use device_type helpers to access the node type

2018-12-07 Thread Michael Ellerman
On Fri, 2018-11-16 at 22:11:01 UTC, Rob Herring wrote: > Remove directly accessing device_node.type pointer and use the accessors > instead. This will eventually allow removing the type pointer. > > Cc: Benjamin Herrenschmidt > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Rob Herring

Re: powerpc: Use device_type helpers to access the node type

2018-12-07 Thread Michael Ellerman
On Fri, 2018-11-16 at 22:11:00 UTC, Rob Herring wrote: > Remove directly accessing device_node.type pointer and use the accessors > instead. This will eventually allow removing the type pointer. > > Replace the open coded iterating over child nodes with > for_each_child_of_node() while we're

Re: powerpc: Rework btext_find_display to use of_stdout and device_type helpers

2018-12-07 Thread Michael Ellerman
On Fri, 2018-11-16 at 22:10:59 UTC, Rob Herring wrote: > Remove directly accessing device_node.type pointer and use the accessors > instead. This will eventually allow removing the type pointer. > > In the process, the of_stdout pointer can be used instead of finding the > stdout node again. > >

Re: macintosh: windfarm: Another convert to using %pOFn instead of device_node.name

2018-12-07 Thread Michael Ellerman
On Fri, 2018-11-16 at 22:05:39 UTC, Rob Herring wrote: > In preparation to remove the node name pointer from struct device_node, > convert printf users to use the %pOFn format specifier. > > Convert the open coded iterating thru child nodes to > for_each_child_of_node() while we're here. > > Cc:

Re: powerpc/mm: dump segment registers on book3s/32

2018-12-07 Thread Michael Ellerman
On Fri, 2018-11-16 at 17:06:43 UTC, Christophe Leroy wrote: > This patch creates a debugfs file to see content of > segment registers > > ~# cat /sys/kernel/debug/segment_registers > ---[ User Segments ]--- > 0x-0x0fff Kern key 1 User key 1 VSID 0xade2b0 > 0x1000-0x1fff Kern

Re: powerpc/xmon: Fix invocation inside lock region

2018-12-07 Thread Michael Ellerman
On Thu, 2018-11-08 at 17:12:42 UTC, Breno Leitao wrote: > Currently xmon needs to get devtree_lock (through rtas_token()) during its > invocation (at crash time). If there is a crash while devtree_lock is being > held, then xmon tries to get the lock but spins forever and never get into > the

Re: powerpc/mm: remove unused function prototype

2018-12-07 Thread Michael Ellerman
On Thu, 2018-11-01 at 21:54:01 UTC, Breno Leitao wrote: > Commit f384796c40dc ("powerpc/mm: Add support for handling > 512TB address > in SLB miss") removed function slb_miss_bad_addr(struct pt_regs *regs), but > kept its declaration in the prototype file. This patch simply removes the > function

Re: powerpc/tools/checkpatch: Ignore DT_SPLIT_BINDING_PATCH

2018-12-07 Thread Michael Ellerman
On Tue, 2018-12-04 at 05:11:54 UTC, Russell Currey wrote: > >From what I've seen, every time this warning comes up it's bogus, > so let's ignore it. > > Signed-off-by: Russell Currey > Reviewed-by: Andrew Donnellan Applied to powerpc next, thanks.

Re: [v3] powerpc/math-emu: Update macros from GCC

2018-12-07 Thread Michael Ellerman
On Mon, 2018-12-03 at 23:07:46 UTC, Joel Stanley wrote: > The add_ss, sub_ddmmss, umul_ppmm and udiv_qrnnd macros originate > from GCC's longlong.h which in turn was copied from GMP's longlong.h a > few decades ago. > > This was found when compiling with clang: > >

Re: [v4] powerpc/mm: dump block address translation on book3s/32

2018-12-07 Thread Michael Ellerman
On Mon, 2018-12-03 at 17:40:25 UTC, Christophe Leroy wrote: > This patch adds a debugfs file to dump block address translation: > > ~# cat /sys/kernel/debug/powerpc/block_address_translation > ---[ Instruction Block Address Translations ]--- > 0: - > 1: - > 2:

Re: [v9,01/20] powerpc/book3s32: Remove CONFIG_BOOKE dependent code

2018-12-07 Thread Michael Ellerman
On Thu, 2018-11-29 at 14:06:47 UTC, Christophe Leroy wrote: > BOOK3S/32 cannot be BOOKE, so remove useless code > > Signed-off-by: Christophe Leroy Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/a43ccc4bc499cb592e2cb3b4ada8d3 cheers

Re: powerpc: annotate implicit fall throughs

2018-12-07 Thread Michael Ellerman
On Wed, 2018-11-28 at 22:28:30 UTC, Stephen Rothwell wrote: > There is a plan to build the kernel with -Wimplicit-fallthrough and these > places in the code produced warnings, but because we build arch/powerpc > with -Werror, they became errors. Fix them up. > > This patch produces no change in

Re: powerpc/pseries/cpuidle: Fix preempt warning

2018-12-07 Thread Michael Ellerman
On Fri, 2018-11-23 at 16:30:11 UTC, Breno Leitao wrote: > When booting a pseries kernel with PREEMPT enabled, it dumps the following > warning: > >BUG: using smp_processor_id() in preemptible [] code: swapper/0/1 >caller is pseries_processor_idle_init+0x5c/0x22c >CPU: 13 PID:

Re: [PATCH] bpf: fix overflow of bpf_jit_limit when PAGE_SIZE >= 64K

2018-12-07 Thread Michael Ellerman
Michael Roth writes: > Commit ede95a63b5 introduced a bpf_jit_limit tuneable to limit BPF > JIT allocations. At compile time it defaults to PAGE_SIZE * 4, > and is adjusted again at init time if MODULES_VADDR is defined. > > For ppc64 kernels, MODULES_VADDR isn't defined, so we're stuck with

Re: [PATCH 01/34] powerpc: use mm zones more sensibly

2018-12-07 Thread Michael Ellerman
Christoph Hellwig writes: > Ben / Michael, > > can we get this one queued up for 4.21 to prepare for the DMA work later > on? I was hoping the PASEMI / NXP regressions could be solved before merging. My p5020ds is booting fine with this series, so I'm not sure why it's causing problems on

Re: [PATCH] pseries/hotplug: Add more delay in pseries_cpu_die while waiting for rtas-stop

2018-12-07 Thread Gautham R Shenoy
On Fri, Dec 07, 2018 at 04:13:11PM +0530, Gautham R Shenoy wrote: > Hi Thiago, > > > Sure. I will test the patch and report back. I added the following debug patch on top of your patch, and after an hour's run, the system crashed. Appending the log at the end. I suppose we still need to

Re: [PATCH v2 30/34] dt-bindings: arm: Convert Tegra board/soc bindings to json-schema

2018-12-07 Thread Thierry Reding
On Thu, Dec 06, 2018 at 04:38:44PM -0600, Rob Herring wrote: > On Tue, Dec 4, 2018 at 2:50 AM Thierry Reding > wrote: > > > > On Mon, Dec 03, 2018 at 03:32:19PM -0600, Rob Herring wrote: > > > Convert Tegra SoC bindings to DT schema format using json-schema. > > > > > > Cc: Mark Rutland > > >

Re: [PATCH] KVM: PPC: Book3S PR: Set hflag to indicate that POWER9 supports 1T segments

2018-12-07 Thread Paul Mackerras
On Fri, Dec 07, 2018 at 10:08:20PM +1100, Michael Ellerman wrote: > Suraj Jitindar Singh writes: > > > When booting a kvm-pr guest on a POWER9 machine the following message is > > observed: > > "qemu-system-ppc64: KVM does not support 1TiB segments which guest expects" > > > > This is because

Re: [PATCH v2 2/2] kgdb/treewide: constify struct kgdb_arch arch_kgdb_ops

2018-12-07 Thread Michael Ellerman
Christophe Leroy writes: > checkpatch.pl reports the following: > > WARNING: struct kgdb_arch should normally be const > #28: FILE: arch/mips/kernel/kgdb.c:397: > +struct kgdb_arch arch_kgdb_ops = { > > This report makes sense, as all other ops struct, this > one should also be const. This

Re: [PATCH v4] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call

2018-12-07 Thread Michael Ellerman
"Dmitry V. Levin" writes: > On Mon, Dec 03, 2018 at 06:18:23AM +0300, Dmitry V. Levin wrote: >> From: Elvira Khabirova >> >> Arch code should use tracehook_*() helpers, as documented >> in include/linux/tracehook.h, >> ptrace_report_syscall() is not expected to be used outside that file. >>

Re: [PATCH] KVM: PPC: Book3S PR: Set hflag to indicate that POWER9 supports 1T segments

2018-12-07 Thread Michael Ellerman
Suraj Jitindar Singh writes: > When booting a kvm-pr guest on a POWER9 machine the following message is > observed: > "qemu-system-ppc64: KVM does not support 1TiB segments which guest expects" > > This is because the guest is expecting to be able to use 1T segments > however we don't indicate

Re: [PATCH] pseries/hotplug: Add more delay in pseries_cpu_die while waiting for rtas-stop

2018-12-07 Thread Gautham R Shenoy
Hi Thiago, On Thu, Dec 06, 2018 at 03:28:17PM -0200, Thiago Jung Bauermann wrote: [..snip..] > > > I posted a similar patch last year, but I wasn't able to arrive at a > root cause analysis like you did: > > https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-February/153734.html Ah! Nice.

Re: [PATCH v4 0/5] powerpc: system call table generation support

2018-12-07 Thread Firoz Khan
Hi Satheesh, On Fri, 7 Dec 2018 at 12:57, Satheesh Rajendran wrote: > > On Fri, Dec 07, 2018 at 11:41:35AM +0530, Firoz Khan wrote: > Hi Firoz, > > This version(v4) booted fine in IBM Power8 box. Sounds good. Thanks for the support. Thanks Arnd for sharing the solution for "split compat syscall

[PATCH] soc: fsl: guts: us devm_kstrdup_const() for RO data

2018-12-07 Thread Nicholas Mc Guire
forms") --- Problem located by experimental coccinelle script Patch was compile tested with: multi_v7_defconfig (implies FSL_GUTS=y) Patch is against 4.20-rc5 (localversion-next is next-20181207) drivers/soc/fsl/guts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drive