> On 30-Aug-2019, at 8:43 PM, David Howells wrote:
>
> Can you try this patch instead of Hillf’s?
Works for me. Test ran fine without any problem.
Tested-by: Sachin Sant
Thanks
-Sachin
.3.0-rc6-
next-20190830 #4
[ 23.802930][ T13] Workqueue: events work_for_cpu_fn
[ 23.802962][ T13] NIP: c019eed8 LR: c0129400 CTR:
c08a46dc
[ 23.802988][ T13] REGS: c0002db2f130 TRAP: 0700 Not tainted (5.3.0-
rc6-next-20190830)
[ 23.80303
Building callchain.c with !COMPAT proved quite ugly with all the
defines. Splitting out the 32bit and 64bit parts looks better.
No code change intended.
Signed-off-by: Michal Suchanek
Reviewed-by: Christophe Leroy
---
v6:
- move current_is_64bit consolidetaion to earlier patch
- move defines
On bigendian ppc64 it is common to have 32bit legacy binaries but much
less so on littleendian.
Signed-off-by: Michal Suchanek
Reviewed-by: Christophe Leroy
---
v3: make configurable
---
arch/powerpc/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
There are numerous references to 32bit functions in generic and 64bit
code so ifdef them out.
Signed-off-by: Michal Suchanek
---
v2:
- fix 32bit ifdef condition in signal.c
- simplify the compat ifdef condition in vdso.c - 64bit is redundant
- simplify the compat ifdef condition in callchain.c -
There are two almost identical copies for 32bit and 64bit.
The function is used only in 32bit code which will be split out in next
patch so consolidate to one function.
Signed-off-by: Michal Suchanek
Reviewed-by: Christophe Leroy
---
new patch in v6
---
arch/powerpc/perf/callchain.c | 25
These functions are required for 64bit as well.
Signed-off-by: Michal Suchanek
Reviewed-by: Christophe Leroy
---
arch/powerpc/kernel/signal.c| 141
arch/powerpc/kernel/signal_32.c | 140 ---
2 files changed, 141 insertions(+),
This partially reverts commit caf6f9c8a326 ("asm-generic: Remove
unneeded __ARCH_WANT_SYS_LLSEEK macro")
When CONFIG_COMPAT is disabled on ppc64 the kernel does not build.
There is resistance to both removing the llseek syscall from the 64bit
syscall tables and building the llseek interface
Less code means less bugs so add a knob to skip the compat stuff.
This is tested on ppc64le top of
https://patchwork.ozlabs.org/cover/1153556/
Changes in v2: saner CONFIG_COMPAT ifdefs
Changes in v3:
- change llseek to 32bit instead of builing it unconditionally in fs
- clanup the makefile
On Thu, 4 Jul 2019 20:04:41 +0530
"Naveen N. Rao" wrote:
> kernel/trace/ftrace.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 7b037295a1f1..0791eafb693d 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
>
On Fri, Aug 30, 2019 at 10:13 PM Michal Suchánek wrote:
> On Fri, 30 Aug 2019 21:54:43 +0200
> Arnd Bergmann wrote:
> > > index 5bbf587f5bc1..2f3c4bb138c4 100644
> > > --- a/fs/read_write.c
> > > +++ b/fs/read_write.c
> > > @@ -331,7 +331,7 @@ COMPAT_SYSCALL_DEFINE3(lseek, unsigned int, fd,
> >
On Fri, 30 Aug 2019 22:21:09 +0200
Christophe Leroy wrote:
> Le 30/08/2019 à 20:57, Michal Suchanek a écrit :
> > There are numerous references to 32bit functions in generic and 64bit
> > code so ifdef them out.
> >
> > Signed-off-by: Michal Suchanek
> > ---
> > v2:
> > - fix 32bit ifdef
On Fri, Aug 30, 2019 at 10:30 PM Michal Suchanek wrote:
>
> Subject: [PATCH] powerpc: Add back __ARCH_WANT_SYS_LLSEEK macro
>
> This partially reverts commit caf6f9c8a326 ("asm-generic: Remove
> unneeded __ARCH_WANT_SYS_LLSEEK macro")
>
> When CONFIG_COMPAT is disabled on ppc64 the kernel does
Subject: [PATCH] powerpc: Add back __ARCH_WANT_SYS_LLSEEK macro
This partially reverts commit caf6f9c8a326 ("asm-generic: Remove
unneeded __ARCH_WANT_SYS_LLSEEK macro")
When CONFIG_COMPAT is disabled on ppc64 the kernel does not build.
There is resistance to both removing the llseek syscall
Le 30/08/2019 à 20:57, Michal Suchanek a écrit :
Building callchain.c with !COMPAT proved quite ugly with all the
defines. Splitting out the 32bit and 64bit parts looks better.
No code change intended.
Signed-off-by: Michal Suchanek
Reviewed-by: Christophe Leroy
---
v6:
- move
Le 30/08/2019 à 20:57, Michal Suchanek a écrit :
On bigendian ppc64 it is common to have 32bit legacy binaries but much
less so on littleendian.
Signed-off-by: Michal Suchanek
Reviewed-by: Christophe Leroy
---
v3: make configurable
---
arch/powerpc/Kconfig | 5 +++--
1 file
Le 30/08/2019 à 20:57, Michal Suchanek a écrit :
These functions are required for 64bit as well.
Signed-off-by: Michal Suchanek
Reviewed-by: christophe.le...@c-s.fr
---
arch/powerpc/kernel/signal.c| 141
arch/powerpc/kernel/signal_32.c | 140
Le 30/08/2019 à 20:57, Michal Suchanek a écrit :
There are two almost identical copies for 32bit and 64bit.
The function is used only in 32bit code which will be split out in next
patch so consolidate to one function.
Signed-off-by: Michal Suchanek
Reviewed-by: christophe.le...@c-s.fr
Le 30/08/2019 à 20:57, Michal Suchanek a écrit :
There are numerous references to 32bit functions in generic and 64bit
code so ifdef them out.
Signed-off-by: Michal Suchanek
---
v2:
- fix 32bit ifdef condition in signal.c
- simplify the compat ifdef condition in vdso.c - 64bit is redundant
On Thu, 4 Jul 2019 20:04:41 +0530
"Naveen N. Rao" wrote:
> LTP testsuite on powerpc results in the below crash:
>
> Unable to handle kernel paging request for data at address 0x
> Faulting instruction address: 0xc029d800
> Oops: Kernel access of bad area, sig: 11 [#1]
>
On Thu, 08 Aug 2019 20:45:04 +0530
"Naveen N. Rao" wrote:
> Naveen N. Rao wrote:
> > Two patches addressing bugs in ftrace function probe handling. The first
> > patch addresses a NULL pointer dereference reported by LTP tests, while
> > the second one is a trivial patch to address a missing
On Fri, 30 Aug 2019 21:54:43 +0200
Arnd Bergmann wrote:
> On Fri, Aug 30, 2019 at 9:46 PM Michal Suchanek wrote:
> >
> > This reverts commit caf6f9c8a326cffd1d4b3ff3f1cfba75d159d70b.
> >
> > Maybe it was needed after all.
> >
> > When CONFIG_COMPAT is disabled on ppc64 the kernel does not
On Sat, 31 Aug 2019 02:48:26 +0800
kbuild test robot wrote:
> Hi Nicholas,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on linus/master]
> [cannot apply to v5.3-rc6 next-20190830]
> [if your patch is applied to the wrong git tree, please drop
On Fri, Aug 30, 2019 at 9:46 PM Michal Suchanek wrote:
>
> This reverts commit caf6f9c8a326cffd1d4b3ff3f1cfba75d159d70b.
>
> Maybe it was needed after all.
>
> When CONFIG_COMPAT is disabled on ppc64 the kernel does not build.
>
> There is resistance to both removing the llseek syscall from the
This reverts commit caf6f9c8a326cffd1d4b3ff3f1cfba75d159d70b.
Maybe it was needed after all.
When CONFIG_COMPAT is disabled on ppc64 the kernel does not build.
There is resistance to both removing the llseek syscall from the 64bit
syscall tables and building the llseek interface
On Fri, 30 Aug 2019 20:57:57 +0200
Michal Suchanek wrote:
> Building callchain.c with !COMPAT proved quite ugly with all the
> defines. Splitting out the 32bit and 64bit parts looks better.
>
BTW the powerpc callchain.c does not match any of the patterns of PERF
CORE in MAINTAINERS (unlike
Building callchain.c with !COMPAT proved quite ugly with all the
defines. Splitting out the 32bit and 64bit parts looks better.
No code change intended.
Signed-off-by: Michal Suchanek
---
v6:
- move current_is_64bit consolidetaion to earlier patch
- move defines to the top of callchain_32.c
On bigendian ppc64 it is common to have 32bit legacy binaries but much
less so on littleendian.
Signed-off-by: Michal Suchanek
---
v3: make configurable
---
arch/powerpc/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
There are numerous references to 32bit functions in generic and 64bit
code so ifdef them out.
Signed-off-by: Michal Suchanek
---
v2:
- fix 32bit ifdef condition in signal.c
- simplify the compat ifdef condition in vdso.c - 64bit is redundant
- simplify the compat ifdef condition in callchain.c -
There are two almost identical copies for 32bit and 64bit.
The function is used only in 32bit code which will be split out in next
patch so consolidate to one function.
Signed-off-by: Michal Suchanek
---
new patch in v6
---
arch/powerpc/perf/callchain.c | 25 +
1 file
These functions are required for 64bit as well.
Signed-off-by: Michal Suchanek
---
arch/powerpc/kernel/signal.c| 141
arch/powerpc/kernel/signal_32.c | 140 ---
2 files changed, 141 insertions(+), 140 deletions(-)
diff --git
The llseek syscall is not built in fs/read_write.c when !64bit && !COMPAT
With the syscall marked as common in syscall.tbl build fails in this
case.
The llseek interface does not make sense on 64bit and it is explicitly
described as 32bit interface. Use on 64bit is not well-defined so just
drop
Less code means less bugs so add a knob to skip the compat stuff.
This is tested on ppc64le top of
https://patchwork.ozlabs.org/cover/1153556/
Changes in v2: saner CONFIG_COMPAT ifdefs
Changes in v3:
- change llseek to 32bit instead of builing it unconditionally in fs
- clanup the makefile
Hi Nicholas,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[cannot apply to v5.3-rc6 next-20190830]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits
Can you try this patch instead of Hillf's?
David
---
commit df882ad6d4e24a3763719c1798ea58e87d56c2d7
Author: Hillf Danton
Date: Fri Aug 30 15:54:33 2019 +0100
keys: Fix missing null pointer check in request_key_auth_describe()
If a request_key authentication token key gets
Hillf Danton wrote:
> 1, callee has no pre defined duty to help caller in general; they should not
> try to do anything, however, to help their callers in principle due to
> limited info on their hands IMO.
Ah, no. It's entirely reasonable for an API to specify that one of its
methods will be
Hi all,
> +static int kasan_depopulate_vmalloc_pte(pte_t *ptep, unsigned long addr,
> + void *unused)
> +{
> + unsigned long page;
> +
> + page = (unsigned long)__va(pte_pfn(*ptep) << PAGE_SHIFT);
> +
> + spin_lock(_mm.page_table_lock);
> +
> +
Hillf Danton wrote:
> - struct request_key_auth *rka = dereference_key_rcu(key);
> + struct request_key_auth *rka;
> +
> + rcu_read_lock();
> + rka = dereference_key_rcu(key);
This shouldn't help as the caller, proc_keys_show(), is holding the RCU read
lock across the call. The
Instead of calling H_BLOCK_REMOVE all the time when the feature is
exhibited, call this hcall only when the couple base page size, page size
is supported as reported by the TLB Invalidate Characteristics.
For regular pages and hugetlb, the assumption is made that the page size is
equal to the
The PAPR document specifies the TLB Block Invalidate Characteristics which
is telling which couple base page size / page size is supported by the
H_BLOCK_REMOVE hcall.
A new set of feature is added to the mmu_psize_def structure to record per
base page size which page size is supported by
Before reading the HPTE encoding values we initialize all of them to -1 (an
invalid value) to later being able to detect the initialized ones.
Signed-off-by: Laurent Dufour
---
arch/powerpc/mm/book3s64/hash_utils.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
Since the commit ba2dd8a26baa ("powerpc/pseries/mm: call H_BLOCK_REMOVE"),
the call to H_BLOCK_REMOVE is always done if the feature is exhibited.
On some system, the hypervisor may not support all the combination of
segment base page size and page size. When this happens the hcall is
returning
The patch
ASoC: fsl_ssi: Fix clock control issue in master mode
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.3
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24
On Thu, Aug 29, 2019 at 12:39:11PM -0700, Sukadev Bhattiprolu wrote:
> Bharata B Rao [bhar...@linux.ibm.com] wrote:
> > On Wed, Aug 28, 2019 at 08:02:19PM -0700, Sukadev Bhattiprolu wrote:
> Where do we serialize two threads attempting to H_SVM_PAGE_IN the same gfn
> at the same time? Or one
> On 30-Aug-2019, at 2:26 PM, Hillf Danton wrote:
>
>
> On Fri, 30 Aug 2019 12:18:07 +0530 Sachin Sant wrote:
>>
>> [ 8074.351033] BUG: Kernel NULL pointer dereference at 0x0038
>> [ 8074.351046] Faulting instruction address: 0xc04ddf30
>> [ 8074.351052] Oops: Kernel access of
We currently try to shrink a single zone when removing memory. We use the
zone of the first page of the memory we are removing. If that memmap was
never initialized (e.g., memory was never onlined), we will read garbage
and can trigger kernel BUGs (due to a stale pointer):
:/# [ 23.912993] BUG:
On Fri, 30 Aug 2019 12:18:07 +0530 Sachin Sant wrote:
>
> [ 8074.351033] BUG: Kernel NULL pointer dereference at 0x0038
> [ 8074.351046] Faulting instruction address: 0xc04ddf30
> [ 8074.351052] Oops: Kernel access of bad area, sig: 11 [#1]
> [ 8074.351056] LE PAGE_SIZE=64K MMU=Hash
On Thu, Aug 22, 2019 at 10:46:49PM +0800, YueHaibing wrote:
> drivers/crypto/nx/nx.h:12:19: warning:
> nx_driver_string defined but not used [-Wunused-const-variable=]
> drivers/crypto/nx/nx.h:13:19: warning:
> nx_driver_version defined but not used [-Wunused-const-variable=]
>
> They are never
Le 30/08/2019 à 09:54, Michal Suchánek a écrit :
On Fri, 30 Aug 2019 06:35:13 + (UTC)
Christophe Leroy wrote:
On 08/29/2019 10:28 PM, Michal Suchanek wrote:
There are numerous references to 32bit functions in generic and 64bit
code so ifdef them out.
Signed-off-by: Michal Suchanek
On Fri, 30 Aug 2019 06:35:13 + (UTC)
Christophe Leroy wrote:
> On 08/29/2019 10:28 PM, Michal Suchanek wrote:
> > There are numerous references to 32bit functions in generic and 64bit
> > code so ifdef them out.
> >
> > Signed-off-by: Michal Suchanek
> > ---
> > v2:
> > - fix 32bit ifdef
Le 29/08/2019 à 14:14, Michael Ellerman a écrit :
Christophe Leroy writes:
DSISR has a bit to tell if the fault is due to a read or a write.
Except some CPUs don't have a DSISR?
Which is why we have page_fault_is_write() that's used in
__do_page_fault().
And that's why I'm also using
Le 30/08/2019 à 09:12, Michal Suchánek a écrit :
On Fri, 30 Aug 2019 08:42:25 +0200
Michal Suchánek wrote:
On Fri, 30 Aug 2019 06:35:11 + (UTC)
Christophe Leroy wrote:
On 08/29/2019 10:28 PM, Michal Suchanek wrote:
obj-$(CONFIG_PPC_PERF_CTRS) += core-book3s.o bhrb.o
diff
On Fri, 30 Aug 2019 08:42:25 +0200
Michal Suchánek wrote:
> On Fri, 30 Aug 2019 06:35:11 + (UTC)
> Christophe Leroy wrote:
>
> > On 08/29/2019 10:28 PM, Michal Suchanek wrote:
> > obj-$(CONFIG_PPC_PERF_CTRS)+= core-book3s.o bhrb.o
> > diff --git
While running LTP tests (specifically cve-2016-7042) against 5.3-rc6
(commit 4a64489cf8) on a POWER9 LPAR, following problem is seen
[ 3373.814425] FS-Cache: Netfs 'nfs' registered for caching
[ 7695.250230] Clock: inserting leap second 23:59:60 UTC
[ 8074.351033] BUG: Kernel NULL pointer
On Fri, 30 Aug 2019 06:35:11 + (UTC)
Christophe Leroy wrote:
> On 08/29/2019 10:28 PM, Michal Suchanek wrote:
> > Building callchain.c with !COMPAT proved quite ugly with all the
> > defines. Splitting out the 32bit and 64bit parts looks better.
> >
> > Also rewrite current_is_64bit as
On 08/29/2019 10:28 PM, Michal Suchanek wrote:
> Building callchain.c with !COMPAT proved quite ugly with all the
> defines. Splitting out the 32bit and 64bit parts looks better.
>
> Also rewrite current_is_64bit as common function. No other code change
> intended.
Nice result.
Could look even
On 08/29/2019 10:28 PM, Michal Suchanek wrote:
> There are numerous references to 32bit functions in generic and 64bit
> code so ifdef them out.
>
> Signed-off-by: Michal Suchanek
> ---
> v2:
> - fix 32bit ifdef condition in signal.c
> - simplify the compat ifdef condition in vdso.c - 64bit is
57 matches
Mail list logo
