[PATCH] powerpc/crashkernel: take mem option into account
'mem=" option is an easy way to put high pressure on memory during some
test. Hence in stead of total mem, the effective usable memory size should
be considered when reserving mem for crashkernel. Otherwise the boot up may
experience oom issue.
E.g passing
crashkernel="2G-4G:384M,4G-16G:512M,16G-64G:1G,64G-128G:2G,128G-:4G", and
mem=5G.
Signed-off-by: Pingfan Liu
Cc: Hari Bathini
Cc: Michael Ellerman
To: linuxppc-dev@lists.ozlabs.org
---
arch/powerpc/kernel/machine_kexec.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/machine_kexec.c
b/arch/powerpc/kernel/machine_kexec.c
index c4ed328..714b733 100644
--- a/arch/powerpc/kernel/machine_kexec.c
+++ b/arch/powerpc/kernel/machine_kexec.c
@@ -114,11 +114,12 @@ void machine_kexec(struct kimage *image)
void __init reserve_crashkernel(void)
{
- unsigned long long crash_size, crash_base;
+ unsigned long long crash_size, crash_base, total_mem_sz;
int ret;
+ total_mem_sz = memory_limit ? memory_limit : memblock_phys_mem_size();
/* use common parsing */
- ret = parse_crashkernel(boot_command_line, memblock_phys_mem_size(),
+ ret = parse_crashkernel(boot_command_line, total_mem_sz,
_size, _base);
if (ret == 0 && crash_size > 0) {
crashk_res.start = crash_base;
--
2.7.5
Re: [PATCH v12 11/12] open: openat2(2) syscall
On 2019-09-07, Jeff Layton wrote:
> On Thu, 2019-09-05 at 06:19 +1000, Aleksa Sarai wrote:
> > + * @flags: O_* flags.
> > + * @mode: O_CREAT/O_TMPFILE file mode.
> > + * @upgrade_mask: UPGRADE_* flags (to restrict O_PATH re-opening).
> > + * @resolve: RESOLVE_* flags.
> > + */
> > +struct open_how {
> > + __u32 flags;
> > + union {
> > + __u16 mode;
> > + __u16 upgrade_mask;
> > + };
> > + __u16 resolve;
> > +};
> > +
> > +#define OPEN_HOW_SIZE_VER0 8 /* sizeof first published struct */
> > +
>
> Hmm, there is no version field. When you want to expand this in the
> future, what is the plan? Add a new flag to indicate that it's some
> length?
The "version number" is the size of the struct. Any extensions we make
are appended to the struct (openat2 now takes a size_t argument), and
the new copy_struct_{to,from}_user() helpers handle all of the
permutations of {old,new} kernel and {old,new} user space.
This is how clone3(), sched_[gs]etattr() and perf_event_open() all
operate (all of the sigset syscalls operate similarly but don't
gracefully handle different kernel vintages -- you just get -EINVAL).
--
Aleksa Sarai
Senior Software Engineer (Containers)
SUSE Linux GmbH
[Bug 204125] FTBFS on ppc64 big endian and gcc9 because of -mcall-aixdesc and missing __linux__
https://bugzilla.kernel.org/show_bug.cgi?id=204125 Daniel Kolesa (li...@octaforge.org) changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #9 from Daniel Kolesa (li...@octaforge.org) --- well, gcc 9.2 doesn't have this problem anymore, so i guess it can be closed here... -- You are receiving this mail because: You are watching the assignee of the bug.
Re: [PATCH] powerpc/64: interrupt return in C
Nicholas Piggin's on August 28, 2019 7:06 pm: > This is a work in progress that goes on top of the syscalls in C patch. > It's not quite complete, 64e low level exit is not taken care of, and > the new return is hacked into the existing interrupt handlers pretty > quickly (e.g., full gprs handling is still ugly and could be cleaned), In performance testing on a POWER9, page fault latency is about 1.1% faster with interrupt returns in C which always saves NVGPRs. So I think the plan will be to rip out all the NVGPR save optimisation from the 64-bit code. Thanks, Nick
Re: [PATCH 0/3] powerpc/ftrace: Enable HAVE_FUNCTION_GRAPH_RET_ADDR_PTR
Naveen N. Rao's on September 6, 2019 4:20 am: > Enable HAVE_FUNCTION_GRAPH_RET_ADDR_PTR for more robust stack unwinding > when function graph tracer is in use. Convert powerpc show_stack() to > use ftrace_graph_ret_addr() for better stack unwinding. This series improved my case of a WARN_ON triggering in trace_graph_return, the last return_to_handler entry in the stack dump has the caller in parenthesis rather than return_to_handler. It gives the caller, it would be nice if it could output the actual function being traced, and then continue the caller. But at least this is a significant improvement. Thanks for the quick turnaround. Tested-by: Nicholas Piggin
Re: [PATCH v2] powerpc/lockdep: fix a false positive warning
* Qian Cai wrote: > I thought about making it a bool in the first place, but since all > other similar helpers (arch_is_kernel_initmem_freed(), > arch_is_kernel_text(), arch_is_kernel_data() etc) could be bool too but > are not, I kept arch_is_bss_hole() just to be “int” for consistent. > > Although then there is is_kernel_rodata() which is bool. I suppose I’ll > change arch_is_bss_hole() to bool, and then could have a follow-up > patch to covert all similar helpers to return boo instead. Sounds good to me. Thanks, Ingo
