* Guenter Roeck [2019-12-25 08:06:26]:
> Since commit 656c21d6af5d ("powerpc/shared: Use static key to detect
> shared processor") and 14c73bd344da ("powerpc/vcpu: Assume dedicated
> processors as non-preempt"), powerpc test builds may fail with the
> following build errors.
>
>
Hi Sukadev,
I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.5-rc3 next-20191220]
[cannot apply to kvm-ppc/kvm-ppc-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we
Hi James,
On 12/12/2019 04:02 PM, James Morse wrote:
Hi Bhupesh,
On 29/11/2019 19:59, Bhupesh Sharma wrote:
vabits_actual variable on arm64 indicates the actual VA space size,
and allows a single binary to support both 48-bit and 52-bit VA
spaces.
If the ARMv8.2-LVA optional feature is
Hi James,
On 12/12/2019 04:02 PM, James Morse wrote:
Hi Bhupesh,
I am sorry this review mail skipped my attention due to holidays and
focus on other urgent issues.
On 29/11/2019 19:59, Bhupesh Sharma wrote:
Add documentation for TCR_EL1.T1SZ variable being added to
vmcoreinfo.
It
Thanks Scott, I will test to see if returning phys_addr_t in __pa()
works for my setup.
And another thin I will test is to compile without CONFIG_RELOCATABLE
before resubmitting the patch.
On Wed, Dec 25, 2019 at 2:53 PM Scott Wood wrote:
>
> On Wed, 2019-12-25 at 11:24 +0800, Yingjie Bai
Hi Scott,
__pa() returns 64bit in my setup.
in arch/powerpc/include/asm/page.h
#if defined(CONFIG_PPC32) && defined(CONFIG_BOOKE)
#define __va(x) ((void *)(unsigned long)((phys_addr_t)(x) + VIRT_PHYS_OFFSET))
#define __pa(x) ((unsigned long)(x) - VIRT_PHYS_OFFSET)
#else
#ifdef CONFIG_PPC64
...
Hi Michael,
Thanks for pointing out the issue. My mistake...
This patch should indeed make sense only when
CONFIG_PHYS_64BIT=y
I could not find corenet32_smp_defconfig, but I guess in your config,
CONFIG_PHYS_64BIT=n ?
I will update the patch later today
On Sun, Dec 22, 2019 at 5:38 PM Michael
Since commit 656c21d6af5d ("powerpc/shared: Use static key to detect
shared processor") and 14c73bd344da ("powerpc/vcpu: Assume dedicated
processors as non-preempt"), powerpc test builds may fail with the
following build errors.
./arch/powerpc/include/asm/spinlock.h:39:1: error:
type
There expect the 'static' keyword to come first in a declaration
arch/powerpc/platforms/powermac/smp.c:664:1: warning: static is not at
beginning of declaration [-Wold-style-declaration]
arch/powerpc/platforms/powermac/smp.c:665:1: warning: static is not at
beginning of declaration
