Re: [PATCH v4 2/9] perf/core: open access for CAP_SYS_PERFMON privileged process

2020-01-10 Thread arnaldo . melo
,Jann Horn ,Thomas Gleixner ,Tvrtko Ursulin ,Lionel Landwerlin ,linux-kernel ,"linux-security-mod...@vger.kernel.org" ,"seli...@vger.kernel.org" ,"intel-...@lists.freedesktop.org" ,"b...@vger.kernel.org" ,"linux-par...@vger.kernel.org" ,"linuxppc-dev@lists.ozlabs.org"

Re: [PATCH v4 2/9] perf/core: open access for CAP_SYS_PERFMON privileged process

2020-01-10 Thread Song Liu
> On Jan 10, 2020, at 3:47 PM, Masami Hiramatsu wrote: > > On Fri, 10 Jan 2020 13:45:31 -0300 > Arnaldo Carvalho de Melo wrote: > >> Em Sat, Jan 11, 2020 at 12:52:13AM +0900, Masami Hiramatsu escreveu: >>> On Fri, 10 Jan 2020 15:02:34 +0100 Peter Zijlstra >>> wrote: Again, this only

Re: Re: linux-next: build warning after merge of the bpf-next tree

2020-01-10 Thread Palmer Dabbelt
On Fri, 10 Jan 2020 14:28:17 PST (-0800), alexan...@ghiti.fr wrote: Hi guys, On 10/27/19 8:02 PM, Stephen Rothwell wrote: Hi all, On Fri, 18 Oct 2019 10:56:57 +1100 Stephen Rothwell wrote: Hi all, After merging the bpf-next tree, today's linux-next build (powerpc ppc64_defconfig) produced

Re: [PATCH v4 2/9] perf/core: open access for CAP_SYS_PERFMON privileged process

2020-01-10 Thread Masami Hiramatsu
On Fri, 10 Jan 2020 13:45:31 -0300 Arnaldo Carvalho de Melo wrote: > Em Sat, Jan 11, 2020 at 12:52:13AM +0900, Masami Hiramatsu escreveu: > > On Fri, 10 Jan 2020 15:02:34 +0100 Peter Zijlstra > > wrote: > > > Again, this only allows attaching to previously created kprobes, it does > > > not

Re: Re: linux-next: build warning after merge of the bpf-next tree

2020-01-10 Thread Alexei Starovoitov
On Fri, Jan 10, 2020 at 2:28 PM Alexandre Ghiti wrote: > > Hi guys, > > On 10/27/19 8:02 PM, Stephen Rothwell wrote: > > Hi all, > > > > On Fri, 18 Oct 2019 10:56:57 +1100 Stephen Rothwell > > wrote: > >> Hi all, > >> > >> After merging the bpf-next tree, today's linux-next build (powerpc > >>

Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2020-01-10 Thread Dave Anderson
- Original Message - > Hi Bhupesh, > > On 25/12/2019 19:01, Bhupesh Sharma wrote: > > On 12/12/2019 04:02 PM, James Morse wrote: > >> On 29/11/2019 19:59, Bhupesh Sharma wrote: > >>> vabits_actual variable on arm64 indicates the actual VA space size, > >>> and allows a single binary to

Re: Re: linux-next: build warning after merge of the bpf-next tree

2020-01-10 Thread Alexandre Ghiti
Hi guys, On 10/27/19 8:02 PM, Stephen Rothwell wrote: Hi all, On Fri, 18 Oct 2019 10:56:57 +1100 Stephen Rothwell wrote: Hi all, After merging the bpf-next tree, today's linux-next build (powerpc ppc64_defconfig) produced this warning: WARNING: 2 bad relocations c1998a48

Re: [RFC PATCH] powerpc/32: Switch VDSO to C implementation.

2020-01-10 Thread Thomas Gleixner
Christophe, Christophe Leroy writes: > On 01/09/2020 02:05 PM, Thomas Gleixner wrote: >> The reason why this is implemented in this way is that >> __arch_get_hw_counter() needs a way to express that the clocksource of >> the moment is not suitable for VDSO so that the syscall fallback gets >>

Re: [RFC PATCH v2 07/10] lib: vdso: don't use READ_ONCE() in __c_kernel_time()

2020-01-10 Thread Thomas Gleixner
Christophe Leroy writes: > > diff --git a/lib/vdso/gettimeofday.c b/lib/vdso/gettimeofday.c > index 17b4cff6e5f0..5a17a9d2e6cd 100644 > --- a/lib/vdso/gettimeofday.c > +++ b/lib/vdso/gettimeofday.c > @@ -144,7 +144,7 @@ __cvdso_gettimeofday(const struct vdso_data *vd, struct >

Re: [RFC PATCH v2 05/10] lib: vdso: inline do_hres()

2020-01-10 Thread Thomas Gleixner
Arnd Bergmann writes: > On Mon, Dec 23, 2019 at 3:31 PM Christophe Leroy > wrote: >> >> do_hres() is called from several places, so GCC doesn't inline >> it at first. >> >> do_hres() takes a struct __kernel_timespec * parameter for >> passing the result. In the 32 bits case, this parameter

Re: [RFC PATCH v2 01/10] lib: vdso: ensure all arches have 32bit fallback

2020-01-10 Thread Andy Lutomirski
> On Jan 10, 2020, at 10:56 AM, Thomas Gleixner wrote: > > Andy Lutomirski writes: > >>> On Mon, Dec 23, 2019 at 6:31 AM Christophe Leroy >>> wrote: >>> >>> In order to simplify next step which moves fallback call at arch >>> level, ensure all arches have a 32bit fallback instead of

Re: [RFC PATCH v2 01/10] lib: vdso: ensure all arches have 32bit fallback

2020-01-10 Thread Thomas Gleixner
Andy Lutomirski writes: > On Mon, Dec 23, 2019 at 6:31 AM Christophe Leroy > wrote: >> >> In order to simplify next step which moves fallback call at arch >> level, ensure all arches have a 32bit fallback instead of handling >> the lack of 32bit fallback in the common code based >> on

Re: [PATCH kernel] vfio/spapr/nvlink2: Skip unpinning pages on error exit

2020-01-10 Thread Alex Williamson
On Mon, 23 Dec 2019 12:09:27 +1100 Alexey Kardashevskiy wrote: > The nvlink2 subdriver for IBM Witherspoon machines preregisters > GPU memory in the IOMMI API so KVM TCE code can map this memory > for DMA as well. This is done by mm_iommu_newdev() called from > vfio_pci_nvgpu_regops::mmap. > >

Re: [RESEND PATCH v5 2/5] arm64/crash_core: Export TCR_EL1.T1SZ in vmcoreinfo

2020-01-10 Thread James Morse
Hi Bhupesh, On 25/12/2019 19:01, Bhupesh Sharma wrote: > On 12/12/2019 04:02 PM, James Morse wrote: >> On 29/11/2019 19:59, Bhupesh Sharma wrote: >>> vabits_actual variable on arm64 indicates the actual VA space size, >>> and allows a single binary to support both 48-bit and 52-bit VA >>> spaces.

Re: [PATCH v15 00/24] selftests, powerpc, x86: Memory Protection Keys

2020-01-10 Thread Dave Hansen
On 1/10/20 9:38 AM, Aneesh Kumar K.V wrote: >> v15: >> (1) Rebased on top of latest master. >> (2) Addressed review comments from Dave Hansen. >> (3) Moved code for getting or setting pkey bits to new >> helpers. These changes replace patch 7 of v14. >> (4) Added a fix

Re: [PATCH v15 00/24] selftests, powerpc, x86: Memory Protection Keys

2020-01-10 Thread Aneesh Kumar K.V
Sandipan Das writes: > Memory protection keys enables an application to protect its address > space from inadvertent access by its own code. > > This feature is now enabled on powerpc and has been available since > 4.16-rc1. The patches move the selftests to arch neutral directory > and enhance

Re: [PATCH v4 2/9] perf/core: open access for CAP_SYS_PERFMON privileged process

2020-01-10 Thread Alexey Budankov
On 10.01.2020 17:02, Peter Zijlstra wrote: > On Thu, Jan 09, 2020 at 02:36:50PM +0300, Alexey Budankov wrote: >> On 08.01.2020 19:07, Peter Zijlstra wrote: >>> On Wed, Dec 18, 2019 at 12:25:35PM +0300, Alexey Budankov wrote: > diff --git a/kernel/events/core.c b/kernel/events/core.c

Re: [PATCH v2 00/10] Impveovements for random.h/archrandom.h

2020-01-10 Thread Theodore Y. Ts'o
On Fri, Jan 10, 2020 at 04:51:53PM +0100, Borislav Petkov wrote: > On Fri, Jan 10, 2020 at 02:54:12PM +, Mark Brown wrote: > > This is a resend of a series from Richard Henderson last posted back in > > November: > > > > > >

Re: [PATCH v4 2/9] perf/core: open access for CAP_SYS_PERFMON privileged process

2020-01-10 Thread Arnaldo Carvalho de Melo
Em Sat, Jan 11, 2020 at 12:52:13AM +0900, Masami Hiramatsu escreveu: > On Fri, 10 Jan 2020 15:02:34 +0100 Peter Zijlstra > wrote: > > Again, this only allows attaching to previously created kprobes, it does > > not allow creating kprobes, right? > > That is; I don't think CAP_SYS_PERFMON should

Re: [PATCH v4 2/9] perf/core: open access for CAP_SYS_PERFMON privileged process

2020-01-10 Thread Alexey Budankov
On 10.01.2020 17:02, Peter Zijlstra wrote: > On Thu, Jan 09, 2020 at 02:36:50PM +0300, Alexey Budankov wrote: >> On 08.01.2020 19:07, Peter Zijlstra wrote: >>> On Wed, Dec 18, 2019 at 12:25:35PM +0300, Alexey Budankov wrote: > diff --git a/kernel/events/core.c b/kernel/events/core.c

Re: [PATCH v4 2/9] perf/core: open access for CAP_SYS_PERFMON privileged process

2020-01-10 Thread Masami Hiramatsu
On Fri, 10 Jan 2020 15:02:34 +0100 Peter Zijlstra wrote: > On Thu, Jan 09, 2020 at 02:36:50PM +0300, Alexey Budankov wrote: > > On 08.01.2020 19:07, Peter Zijlstra wrote: > > > On Wed, Dec 18, 2019 at 12:25:35PM +0300, Alexey Budankov wrote: > > > >> diff --git a/kernel/events/core.c

Re: [PATCH v2 00/10] Impveovements for random.h/archrandom.h

2020-01-10 Thread Borislav Petkov
On Fri, Jan 10, 2020 at 02:54:12PM +, Mark Brown wrote: > This is a resend of a series from Richard Henderson last posted back in > November: > > > https://lore.kernel.org/linux-arm-kernel/20191106141308.30535-1-...@twiddle.net/ > > Back then Borislav said they looked good and asked if

Re: [PATCH 06/18] powerpc sstep: Add support for prefixed integer load/stores

2020-01-10 Thread Balamuruhan S
On Tue, Nov 26, 2019 at 04:21:29PM +1100, Jordan Niethe wrote: > This adds emulation support for the following prefixed integer > load/stores: > * Prefixed Load Byte and Zero (plbz) > * Prefixed Load Halfword and Zero (plhz) > * Prefixed Load Halfword Algebraic (plha) > * Prefixed Load

[PATCH v2 10/10] s390x: Mark archrandom.h functions __must_check

2020-01-10 Thread Mark Brown
From: Richard Henderson We must not use the pointer output without validating the success of the random read. Reviewed-by: Harald Freudenberger Reviewed-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/s390/include/asm/archrandom.h | 8 1 file

[PATCH v2 09/10] powerpc: Mark archrandom.h functions __must_check

2020-01-10 Thread Mark Brown
From: Richard Henderson We must not use the pointer output without validating the success of the random read. Acked-by: Michael Ellerman Reviewed-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/powerpc/include/asm/archrandom.h | 8 1 file

[PATCH v2 08/10] powerpc: Use bool in archrandom.h

2020-01-10 Thread Mark Brown
From: Richard Henderson The generic interface uses bool not int; match that. Reviewed-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/powerpc/include/asm/archrandom.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH v2 07/10] x86: Mark archrandom.h functions __must_check

2020-01-10 Thread Mark Brown
From: Richard Henderson We must not use the pointer output without validating the success of the random read. Reviewed-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/x86/include/asm/archrandom.h | 16 1 file changed, 8 insertions(+),

[PATCH v2 06/10] linux/random.h: Mark CONFIG_ARCH_RANDOM functions __must_check

2020-01-10 Thread Mark Brown
From: Richard Henderson We must not use the pointer output without validating the success of the random read. Reviewed-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- include/linux/random.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

[PATCH v2 05/10] linux/random.h: Use false with bool

2020-01-10 Thread Mark Brown
From: Richard Henderson Keep the generic fallback versions in sync with the other architecture specific implementations and use the proper name for false. Suggested-by: Ard Biesheuvel Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- include/linux/random.h | 8 1 file

[PATCH v2 04/10] linux/random.h: Remove arch_has_random, arch_has_random_seed

2020-01-10 Thread Mark Brown
From: Richard Henderson The arm64 version of archrandom.h will need to be able to test for support and read the random number without preemption, so a separate query predicate is not practical. Since this part of the generic interface is unused, remove it. Signed-off-by: Richard Henderson

[PATCH v2 03/10] s390: Remove arch_has_random, arch_has_random_seed

2020-01-10 Thread Mark Brown
From: Richard Henderson These symbols are currently part of the generic archrandom.h interface, but are currently unused and can be removed. Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/s390/include/asm/archrandom.h | 12 1 file changed, 12 deletions(-)

[PATCH v2 01/10] x86: Remove arch_has_random, arch_has_random_seed

2020-01-10 Thread Mark Brown
From: Richard Henderson Use the expansion of these macros directly in arch_get_random_*. These symbols are currently part of the generic archrandom.h interface, but are currently unused and can be removed. Signed-off-by: Richard Henderson Signed-off-by: Mark Brown ---

[PATCH v2 02/10] powerpc: Remove arch_has_random, arch_has_random_seed

2020-01-10 Thread Mark Brown
From: Richard Henderson These symbols are currently part of the generic archrandom.h interface, but are currently unused and can be removed. Signed-off-by: Richard Henderson Signed-off-by: Mark Brown --- arch/powerpc/include/asm/archrandom.h | 10 -- 1 file changed, 10 deletions(-)

[PATCH v2 00/10] Impveovements for random.h/archrandom.h

2020-01-10 Thread Mark Brown
This is a resend of a series from Richard Henderson last posted back in November: https://lore.kernel.org/linux-arm-kernel/20191106141308.30535-1-...@twiddle.net/ Back then Borislav said they looked good and asked if he should take them through the tip tree but things seem to have got lost

Re: [PATCH v4 2/9] perf/core: open access for CAP_SYS_PERFMON privileged process

2020-01-10 Thread Peter Zijlstra
On Thu, Jan 09, 2020 at 02:36:50PM +0300, Alexey Budankov wrote: > On 08.01.2020 19:07, Peter Zijlstra wrote: > > On Wed, Dec 18, 2019 at 12:25:35PM +0300, Alexey Budankov wrote: > >> diff --git a/kernel/events/core.c b/kernel/events/core.c > >> index 059ee7116008..d9db414f2197 100644 > >> ---

Re: [PATCH v2 9/9] net: wireless: ath5k: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-10 Thread Kalle Valo
Krzysztof Kozlowski writes: > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version

Re: [PATCH v2 2/9] net: wireless: rtl818x: Constify ioreadX() iomem argument (as in generic implementation)

2020-01-10 Thread Kalle Valo
Krzysztof Kozlowski writes: > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version

Re: [PATCH 06/18] powerpc sstep: Add support for prefixed integer load/stores

2020-01-10 Thread Balamuruhan S
On Tue, Nov 26, 2019 at 04:21:29PM +1100, Jordan Niethe wrote: > This adds emulation support for the following prefixed integer > load/stores: > * Prefixed Load Byte and Zero (plbz) > * Prefixed Load Halfword and Zero (plhz) > * Prefixed Load Halfword Algebraic (plha) > * Prefixed Load

[Bug 205201] Booting halts if Dawicontrol DC-2976 UW SCSI board installed, unless RAM size limited to 3500M

2020-01-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205201 Roland (rj.ron...@gmail.com) changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 205201] Booting halts if Dawicontrol DC-2976 UW SCSI board installed, unless RAM size limited to 3500M

2020-01-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205201 --- Comment #17 from Roland (rj.ron...@gmail.com) --- Kernel 5.5 alpha 1 fixed the issue with Dawicontrol DC-2976 UW SCSI board. Also a RTL 8169 ethernet card which had similar type of problem with earlier kernels works now with full (8 GB) Ram.

Re: [PATCH 2/3] powerpc sstep: add support for divde[.] and divdeu[.] instructions

2020-01-10 Thread Balamuruhan S
On Thu, Jan 09, 2020 at 09:23:14AM +1100, Paul Mackerras wrote: > On Tue, Dec 10, 2019 at 12:49:03PM +0530, Balamuruhan S wrote: > > This patch adds emulation support for divde, divdeu instructions, > > * Divide Doubleword Extended (divde[.]) > > * Divide Doubleword Extended Unsigned

[PATCH] powerpc/ptdump: don't entirely rebuild kernel when selecting CONFIG_PPC_DEBUG_WX

2020-01-10 Thread Christophe Leroy
Selecting CONFIG_PPC_DEBUG_WX only impacts ptdump and pgtable_32/64 init calls. Declaring related functions in asm/pgtable.h implies rebuilding almost everything. Move ptdump_check_wx() declaration in a new dedicated header file. Signed-off-by: Christophe Leroy ---