[powerpc:next-test] BUILD SUCCESS dbbd7a68c8d47293bd8d027841b06dd5137e0fcc

2020-08-03 Thread kernel test robot
allnoconfig powerpc defconfig i386 randconfig-a004-20200803 i386 randconfig-a005-20200803 i386 randconfig-a001-20200803 i386 randconfig-a002-20200803 i386 randconfig-a003-20200803 i386

[powerpc:next] BUILD SUCCESS 2075ec9896c5aef01e837198381d04cfa6452317

2020-08-03 Thread kernel test robot
allmodconfig powerpc allnoconfig powerpc defconfig i386 randconfig-a004-20200803 i386 randconfig-a005-20200803 i386 randconfig-a001-20200803 i386 randconfig-a002

[powerpc:merge] BUILD SUCCESS a3dcfbc2456df1a2d416b7d0b627d9cededa1432

2020-08-03 Thread kernel test robot
allyesconfig powerpc allmodconfig powerpc allnoconfig powerpc defconfig i386 randconfig-a004-20200803 i386 randconfig-a005-20200803 i386 randconfig-a001-20200803 i386

[PATCH 2/2] powerpc/topology: Override cpu_smt_mask

2020-08-03 Thread Srikar Dronamraju
On Power9 a pair of cores can be presented by the firmware as a big-core for backward compatibility reasons, with 4 threads per (small) core and 8 threads per big-core. cpu_smt_mask() should generally point to the cpu mask of the (small)core. In order to maintain userspace backward compatibility

[PATCH 1/2] sched/topology: Allow archs to override cpu_smt_mask

2020-08-03 Thread Srikar Dronamraju
cpu_smt_mask tracks topology_sibling_cpumask. This would be good for most architectures. One of the users of cpu_smt_mask(), would be to identify idle-cores. On Power9, a pair of cores can be presented by the firmware as a big-core for backward compatibility reasons. In order to maintain

[PATCH] powerpc/pseries/hotplug-cpu: increase wait time for vCPU death

2020-08-03 Thread Michael Roth
For a power9 KVM guest with XIVE enabled, running a test loop where we hotplug 384 vcpus and then unplug them, the following traces can be seen (generally within a few loops) either from the unplugged vcpu: [ 1767.353447] cpu 65 (hwid 65) Ready to die... [ 1767.952096] Querying DEAD? cpu 66

Re: [PATCH 5/6] powerpc/powernv/pci: Drop unused parent variable

2020-08-03 Thread Joel Stanley
On Tue, 4 Aug 2020 at 01:06, Oliver O'Halloran wrote: > > The "parent" variable in pnv_pci_ioda_configure_pe() isn't used for > anything anymore and can be dropped. > > Signed-off-by: Oliver O'Halloran Reviewed-by: Joel Stanley

Re: [PATCH 4/6] powerpc/powernv: Fix spurious kerneldoc warnings in opal-prd.c

2020-08-03 Thread Joel Stanley
On Tue, 4 Aug 2020 at 01:03, Oliver O'Halloran wrote: > > Comments opening with /** are parsed by kerneldoc and this causes the > following warning to be printed: > > arch/powerpc/platforms/powernv/opal-prd.c:31: warning: cannot > understand > function prototype: 'struct

Re: [PATCH 3/6] powerpc/powernv: Staticify functions without prototypes

2020-08-03 Thread Joel Stanley
On Tue, 4 Aug 2020 at 01:01, Oliver O'Halloran wrote: > > There's a few scattered in the powernv platform. > > Signed-off-by: Oliver O'Halloran > +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c > @@ -38,7 +38,7 @@ > > static int eeh_event_irq = -EINVAL; > > -void

Re: [PATCH 1/6] powerpc/powernv/smp: Fix spurious DBG() warning

2020-08-03 Thread Joel Stanley
On Tue, 4 Aug 2020 at 00:57, Oliver O'Halloran wrote: > > When building with W=1 we get the following warning: > > arch/powerpc/platforms/powernv/smp.c: In function ‘pnv_smp_cpu_kill_self’: > arch/powerpc/platforms/powernv/smp.c:276:16: error: suggest braces around > empty body in an

Re: [merge] Build failure selftest/powerpc/mm/pkey_exec_prot

2020-08-03 Thread Michael Ellerman
Sandipan Das writes: > On 03/08/20 4:32 pm, Michael Ellerman wrote: >> Sachin Sant writes: On 02-Aug-2020, at 10:58 PM, Sandipan Das wrote: On 02/08/20 4:45 pm, Sachin Sant wrote: > pkey_exec_prot test from linuxppc merge branch (3f68564f1f5a) fails to > build due to following

[PATCH 6/6] powerpc/nx: Don't pack struct coprocessor_request_block

2020-08-03 Thread Oliver O'Halloran
Building with W=1 results in the following warning: In file included from arch/powerpc/platforms/powernv/vas-fault.c:16: ./arch/powerpc/include/asm/icswx.h:159:1: error: alignment 1 of ‘struct coprocessor_request_block’ is less than 16 [-Werror=packed-not-aligned] 159 | } __packed;

[PATCH 5/6] powerpc/powernv/pci: Drop unused parent variable

2020-08-03 Thread Oliver O'Halloran
The "parent" variable in pnv_pci_ioda_configure_pe() isn't used for anything anymore and can be dropped. Signed-off-by: Oliver O'Halloran --- arch/powerpc/platforms/powernv/pci-ioda.c | 8 1 file changed, 8 deletions(-) diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c

[PATCH 4/6] powerpc/powernv: Fix spurious kerneldoc warnings in opal-prd.c

2020-08-03 Thread Oliver O'Halloran
Comments opening with /** are parsed by kerneldoc and this causes the following warning to be printed: arch/powerpc/platforms/powernv/opal-prd.c:31: warning: cannot understand function prototype: 'struct opal_prd_msg_queue_item ' opal_prd_mesg_queue_item is an internal data

[PATCH 3/6] powerpc/powernv: Staticify functions without prototypes

2020-08-03 Thread Oliver O'Halloran
There's a few scattered in the powernv platform. Signed-off-by: Oliver O'Halloran --- arch/powerpc/platforms/powernv/eeh-powernv.c | 4 ++-- arch/powerpc/platforms/powernv/rng.c | 2 +- arch/powerpc/platforms/powernv/vas-window.c | 9 - 3 files changed, 7 insertions(+), 8

[PATCH 2/6] powerpc/powernv: Include asm/powernv.h from the local powernv.h

2020-08-03 Thread Oliver O'Halloran
The asm/powernv.h header provides prototypes for functions which need to be called by non-powernv platform code. Also include it in the powernv.h that's local to the platform directory to squash some warnings about non-static functions missing prototypes. Also include powernv.h since from

[PATCH 1/6] powerpc/powernv/smp: Fix spurious DBG() warning

2020-08-03 Thread Oliver O'Halloran
When building with W=1 we get the following warning: arch/powerpc/platforms/powernv/smp.c: In function ‘pnv_smp_cpu_kill_self’: arch/powerpc/platforms/powernv/smp.c:276:16: error: suggest braces around empty body in an ‘if’ statement [-Werror=empty-body] 276 | cpu, srr1);

Clean up W=1 for the powernv platform

2020-08-03 Thread Oliver O'Halloran
Fixes the (mostly) suprious errors we get when building powernv with W=1. More work is required to build all of powerpc with W=1, let alone W=2.

Re: powerpc: build failures in Linus' tree

2020-08-03 Thread Michael Ellerman
Stephen Rothwell writes: > On Mon, 03 Aug 2020 21:18:00 +1000 Michael Ellerman > wrote: >> >> If we just move the include of asm/paca.h below asm-generic/percpu.h >> then it avoids the bad circular dependency and we still have paca.h >> included from percpu.h as before. >> >> eg: >> >> diff

Re: [PATCH v2 15/16] powerpc/powernv/sriov: Make single PE mode a per-BAR setting

2020-08-03 Thread Segher Boessenkool
On Mon, Aug 03, 2020 at 03:57:11PM +1000, Michael Ellerman wrote: > > I would assume the function should still be generated since those checks > > are relevant, just the return value is bogus. > > Yeah, just sometimes missing warnings boil down to the compiler eliding > whole sections of code, if

Re: [PATCHv4 2/2] powerpc/pseries: update device tree before ejecting hotplug uevents

2020-08-03 Thread Laurent Dufour
Le 30/07/2020 à 15:33, Pingfan Liu a écrit : A bug is observed on pseries by taking the following steps on rhel: -1. drmgr -c mem -r -q 5 -2. echo c > /proc/sysrq-trigger And then, the failure looks like: kdump: saving to /sysroot//var/crash/127.0.0.1-2020-01-16-02:06:14/ kdump: saving

RE: [PATCH v2] selftests/powerpc: Fix pkey syscall redefinitions

2020-08-03 Thread David Laight
> > +#undef SYS_pkey_mprotect > > #define SYS_pkey_mprotect 386 > > We shouldn't undef them. > > They should obviously never change, but if the system headers already > have a definition then we should use that, so I think it should be: > > #ifndef SYS_pkey_mprotect > #define

Re: [PATCH v3] selftests/powerpc: Fix pkey syscall redefinitions

2020-08-03 Thread Sachin Sant
> On 03-Aug-2020, at 4:53 PM, Sandipan Das wrote: > > On some distros, there are conflicts w.r.t to redefinition > of pkey syscall numbers which cause build failures. This > fixes them. > > Reported-by: Sachin Sant > Signed-off-by: Sandipan Das > — Thanks for the fix. Tested-by: Sachin

Re: [PATCHv4 1/2] powerpc/pseries: group lmb operation and memblock's

2020-08-03 Thread Laurent Dufour
@@ -603,6 +606,8 @@ static int dlpar_add_lmb(struct drmem_lmb *lmb) } lmb_set_nid(lmb); + lmb->flags |= DRCONF_MEM_ASSIGNED; + block_sz = memory_block_size_bytes(); /* Add the memory */ Since the lmb->flags is now set earlier, you should unset it in the

Re: [PATCH] powerpc: Fix P10 PVR revision in /proc/cpuinfo for SMT4 cores

2020-08-03 Thread Michael Ellerman
Michael Neuling writes: > On POWER10 bit 12 in the PVR indicates if the core is SMT4 or > SMT8. Bit 12 is set for SMT4. > > Without this patch, /proc/cpuinfo on a SMT4 DD1 POWER10 looks like > this: > cpu : POWER10, altivec supported > revision: 17.0 (pvr 0080 1100) >

Re: powerpc: build failures in Linus' tree

2020-08-03 Thread Stephen Rothwell
Hi Michael, On Mon, 03 Aug 2020 21:18:00 +1000 Michael Ellerman wrote: > > If we just move the include of asm/paca.h below asm-generic/percpu.h > then it avoids the bad circular dependency and we still have paca.h > included from percpu.h as before. > > eg: > > diff --git

Re: powerpc: build failures in Linus' tree

2020-08-03 Thread Willy Tarreau
On Mon, Aug 03, 2020 at 09:18:00PM +1000, Michael Ellerman wrote: > If we just move the include of asm/paca.h below asm-generic/percpu.h > then it avoids the bad circular dependency and we still have paca.h > included from percpu.h as before. > > eg: > > diff --git

Re: [PATCH v2] selftests/powerpc: Fix pkey syscall redefinitions

2020-08-03 Thread Sandipan Das
On 03/08/20 4:34 pm, Michael Ellerman wrote: > Sandipan Das writes: >> On some distros, there are conflicts w.r.t to redefinition >> of pkey syscall numbers which cause build failures. This >> fixes them. >> >> Reported-by: Sachin Sant >> Signed-off-by: Sandipan Das >> --- >> Previous

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-08-03 Thread Geert Uytterhoeven
Hi Michael, On Mon, Aug 3, 2020 at 1:09 PM Michael Ellerman wrote: > Geert Uytterhoeven writes: > > On Mon, Jul 20, 2020 at 11:03 PM Segher Boessenkool > > wrote: > >> On Sat, Jul 18, 2020 at 09:50:50AM +0200, Geert Uytterhoeven wrote: > >> > On Wed, Jun 24, 2020 at 6:02 AM Nathan Chancellor >

Re: [merge] Build failure selftest/powerpc/mm/pkey_exec_prot

2020-08-03 Thread Sandipan Das
Hi Michael, On 03/08/20 4:32 pm, Michael Ellerman wrote: > Sachin Sant writes: >>> On 02-Aug-2020, at 10:58 PM, Sandipan Das wrote: >>> On 02/08/20 4:45 pm, Sachin Sant wrote: pkey_exec_prot test from linuxppc merge branch (3f68564f1f5a) fails to build due to following error:

[PATCH v3] selftests/powerpc: Fix pkey syscall redefinitions

2020-08-03 Thread Sandipan Das
On some distros, there are conflicts w.r.t to redefinition of pkey syscall numbers which cause build failures. This fixes them. Reported-by: Sachin Sant Signed-off-by: Sandipan Das --- Previous versions can be found at: v2:

Re: powerpc: build failures in Linus' tree

2020-08-03 Thread Michael Ellerman
Willy Tarreau writes: > On Sun, Aug 02, 2020 at 07:20:19PM +0200, Willy Tarreau wrote: >> On Sun, Aug 02, 2020 at 08:48:42PM +1000, Stephen Rothwell wrote: >> > Hi all, >> > >> > We are getting build failures in some PowerPC configs for Linus' tree. >> > See e.g.

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-08-03 Thread Michael Ellerman
Geert Uytterhoeven writes: > On Mon, Jul 20, 2020 at 11:03 PM Segher Boessenkool > wrote: >> On Sat, Jul 18, 2020 at 09:50:50AM +0200, Geert Uytterhoeven wrote: >> > On Wed, Jun 24, 2020 at 6:02 AM Nathan Chancellor >> > wrote: >> > > /* If we have an image attached to us, it overrides

Re: [PATCH v2] selftests/powerpc: Fix pkey syscall redefinitions

2020-08-03 Thread Michael Ellerman
Sandipan Das writes: > On some distros, there are conflicts w.r.t to redefinition > of pkey syscall numbers which cause build failures. This > fixes them. > > Reported-by: Sachin Sant > Signed-off-by: Sandipan Das > --- > Previous versions can be found at: > v1: >

Re: [merge] Build failure selftest/powerpc/mm/pkey_exec_prot

2020-08-03 Thread Michael Ellerman
Sachin Sant writes: >> On 02-Aug-2020, at 10:58 PM, Sandipan Das wrote: >> On 02/08/20 4:45 pm, Sachin Sant wrote: >>> pkey_exec_prot test from linuxppc merge branch (3f68564f1f5a) fails to >>> build due to following error: >>> >>> gcc -std=gnu99 -O2 -Wall -Werror >>>

Re: [PATCH] powerpc: Fix P10 PVR revision in /proc/cpuinfo for SMT4 cores

2020-08-03 Thread Vaidyanathan Srinivasan
* Michael Neuling [2020-08-03 13:56:00]: > On POWER10 bit 12 in the PVR indicates if the core is SMT4 or > SMT8. Bit 12 is set for SMT4. > > Without this patch, /proc/cpuinfo on a SMT4 DD1 POWER10 looks like > this: > cpu : POWER10, altivec supported > revision: 17.0

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-08-03 Thread Geert Uytterhoeven
Hi Segher, On Mon, Jul 20, 2020 at 11:03 PM Segher Boessenkool wrote: > On Sat, Jul 18, 2020 at 09:50:50AM +0200, Geert Uytterhoeven wrote: > > On Wed, Jun 24, 2020 at 6:02 AM Nathan Chancellor > > wrote: > > > /* If we have an image attached to us, it overrides anything > > >

Re: Build regressions/improvements in v5.8

2020-08-03 Thread Geert Uytterhoeven
On Mon, Aug 3, 2020 at 11:53 AM Geert Uytterhoeven wrote: > JFYI, when comparing v5.8[1] to v5.8-rc7[3], the summaries are: > - build errors: +2/-3 + /kisskb/src/arch/powerpc/include/asm/mmu.h: error: unknown type name 'next_tlbcam_idx': => 139:22

[PATCH v2] selftests/powerpc: Fix pkey syscall redefinitions

2020-08-03 Thread Sandipan Das
On some distros, there are conflicts w.r.t to redefinition of pkey syscall numbers which cause build failures. This fixes them. Reported-by: Sachin Sant Signed-off-by: Sandipan Das --- Previous versions can be found at: v1:

[PATCH] powerpc/powernv/sriov: Fix use of uninitialised variable

2020-08-03 Thread Oliver O'Halloran
Initialising the value before using it is generally regarded as a good idea so do that. Fixes: 4c51f3e1e870 ("powerpc/powernv/sriov: Make single PE mode a per-BAR setting") Reported-by: Nathan Chancellor Signed-off-by: Oliver O'Halloran --- arch/powerpc/platforms/powernv/pci-sriov.c | 4 +---

[PATCH] selftests/powerpc: Fix pkey syscall redefinitions

2020-08-03 Thread Sandipan Das
Some distros have the pkey syscall numbers defined under unistd.h. This conflicts with the definitions in the pkeys selftest header and causes build failures. E.g. this works $ grep -nr "SYS_pkey" /usr/include/ /usr/include/bits/syscall.h:1575:# define SYS_pkey_alloc __NR_pkey_alloc

Re: [PATCH 2/2 v2] powerpc/powernv: Enable and setup PCI P2P

2020-08-03 Thread Oliver O'Halloran
On Thu, Apr 30, 2020 at 11:15 PM Max Gurtovoy wrote: > diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c > b/arch/powerpc/platforms/powernv/pci-ioda.c > index 57d3a6a..9ecc576 100644 > --- a/arch/powerpc/platforms/powernv/pci-ioda.c > +++ b/arch/powerpc/platforms/powernv/pci-ioda.c > @@

linux-next: manual merge of the char-misc tree with the powerpc tree

2020-08-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the char-misc tree got a conflict in: drivers/misc/ocxl/config.c between commit: 3591538a31af ("ocxl: Address kernel doc errors & warnings") from the powerpc tree and commit: 28fc491e9be6 ("misc: ocxl: config: Provide correct formatting to function

Re: [PATCH v4 09/10] Powerpc/smp: Create coregroup domain

2020-08-03 Thread Srikar Dronamraju
> > Also in the current P9 itself, two neighbouring core-pairs form a quad. > > Cache latency within a quad is better than a latency to a distant core-pair. > > Cache latency within a core pair is way better than latency within a quad. > > So if we have only 4 threads running on a DIE all of them