Re: [PATCH] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-04 Thread Andrew Lunn
On Tue, Jan 05, 2021 at 01:22:29PM +1100, Michael Ellerman wrote: > Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() > into error") the ppc32_allmodconfig build fails with: > > ERROR: modpost: missing MODULE_LICENSE() in > drivers/net/ethernet/freescale/fs_enet/mii-fec.o >

[Bug 210911] error: implicit declaration of function 'cleanup_cpu_mmu_context' [-Werror=implicit-function-declaration]

2021-01-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210911 Michael Ellerman (mich...@ellerman.id.au) changed: What|Removed |Added Status|RESOLVED|CLOSED --

[Bug 210911] error: implicit declaration of function 'cleanup_cpu_mmu_context' [-Werror=implicit-function-declaration]

2021-01-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210911 Michael Ellerman (mich...@ellerman.id.au) changed: What|Removed |Added Status|NEW |RESOLVED

[PATCH] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-04 Thread Michael Ellerman
Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into error") the ppc32_allmodconfig build fails with: ERROR: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/freescale/fs_enet/mii-fec.o ERROR: modpost: missing MODULE_LICENSE() in

Re: [PATCH] scsi: target/sbp: remove firewire SBP target driver

2021-01-04 Thread Bart Van Assche
On 1/4/21 2:50 PM, Finn Thain wrote: > On Mon, 4 Jan 2021, Bart Van Assche wrote: >> Additionally, there is a good alternative available for the sbp driver. >> Every system I know of that is equipped with a Firewire port also has an >> Ethernet port. So users who want to provide SCSI target

[PATCH AUTOSEL 5.10 13/17] local64.h: make mandatory

2021-01-04 Thread Sasha Levin
From: Randy Dunlap [ Upstream commit 87dbc209ea04645fd2351981f09eff5d23f8e2e9 ] Make mandatory in include/asm-generic/Kbuild and remove all arch/*/include/asm/local64.h arch-specific files since they only #include . This fixes build errors on arch/c6x/ and arch/nios2/ for block/blk-iocost.c.

Re: [PATCH] scsi: target/sbp: remove firewire SBP target driver

2021-01-04 Thread Finn Thain
On Mon, 4 Jan 2021, Bart Van Assche wrote: > On 6/16/20 7:07 PM, Finn Thain wrote: > > On Tue, 16 Jun 2020, Bart Van Assche wrote: > >> As far as I know the sbp driver only has had one user ever and that > >> user is no longer user the sbp driver. > > > > So, you estimate the userbase at zero.

[PATCH v2 4/5] ibmvfc: complete commands outside the host/queue lock

2021-01-04 Thread Tyrel Datwyler
Drain the command queue and place all commands on a completion list. Perform command completion on that list outside the host/queue locks. Further, move purged command compeletions outside the host_lock as well. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- Changes in v2: * Changed

Re: [PATCH 4/5 v2] ibmvfc: relax locking around ibmvfc_queuecommand

2021-01-04 Thread Tyrel Datwyler
On 1/4/21 2:17 PM, Tyrel Datwyler wrote: > The drivers queuecommand routine is still wrapped to hold the host lock > for the duration of the call. This will become problematic when moving > to multiple queues due to the lock contention preventing asynchronous > submissions to mulitple queues.

[PATCH 4/5 v2] ibmvfc: relax locking around ibmvfc_queuecommand

2021-01-04 Thread Tyrel Datwyler
The drivers queuecommand routine is still wrapped to hold the host lock for the duration of the call. This will become problematic when moving to multiple queues due to the lock contention preventing asynchronous submissions to mulitple queues. There is no real legatimate reason to hold the host

Re: [PATCH] ibmvnic: fix: NULL pointer dereference.

2021-01-04 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Wed, 30 Dec 2020 15:23:14 +0800 you wrote: > The error is due to dereference a null pointer in function > reset_one_sub_crq_queue(): > > if (!scrq) { > netdev_dbg(adapter->netdev, >"Invalid scrq reset.

[PATCH v2] powerpc: Handle .text.{hot,unlikely}.* in linker script

2021-01-04 Thread Nathan Chancellor
Commit eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input sections") added ".text.unlikely.*" and ".text.hot.*" due to an LLVM change [1]. After another LLVM change [2], these sections are seen in some PowerPC builds, where there is a orphan section warning then build failure: $ make

Re: [PATCH] powerpc: Handle .text.{hot,unlikely}.* in linker script

2021-01-04 Thread Nathan Chancellor
On Mon, Jan 04, 2021 at 09:55:20PM +0100, Sedat Dilek wrote: > On Mon, Jan 4, 2021 at 9:49 PM Nathan Chancellor > wrote: > > > > Commit eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input > > sections") added ".text.unlikely.*" and ".text.hot.*" due to an LLVM > > change [1]. > > > > After

Re: [PATCH] powerpc: Handle .text.{hot,unlikely}.* in linker script

2021-01-04 Thread Sedat Dilek
On Mon, Jan 4, 2021 at 9:49 PM Nathan Chancellor wrote: > > Commit eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input > sections") added ".text.unlikely.*" and ".text.hot.*" due to an LLVM > change [1]. > > After another LLVM change [2], these sections are seen in some PowerPC > builds,

[PATCH] powerpc: Handle .text.{hot,unlikely}.* in linker script

2021-01-04 Thread Nathan Chancellor
Commit eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input sections") added ".text.unlikely.*" and ".text.hot.*" due to an LLVM change [1]. After another LLVM change [2], these sections are seen in some PowerPC builds, where there is a orphan section warning then build failure: $ make

Re: [GIT PULL] Fix kprobes issue by moving RCU-tasks initialization earlier

2021-01-04 Thread pr-tracker-bot
The pull request you sent on Mon, 4 Jan 2021 10:19:34 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/urgent has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/36bbbd0e234d817938bdc52121a0f5473b3e58f5 Thank you! -- Deet-doot-dot, I am a

[GIT PULL] Fix kprobes issue by moving RCU-tasks initialization earlier

2021-01-04 Thread Paul E. McKenney
Hello, Linus, This fix is for a regression in the v5.10 merge window, but it was reported quite late in the v5.10 process, plus generating and testing the fix took some time. The regression is due to 36dadef23fcc ("kprobes: Init kprobes in early_initcall") which on powerpc can use RCU Tasks

Re: [PATCH] scsi: target/sbp: remove firewire SBP target driver

2021-01-04 Thread Bart Van Assche
On 6/16/20 7:07 PM, Finn Thain wrote: > On Tue, 16 Jun 2020, Bart Van Assche wrote: >> As far as I know the sbp driver only has had one user ever and that user >> is no longer user the sbp driver. > > So, you estimate the userbase at zero. Can you give a confidence level? > Actual measurement

[PATCH v2 05/23] powerpc/pmem: Include pmem prototypes

2021-01-04 Thread Cédric Le Goater
It fixes this W=1 compile error : ../arch/powerpc/lib/pmem.c:51:6: error: no previous prototype for ‘arch_wb_cache_pmem’ [-Werror=missing-prototypes] 51 | void arch_wb_cache_pmem(void *addr, size_t size) | ^~ ../arch/powerpc/lib/pmem.c:58:6: error: no previous

[PATCH v2 01/23] powerpc/mm: Include __find_linux_pte() prototype

2021-01-04 Thread Cédric Le Goater
It fixes this W=1 compile error : ../arch/powerpc/mm/pgtable.c:337:8: error: no previous prototype for ‘__find_linux_pte’ [-Werror=missing-prototypes] 337 | pte_t *__find_linux_pte(pgd_t *pgdir, unsigned long ea, |^~~~ Cc: "Aneesh Kumar K.V" Signed-off-by: Cédric Le

[PATCH v2 06/23] powerpc/setup_64: Make some routines static

2021-01-04 Thread Cédric Le Goater
The following routines are only called by local services and do not need to be external symbols. It fixes these W=1 errors : ../arch/powerpc/kernel/setup_64.c:261:13: error: no previous prototype for ‘record_spr_defaults’ [-Werror=missing-prototypes] 261 | void __init

[PATCH v2 22/23] powerpc/pcidn: Make IOV setup routines static

2021-01-04 Thread Cédric Le Goater
These are only used locally. It fixes these W=1 compile errors : ../arch/powerpc/platforms/pseries/pci.c:58:5: error: no previous prototype for ‘pseries_send_map_pe’ [-Werror=missing-prototypes] 58 | int pseries_send_map_pe(struct pci_dev *pdev, | ^~~

[PATCH v2 20/23] KVM: PPC: Book3S HV: Declare some prototypes

2021-01-04 Thread Cédric Le Goater
This fixes these W=1 compile errors: ../arch/powerpc/kvm/book3s_hv_builtin.c:425:6: error: no previous prototype for ‘kvmppc_read_intr’ [-Werror=missing-prototypes] 425 | long kvmppc_read_intr(void) | ^~~~ ../arch/powerpc/kvm/book3s_hv_builtin.c:652:6: error: no previous

[PATCH v2 00/23] powerpc: Fix W=1 compile errors

2021-01-04 Thread Cédric Le Goater
Hello, Here is an assorted collection of fixes for W=1. After this series, only a few errors are left, some missing declarations in arch/powerpc/kernel/sys_ppc32.c, panic_smp_self_stop() declaration and a few of these which I don't know how to fix : ./arch/powerpc/xmon/xmon.c: In function

[PATCH v2 21/23] powerpc/pseries: Make IOV setup routines static

2021-01-04 Thread Cédric Le Goater
These are only used locally. It fixes these W=1 compile errors : ../arch/powerpc/platforms/pseries/setup.c:610:17: error: no previous prototype for ‘pseries_get_iov_fw_value’ [-Werror=missing-prototypes] 610 | resource_size_t pseries_get_iov_fw_value(struct pci_dev *dev, int resno, |

[PATCH v2 17/23] powerpc/watchdog: Declare soft_nmi_interrupt() prototype

2021-01-04 Thread Cédric Le Goater
soft_nmi_interrupt() usage requires PPC_WATCHDOG to be configured. Check the CONFIG definition to declare the prototype. It fixes this W=1 compile error : ../arch/powerpc/kernel/watchdog.c:250:6: error: no previous prototype for ‘soft_nmi_interrupt’ [-Werror=missing-prototypes] 250 | void

[PATCH v2 19/23] KVM: PPC: Book3S HV: Include prototypes

2021-01-04 Thread Cédric Le Goater
It fixes these W=1 compile errors : CC [M] arch/powerpc/kvm/book3s_64_mmu_hv.o ../arch/powerpc/kvm/book3s_64_mmu_hv.c:879:5: error: no previous prototype for ‘kvm_unmap_hva_range_hv’ [-Werror=missing-prototypes] 879 | int kvm_unmap_hva_range_hv(struct kvm *kvm, unsigned long start, unsigned

[PATCH v2 18/23] KVM: PPC: Make the VMX instruction emulation routines static

2021-01-04 Thread Cédric Le Goater
These are only used locally. It fixes these W=1 compile errors : ../arch/powerpc/kvm/powerpc.c:1521:5: error: no previous prototype for ‘kvmppc_get_vmx_dword’ [-Werror=missing-prototypes] 1521 | int kvmppc_get_vmx_dword(struct kvm_vcpu *vcpu, int index, u64 *val) |

[PATCH v2 16/23] powerpc/mm: Declare arch_report_meminfo() prototype.

2021-01-04 Thread Cédric Le Goater
It fixes this W=1 compile error : ../arch/powerpc/mm/book3s64/pgtable.c:411:6: error: no previous prototype for ‘arch_report_meminfo’ [-Werror=missing-prototypes] 411 | void arch_report_meminfo(struct seq_file *m) | ^~~ Cc: "Aneesh Kumar K.V" Signed-off-by: Cédric

[PATCH v2 14/23] powerpc/mm: Declare preload_new_slb_context() prototype

2021-01-04 Thread Cédric Le Goater
It fixes this W=1 compile error : ../arch/powerpc/mm/book3s64/slb.c:380:6: error: no previous prototype for ‘preload_new_slb_context’ [-Werror=missing-prototypes] 380 | void preload_new_slb_context(unsigned long start, unsigned long sp) | ^~~ Cc: "Aneesh Kumar

[PATCH v2 23/23] powerpc/pseries/eeh: Make pseries_send_allow_unfreeze() static

2021-01-04 Thread Cédric Le Goater
Only used locally. It fixes this W=1 compile error : ../arch/powerpc/platforms/pseries/eeh_pseries.c:697:5: error: no previous prototype for ‘pseries_send_allow_unfreeze’ [-Werror=missing-prototypes] 697 | int pseries_send_allow_unfreeze(struct pci_dn *pdn, |

[PATCH v2 02/23] powerpc/pseries/ras: Remove unused variable 'status'

2021-01-04 Thread Cédric Le Goater
The last use of 'status' was removed in 2012. Remove the variable to fix this W=1 compile error. ../arch/powerpc/platforms/pseries/ras.c: In function ‘ras_epow_interrupt’: ../arch/powerpc/platforms/pseries/ras.c:318:6: error: variable ‘status’ set but not used [-Werror=unused-but-set-variable]

[PATCH v2 09/23] powerpc/smp: Make debugger_ipi_callback() static

2021-01-04 Thread Cédric Le Goater
debugger_ipi_callback() is a local routine used as a NMI IPI handler and does not need to be external. It fixes this W=1 compile error : ../arch/powerpc/kernel/smp.c:579:6: error: no previous prototype for ‘debugger_ipi_callback’ [-Werror=missing-prototypes] 579 | void

[PATCH v2 10/23] powerpc/optprobes: Remove unused routine patch_imm32_load_insns()

2021-01-04 Thread Cédric Le Goater
Commit 650b55b707fd ("powerpc: Add prefixed instructions to instruction data type") removed the use of patch_imm32_load_insns(). Clean it up to fix this W=1 compile error : ../arch/powerpc/kernel/optprobes.c:149:6: error: no previous prototype for ‘patch_imm32_load_insns’

[PATCH v2 12/23] powerpc/mm: Declare some prototypes

2021-01-04 Thread Cédric Le Goater
It fixes this W=1 compile error : ../arch/powerpc/mm/book3s64/hash_utils.c:1515:5: error: no previous prototype for ‘__hash_page’ [-Werror=missing-prototypes] 1515 | int __hash_page(unsigned long trap, unsigned long ea, unsigned long dsisr, | ^~~

[PATCH v2 08/23] powerpc/smp: Include tick_broadcast() prototype

2021-01-04 Thread Cédric Le Goater
It fixes this W=1 compile error : ../arch/powerpc/kernel/smp.c:569:6: error: no previous prototype for ‘tick_broadcast’ [-Werror=missing-prototypes] 569 | void tick_broadcast(const struct cpumask *mask) | ^~ Cc: "Gautham R. Shenoy" Signed-off-by: Cédric Le Goater ---

[PATCH v2 15/23] powerpc/mm/hugetlb: Make pseries_alloc_bootmem_huge_page() static

2021-01-04 Thread Cédric Le Goater
pseries_alloc_bootmem_huge_page() is only used locally in alloc_bootmem_huge_page() and does not need to be external. It fixes this W=1 compile error : ../arch/powerpc/mm/hugetlbpage.c:220:12: error: no previous prototype for ‘pseries_alloc_bootmem_huge_page’ [-Werror=missing-prototypes] 220

[PATCH v2 13/23] powerpc/mm: Move hpte_insert_repeating() prototype

2021-01-04 Thread Cédric Le Goater
It fixes this W=1 compile error : ../arch/powerpc/mm/book3s64/hash_utils.c:1867:6: error: no previous prototype for ‘hpte_insert_repeating’ [-Werror=missing-prototypes] 1867 | long hpte_insert_repeating(unsigned long hash, unsigned long vpn, | ^ Cc: "Aneesh Kumar

[PATCH v2 11/23] powerpc/optprobes: Make patch_imm64_load_insns() static

2021-01-04 Thread Cédric Le Goater
patch_imm64_load_insns() is only used locally in arch_prepare_optimized_kprobe() and does not need to be external. It fixes this W=1 compile error : ../arch/powerpc/kernel/optprobes.c:149:6: error: no previous prototype for ‘patch_imm64_load_insns’ [-Werror=missing-prototypes] 149 | void

[PATCH v2 04/23] powerpc/pseries/ras: Make init_ras_hotplug_IRQ() static

2021-01-04 Thread Cédric Le Goater
init_ras_hotplug_IRQ() is a local routine used by a machine init call and it doesn't need to be external. It fixes this W=1 compile error: ../arch/powerpc/platforms/pseries/ras.c:125:12: error: no previous prototype for ‘init_ras_hotplug_IRQ’ [-Werror=missing-prototypes] 125 | int __init

[PATCH v2 07/23] powerpc/mce: Include prototypes

2021-01-04 Thread Cédric Le Goater
It fixes these W=1 compile errors : ../arch/powerpc/kernel/mce.c:591:14: error: no previous prototype for ‘machine_check_early’ [-Werror=missing-prototypes] 591 | long notrace machine_check_early(struct pt_regs *regs) | ^~~ ../arch/powerpc/kernel/mce.c:725:6:

[PATCH v2 03/23] powerpc/pseries/eeh: Make pseries_pcibios_bus_add_device() static

2021-01-04 Thread Cédric Le Goater
pseries_pcibios_bus_add_device() is a local routine defining the pcibios_bus_add_device() handler of the pseries machine in eeh_pseries_init(). It doesn't need to be external. It fixes this W=1 compile error: ../arch/powerpc/platforms/pseries/eeh_pseries.c:46:6: error: no previous prototype for

Re: [PATCH 17/23] powerpc/watchdog: Declare soft_nmi_interrupt() prototype

2021-01-04 Thread Cédric Le Goater
On 12/21/20 9:48 AM, Christophe Leroy wrote: > > > Le 21/12/2020 à 08:42, Cédric Le Goater a écrit : >> It fixes this W=1 compile error : >> >> ../arch/powerpc/kernel/watchdog.c:250:6: error: no previous prototype for >> ‘soft_nmi_interrupt’ [-Werror=missing-prototypes] >>    250 | void

Re: Regression for 32-bit ppc on PowerBook G4 Aluminum (bisected to commit d0e3fc69d00d)

2021-01-04 Thread Michael Ellerman
Larry Finger writes: > I tested 5.11.0-rc1 and it booted OK. My problem is fixed. Thanks. cheers

Re: [PATCH v3 0/6] Memory corruption may occur due to incorrent tlb flush

2021-01-04 Thread Greg KH
On Thu, Mar 12, 2020 at 06:57:34PM +0530, Santosh Sivaraj wrote: > The TLB flush optimisation (a46cc7a90f: powerpc/mm/radix: Improve TLB/PWC > flushes) may result in random memory corruption. Any concurrent page-table > walk > could end up with a Use-after-Free. Even on UP this might give issues,

Patch "powerpc/mmu_gather: enable RCU_TABLE_FREE even for !SMP case" has been added to the 4.19-stable tree

2021-01-04 Thread gregkh
This is a note to let you know that I've just added the patch titled powerpc/mmu_gather: enable RCU_TABLE_FREE even for !SMP case to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Patch "mm/mmu_gather: invalidate TLB correctly on batch allocation failure and flush" has been added to the 4.19-stable tree

2021-01-04 Thread gregkh
This is a note to let you know that I've just added the patch titled mm/mmu_gather: invalidate TLB correctly on batch allocation failure and flush to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The

Patch "asm-generic/tlb: Track which levels of the page tables have been cleared" has been added to the 4.19-stable tree

2021-01-04 Thread gregkh
This is a note to let you know that I've just added the patch titled asm-generic/tlb: Track which levels of the page tables have been cleared to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of

Patch "asm-generic/tlb: Track freeing of page-table directories in struct mmu_gather" has been added to the 4.19-stable tree

2021-01-04 Thread gregkh
This is a note to let you know that I've just added the patch titled asm-generic/tlb: Track freeing of page-table directories in struct mmu_gather to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The

Patch "asm-generic/tlb: avoid potential double flush" has been added to the 4.19-stable tree

2021-01-04 Thread gregkh
This is a note to let you know that I've just added the patch titled asm-generic/tlb: avoid potential double flush to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Patch "asm-generic/tlb, arch: Invert CONFIG_HAVE_RCU_TABLE_INVALIDATE" has been added to the 4.19-stable tree

2021-01-04 Thread gregkh
This is a note to let you know that I've just added the patch titled asm-generic/tlb, arch: Invert CONFIG_HAVE_RCU_TABLE_INVALIDATE to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch

Re: [PATCH v9 05/12] mm: HUGE_VMAP arch support cleanup

2021-01-04 Thread Ding Tianhong
On 2020/12/5 14:57, Nicholas Piggin wrote: > This changes the awkward approach where architectures provide init > functions to determine which levels they can provide large mappings for, > to one where the arch is queried for each call. > > This removes code and indirection, and allows

[PATCH] tools headers UAPI: Sync linux/types.h with the kernel sources

2021-01-04 Thread Michael Ellerman
Unlike the other headers in tools/include/uapi/linux, types.h has never been synced from the exported headers, instead it's been hand written over time. This means it doesn't match the exported headers which can cause build errors on some architectures. For example on powerpc, tools/bpf doesn't

Re: [PATCH] selftests/powerpc: make the test check in eeh-basic.sh posix compliant

2021-01-04 Thread Frederic Barrat
On 28/12/2020 05:34, Po-Hsu Lin wrote: The == operand is a bash extension, thus this will fail on Ubuntu with Error message is somehow missing. It should read: "./eeh-basic.sh: 89: test: 2: unexpected operator" As the /bin/sh on Ubuntu is pointed to DASH. Use -eq to fix this posix

Re: [PATCH v2 -next] misc: ocxl: use DEFINE_MUTEX() for mutex lock

2021-01-04 Thread Frederic Barrat
On 24/12/2020 14:24, Zheng Yongjun wrote: mutex lock can be initialized automatically with DEFINE_MUTEX() rather than explicitly calling mutex_init(). Signed-off-by: Zheng Yongjun --- Thanks! Acked-by: Frederic Barrat drivers/misc/ocxl/file.c | 3 +-- 1 file changed, 1