Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Christophe Leroy
Le 04/03/2021 à 20:24, Segher Boessenkool a écrit : On Thu, Mar 04, 2021 at 09:54:44AM -0800, Nick Desaulniers wrote: On Thu, Mar 4, 2021 at 9:42 AM Marco Elver wrote: include/linux/compiler.h:246: prevent_tail_call_optimization commit a9a3ed1eff36 ("x86: Fix early boot crash on gcc-10,

Re: linux-next: manual merge of the tty tree with the powerpc-fixes tree

2021-03-04 Thread Greg KH
On Fri, Mar 05, 2021 at 12:05:23PM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tty tree got a conflict in: > > drivers/tty/hvc/hvcs.c > > between commit: > > 386a966f5ce7 ("vio: make remove callback return void") > > from the powerpc-fixes tree and commit:

Re: [PATCH v2 07/37] KVM: PPC: Book3S 64: Move GUEST_MODE_SKIP test into KVM

2021-03-04 Thread Daniel Axtens
Hi Nick, > - .if IKVM_SKIP > -89: mtocrf 0x80,r9 > - ld r10,IAREA+EX_CTR(r13) > - mtctr r10 > - ld r9,IAREA+EX_R9(r13) > - ld r10,IAREA+EX_R10(r13) > - ld r11,IAREA+EX_R11(r13) > - ld r12,IAREA+EX_R12(r13) > - .if IHSRR_IF_HVMODE > -

Re: [PATCH] powerpc/perf: prevent mixed EBB and non-EBB events

2021-03-04 Thread Athira Rajeev
> On 24-Feb-2021, at 5:51 PM, Thadeu Lima de Souza Cascardo > wrote: > > EBB events must be under exclusive groups, so there is no mix of EBB and > non-EBB events on the same PMU. This requirement worked fine as perf core > would not allow other pinned events to be scheduled together with

Re: [PATCH] ibmvnic: remove excessive irqsave

2021-03-04 Thread Christophe Leroy
Le 05/03/2021 à 02:43, angkery a écrit : From: Junlin Yang ibmvnic_remove locks multiple spinlocks while disabling interrupts: spin_lock_irqsave(>state_lock, flags); spin_lock_irqsave(>rwi_lock, flags); there is no need for the second irqsave,since interrupts are disabled at that point, so

Re: [PATCH v2 06/37] KVM: PPC: Book3S 64: move KVM interrupt entry to a common entry point

2021-03-04 Thread Daniel Axtens
Hi Nick, > Rather than bifurcate the call depending on whether or not HV is > possible, and have the HV entry test for PR, just make a single > common point which does the demultiplexing. This makes it simpler > to add another type of exit handler. > > Reviewed-by: Fabiano Rosas I checked this

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Michael Ellerman
Marco Elver writes: > On Thu, Mar 04, 2021 at 12:48PM +0100, Christophe Leroy wrote: >> Le 04/03/2021 à 12:31, Marco Elver a écrit : >> > On Thu, 4 Mar 2021 at 12:23, Christophe Leroy >> > wrote: >> > > Le 03/03/2021 à 11:56, Marco Elver a écrit : >> > > > >> > > > Somewhat tangentially, I also

Re: [PATCH v2 05/37] KVM: PPC: Book3S HV: Ensure MSR[ME] is always set in guest MSR

2021-03-04 Thread Daniel Axtens
>> This 'if' is technically redundant but you mention a future patch warning >> on !(msr & MSR_ME) so I'm holding off on any judgement about the 'if' until >> I get to that patch :) > > That's true. The warning is actually further down when we're setting up > the msr to run in guest mode. At this

Re: [PATCH] ibmvnic: remove excessive irqsave

2021-03-04 Thread Sukadev Bhattiprolu
angkery [angk...@163.com] wrote: > From: Junlin Yang > > ibmvnic_remove locks multiple spinlocks while disabling interrupts: > spin_lock_irqsave(>state_lock, flags); > spin_lock_irqsave(>rwi_lock, flags); > > there is no need for the second irqsave,since interrupts are disabled > at that point,

[PATCH V3] mm: Generalize HUGETLB_PAGE_SIZE_VARIABLE

2021-03-04 Thread Anshuman Khandual
HUGETLB_PAGE_SIZE_VARIABLE need not be defined for each individual platform subscribing it. Instead just make it generic. Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Andrew Morton Cc: Christoph Hellwig Cc: Christophe Leroy Cc: linux-i...@vger.kernel.org Cc:

[PATCH] ibmvnic: remove excessive irqsave

2021-03-04 Thread angkery
From: Junlin Yang ibmvnic_remove locks multiple spinlocks while disabling interrupts: spin_lock_irqsave(>state_lock, flags); spin_lock_irqsave(>rwi_lock, flags); there is no need for the second irqsave,since interrupts are disabled at that point, so remove the second irqsave:

linux-next: manual merge of the tty tree with the powerpc-fixes tree

2021-03-04 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the tty tree got a conflict in: drivers/tty/hvc/hvcs.c between commit: 386a966f5ce7 ("vio: make remove callback return void") from the powerpc-fixes tree and commit: fb8d350c291c ("tty: hvc, drop unneeded forward declarations") from the tty tree. I

Re: [Freedreno] [PATCH 16/17] iommu: remove DOMAIN_ATTR_IO_PGTABLE_CFG

2021-03-04 Thread Rob Clark
On Thu, Mar 4, 2021 at 7:48 AM Robin Murphy wrote: > > On 2021-03-01 08:42, Christoph Hellwig wrote: > > Signed-off-by: Christoph Hellwig > > Moreso than the previous patch, where the feature is at least relatively > generic (note that there's a bunch of in-flight development around >

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Marco Elver
On Thu, 4 Mar 2021 at 19:51, Mark Rutland wrote: > On Thu, Mar 04, 2021 at 07:22:53PM +0100, Marco Elver wrote: > > On Thu, 4 Mar 2021 at 19:02, Mark Rutland wrote: > > > On Thu, Mar 04, 2021 at 06:25:33PM +0100, Marco Elver wrote: > > > > On Thu, Mar 04, 2021 at 04:59PM +, Mark Rutland

Re: [PATCH 2/5] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-04 Thread Rob Herring
On Thu, Mar 4, 2021 at 3:24 PM Daniel Walker wrote: > > On Thu, Mar 04, 2021 at 08:09:52AM +0100, Christophe Leroy wrote: > > > > > > Le 04/03/2021 à 05:47, Daniel Walker a écrit : > > > It looks like there's some seepage of cmdline stuff into > > > the generic device tree code. This conflicts

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Marco Elver
On Thu, 4 Mar 2021 at 19:02, Mark Rutland wrote: > On Thu, Mar 04, 2021 at 06:25:33PM +0100, Marco Elver wrote: > > On Thu, Mar 04, 2021 at 04:59PM +, Mark Rutland wrote: > > > On Thu, Mar 04, 2021 at 04:30:34PM +0100, Marco Elver wrote: > > > > On Thu, 4 Mar 2021 at 15:57, Mark Rutland

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Segher Boessenkool
Hi! On Thu, Mar 04, 2021 at 02:57:30PM +, Mark Rutland wrote: > It looks like GCC is happy to give us the function-entry-time FP if we use > __builtin_frame_address(1), >From the GCC manual: Calling this function with a nonzero argument can have unpredictable effects, including

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Nick Desaulniers
On Thu, Mar 4, 2021 at 9:42 AM Marco Elver wrote: > > On Thu, Mar 04, 2021 at 04:59PM +, Mark Rutland wrote: > > On Thu, Mar 04, 2021 at 04:30:34PM +0100, Marco Elver wrote: > > > On Thu, 4 Mar 2021 at 15:57, Mark Rutland wrote: > > > > [adding Mark Brown] > > > > > > > > The bigger problem

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Marco Elver
On Thu, Mar 04, 2021 at 04:59PM +, Mark Rutland wrote: > On Thu, Mar 04, 2021 at 04:30:34PM +0100, Marco Elver wrote: > > On Thu, 4 Mar 2021 at 15:57, Mark Rutland wrote: > > > [adding Mark Brown] > > > > > > The bigger problem here is that skipping is dodgy to begin with, and > > > this is

Re: [PATCH 2/5] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-04 Thread Daniel Walker
On Thu, Mar 04, 2021 at 08:09:52AM +0100, Christophe Leroy wrote: > > > Le 04/03/2021 à 05:47, Daniel Walker a écrit : > > It looks like there's some seepage of cmdline stuff into > > the generic device tree code. This conflicts with the > > generic cmdline implementation so I remove it in the

Re: [PATCH 1/5] CMDLINE: add generic builtin command line

2021-03-04 Thread Daniel Walker
On Thu, Mar 04, 2021 at 08:00:49AM +0100, Christophe Leroy wrote: > > > Le 04/03/2021 à 05:47, Daniel Walker a écrit : > > This code allows architectures to use a generic builtin command line. > > The state of the builtin command line options across architecture is > > diverse. On x86 and mips

Re: [PATCH 2/5] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-04 Thread Daniel Walker
On Thu, Mar 04, 2021 at 08:32:37AM -0600, Rob Herring wrote: > On Wed, Mar 3, 2021 at 10:48 PM Daniel Walker wrote: > > > > It looks like there's some seepage of cmdline stuff into > > the generic device tree code. This conflicts with the > > generic cmdline implementation so I remove it in the

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Marco Elver
On Thu, 4 Mar 2021 at 15:57, Mark Rutland wrote: > [adding Mark Brown] > > On Wed, Mar 03, 2021 at 04:20:43PM +0100, Marco Elver wrote: > > On Wed, Mar 03, 2021 at 03:52PM +0100, Christophe Leroy wrote: > > > Le 03/03/2021 � 15:38, Marco Elver a �crit�: > > > > On Wed, 3 Mar 2021 at 15:09,

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Segher Boessenkool
On Thu, Mar 04, 2021 at 09:54:44AM -0800, Nick Desaulniers wrote: > On Thu, Mar 4, 2021 at 9:42 AM Marco Elver wrote: > include/linux/compiler.h:246: > prevent_tail_call_optimization > > commit a9a3ed1eff36 ("x86: Fix early boot crash on gcc-10, third try") That is much heavier than needed (an

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Mark Rutland
On Thu, Mar 04, 2021 at 07:22:53PM +0100, Marco Elver wrote: > On Thu, 4 Mar 2021 at 19:02, Mark Rutland wrote: > > On Thu, Mar 04, 2021 at 06:25:33PM +0100, Marco Elver wrote: > > > On Thu, Mar 04, 2021 at 04:59PM +, Mark Rutland wrote: > > > > On Thu, Mar 04, 2021 at 04:30:34PM +0100, Marco

Re: [PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()

2021-03-04 Thread Tyrel Datwyler
On 3/4/21 1:28 AM, Jiapeng Chong wrote: > Fix the following coccicheck warnings: > > ./drivers/scsi/ibmvscsi/ibmvfc.c:3483:60-61: WARNING opportunity for > kobj_to_dev(). > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Acked-by: Tyrel Datwyler > --- >

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Marco Elver
On Thu, 4 Mar 2021 at 15:08, Christophe Leroy wrote: > > > > Le 04/03/2021 à 13:48, Marco Elver a écrit : > > From d118080eb9552073f5dcf1f86198f3d86d5ea850 Mon Sep 17 00:00:00 2001 > > From: Marco Elver > > Date: Thu, 4 Mar 2021 13:15:51 +0100 > > Subject: [PATCH] kfence: fix reports if

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Mark Rutland
On Thu, Mar 04, 2021 at 06:25:33PM +0100, Marco Elver wrote: > On Thu, Mar 04, 2021 at 04:59PM +, Mark Rutland wrote: > > On Thu, Mar 04, 2021 at 04:30:34PM +0100, Marco Elver wrote: > > > On Thu, 4 Mar 2021 at 15:57, Mark Rutland wrote: > > > > [adding Mark Brown] > > > > > > > > The bigger

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Mark Rutland
On Thu, Mar 04, 2021 at 04:30:34PM +0100, Marco Elver wrote: > On Thu, 4 Mar 2021 at 15:57, Mark Rutland wrote: > > [adding Mark Brown] > > > > The bigger problem here is that skipping is dodgy to begin with, and > > this is still liable to break in some cases. One big concern is that > >

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Marco Elver
On Thu, Mar 04, 2021 at 12:48PM +0100, Christophe Leroy wrote: > Le 04/03/2021 à 12:31, Marco Elver a écrit : > > On Thu, 4 Mar 2021 at 12:23, Christophe Leroy > > wrote: > > > Le 03/03/2021 à 11:56, Marco Elver a écrit : > > > > > > > > Somewhat tangentially, I also note that e.g.

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Marco Elver
On Thu, 4 Mar 2021 at 13:00, Christophe Leroy wrote: > > > > Le 04/03/2021 à 12:48, Christophe Leroy a écrit : > > > > > > Le 04/03/2021 à 12:31, Marco Elver a écrit : > >> On Thu, 4 Mar 2021 at 12:23, Christophe Leroy > >> wrote: > >>> Le 03/03/2021 à 11:56, Marco Elver a écrit : > >

Re: [PATCH v2 1/3] powerpc: sstep: Fix load and update emulation

2021-03-04 Thread Segher Boessenkool
On Wed, Mar 03, 2021 at 10:01:27PM +0530, Naveen N. Rao wrote: > On 2021/03/01 08:37PM, Segher Boessenkool wrote: > > > And, r6 always ends up with 0xaea. It changes with the value I put into > > > r6 though. > > > > That is exactly the behaviour specified for p8. 0aaa+0040=0aea. > > > > >

Re: [PATCH 16/17] iommu: remove DOMAIN_ATTR_IO_PGTABLE_CFG

2021-03-04 Thread Robin Murphy
On 2021-03-01 08:42, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig Moreso than the previous patch, where the feature is at least relatively generic (note that there's a bunch of in-flight development around DOMAIN_ATTR_NESTING), I'm really not convinced that it's beneficial to

Re: [PATCH v2] powerpc/32: remove bogus ppc_select syscall

2021-03-04 Thread Arnd Bergmann
On Thu, Mar 4, 2021 at 4:24 PM Christophe Leroy wrote: > Le 04/03/2021 à 16:17, Arnd Bergmann a écrit : > > On Thu, Mar 4, 2021 at 1:51 PM Christophe Leroy > > wrote: > >> --- > >> First version was in 2008, at that time it was rejected, see > >>

Re: [PATCH 14/17] iommu: remove DOMAIN_ATTR_DMA_USE_FLUSH_QUEUE

2021-03-04 Thread Robin Murphy
On 2021-03-01 08:42, Christoph Hellwig wrote: Use explicit methods for setting and querying the information instead. Now that everyone's using iommu-dma, is there any point in bouncing this through the drivers at all? Seems like it would make more sense for the x86 drivers to reflect their

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Marco Elver
On Thu, 4 Mar 2021 at 12:23, Christophe Leroy wrote: > Le 03/03/2021 à 11:56, Marco Elver a écrit : > > > > Somewhat tangentially, I also note that e.g. show_regs(regs) (which > > was printed along the KFENCE report above) didn't include the top > > frame in the "Call Trace", so this assumption

Re: [PATCH v2] powerpc/32: remove bogus ppc_select syscall

2021-03-04 Thread Christophe Leroy
Le 04/03/2021 à 16:17, Arnd Bergmann a écrit : On Thu, Mar 4, 2021 at 1:51 PM Christophe Leroy wrote: From: Arnd Bergmann The ppc_select function was introduced in linux-2.3.48 in order to support code confusing the legacy select() calling convention with the standard one. Even 24 years

Re: [PATCH v2] powerpc/32: remove bogus ppc_select syscall

2021-03-04 Thread Arnd Bergmann
On Thu, Mar 4, 2021 at 1:51 PM Christophe Leroy wrote: > > From: Arnd Bergmann > > The ppc_select function was introduced in linux-2.3.48 in order to support > code confusing the legacy select() calling convention with the standard one. > Even 24 years ago, all correctly built code should not

Re: [PATCH v1] powerpc: Include running function as first entry in save_stack_trace() and friends

2021-03-04 Thread Mark Rutland
[adding Mark Brown] On Wed, Mar 03, 2021 at 04:20:43PM +0100, Marco Elver wrote: > On Wed, Mar 03, 2021 at 03:52PM +0100, Christophe Leroy wrote: > > Le 03/03/2021 � 15:38, Marco Elver a �crit�: > > > On Wed, 3 Mar 2021 at 15:09, Christophe Leroy > > > wrote: > > > > > > > > It seems like

[PATCH v2 4/4] powerpc: Enable KFENCE on BOOK3S/64

2021-03-04 Thread Christophe Leroy
This reuses the DEBUG_PAGEALLOC logic. Tested on qemu with ppc64_defconfig + CONFIG_KFENCE + CONFIG_KUNIT + CONFIG_KFENCE_KUNIT_TEST. Signed-off-by: Christophe Leroy --- v2: New --- arch/powerpc/Kconfig | 2 +- arch/powerpc/include/asm/kfence.h | 8

[PATCH v2 1/4] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Christophe Leroy
Add architecture specific implementation details for KFENCE and enable KFENCE for the ppc32 architecture. In particular, this implements the required interface in . KFENCE requires that attributes for pages from its memory pool can individually be set. Therefore, force the Read/Write linear map

[PATCH v2 2/4] powerpc/64s: Remove unneeded #ifdef CONFIG_DEBUG_PAGEALLOC in hash_utils

2021-03-04 Thread Christophe Leroy
debug_pagealloc_enabled() is always defined and constant folds to 'false' when CONFIG_DEBUG_PAGEALLOC is not enabled. Remove the #ifdefs, the code and associated static variables will be optimised out by the compiler when CONFIG_DEBUG_PAGEALLOC is not defined. Signed-off-by: Christophe Leroy

[PATCH v2 3/4] powerpc/64s: Allow double call of kernel_[un]map_linear_page()

2021-03-04 Thread Christophe Leroy
If the page is already mapped resp. already unmapped, bail out. Signed-off-by: Christophe Leroy --- v2: New --- arch/powerpc/mm/book3s64/hash_utils.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/mm/book3s64/hash_utils.c

Re: [PATCH 2/5] CMDLINE: drivers: of: ifdef out cmdline section

2021-03-04 Thread Rob Herring
On Wed, Mar 3, 2021 at 10:48 PM Daniel Walker wrote: > > It looks like there's some seepage of cmdline stuff into > the generic device tree code. This conflicts with the > generic cmdline implementation so I remove it in the case > when that's enabled. > > Cc: xe-linux-exter...@cisco.com >

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Christophe Leroy
Le 04/03/2021 à 13:48, Marco Elver a écrit : From d118080eb9552073f5dcf1f86198f3d86d5ea850 Mon Sep 17 00:00:00 2001 From: Marco Elver Date: Thu, 4 Mar 2021 13:15:51 +0100 Subject: [PATCH] kfence: fix reports if constant function prefixes exist Some architectures prefix all functions with a

Re: [PATCH v2 1/3] powerpc: sstep: Fix load and update emulation

2021-03-04 Thread Naveen N. Rao
On 2021/03/01 08:37PM, Segher Boessenkool wrote: > Hi! > > I didn't see this until now, almost a month later, sorry about that :-) No problem. > > On Thu, Feb 04, 2021 at 01:57:53PM +0530, Naveen N. Rao wrote: > > On 2021/02/03 03:17PM, Segher Boessenkool wrote: > > > Power8 does: > > > > > >

[PATCH v2] powerpc/32: remove bogus ppc_select syscall

2021-03-04 Thread Christophe Leroy
From: Arnd Bergmann The ppc_select function was introduced in linux-2.3.48 in order to support code confusing the legacy select() calling convention with the standard one. Even 24 years ago, all correctly built code should not have done this and could have easily been phased out. Nothing that

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Christophe Leroy
Le 04/03/2021 à 12:48, Christophe Leroy a écrit : Le 04/03/2021 à 12:31, Marco Elver a écrit : On Thu, 4 Mar 2021 at 12:23, Christophe Leroy wrote: Le 03/03/2021 à 11:56, Marco Elver a écrit : Somewhat tangentially, I also note that e.g. show_regs(regs) (which was printed along the

[Bug 210749] sysfs: cannot create duplicate filename '/bus/nvmem/devices/module-vpd'

2021-03-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210749 --- Comment #8 from Michael Ellerman (mich...@ellerman.id.au) --- Actually I also reverted 4e302c3b568e ("misc: eeprom: at24: fix NVMEM name with custom AT24 device name"). -- You may reply to this email to add a comment. You are receiving

[PATCH] powerpc/perf: Fix sampled instruction type for larx/stcx

2021-03-04 Thread Athira Rajeev
Sampled Instruction Event Register (SIER) field [46:48] identifies the sampled instruction type. ISA v3.1 says value of 0b111 for this field as reserved, but in POWER10 it denotes LARX/STCX type which will hopefully be fixed in ISA v3.1 update. Patch fixes the functions to handle type value 7 for

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Christophe Leroy
Le 04/03/2021 à 12:31, Marco Elver a écrit : On Thu, 4 Mar 2021 at 12:23, Christophe Leroy wrote: Le 03/03/2021 à 11:56, Marco Elver a écrit : Somewhat tangentially, I also note that e.g. show_regs(regs) (which was printed along the KFENCE report above) didn't include the top frame in the

[Bug 210749] sysfs: cannot create duplicate filename '/bus/nvmem/devices/module-vpd'

2021-03-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210749 Michael Ellerman (mich...@ellerman.id.au) changed: What|Removed |Added Status|NEW |ASSIGNED ---

[PATCH] powerpc/pseries: export LPAR security flavor in lparcfg

2021-03-04 Thread Laurent Dufour
This is helpful to read the security flavor from inside the LPAR. Export it like this in /proc/powerpc/lparcfg: $ grep security_flavor /proc/powerpc/lparcfg security_flavor=1 Value means: 0 Speculative execution fully enabled 1 Speculative execution controls to mitigate user-to-kernel attacks 2

Re: [PATCH v2] powerpc: Fix save_stack_trace_regs() to have running function as first entry

2021-03-04 Thread Michael Ellerman
Christophe Leroy writes: > It seems like other architectures, namely x86 and arm64 > at least, include the running function as top entry when saving > stack trace with save_stack_trace_regs(). Also riscv AFAICS. > Functionnalities like KFENCE expect it. > > Do the same on powerpc, it allows

Re: [RFC PATCH v1] powerpc: Enable KFENCE for PPC32

2021-03-04 Thread Christophe Leroy
Le 03/03/2021 à 11:56, Marco Elver a écrit : Somewhat tangentially, I also note that e.g. show_regs(regs) (which was printed along the KFENCE report above) didn't include the top frame in the "Call Trace", so this assumption is definitely not isolated to KFENCE. Now, I have tested PPC64

Re: cleanup unused or almost unused IOMMU APIs and the FSL PAMU driver

2021-03-04 Thread Joerg Roedel
On Mon, Mar 01, 2021 at 09:42:40AM +0100, Christoph Hellwig wrote: > Diffstat: > arch/powerpc/include/asm/fsl_pamu_stash.h | 12 > drivers/gpu/drm/msm/adreno/adreno_gpu.c |2 > drivers/iommu/amd/iommu.c | 23 > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 85

Re: [PATCH v2 34/37] KVM: PPC: Book3S HV: add virtual mode handlers for HPT hcalls and page faults

2021-03-04 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of March 4, 2021 6:09 am: > Nicholas Piggin writes: > >> In order to support hash guests in the P9 path (which does not do real >> mode hcalls or page fault handling), these real-mode hash specific >> interrupts need to be implemented in virt mode. >> >>

Re: [PATCH v2 30/37] KVM: PPC: Book3S HV: Implement radix prefetch workaround by disabling MMU

2021-03-04 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of March 3, 2021 7:21 am: > Nicholas Piggin writes: > >> Rather than partition the guest PID space and catch and flush a rogue >> guest, instead work around this issue by ensuring the MMU is always >> disabled in HV mode while the guest MMU context is

Re: [PATCH v3] powerpc/uprobes: Validation for prefixed instruction

2021-03-04 Thread Ravi Bangoria
On 3/4/21 4:21 PM, Christophe Leroy wrote: Le 04/03/2021 à 11:13, Ravi Bangoria a écrit : On 3/4/21 1:02 PM, Christophe Leroy wrote: Le 04/03/2021 à 06:05, Ravi Bangoria a écrit : As per ISA 3.1, prefixed instruction should not cross 64-byte boundary. So don't allow Uprobe on such

Re: [PATCH v2 28/37] KVM: PPC: Book3S HV P9: Add helpers for OS SPR handling

2021-03-04 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of March 3, 2021 1:04 am: > Nicholas Piggin writes: > >> This is a first step to wrapping supervisor and user SPR saving and >> loading up into helpers, which will then be called independently in >> bare metal and nested HV cases in order to optimise SPR

Re: [PATCH v3] powerpc/uprobes: Validation for prefixed instruction

2021-03-04 Thread Christophe Leroy
Le 04/03/2021 à 11:13, Ravi Bangoria a écrit : On 3/4/21 1:02 PM, Christophe Leroy wrote: Le 04/03/2021 à 06:05, Ravi Bangoria a écrit : As per ISA 3.1, prefixed instruction should not cross 64-byte boundary. So don't allow Uprobe on such prefixed instruction. There are two ways probed

[Bug 210749] sysfs: cannot create duplicate filename '/bus/nvmem/devices/module-vpd'

2021-03-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210749 Michael Ellerman (mich...@ellerman.id.au) changed: What|Removed |Added CC|

Re: [PATCH v3] powerpc/uprobes: Validation for prefixed instruction

2021-03-04 Thread Ravi Bangoria
On 3/4/21 1:02 PM, Christophe Leroy wrote: Le 04/03/2021 à 06:05, Ravi Bangoria a écrit : As per ISA 3.1, prefixed instruction should not cross 64-byte boundary. So don't allow Uprobe on such prefixed instruction. There are two ways probed instruction is changed in mapped pages. First,

[PATCH] scsi: ibmvfc: Switch to using the new API kobj_to_dev()

2021-03-04 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./drivers/scsi/ibmvscsi/ibmvfc.c:3483:60-61: WARNING opportunity for kobj_to_dev(). Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/scsi/ibmvscsi/ibmvfc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2] ASoC: imx-hdmi: fix platform_no_drv_owner.cocci warnings

2021-03-04 Thread Yang Li
./sound/soc/fsl/imx-hdmi.c:226:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Reported-by: Abaci Robot Signed-off-by: Yang Li --- Change in v2: -use imx-hdmi instead of hdmi-codec for Subject sound/soc/fsl/imx-hdmi.c |

[PATCH] powerpc: fix coding style issues

2021-03-04 Thread Qiang Ma
There are several style issues in this function, so fix them. Signed-off-by: Qiang Ma --- arch/powerpc/kernel/syscalls.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/kernel/syscalls.c b/arch/powerpc/kernel/syscalls.c index