Re: [PATCH] powerpc: Avoid clang uninitialized warning in __get_user_size_allowed

2021-04-26 Thread Christophe Leroy
Le 26/04/2021 à 22:35, Nathan Chancellor a écrit : Commit 9975f852ce1b ("powerpc/uaccess: Remove calls to __get_user_bad() and __put_user_bad()") switch to BUILD_BUG() in the default case, which leaves x uninitialized. This will not be an issue because the build will be broken in that case

[PATCH v6] powerpc/kexec_file: use current CPU info while setting up FDT

2021-04-26 Thread Sourabh Jain
kexec_file_load uses initial_boot_params in setting up the device-tree for the kernel to be loaded. Though initial_boot_params holds info about CPUs at the time of boot, it doesn't account for hot added CPUs. So, kexec'ing with kexec_file_load syscall would leave the kexec'ed kernel with

Re: [PATCH net-next v4 2/2] of: net: fix of_get_mac_addr_nvmem() for non-platform devices

2021-04-26 Thread Benjamin Herrenschmidt
On Mon, 2021-04-26 at 12:54 +0200, Michael Walle wrote: > Before I'll try to come up with a patch for this, I'd like to get > your opinion on it. > > (1) replacing of_get_mac_address(node) with eth_get_mac_address(dev) > might sometimes lead to confusing comments like in >

Re: [PATCH 2/9] ARM: PXA: Kill use of irq_create_strict_mappings()

2021-04-26 Thread Guenter Roeck
On Tue, Apr 06, 2021 at 10:35:50AM +0100, Marc Zyngier wrote: > irq_create_strict_mappings() is a poor way to allow the use of > a linear IRQ domain as a legacy one. Let's be upfront about > it and use a legacy domain when appropriate. > > Signed-off-by: Marc Zyngier > --- When running the

Re: [PATCH] kbuild: replace LANG=C with LC_ALL=C

2021-04-26 Thread Matthieu Baerts
Hi, Thank you for the patch! On 24/04/2021 13:48, Masahiro Yamada wrote: > LANG gives a weak default to each LC_* in case it is not explicitly > defined. LC_ALL, if set, overrides all other LC_* variables. > > LANG < LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ... < LC_ALL > > This is

Re: [PATCH v2 2/2] powerpc: If kexec_build_elf_info() fails return immediately from elf64_load()

2021-04-26 Thread Rob Herring
On Wed, 21 Apr 2021 09:36:10 -0700, Lakshmi Ramasubramanian wrote: > Uninitialized local variable "elf_info" would be passed to > kexec_free_elf_info() if kexec_build_elf_info() returns an error > in elf64_load(). > > If kexec_build_elf_info() returns an error, return the error > immediately. >

Re: [PATCH v2 1/2] powerpc: Free fdt on error in elf64_load()

2021-04-26 Thread Rob Herring
On Wed, 21 Apr 2021 09:36:09 -0700, Lakshmi Ramasubramanian wrote: > There are a few "goto out;" statements before the local variable "fdt" > is initialized through the call to of_kexec_alloc_and_setup_fdt() in > elf64_load(). This will result in an uninitialized "fdt" being passed > to kvfree()

[PATCH] powerpc: Avoid clang uninitialized warning in __get_user_size_allowed

2021-04-26 Thread Nathan Chancellor
Commit 9975f852ce1b ("powerpc/uaccess: Remove calls to __get_user_bad() and __put_user_bad()") switch to BUILD_BUG() in the default case, which leaves x uninitialized. This will not be an issue because the build will be broken in that case but clang does static analysis before it realizes the

Re: [PATCH v7] powerpc/irq: Inline call_do_irq() and call_do_softirq()

2021-04-26 Thread Nathan Chancellor
On Sat, Mar 20, 2021 at 11:22:27PM +1100, Michael Ellerman wrote: > From: Christophe Leroy > > call_do_irq() and call_do_softirq() are simple enough to be > worth inlining. > > Inlining them avoids an mflr/mtlr pair plus a save/reload on stack. It > also allows GCC to keep the saved ksp_limit

Re: [PATCH v5 16/16] of: Add plumbing for restricted DMA pool

2021-04-26 Thread Claire Chang
On Fri, Apr 23, 2021 at 9:35 PM Robin Murphy wrote: > > On 2021-04-22 09:15, Claire Chang wrote: > > If a device is not behind an IOMMU, we look up the device node and set > > up the restricted DMA when the restricted-dma-pool is presented. > > > > Signed-off-by: Claire Chang > > --- > >

Re: [PATCH v5 05/16] swiotlb: Add restricted DMA pool initialization

2021-04-26 Thread Claire Chang
On Fri, Apr 23, 2021 at 7:34 PM Steven Price wrote: > > On 22/04/2021 09:14, Claire Chang wrote: > > Add the initialization function to create restricted DMA pools from > > matching reserved-memory nodes. > > > > Signed-off-by: Claire Chang > > --- > > include/linux/device.h | 4 +++ > >

Re: [PATCH v5 08/16] swiotlb: Update is_swiotlb_active to add a struct device argument

2021-04-26 Thread Claire Chang
On Fri, Apr 23, 2021 at 9:31 PM Robin Murphy wrote: > > On 2021-04-22 09:15, Claire Chang wrote: > > Update is_swiotlb_active to add a struct device argument. This will be > > useful later to allow for restricted DMA pool. > > > > Signed-off-by: Claire Chang > > --- > >

Re: [PATCH] kbuild: replace LANG=C with LC_ALL=C

2021-04-26 Thread Matthias Maennich
On Sat, Apr 24, 2021 at 08:48:41PM +0900, Masahiro Yamada wrote: LANG gives a weak default to each LC_* in case it is not explicitly defined. LC_ALL, if set, overrides all other LC_* variables. LANG < LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ... < LC_ALL This is why documentation

Re: linux-next: boot failure in today's linux-next

2021-04-26 Thread Jens Axboe
On 4/26/21 1:43 AM, Stephen Rothwell wrote: > Hi all, > > On Mon, 26 Apr 2021 16:36:06 +1000 Stephen Rothwell > wrote: >> >> Today's linux-next build (ipowerpc_pseries_le_defconfig) >> failed its qemu boot tests like this: >> >> [1.833361][T1] ibmvscsi 7103: SRP_VERSION: 16.a >> [

Re: [PATCH net-next v4 2/2] of: net: fix of_get_mac_addr_nvmem() for non-platform devices

2021-04-26 Thread Michael Walle
Am 2021-04-16 17:19, schrieb Rob Herring: On Fri, Apr 16, 2021 at 2:30 AM Michael Walle wrote: Am 2021-04-16 05:24, schrieb Benjamin Herrenschmidt: > On Mon, 2021-04-12 at 19:47 +0200, Michael Walle wrote: >> >> /** >> * of_get_phy_mode - Get phy mode for given device_node >> @@ -59,15

Guest entry/exit performance work and observations

2021-04-26 Thread Nicholas Piggin
I'm looking at KVM HV P9 path guest exit/entry performance with the Cify patches, plus some further work to see what we can do. Measurement is done in the guest making a "NULL hcall" and return back to a non-nested guest. Two cases considered: First, returning to guest at the "try_real_mode"

Re: linux-next: boot failure in today's linux-next

2021-04-26 Thread Stephen Rothwell
Hi all, On Mon, 26 Apr 2021 16:36:06 +1000 Stephen Rothwell wrote: > > Today's linux-next build (ipowerpc_pseries_le_defconfig) > failed its qemu boot tests like this: > > [1.833361][T1] ibmvscsi 7103: SRP_VERSION: 16.a > [1.834439][T1] ibmvscsi 7103: Maximum ID: 64

linux-next: boot failure in today's linux-next

2021-04-26 Thread Stephen Rothwell
Hi all, Today's linux-next build (ipowerpc_pseries_le_defconfig) failed its qemu boot tests like this: [1.833361][T1] ibmvscsi 7103: SRP_VERSION: 16.a [1.834439][T1] ibmvscsi 7103: Maximum ID: 64 Maximum LUN: 32 Maximum Channel: 3 [1.834683][T1] scsi host0: IBM