Re: [PATCH] powerpc/32: Fix critical and debug interrupts on BOOKE

2021-08-03 Thread Christophe Leroy
Hi Radu, Le 07/07/2021 à 07:55, Christophe Leroy a écrit : 32 bits BOOKE have special interrupts for debug and other critical events. Were you able to test this patch ? Thanks Christophe When handling those interrupts, dedicated registers are saved in the stack frame in addition to the

Re: undefined reference to `.radix__create_section_mapping'

2021-08-03 Thread Randy Dunlap
On 8/3/21 10:31 PM, Christophe Leroy wrote: Hi Randy, Le 04/08/2021 à 04:40, Randy Dunlap a écrit : On 7/31/21 11:22 AM, kernel test robot wrote: tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head:   c7d102232649226a6958a4942cf13cff4f7c commit:

[Bug 213961] Oops while loading radeon driver

2021-08-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213961 Christophe Leroy (christophe.le...@csgroup.eu) changed: What|Removed |Added CC|

Re: [PATCH] powerpc: Always inline radix_enabled() to fix build failure

2021-08-03 Thread Christophe Leroy
Le 04/08/2021 à 03:37, Jordan Niethe a écrit : This is the same as commit acdad8fb4a15 ("powerpc: Force inlining of mmu_has_feature to fix build failure") but for radix_enabled(). The config in the linked bugzilla causes the following build failure: LD .tmp_vmlinux.kallsyms1

Re: undefined reference to `.radix__create_section_mapping'

2021-08-03 Thread Christophe Leroy
Hi Randy, Le 04/08/2021 à 04:40, Randy Dunlap a écrit : On 7/31/21 11:22 AM, kernel test robot wrote: tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head:   c7d102232649226a6958a4942cf13cff4f7c commit: fe3dc333d2ed50c9764d281869d87bae0d795ce5

[PATCH] powerpc: Remove MSR_PR check in interrupt_exit_{user/kernel}_prepare()

2021-08-03 Thread Christophe Leroy
In those hot functions that are called at every interrupt, any saved cycle is worth it. interrupt_exit_user_prepare() and interrupt_exit_kernel_prepare() are called from three places: - From entry_32.S - From interrupt_64.S - From interrupt_exit_user_restart() and interrupt_exit_kernel_restart()

Re: [PATCH 1/2] powerpc/bug: Remove specific powerpc BUG_ON() and WARN_ON() on PPC32

2021-08-03 Thread Christophe Leroy
Gentle ping Michael ? Le 25/06/2021 à 16:41, Christophe Leroy a écrit : Hi Michael, What happened to this series ? It has been flagged 'under review' in Patchwork since mid April but I never saw it in next-test. Thanks Christophe Le 12/04/2021 à 18:26, Christophe Leroy a écrit : powerpc

Re: [RFC PATCH] powerpc/book3s64/radix: Upgrade va tlbie to PID tlbie if we cross PMD_SIZE

2021-08-03 Thread Nicholas Piggin
Excerpts from Aneesh Kumar K.V's message of August 4, 2021 12:37 am: > With shared mapping, even though we are unmapping a large range, the kernel > will force a TLB flush with ptl lock held to avoid the race mentioned in > commit 1cf35d47712d ("mm: split 'tlb_flush_mmu()' into tlb flushing and >

Re: [PATCH 00/38] Replace deprecated CPU-hotplug

2021-08-03 Thread Sebastian Andrzej Siewior
On 2021-08-03 17:30:40 [+0200], Hans de Goede wrote: > Hi Sebastien, Hi Hans, > On 8/3/21 4:15 PM, Sebastian Andrzej Siewior wrote: > > This is a tree wide replacement of the deprecated CPU hotplug functions > > which are only wrappers around the actual functions. > > > > Each patch is

Re: [PATCH 00/38] Replace deprecated CPU-hotplug

2021-08-03 Thread Hans de Goede
Hi Sebastien, On 8/3/21 4:15 PM, Sebastian Andrzej Siewior wrote: > This is a tree wide replacement of the deprecated CPU hotplug functions > which are only wrappers around the actual functions. > > Each patch is independent and can be picked up by the relevant maintainer. Ok; and I take it

Re: [PATCH v2 5/6] PCI: Adapt all code locations to not use struct pci_dev::driver directly

2021-08-03 Thread Ido Schimmel
On Tue, Aug 03, 2021 at 12:01:49PM +0200, Uwe Kleine-König wrote: > This prepares removing the driver member of struct pci_dev which holds the > same information than struct pci_dev::dev->driver. > > Signed-off-by: Uwe Kleine-König > --- > arch/powerpc/include/asm/ppc-pci.h| 3 +- >

Re: [PATCH v2 5/6] PCI: Adapt all code locations to not use struct pci_dev::driver directly

2021-08-03 Thread Andy Shevchenko
On Tue, Aug 03, 2021 at 12:01:49PM +0200, Uwe Kleine-König wrote: > This prepares removing the driver member of struct pci_dev which holds the > same information than struct pci_dev::dev->driver. ... > + struct pci_driver *pdrv; Missed blank line here and everywhere else. I don't remember

Re: [PATCH v2 4/6] PCI: Provide wrapper to access a pci_dev's bound driver

2021-08-03 Thread Andy Shevchenko
On Tue, Aug 03, 2021 at 12:01:48PM +0200, Uwe Kleine-König wrote: > Which driver a device is bound to is available twice: In struct > pci_dev::dev->driver and in struct pci_dev::driver. To get rid of the > duplication introduce a wrapper to access struct pci_dev's driver > member. Once all users

[PATCH 00/38] Replace deprecated CPU-hotplug

2021-08-03 Thread Sebastian Andrzej Siewior
This is a tree wide replacement of the deprecated CPU hotplug functions which are only wrappers around the actual functions. Each patch is independent and can be picked up by the relevant maintainer. Cc: Alexander Shishkin Cc: Amit Kucheria Cc: Andrew Morton Cc: Andy Lutomirski Cc: Arnaldo

Re: [PATCH v2 5/6] PCI: Adapt all code locations to not use struct pci_dev::driver directly

2021-08-03 Thread Boris Ostrovsky
On 8/3/21 6:01 AM, Uwe Kleine-König wrote: > This prepares removing the driver member of struct pci_dev which holds the > same information than struct pci_dev::dev->driver. > > Signed-off-by: Uwe Kleine-König > --- > arch/powerpc/include/asm/ppc-pci.h| 3 +- >

Re: [PATCH printk v1 00/10] printk: introduce atomic consoles and sync mode

2021-08-03 Thread Andy Shevchenko
On Tue, Aug 03, 2021 at 03:18:51PM +0206, John Ogness wrote: > Hi, > > This is the next part of our printk-rework effort (points 3 and > 4 of the LPC 2019 summary [0]). > > Here the concept of "atomic consoles" is introduced through a > new (optional) write_atomic() callback for console

[PATCH printk v1 00/10] printk: introduce atomic consoles and sync mode

2021-08-03 Thread John Ogness
Hi, This is the next part of our printk-rework effort (points 3 and 4 of the LPC 2019 summary [0]). Here the concept of "atomic consoles" is introduced through a new (optional) write_atomic() callback for console drivers. This callback must be implemented as an NMI-safe variant of the write()

Re: [PATCH v3 31/41] powerpc/32: Dismantle EXC_XFER_STD/LITE/TEMPLATE

2021-08-03 Thread Finn Thain
On Tue, 3 Aug 2021, Stan Johnson wrote: > Attached you will find the following six files: > > 1) config-5.13-patched_VMAP.txt > 2) config-5.13-patched_NO_VMAP.txt > 3) pb3400c-console-5.13-patched_VMAP.txt (using config 1) > 4) pb3400c-console-5.13-patched_NO_VMAP.txt (using config 2) > 5)

Re: [PATCH] powerpc/32s: Fix napping restore in data storage interrupt (DSI)

2021-08-03 Thread Finn Thain
On Tue, 3 Aug 2021, Christophe Leroy wrote: > When a DSI (Data Storage Interrupt) is taken while in NAP mode, r11 > doesn't survive the call to power_save_ppc32_restore(). > > So use r1 instead of r11 as they both contain the virtual stack pointer > at that point. > > Reported-by: Finn Thain

[PATCH v3 2/2] virtio-console: remove unnecessary kmemdup()

2021-08-03 Thread Xianting Tian
hvc framework will never pass stack memory to the put_chars() function, So the calling of kmemdup() is unnecessary, remove it. This revert commit c4baad5029 ("virtio-console: avoid DMA from stack") Signed-off-by: Xianting Tian --- drivers/char/virtio_console.c | 12 ++-- 1 file

[PATCH v3 1/2] tty: hvc: pass DMA capable memory to put_chars()

2021-08-03 Thread Xianting Tian
As well known, hvc backend can register its opertions to hvc backend. the opertions contain put_chars(), get_chars() and so on. Some hvc backend may do dma in its opertions. eg, put_chars() of virtio-console. But in the code of hvc framework, it may pass DMA incapable memory to put_chars() under

Re: Debian SID kernel doesn't boot on PowerBook 3400c

2021-08-03 Thread Stan Johnson
On 8/3/21 4:08 AM, Christophe Leroy wrote: > > > Le 02/08/2021 à 19:32, Stan Johnson a écrit : >> On 8/2/21 8:41 AM, Christophe Leroy wrote: >>> >>> ... > > Can you try again without CONFIG_VMAP_STACK ? > > Thanks > Christophe > ... With

[powerpc:next] BUILD SUCCESS a6cae77f1bc89368a4e2822afcddc45c3062d499

2021-08-03 Thread kernel test robot
randconfig-c001-20210803 mips ip28_defconfig armcerfcube_defconfig armneponset_defconfig arcnsimosci_defconfig arm hackkit_defconfig powerpc

[PATCH] powerpc: Always inline radix_enabled() to fix build failure

2021-08-03 Thread Jordan Niethe
This is the same as commit acdad8fb4a15 ("powerpc: Force inlining of mmu_has_feature to fix build failure") but for radix_enabled(). The config in the linked bugzilla causes the following build failure: LD .tmp_vmlinux.kallsyms1 powerpc64-linux-ld: arch/powerpc/mm/pgtable.o: in function

Re: [PATCH] cpuidle: pseries: Mark pseries_idle_proble() as __init

2021-08-03 Thread Michael Ellerman
Nathan Chancellor writes: > After commit 7cbd631d4dec ("cpuidle: pseries: Fixup CEDE0 latency only > for POWER10 onwards"), pseries_idle_probe() is no longer inlined when > compiling with clang, which causes a modpost warning: > > WARNING: modpost: vmlinux.o(.text+0xc86a54): Section mismatch in >

Re: Debian SID kernel doesn't boot on PowerBook 3400c

2021-08-03 Thread Finn Thain
On Tue, 3 Aug 2021, Christophe Leroy wrote: > > Looks like the memory errors are linked to KUAP (Kernel Userspace Access > Protection). Based on the places the problems happen, I don't think > there are any invalid access, so there must be something wrong in the > KUAP logic, probably

Re: Debian SID kernel doesn't boot on PowerBook 3400c

2021-08-03 Thread Finn Thain
On Tue, 3 Aug 2021, Stan Johnson wrote: > > I'm not sure of the issue you are referencing. If it's the Wallstreet > issue, I believe we were waiting to hear back from you regarding the > memory errors that crop up with CONFIG_VMAP_STACK=y and mem >464M. > Finn, if that is not correct, please

Re: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-08-03 Thread Saravana Kannan
On Tue, Aug 3, 2021 at 4:33 AM Maxim Kochetkov wrote: > > Since 5.13 QE's ucc nodes can't get interrupts from devicetree: > > ucc@2000 { > cell-index = <1>; > reg = <0x2000 0x200>; > interrupts = <32>; > interrupt-parent =

[PATCH] cpuidle: pseries: Mark pseries_idle_proble() as __init

2021-08-03 Thread Nathan Chancellor
After commit 7cbd631d4dec ("cpuidle: pseries: Fixup CEDE0 latency only for POWER10 onwards"), pseries_idle_probe() is no longer inlined when compiling with clang, which causes a modpost warning: WARNING: modpost: vmlinux.o(.text+0xc86a54): Section mismatch in reference from the function

Re: [PATCH v5] pseries: prevent free CPU ids to be reused on another node

2021-08-03 Thread Laurent Dufour
Le 03/08/2021 à 18:54, Nathan Lynch a écrit : Laurent Dufour writes: V5: - Rework code structure - Reintroduce the capability to reuse other node's ids. OK. While I preferred v4, where we would fail an add rather than allow CPU IDs to appear to "travel" between nodes, this change is a

Re: [PATCH v5] pseries/drmem: update LMBs after LPM

2021-08-03 Thread Laurent Dufour
Le 03/08/2021 à 19:32, Nathan Lynch a écrit : Laurent Dufour writes: V5: - Reword the commit's description to address Nathan's comments. Thanks. Still don't like the global variable usage but: Reviewed-by: Nathan Lynch Thanks Nathan, I don't like either the global variable usage but

Re: [PATCH v5] pseries/drmem: update LMBs after LPM

2021-08-03 Thread Nathan Lynch
Laurent Dufour writes: > V5: > - Reword the commit's description to address Nathan's comments. Thanks. Still don't like the global variable usage but: Reviewed-by: Nathan Lynch

[powerpc:merge] BUILD SUCCESS 98b7252a619bc485763d8e7b9f446f7cc3b992e8

2021-08-03 Thread kernel test robot
allnoconfig x86_64 randconfig-a002-20210803 x86_64 randconfig-a004-20210803 x86_64 randconfig-a006-20210803 x86_64 randconfig-a003-20210803 x86_64 randconfig-a001-20210803 x86_64 randconfig-a005

Re: [PATCH v5] pseries: prevent free CPU ids to be reused on another node

2021-08-03 Thread Nathan Lynch
Laurent Dufour writes: > V5: > - Rework code structure > - Reintroduce the capability to reuse other node's ids. OK. While I preferred v4, where we would fail an add rather than allow CPU IDs to appear to "travel" between nodes, this change is a net improvement. Reviewed-by: Nathan Lynch

[Bug 213961] New: Oops while loading radeon driver

2021-08-03 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=213961 Bug ID: 213961 Summary: Oops while loading radeon driver Product: Platform Specific/Hardware Version: 2.5 Kernel Version: 5.14-rc4 Hardware: PPC-32 OS: Linux

Re: [PATCH v2] arch: vdso: remove if-conditionals of $(c-gettimeofday-y)

2021-08-03 Thread Catalin Marinas
On Sat, Jul 31, 2021 at 03:00:20PM +0900, Masahiro Yamada wrote: > arm, arm64, csky, mips, powerpc always select GENERIC_GETTIMEOFDAY, > hence $(gettimeofday-y) never becomes empty. > > riscv conditionally selects GENERIC_GETTIMEOFDAY when MMU=y && 64BIT=y, > but

[PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-08-03 Thread Maxim Kochetkov
Since 5.13 QE's ucc nodes can't get interrupts from devicetree: ucc@2000 { cell-index = <1>; reg = <0x2000 0x200>; interrupts = <32>; interrupt-parent = <>; }; Now fw_devlink expects driver to create and probe a

Re: [PATCH printk v1 03/10] kgdb: delay roundup if holding printk cpulock

2021-08-03 Thread John Ogness
On 2021-08-03, Daniel Thompson wrote: > On Tue, Aug 03, 2021 at 03:18:54PM +0206, John Ogness wrote: >> kgdb makes use of its own cpulock (@dbg_master_lock, @kgdb_active) >> during cpu roundup. This will conflict with the printk cpulock. > > When the full vision is realized what will be the

[PATCH] powerpc/32s: Fix napping restore in data storage interrupt (DSI)

2021-08-03 Thread Christophe Leroy
When a DSI (Data Storage Interrupt) is taken while in NAP mode, r11 doesn't survive the call to power_save_ppc32_restore(). So use r1 instead of r11 as they both contain the virtual stack pointer at that point. Reported-by: Finn Thain Fixes: 4c0104a83fc3 ("powerpc/32: Dismantle

[PATCH] powerpc/kexec: fix for_each_child.cocci warning

2021-08-03 Thread Julia Lawall
From: kernel test robot for_each_node_by_type should have of_node_put() before return. Generated by: scripts/coccinelle/iterators/for_each_child.cocci CC: Sumera Priyadarsini Reported-by: kernel test robot Signed-off-by: kernel test robot --- The code seems to have been this way since the

[RFC PATCH] powerpc/book3s64/radix: Upgrade va tlbie to PID tlbie if we cross PMD_SIZE

2021-08-03 Thread Aneesh Kumar K.V
With shared mapping, even though we are unmapping a large range, the kernel will force a TLB flush with ptl lock held to avoid the race mentioned in commit 1cf35d47712d ("mm: split 'tlb_flush_mmu()' into tlb flushing and memory freeing parts") This results in the kernel issuing a high number of

Re: [PATCH printk v1 03/10] kgdb: delay roundup if holding printk cpulock

2021-08-03 Thread Daniel Thompson
On Tue, Aug 03, 2021 at 03:18:54PM +0206, John Ogness wrote: > kgdb makes use of its own cpulock (@dbg_master_lock, @kgdb_active) > during cpu roundup. This will conflict with the printk cpulock. When the full vision is realized what will be the purpose of the printk cpulock? I'm asking largely

[PATCH 03/38] powerpc: Replace deprecated CPU-hotplug functions.

2021-08-03 Thread Sebastian Andrzej Siewior
The functions get_online_cpus() and put_online_cpus() have been deprecated during the CPU hotplug rework. They map directly to cpus_read_lock() and cpus_read_unlock(). Replace deprecated CPU-hotplug functions with the official version. The behavior remains unchanged. Cc: Michael Ellerman Cc:

[PATCH printk v1 03/10] kgdb: delay roundup if holding printk cpulock

2021-08-03 Thread John Ogness
kgdb makes use of its own cpulock (@dbg_master_lock, @kgdb_active) during cpu roundup. This will conflict with the printk cpulock. Therefore, a CPU must ensure that it is not holding the printk cpulock when calling kgdb_cpu_enter(). If it is, it must allow its printk context to complete first. A

Re: [PATCH v5 0/2] cpuidle/pseries: cleanup of the CEDE0 latency fixup code

2021-08-03 Thread Michael Ellerman
Michael Ellerman writes: > On Mon, 19 Jul 2021 12:03:17 +0530, Gautham R. Shenoy wrote: >> >> Hi, >> >> This is the v5 of the patchset to fixup CEDE0 latency only from >> POWER10 onwards. >> >> >> [...] > > Applied to powerpc/next. > > [1/2] cpuidle/pseries: Fixup CEDE0 latency only for

[PATCH v2 5/6] PCI: Adapt all code locations to not use struct pci_dev::driver directly

2021-08-03 Thread Uwe Kleine-König
This prepares removing the driver member of struct pci_dev which holds the same information than struct pci_dev::dev->driver. Signed-off-by: Uwe Kleine-König --- arch/powerpc/include/asm/ppc-pci.h| 3 +- arch/powerpc/kernel/eeh_driver.c | 12 ---

[PATCH v2 0/6] PCI: Drop duplicated tracking of a pci_dev's bound driver

2021-08-03 Thread Uwe Kleine-König
Hello, changes since v1 (https://lore.kernel.org/linux-pci/20210729203740.1377045-1-u.kleine-koe...@pengutronix.de): - New patch to simplify drivers/pci/xen-pcifront.c, spotted and suggested by Boris Ostrovsky - Fix a possible NULL pointer dereference I introduced in xen-pcifront.c - A few

[PATCH v2 4/6] PCI: Provide wrapper to access a pci_dev's bound driver

2021-08-03 Thread Uwe Kleine-König
Which driver a device is bound to is available twice: In struct pci_dev::dev->driver and in struct pci_dev::driver. To get rid of the duplication introduce a wrapper to access struct pci_dev's driver member. Once all users are converted the wrapper can be changed to calculate the driver using

[PATCH v2 6/6] PCI: Drop duplicated tracking of a pci_dev's bound driver

2021-08-03 Thread Uwe Kleine-König
Currently it's tracked twice which driver is bound to a given pci device. Now that all users of the pci specific one (struct pci_dev::driver) are updated to use an access macro (pci_driver_of_dev()), change the macro to use the information from the driver core and remove the driver member from

Re: [PATCH 2/3] selftests/powerpc: Add test for real address error handling

2021-08-03 Thread Michael Ellerman
Ganesh Goudar writes: > Add test for real address or control memory address access > error handling, using NX-GZIP engine. > > The error is injected by accessing the control memory address > using illegal instruction, on successful handling the process > attempting to access control memory

Re: [PATCH v5 0/2] cpuidle/pseries: cleanup of the CEDE0 latency fixup code

2021-08-03 Thread Michael Ellerman
On Mon, 19 Jul 2021 12:03:17 +0530, Gautham R. Shenoy wrote: > > Hi, > > This is the v5 of the patchset to fixup CEDE0 latency only from > POWER10 onwards. > > > [...] Applied to powerpc/next. [1/2] cpuidle/pseries: Fixup CEDE0 latency only for POWER10 onwards

Re: [PATCH] powerpc/stacktrace: Include linux/delay.h

2021-08-03 Thread Michael Ellerman
On Thu, 29 Jul 2021 20:01:03 +0200, Michal Suchanek wrote: > commit 7c6986ade69e ("powerpc/stacktrace: Fix spurious "stale" traces in > raise_backtrace_ipi()") > introduces udelay() call without including the linux/delay.h header. > This may happen to work on master but the header that declares

Re: [PATCH] powerpc/kexec: blacklist functions called in real mode for kprobe

2021-08-03 Thread Michael Ellerman
On Wed, 14 Jul 2021 18:17:58 +0530, Hari Bathini wrote: > As kprobe does not handle events happening in real mode, blacklist the > functions that only get called in real mode or in kexec sequence with > MMU turned off. Applied to powerpc/next. [1/1] powerpc/kexec: blacklist functions called in

Re: Debian SID kernel doesn't boot on PowerBook 3400c

2021-08-03 Thread Christophe Leroy
Le 02/08/2021 à 19:32, Stan Johnson a écrit : On 8/2/21 8:41 AM, Christophe Leroy wrote: Le 31/07/2021 à 20:24, Stan Johnson a écrit : Hi Christophe, On 7/31/21 9:58 AM, Christophe Leroy wrote: Stan Johnson a écrit : Hello, The current Debian SID kernel will not boot on a PowerBook