Re: [PATCH] powerpc/mce: Fix access error in mce handler

2021-09-07 Thread Michael Ellerman
Ganesh writes: > On 9/6/21 6:03 PM, Michael Ellerman wrote: > >> Ganesh Goudar writes: >>> We queue an irq work for deferred processing of mce event >>> in realmode mce handler, where translation is disabled. >>> Queuing of the work may result in accessing memory outside >>> RMO region, such

Re: [PATCH 1/2] powerpc/perf: Expose instruction and data address registers as part of extended regs

2021-09-07 Thread Michael Ellerman
Athira Rajeev writes: > Patch adds support to include Sampled Instruction Address Register > (SIAR) and Sampled Data Address Register (SDAR) SPRs as part of extended > registers. Update the definition of PERF_REG_PMU_MASK_300/31 and > PERF_REG_EXTENDED_MAX to include these SPR's. > >

Re: [RFC PATCH v2] powerpc/papr_scm: Move duplicate definitions to common header files

2021-09-07 Thread Michael Ellerman
Shivaprasad G Bhat writes: > papr_scm and ndtest share common PDSM payload structs like > nd_papr_pdsm_health. Presently these structs are duplicated across papr_pdsm.h > and ndtest.h header files. Since 'ndtest' is essentially arch independent and > can > run on platforms other than PPC64, a

Re: [PATCH v3] ftrace: Cleanup ftrace_dyn_arch_init()

2021-09-07 Thread Weizhao Ouyang
Thanks for reply. On 2021/9/7 23:55, LEROY Christophe wrote: > >> -Message d'origine- >> De : Linuxppc-dev > bounces+christophe.leroy=csgroup...@lists.ozlabs.org> De la part de Weizhao >> Ouyang >> >> Most of ARCHs use empty ftrace_dyn_arch_init(), introduce a weak common >>

Re: [PATCH 0/5] s390/pci: automatic error recovery

2021-09-07 Thread Oliver O'Halloran
On Tue, Sep 7, 2021 at 10:21 PM Niklas Schnelle wrote: > > On Tue, 2021-09-07 at 10:45 +0200, Niklas Schnelle wrote: > > On Tue, 2021-09-07 at 12:04 +1000, Oliver O'Halloran wrote: > > > On Mon, Sep 6, 2021 at 7:49 PM Niklas Schnelle > > > wrote: > > > > Patch 3 I already sent separately

Re: [RESEND PATCH v4 4/4] powerpc/papr_scm: Document papr_scm sysfs event format entries

2021-09-07 Thread Dan Williams
On Thu, Sep 2, 2021 at 10:11 PM Kajol Jain wrote: > > Details is added for the event, cpumask and format attributes > in the ABI documentation. > > Acked-by: Peter Zijlstra (Intel) > Reviewed-by: Madhavan Srinivasan > Tested-by: Nageswara R Sastry > Signed-off-by: Kajol Jain > --- >

Re: [PATCH] pci/hotplug/pnv-php: Remove probable double put

2021-09-07 Thread Oliver O'Halloran
On Wed, Sep 8, 2021 at 8:02 AM Tyrel Datwyler wrote: > > On 9/7/21 1:59 AM, Xu Wang wrote: > > Device node iterators put the previous value of the index variable, > > so an explicit put causes a double put. > > > > Signed-off-by: Xu Wang > > --- > > drivers/pci/hotplug/pnv_php.c | 1 - > > 1

Re: [PATCH] pci/hotplug/pnv-php: Remove probable double put

2021-09-07 Thread Tyrel Datwyler
On 9/7/21 1:59 AM, Xu Wang wrote: > Device node iterators put the previous value of the index variable, > so an explicit put causes a double put. > > Signed-off-by: Xu Wang > --- > drivers/pci/hotplug/pnv_php.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [RESEND PATCH v4 1/4] drivers/nvdimm: Add nvdimm pmu structure

2021-09-07 Thread Dan Williams
Hi Kajol, Apologies for the delay in responding to this series, some comments below: On Thu, Sep 2, 2021 at 10:10 PM Kajol Jain wrote: > > A structure is added, called nvdimm_pmu, for performance > stats reporting support of nvdimm devices. It can be used to add > nvdimm pmu data such as

Re: [PATCH 1/5] KVM: rseq: Update rseq when processing NOTIFY_RESUME on xfer to KVM guest

2021-09-07 Thread Sean Christopherson
On Mon, Sep 06, 2021, Paolo Bonzini wrote: > On 20/08/21 20:51, Mathieu Desnoyers wrote: > > > Ah, or is it the case that rseq_cs is non-NULL if and only if userspace > > > is in an > > > rseq critical section, and because syscalls in critical sections are > > > illegal, by > > > definition

RE: [PATCH v3] ftrace: Cleanup ftrace_dyn_arch_init()

2021-09-07 Thread LEROY Christophe
> -Message d'origine- > De : Linuxppc-dev bounces+christophe.leroy=csgroup...@lists.ozlabs.org> De la part de Weizhao > Ouyang > > Most of ARCHs use empty ftrace_dyn_arch_init(), introduce a weak common > ftrace_dyn_arch_init() to cleanup them. > > Signed-off-by: Weizhao Ouyang >

[PATCH 3/9] xen/x86: make "earlyprintk=xen" work better for PVH Dom0

2021-09-07 Thread Jan Beulich
The xen_hvm_early_write() path better wouldn't be taken in this case; while port 0xE9 can be used, the hypercall path is quite a bit more efficient. Put that first, as it may also work for DomU-s (see also xen_raw_console_write()). While there also bail from the function when the first

[PATCH 5/9] xen/x86: make "earlyprintk=xen" work for HVM/PVH DomU

2021-09-07 Thread Jan Beulich
xenboot_write_console() is dealing with these quite fine so I don't see why xenboot_console_setup() would return -ENOENT in this case. Adjust documentation accordingly. Signed-off-by: Jan Beulich --- a/Documentation/admin-guide/kernel-parameters.txt +++

Re: [PATCH] powerpc/mce: Fix access error in mce handler

2021-09-07 Thread Ganesh
On 9/6/21 6:03 PM, Michael Ellerman wrote: Ganesh Goudar writes: We queue an irq work for deferred processing of mce event in realmode mce handler, where translation is disabled. Queuing of the work may result in accessing memory outside RMO region, such access needs the translation to be

Re: [PATCH 0/5] s390/pci: automatic error recovery

2021-09-07 Thread Niklas Schnelle
On Tue, 2021-09-07 at 10:45 +0200, Niklas Schnelle wrote: > On Tue, 2021-09-07 at 12:04 +1000, Oliver O'Halloran wrote: > > On Mon, Sep 6, 2021 at 7:49 PM Niklas Schnelle > > wrote: > > > Patch 3 I already sent separately resulting in the discussion below but > > > without > > > a final

Re: [PATCH] pci/hotplug/pnv-php: Remove probable double put

2021-09-07 Thread Bjorn Helgaas
Make your subject line follow the previous convention. Figure out if this is a "probable" or a real double put. If it's a real double put, we should fix it. If it's only "probable," that means we don't understand the problem yet. On Tue, Sep 07, 2021 at 08:59:46AM +, Xu Wang wrote: >

[PATCH v3] ftrace: Cleanup ftrace_dyn_arch_init()

2021-09-07 Thread Weizhao Ouyang
Most of ARCHs use empty ftrace_dyn_arch_init(), introduce a weak common ftrace_dyn_arch_init() to cleanup them. Signed-off-by: Weizhao Ouyang Acked-by: Heiko Carstens (s390) Acked-by: Helge Deller (parisc) --- Changes in v3: -- fix unrecognized opcode on PowerPC Changes in v2: -- correct

[PATCH] pci/hotplug/pnv-php: Remove probable double put

2021-09-07 Thread Xu Wang
Device node iterators put the previous value of the index variable, so an explicit put causes a double put. Signed-off-by: Xu Wang --- drivers/pci/hotplug/pnv_php.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/hotplug/pnv_php.c b/drivers/pci/hotplug/pnv_php.c index

Re: [PATCH 0/5] s390/pci: automatic error recovery

2021-09-07 Thread Niklas Schnelle
On Tue, 2021-09-07 at 12:04 +1000, Oliver O'Halloran wrote: > On Mon, Sep 6, 2021 at 7:49 PM Niklas Schnelle wrote: > > Patch 3 I already sent separately resulting in the discussion below but > > without > > a final conclusion. > > > >

Re: [PATCH 3/5] PCI: Move pci_dev_is/assign_added() to pci.h

2021-09-07 Thread Niklas Schnelle
On Tue, 2021-09-07 at 10:51 +0300, Andy Shevchenko wrote: > On Tue, Sep 7, 2021 at 3:26 AM kernel test robot wrote: > > Hi Niklas, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on s390/features] > > [also build test ERROR on next-20210906] > > [cannot apply

Re: [PATCH 3/5] PCI: Move pci_dev_is/assign_added() to pci.h

2021-09-07 Thread Andy Shevchenko
On Tue, Sep 7, 2021 at 3:26 AM kernel test robot wrote: > > Hi Niklas, > > I love your patch! Yet something to improve: > > [auto build test ERROR on s390/features] > [also build test ERROR on next-20210906] > [cannot apply to pci/next powerpc/next v5.14] > [If your patch is applied to the wrong

Re: [PATCH 0/5] s390/pci: automatic error recovery

2021-09-07 Thread Niklas Schnelle
On Mon, 2021-09-06 at 21:05 -0500, Linas Vepstas wrote: > On Mon, Sep 6, 2021 at 4:49 AM Niklas Schnelle > wrote: > > > I believe we might be the first > > implementation of PCI device recovery in a virtualized setting requiring > > us to > > coordinate the device reset with the hypervisor