Re: [PATCH v3 6/6] KVM: PPC: mmio: Reject instructions that access more than mmio.data size

2022-01-09 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of January 8, 2022 7:00 am: > The MMIO interface between the kernel and userspace uses a structure > that supports a maximum of 8-bytes of data. Instructions that access > more than that need to be emulated in parts. > > We currently don't have generic

Re: [PATCH v3 5/6] KVM: PPC: mmio: Return to guest after emulation failure

2022-01-09 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of January 8, 2022 7:00 am: > If MMIO emulation fails we don't want to crash the whole guest by > returning to userspace. > > The original commit bbf45ba57eae ("KVM: ppc: PowerPC 440 KVM > implementation") added a todo: > > /* XXX Deliver Program interrupt

Re: [PATCH v3 4/6] KVM: PPC: mmio: Queue interrupt at kvmppc_emulate_mmio

2022-01-09 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of January 8, 2022 7:00 am: > If MMIO emulation fails, we queue a Program interrupt to the > guest. Move that line up into kvmppc_emulate_mmio, which is where we > set RESUME_GUEST/HOST. This allows the removal of the 'advance' > variable. > > No functional

Re: [PATCH v3 3/6] KVM: PPC: Don't use pr_emerg when mmio emulation fails

2022-01-09 Thread Nicholas Piggin
Excerpts from Fabiano Rosas's message of January 8, 2022 7:00 am: > If MMIO emulation fails we deliver a Program interrupt to the > guest. This is a normal event for the host, so use pr_info. > > Signed-off-by: Fabiano Rosas > --- Should it be rate limited to prevent guest spamming host log? In

Re: [PATCH 00/13] powerpc/bpf: Some fixes and updates

2022-01-09 Thread Michael Ellerman
Daniel Borkmann writes: > On 1/7/22 8:36 AM, Naveen N. Rao wrote: >> Daniel Borkmann wrote: >>> On 1/6/22 12:45 PM, Naveen N. Rao wrote: A set of fixes and updates to powerpc BPF JIT: - Patches 1-3 fix issues with the existing powerpc JIT and are tagged    for -stable. - Patch

Re: [PATCH v3 4/6] KVM: PPC: mmio: Queue interrupt at kvmppc_emulate_mmio

2022-01-09 Thread Alexey Kardashevskiy
On 08/01/2022 08:00, Fabiano Rosas wrote: If MMIO emulation fails, we queue a Program interrupt to the guest. Move that line up into kvmppc_emulate_mmio, which is where we set RESUME_GUEST/HOST. This allows the removal of the 'advance' variable. No functional change, just separation of

Re: [PATCH]powerpc/xmon: Dump XIVE information for online-only processors.

2022-01-09 Thread Michael Ellerman
On Wed, 05 Jan 2022 19:47:48 +0530, Sachin Sant wrote: > dxa command in XMON debugger iterates through all possible processors. > As a result, empty lines are printed even for processors which are not > online. > > CPU 47:pp=00 CPPR=ff IPI=0x0040002f PQ=-- EQ idx=699 T=0 > CPU

Re: (subset) [PATCH V3 0/8] sched: Remove unused TASK_SIZE_OF for all archs

2022-01-09 Thread Michael Ellerman
On Tue, 28 Dec 2021 14:47:21 +0800, guo...@kernel.org wrote: > From: Guo Ren > > This macro isn't used in Linux, now. Delete in include/linux/sched.h > and arch's include/asm. This would confuse people who are > implementing the COMPAT feature for architecture. > > Changes in v3: > - Fixup

Re: [PATCH] powerpc/opal: use default_groups in kobj_type

2022-01-09 Thread Michael Ellerman
On Tue, 4 Jan 2022 17:13:18 +0100, Greg Kroah-Hartman wrote: > There are currently 2 ways to create a set of sysfs files for a > kobj_type, through the default_attrs field, and the default_groups > field. Move the powerpc opal dump and elog sysfs code to use > default_groups field which has been

Re: [PATCH] powerpc/cacheinfo: use default_groups in kobj_type

2022-01-09 Thread Michael Ellerman
On Tue, 4 Jan 2022 16:54:50 +0100, Greg Kroah-Hartman wrote: > There are currently 2 ways to create a set of sysfs files for a > kobj_type, through the default_attrs field, and the default_groups > field. Move the powerpc cacheinfo sysfs code to use default_groups > field which has been the

Re: [PATCH] floppy: Remove usage of the deprecated "pci-dma-compat.h" API

2022-01-09 Thread Michael Ellerman
On Sun, 2 Jan 2022 11:29:54 +0100, Christophe JAILLET wrote: > In [1], Christoph Hellwig has proposed to remove the wrappers in > include/linux/pci-dma-compat.h. > > Some reasons why this API should be removed have been given by Julia > Lawall in [2]. > > A coccinelle script has been used to

Re: [PATCH] powerpc/xive: Add missing null check after calling kmalloc

2022-01-09 Thread Michael Ellerman
On Sun, 26 Dec 2021 20:54:02 +0700, Ammar Faizi wrote: > Commit 930914b7d528fc ("powerpc/xive: Add a debugfs file to dump > internal XIVE state") forgot to add a null check. > > Add it. > > Applied to powerpc/next. [1/1] powerpc/xive: Add missing null check after calling kmalloc

Re: Linux kernel: powerpc: KVM guest can trigger host crash on Power8

2022-01-09 Thread John Paul Adrian Glaubitz
Hi Michael! On 1/7/22 12:20, John Paul Adrian Glaubitz wrote: >> Can you separately test with (on the host): >> >> # echo 0 > /sys/module/kvm_hv/parameters/dynamic_mt_modes > > I'm trying to turn off "dynamic_mt_modes" first and see if that makes any > difference. > > I will report back. So

[Bug 215470] New: Unable to boot NXP P2020 processor (freeze before any print to stdout)

2022-01-09 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215470 Bug ID: 215470 Summary: Unable to boot NXP P2020 processor (freeze before any print to stdout) Product: Platform Specific/Hardware Version: 2.5 Kernel Version: >=v5.15-rc1