Re: [PATCH] powerpc/85xx: P2020: Add law_trgt_if property to PCIe DT nodes
Rob Herring writes: > On Fri, Jul 29, 2022 at 7:17 AM Michael Ellerman > wrote: >> >> On Wed, 4 May 2022 20:08:22 +0200, Pali Rohár wrote: >> > DT law_trgt_if property defines Local Access Window Target Interface. >> > >> > Local Access Window Target Interface is used for identifying individual >> > peripheral and mapping its memory to CPU. Interface id is defined by >> > hardware itself. >> > >> > U-Boot uses law_trgt_if DT property in PCIe nodes for configuring memory >> > mapping of individual PCIe controllers. >> > >> > [...] >> >> Applied to powerpc/next. >> >> [1/1] powerpc/85xx: P2020: Add law_trgt_if property to PCIe DT nodes >> >> https://git.kernel.org/powerpc/c/1f00b5ab992c122c51bc37662b3b4df5963462f3 > > Why? Minimally, it needs a vendor prefix and s/_/-/ as I commented. OK. I misread your "maybe that's fine" as approval. Pali can you send a fixup patch please? cheers
[PATCH linux-next] macintosh:adb:recordmcount:use !E in conditional statements
From: ye xingchen Use !E to replace the type of x == 0. This change is just to simplify the code, no actual functional changes. Reported-by: Zeal Robot Signed-off-by: ye xingchen --- drivers/macintosh/adb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/macintosh/adb.c b/drivers/macintosh/adb.c index 1bbb9ca08d40..368ab25db234 100644 --- a/drivers/macintosh/adb.c +++ b/drivers/macintosh/adb.c @@ -673,7 +673,7 @@ static int adb_open(struct inode *inode, struct file *file) goto out; } state = kmalloc(sizeof(struct adbdev_state), GFP_KERNEL); - if (state == 0) { + if (!state) { ret = -ENOMEM; goto out; } -- 2.25.1
Re: [RFC] Remove DECNET support from kernel
On Sunday 31 July 2022 12:06:10 Stephen Hemminger wrote: > diff --git a/Documentation/admin-guide/sysctl/net.rst > b/Documentation/admin-guide/sysctl/net.rst > index 805f2281e000..299d9c3407d3 100644 > --- a/Documentation/admin-guide/sysctl/net.rst > +++ b/Documentation/admin-guide/sysctl/net.rst > @@ -39,7 +39,6 @@ Table : Subdirectories in /proc/sys/net > 802 E802 protocol ax25 AX25 > ethernet Ethernet protocol rose X.25 PLP layer > ipv4 IP version 4 x25X.25 protocol > - bridgeBridging decnet DEC net > ipv6 IP version 6 tipc TIPC > = === = == == > Hello! You should remove only decnet from the list, not bridge. This is two columns table.
Re: [PATCH 04/36] cpuidle,intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE
On Sat, Jul 30, 2022 at 09:52:34PM +0200, Rafael J. Wysocki wrote: > On Sat, Jul 30, 2022 at 11:48 AM Michel Lespinasse > wrote: > > I'm not sure if that was the patch you meant to send though, as it > > seems it's only adding a tracepoint so shouldn't make any difference > > if I'm not actually using the tracepoint ? > > You are right, it looks like I pasted a link to a different patch by > mistake. Sorry about that. > > I meant this one: > > https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git/commit/?h=pm=d295ad34f236c3518634fb6403d4c0160456e470 > > which will appear in the final 5.19. Thanks. I can confirm that this patch fixes the boot time debug warnings for me. And I see that linus already merged it, nice! -- Michel "walken" Lespinasse.