Re: [PATCH v4 0/7] introduce vm_flags modifier functions

2023-03-17 Thread Suren Baghdasaryan
On Fri, Mar 17, 2023 at 3:41 PM Alex Williamson wrote: > > On Fri, 17 Mar 2023 12:08:32 -0700 > Suren Baghdasaryan wrote: > > > On Tue, Mar 14, 2023 at 1:11 PM Alex Williamson > > wrote: > > > > > > On Thu, 26 Jan 2023 11:37:45 -0800 > > > Suren Baghdasaryan wrote: > > > > > > > This patchset

Re: [PATCH v4 0/7] introduce vm_flags modifier functions

2023-03-17 Thread Alex Williamson
On Fri, 17 Mar 2023 12:08:32 -0700 Suren Baghdasaryan wrote: > On Tue, Mar 14, 2023 at 1:11 PM Alex Williamson > wrote: > > > > On Thu, 26 Jan 2023 11:37:45 -0800 > > Suren Baghdasaryan wrote: > > > > > This patchset was originally published as a part of per-VMA locking [1] > > > and > > >

Re: [PATCHv2 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO

2023-03-17 Thread Bjorn Helgaas
On Fri, Mar 17, 2023 at 11:50:22AM -0700, Sathyanarayanan Kuppuswamy wrote: > On 3/17/23 10:51 AM, Grant Grundler wrote: > > Since correctable errors have been corrected (and counted), the dmesg output > > should not be reported as a warning, but rather as "informational". > > > > Otherwise,

Re: [PATCH v11 09/13] arm64: dts: ls1046a: Add serdes nodes

2023-03-17 Thread Sean Anderson
On 3/14/23 03:08, Shawn Guo wrote: > On Mon, Mar 13, 2023 at 12:11:33PM -0400, Sean Anderson wrote: >> This adds nodes for the SerDes devices. They are disabled by default >> to prevent any breakage on existing boards. >> >> Signed-off-by: Sean Anderson > > The DTS patches look good to me. Let

Re: [PATCH v4 0/7] introduce vm_flags modifier functions

2023-03-17 Thread Suren Baghdasaryan
On Tue, Mar 14, 2023 at 1:11 PM Alex Williamson wrote: > > On Thu, 26 Jan 2023 11:37:45 -0800 > Suren Baghdasaryan wrote: > > > This patchset was originally published as a part of per-VMA locking [1] and > > was split after suggestion that it's viable on its own and to facilitate > > the review

Re: [PATCHv2 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO

2023-03-17 Thread Sathyanarayanan Kuppuswamy
On 3/17/23 10:51 AM, Grant Grundler wrote: > Since correctable errors have been corrected (and counted), the dmesg output > should not be reported as a warning, but rather as "informational". > > Otherwise, using a certain well known vendor's PCIe parts in a USB4 docking > station, the dmesg

Re: [PATCH] PCI/AER: correctable error message as KERN_INFO

2023-03-17 Thread Grant Grundler
On Tue, Mar 14, 2023 at 5:24 PM Grant Grundler wrote: > > On Tue, Mar 14, 2023 at 12:38 PM Bjorn Helgaas wrote: > > > > On Tue, Feb 28, 2023 at 10:04:53PM -0800, Grant Grundler wrote: > > > Since correctable errors have been corrected (and counted), the dmesg > > > output > > > should not be

[PATCHv2 pci-next 2/2] PCI/AER: Rate limit the reporting of the correctable errors

2023-03-17 Thread Grant Grundler
From: Rajat Khandelwal There are many instances where correctable errors tend to inundate the message buffer. We observe such instances during thunderbolt PCIe tunneling. It's true that they are mitigated by the hardware and are non-fatal but we shouldn't be spamming the logs with such

[PATCHv2 pci-next 1/2] PCI/AER: correctable error message as KERN_INFO

2023-03-17 Thread Grant Grundler
Since correctable errors have been corrected (and counted), the dmesg output should not be reported as a warning, but rather as "informational". Otherwise, using a certain well known vendor's PCIe parts in a USB4 docking station, the dmesg buffer can be spammed with correctable errors, 717 bytes

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.3-3 tag

2023-03-17 Thread pr-tracker-bot
The pull request you sent on Fri, 17 Mar 2023 14:24:51 +1100: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-6.3-3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/17adaeaed05b879964b1a72e4db87ebf3b2a38ba Thank you! --

RE: [EXT] Re: [PATCH 1/1] PCI: layerscape: Add the workaround for A-010305

2023-03-17 Thread Frank Li
> > pci->ep.ops = _pcie_ep_ops; > > > > + pcie->big_endian = of_property_read_bool(dev->of_node, "big- > endian"); > > Somewhat surprising that 6c389328c985 ("dt-bindings: pci: > layerscape-pci: Add a optional property big-endian") added this > property a year ago, but it has been

Re: powerpc/pseries: Fix exception handling in pSeries_reconfig_add_node()

2023-03-17 Thread Nathan Lynch
Markus Elfring writes: >>> The label “out_err” was used to jump to another pointer check despite of >>> the detail in the implementation of the function “pSeries_reconfig_add_node” >>> that it was determined already that the corresponding variable contained >>> a null pointer (because of a failed

Re: powerpc/pseries: Fix exception handling in pSeries_reconfig_add_node()

2023-03-17 Thread Markus Elfring
>> The label “out_err” was used to jump to another pointer check despite of >> the detail in the implementation of the function “pSeries_reconfig_add_node” >> that it was determined already that the corresponding variable contained >> a null pointer (because of a failed function call in two

Re: [PATCH v2] hvc/xen: prevent concurrent accesses to the shared ring

2023-03-17 Thread Juergen Gross
On 30.11.22 16:09, Roger Pau Monne wrote: The hvc machinery registers both a console and a tty device based on the hv ops provided by the specific implementation. Those two interfaces however have different locks, and there's no single locks that's shared between the tty and the console

Re: [PATCH] powerpc/pseries: Fix exception handling in pSeries_reconfig_add_node()

2023-03-17 Thread Nathan Lynch
Markus Elfring writes: > > The label “out_err” was used to jump to another pointer check despite of > the detail in the implementation of the function “pSeries_reconfig_add_node” > that it was determined already that the corresponding variable contained > a null pointer (because of a failed

Re: [kvm-unit-tests PATCH 3/7] powerpc: abstract H_CEDE calls into a sleep() function

2023-03-17 Thread Thomas Huth
On 17/03/2023 13.36, Nicholas Piggin wrote: This consolidates several implementations, and it no longer leaves MSR[EE] enabled after the decrementer interrupt is handled, but rather disables it on return. The handler no longer allows a continuous ticking, but rather dec has to be re-armed and

Re: [kvm-unit-tests PATCH 2/7] powerpc: add local variant of SPR test

2023-03-17 Thread Thomas Huth
On 17/03/2023 13.36, Nicholas Piggin wrote: This adds the non-migration variant of the SPR test to the matrix, which can be simpler to run and debug. Signed-off-by: Nicholas Piggin --- powerpc/unittests.cfg | 4 1 file changed, 4 insertions(+) diff --git a/powerpc/unittests.cfg

[kvm-unit-tests PATCH 7/7] powerpc/spapr_vpa: Add basic VPA tests

2023-03-17 Thread Nicholas Piggin
The VPA is a(n optional) memory structure shared between the hypervisor and operating system, defined by PAPR. This test defines the structure and adds registration, deregistration, and a few simple sanity tests. Signed-off-by: Nicholas Piggin --- lib/linux/compiler.h| 2 +

[kvm-unit-tests PATCH 6/7] powerpc/sprs: Specify SPRs with data rather than code

2023-03-17 Thread Nicholas Piggin
A significant rework that builds an array of 'struct spr', where each element describes an SPR. This makes various metadata about the SPR like name and access type easier to carry and use. Hypervisor privileged registers are described despite not being used at the moment for completeness, but

[kvm-unit-tests PATCH 5/7] powerpc: Indirect SPR accessor functions

2023-03-17 Thread Nicholas Piggin
Make overly-clever SPR accessor functions that allow a non-constant SPR number to be specified. This will be used to restructure test in the next change. Signed-off-by: Nicholas Piggin --- powerpc/sprs.c | 63 ++ 1 file changed, 54 insertions(+),

[kvm-unit-tests PATCH 4/7] powerpc: Add ISA v3.1 (POWER10) support to SPR test

2023-03-17 Thread Nicholas Piggin
This is a very basic detection that does not include all new SPRs. Signed-off-by: Nicholas Piggin --- powerpc/sprs.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/powerpc/sprs.c b/powerpc/sprs.c index 161a6ba..45f77a5 100644 --- a/powerpc/sprs.c +++

[kvm-unit-tests PATCH 1/7] MAINTAINERS: Update powerpc list

2023-03-17 Thread Nicholas Piggin
KVM development on powerpc has moved to the Linux on Power mailing list, as per linux.git commit 19b27f37ca97d ("MAINTAINERS: Update powerpc KVM entry"). Signed-off-by: Nicholas Piggin --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS

[kvm-unit-tests PATCH 3/7] powerpc: abstract H_CEDE calls into a sleep() function

2023-03-17 Thread Nicholas Piggin
This consolidates several implementations, and it no longer leaves MSR[EE] enabled after the decrementer interrupt is handled, but rather disables it on return. The handler no longer allows a continuous ticking, but rather dec has to be re-armed and EE re-enabled (e.g., via H_CEDE hcall) each

[kvm-unit-tests PATCH 2/7] powerpc: add local variant of SPR test

2023-03-17 Thread Nicholas Piggin
This adds the non-migration variant of the SPR test to the matrix, which can be simpler to run and debug. Signed-off-by: Nicholas Piggin --- powerpc/unittests.cfg | 4 1 file changed, 4 insertions(+) diff --git a/powerpc/unittests.cfg b/powerpc/unittests.cfg index 1e74948..3e41598 100644

Re: [PATCH v2] hvc/xen: prevent concurrent accesses to the shared ring

2023-03-17 Thread Roger Pau Monné
On Fri, Mar 10, 2023 at 10:18:32AM +0100, Roger Pau Monné wrote: > On Fri, Mar 10, 2023 at 10:01:39AM +1100, Michael Ellerman wrote: > > Roger Pau Monné writes: > > > On Mon, Dec 12, 2022 at 01:36:48PM +0100, Roger Pau Monné wrote: > > >> On Fri, Dec 02, 2022 at 12:40:05PM +0100, Roger Pau Monné

[PATCH] powerpc/pseries: Fix exception handling in pSeries_reconfig_add_node()

2023-03-17 Thread Markus Elfring
Date: Fri, 17 Mar 2023 09:26:13 +0100 The label “out_err” was used to jump to another pointer check despite of the detail in the implementation of the function “pSeries_reconfig_add_node” that it was determined already that the corresponding variable contained a null pointer (because of a failed