Re: [RFC PATCH v12 11/33] KVM: Introduce per-page memory attributes

2023-09-26 Thread Binbin Wu
On 9/21/2023 5:03 AM, Sean Christopherson wrote: On Mon, Sep 18, 2023, Binbin Wu wrote: On 9/14/2023 9:55 AM, Sean Christopherson wrote: From: Chao Peng [...] +#ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES +/* + * Returns true if _all_ gfns in the range [@start, @end) have attributes + *

Re: linux-next: Tree for Sep 26 (arch/powerpc/platforms/86xx/pic.o)

2023-09-26 Thread Randy Dunlap
On 9/25/23 22:50, Stephen Rothwell wrote: > Hi all, > > Changes since 20230925: > on powerpc 32BIT: powerpc-linux-ld: arch/powerpc/platforms/86xx/pic.o: in function `mpc86xx_init_irq': pic.c:(.init.text+0x38): undefined reference to `mpic_alloc' powerpc-linux-ld: pic.c:(.init.text+0x58):

Re: [PATCH V2] perf test: Fix parse-events tests to skip parametrized events

2023-09-26 Thread Athira Rajeev
> On 27-Sep-2023, at 4:07 AM, Namhyung Kim wrote: > > Hello, > > On Mon, Sep 25, 2023 at 10:37 AM Arnaldo Carvalho de Melo > wrote: >> >> >> >> On Wed, Sep 13, 2023, 7:40 AM Athira Rajeev >> wrote: >>> >>> >>> On 08-Sep-2023, at 7:48 PM, Athira Rajeev wrote:

Re: [PATCH 0/3] Fix for shellcheck issues with version "0.6"

2023-09-26 Thread Athira Rajeev
> On 25-Sep-2023, at 1:34 PM, kajoljain wrote: > > > > On 9/7/23 22:45, Athira Rajeev wrote: >> From: root >> >> shellcheck was run on perf tool shell scripts s a pre-requisite >> to include a build option for shellcheck discussed here: >>

Re: [PATCH 2/2] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

2023-09-26 Thread Athira Rajeev
> On 27-Sep-2023, at 5:25 AM, Namhyung Kim wrote: > > On Thu, Sep 14, 2023 at 10:18 AM Athira Rajeev > wrote: >> >> Add rule in new Makefile "tests/Makefile.tests" for running >> shellcheck on shell test scripts. This automates below shellcheck >> into the build. >> >>$ for F in

Re: [PATCH 1/2] tools/perf: Add new CONFIG_SHELLCHECK for detecting shellcheck binary

2023-09-26 Thread Athira Rajeev
> On 27-Sep-2023, at 5:21 AM, Namhyung Kim wrote: > > Hello, > > On Thu, Sep 14, 2023 at 10:18 AM Athira Rajeev > wrote: >> >> shellcheck tool can detect coding/formatting issues on >> shell scripts. In perf directory "tests/shell", there are lot >> of shell test scripts and this tool can

Re: Questions: Should kernel panic when PCIe fatal error occurs?

2023-09-26 Thread Oliver O'Halloran
On Wed, Sep 27, 2023 at 9:03 AM Bjorn Helgaas wrote: > > On Fri, Sep 22, 2023 at 10:46:36AM +0800, Shuai Xue wrote: > > ... > > > Actually, this is a question from my colleague from firmware team. > > The original question is that: > > > > "Should I set CPER_SEV_FATAL for Generic Error Status

[PATCH] powerpc/pseries/vas: Migration suspend waits for no in-progress open windows

2023-09-26 Thread Haren Myneni
The hypervisor returns migration failure if all VAS windows are not closed. During pre-migration stage, vas_migration_handler() sets migration_in_progress flag and closes all windows from the list. The allocate VAS window routine checks the migration flag, setup the window and then add it to the

[PATCH] powerpc/pseries/vas: Migration suspend waits for no in-progress open windows

2023-09-26 Thread Haren Myneni
The hypervisor returns migration failure if all VAS windows are not closed. During pre-migration stage, vas_migration_handler() sets migration_in_progress flag and closes all windows from the list. The allocate VAS window routine checks the migration flag, setup the window and then add it to the

RE: Re: [PATCH v2 1/2] ASoC: dt-bindings: fsl_rpmsg: List DAPM endpoints ignoring system suspend

2023-09-26 Thread Chancel Liu
> > + fsl,lpa-widgets: > > +$ref: /schemas/types.yaml#/definitions/non-unique-string-array > > +description: | > > + A list of DAPM endpoints which mark paths between these > endpoints should > > + not be disabled when system enters in suspend state. LPA means low power > > +

Re: Questions: Should kernel panic when PCIe fatal error occurs?

2023-09-26 Thread Shuai Xue
On 2023/9/27 07:02, Bjorn Helgaas wrote: > On Fri, Sep 22, 2023 at 10:46:36AM +0800, Shuai Xue wrote: >> ... > >> Actually, this is a question from my colleague from firmware team. >> The original question is that: >> >> "Should I set CPER_SEV_FATAL for Generic Error Status Block when a >>

Re: [PATCH 00/40] soc: Convert to platform remove callback returning void

2023-09-26 Thread Joel Stanley
On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König wrote: > > Hello, > > this series converts all platform drivers below drivers/soc to use > .remove_new(). The motivation is to get rid of an integer return code > that is (mostly) ignored by the platform driver core and error prone on > the driver

Re: [PATCH V4 2/2] tools/perf/tests: Fix object code reading to skip address that falls out of text section

2023-09-26 Thread Namhyung Kim
On Thu, Sep 14, 2023 at 10:40 PM Athira Rajeev wrote: > > The testcase "Object code reading" fails in somecases > for "fs_something" sub test as below: > > Reading object code for memory address: 0xc00807f0142c > File is: /lib/modules/6.5.0-rc3+/kernel/fs/xfs/xfs.ko > On file

Re: [PATCH v10 13/15] PCI/AER: Forward RCH downstream port-detected errors to the CXL.mem dev handler

2023-09-26 Thread Dan Williams
Terry Bowman wrote: > Hi Dan, > > On 8/31/23 15:35, Dan Williams wrote: > > Terry Bowman wrote: > >> From: Robert Richter > >> > >> In Restricted CXL Device (RCD) mode a CXL device is exposed as an > >> RCiEP, but CXL downstream and upstream ports are not enumerated and > >> not visible in the

Re: [PATCH 2/2] tools/perf: Add perf binary dependent rule for shellcheck log in Makefile.perf

2023-09-26 Thread Namhyung Kim
On Thu, Sep 14, 2023 at 10:18 AM Athira Rajeev wrote: > > Add rule in new Makefile "tests/Makefile.tests" for running > shellcheck on shell test scripts. This automates below shellcheck > into the build. > > $ for F in $(find tests/shell/ -perm -o=x -name '*.sh'); do > shellcheck -S

Re: [PATCH 1/2] tools/perf: Add new CONFIG_SHELLCHECK for detecting shellcheck binary

2023-09-26 Thread Namhyung Kim
Hello, On Thu, Sep 14, 2023 at 10:18 AM Athira Rajeev wrote: > > shellcheck tool can detect coding/formatting issues on > shell scripts. In perf directory "tests/shell", there are lot > of shell test scripts and this tool can detect coding/formatting > issues on these scripts. > > Example to use

[linux-next:master] BUILD REGRESSION 4ae73bba62a367f2314f6ce69e3085a941983d8b

2023-09-26 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 4ae73bba62a367f2314f6ce69e3085a941983d8b Add linux-next specific files for 20230926 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202308282000.2xnh0k6d-...@intel.com https

Re: Questions: Should kernel panic when PCIe fatal error occurs?

2023-09-26 Thread Bjorn Helgaas
On Fri, Sep 22, 2023 at 10:46:36AM +0800, Shuai Xue wrote: > ... > Actually, this is a question from my colleague from firmware team. > The original question is that: > > "Should I set CPER_SEV_FATAL for Generic Error Status Block when a > PCIe fatal error is detected? If set, kernel

Re: [PATCH V2] perf test: Fix parse-events tests to skip parametrized events

2023-09-26 Thread Namhyung Kim
Hello, On Mon, Sep 25, 2023 at 10:37 AM Arnaldo Carvalho de Melo wrote: > > > > On Wed, Sep 13, 2023, 7:40 AM Athira Rajeev > wrote: >> >> >> >> > On 08-Sep-2023, at 7:48 PM, Athira Rajeev >> > wrote: >> > >> > >> > >> >> On 08-Sep-2023, at 11:04 AM, Sachin Sant wrote: >> >> >> >> >> >> >>

[PATCH] uapi/auxvec: Define AT_HWCAP3 and AT_HWCAP4 aux vector, entries

2023-09-26 Thread Peter Bergner
The powerpc toolchain keeps a copy of the HWCAP bit masks in our TCB for fast access by our __builtin_cpu_supports built-in function. The TCB space for the HWCAP entries - which are created in pairs - is an ABI extension, so waiting to create the space for HWCAP3 and HWCAP4 until we need them is

Re: [PATCH 8/8] iommu/dart: Call apple_dart_finalize_domain() as part of alloc_paging()

2023-09-26 Thread Janne Grunau
On Fri, Sep 22, 2023 at 02:07:59PM -0300, Jason Gunthorpe wrote: > In many cases the dev argument will now be !NULL so we should use it to > finalize the domain at allocation. > > Make apple_dart_finalize_domain() accept the correct type. > > Signed-off-by: Jason Gunthorpe > --- >

Re: [PATCH 7/8] iommu/dart: Convert to domain_alloc_paging()

2023-09-26 Thread Janne Grunau
On Fri, Sep 22, 2023 at 02:07:58PM -0300, Jason Gunthorpe wrote: > Since the IDENTITY and BLOCKED behaviors were moved to global statics all > that remains is the paging domain. Rename to > apple_dart_attach_dev_paging() and remove the left over cruft. > > Signed-off-by: Jason Gunthorpe > --- >

Re: [PATCH 6/8] iommu/dart: Move the blocked domain support to a global static

2023-09-26 Thread Janne Grunau
Hej, On Fri, Sep 22, 2023 at 02:07:57PM -0300, Jason Gunthorpe wrote: > Move to the new static global for blocked domains. Move the blocked > specific code to apple_dart_attach_dev_blocked(). > > Signed-off-by: Jason Gunthorpe > --- > drivers/iommu/apple-dart.c | 36

Re: [PATCH v6 08/30] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC

2023-09-26 Thread Krzysztof Kozlowski
On 25/09/2023 15:50, Herve Codina wrote: > With these details, do you still think I need to change the child > (channel) > compatible ? From OS point of view, you have a driver binding to this child-level compatible. How do you enforce Linux driver binding based on

Re: [PATCH 6/8] iommu/dart: Move the blocked domain support to a global static

2023-09-26 Thread Robin Murphy
On 2023-09-26 20:05, Janne Grunau wrote: Hej, On Fri, Sep 22, 2023 at 02:07:57PM -0300, Jason Gunthorpe wrote: Move to the new static global for blocked domains. Move the blocked specific code to apple_dart_attach_dev_blocked(). Signed-off-by: Jason Gunthorpe --- drivers/iommu/apple-dart.c

Re: [PATCH 6/8] iommu/dart: Move the blocked domain support to a global static

2023-09-26 Thread Robin Murphy
On 2023-09-26 20:34, Robin Murphy wrote: On 2023-09-26 20:05, Janne Grunau wrote: Hej, On Fri, Sep 22, 2023 at 02:07:57PM -0300, Jason Gunthorpe wrote: Move to the new static global for blocked domains. Move the blocked specific code to apple_dart_attach_dev_blocked(). Signed-off-by: Jason

Re: [Bisected] PowerMac G4 getting "BUG: Unable to handle kernel data access on write at 0x00001ff0" at boot with CONFIG_VMAP_STACK=y on kernels 6.5.x (regression over 6.4.x)

2023-09-26 Thread Liam R. Howlett
* Bagas Sanjaya [230925 20:03]: > On Tue, Sep 26, 2023 at 01:01:59AM +0200, Erhard Furtner wrote: > > Greetings! > > > > Had a chat on #gentoo-powerpc with another user whose G4 Mini fails booting > > kernel 6.5.0 when CONFIG_VMAP_STACK=y is enabled. I was able to replicate > > the issue on my

Re: [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-09-26 Thread Mark Brown
On Mon, 25 Sep 2023 17:09:28 -0500, Rob Herring wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. > > Add

[PATCH v3 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-26 Thread Frank Li
From: Guanhua Gao Set DMA mask and coherent DMA mask to enable 64-bit addressing. Signed-off-by: Guanhua Gao Signed-off-by: Hou Zhiqiang Signed-off-by: Frank Li --- Notes: change from v2 to v3 - remove check return value of dma_set_mask_and_coherent. 64bit mask always return

Re: [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-26 Thread Frank Li
On Tue, Sep 26, 2023 at 12:27:32AM -0700, Christoph Hellwig wrote: > > + /* set 64-bit DMA mask and coherent DMA mask */ > > + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); > > The comment is a bit silly :) > > > + if (ret) > > + return ret; > > Also no need to check

Re: [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-09-26 Thread Conor Dooley
On Mon, Sep 25, 2023 at 05:09:28PM -0500, Rob Herring wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. >

Re: [PATCH] ASoC: fsl-asoc-card: use integer type for fll_id and pll_id

2023-09-26 Thread Mark Brown
On Wed, 20 Sep 2023 17:43:12 +0800, Shengjiu Wang wrote: > As the pll_id and pll_id can be zero (WM8960_SYSCLK_AUTO) > with the commit 2bbc2df46e67 ("ASoC: wm8960: Make automatic the > default clocking mode") > > Then the machine driver will skip to call set_sysclk() and set_pll() > for codec,

Re: [PATCH v3 10/13] arch: make execmem setup available regardless of CONFIG_MODULES

2023-09-26 Thread Mike Rapoport
Hi Arnd, On Tue, Sep 26, 2023 at 09:33:48AM +0200, Arnd Bergmann wrote: > On Mon, Sep 18, 2023, at 09:29, Mike Rapoport wrote: > > index a42e4cd11db2..c0b536e398b4 100644 > > --- a/arch/arm/mm/init.c > > +++ b/arch/arm/mm/init.c > > +#ifdef CONFIG_XIP_KERNEL > > +/* > > + * The XIP kernel text is

Re: [PATCH] ASoC: fsl_sai: Don't disable bitclock for i.MX8MP

2023-09-26 Thread Mark Brown
On Tue, 19 Sep 2023 17:42:13 +0800, Shengjiu Wang wrote: > On i.MX8MP, the BCE and TERE bit are binding with mclk > enablement, if BCE and TERE are cleared the MCLK also be > disabled on output pin, that cause the external codec (wm8960) > in wrong state. > > Codec (wm8960) is using the mclk to

Re: [PATCH v3 02/13] mm: introduce execmem_text_alloc() and execmem_free()

2023-09-26 Thread Mike Rapoport
On Sat, Sep 23, 2023 at 03:36:01PM -0700, Song Liu wrote: > On Sat, Sep 23, 2023 at 8:39 AM Mike Rapoport wrote: > > > > On Thu, Sep 21, 2023 at 03:34:18PM -0700, Song Liu wrote: > > > On Mon, Sep 18, 2023 at 12:30 AM Mike Rapoport wrote: > > > > > > > > > > [...] > > > > > > > diff --git

Re: [PATCH v3 10/13] arch: make execmem setup available regardless of CONFIG_MODULES

2023-09-26 Thread Arnd Bergmann
On Mon, Sep 18, 2023, at 09:29, Mike Rapoport wrote: > index a42e4cd11db2..c0b536e398b4 100644 > --- a/arch/arm/mm/init.c > +++ b/arch/arm/mm/init.c > +#ifdef CONFIG_XIP_KERNEL > +/* > + * The XIP kernel text is mapped in the module area for modules and > + * some other stuff to work without any

Re: [PATCH v2 1/1] PCI: layerscape-ep: set 64-bit DMA mask

2023-09-26 Thread Christoph Hellwig
> + /* set 64-bit DMA mask and coherent DMA mask */ > + ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(64)); The comment is a bit silly :) > + if (ret) > + return ret; Also no need to check the return value when setting a 64-bit mask, but I guess it desn't hurt here.

Re: [PATCH v4 4/5] powerpc/code-patching: introduce patch_instructions()

2023-09-26 Thread Christophe Leroy
Le 26/09/2023 à 00:50, Song Liu a écrit : > On Fri, Sep 8, 2023 at 6:28 AM Hari Bathini wrote: >> >> patch_instruction() entails setting up pte, patching the instruction, >> clearing the pte and flushing the tlb. If multiple instructions need >> to be patched, every instruction would have to go

Re: [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-09-26 Thread Herve Codina
On Mon, 25 Sep 2023 17:09:28 -0500 Rob Herring wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any node. > > Add