CLK input clock in tlv320aic31xx" missed a
Kconfig option. Sending incremental patch fix.
Regards,
Ariel
Ariel D'Alessandro (1):
ASoC: fsl-asoc-card: Add missing Kconfig option for tlv320aic31xx
sound/soc/fsl/Kconfig | 1 +
1 file changed, 1 insertion(+)
--
2.30.2
Hi Mark,
On 11/22/21 9:00 PM, Mark Brown wrote:
> On Fri, 19 Nov 2021 12:32:43 -0300, Ariel D'Alessandro wrote:
>> The tlv320aic31xx codec allows using BCLK as the input clock for PLL,
>> deriving all the frequencies through a set of divisors.
>>
>> In this case,
The following commit added support for tlv320aic31xx codec to
fsl-asoc-card, but missed the related Kconfig option. Fix this.
commit 8c9b9cfb7724685ce705f511b882f30597596536
Author: Ariel D'Alessandro
Date: Fri Nov 19 12:32:48 2021 -0300
ASoC: fsl-asoc-card: Support fsl,imx-audio
On 11/19/21 12:32 PM, Ariel D'Alessandro wrote:
> Add entry for fsl,imx-audio-tlv320aic31xx audio codec. This codec is
> configured to use BCLK as clock input.
>
> Signed-off-by: Michael Trimarchi
> Signed-off-by: Ariel D'Alessandro
> ---
> sound/soc/fsl
Hi Mark,
On 12/3/21 2:34 PM, Mark Brown wrote:
> On Fri, Dec 03, 2021 at 02:25:17PM -0300, Ariel D'Alessandro wrote:
>> On 11/22/21 9:00 PM, Mark Brown wrote:
>
>>> If any updates are required or you are submitting further changes they
>>> should be sent as incre
When the clock used by the codec is BCLK, the operation parameters need
to be calculated from input sample rate and format. Low frequency rates
required different r multipliers, in order to achieve a higher PLL
output frequency.
Signed-off-by: Michael Trimarchi
Signed-off-by: Ariel D'Alessandro
Signed-off-by: Ariel D'Alessandro
---
sound/soc/codecs/tlv320aic31xx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/tlv320aic31xx.h b/sound/soc/codecs/tlv320aic31xx.h
index 2513922a0292..80d062578fb5 100644
--- a/sound/soc/codecs/tlv320aic31xx.h
+++ b
If BCLK is used as PLL input, the sysclk is determined by the hw
params. So it must be updated here to match the input frequency, based
on sample rate, format and channels.
Signed-off-by: Ariel D'Alessandro
Signed-off-by: Michael Trimarchi
---
sound/soc/codecs/tlv320aic31xx.c | 14
Add divisors for rates needed when the clk_in is set to BCLK.
Signed-off-by: Michael Trimarchi
Signed-off-by: Ariel D'Alessandro
---
sound/soc/codecs/tlv320aic31xx.c | 20
1 file changed, 20 insertions(+)
diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs
Add entry for fsl,imx-audio-tlv320aic31xx audio codec. This codec is
configured to use BCLK as clock input.
Signed-off-by: Michael Trimarchi
Signed-off-by: Ariel D'Alessandro
---
sound/soc/fsl/fsl-asoc-card.c | 12
1 file changed, 12 insertions(+)
diff --git a/sound/soc/fsl/fsl
modifies the tlv320aic31xx driver to update its sysclk if
BCLK is used as the input clock. This allows to be used by the generic
fsl-asoc-card, without having to add a specific driver.
Ariel D'Alessandro (5):
ASoC: tlv320aic31xx: Fix typo in BCLK clock name
ASoC: tlv320aic31xx: Add support
is used.
Signed-off-by: Ariel D'Alessandro
---
Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 1 +
sound/soc/fsl/fsl-asoc-card.c | 6 ++
2 files changed, 7 insertions(+)
diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc-card.txt
b
Now that fsl-asoc-card support setting mclk-id through the device-tree
mclk-id property, let's remove the default BCLK configuration for this
card.
Signed-off-by: Ariel D'Alessandro
---
sound/soc/fsl/fsl-asoc-card.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/fsl/fsl-asoc
setting mclk-id from the
device-tree node.
Ariel D'Alessandro (4):
dt-bindings: sound: Rename tlv320aic31xx-micbias as tlv320aic31xx
dt-bindings: tlv320aic31xx: Define PLL clock inputs
ASoC: fsl-asoc-card: Add optional dt property for setting mclk-id
ASoC: fsl-asoc-card: Remove BCLK default
Add constants for the different PLL clock inputs in tlv320aic31xx.
Signed-off-by: Ariel D'Alessandro
---
include/dt-bindings/sound/tlv320aic31xx.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/dt-bindings/sound/tlv320aic31xx.h
b/include/dt-bindings/sound/tlv320aic31xx.h
Let's use a more generic name, so other definitions for tlv320aic31xx
can be included.
Signed-off-by: Ariel D'Alessandro
---
.../devicetree/bindings/sound/tlv320aic31xx.txt | 2 +-
arch/arm/boot/dts/am43x-epos-evm.dts | 2 +-
include/dt-bindings/sound/tlv320aic31xx
Hi Rob,
Thanks for the review.
On 12/13/21 5:35 PM, Rob Herring wrote:
> On Fri, Dec 03, 2021 at 10:49:26AM -0300, Ariel D'Alessandro wrote:
>> This is a follow up of patchset:
>>
>> [RFC patch 0/5] Support BCLK input clock in tlv320aic31xx
>
> Link?
L
Hi Rob,
On 12/13/21 5:37 PM, Rob Herring wrote:
> On Fri, Dec 03, 2021 at 10:49:29AM -0300, Ariel D'Alessandro wrote:
>> Sound cards may allow using different main clock inputs. In the generic
>> fsl-asoc-card driver, these values are hardcoded for each specific card
>> confi
Add constants for the different PLL clock inputs in tlv320aic31xx.
Signed-off-by: Ariel D'Alessandro
---
include/dt-bindings/sound/tlv320aic31xx.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/dt-bindings/sound/tlv320aic31xx.h
b/include/dt-bindings/sound/tlv320aic31xx.h
Support setting the sound card main clock input from the device-tree
using the mclk-id property.
Signed-off-by: Ariel D'Alessandro
---
Documentation/devicetree/bindings/sound/fsl-asoc-card.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/sound/fsl-asoc
is used.
Signed-off-by: Ariel D'Alessandro
---
sound/soc/fsl/fsl-asoc-card.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
index 5ee945505281..156d3c669274 100644
--- a/sound/soc/fsl/fsl-asoc-card.c
+++ b/sound/soc/fsl/fsl
Let's use a more generic name, so other definitions for tlv320aic31xx
can be included.
Signed-off-by: Ariel D'Alessandro
Acked-by: Rob Herring
---
.../devicetree/bindings/sound/tlv320aic31xx.txt | 2 +-
arch/arm/boot/dts/am43x-epos-evm.dts | 2 +-
include/dt
setting mclk-id from the
device-tree node.
Changes in v2:
* Split patch adding mckl-id property.
Ariel D'Alessandro (5):
dt-bindings: sound: Rename tlv320aic31xx-micbias as tlv320aic31xx
dt-bindings: tlv320aic31xx: Define PLL clock inputs
ASoC: bindings: fsl-asoc-card: Add mclk-id optional
Now that fsl-asoc-card support setting mclk-id through the device-tree
mclk-id property, let's remove the default BCLK configuration for this
card.
Signed-off-by: Ariel D'Alessandro
---
sound/soc/fsl/fsl-asoc-card.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/fsl/fsl-asoc
24 matches
Mail list logo
