[PATCH 1/2] sched: Remove unused mc_capable() and smt_capable()

2014-03-04 Thread Bjorn Helgaas
Remove mc_capable() and smt_capable(). Neither is used. Both were added by 5c45bf279d37 (sched: mc/smt power savings sched policy). Uses of both were removed by 8e7fbcbc22c1 (sched: Remove stale power aware scheduling remnants and dysfunctional knobs). Signed-off-by: Bjorn Helgaas bhelg

[PATCH 2/2] sparc64: Remove unused sparc64_multi_core

2014-03-04 Thread Bjorn Helgaas
Remove sparc64_multi_core because it's not used any more. It was added by a2f9f6bbb30e (Fix {mc,smt}_capable()), and the last uses were removed by e637d96bf462 (sched: Remove unused mc_capable() and smt_capable()). Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/sparc/include/asm

Re: [PATCH 1/6] PCI,acpiphp: Use list_for_each_entry() for bus traversal

2014-02-14 Thread Bjorn Helgaas
On Thu, Feb 13, 2014 at 09:13:58PM +0800, Yijing Wang wrote: Replace list_for_each() + pci_bus_b() with the simpler list_for_each_entry(). Signed-off-by: Yijing Wang wangyij...@huawei.com I applied all six of these (please include a 0/6 cover letter in the future; that's a nice place to note

Re: [PATCH 02/12][v4] pci: fsl: add structure fsl_pci

2014-01-08 Thread Bjorn Helgaas
On Wed, Jan 08, 2014 at 03:58:08PM -0600, Scott Wood wrote: On Wed, 2014-01-08 at 13:01 +0800, Minghuan Lian wrote: PowerPC uses structure pci_controller to describe PCI controller, but ARM uses structure pci_sys_data. In order to support PowerPC and ARM simultaneously, the patch adds a

Re: [RFC] linux/pci: move pci_platform_pm_ops to linux/pci.h

2013-12-20 Thread Bjorn Helgaas
On Fri, Dec 20, 2013 at 3:03 AM, Dongsheng Wang dongsheng.w...@freescale.com wrote: From: Wang Dongsheng dongsheng.w...@freescale.com make Freescale platform use pci_platform_pm_ops struct. This changelog doesn't say anything about what the patch does. I infer that you want to use

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-12-18 Thread Bjorn Helgaas
On Thu, Sep 26, 2013 at 08:32:53AM -0400, Mark Lord wrote: On 13-09-18 05:48 AM, Alexander Gordeev wrote: The last pattern makes most of sense to me and could be updated with a more clear sequence - a call to (bit modified) pci_msix_table_size() followed by a call to pci_enable_msix(). I

Re: [PATCH 1/9] PCI: Use dev_is_pci() to check whether it is pci device

2013-12-10 Thread Bjorn Helgaas
On Mon, Dec 9, 2013 at 8:59 PM, Benjamin Herrenschmidt b...@au1.ibm.com wrote: On Mon, 2013-12-09 at 17:01 -0700, Bjorn Helgaas wrote: [+cc arch lists] On Thu, Dec 05, 2013 at 07:52:53PM +0800, Yijing Wang wrote: Use dev_is_pci() instead of directly compare pci_bus_type to check whether

Re: [PATCH 1/9] PCI: Use dev_is_pci() to check whether it is pci device

2013-12-09 Thread Bjorn Helgaas
[+cc arch lists] On Thu, Dec 05, 2013 at 07:52:53PM +0800, Yijing Wang wrote: Use dev_is_pci() instead of directly compare pci_bus_type to check whether it is pci device. Signed-off-by: Yijing Wang wangyij...@huawei.com I applied all these to my pci/yijing-dev_is_pci branch for v3.14,

Re: [PATCH 01/12][v3] pci: fsl: derive the common PCI driver to drivers/pci/host

2013-11-25 Thread Bjorn Helgaas
On Wed, Oct 23, 2013 at 06:41:23PM +0800, Minghuan Lian wrote: The Freescale's Layerscape series processors will use ARM cores. The LS1's PCIe controllers is the same as T4240's. So it's better the PCIe controller driver can support PowerPC and ARM simultaneously. This patch is for this

Re: [PATCH 1/9 v2] pci:msi: add weak function for returning msi region info

2013-11-25 Thread Bjorn Helgaas
On Tue, Nov 19, 2013 at 10:47:05AM +0530, Bharat Bhushan wrote: In Aperture type of IOMMU (like FSL PAMU), VFIO-iommu system need to know the MSI region to map its window in h/w. This patch just defines the required weak functions only and will be used by followup patches. Signed-off-by:

Re: [PATCH 1/3] iommu/fsl: Factor out PCI specific code.

2013-10-14 Thread Bjorn Helgaas
On Sun, Oct 13, 2013 at 02:02:32AM +0530, Varun Sethi wrote: Factor out PCI specific code in the PAMU driver. Signed-off-by: Varun Sethi varun.se...@freescale.com --- drivers/iommu/fsl_pamu_domain.c | 81 +++ 1 file changed, 40 insertions(+), 41

Re: PCIE device errors after linux kernel upgrade

2013-10-11 Thread Bjorn Helgaas
On Fri, Aug 16, 2013 at 4:05 PM, Bjorn Helgaas bhelg...@google.com wrote: On Tue, Aug 6, 2013 at 11:41 PM, Leon Ravich lrav...@gmail.com wrote: From comparison of pci printout from the two kernel , beside the EDAC errors I noticed other strange differences: In 3.8.13 I got BAR 7 and BAR 8

Re: [PATCH 1/2][v2] pci: fsl: derive the common PCI driver to drivers/pci/host

2013-10-09 Thread Bjorn Helgaas
On Wed, Oct 9, 2013 at 4:14 AM, Lian Minghuan-b31939 b31...@freescale.com wrote: arch/powerpc/sysdev/fsl_pci.c | 521 +- arch/powerpc/sysdev/fsl_pci.h | 89 .../fsl_pci.c = drivers/pci/host/pci-fsl-common.c | 591

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

2013-10-08 Thread Bjorn Helgaas
On Thu, Oct 3, 2013 at 11:19 PM, Bhushan Bharat-R65777 r65...@freescale.com wrote: I don't know enough about VFIO to understand why these new interfaces are needed. Is this the first VFIO IOMMU driver? I see vfio_iommu_spapr_tce.c and vfio_iommu_type1.c but I don't know if they're

Re: [PATCH 1/2][v2] pci: fsl: derive the common PCI driver to drivers/pci/host

2013-10-08 Thread Bjorn Helgaas
[+cc Ben, Paul, linuxppc-dev] On Mon, Sep 30, 2013 at 04:52:54PM +0800, Minghuan Lian wrote: The Freescale's Layerscape series processors will use ARM cores. The LS1's PCIe controllers is the same as T4240's. So it's better the PCIe controller driver can support PowerPC and ARM

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

2013-10-08 Thread Bjorn Helgaas
- u32 msiir_offset; /* Offset of MSIIR, relative to start of CCSR */ + dma_addr_t msiir; /* MSIIR Address in CCSR */ Are you sure dma_addr_t is right here, versus phys_addr_t? It implies that it's the output of the DMA API, but I don't think the DMA API is used in the MSI driver.

Re: [PATCH v2 2/6] PCI/MSI: Factor out pci_get_msi_cap() interface

2013-09-25 Thread Bjorn Helgaas
On Fri, Sep 20, 2013 at 07:27:36AM -0500, Tejun Heo wrote: On Fri, Sep 20, 2013 at 10:24:59AM +0200, Alexander Gordeev wrote: * Make pci_enable_msix() return 0/-errno My choice would be this one. I agree; it sounds like you've identified several bugs related to the current confusing

Re: [PATCH 1/7] powerpc: Add interface to get msi region information

2013-09-24 Thread Bjorn Helgaas
On Thu, Sep 19, 2013 at 12:59:17PM +0530, Bharat Bhushan wrote: This patch adds interface to get following information - Number of MSI regions (which is number of MSI banks for powerpc). - Get the region address range: Physical page which have the address/addresses used for generating

Re: [PATCH v2 3/6] powerpc/pci: use pci_is_pcie() to simplify code

2013-09-06 Thread Bjorn Helgaas
, Paul, this has no dependencies on anything new to PCI or any other patches in this series, so you can take it through the POWERPC tree. If you don't want to do that, let me know and I can take it. If you want it: Acked-by: Bjorn Helgaas bhelg...@google.com diff --git a/arch/powerpc/kernel/eeh.c

Re: PCIE device errors after linux kernel upgrade

2013-08-16 Thread Bjorn Helgaas
On Tue, Aug 6, 2013 at 11:41 PM, Leon Ravich lrav...@gmail.com wrote: From comparison of pci printout from the two kernel , beside the EDAC errors I noticed other strange differences: In 3.8.13 I got BAR 7 and BAR 8: [ 39.017749] pci :00:00.0: BAR 8: assigned [mem 0xc000-0xdfff]

Re: PCIE device errors after linux kernel upgrade

2013-08-05 Thread Bjorn Helgaas
[+cc linuxppc-dev] On Mon, Aug 5, 2013 at 5:17 AM, Leon Ravich lrav...@gmail.com wrote: Hi all , I am trying to upgrade ours embedded device (freescale powerPC P2020 cpu) linux kernel , till now we used 2.6.32 I am trying to upgrade to 3.8.13 . I took the source from freescale git:

Re: [PATCHv6 02/13] PCI: remove ARCH_SUPPORTS_MSI kconfig option

2013-08-01 Thread Bjorn Helgaas
versions of those functions. For this reason, the ARCH_SUPPORTS_MSI hidden kconfig boolean becomes useless, and this patch gets rid of it. Signed-off-by: Thomas Petazzoni thomas.petazz...@free-electrons.com Acked-by: Bjorn Helgaas bhelg...@google.com Cc: Benjamin Herrenschmidt b

[PATCH 0/2] PCI: Convert hotplug core and pciehp to be builtin only

2013-07-25 Thread Bjorn Helgaas
and CONFIG_HOTPLUG_PCI_PCIE=y combination was accepted by Kconfig and builds a kernel, but pciehp doesn't actually work in that case (pointed out by Yinghai, thanks!) These are intended for v3.11. --- Bjorn Helgaas (2): PCI: hotplug: Convert to be builtin only, not modular PCI

[PATCH 1/2] PCI: hotplug: Convert to be builtin only, not modular

2013-07-25 Thread Bjorn Helgaas
Convert CONFIG_HOTPLUG_PCI from tristate to bool. This only affects the hotplug core; several of the hotplug drivers can still be modules. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/ia64/configs/generic_defconfig|2 +- arch/ia64/configs/gensparse_defconfig |2

[PATCH 2/2] PCI: pciehp: Convert pciehp to be builtin only, not modular

2013-07-25 Thread Bjorn Helgaas
Convert pciehp to be builtin only, with no module option. Signed-off-by: Bjorn Helgaas bhelg...@google.com Acked-by: Rafael J. Wysocki rafael.j.wyso...@intel.com --- drivers/pci/pcie/Kconfig |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/pci/pcie/Kconfig b

Re: [PATCHv5 02/11] PCI: use weak functions for MSI arch-specific functions

2013-07-25 Thread Bjorn Helgaas
Acked-by: Bjorn Helgaas bhelg...@google.com --- arch/mips/include/asm/pci.h| 5 - arch/powerpc/include/asm/pci.h | 5 - arch/s390/include/asm/pci.h| 4 arch/x86/include/asm/pci.h | 28 -- arch/x86/kernel/x86_init.c | 21

Re: [PATCH 04/11] PCI/hotplug: Needn't remove EEH cache again

2013-07-24 Thread Bjorn Helgaas
[+cc linux-pci] On Tue, Jul 23, 2013 at 8:24 PM, Gavin Shan sha...@linux.vnet.ibm.com wrote: Since pcibios_release_device() called by pci_stop_and_remove_bus_device() has removed the EEH cache, we needn't do that again. Cc: Bjorn Helgaas bhelg...@google.com Acked-by: Bjorn Helgaas bhelg

Re: [PATCH] powerpc: platforms: powernv: add '__init' for pnv_pci_init_ioda2_phb()

2013-07-22 Thread Bjorn Helgaas
On Mon, Jul 22, 2013 at 12:52 AM, Chen Gang gang.c...@asianux.com wrote: pnv_pci_init_ioda2_phb() is only used during boot up, so need add '__init' to save the related memory, and avoid related warning: The function .pnv_pci_init_ioda2_phb() references the function __init

Re: [PATCHv4 03/11] pci: remove ARCH_SUPPORTS_MSI kconfig option

2013-07-06 Thread Bjorn Helgaas
On Sat, Jul 6, 2013 at 7:54 AM, Jason Cooper ja...@lakedaemon.net wrote: On Fri, Jul 05, 2013 at 11:45:01PM +0200, Thomas Petazzoni wrote: Dear Bjorn Helgaas, On Fri, 5 Jul 2013 15:37:33 -0600, Bjorn Helgaas wrote: Acked-by: Bjorn Helgaas bhelg...@google.com Again, please update

Re: [PATCH 1/8] PCI: Add pcibios_stop_dev()

2013-07-05 Thread Bjorn Helgaas
and device during the time. The patch introduces hook pcibios_stop_dev() for the purpose. Cc: Bjorn Helgaas bhelg...@google.com Cc: linux-...@vger.kernel.org Signed-off-by: Gavin Shan sha...@linux.vnet.ibm.com --- drivers/pci/probe.c |4 drivers/pci/remove.c |2 ++ include/linux

Re: [PATCH 4/8] PCI/hotplug: Needn't remove EEH cache again

2013-07-05 Thread Bjorn Helgaas
On Thu, Jul 4, 2013 at 8:57 PM, Gavin Shan sha...@linux.vnet.ibm.com wrote: Since pci_stop_and_remove_bus_device() has removed the EEH cache, we needn't do that again. Cc: Bjorn Helgaas bhelg...@google.com Cc: linux-...@vger.kernel.org Signed-off-by: Gavin Shan sha...@linux.vnet.ibm.com

Re: [PATCHv4 02/11] pci: use weak functions for MSI arch-specific functions

2013-07-05 Thread Bjorn Helgaas
Acked-by: Bjorn Helgaas bhelg...@google.com --- arch/mips/include/asm/pci.h| 5 - arch/powerpc/include/asm/pci.h | 5 - arch/s390/include/asm/pci.h| 4 arch/x86/include/asm/pci.h | 28 -- arch/x86/kernel/x86_init.c | 21

Re: [PATCHv4 02/11] pci: use weak functions for MSI arch-specific functions

2013-07-05 Thread Bjorn Helgaas
On Fri, Jul 5, 2013 at 3:32 PM, Bjorn Helgaas bhelg...@google.com wrote: Acked-by: Bjorn Helgaas bhelg...@google.com But please update your subject line to use consistent capitalization, e.g., PCI: Use weak ... ___ Linuxppc-dev mailing list Linuxppc

Re: [PATCHv4 03/11] pci: remove ARCH_SUPPORTS_MSI kconfig option

2013-07-05 Thread Bjorn Helgaas
Cc: Chris Metcalf cmetc...@tilera.com Acked-by: Bjorn Helgaas bhelg...@google.com Again, please update the subject line to PCI: Remove ... I doubt that you'll get explicit acks from all the arches you touched, but I think it's reasonable to put at least patches 2 3 in -next soon after v3.11-rc1

Re: [PATCH 1/8] PCI: Add pcibios_stop_dev()

2013-07-05 Thread Bjorn Helgaas
On Fri, Jul 5, 2013 at 4:36 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Fri, 2013-07-05 at 12:49 -0600, Bjorn Helgaas wrote: We already have pcibios_release_device() (just merged for v3.11). Would that work for you? I haven't seen your whole series, so I can't tell whether

Re: [PATCHv4 02/11] pci: use weak functions for MSI arch-specific functions

2013-07-02 Thread Bjorn Helgaas
On Mon, Jul 1, 2013 at 11:30 PM, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: Dear Michael Ellerman, On Tue, 02 Jul 2013 10:53:16 +1000, Michael Ellerman wrote: On Mon, 2013-07-01 at 15:42 +0200, Thomas Petazzoni wrote: Until now, the MSI architecture-specific functions could

[PATCH] powerpc/powernv: Mark pnv_pci_init_ioda2_phb() as __init

2013-07-02 Thread Bjorn Helgaas
a section mismatch warning. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/powerpc/platforms/powernv/pci-ioda.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c index 9c9d15e

[PATCH 1/2] powerpc/PCI: Use PCI_UNKNOWN for unknown power state

2013-05-20 Thread Bjorn Helgaas
Previously we initialized dev-current_state to 4 (PCI_D3cold), but I think we wanted PCI_UNKNOWN (5) here based on the comment and the fact that the generic version of this code, pci_setup_device(), uses PCI_UNKNOWN. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/powerpc/kernel

[PATCH 2/2] sparc/PCI: Use PCI_UNKNOWN for unknown power state

2013-05-20 Thread Bjorn Helgaas
Previously we initialized dev-current_state to 4 (PCI_D3cold), but I think we wanted PCI_UNKNOWN (5) here based on the comment and the fact that the generic version of this code, pci_setup_device(), uses PCI_UNKNOWN. Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/sparc/kernel/pci.c

Re: [PATCH 1/2] powerpc/PCI: Use PCI_UNKNOWN for unknown power state

2013-05-20 Thread Bjorn Helgaas
On Mon, May 20, 2013 at 5:19 PM, Bjorn Helgaas bhelg...@google.com wrote: Previously we initialized dev-current_state to 4 (PCI_D3cold), but I think we wanted PCI_UNKNOWN (5) here based on the comment and the fact that the generic version of this code, pci_setup_device(), uses PCI_UNKNOWN

Re: [PATCH 1/2] powerpc/PCI: Use PCI_UNKNOWN for unknown power state

2013-05-20 Thread Bjorn Helgaas
On Mon, May 20, 2013 at 5:42 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2013-05-20 at 17:19 -0600, Bjorn Helgaas wrote: Previously we initialized dev-current_state to 4 (PCI_D3cold), but I think we wanted PCI_UNKNOWN (5) here based on the comment and the fact

Re: [PATCH] powerpc/pci: Support per-aperture memory offset

2013-05-06 Thread Bjorn Helgaas
On Sun, May 5, 2013 at 11:50 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: The PCI core supports an offset per aperture nowadays but our arch code still has a single offset per host bridge representing the difference betwen CPU memory addresses and PCI MMIO addresses. This is a

Re: [RFC PATCH 1/3] powerpc: Move struct pci_controller to asm-generic

2013-04-25 Thread Bjorn Helgaas
On Thu, Apr 25, 2013 at 3:49 AM, Andrew Murray andrew.mur...@arm.com wrote: This patch moves struct pci_controller into asm-generic to allow for use by other architectures thus reducing code duplication in the kernel. Signed-off-by: Andrew Murray andrew.mur...@arm.com ---

Re: [PATCH 04/28] proc: Supply PDE attribute setting accessor functions [RFC]

2013-04-18 Thread Bjorn Helgaas
-by: Bjorn Helgaas bhelg...@google.com fs/proc/generic.c | 13 +++ include/linux/proc_fs.h |5 kernel/configs.c |2 +- kernel/profile.c |2 +- net/netfilter/xt_recent.c

Re: [PATCHv3 2/2] radeon: use max_bus_speed to activate gen2 speeds

2013-04-17 Thread Bjorn Helgaas
On Wed, Apr 17, 2013 at 2:04 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Wed, Apr 17, 2013 at 8:38 AM, Lucas Kannebley Tavares luca...@linux.vnet.ibm.com wrote: On 04/12/2013 01:38 PM, Bjorn Helgaas wrote: On Thu, Apr 11, 2013 at 7:13 AM, Lucas Kannebley Tavares luca

Re: [PATCHv3 2/2] radeon: use max_bus_speed to activate gen2 speeds

2013-04-17 Thread Bjorn Helgaas
On Wed, Apr 17, 2013 at 2:17 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Wed, Apr 17, 2013 at 4:11 PM, Bjorn Helgaas bhelg...@google.com wrote: On Wed, Apr 17, 2013 at 2:04 PM, Alex Deucher alexdeuc...@gmail.com wrote: On Wed, Apr 17, 2013 at 8:38 AM, Lucas Kannebley Tavares luca

Re: [PATCH 1/3] iommu: Move swap_pci_ref function to pci.h.

2013-04-15 Thread Bjorn Helgaas
On Mon, Apr 15, 2013 at 8:58 AM, Joerg Roedel j...@8bytes.org wrote: On Mon, Apr 15, 2013 at 12:42:00AM +0530, Varun Sethi wrote: swap_pci_ref function is used by the IOMMU API code for swapping pci device pointers, while determining the iommu group for the device. Currently this function was

Re: [PATCHv3 2/2] radeon: use max_bus_speed to activate gen2 speeds

2013-04-12 Thread Bjorn Helgaas
On Thu, Apr 11, 2013 at 7:13 AM, Lucas Kannebley Tavares luca...@linux.vnet.ibm.com wrote: radeon currently uses a drm function to get the speed capabilities for the bus. However, this is a non-standard method of performing this detection and this patch changes it to use the max_bus_speed

Re: [PATCH 1/2] pci: Set dev-dev.type in alloc_pci_dev

2013-04-08 Thread Bjorn Helgaas
-by: Brian King brk...@linux.vnet.ibm.com Acked-by: Bjorn Helgaas bhelg...@google.com Feel free to put this in the powerpc tree along with the set default VGA device patch. --- drivers/pci/probe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/pci/probe.c

Re: [PATCH 2/3] powerpc: Enable boot_vga sysfs attribute for graphics adapters on Power

2013-04-06 Thread Bjorn Helgaas
On Sat, Apr 6, 2013 at 2:00 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Fri, 2013-04-05 at 14:11 -0600, Bjorn Helgaas wrote: I think sparc has the same issue in its own copy of of_create_pci_dev(). Of course, both of_create_pci_dev() implementations are basically copies

Re: [PATCH 2/3] powerpc: Enable boot_vga sysfs attribute for graphics adapters on Power

2013-04-05 Thread Bjorn Helgaas
On Thu, Apr 4, 2013 at 3:58 PM, Brian King brk...@linux.vnet.ibm.com wrote: Initialize dev-dev.type such that the PCI group attributes for boot_vga and SR-IOV can be displayed if appropriate. This fixes an issue seen on Power preventing X from auto initializing a graphics adapter when using

Re: [PATCH 3/3] powerpc: Set default VGA device

2013-04-05 Thread Bjorn Helgaas
On Thu, Apr 4, 2013 at 3:58 PM, Brian King brk...@linux.vnet.ibm.com wrote: Add a PCI quirk for VGA devices on Power to set the default VGA device. Ensures a default VGA is always set if a graphics adapter is present, even if firmware did not initialize it. If more than one graphics adapter

Re: [linuxppc-release][PATCH] powerpc/pci-hotplug: fix init issue of rescanned pci device

2013-04-01 Thread Bjorn Helgaas
On Mon, Apr 1, 2013 at 4:29 AM, Chen Yuanquan-B41889 b41...@freescale.com wrote: On 12/08/2012 05:15 AM, Bjorn Helgaas wrote: On Thu, Dec 6, 2012 at 4:23 AM, Chen Yuanquan-B41889 b41...@freescale.com wrote: On 12/06/2012 05:30 AM, Bjorn Helgaas wrote: On Wed, Dec 5, 2012 at 2:29 AM, Chen

Re: [PATCHv2 1/3] pci: added pcie_get_speed_cap_mask function

2013-03-27 Thread Bjorn Helgaas
On Wed, Mar 27, 2013 at 9:25 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Tue, 2013-03-26 at 12:39 -0600, Bjorn Helgaas wrote: But we also know pdev is a PCIe device, and I think a PCIe device on a root bus must be a Root Complex Integrated Endpoint (PCIe spec sec 1.3.2.3

Re: [PATCHv2 1/3] pci: added pcie_get_speed_cap_mask function

2013-03-26 Thread Bjorn Helgaas
On Tue, Mar 19, 2013 at 11:24 PM, Lucas Kannebley Tavares luca...@linux.vnet.ibm.com wrote: Added function to gather the speed cap for a device and return a mask to supported speeds. The function is divided into an interface and a weak implementation so that architecture-specific functions can

Re: [PATCH v3 00/22] PCI: Iterate pci host bridge instead of pci root bus

2013-02-02 Thread Bjorn Helgaas
On Sun, Jan 27, 2013 at 12:23 PM, Yinghai Lu ying...@kernel.org wrote: Now we have pci_root_buses list, and there is lots of iteration with list_of_each of it, that is not safe after we add pci root bus hotplug support after booting stage. Add pci_get_next_host_bridge and use bus_find_device

Re: [linuxppc-release][PATCH] powerpc/pci-hotplug: fix init issue of rescanned pci device

2012-12-07 Thread Bjorn Helgaas
On Thu, Dec 6, 2012 at 4:23 AM, Chen Yuanquan-B41889 b41...@freescale.com wrote: On 12/06/2012 05:30 AM, Bjorn Helgaas wrote: On Wed, Dec 5, 2012 at 2:29 AM, Chen Yuanquan-B41889 b41...@freescale.com wrote: On 12/05/2012 04:26 PM, Benjamin Herrenschmidt wrote: On Wed, 2012-12-05 at 16:20

Re: [linuxppc-release][PATCH] powerpc/pci-hotplug: fix init issue of rescanned pci device

2012-12-05 Thread Bjorn Helgaas
On Wed, Dec 5, 2012 at 2:29 AM, Chen Yuanquan-B41889 b41...@freescale.com wrote: On 12/05/2012 04:26 PM, Benjamin Herrenschmidt wrote: On Wed, 2012-12-05 at 16:20 +0800, Chen Yuanquan-B41889 wrote: On 12/05/2012 03:17 PM, Benjamin Herrenschmidt wrote: On Wed, 2012-12-05 at 10:31 +0800,

Re: [PATCH] Centralise CONFIG_ARCH_NO_VIRT_TO_BUS

2012-11-14 Thread Bjorn Helgaas
On Tue, Nov 13, 2012 at 3:32 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: On Mon, Nov 12, 2012 at 10:26 PM, Stephen Rothwell s...@canb.auug.org.au wrote: diff --git a/arch/Kconfig b/arch/Kconfig index 366ec06..9bc00e7 100644 --- a/arch/Kconfig +++ b/arch/Kconfig @@ -271,6 +271,13 @@

Re: [PATCH v3 1/2] powerpc/PCI: move DMA IRQ init to device_add() notification path

2012-10-12 Thread Bjorn Helgaas
On Mon, Jun 18, 2012 at 4:55 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2012-06-18 at 15:06 -0600, Bjorn Helgaas wrote: We're moving the CardBus IRQ config from before pci_bus_add_devices() to after. I see why you did that: we're proposing to do the powerpc DMA IRQ

Re: linux-next: build failure after merge of the pci tree

2012-09-11 Thread Bjorn Helgaas
On Mon, Sep 10, 2012 at 7:29 PM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Bjorn, After merging the pci tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: arch/powerpc/platforms/powernv/pci-ioda.c: In function 'pnv_pci_window_alignment':

Re: [PATCH v2] PCI: use dev-irq instead of dev-pin to enable non MSI/INTx interrupt

2012-09-07 Thread Bjorn Helgaas
On Mon, Aug 6, 2012 at 8:45 PM, Zang Roy-R61911 r61...@freescale.com wrote: -Original Message- From: Linuxppc-dev [mailto:linuxppc-dev-bounces+tie- fei.zang=freescale@lists.ozlabs.org] On Behalf Of Liu Shengzhou-B36685 Sent: Thursday, July 26, 2012 11:45 AM To:

Re: [PATCH 1/2] PCI: leave MEM and IO decoding disabled during 64-bit BAR sizing, too

2012-08-23 Thread Bjorn Helgaas
On Thu, Aug 23, 2012 at 12:28:23AM -0700, Olof Johansson wrote: Hi, On Mon, Jul 9, 2012 at 11:20 AM, Bjorn Helgaas bhelg...@google.com wrote: After 253d2e5498, we disable MEM and IO decoding for most devices while we size 32-bit BARs. However, we restore the original COMMAND register

Re: [PATCH 05/15] pci: resource assignment based on p2p alignment

2012-07-18 Thread Bjorn Helgaas
On Tue, Jul 17, 2012 at 10:25 PM, Ram Pai linux...@us.ibm.com wrote: On Tue, Jul 17, 2012 at 11:14:51AM -0600, Bjorn Helgaas wrote: On Tue, Jul 17, 2012 at 4:38 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Tue, 2012-07-17 at 18:03 +0800, Ram Pai wrote: Lets say we

Re: [PATCH 05/15] pci: resource assignment based on p2p alignment

2012-07-17 Thread Bjorn Helgaas
On Tue, Jul 17, 2012 at 4:38 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Tue, 2012-07-17 at 18:03 +0800, Ram Pai wrote: Lets say we passed that 'type' flag to size the minimum alignment constraints for that b_res. And window_alignment(bus, type) of

Re: [PATCH 5/7] pci: minimal alignment for bars of P2P bridges

2012-07-16 Thread Bjorn Helgaas
On Sun, Jul 15, 2012 at 9:50 PM, Gavin Shan sha...@linux.vnet.ibm.com wrote: On Fri, Jul 13, 2012 at 02:12:50PM -0600, Bjorn Helgaas wrote: On Fri, Jun 29, 2012 at 02:47:48PM +0800, Gavin Shan wrote: On some powerpc platforms, device BARs need to be assigned to separate segments of the address

Re: [PATCH v5 0/7] minimal alignment for p2p bars

2012-07-16 Thread Bjorn Helgaas
On Mon, Jul 16, 2012 at 11:30:23PM +0800, Gavin Shan wrote: v1 - v2: * Shorten the varaible names so that they looks more short. * Changelog adjustment so that they looks more meaningful. v2 - v3: * Rebase to 3.5.RC4 v3 - v4: * Merge Yinghai's patches. v3 -

Re: [PATCH 04/15] pci: weak function returns alignment

2012-07-16 Thread Bjorn Helgaas
On Mon, Jul 16, 2012 at 11:30:27PM +0800, Gavin Shan wrote: The patch implements the weak function to return the default I/O or memory alignment for P2P bridge. Currently, I/O window has 4KiB alignment and memory window is 4MiB aligned by default. On the other hand, those platforms (e.g.

Re: [PATCH 05/15] pci: resource assignment based on p2p alignment

2012-07-16 Thread Bjorn Helgaas
On Mon, Jul 16, 2012 at 11:30:28PM +0800, Gavin Shan wrote: The patch changes function pbus_size_io() and pbus_size_mem() to do resource (I/O, memory and prefetchable memory) reassignment based on the minimal alignments for the p2p bridge, which was retrieved by function

Re: [PATCH 5/7] pci: minimal alignment for bars of P2P bridges

2012-07-13 Thread Bjorn Helgaas
On Fri, Jun 29, 2012 at 02:47:48PM +0800, Gavin Shan wrote: On some powerpc platforms, device BARs need to be assigned to separate segments of the address space in order for the error isolation and HW virtualization mechanisms (EEH) to work properly. Those segments have a minimum size that can

Re: [PATCH V4 1/2] PCI: pcibus address to resource converting take bus directly

2012-06-27 Thread Bjorn Helgaas
On Wed, Jun 27, 2012 at 8:48 AM, Gavin Shan sha...@linux.vnet.ibm.com wrote: For allocating resource under bus path, we do have dev pass along, and we could just use bus instead. Also, we'd like to make function find_pci_host_bridge() global so that some platforms (e.g. PPC) can access the pci

Re: [PATCH V4 2/2] PCI: minimal alignment for bars of P2P bridges

2012-06-27 Thread Bjorn Helgaas
On Wed, Jun 27, 2012 at 8:48 AM, Gavin Shan sha...@linux.vnet.ibm.com wrote: On some powerpc platforms, device BARs need to be assigned to separate segments of the address space in order for the error isolation and HW virtualization mechanisms (EEH) to work properly. Those segments have a

Re: [PATCH] PPC: PCI: Fix pcibios_io_space_offset() so it works for 32-bit ptr/64-bit rsrcs

2012-06-20 Thread Bjorn Helgaas
On Mon, Jun 18, 2012 at 2:39 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Mon, 2012-06-18 at 09:23 -0600, Bjorn Helgaas wrote: Ooh, sorry about that.  Who's going to push this fix?  I don't see it in Linus' tree yet.  If you want me to, please forward me the original patch

Re: [PATCH] PPC: PCI: Fix pcibios_io_space_offset() so it works for 32-bit ptr/64-bit rsrcs

2012-06-18 Thread Bjorn Helgaas
On Tue, Jun 5, 2012 at 11:15 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Tue, 2012-06-05 at 23:50 -0400, Ben Collins wrote: The commit introducing pcibios_io_space_offset() was ignoring 32-bit to 64-bit sign extention, which is the case on ppc32 with 64-bit resource

Re: [PATCH 3/7][TRIVIAL][resend] drivers/pci: cleanup kernel-doc warning

2012-06-18 Thread Bjorn Helgaas
On Fri, Jun 15, 2012 at 7:15 AM, Wanpeng Li liwp.li...@gmail.com wrote: From: Wanpeng Li l...@linux.vnet.ibm.com Warning(drivers/pci/setup-bus.c:277): No description found for parameter 'fail_head' Warning(drivers/pci/setup-bus.c:277): Excess function parameter 'failed_list' description in

Re: [PATCH v3 1/2] powerpc/PCI: move DMA IRQ init to device_add() notification path

2012-06-18 Thread Bjorn Helgaas
I'm trying to make some progress on these patches, but I'm concerned about this bit: diff --git a/drivers/pcmcia/cardbus.c b/drivers/pcmcia/cardbus.c index 24caeaf..a980691 100644 --- a/drivers/pcmcia/cardbus.c +++ b/drivers/pcmcia/cardbus.c @@ -85,7 +84,6 @@ int __ref cb_alloc(struct

Re: [PATCH v2 0/2] Add pcibios_device_change_notifier

2012-06-11 Thread Bjorn Helgaas
On Tue, Jun 5, 2012 at 11:26 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2012-05-23 at 11:33 +0900, Hiroo Matsumoto wrote: This patchset is for PCI hotplug. pcibios_setup_bus_devices which sets DMA and IRQs of PCI device is called only when boot. DMA setting in probe

Re: [PATCH v3 1/2] powerpc/PCI: move DMA IRQ init to device_add() notification path

2012-05-24 Thread Bjorn Helgaas
On Thu, May 24, 2012 at 9:00 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2012-05-23 at 16:37 -0600, Bjorn Helgaas wrote: From: Hiroo Matsumoto matsumoto.hi...@jp.fujitsu.com PowerPC initialized DMA and IRQ information in the pci_scan_child_bus() - pcibios_fixup_bus

Re: [PATCH v2 1/2] powerpc/PCI: Add pcibios_device_change_notifier for powerpc

2012-05-23 Thread Bjorn Helgaas
On Wed, May 23, 2012 at 11:51 AM, Jesse Larrew jlar...@linux.vnet.ibm.com wrote: On 05/22/2012 09:33 PM, Hiroo Matsumoto wrote: +static int pcibios_device_change_notifier(struct notifier_block *nb, +                                       unsigned long action, void *data) +{ +     struct

[PATCH v3 0/2] archdata init in device_add() notifier

2012-05-23 Thread Bjorn Helgaas
Here's what I put in my for-3.6 branch for now. We can still change it, so let me know if you see any problems. I reworked the changelogs, changed the notification function name per Jesse, folded the one-line pcibios_setup_bus_notifier() into the only caller (on microblaze), and changed it from

[PATCH v3 1/2] powerpc/PCI: move DMA IRQ init to device_add() notification path

2012-05-23 Thread Bjorn Helgaas
: MAC: 1, PHY: 4, PBA No: D50861-003 [bhelgaas: changelog, notifier name, registration can be __init] CC: Dominik Brodowski li...@dominikbrodowski.net Signed-off-by: Hiroo MATSUMOTO matsumoto.hi...@jp.fujitsu.com Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/powerpc/include/asm/pci.h

[PATCH v3 2/2] microblaze/PCI: move DMA IRQ init to device_add() notification path

2012-05-23 Thread Bjorn Helgaas
, inline registration] Signed-off-by: Hiroo MATSUMOTO matsumoto.hi...@jp.fujitsu.com Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/microblaze/include/asm/pci.h |1 - arch/microblaze/pci/pci-common.c | 62 - 2 files changed, 34 insertions(+), 29

[PATCH v2 4/7] powerpc/PCI: convert devtree bus addresses to resource

2012-03-16 Thread Bjorn Helgaas
an...@samba.org CC: Benjamin Herrenschmidt b...@kernel.crashing.org CC: linuxppc-dev@lists.ozlabs.org Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/powerpc/kernel/pci_of_scan.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel

[PATCH v2 5/7] powerpc/PCI: allow reallocation on PA Semi

2012-03-16 Thread Bjorn Helgaas
Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/powerpc/platforms/pasemi/pci.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi/pci.c index b27d886..aa86271 100644 --- a/arch/powerpc/platforms

[PATCH v3 10/34] powerpc/PCI: allow reallocation on PA Semi

2012-03-07 Thread Bjorn Helgaas
We believe there's no reason to prevent reallocation on PA Semi, so revert to the default of allow reallocation if necessary. CC: Olof Johansson o...@lixom.net CC: Benjamin Herrenschmidt b...@kernel.crashing.org CC: linuxppc-dev@lists.ozlabs.org Signed-off-by: Bjorn Helgaas bhelg...@google.com

[PATCH v3 11/34] powerpc/PCI: replace pci_probe_only with pci_flags

2012-03-07 Thread Bjorn Helgaas
Herrenschmidt b...@kernel.crashing.org CC: linuxppc-dev@lists.ozlabs.org Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/powerpc/include/asm/ppc-pci.h|2 -- arch/powerpc/kernel/pci-common.c |3 --- arch/powerpc/kernel/pci_64.c |5 - arch

[PATCH v3 27/34] powerpc/PCI: get rid of device resource fixups

2012-03-07 Thread Bjorn Helgaas
() using the offsets supplied with pci_add_resource_offset(). The OF path now does the fixup with new pcibios_bus_to_resource() calls in of_pci_parse_addrs() and of_scan_pci_bridge(). Acked-by: Benjamin Herrenschmidt b...@kernel.crashing.org CC: linuxppc-dev@lists.ozlabs.org Signed-off-by: Bjorn Helgaas

[PATCH v1 2/9] powerpc/PCI: compute I/O space bus-to-resource offset consistently

2012-03-06 Thread Bjorn Helgaas
-off-by: Bjorn Helgaas bhelg...@google.com --- arch/powerpc/include/asm/pci.h |1 + arch/powerpc/kernel/pci-common.c |8 ++-- arch/powerpc/kernel/pci_32.c |6 +++--- arch/powerpc/kernel/pci_64.c |2 +- 4 files changed, 11 insertions(+), 6 deletions(-) diff --git

[PATCH v1 3/9] powerpc/PCI: convert devtree bus addresses to resource

2012-03-06 Thread Bjorn Helgaas
the OF device tree. CC: Benjamin Herrenschmidt b...@kernel.crashing.org CC: linuxppc-dev@lists.ozlabs.org Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/powerpc/kernel/pci_of_scan.c | 12 1 files changed, 8 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel

Re: linux-next: boot failure for next-20120227 and later (pci tree related)

2012-03-05 Thread Bjorn Helgaas
On Sun, Mar 4, 2012 at 8:34 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Sat, 2012-03-03 at 08:52 +1100, Benjamin Herrenschmidt wrote: Or give me a chance to dig :-) I'll have a look next week. This is indeed what bjorn suspected on irc, this patch fixes it: (Bjorn, please

Re: linux-next: boot failure for next-20120227 and later (pci tree related)

2012-03-02 Thread Bjorn Helgaas
system  (several other PowerPC based systems to not fail).  A normal boot only shows .wait_scan_init being called once.  (I have initcall_debug=y debug on the command line). I bisected this down to: commit 6c5705fec63d83eeb165fe61e34adc92ecc2ce75 Author: Bjorn Helgaas bhelg...@google.com Date

Re: [PATCH 08/18] PCI, powerpc: Register busn_res for root buses

2012-02-28 Thread Bjorn Helgaas
On Mon, Feb 27, 2012 at 10:36 PM, Bjorn Helgaas bhelg...@google.com wrote: On Mon, Feb 27, 2012 at 7:09 PM, Yinghai Lu ying...@kernel.org wrote: Signed-off-by: Yinghai Lu ying...@kernel.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc

Re: [PATCH 09/24] PCI, powerpc: Register busn_res for root buses

2012-02-27 Thread Bjorn Helgaas
On Sat, Feb 25, 2012 at 12:47 AM, Yinghai Lu ying...@kernel.org wrote: On Fri, Feb 24, 2012 at 2:24 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Thu, 23 Feb 2012 12:51:30 -0800 Bjorn Helgaas bhelg...@google.com wrote: 2) We already have a way to add resources to a root bus

Re: [PATCH 08/18] PCI, powerpc: Register busn_res for root buses

2012-02-27 Thread Bjorn Helgaas
On Mon, Feb 27, 2012 at 7:09 PM, Yinghai Lu ying...@kernel.org wrote: Signed-off-by: Yinghai Lu ying...@kernel.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@lists.ozlabs.org ---  arch/powerpc/kernel/pci-common.c |    7 ++-  

Re: [PATCH v1 09/11] powerpc/PCI: replace pci_probe_only with pci_flags

2012-02-23 Thread Bjorn Helgaas
On Wed, Feb 22, 2012 at 1:41 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2012-02-22 at 11:19 -0700, Bjorn Helgaas wrote:  int maple_pci_get_legacy_ide_irq(struct pci_dev *pdev, int channel) diff --git a/arch/powerpc/platforms/pasemi/pci.c b/arch/powerpc/platforms/pasemi

[PATCH v2 10/12] powerpc/PCI: replace pci_probe_only with pci_flags

2012-02-23 Thread Bjorn Helgaas
Herrenschmidt b...@kernel.crashing.org CC: linuxppc-dev@lists.ozlabs.org Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch/powerpc/include/asm/ppc-pci.h|2 -- arch/powerpc/kernel/pci-common.c |3 --- arch/powerpc/kernel/pci_64.c |5 - arch/powerpc

Re: [PATCH 09/24] PCI, powerpc: Register busn_res for root buses

2012-02-23 Thread Bjorn Helgaas
On Thu, Feb 23, 2012 at 12:25 PM, Jesse Barnes jbar...@virtuousgeek.org wrote: On Fri, 10 Feb 2012 08:35:58 +1100 Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2012-02-09 at 11:24 -0800, Bjorn Helgaas wrote: My point is that the interface between the arch and the PCI core

[PATCH v1 09/11] powerpc/PCI: replace pci_probe_only with pci_flags

2012-02-22 Thread Bjorn Helgaas
set the ppc64 default (PCI_PROBE_ONLY set) in the 64-bit setup_arch() before calling the platform .setup_arch() method, which may override the default. CC: Benjamin Herrenschmidt b...@kernel.crashing.org CC: linuxppc-dev@lists.ozlabs.org Signed-off-by: Bjorn Helgaas bhelg...@google.com --- arch

Re: [PATCH v1 09/11] powerpc/PCI: replace pci_probe_only with pci_flags

2012-02-22 Thread Bjorn Helgaas
On Wed, Feb 22, 2012 at 1:41 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2012-02-22 at 11:19 -0700, Bjorn Helgaas wrote: We already use pci_flags, so this just sets pci_flags directly and removes the intermediate step of figuring out pci_probe_only, then using it to set

Re: [PATCH 09/24] PCI, powerpc: Register busn_res for root buses

2012-02-09 Thread Bjorn Helgaas
On Wed, Feb 8, 2012 at 2:02 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2012-02-08 at 07:58 -0800, Bjorn Helgaas wrote: The only architecture-specific thing here is discovering the range of bus numbers below a host bridge.  The architecture should not have to mess around

<    3   4   5   6   7   8   9   >