Re: [PATCH 09/24] PCI, powerpc: Register busn_res for root buses

2012-02-08 Thread Bjorn Helgaas
On Sat, Feb 4, 2012 at 10:57 PM, Yinghai Lu ying...@kernel.org wrote: Signed-off-by: Yinghai Lu ying...@kernel.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@lists.ozlabs.org ---  arch/powerpc/kernel/pci-common.c |    7 ++-  

Re: [PATCH 06/13] PCI, powerpc: Register busn_res for root buses

2012-01-30 Thread Bjorn Helgaas
On Fri, Jan 27, 2012 at 6:49 PM, Yinghai Lu ying...@kernel.org wrote: Signed-off-by: Yinghai Lu ying...@kernel.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: linuxppc-dev@lists.ozlabs.org ---  arch/powerpc/kernel/pci-common.c |    7 ++-  

Re: Kernel cannot see PCI device

2011-05-19 Thread Bjorn Helgaas
On Thu, May 19, 2011 at 6:41 AM, Prashant Bhole prashantsmailcen...@gmail.com wrote: On Wed, May 18, 2011 at 7:44 PM, Bjorn Helgaas bhelg...@google.com wrote: On Wed, May 18, 2011 at 4:02 AM, Prashant Bhole prashantsmailcen...@gmail.com wrote: On Mon, May 2, 2011 at 10:21 AM, Prashant Bhole

Re: Kernel cannot see PCI device

2011-05-19 Thread Bjorn Helgaas
On Thu, May 19, 2011 at 5:12 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Thu, 2011-05-19 at 11:58 -0600, Bjorn Helgaas wrote: The scan below PCIX0 (bus 0001:00) doesn't find anything.  You really need a powerpc expert to help here, but in their absence, my guess would

Re: Kernel cannot see PCI device

2011-05-18 Thread Bjorn Helgaas
On Wed, May 18, 2011 at 4:02 AM, Prashant Bhole prashantsmailcen...@gmail.com wrote: On Mon, May 2, 2011 at 10:21 AM, Prashant Bhole prashantsmailcen...@gmail.com wrote: Hi, I have a custom made powerpc 460EX board. On that board u-boot can see a PCI device but Linux kernel cannot see it.

Re: [RFC/PATCH] of: Match PCI devices to OF nodes generically

2011-04-04 Thread Bjorn Helgaas
On Mon, Apr 4, 2011 at 1:37 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: powerpc has two different ways of matching PCI devices to their corresponding OF node (if any) for historical reasons. The ppc64 one does a scan looking for matching bus/dev/fn, while the ppc32 one does a

Re: [PATCH v4 4/5] PCI: augment bus resource table with a list

2010-02-23 Thread Bjorn Helgaas
Here's the update (only added EXPORT_SYMBOL_GPL for pci_resource_n). I'll repost the whole series if that's easier for you. Bjorn commit 72b4d74167af9cec8e68cd6d54eda5d3cb894c57 Author: Bjorn Helgaas bjorn.helg...@hp.com Date: Tue Feb 9 15:33:27 2010 -0700 PCI: augment bus resource table

[PATCH v5 0/5] PCI: try pci=use_crs again

2010-02-23 Thread Bjorn Helgaas
to be6e9f7853e - Add patch to clean up disabled window printk - Add bugzilla reference comment in use_crs DMI quirk --- Bjorn Helgaas (5): PCI: split up pci_read_bridge_bases() PCI: read bridge windows before filling in subtractive decode resources PCI: add

[PATCH v5 3/5] PCI: add pci_bus_for_each_resource(), remove direct bus-resource[] refs

2010-02-23 Thread Bjorn Helgaas
. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- arch/ia64/pci/pci.c |5 ++--- arch/mn10300/unit-asb2305/pci.c |6 ++ arch/powerpc/kernel/pci-common.c | 11 --- arch/powerpc/platforms/fsl_uli1575.c | 12 ++-- drivers/pci/bus.c

[PATCH v5 4/5] PCI: augment bus resource table with a list

2010-02-23 Thread Bjorn Helgaas
) subtractive-decode P2P bridges, and we can incrementally change other architectures to use the list. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- arch/ia64/pci/pci.c | 12 +++- arch/x86/pci/acpi.c | 33 - arch/x86/pci/bus_numa.c |3

[PATCH v5 5/5] x86/PCI: use host bridge _CRS info by default on 2008 and newer machines

2010-02-23 Thread Bjorn Helgaas
://bugs.launchpad.net/ubuntu/+source/linux/+bug/341681 Most of these systems are relatively new, so this patch turns on pci=use_crs only on machines with a BIOS date of 2008 or newer. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- Documentation/kernel-parameters.txt |8 - arch/ia64/include

[PATCH v4 0/5] PCI: try pci=use_crs again

2010-02-17 Thread Bjorn Helgaas
reference comment in use_crs DMI quirk --- Bjorn Helgaas (5): PCI: split up pci_read_bridge_bases() PCI: read bridge windows before filling in subtractive decode resources PCI: add pci_bus_for_each_resource(), remove direct bus-resource[] refs PCI: augment bus resource table

[PATCH v4 1/5] PCI: split up pci_read_bridge_bases()

2010-02-17 Thread Bjorn Helgaas
No functional change; this breaks up pci_read_bridge_bases() into separate pieces for the I/O, memory, and prefetchable memory windows, similar to how Yinghai recently split up pci_setup_bridge() in 68e84ff3bdc. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- drivers/pci/probe.c | 54

[PATCH v4 2/5] PCI: read bridge windows before filling in subtractive decode resources

2010-02-17 Thread Bjorn Helgaas
No functional change; this fills in the bus subtractive decode resources after reading the bridge window information rather than before. Also, print out the subtractive decode resources as we already do for the positive decode windows. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com

[PATCH v4 3/5] PCI: add pci_bus_for_each_resource(), remove direct bus-resource[] refs

2010-02-17 Thread Bjorn Helgaas
. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- arch/ia64/pci/pci.c |5 ++--- arch/mn10300/unit-asb2305/pci.c |6 ++ arch/powerpc/kernel/pci-common.c | 11 --- arch/powerpc/platforms/fsl_uli1575.c | 12 ++-- drivers/pci/bus.c

[PATCH v4 4/5] PCI: augment bus resource table with a list

2010-02-17 Thread Bjorn Helgaas
) subtractive-decode P2P bridges, and we can incrementally change other architectures to use the list. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- arch/ia64/pci/pci.c | 12 +++- arch/x86/pci/acpi.c | 33 - arch/x86/pci/bus_numa.c |3

[PATCH v4 5/5] x86/PCI: use host bridge _CRS info by default on 2008 and newer machines

2010-02-17 Thread Bjorn Helgaas
://bugs.launchpad.net/ubuntu/+source/linux/+bug/341681 Most of these systems are relatively new, so this patch turns on pci=use_crs only on machines with a BIOS date of 2008 or newer. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- Documentation/kernel-parameters.txt |8 - arch/ia64/include

[PATCH v3 1/7] PCI: split up pci_read_bridge_bases()

2010-02-12 Thread Bjorn Helgaas
No functional change; this breaks up pci_read_bridge_bases() into separate pieces for the I/O, memory, and prefetchable memory windows, similar to how Yinghai recently split up pci_setup_bridge() in 68e84ff3bdc. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- drivers/pci/probe.c | 54

[PATCH v3 3/7] PCI: replace bus resource table with a list

2010-02-12 Thread Bjorn Helgaas
of ranges to their secondary buses (i.e., PCI root buses). This patch replaces the fixed-size table with a list. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- arch/alpha/kernel/pci.c |5 +- arch/ia64/pci/pci.c | 20 ++ arch/mn10300/unit-asb2305/pci.c

[PATCH v3 7/7] PCI: reference bridge window resources explicitly

2010-02-12 Thread Bjorn Helgaas
window) bridge-res[PCI_BRIDGE_RESOURCES+3]: CB mem 1 window Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- arch/powerpc/kernel/pci_64.c |4 +-- arch/powerpc/kernel/pci_of_scan.c |9 -- drivers/pci/probe.c |6 ++-- drivers/pci/quirks.c |4

[PATCH v3 2/7] PCI: read bridge windows before filling in subtractive decode resources

2010-02-12 Thread Bjorn Helgaas
No functional change; this fills in the bus subtractive decode resources after reading the bridge window information rather than before. Also, print out the subtractive decode resources as we already do for the positive decode windows. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com

[PATCH v3 6/7] PCI: break out primary/secondary/subordinate for readability

2010-02-12 Thread Bjorn Helgaas
No functional change; just add names for the primary/secondary/subordinate bus numbers read from config space rather than repeatedly masking/shifting. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- drivers/pci/probe.c | 24 ++-- 1 files changed, 14 insertions

[PATCH v3 0/7] PCI: try pci=use_crs again

2010-02-12 Thread Bjorn Helgaas
: - Rebase to be6e9f7853e - Add patch to clean up disabled window printk - Add bugzilla reference comment in use_crs DMI quirk --- Bjorn Helgaas (7): PCI: split up pci_read_bridge_bases() PCI: read bridge windows before filling in subtractive decode resources PCI: replace bus

[PATCH v3 4/7] x86/PCI: use host bridge _CRS info by default on 2008 and newer machines

2010-02-12 Thread Bjorn Helgaas
://bugs.launchpad.net/ubuntu/+source/linux/+bug/341681 Most of these systems are relatively new, so this patch turns on pci=use_crs only on machines with a BIOS date of 2008 or newer. Signed-off-by: Bjorn Helgaas bjorn.helg...@hp.com --- Documentation/kernel-parameters.txt |8 - arch/ia64/include

Re: [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources()

2008-03-06 Thread Bjorn Helgaas
On Thursday 06 March 2008 08:06:40 am Russell King - ARM Linux wrote: On Wed, Feb 27, 2008 at 05:04:41PM -0700, Bjorn Helgaas wrote: Move bridge enable from pcibios_enable_resources() to platform_pci_enable_device() so the former matches other architectures and can be shared. Signed

[patch 00/16] PCI: consolidate several pcibios_enable_resources() implementations, v3

2008-03-04 Thread Bjorn Helgaas
This series replaces most of the arch-specific pcibios_enable_resources() implementations with a single generic pci_enable_resources(). I think this is ready for -mm, but of course, I'm still interested in any other comments. Changes between v2 and v3: - Renamed the generic version to

[patch 01/16] PCI: add generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
-to-date. The only functional difference from the x86 version is that this uses !r-parent to check for resource collisions instead of !r-start r-end. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/drivers/pci/setup-res.c

[patch 03/16] arm: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
IORESOURCE_ROM_ENABLE is set - checks for resource collisions with !r-parent Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/arm/kernel/bios32.c === --- work8.orig/arch/arm/kernel/bios32.c 2008-03-04 09:59:24.0

[patch 04/16] cris: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
IORESOURCE_ROM_ENABLE is set - checks for resource collisions with !r-parent Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/cris/arch-v32/drivers/pci/bios.c === --- work8.orig/arch/cris/arch-v32/drivers/pci/bios.c

[patch 06/16] ia64: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
Use the generic pci_enable_resources() instead of the arch-specific code. Unlike this arch-specific code, the generic version: - does not check for a NULL dev pointer - skips resources that have neither IORESOURCE_IO nor IORESOURCE_MEM set Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED

[patch 08/16] mn10300: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
IORESOURCE_ROM_ENABLE is set - checks for resource collisions with !r-parent Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/mn10300/unit-asb2305/pci-asb2305.c === --- work8.orig/arch/mn10300/unit-asb2305/pci-asb2305.c

[patch 07/16] mips: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
Use the generic pci_enable_resources() instead of the arch-specific code. Unlike this arch-specific code, the generic version: - checks for resource collisions with !r-parent Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/mips/pci/pci.c

[patch 11/16] ppc: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
IORESOURCE_ROM_ENABLE is set - checks for resource collisions with !r-parent, not IORESOURCE_UNSET Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/ppc/kernel/pci.c === --- work8.orig/arch/ppc/kernel/pci.c2008-03-04

[patch 12/16] sh: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
IORESOURCE_ROM_ENABLE is set - checks for resource collisions with !r-parent Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/sh/drivers/pci/pci.c === --- work8.orig/arch/sh/drivers/pci/pci.c2008-03-04 10:10

[patch 15/16] x86: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
Use the generic pci_enable_resources() instead of the arch-specific code. Unlike this arch-specific code, the generic version: - checks for resource collisions with !r-parent Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/x86/pci/common.c

[patch 09/16] parisc: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
ROM resources unless IORESOURCE_ROM_ENABLE is set - checks for resource collisions with !r-parent Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/parisc/kernel/pci.c === --- work8.orig/arch/parisc/kernel/pci.c 2008

[patch 13/16] sparc64: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
collisions with !r-parent Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/sparc64/kernel/pci.c === --- work8.orig/arch/sparc64/kernel/pci.c2008-03-04 10:11:25.0 -0700 +++ work8/arch/sparc64/kernel/pci.c

[patch 05/16] frv: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
IORESOURCE_ROM_ENABLE is set - checks for resource collisions with !r-parent Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/frv/mb93090-mb00/pci-frv.c === --- work8.orig/arch/frv/mb93090-mb00/pci-frv.c 2008-03-04 10

[patch 14/16] v850: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
IORESOURCE_ROM_ENABLE is set - checks for resource collisions with !r-parent Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/v850/kernel/rte_mb_a_pci.c === --- work8.orig/arch/v850/kernel/rte_mb_a_pci.c 2008-03-04 10

[patch 10/16] powerpc: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
Use the generic pci_enable_resources() instead of the arch-specific code. The generic version is functionally equivalent, but uses dev_printk. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/powerpc/kernel/pci-common.c

[patch 16/16] xtensa: use generic pci_enable_resources()

2008-03-04 Thread Bjorn Helgaas
IORESOURCE_ROM_ENABLE is set - checks for resource collisions with !r-parent Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work8/arch/xtensa/kernel/pci.c === --- work8.orig/arch/xtensa/kernel/pci.c 2008-03-04 10:17:29.0

Re: [patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations

2008-03-03 Thread Bjorn Helgaas
On Monday 03 March 2008 11:45:06 am Jesse Barnes wrote: On Wednesday, February 27, 2008 4:04 pm Bjorn Helgaas wrote: Not-Yet-Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] So you'd like to see the MIPS stuff cleaned up a bit more first before actual sign-off? Or just more testing? I

[patch 2/6] ppc: make pcibios_enable_device() use pcibios_enable_resources()

2008-02-27 Thread Bjorn Helgaas
, so I think it's more likely a historical accident. This patch removes the duplication, making pcibios_enable_device() simply call pcibios_enable_resources() as x86 does. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] Index: work6/arch/ppc

[patch 4/6] ARM: move bridge enable out of pcibios_enable_resources()

2008-02-27 Thread Bjorn Helgaas
Move bridge enable from pcibios_enable_resources() to platform_pci_enable_device() so the former matches other architectures and can be shared. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work6/arch/arm/kernel/bios32.c

[patch 3/6] xtensa: make pcibios_enable_device() use pcibios_enable_resources()

2008-02-27 Thread Bjorn Helgaas
() on xtensa, so I think it's more likely a historical accident copied from ppc. This patch removes the duplication, making pcibios_enable_device() simply call pcibios_enable_resources() as x86 does. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work6/arch/xtensa/kernel/pci.c

[patch 1/6] PCI: split pcibios_enable_resources() out of pcibios_enable_device()

2008-02-27 Thread Bjorn Helgaas
() implementations to make them more similar to the x86 implementation. There should be no functional change from this patch. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Acked-by: Benjamin Herrenschmidt [EMAIL PROTECTED] --- arch/alpha/kernel/pci.c |8 +++- arch/arm/kernel/bios32.c

[patch 5/6] PARISC: move PERR SERR enables out of pcibios_enable_resources()

2008-02-27 Thread Bjorn Helgaas
Move PERR and SERR enables from pcibios_enable_resources() to platform_pci_enable_device() so the former matches other architectures and can be shared. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work6/arch/parisc/kernel/pci.c

[patch 6/6] PCI: consolidate several pcibios_enable_resources() implementations

2008-02-27 Thread Bjorn Helgaas
the generic version weak so pmc-sierra can override it. Not-Yet-Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] --- arch/alpha/kernel/pci.c | 27 arch/arm/kernel/bios32.c| 37 arch/cris/arch-v32/drivers/pci/bios.c

[patch 0/6] RFC: PCI: consolidate pcibios_enable_resources() implementations, v2

2008-02-27 Thread Bjorn Helgaas
There are many implementations of pcibios_enable_resources() that differ in minor ways that look more like bugs than architectural differences. This patch series consolidates most of them to use the x86 version. Changes between v1 and v2: - Moved ARM bridge enable to new

Re: [patch 4/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-19 Thread Bjorn Helgaas
On Monday 18 February 2008 11:31:07 pm Benjamin Herrenschmidt wrote: On Mon, 2008-02-18 at 21:39 -0700, Bjorn Helgaas wrote: powerpc: has a different collision check at (5) I've always found the collision check dodgy. I tend to want to keep the way powerpc does it here

Re: [patch 0/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-19 Thread Bjorn Helgaas
On Tuesday 19 February 2008 03:08:32 am Benjamin Herrenschmidt wrote: On Tue, 2008-02-19 at 08:09 +, Russell King wrote: On Mon, Feb 18, 2008 at 09:39:52PM -0700, Bjorn Helgaas wrote: ARM and PA-RISC, in particular, have interesting differences: - ARM always enables bridge

[patch 0/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-18 Thread Bjorn Helgaas
There are many implementations of pcibios_enable_resources() that differ in minor ways that look more like bugs than architectural differences. This patch series consolidates most of them to use the x86 version. This series is for discussion only at this point. I'm interested in feedback about

[patch 1/4] PCI: split pcibios_enable_resources() out of pcibios_enable_device()

2008-02-18 Thread Bjorn Helgaas
() implementations to make them more similar to the x86 implementation. There should be no functional change from this patch. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] --- arch/alpha/kernel/pci.c |8 +++- arch/arm/kernel/bios32.c |9 +++-- arch/parisc/kernel/pci.c

[patch 3/4] xtensa: make pcibios_enable_device() use pcibios_enable_resources()

2008-02-18 Thread Bjorn Helgaas
() on xtensa, so I think it's more likely a historical accident copied from ppc. This patch removes the duplication, making pcibios_enable_device() simply call pcibios_enable_resources() as x86 does. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work6/arch/xtensa/kernel/pci.c

[patch 4/4] RFC: PCI: consolidate several pcibios_enable_resources() implementations

2008-02-18 Thread Bjorn Helgaas
-by: Bjorn Helgaas [EMAIL PROTECTED] --- arch/alpha/kernel/pci.c | 27 - arch/arm/kernel/bios32.c| 43 - arch/cris/arch-v32/drivers/pci/bios.c | 32 arch/frv/mb93090-mb00/pci-frv.c | 32

[patch 2/4] ppc: make pcibios_enable_device() use pcibios_enable_resources()

2008-02-18 Thread Bjorn Helgaas
, so I think it's more likely a historical accident. This patch removes the duplication, making pcibios_enable_device() simply call pcibios_enable_resources() as x86 does. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index: work6/arch/ppc/kernel/pci.c

<    4   5   6   7   8   9