Re: next: gcc-8-ppc6xx_defconfig: ERROR: modpost: "__divdi3" [sound/pci/emu10k1/snd-emu10k1.ko] undefined!

2023-05-17 Thread Christophe Leroy
Le 17/05/2023 à 16:02, Naresh Kamboju a écrit : > Linux next powerpc gcc-8 build failed on Linux next 20230516 and 20230517. > - build/gcc-8-ppc6xx_defconfig > > Reported-by: Linux Kernel Functional Testing > > Build log: > > make --silent --keep-going --jobs=8 >

Re: [PATCH v2 6/6] powerpc/64: Rename entry_64.S to prom_entry_64.S

2023-05-15 Thread Christophe Leroy
Le 15/05/2023 à 15:17, Nicholas Piggin a écrit : > On Mon May 15, 2023 at 2:45 PM AEST, Nicholas Piggin wrote: >> This file contains only the enter_prom implementation now. >> Trim includes and update header comment while we're here. >> >> Signed-off-by: Nicholas Piggin >> --- >>

[PATCH 1/3][For 4.19/4.14] spi: spi-fsl-spi: automatically adapt bits-per-word in cpu mode

2023-05-15 Thread Christophe Leroy
y 4 and large enough that the reduced number of interrupts easily compensates for the one or two extra fsl_spi_setup_transfer() calls this causes. Signed-off-by: Rasmus Villemoes Signed-off-by: Mark Brown Signed-off-by: Christophe Leroy --- drivers/spi/spi-fsl-spi.c | 16 1 file chan

[PATCH 1/2][For 5.15/5.10/5.4] spi: fsl-spi: Re-organise transfer bits_per_word adaptation

2023-05-15 Thread Christophe Leroy
in fsl_spi_prepare_message() while for CPM mode that's done in fsl_spi_setup_transfer(). Reunify all of it in fsl_spi_prepare_message(), and catch impossible cases early through master's bits_per_word_mask instead of returning EINVAL later. Signed-off-by: Christophe Leroy Link: https

[PATCH 2/3][For 4.19/4.14] spi: fsl-spi: Re-organise transfer bits_per_word adaptation

2023-05-15 Thread Christophe Leroy
in fsl_spi_prepare_message() while for CPM mode that's done in fsl_spi_setup_transfer(). Reunify all of it in fsl_spi_prepare_message(), and catch impossible cases early through master's bits_per_word_mask instead of returning EINVAL later. Signed-off-by: Christophe Leroy Link: https

[PATCH 2/2][For 5.15/5.10/5.4] spi: fsl-cpm: Use 16 bit mode for large transfers with even size

2023-05-15 Thread Christophe Leroy
-by: Christophe Leroy Link: https://lore.kernel.org/r/f2e981f20f92dd28983c3949702a09248c23845c.1680371809.git.christophe.le...@csgroup.eu Signed-off-by: Mark Brown --- drivers/spi/spi-fsl-cpm.c | 23 +++ drivers/spi/spi-fsl-spi.c | 3 +++ 2 files changed, 26 insertions(+) diff

[PATCH 3/3][For 4.19/4.14] spi: fsl-cpm: Use 16 bit mode for large transfers with even size

2023-05-15 Thread Christophe Leroy
-by: Christophe Leroy Link: https://lore.kernel.org/r/f2e981f20f92dd28983c3949702a09248c23845c.1680371809.git.christophe.le...@csgroup.eu Signed-off-by: Mark Brown --- drivers/spi/spi-fsl-cpm.c | 23 +++ drivers/spi/spi-fsl-spi.c | 3 +++ 2 files changed, 26 insertions(+) diff

Re: [PATCH 1/3] kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures

2023-05-12 Thread Christophe Leroy
Le 12/05/2023 à 18:09, Marco Elver a écrit : > On Fri, 12 May 2023 at 17:31, Christophe Leroy > wrote: >> >> Activating KCSAN on a 32 bits architecture leads to the following >> link-time failure: >> >> LD .tmp_vmlinux.kallsyms1 >>

[PATCH 2/3] powerpc/{32,book3e}: kcsan: Extend KCSAN Support

2023-05-12 Thread Christophe Leroy
information. Signed-off-by: Rohan McLure Signed-off-by: Christophe Leroy --- arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 539d1f03ff42..2f6af3cb75d6 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig

[PATCH 0/3] Extend KCSAN to all powerpc

2023-05-12 Thread Christophe Leroy
. Christophe Leroy (2): kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures xtensa: Remove 64 bits atomic builtins stubs Rohan McLure (1): powerpc/{32,book3e}: kcsan: Extend KCSAN Support arch/powerpc/Kconfig | 2 +- arch/xtensa/lib/Makefile | 2 -- arch

[PATCH 3/3] xtensa: Remove 64 bits atomic builtins stubs

2023-05-12 Thread Christophe Leroy
The stubs were provided by commit 725aea873261 ("xtensa: enable KCSAN") to make linker happy allthought they are not meant to be used at all. KCSAN core has been fixed to not require them anymore on 32 bits architectures. Then they can be removed. Signed-off-by: Christophe Leroy

[PATCH 1/3] kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures

2023-05-12 Thread Christophe Leroy
64 bits atomic builtins. Only include DEFINE_TSAN_ATOMIC_OPS(64) on 64 bits architectures. Fixes: 0f8ad5f2e934 ("kcsan: Add support for atomic builtins") Suggested-by: Marco Elver Signed-off-by: Christophe Leroy --- kernel/kcsan/core.c | 2 ++ 1 file changed, 2 insertions(+)

Re: Fwd: Linux 6.3.1 + AMD RX 570 on ppc64le 4K: Kernel attempted to read user page (1128) - exploit attempt? (uid: 0)

2023-05-12 Thread Christophe Leroy
Le 12/05/2023 à 17:16, Christophe Leroy a écrit : > > > Le 11/05/2023 à 19:25, Niccolò Belli a écrit : >> [Vous ne recevez pas souvent de courriers de >> darkba...@linuxsystems.it. D?couvrez pourquoi ceci est important ? >> https://aka.ms/LearnAboutSenderIdentific

Re: Fwd: Linux 6.3.1 + AMD RX 570 on ppc64le 4K: Kernel attempted to read user page (1128) - exploit attempt? (uid: 0)

2023-05-12 Thread Christophe Leroy
Le 11/05/2023 à 19:25, Niccolò Belli a écrit : > [Vous ne recevez pas souvent de courriers de darkba...@linuxsystems.it. > D?couvrez pourquoi ceci est important ? > https://aka.ms/LearnAboutSenderIdentification ] > > Il 2023-05-12 10:32 Bagas Sanjaya ha scritto: >> #regzbot introduced:

Re: [PATCH 0/4] powerpc/64: ELFv2 conversion

2023-05-05 Thread Christophe Leroy
Le 05/05/2023 à 09:18, Nicholas Piggin a écrit : > This series has the steps to remove ELFv1 from the kernel build. > Patch 1 is a build fix, 2 defaults everything to ELFv2, 3 is > really a separate issue that concerns userspace. 4 removes v1 > support. I see CONFIG_MPROFILE_KERNEL is

Re: [RFC PATCH 4/4] powerpc/64: Remove support for kernel's built with ELFv1 ABI

2023-05-05 Thread Christophe Leroy
Le 05/05/2023 à 09:18, Nicholas Piggin a écrit : > User code must still support ELFv1, e.g., see is_elf2_task(). > > This one should wait a while until ELFv2 fallout settles, so > just posting it out of interest. Can't ELFv1 user code run on an ELFv2 kernel ? Christophe > > Thanks, > Nick >

Re: [PASEMI NEMO] Boot issue with the PowerPC updates 6.4-1

2023-05-03 Thread Christophe Leroy
+Rob as he's the commit's Author. Le 03/05/2023 à 17:46, Christian Zigotzky a écrit : > On 02 May 2023 at 11:28 am, Michael Ellerman wrote: >> Christian Zigotzky writes: >>> Hello, >>> >>> Our PASEMI Nemo board [1] doesn't boot with the PowerPC updates 6.4-1 >>> [2]. >>> >>> The kernel hangs

Re: [PASEMI NEMO] Boot issue with the PowerPC updates 6.4-1

2023-05-02 Thread Christophe Leroy
Hello, Le 02/05/2023 à 04:22, Christian Zigotzky a écrit : > Hello, > > Our PASEMI Nemo board [1] doesn't boot with the PowerPC updates 6.4-1 [2]. > > The kernel hangs right after the booting Linux via __start() @ > 0x ... > > I was able to revert the PowerPC updates 6.4-1 [2]

Re: [PATCH] powerpc: remove unneeded if-checks

2023-04-29 Thread Christophe Leroy
: 67207b9664a8 ("[PATCH] spufs: The SPU file system, base") Reviewed-by: Christophe Leroy > --- > arch/powerpc/platforms/cell/spu_base.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/arch/powerpc/platforms/cell/spu_base.c > b/arch/powerpc/

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-28 Thread Christophe Leroy
Le 26/04/2023 à 14:29, Michael Ellerman a écrit : > Joel Fernandes writes: >> On Tue, Apr 25, 2023 at 6:58 AM Zhouyi Zhou wrote: > ... >> >> Out of curiosity for PPC folks, why cannot 64-bit PPC use per-task >> canary? Michael, is this an optimization? Adding Christophe as well >> since it

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-25 Thread Christophe Leroy
I would not declare victory yet. My > feeling is something changes in timing, or compiler codegen which > hides the issue. So the issue is still there but it is just a matter > of time before someone else reports it. > > Out of curiosity for PPC folks, why cannot 64

Re: BUG : PowerPC RCU: torture test failed with __stack_chk_fail

2023-04-25 Thread Christophe Leroy
Le 25/04/2023 à 13:53, Peter Zijlstra a écrit : > On Tue, Apr 25, 2023 at 06:59:29AM -0400, Joel Fernandes wrote: >>> I'm a little confused; the way I understand the whole stack protector >>> thing to work is that we push a canary on the stack at call and on >>> return check it is still valid.

Re: [PATCH] powerpc/bpf: populate extable entries only during the last pass

2023-04-07 Thread Christophe Leroy
Le 06/04/2023 à 09:35, Hari Bathini a écrit : > Since commit 85e031154c7c ("powerpc/bpf: Perform complete extra passes > to update addresses"), two additional passes are performed to avoid > space and CPU time wastage on powerpc. But these extra passes led to > WARN_ON_ONCE() hits in

Re: [PATCH] powerpc: don't try to copy ppc for task with NULL pt_regs

2023-03-30 Thread Christophe Leroy
Le 28/03/2023 à 13:47, Michael Ellerman a écrit : > "Nicholas Piggin" writes: >> On Mon Mar 27, 2023 at 8:26 PM AEST, Christophe Leroy wrote: > ... >>> >>> Now that thread.regs doesn't change anymore at each interrupt, it would >>> probably be w

Re: [PATCH 2/2] powerpc/64: Rename entry_64.S to prom_entry.S

2023-03-28 Thread Christophe Leroy
Le 28/03/2023 à 08:51, Nicholas Piggin a écrit : > On Tue Mar 28, 2023 at 3:48 AM AEST, Christophe Leroy wrote: >> >> >> Le 25/03/2023 à 14:06, Nicholas Piggin a écrit : >>> This file contains only the enter_prom implementation now. >>> Trim includes and

Re: [PATCH 2/2] powerpc/64: Rename entry_64.S to prom_entry.S

2023-03-27 Thread Christophe Leroy
Le 25/03/2023 à 14:06, Nicholas Piggin a écrit : > This file contains only the enter_prom implementation now. > Trim includes and update header comment while we're here. > > Signed-off-by: Nicholas Piggin > --- > arch/powerpc/kernel/Makefile | 8 +++-- >

Re: [PATCH 1/2] powerpc: merge 32-bit and 64-bit _switch implementation

2023-03-27 Thread Christophe Leroy
Le 25/03/2023 à 14:06, Nicholas Piggin a écrit : > The _switch stack frame setup are substantially the same, so are the > comments. The difference in how the stack and current are switched, > and other hardware and software housekeeping is done is moved into > macros. > > Signed-off-by:

Re: [PATCH 06/21] powerpc: dma-mapping: minimize for_cpu flushing

2023-03-27 Thread Christophe Leroy
Le 27/03/2023 à 14:13, Arnd Bergmann a écrit : > From: Arnd Bergmann > > The powerpc dma_sync_*_for_cpu() variants do more flushes than on other > architectures. Reduce it to what everyone else does: > > - No flush is needed after data has been sent to a device > > - When data has been

Re: [PATCH] powerpc: don't try to copy ppc for task with NULL pt_regs

2023-03-27 Thread Christophe Leroy
Le 27/03/2023 à 08:36, Nicholas Piggin a écrit : > On Mon Mar 27, 2023 at 8:15 AM AEST, Jens Axboe wrote: >> Powerpc sets up PF_KTHREAD and PF_IO_WORKER with a NULL pt_regs, which >> from my (arguably very short) checking is not commonly done for other >> archs. This is fine, except when

Re: Memory coherency issue with IO thread offloading?

2023-03-24 Thread Christophe Leroy
Hi, Le 23/03/2023 à 19:54, Jens Axboe a écrit : > Hi, > > I got a report sent to me from mariadb, in where 5.10.158 works fine and > 5.10.162 is broken. And in fact, current 6.3-rc also fails the test > case. Beware that this email is long, as I'm trying to include > everything that may be

Re: [PATCH v2] soc: fsl: qe: remove unused qe_ic_from_irq function

2023-03-20 Thread Christophe Leroy
^ > The use of this function was removed with > commit d7c2878cfcfa ("soc: fsl: qe: remove unused qe_ic_set_* functions") > > This function is not used, so remove it. > > Signed-off-by: Tom Rix Reviewed-by: Christophe Leroy > --- > v2: Add to commit log when the use was

Re: [PATCH] soc: fsl: qe: remove unused qe_ic_from_irq function

2023-03-20 Thread Christophe Leroy
Le 19/03/2023 à 16:37, Tom Rix a écrit : > clang with W=1 reports > drivers/soc/fsl/qe/qe_ic.c:235:29: error: unused function >'qe_ic_from_irq' [-Werror,-Wunused-function] > static inline struct qe_ic *qe_ic_from_irq(unsigned int virq) > ^ > This function is not

Re: [PATCH v4 20/36] powerpc: Implement the new page table range API

2023-03-18 Thread Christophe Leroy
Le 17/03/2023 à 04:47, Matthew Wilcox a écrit : > On Wed, Mar 15, 2023 at 10:18:22AM +0000, Christophe Leroy wrote: >> I investigated a bit further and can confirm now that the above won't >> always work, see comment >> https://elixir.bootlin.com/linux/v6.3-rc2/source/arc

Re: [PATCH v4 20/36] powerpc: Implement the new page table range API

2023-03-15 Thread Christophe Leroy
Le 15/03/2023 à 10:43, Christophe Leroy a écrit : > > > Le 15/03/2023 à 06:14, Matthew Wilcox (Oracle) a écrit : >> Add set_ptes(), update_mmu_cache_range() and flush_dcache_folio(). >> Change the PG_arch_1 (aka PG_dcache_dirty) flag from being per-page to >>

Re: [PATCH v4 20/36] powerpc: Implement the new page table range API

2023-03-15 Thread Christophe Leroy
an > Cc: Nicholas Piggin > Cc: Christophe Leroy > Cc: linuxppc-dev@lists.ozlabs.org > --- > arch/powerpc/include/asm/book3s/pgtable.h | 10 + > arch/powerpc/include/asm/cacheflush.h | 14 +-- > arch/powerpc/include/asm/kvm_ppc.h| 10 ++--- > arch

Re: [PATCH] crypto: p10-aes-gcm - remove duplicate include header

2023-03-14 Thread Christophe Leroy
Hi, Le 14/03/2023 à 09:31, ye.xingc...@zte.com.cn a écrit : > From: Ye Xingchen > > crypto/algapi.h is included more than once. > > Signed-off-by: Ye Xingchen You already sent this patch, see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/202301171601080312...@zte.com.cn/ Any

Re: Question about the dependency on the config SOC_FSL in CPM_QMC

2023-03-14 Thread Christophe Leroy
Hi Lukas Le 14/03/2023 à 08:21, Lukas Bulwahn a écrit : > Dear Herve, > > In your patch below, you added the config CPM_QMC which depends on the > non-existing config SOC_FSL: > > https://lore.kernel.org/r/20230217145645.1768659-7-herve.cod...@bootlin.com > > Up to my knowledge, the config

Re: [PATCH v2 4/4] powerpc/bpf: use bpf_jit_binary_pack_[alloc|finalize|free]

2023-03-11 Thread Christophe Leroy
Le 09/03/2023 à 19:02, Hari Bathini a écrit : > Use bpf_jit_binary_pack_alloc in powerpc jit. The jit engine first > writes the program to the rw buffer. When the jit is done, the program > is copied to the final location with bpf_jit_binary_pack_finalize. > With multiple jit_subprogs,

Re: [PATCH v2 1/4] powerpc/code-patching: introduce patch_instructions()

2023-03-11 Thread Christophe Leroy
Le 09/03/2023 à 19:02, Hari Bathini a écrit : > patch_instruction() entails setting up pte, patching the instruction, > clearing the pte and flushing the tlb. If multiple instructions need > to be patched, every instruction would have to go through the above > drill unnecessarily. Instead,

Re: [PATCH v2 1/4] powerpc/code-patching: introduce patch_instructions()

2023-03-10 Thread Christophe Leroy
Le 10/03/2023 à 19:26, Christophe Leroy a écrit : > > > Le 09/03/2023 à 19:02, Hari Bathini a écrit : >> patch_instruction() entails setting up pte, patching the instruction, >> clearing the pte and flushing the tlb. If multiple instructions need >> to be patched, e

Re: [PATCH v2 1/4] powerpc/code-patching: introduce patch_instructions()

2023-03-10 Thread Christophe Leroy
Le 09/03/2023 à 19:02, Hari Bathini a écrit : > patch_instruction() entails setting up pte, patching the instruction, > clearing the pte and flushing the tlb. If multiple instructions need > to be patched, every instruction would have to go through the above > drill unnecessarily. Instead,

Re: [RFC PATCH 0/4] Remove some e300/MPC83xx evaluation platforms

2023-03-03 Thread Christophe Leroy
Le 03/03/2023 à 20:41, Crystal Wood a écrit : > On Fri, 2023-03-03 at 10:14 +0100, Arnd Bergmann wrote: >> On Fri, Mar 3, 2023, at 02:04, Paul Gortmaker wrote: >>> 01/03/2023 (Wed 14:23) Christophe Leroy wrote: >>>> Le 28/02/2023 ?? 18:51, Arnd Bergmann a ??crit

Re: [RFC PATCH 0/4] Remove some e300/MPC83xx evaluation platforms

2023-03-01 Thread Christophe Leroy
Le 28/02/2023 à 18:51, Arnd Bergmann a écrit : > On Tue, Feb 28, 2023, at 11:03, Joakim Tjernlund wrote: >> On Mon, 2023-02-27 at 14:48 -0600, Li Yang wrote: >> >> Here, we remove the MPC8548E-MDS[1], the MPC8360E-MDS[2], the >> MPC837xE-MDS[3], and the MPC832x-MDS[4] board support

Re: [PATCH v7 13/41] mm: Make pte_mkwrite() take a VMA

2023-03-01 Thread Christophe Leroy
Le 27/02/2023 à 23:29, Rick Edgecombe a écrit : > The x86 Control-flow Enforcement Technology (CET) feature includes a new > type of memory called shadow stack. This shadow stack memory has some > unusual properties, which requires some core mm changes to function > properly. > > One of these

Re: Patch for audio on iBook G4 (powerbook6,5)

2023-02-28 Thread Christophe Leroy
Le 28/02/2023 à 22:17, m...@thaison-nguyen.de a écrit : > Hi > > I have added a bug report and a patch regarding audio for iBook G4 > (powerbook6,5) on kernel.org bugzilla, but nobody has picked it up. > https://bugzilla.kernel.org/show_bug.cgi?id=216504 > > Now I am trying to submit the

Re: [PATCH V2] mm: Merge pte_mkhuge() call into arch_make_huge_pte()

2023-02-28 Thread Christophe Leroy
d S. Miller" > Cc: Mike Kravetz > Cc: Andrew Morton > Cc: linux-arm-ker...@lists.infradead.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: sparcli...@vger.kernel.org > Cc: linux...@kvack.org > Cc: linux-ker...@vger.kernel.org > Reviewed-by: Christophe

Re: [PATCH v2 18/30] powerpc: Implement the new page table range API

2023-02-27 Thread Christophe Leroy
Le 27/02/2023 à 21:20, Matthew Wilcox a écrit : > On Mon, Feb 27, 2023 at 07:45:08PM +0000, Christophe Leroy wrote: >> Hi, >> >> Le 27/02/2023 à 18:57, Matthew Wilcox (Oracle) a écrit : >>> Add set_ptes(), update_mmu_cache_range() and flush_dcache_folio().

Re: [PATCH v2 18/30] powerpc: Implement the new page table range API

2023-02-27 Thread Christophe Leroy
done on BOOKE as you can't switch off MMU on BOOKE, flush_dcache_icache_phys() allows to flush not mapped pages without having to map them. So it is more efficient. Christophe > > Signed-off-by: Matthew Wilcox (Oracle) > Cc: Michael Ellerman > Cc: Nicholas Piggin > Cc:

[PATCH] powerpc/perf: Properly detect mpc7450 family

2023-02-27 Thread Christophe Leroy
; 7448 And use them to detect 7450 family for perf events. Reported-by: kernel test robot Reported-by: Dan Carpenter Link: https://lore.kernel.org/r/202302260657.7dm9uwev-...@intel.com/ Fixes: ec3eb9d941a9 ("powerpc/perf: Use PVR rather than oprofile field to determine CPU version")

Re: [RFC PATCH 0/4] Remove some e300/MPC83xx evaluation platforms

2023-02-24 Thread Christophe Leroy
Le 20/02/2023 à 12:59, Paul Gortmaker a écrit : > [This RFC is proposed for v6.4 and hence is based off linux-next.] > > This series removes support for four e300 (MPC83xx) Freescale processor > family evaluation boards that were added to the kernel in the 2006 era. > > These boards were all

Re: [PATCH] powerpc/atomics: Remove unused function

2023-02-24 Thread Christophe Leroy
t; since commit 9f61521c7a28 ("powerpc/qspinlock: powerpc qspinlock > implementation") > > Signed-off-by: Nysal Jan K.A Reviewed-by: Christophe Leroy > --- > arch/powerpc/include/asm/atomic.h | 29 - > 1 file changed, 29 deletions(-)

Re: [PATCH v4 00/17] powerpc/85xx: p2020: Create one unified machine description

2023-02-23 Thread Christophe Leroy
Le 22/02/2023 à 19:22, Pali Rohár a écrit : > On Wednesday 22 February 2023 15:42:47 Christophe Leroy wrote: >> This patch series unifies all P2020 boards and machine descriptions into >> one generic unified P2020 machine description. With this generic machine >> descrip

[PATCH v4 09/17] powerpc/85xx: Remove #ifdef CONFIG_QUICC_ENGINE in mpc85xx_rdb

2023-02-22 Thread Christophe Leroy
mpc85xx_qe_par_io_init() is a stub when CONFIG_QUICC_ENGINE is not set. CONFIG_UCC_GETH and CONFIG_SERIAL_QE depend on CONFIG_QUICC_ENGINE. Remove #ifdef CONFIG_QUICC_ENGINE Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 2 -- 1 file changed, 2 deletions

[PATCH v4 11/17] powerpc/85xx: p2020: Move all P2020 RDB machine descriptions to p2020.c

2023-02-22 Thread Christophe Leroy
and simplified to be specific just for P2020 boards. Signed-off-by: Pali Rohár [chleroy: Split in two patches: one for DS, one for RDB and keep helpers out] Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/Makefile | 2 +- arch/powerpc/platforms/85xx/mpc85xx.h | 2 + arch

[PATCH v4 12/17] powerpc/85xx: p2020: Move i8259 code into own function

2023-02-22 Thread Christophe Leroy
From: Pali Rohár Splits mpic and i8259 initialization codes into separate functions. Use 'if (IS_ENABLED(CONFIG_PPC_I8259))' instead of '#ifdef CONFIG_PPC_I8259'. Signed-off-by: Pali Rohár [chleroy: Put into own C file] Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/Makefile

[PATCH v4 05/17] powerpc/85xx: mpc85xx_{ds/rdb} compact the call to mpic_alloc()

2023-02-22 Thread Christophe Leroy
Reduce number of lines in the call to mpic_alloc(). Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/mpc85xx_ds.c | 18 ++ arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 16 +--- 2 files changed, 11 insertions(+), 23 deletions(-) diff --git a/arch

[PATCH v4 13/17] powerpc/85xx: mpc85xx_ds: Move PCI code into own file

2023-02-22 Thread Christophe Leroy
From: Pali Rohár In order to share between DS and P2020. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/Makefile | 3 +- arch/powerpc/platforms/85xx/mpc85xx.h | 6 +++ arch/powerpc/platforms/85xx/mpc85xx_ds.c | 32 arch/powerpc/platforms/85xx

[PATCH v4 15/17] powerpc/85xx: p2020: Define just one machine description

2023-02-22 Thread Christophe Leroy
directory. Signed-off-by: Pali Rohár Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/p2020.c | 77 ++--- 1 file changed, 15 insertions(+), 62 deletions(-) diff --git a/arch/powerpc/platforms/85xx/p2020.c b/arch/powerpc/platforms/85xx/p2020.c index

[PATCH v4 02/17] powerpc/85xx: Rename setup_arch and pic_init on p1023

2023-02-22 Thread Christophe Leroy
Avoid conflict with other functions, rename mpc85xx_rdb_setup_arch() to p1023_rdb_setup_arch(), same for mpc85xx_rdb_pic_init(). Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/p1023_rdb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc

[PATCH v4 03/17] powerpc/85xx: Remove DBG() macro

2023-02-22 Thread Christophe Leroy
DBG() macro is defined at three places while used only one time at one place. Replace its only use by a pr_debug() and remove the macro. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/mpc85xx_ds.c | 10 +- arch/powerpc/platforms/85xx/mpc85xx_mds.c | 7 --- arch

[PATCH v4 06/17] powerpc/85xx: mpc85xx_{ds/rdb} replace BUG_ON() by WARN_ON()

2023-02-22 Thread Christophe Leroy
No need to BUG() in case mpic_alloc() fails. Use WARN_ON(). Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/mpc85xx_ds.c | 4 +++- arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/85xx

[PATCH v4 14/17] powerpc/85xx: p2020: Unify .setup_arch and .init_IRQ callbacks

2023-02-22 Thread Christophe Leroy
From: Pali Rohár Make just one .setup_arch and one .init_IRQ callback implementation for all P2020 board code. This deduplicate repeated and same code. Signed-off-by: Pali Rohár Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/mpc85xx.h | 5 --- arch/powerpc/platforms

[PATCH v4 17/17] powerpc: dts: turris1x.dts: Remove "fsl,P2020RDB-PC" compatible string

2023-02-22 Thread Christophe Leroy
kernel has generic unified support for boards with P2020 processors, there is no need to have this "hack" in turris1x.dts file. So remove incorrect "fsl,P2020RDB-PC" compatible string from turris1x.dts. Signed-off-by: Pali Rohár Signed-off-by: Christophe Leroy --- arch/pow

[PATCH v4 08/17] powerpc/85xx: Remove #ifdefs CONFIG_PPC_I8259 in mpc85xx_ds

2023-02-22 Thread Christophe Leroy
All necessary items are declared all the time, no need to use a #ifdef CONFIG_PPC_I8259. Refactor CONFIG_PPC_I8259 actions into a dedicated init function. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/mpc85xx_ds.c | 37 +--- 1 file changed, 20 insertions

[PATCH v4 01/17] powerpc/fsl_uli1575: Misc cleanup

2023-02-22 Thread Christophe Leroy
Use a single line for uli_exclude_device() Add uli_exclude_device() prototype in ppc-pci.h Remove that prototype from mpc85xx_ds.c Make uli_pirq_to_irq[] static as it is used only in that file. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/ppc-pci.h | 2 ++ arch/powerpc

[PATCH v4 10/17] powerpc/85xx: p2020: Move all P2020 DS machine descriptions to p2020.c

2023-02-22 Thread Christophe Leroy
and simplified to be specific just for P2020 boards. Signed-off-by: Pali Rohár [chleroy: Split in two patches: one for DS, one for RDB and keep helpers out] Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/Makefile | 2 +- arch/powerpc/platforms/85xx/mpc85xx.h| 3 ++ arch

[PATCH v4 04/17] powerpc/85xx: Remove #ifdefs CONFIG_PCI in mpc85xx_ds

2023-02-22 Thread Christophe Leroy
All necessary items are declared all the time, no need to use a #ifdef CONFIG_PCI. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/mpc85xx_ds.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/platforms/85xx/mpc85xx_ds.c b/arch/powerpc

[PATCH v4 16/17] powerpc/85xx: p2020: Enable boards by new config option CONFIG_PPC_P2020

2023-02-22 Thread Christophe Leroy
boards. Signed-off-by: Pali Rohár Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/Kconfig | 22 ++ arch/powerpc/platforms/85xx/Makefile | 5 +++-- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/85xx/Kconfig b/arch/powerpc

[PATCH v4 07/17] powerpc/85xx: mpc85xx_{ds/rdb} replace prink by pr_xxx macro

2023-02-22 Thread Christophe Leroy
Use pr_debug() instead of printk(KERN_DEBUG Use pr_err() instead of printk(KERN_ERR Use pr_info() instead of printk(KERN_INFO or printk(" Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/mpc85xx_ds.c | 6 +++--- arch/powerpc/platforms/85xx/mpc85xx_rdb.c | 2 +- 2 files ch

[PATCH v4 00/17] powerpc/85xx: p2020: Create one unified machine description

2023-02-22 Thread Christophe Leroy
patch "p2020: Move i8259 code into own function" (separated from the next one) * Renamed CONFIG_P2020 to CONFIG_PPC_P2020 * Fixed descriptions Link to v1: https://lore.kernel.org/linuxppc-dev/20220819191557.28116-1-p...@kernel.org/ Christophe Leroy (9): powerpc/fsl_uli1575: Mi

Re: [PATCH v3 0/8] powerpc/85xx: p2020: Create one unified machine description

2023-02-22 Thread Christophe Leroy
Le 22/02/2023 à 08:52, Pali Rohár a écrit : > On Wednesday 22 February 2023 06:39:07 Christophe Leroy wrote: >> Hi, >> >> Le 21/02/2023 à 23:07, Pali Rohár a écrit : >>> Hello Christophe! Could you look at this v3 series? >>> I addressed those small

Re: [PATCH v2] arch/powerpc/include/asm/barrier.h: redefine rmb and wmb to lwsync

2023-02-22 Thread Christophe Leroy
Le 22/02/2023 à 10:46, Kautuk Consul a écrit : >> >> Reviewed-by: Christophe Leroy > Thanks! >> >>> --- >>>arch/powerpc/include/asm/barrier.h | 7 +++ >>>1 file changed, 7 insertions(+) >>> >>> diff --git a/arch/power

Re: [PATCH v2] arch/powerpc/include/asm/barrier.h: redefine rmb and wmb to lwsync

2023-02-22 Thread Christophe Leroy
Le 22/02/2023 à 10:30, Kautuk Consul a écrit : > Again, could some IBM/non-IBM employees do basic sanity kernel load > testing on PPC64 UP and SMP systems for this patch? > would deeply appreciate it! :-) And can 'non-IBM' 'non employees' do something ? :) > > Thanks again! > Did you try on

Re: [PATCH v2] arch/powerpc/include/asm/barrier.h: redefine rmb and wmb to lwsync

2023-02-22 Thread Christophe Leroy
PPC > architectures that support it. > > Signed-off-by: Kautuk Consul Reviewed-by: Christophe Leroy > --- > arch/powerpc/include/asm/barrier.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/powerpc/include/asm/barrier.h > b/arch/powerpc/inclu

Re: [PATCH] arch/powerpc/include/asm/barrier.h: redefine rmb and wmb to lwsync

2023-02-22 Thread Christophe Leroy
Le 22/02/2023 à 09:16, Kautuk Consul a écrit : > On Wed, Feb 22, 2023 at 07:02:34AM +0000, Christophe Leroy wrote: >> >> >> Le 22/02/2023 à 07:01, Kautuk Consul a écrit : >>> A link from ibm.com states: >>> "Ensures that all instructions preceding the

Re: [PATCH] arch/powerpc/include/asm/barrier.h: redefine rmb and wmb to lwsync

2023-02-22 Thread Christophe Leroy
Le 22/02/2023 à 09:21, Kautuk Consul a écrit : >> On Wed, Feb 22, 2023 at 07:02:34AM +, Christophe Leroy wrote: >>>> +/* Redefine rmb() to lwsync. */ >>> >>> WHat's the added value of this comment ? Isn't it obvious in the line >>> below that rm

Re: [PATCH] arch/powerpc/include/asm/barrier.h: redefine rmb and wmb to lwsync

2023-02-21 Thread Christophe Leroy
Le 22/02/2023 à 07:01, Kautuk Consul a écrit : > A link from ibm.com states: > "Ensures that all instructions preceding the call to __lwsync > complete before any subsequent store instructions can be executed > on the processor that executed the function. Also, it ensures that > all load

Re: [PATCH v3 0/8] powerpc/85xx: p2020: Create one unified machine description

2023-02-21 Thread Christophe Leroy
Hi, Le 21/02/2023 à 23:07, Pali Rohár a écrit : > Hello Christophe! Could you look at this v3 series? > I addressed those small issues and hopefully it should be ready. > It would be great to have this finally in v6.3 release. I started looking at your series and I will try to provide a feedback

Re: [PATCH v3] powerpc/boot: Don't always pass -mcpu=powerpc when building 32-bit uImage

2023-02-19 Thread Christophe Leroy
Le 25/01/2023 à 08:40, Christophe Leroy a écrit : Le 22/01/2023 à 12:19, Pali Rohár a écrit : On Saturday 24 December 2022 18:44:52 Pali Rohár wrote: On Thursday 08 December 2022 19:57:39 Christophe Leroy wrote: Le 08/12/2022 à 20:16, Pali Rohár a écrit : With "[PATCH v1] power

[PATCH] powerpc/e500: Add missing prototype for 'relocate_init'

2023-02-18 Thread Christophe Leroy
to associated is_second_reloc variable declaration. Reported-by: kernel test robot Link: https://lore.kernel.org/oe-kbuild-all/202302181136.wgyckucs-...@intel.com/ Signed-off-by: Christophe Leroy --- arch/powerpc/mm/mmu_decl.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/mm

[PATCH v2 07/10] powerpc: Make generic_calibrate_decr() the default

2023-02-18 Thread Christophe Leroy
default assignment from all machines. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/time.c| 6 +- arch/powerpc/platforms/40x/ppc40x_simple.c| 1 - arch/powerpc/platforms/44x/canyonlands.c | 1 - arch/powerpc/platforms/44x/ebony.c

[PATCH v2 09/10] powerpc: Use ppc_md_progress()

2023-02-18 Thread Christophe Leroy
Many places have: if (ppc.md_progress) ppc.md_progress(); Use ppc_md_progress() instead. Note that checkpatch complains about using function names, but this is not a function taking format strings, so we leave the function names for now. Signed-off-by: Christophe Leroy

[PATCH v2 08/10] powerpc: Add ppc_md_progress()

2023-02-18 Thread Christophe Leroy
Many places have: if (ppc.md_progress) ppc.md_progress(); Introduce ppc_md_progress() which will embedded the test. Signed-off-by: Christophe Leroy --- arch/powerpc/include/asm/machdep.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/powerpc/include/asm

[PATCH v2 06/10] powerpc/85xx: Fix function naming for p1023_rdb platform

2023-02-18 Thread Christophe Leroy
p1023_rdb platform is a copy of mpc85xx_rdb platform and some of its functions have kept mpc85xx_rdb names. Rename the said functions. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/p1023_rdb.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch

[PATCH v2 10/10] powerpc/85xx: Don't check ppc_md.progress in mpc85xx_cds_setup_arch()

2023-02-18 Thread Christophe Leroy
mpc85xx_cds_setup_arch() is not a hot path, creating the string to be printed even when it doesn't get printed at the end is not an problem. Do it at all time. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/85xx/mpc85xx_cds.c | 11 --- 1 file changed, 4 insertions(+), 7

[PATCH v2 05/10] powerpc/gamecube|wii : Use machine_device_initcall()

2023-02-18 Thread Christophe Leroy
Instead of checking machine type in the function, use machine_device_initcall(). Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/embedded6xx/gamecube.c | 5 + arch/powerpc/platforms/embedded6xx/wii.c | 5 + 2 files changed, 2 insertions(+), 8 deletions(-) diff --git

[PATCH v2 04/10] powerpc/47x: Split ppc47x machine in two

2023-02-18 Thread Christophe Leroy
This machine matches two compatibles and sets .pci_irq_fixup on one of them. Split it into two machines, then the probe function can be dropped. Signed-off-by: Christophe Leroy --- v2: Also update/duplicate machine_{device/arch}_initcall --- arch/powerpc/platforms/44x/ppc476.c | 37

[PATCH v2 03/10] powerpc/platforms: Use 'compatible' property for simple cases

2023-02-18 Thread Christophe Leroy
Use the new 'compatible' property for simple cases. checkpatch complains about the new compatible being undocumented but in reality nothing is new so just ignore it for the time being. Signed-off-by: Christophe Leroy --- arch/powerpc/platforms/44x/canyonlands.c | 9 +-- arch/powerpc

[PATCH v2 01/10] powerpc/machdep: Make machine name const

2023-02-18 Thread Christophe Leroy
Machine name in struct machdep_calls should never be modified. Mark it const. Signed-off-by: Christophe Leroy --- v2: New --- arch/powerpc/include/asm/machdep.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/include/asm/machdep.h b/arch/powerpc/include/asm

[PATCH v2 02/10] powerpc/machdep: Define 'compatible' property in ppc_md and use it

2023-02-18 Thread Christophe Leroy
. Signed-off-by: Christophe Leroy --- v2: Make it const --- arch/powerpc/include/asm/machdep.h | 1 + arch/powerpc/kernel/setup-common.c | 13 +++-- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/include/asm/machdep.h b/arch/powerpc/include/asm/machdep.h index

Re: microwatt_defconfig broken: fined reference to `hash__tlb_flush'

2023-02-17 Thread Christophe Leroy
Hi Jan-Benedict, Le 17/02/2023 à 21:41, Jan-Benedict Glaw a écrit : > Hi Christophe! > > On Fri, 2023-02-17 21:00:43 +0100, Jan-Benedict Glaw > wrote: >> On Fri, 2023-02-17 19:44:27 +, Christophe Leroy >> wrote: >>> Le 17/02/2023 à 18:14, Jan-Benedict

Re: microwatt_defconfig broken: fined reference to `hash__tlb_flush'

2023-02-17 Thread Christophe Leroy
Le 17/02/2023 à 18:14, Jan-Benedict Glaw a écrit : > Hi! > > My CI builds showed that the microwatt_defconfig broke somewhere between > (upstream Linus) 6d796c50f84ca79f1722bb131799e5a5710c4700 (last known good, > log > at [1]) and 033c40a89f55525139fd5b6342281b09b97d05bf (first known bad, log

Re: [PATCH v6 10/10] MAINTAINERS: add the Freescale QMC audio entry

2023-02-17 Thread Christophe Leroy
Le 17/02/2023 à 15:56, Herve Codina a écrit : > After contributing the component, add myself as the maintainer > for the Freescale QMC audio ASoC component. > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > --- > MAINTAINERS | 8 > 1 file

Re: [PATCH v6 09/10] ASoC: fsl: Add support for QMC audio

2023-02-17 Thread Christophe Leroy
ned-off-by: Herve Codina Reviewed-by: Christophe Leroy Tested-by: Christophe Leroy > --- > sound/soc/fsl/Kconfig | 9 + > sound/soc/fsl/Makefile| 2 + > sound/soc/fsl/fsl_qmc_audio.c | 735 ++ > 3 files changed, 746 inserti

Re: [PATCH v6 08/10] dt-bindings: sound: Add support for QMC audio

2023-02-17 Thread Christophe Leroy
Codina > Reviewed-by: Krzysztof Kozlowski Reviewed-by: Christophe Leroy > --- > .../bindings/sound/fsl,qmc-audio.yaml | 117 ++ > 1 file changed, 117 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/sound/fsl,qmc-audio.

Re: [PATCH v6 07/10] MAINTAINERS: add the Freescale QMC controller entry

2023-02-17 Thread Christophe Leroy
Le 17/02/2023 à 15:56, Herve Codina a écrit : > After contributing the driver, add myself as the maintainer > for the Freescale QMC controller. > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > --- > MAINTAINERS | 8 > 1 file changed, 8 in

Re: [PATCH v6 06/10] soc: fsl: cpm1: Add support for QMC

2023-02-17 Thread Christophe Leroy
; MPC885 or MPC866. > > It is also available on some Quicc Engine SoCs. > This current version support CPM1 SoCs only and some > enhancement are needed to support Quicc Engine SoCs. > > Signed-off-by: Herve Codina > Acked-by: Li Yang Reviewed-by: Christophe Leroy >

Re: [PATCH v6 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller

2023-02-17 Thread Christophe Leroy
Le 17/02/2023 à 15:56, Herve Codina a écrit : > Add support for the QMC (QUICC Multichannel Controller) > available in some PowerQUICC SoC such as MPC885 or MPC866. > > Signed-off-by: Herve Codina > Reviewed-by: Krzysztof Kozlowski Reviewed-by: Christophe Leroy > --- >

Re: [PATCH v6 03/10] MAINTAINERS: add the Freescale TSA controller entry

2023-02-17 Thread Christophe Leroy
Le 17/02/2023 à 15:56, Herve Codina a écrit : > After contributing the driver, add myself as the maintainer > for the Freescale TSA controller. > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > --- > MAINTAINERS | 9 + > 1 file changed, 9 in

Re: [PATCH v6 01/10] dt-bindings: soc: fsl: cpm_qe: Add TSA controller

2023-02-17 Thread Christophe Leroy
Le 17/02/2023 à 15:56, Herve Codina a écrit : > Add support for the time slot assigner (TSA) > available in some PowerQUICC SoC such as MPC885 > or MPC866. > > Signed-off-by: Herve Codina Reviewed-by: Christophe Leroy > --- > .../bindings/soc/fsl/cpm_qe/fs

<    3   4   5   6   7   8   9   10   11   12   >