Re: [PATCH v5 08/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC

2023-09-12 Thread Conor Dooley
On Tue, Sep 12, 2023 at 12:10:18PM +0200, Herve Codina wrote: > The QMC (QUICC mutichannel controller) is a controller present in some > PowerQUICC SoC such as MPC885. > The QMC HDLC uses the QMC controller to transfer HDLC data. > > Additionally, a framer can be connected to the QMC HDLC. > If

Re: [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-09-12 Thread Conor Dooley
Yo, I'm not au fait enough with this to leave particularly meaningful comments, so just some minor ones for you. On Tue, Sep 12, 2023 at 12:14:44PM +0200, Herve Codina wrote: > The Lantiq PEF2256 is a framer and line interface component designed to > fulfill all required interfacing between an

Re: [PATCH v5 06/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Fix example property name

2023-09-12 Thread Conor Dooley
("dt-bindings: soc: fsl: cpm_qe: Add QMC controller") > Signed-off-by: Herve Codina Acked-by: Conor Dooley Thanks, Conor. > --- > .../bindings/soc/fsl/cpm_qe/fsl,cpm1-scc-qmc.yaml | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [PATCH v5 07/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add 'additionalProperties: false' in child nodes

2023-09-12 Thread Conor Dooley
On Tue, Sep 12, 2023 at 10:14:58AM +0200, Herve Codina wrote: > Additional properties in child node should not be allowed. > > Prevent them adding 'additionalProperties: false' > > Signed-off-by: Herve Codina Acked-by: Conor Dooley Thanks, Conor. > --- > .../device

Re: [PATCH v5 25/31] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer

2023-09-13 Thread Conor Dooley
On Tue, Sep 12, 2023 at 01:54:05PM -0500, Rob Herring wrote: > > > + lantiq,data-rate-bps: > > > +$ref: /schemas/types.yaml#/definitions/uint32 > > > +enum: [2048000, 4096000, 8192000, 16384000] > > > > -kBps is a standard suffix, would it be worth using that instead here? > > What you

Re: [PATCH v5 08/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC

2023-09-13 Thread Conor Dooley
On Wed, Sep 13, 2023 at 09:26:40AM +0200, Herve Codina wrote: > Hi Conor, > > On Tue, 12 Sep 2023 18:21:58 +0100 > Conor Dooley wrote: > > > On Tue, Sep 12, 2023 at 12:10:18PM +0200, Herve Codina wrote: > > > The QMC (QUICC mutichannel controller) i

Re: [PATCH v5 08/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC

2023-09-13 Thread Conor Dooley
On Wed, Sep 13, 2023 at 04:52:50PM +0200, Herve Codina wrote: > On Wed, 13 Sep 2023 15:42:45 +0100 > Conor Dooley wrote: > > > On Wed, Sep 13, 2023 at 09:26:40AM +0200, Herve Codina wrote: > > > Hi Conor, > > > > > > On Tue, 12 Sep 202

Re: [PATCH v5 08/31] dt-bindings: soc: fsl: cpm_qe: cpm1-scc-qmc: Add support for QMC HDLC

2023-09-13 Thread Conor Dooley
On Wed, Sep 13, 2023 at 03:56:16PM +0100, Conor Dooley wrote: > On Wed, Sep 13, 2023 at 04:52:50PM +0200, Herve Codina wrote: > > On Wed, 13 Sep 2023 15:42:45 +0100 > > Conor Dooley wrote: > > > > > On Wed, Sep 13, 2023 at 09:26:40AM +0200, Herve

Re: [PATCH] ASoC: dt-bindings: Add missing (unevaluated|additional)Properties on child node schemas

2023-09-26 Thread Conor Dooley
for any node. > > Add unevaluatedProperties or additionalProperties as appropriate. > > Signed-off-by: Rob Herring Acked-by: Conor Dooley Thanks, Conor. > --- > Documentation/devicetree/bindings/sound/dialog,da7219.yaml | 1 + > Documentation/devicetree/bind

Re: [PATCH 1/2] kexec: fix KEXEC_FILE dependencies

2023-10-23 Thread Conor Dooley
On Mon, Oct 23, 2023 at 01:01:54PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The cleanup for the CONFIG_KEXEC Kconfig logic accidentally changed the > 'depends on CRYPTO=y' dependency to a plain 'depends on CRYPTO', which > causes a link failure when all the crypto support is in a

Re: [PATCH 1/2] kexec: fix KEXEC_FILE dependencies

2023-10-23 Thread Conor Dooley
On Mon, Oct 23, 2023 at 06:04:06PM +0200, Arnd Bergmann wrote: > On Mon, Oct 23, 2023, at 17:37, Conor Dooley wrote: > > On Mon, Oct 23, 2023 at 01:01:54PM +0200, Arnd Bergmann wrote: > > >> index 25474f8c12b79..f571bad2d22d0 100644 > >> --- a/arch/riscv/Kconfig

Re: [PATCH v7 00/25] Rust support

2022-07-16 Thread Conor Dooley
Hey, Maybe I am just missing something blatantly obvious here, but trying to build rust support in -next fails for me. I am using ClangBuiltLinux clang version 15.0.0 5b0788fef86ed7008a11f6ee19b9d86d42b6fcfa and LLD 15.0.0. Is it just expected that building -next with rust support is not a good

Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-19 Thread Conor Dooley
ip-host.c | 1 - LGTM... Acked-by: Conor Dooley

Re: [PATCH v2 0/4] PCI: Remove unnecessary includes

2022-10-25 Thread Conor Dooley
Include explicitly > PCI: microchip: Include explicitly > PCI: mvebu: Include explicitly > PCI: Remove unnecessary includes > drivers/pci/controller/pcie-microchip-host.c | 2 +- Hey Bjorn, actually did the build this time rather than visually inspecting... For the microchip bits: Reviewed-by: Conor Dooley Thanks!

Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-20 Thread Conor Dooley
On Thu, Oct 20, 2022 at 08:45:47AM -0500, Bjorn Helgaas wrote: > [+cc Pali, heads-up for trivial addition of to > pci-mvebu.c] > > On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > &g

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-01-31 Thread Conor Dooley
Hey Mike, On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Every architecture that supports FLATMEM memory model defines its own > version of pfn_valid() that essentially compares a pfn to max_mapnr. > > Use mips/powerpc version implemented as

Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM

2023-01-31 Thread Conor Dooley
Hi Mike, On Tue, Jan 31, 2023 at 08:41:49PM +0200, Mike Rapoport wrote: > On Tue, Jan 31, 2023 at 05:47:24PM +0000, Conor Dooley wrote: > > On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > > > From: "Mike Rapoport (IBM)" > > > > >

Re: [PATCH v2 4/5] riscv: Select ARCH_DMA_DEFAULT_COHERENT

2023-02-23 Thread Conor Dooley
On Thu, Feb 23, 2023 at 11:36:43AM +, Jiaxun Yang wrote: > For riscv our assumption is unless a device states it is non-coherent, > we take it to be DMA coherent. > > Select ARCH_DMA_DEFAULT_COHERENT to ensure dma_default_coherent > is always initialized to true. > > Signed-off-by: Jiaxun

Re: [PATCH 2/3] riscv: Set dma_default_coherent to true

2023-02-22 Thread Conor Dooley
On Wed, Feb 22, 2023 at 03:55:19PM +, Jiaxun Yang wrote: > > > > 2023年2月22日 14:50,Conor Dooley 写道: > > > > On Wed, Feb 22, 2023 at 01:37:11PM +, Jiaxun Yang wrote: > >> For riscv our assumption is unless a device states it is non-coherent, &

Re: [PATCH 6/7] riscv: Select ARCH_DMA_DEFAULT_COHERENT

2023-02-21 Thread Conor Dooley
On Tue, Feb 21, 2023 at 12:46:12PM +, Jiaxun Yang wrote: > For RISCV we always assume devices are DMA coherent. "Always assume", I'm not keen on that wording as it is unclear as to whether you are suggesting that a) we always take devices to be DMA coherent, or b) unless a device states it is

Re: [PATCH 2/3] riscv: Set dma_default_coherent to true

2023-02-22 Thread Conor Dooley
On Wed, Feb 22, 2023 at 04:20:16PM +, Jiaxun Yang wrote: > > 2023年2月22日 16:02,Conor Dooley 写道: > > On Wed, Feb 22, 2023 at 03:55:19PM +, Jiaxun Yang wrote: > >>> 2023年2月22日 14:50,Conor Dooley 写道: > >>> On Wed, Feb 22, 2023 at 01:37:11PM +, Jia

Re: [PATCH 2/3] riscv: Set dma_default_coherent to true

2023-02-22 Thread Conor Dooley
On Wed, Feb 22, 2023 at 01:37:11PM +, Jiaxun Yang wrote: > For riscv our assumption is unless a device states it is non-coherent, > we take it to be DMA coherent. > > For devicetree probed devices that have been true since very begining > with OF_DMA_DEFAULT_COHERENT selected. > >

Re: [PATCH v9 0/6] Introduce 64b relocatable kernel

2023-04-21 Thread Conor Dooley
On Fri, Apr 21, 2023 at 07:10:14PM +, Konstantin Ryabitsev wrote: > April 21, 2023 2:59 PM, "Palmer Dabbelt" wrote: > >> riscv: Use PUD/P4D/PGD pages for the linear mapping > >> (https://patchwork.kernel.org/project/linux-riscv/list/?series=733603) > >> base-commit-tag: v6.3-rc1 > > > > The

Re: [PATCH v6 4/4] risc/purgatory: Add linker script

2023-05-01 Thread Conor Dooley
Hey Ricardo, On Mon, May 01, 2023 at 02:38:22PM +0200, Ricardo Ribalda wrote: > If PGO is enabled, the purgatory ends up with multiple .text sections. > This is not supported by kexec and crashes the system. > > Cc: sta...@vger.kernel.org > Fixes: 930457057abe ("kernel/kexec_file.c: split up

Re: [PATCH v6 4/4] risc/purgatory: Add linker script

2023-05-01 Thread Conor Dooley
On Mon, May 01, 2023 at 07:18:12PM +0200, Ricardo Ribalda wrote: > On Mon, 1 May 2023 at 18:19, Nick Desaulniers wrote: > > > > On Mon, May 1, 2023 at 5:39 AM Ricardo Ribalda wrote: > > > > > > If PGO is enabled, the purgatory ends up with multiple .text sections. > > > This is not supported by

[PATCH v1] dt-bindings: move cache controller bindings to a cache directory

2023-03-30 Thread Conor Dooley
From: Conor Dooley There's a bunch of bindings for (mostly l2) cache controllers scattered to the four winds, move them to a common directory. I renamed the freescale l2cache.txt file, as while that might make sense when the parent dir is fsl, it's confusing after the move. The two Marvell

Re: [PATCH 09/21] riscv: dma-mapping: skip invalidation before bidirectional DMA

2023-03-29 Thread Conor Dooley
n by the device. > > riscv also invalidates the caches before the transfer, which does > not appear to serve any purpose. Rationale makes sense to me.. Reviewed-by: Conor Dooley Thanks for working on all of this Arnd! signature.asc Description: PGP signature

Re: [PATCH 08/21] riscv: dma-mapping: only invalidate after DMA, not flush

2023-03-29 Thread Conor Dooley
ut *surely* if no other arch needs to do that, then we are safe to also not do it... Your logic seems right by me at least, especially given the lack of flushes elsewhere. Reviewed-by: Conor Dooley Cheers, Conor. > Signed-off-by: Arnd Bergmann > --- > arch/riscv/mm/dma-noncoherent.c

Re: [PATCH v2 05/28] dt-bindings: net: Add support for QMC HDLC

2023-07-27 Thread Conor Dooley
On Wed, Jul 26, 2023 at 05:02:01PM +0200, Herve Codina wrote: > The QMC (QUICC mutichannel controller) is a controller present in some > PowerQUICC SoC such as MPC885. > The QMC HDLC uses the QMC controller to transfer HDLC data. > > Signed-off-by: Herve Codina > --- >

Re: [PATCH v2 27/28] dt-bindings: net: fsl,qmc-hdlc: Add framer support

2023-07-27 Thread Conor Dooley
On Wed, Jul 26, 2023 at 05:02:23PM +0200, Herve Codina wrote: > A framer can be connected to the QMC HDLC. > If present, this framer is the interface between the TDM used by the QMC > HDLC and the E1/T1 line. > The QMC HDLC can use this framer to get information about the line and > configure the

Re: [PATCH v2 05/28] dt-bindings: net: Add support for QMC HDLC

2023-07-27 Thread Conor Dooley
On Thu, Jul 27, 2023 at 11:09:48AM +0200, Herve Codina wrote: > On Thu, 27 Jul 2023 09:19:59 +0100 > Conor Dooley wrote: > > On Wed, Jul 26, 2023 at 05:02:01PM +0200, Herve Codina wrote: > If needed, I can change to: > title: QMC (QUICC Multichannel Controller) H

Re: [PATCH v3 11/13] riscv/kexec: refactor for kernel/Kconfig.kexec

2023-06-28 Thread Conor Dooley
Hey Eric, On Mon, Jun 26, 2023 at 12:13:30PM -0400, Eric DeVolder wrote: > The kexec and crash kernel options are provided in the common > kernel/Kconfig.kexec. Utilize the common options and provide > the ARCH_SUPPORTS_ and ARCH_SELECTS_ entries to recreate the > equivalent set of KEXEC and

Re: [PATCH v6 4/4] risc/purgatory: Add linker script

2023-05-05 Thread Conor Dooley
On Mon, May 01, 2023 at 09:54:43PM +0200, Ricardo Ribalda wrote: > On Mon, 1 May 2023 at 19:41, Conor Dooley wrote: > > On Mon, May 01, 2023 at 02:38:22PM +0200, Ricardo Ribalda wrote: > > > If PGO is enabled, the purgatory ends up with multiple .text sections. > >

Re: [PATCH] tty: hvc: Don't enable the RISC-V SBI console by default

2024-02-14 Thread Conor Dooley
ot; drivers, then the solution is simple, firmware needs implementation needs to patch the DT and, at least, mark the uart as reserved if it is using it to provide the debug console. Marking this nonportable so that people only walk into this with their eyes open seems like a reasonable

Re: [PATCH 0/4] arm64: mm: support dynamic vmalloc/pmd configuration

2024-02-21 Thread Conor Dooley
Hey Maxwell, FYI: > mm/vmalloc: allow arch-specific vmalloc_node overrides > mm: pgalloc: support address-conditional pmd allocation With these two arch/riscv/configs/* are broken with calls to undeclared functions. > arm64: separate code and data virtual memory allocation > arm64:

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-06 Thread Conor Dooley
On Wed, Dec 06, 2023 at 11:37:52PM +0800, Baoquan He wrote: > On 12/04/23 at 04:14pm, Conor Dooley wrote: > > On Mon, Dec 04, 2023 at 11:38:05PM +0800, Baoquan He wrote: > > > On 12/01/23 at 10:38am, Conor Dooley wrote: > > > > On Thu, Nov 30, 2023 at 10:3

Re: [PATCH 3/3] ASoC: dt-bindings: fsl,micfil: Add compatible string for i.MX95 platform

2024-01-10 Thread Conor Dooley
On Tue, Jan 09, 2024 at 04:55:51PM +0900, Chancel Liu wrote: > Add compatible string "fsl,imx95-micfil" for i.MX95 platform. > > Signed-off-by: Chancel Liu > --- > .../devicetree/bindings/sound/fsl,micfil.yaml | 15 +++ > 1 file changed, 11 insertions(+), 4 deletions(-) > >

Re: [PATCH 2/3] arch and include: Update LLVM Phabricator links

2024-01-10 Thread Conor Dooley
arch/riscv/include/asm/ftrace.h | 2 +- Reviewed-by: Conor Dooley Cheers, Conor. signature.asc Description: PGP signature

Re: [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required

2023-12-19 Thread Conor Dooley
ause the content has been printed > out in generic code. > > Signed-off-by: Baoquan He I'm sorry - I meant to look at this several days ago but I forgot. Apart from the typo that crept back into $subject, this version explains the rationale behind what you're changing a lot better, t

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-01 Thread Conor Dooley
On Thu, Nov 30, 2023 at 10:39:53AM +0800, Baoquan He wrote: $subject has a typo in the arch bit :) > Replace pr_debug() with the newly added kexec_dprintk() in kexec_file > loading related codes. Commit messages should be understandable in isolation, but this only explains (part of) what is

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-04 Thread Conor Dooley
On Mon, Dec 04, 2023 at 11:38:05PM +0800, Baoquan He wrote: > On 12/01/23 at 10:38am, Conor Dooley wrote: > > On Thu, Nov 30, 2023 at 10:39:53AM +0800, Baoquan He wrote: > > > > $subject has a typo in the arch bit :) > > Indeed, will fix if need report.

Re: [PATCH 1/2] powerpc/prom_init: Replace linux,sml-base/sml-size with linux,sml-log

2024-03-07 Thread Conor Dooley
On Thu, Mar 07, 2024 at 04:15:01PM -0500, Stefan Berger wrote: > > > On 3/7/24 15:39, Conor Dooley wrote: > > On Thu, Mar 07, 2024 at 10:11:03AM -0500, Stefan Berger wrote: > > > On 3/7/24 05:41, Michael Ellerman wrote: > > > > Stefan Berger wr

Re: [PATCH 1/2] powerpc/prom_init: Replace linux,sml-base/sml-size with linux,sml-log

2024-03-07 Thread Conor Dooley
On Thu, Mar 07, 2024 at 10:11:03AM -0500, Stefan Berger wrote: > On 3/7/24 05:41, Michael Ellerman wrote: > > Stefan Berger writes: > > > > Also adding the new linux,sml-log property should be accompanied by a > > change to the device tree binding. > > > See my proposal below. > > > > > The

Re: [PATCH 2/2] tpm: of: If available Use linux,sml-log to get the log and its size

2024-03-07 Thread Conor Dooley
On Wed, Mar 06, 2024 at 10:55:11AM -0500, Stefan Berger wrote: > If linux,sml-log is available use it to get the TPM log rather than the > pointer found in linux,sml-base. This resolves an issue on PowerVM and KVM > on Power where after a kexec the memory pointed to by linux,sml-base may > have

Re: [PATCH v2 4/5] dt-bindings: hwmon: stts751: convert to dtschema

2024-03-22 Thread Conor Dooley
On Fri, Mar 22, 2024 at 07:45:29AM +0100, Javier Carrasco wrote: > Convert existing binding to support validation. > > This is a straightforward conversion with no new properties. > Reviewed-by: Conor Dooley Thanks, Conor. signature.asc Description: PGP signature

Re: [PATCH v2 2/5] dt-bindings: hwmon: ibmpowernv: convert to dtschema

2024-03-22 Thread Conor Dooley
I think its a poor choice here regardless. With a compatible for the filename: Reviewed-by: Conor Dooley Thanks, Conor. > @@ -0,0 +1,37 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/hwmon/ibm,powernv.yaml#

Re: [PATCH 2/4] ASoC: dt-bindings: fsl,xcvr: Add two PLL clock sources

2024-05-09 Thread Conor Dooley
On Thu, May 09, 2024 at 10:57:38AM +0800, Shengjiu Wang wrote: > Add two PLL clock sources, they are the parent clocks of the root clock > one is for 8kHz series rates, named as 'pll8k', another one is for > 11kHz series rates, named as 'pll11k'. They are optional clocks, > if there are such

Re: [PATCH 1/4] ASoC: dt-bindings: fsl,xcvr: Add compatible string for i.MX95

2024-05-09 Thread Conor Dooley
On Thu, May 09, 2024 at 10:57:37AM +0800, Shengjiu Wang wrote: > Add compatible string "fsl,imx95-xcvr" for i.MX95 platform. That's apparent from the diff. Why is it not compatible with existing devices? Cheers, Conor. > > Signed-off-by: Shengjiu Wang > --- >

Re: [PATCH 2/4] ASoC: dt-bindings: fsl,xcvr: Add two PLL clock sources

2024-05-11 Thread Conor Dooley
On Fri, May 10, 2024 at 10:38:30AM +0800, Shengjiu Wang wrote: > On Fri, May 10, 2024 at 10:27 AM Shengjiu Wang > wrote: > > > > On Fri, May 10, 2024 at 1:14 AM Conor Dooley wrote: > > > > > > On Thu, May 09, 2024 at 10:57:38AM +0800, Shengjiu Wang wrot