Re: [PATCH v3 0/6] Ethernet over hdlc

2018-09-03 Thread David Miller
From: David Gounaris Date: Mon, 3 Sep 2018 14:47:24 +0200 > Here is what has been changed in v3 after the review comments from v2. > > v3-0001: corrected style problems > v3-0002: corrected style problems > v3-0003: corrected style problems > v3-0004: corrected style problems > v3-0005: correct

Re: [PATCH v2 3/6] net/wan/fsl_ucc_hdlc: Adding ARPHRD_ETHER

2018-08-31 Thread David Miller
From: David Gounaris Date: Wed, 29 Aug 2018 15:13:25 +0200 > @@ -513,6 +517,8 @@ static int hdlc_rx_done(struct ucc_hdlc_private *priv, > int rx_work_limit) > break; > > case ARPHRD_PPP: > + case ARPHRD_ETHER: > + Please don

Re: [v2, 3/3] ptp_qoriq: support automatic configuration for ptp timer

2018-08-05 Thread David Miller
From: Yangbo Lu Date: Wed, 1 Aug 2018 18:05:54 +0800 > This patch is to support automatic configuration for ptp timer. > If required ptp dts properties are not provided, driver could > try to calculate a set of default configurations to initialize > the ptp timer. This makes the driver work for

Re: [v2, 2/3] powerpc/mpc85xx: add clocks property for fman ptp timer node

2018-08-05 Thread David Miller
From: Yangbo Lu Date: Wed, 1 Aug 2018 18:05:53 +0800 > This patch is to add clocks property for fman ptp timer node. > > Signed-off-by: Yangbo Lu > --- > Changes for v2: > - None. Applied.

Re: [v2, 1/3] arm64: dts: fsl: add clocks property for fman ptp timer node

2018-08-05 Thread David Miller
From: Yangbo Lu Date: Wed, 1 Aug 2018 18:05:52 +0800 > This patch is to add clocks property for fman ptp timer node. > > Signed-off-by: Yangbo Lu > --- > Changes for v2: > - None. Applied.

Re: [PATCH 3/3] ptp_qoriq: convert to use module parameters for initialization

2018-07-30 Thread David Miller
From: Yangbo Lu Date: Mon, 30 Jul 2018 18:01:54 +0800 > +static unsigned int cksel = DEFAULT_CKSEL; > +module_param(cksel, uint, 0644); > +MODULE_PARM_DESC(cksel, "Select reference clock"); > + > +static unsigned int clk_src; > +module_param(clk_src, uint, 0644); > +MODULE_PARM_DESC(clk_src, "Ref

Re: [PATCH] net: ethernet: fs-enet: Use generic CRC32 implementation

2018-07-25 Thread David Miller
From: Krzysztof Kozlowski Date: Mon, 23 Jul 2018 18:20:20 +0200 > Use generic kernel CRC32 implementation because it: > 1. Should be faster (uses lookup tables), > 2. Removes duplicated CRC generation code, > 3. Uses well-proven algorithm instead of coding it one more time. > > Suggested-by: Eri

Re: [PATCH net-next] wan/fsl_ucc_hdlc: use IS_ERR_VALUE() to check return value of qe_muram_alloc

2018-07-23 Thread David Miller
From: YueHaibing Date: Mon, 23 Jul 2018 22:12:33 +0800 > qe_muram_alloc return a unsigned long integer,which should not > compared with zero. check it using IS_ERR_VALUE() to fix this. > > Fixes: c19b6d246a35 ("drivers/net: support hdlc function for QE-UCC") > Signed-off-by: YueHaibing Applied

Re: [PATCH] net: prevent ISA drivers from building on PPC32

2018-07-22 Thread David Miller
From: Randy Dunlap Date: Sat, 21 Jul 2018 12:59:25 -0700 > From: Randy Dunlap > > Prevent drivers from building on PPC32 if they use isa_bus_to_virt(), > isa_virt_to_bus(), or isa_page_to_bus(), which are not available and > thus cause build errors. ... > Signed-off-by: Randy Dunlap > Suggest

Re: [PATCH] MAINTAINERS: Drop inactive Vitaly Bordug's email

2018-07-18 Thread David Miller
From: Krzysztof Kozlowski Date: Tue, 17 Jul 2018 18:41:54 +0200 > The Vitaly Bordug's email bounces ("ru.mvista.com: Name or service not > known") and there was no activity (ack, review, sign) since 2009. > > Cc: Vitaly Bordug > Cc: Pantelis Antoniou > Cc: "David S. Miller" > Signed-off-by: K

Re: [PATCH] net/ethernet/freescale/fman: fix cross-build error

2018-07-16 Thread David Miller
From: Randy Dunlap Date: Fri, 13 Jul 2018 21:25:19 -0700 > From: Randy Dunlap > > CC [M] drivers/net/ethernet/freescale/fman/fman.o > In file included from ../drivers/net/ethernet/freescale/fman/fman.c:35: > ../include/linux/fsl/guts.h: In function 'guts_set_dmacr': > ../include/linux/fsl/gu

Re: [v4, 00/10] Support DPAA PTP clock and timestamping

2018-06-26 Thread David Miller
From: Yangbo Lu Date: Mon, 25 Jun 2018 20:37:06 +0800 > This patchset is to support DPAA FMAN PTP clock and HW timestamping. > It had been verified on both ARM platform and PPC platform. > - The patch #1 to patch #5 are to support DPAA FMAN 1588 timer in > ptp_qoriq driver. > - The patch #6 to

Re: [PATCH net-next] wan/fsl_ucc_hdlc: use dma_zalloc_coherent instead of allocator/memset

2018-06-04 Thread David Miller
From: YueHaibing Date: Mon, 4 Jun 2018 21:07:59 +0800 > Use dma_zalloc_coherent instead of dma_alloc_coherent > followed by memset 0. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next 0/8] ibmvnic: Failover hardening

2018-05-24 Thread David Miller
From: Thomas Falcon Date: Wed, 23 May 2018 13:37:54 -0500 > Introduce additional transport event hardening to handle > events during device reset. In the driver's current state, > if a transport event is received during device reset, it can > cause the device to become unresponsive as invalid ope

Re: [PATCH] net: ethernet: ucc: fix spelling mistake: "tx-late-collsion" -> "tx-late-collision"

2018-04-30 Thread David Miller
From: Colin King Date: Sat, 28 Apr 2018 10:57:07 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in tx_fw_stat_gstrings text > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH net] ibmvnic: Clean actual number of RX or TX pools

2018-04-22 Thread David Miller
From: Thomas Falcon Date: Fri, 20 Apr 2018 14:25:32 -0500 > Avoid using value stored in the login response buffer when > cleaning TX and RX buffer pools since these could be inconsistent > depending on the device state. Instead use the field in the driver's > private data that tracks the number o

Re: [PATCH] ibmvnic: Clear pending interrupt after device reset

2018-04-16 Thread David Miller
From: Thomas Falcon Date: Sun, 15 Apr 2018 18:53:36 -0500 > Due to a firmware bug, the hypervisor can send an interrupt to a > transmit or receive queue just prior to a partition migration, not > allowing the device enough time to handle it and send an EOI. When > the partition migrates, the inte

Re: [PATCH] ibmvnic: Clear pending interrupt after device reset

2018-04-15 Thread David Miller
From: Thomas Falcon Date: Sun, 15 Apr 2018 18:53:36 -0500 > Due to a firmware bug, the hypervisor can send an interrupt to a > transmit or receive queue just prior to a partition migration, not > allowing the device enough time to handle it and send an EOI. When > the partition migrates, the inte

Re: RFC on writel and writel_relaxed

2018-03-29 Thread David Miller
From: Sinan Kaya Date: Thu, 29 Mar 2018 09:56:01 -0400 > sparc question sent Sparc never lets physical memory accesses pass MMIO, and vice versa. They are always strongly ordered amongst eachother. Therefore no explicit barrier instructions are necessary.

Re: RFC on writel and writel_relaxed

2018-03-28 Thread David Miller
From: Benjamin Herrenschmidt Date: Thu, 29 Mar 2018 02:13:16 +1100 > Let's fix all archs, it's way easier than fixing all drivers. Half of > the archs are unused or dead anyway. Agreed.

Re: [PATCH net-next] ibmvnic: Potential NULL dereference in clean_one_tx_pool()

2018-03-25 Thread David Miller
From: Dan Carpenter Date: Fri, 23 Mar 2018 14:36:15 +0300 > There is an && vs || typo here, which potentially leads to a NULL > dereference. > > Fixes: e9e1e97884b7 ("ibmvnic: Update TX pool cleaning routine") > Signed-off-by: Dan Carpenter Applied, thanks Dan.

Re: [PATCH v12 00/11] Application Data Integrity feature introduced by SPARC M7

2018-03-18 Thread David Miller
From: Khalid Aziz Date: Wed, 21 Feb 2018 10:15:42 -0700 > V12 changes: > This series is same as v10 and v11 and was simply rebased on 4.16-rc2 > kernel and patch 11 was added to update signal delivery code to use the > new helper functions added by Eric Biederman. Can mm maintainers please > revi

Re: [PATCH 0/5] DPAA Ethernet fixes

2018-03-15 Thread David Miller
From: Madalin-cristian Bucur Date: Thu, 15 Mar 2018 09:32:35 + >> -Original Message- >> From: Joakim Tjernlund [mailto:joakim.tjernl...@infinera.com] >> Sent: Wednesday, March 14, 2018 8:43 PM >> To: da...@davemloft.net; Madalin-cristian Bucur >> >> >> On Wed, 2018-03-14 at 08:37 -0

Re: [PATCH 0/5] DPAA Ethernet fixes

2018-03-14 Thread David Miller
From: Madalin Bucur Date: Wed, 14 Mar 2018 08:37:27 -0500 > This patch set is addressing several issues in the DPAA Ethernet > driver suite: > > - module unload crash caused by wrong reference to device being left >in the cleanup code after the DSA related changes > - scheduling wile atomi

Re: [PATCH, net] ibmvnic: fix empty firmware version and errors cleanup

2018-02-05 Thread David Miller
From: Desnes Augusto Nunes do Rosario Date: Mon, 5 Feb 2018 14:33:55 -0200 > This patch makes sure that the firmware version is never NULL. Moreover, > it also performs some cleanup on the error messages. > > Fixes: a107311d7fdf ("ibmvnic: fix firmware version when no firmware level > has been

Re: [PATCH, net] ibmvnic: fix firmware version when no firmware level has been provided by the VIOS server

2018-02-01 Thread David Miller
From: Desnes Augusto Nunes do Rosario Date: Thu, 1 Feb 2018 16:04:30 -0200 > Older versions of VIOS servers do not send the firmware level in the VPD > buffer for the ibmvnic driver. Thus, not only the current message is mis- > leading but the firmware version in the ethtool will be NULL. Theref

Re: [PATCH] net: fs_enet: do not call phy_stop() in interrupts

2018-01-17 Thread David Miller
From: Christophe Leroy Date: Tue, 16 Jan 2018 10:33:05 +0100 (CET) > In case of TX timeout, fs_timeout() calls phy_stop(), which > triggers the following BUG_ON() as we are in interrupt. ... > This patch moves fs_timeout() actions into an async worker. > > Fixes: commit 48257c4f168e5 ("Add fs_e

Re: [net] Revert "net: core: maybe return -EEXIST in __dev_alloc_name"

2018-01-08 Thread David Miller
From: Michael Ellerman Date: Mon, 08 Jan 2018 14:26:12 +1100 > I don't see it in rc7, will it get to Linus sometime before the > release? I will do what I can to make sure it does, it is in my GIT tree.

Re: [net] Revert "net: core: maybe return -EEXIST in __dev_alloc_name"

2018-01-02 Thread David Miller
From: Michael Ellerman Date: Fri, 22 Dec 2017 15:22:22 +1100 >> On Tue, Dec 19 2017, Michael Ellerman >> wrote: >>> This revert seems to have broken networking on one of my powerpc >>> machines, according to git bisect. >>> >>> The symptom is DHCP fails and I don't get a link, I didn't dig any

Re: [PATCH] net: ethernet: xilinx: Mark XILINX_LL_TEMAC broken on 64-bit

2017-11-29 Thread David Miller
From: Geert Uytterhoeven Date: Wed, 29 Nov 2017 11:01:09 +0100 > On 64-bit (e.g. powerpc64/allmodconfig): > > drivers/net/ethernet/xilinx/ll_temac_main.c: In function > 'temac_start_xmit_done': > drivers/net/ethernet/xilinx/ll_temac_main.c:633:22: warning: cast to > pointer from intege

Re: [PATCH] [net] ibmvnic: fix dma_mapping_error call

2017-11-17 Thread David Miller
From: Desnes Augusto Nunes do Rosario Date: Fri, 17 Nov 2017 09:09:04 -0200 > This patch fixes the dma_mapping_error call to use the correct dma_addr > which is inside the ibmvnic_vpd struct. Moreover, it fixes an uninitialized > warning regarding a local dma_addr variable which is not used anymo

Re: [PATCH] [net-next,v4] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

2017-11-14 Thread David Miller
From: Desnes Augusto Nunes do Rosario Date: Mon, 13 Nov 2017 15:59:19 -0200 > This patch implements and enables VDP support for the ibmvnic driver. > Moreover, it includes the implementation of suitable structs, signal > transmission/handling and functions which allows the retrival of firmware >

Re: [PATCH] [net-next,v2] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

2017-11-04 Thread David Miller
From: Desnes Augusto Nunes do Rosario Date: Wed, 1 Nov 2017 19:03:32 -0200 > + substr = strnstr(adapter->vpd->buff, "RM", adapter->vpd->len); > + if (!substr) { > + dev_info(dev, "No FW level provided by VPD\n"); > + complete(&adapter->fw_done); > + re

Re: [PATCH 04/13] timer: Remove init_timer_pinned() in favor of timer_setup()

2017-10-04 Thread David Miller
From: Kees Cook Date: Wed, 4 Oct 2017 16:26:58 -0700 > This refactors the only users of init_timer_pinned() to use > the new timer_setup() and from_timer(). Drops the definition of > init_timer_pinned(). > > Cc: Chris Metcalf > Cc: Thomas Gleixner > Cc: net...@vger.kernel.org > Signed-off-by:

Re: [PATCH 05/13] timer: Remove init_timer_deferrable() in favor of timer_setup()

2017-10-04 Thread David Miller
From: Kees Cook Date: Wed, 4 Oct 2017 16:26:59 -0700 > This refactors the only users of init_timer_deferrable() to use > the new timer_setup() and from_timer(). Removes definition of > init_timer_deferrable(). > > Cc: Benjamin Herrenschmidt > Cc: Michael Ellerman > Cc: Sebastian Reichel > Cc

Re: [PATCH 10/13] timer: Remove expires and data arguments from DEFINE_TIMER

2017-10-04 Thread David Miller
From: Kees Cook Date: Wed, 4 Oct 2017 16:27:04 -0700 > Drop the arguments from the macro and adjust all callers with the > following script: > > perl -pi -e 's/DEFINE_TIMER\((.*), 0, 0\);/DEFINE_TIMER($1);/g;' \ > $(git grep DEFINE_TIMER | cut -d: -f1 | sort -u | grep -v timer.h) > > Sig

Re: [PATCH v2] net/ethernet/freescale: fix warning for ucc_geth

2017-09-18 Thread David Miller
From: Valentin Longchamp Date: Fri, 15 Sep 2017 07:58:47 +0200 > uf_info.regs is resource_size_t i.e. phys_addr_t that can be either u32 > or u64 according to CONFIG_PHYS_ADDR_T_64BIT. > > The printk format is thus adaptet to u64 and the regs value cast to u64 > to take both u32 and u64 into acc

Re: [PATCH v7 07/11] sparc64: optimized struct page zeroing

2017-08-30 Thread David Miller
From: Pasha Tatashin Date: Wed, 30 Aug 2017 09:19:58 -0400 > The reason I am not doing initializing stores is because they require > a membar, even if only regular stores are following (I hoped to do a > membar before first load). This is something I was thinking was not > true, but after consult

Re: [PATCH v7 07/11] sparc64: optimized struct page zeroing

2017-08-29 Thread David Miller
From: Pavel Tatashin Date: Mon, 28 Aug 2017 22:02:18 -0400 > Add an optimized mm_zero_struct_page(), so struct page's are zeroed without > calling memset(). We do eight to ten regular stores based on the size of > struct page. Compiler optimizes out the conditions of switch() statement. > > SPAR

Re: [PATCH v7 02/11] sparc64/mm: setting fields in deferred pages

2017-08-29 Thread David Miller
From: Pavel Tatashin Date: Mon, 28 Aug 2017 22:02:13 -0400 > Without deferred struct page feature (CONFIG_DEFERRED_STRUCT_PAGE_INIT), > flags and other fields in "struct page"es are never changed prior to first > initializing struct pages by going through __init_single_page(). > > With deferred

Re: [PATCH v7 04/11] sparc64: simplify vmemmap_populate

2017-08-29 Thread David Miller
From: Pavel Tatashin Date: Mon, 28 Aug 2017 22:02:15 -0400 > Remove duplicating code by using common functions > vmemmap_pud_populate and vmemmap_pgd_populate. > > Signed-off-by: Pavel Tatashin > Reviewed-by: Steven Sistare > Reviewed-by: Daniel Jordan > Reviewed-by: Bob Picco Acked-by: Dav

Re: [PATCH v4 0/7] Add RSS to DPAA 1.x Ethernet driver

2017-08-28 Thread David Miller
From: Madalin Bucur Date: Sun, 27 Aug 2017 16:13:36 +0300 > This patch set introduces Receive Side Scaling for the DPAA Ethernet > driver. Documentation is updated with details related to the new > feature and limitations that apply. > Added also a small fix. > > v2: removed a C++ style comment

Re: [PATCH v3 0/7] Add RSS to DPAA 1.x Ethernet driver

2017-08-24 Thread David Miller
From: David Miller Date: Thu, 24 Aug 2017 09:42:20 -0700 (PDT) > From: Madalin Bucur > Date: Thu, 24 Aug 2017 10:28:21 +0300 > >> This patch set introduces Receive Side Scaling for the DPAA Ethernet >> driver. Documentation is updated with details related to the new >&

Re: [PATCH v3 0/7] Add RSS to DPAA 1.x Ethernet driver

2017-08-24 Thread David Miller
From: Madalin Bucur Date: Thu, 24 Aug 2017 10:28:21 +0300 > This patch set introduces Receive Side Scaling for the DPAA Ethernet > driver. Documentation is updated with details related to the new > feature and limitations that apply. > Added also a small fix. > > v2: removed a C++ style comment

Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen

2017-08-22 Thread David Miller
From: Madalin-cristian Bucur Date: Wed, 23 Aug 2017 04:36:56 + > The struct fman is only visible in the fman file, the fman port > module uses struct fman as an opaque pointer, thus this export. Don't use that programming model. Export the datastructure properly to it's users. This abstrac

Re: [PATCH v2 1/6] fsl/fman: enable FMan Keygen

2017-08-22 Thread David Miller
From: Madalin Bucur Date: Tue, 22 Aug 2017 20:31:01 +0300 > /** > + * fman_get_keygen > + * > + * @fman:A Pointer to FMan device > + * > + * Get the handle to KeyGen module part of FM driver > + * > + * Return: Handle to KeyGen > + */ > +struct fman_keygen *fman_get_keygen(struct fman *fman)

Re: [PATCH] net: ethernet: freescale: fs_enet: make mdiobb_ops const

2017-08-22 Thread David Miller
From: Bhumika Goyal Date: Tue, 22 Aug 2017 13:45:59 +0530 > Make this const as it is only stored in a const field of a > mdiobb_ctrl structure. > > Signed-off-by: Bhumika Goyal Applied.

Re: RCU lockup issues when CONFIG_SOFTLOCKUP_DETECTOR=n - any one else seeing this?

2017-08-21 Thread David Miller
From: Nicholas Piggin Date: Tue, 22 Aug 2017 00:19:28 +1000 > Thanks here's an updated version with a couple more bugs fixed. If > you could try testing, that would be much appreciated. I'm not getting RCU stalls on sparc64 any longer with this patch. I'm really happy you guys were able to figu

Re: [PATCH 4/6] dpaa_eth: add NETIF_F_RXHASH

2017-08-21 Thread David Miller
From: Madalin Bucur Date: Fri, 18 Aug 2017 11:56:26 +0300 > + if (net_dev->features & NETIF_F_RXHASH && priv->keygen_in_use && > + !fman_port_get_hash_result_offset(priv->mac_dev->port[RX], > + &hash_offset)) > + skb_set_hash(skb,

Re: RCU lockup issues when CONFIG_SOFTLOCKUP_DETECTOR=n - any one else seeing this?

2017-08-19 Thread David Miller
From: Nicholas Piggin Date: Sun, 20 Aug 2017 14:45:53 +1000 > [PATCH] timers: Fix excessive granularity of new timers after a nohz idle I just booted into this on my sparc64 box, let's see if it does the trick :-)

Re: [PATCH] net: ibm: ibmvnic: constify vio_device_id

2017-08-17 Thread David Miller
From: Arvind Yadav Date: Thu, 17 Aug 2017 18:52:54 +0530 > vio_device_id are not supposed to change at runtime. All functions > working with vio_device_id provided by work with > const vio_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Applied.

Re: [PATCH] net: ibm: ibmveth: constify vio_device_id

2017-08-17 Thread David Miller
From: Arvind Yadav Date: Thu, 17 Aug 2017 18:52:53 +0530 > vio_device_id are not supposed to change at runtime. All functions > working with vio_device_id provided by work with > const vio_device_id. So mark the non-const structs as const. > > Signed-off-by: Arvind Yadav Applied.

Re: [PATCH net-next] fsl/fman: implement several errata workarounds

2017-08-11 Thread David Miller
From: Florinel Iordache Date: Thu, 10 Aug 2017 16:47:04 +0300 > Implemented workarounds for the following dTSEC Erratum: > A002, A004, A0012, A0014, A004839 on several operations > that involve MAC CFG register changes: adjust link, > rx pause frames, modify MAC address. > > Signed-off-by: Flori

Re: RCU lockup issues when CONFIG_SOFTLOCKUP_DETECTOR=n - any one else seeing this?

2017-07-28 Thread David Miller
From: Boqun Feng Date: Fri, 28 Jul 2017 20:54:16 +0800 > Hi Jonathan, > > FWIW, there is wakeup-missing issue in swake_up() and swake_up_all(): > > https://marc.info/?l=linux-kernel&m=149750022019663 > > and RCU begins to use swait/wake last year, so I thought this could be > relevant. >

Re: RCU lockup issues when CONFIG_SOFTLOCKUP_DETECTOR=n - any one else seeing this?

2017-07-26 Thread David Miller
From: "Paul E. McKenney" Date: Wed, 26 Jul 2017 16:15:05 -0700 > On Wed, Jul 26, 2017 at 03:45:40PM -0700, David Miller wrote: >> Just out of curiousity, what x86 idle method is your machine using? >> The mwait one or the one which simply uses 'halt'? The m

Re: RCU lockup issues when CONFIG_SOFTLOCKUP_DETECTOR=n - any one else seeing this?

2017-07-26 Thread David Miller
From: "Paul E. McKenney" Date: Wed, 26 Jul 2017 15:36:58 -0700 > And without CONFIG_SOFTLOCKUP_DETECTOR, I see five runs of 24 with RCU > CPU stall warnings. So it seems likely that CONFIG_SOFTLOCKUP_DETECTOR > really is having an effect. Thanks for all of the info Paul, I'll digest this and sc

Re: RCU lockup issues when CONFIG_SOFTLOCKUP_DETECTOR=n - any one else seeing this?

2017-07-26 Thread David Miller
From: "Paul E. McKenney" Date: Wed, 26 Jul 2017 08:49:00 -0700 > On Wed, Jul 26, 2017 at 04:33:40PM +0100, Jonathan Cameron wrote: >> Didn't leave it long enough. Still bad on 4.10-rc7 just took over >> an hour to occur. > > And it is quite possible that SOFTLOCKUP_DETECTOR=y and HZ_PERIODIC=y >

Re: RCU lockup issues when CONFIG_SOFTLOCKUP_DETECTOR=n - any one else seeing this?

2017-07-26 Thread David Miller
From: "Paul E. McKenney" Date: Wed, 26 Jul 2017 07:14:17 -0700 > Dave, any other ideas on what might be causing this or what might be > tested? I was going to go through the changes that happened between v4.12 and now to kernel/timer/tick-sched.c and see if reverting any of those help. But I do

Re: RCU lockup issues when CONFIG_SOFTLOCKUP_DETECTOR=n - any one else seeing this?

2017-07-25 Thread David Miller
From: "Paul E. McKenney" Date: Tue, 25 Jul 2017 20:55:45 -0700 > On Tue, Jul 25, 2017 at 02:10:29PM -0700, David Miller wrote: >> Just to report, turning softlockup back on fixes things for me on >> sparc64 too. > > Very good! > >> The thing about softl

Re: RCU lockup issues when CONFIG_SOFTLOCKUP_DETECTOR=n - any one else seeing this?

2017-07-25 Thread David Miller
From: Jonathan Cameron Date: Wed, 26 Jul 2017 00:52:07 +0800 > On Tue, 25 Jul 2017 08:12:45 -0700 > "Paul E. McKenney" wrote: > >> On Tue, Jul 25, 2017 at 10:42:45PM +0800, Jonathan Cameron wrote: >> > On Tue, 25 Jul 2017 06:46:26 -0700 >> > "Paul E. McKenney" wrote: >> > >> > > On Tue, Jul

Re: [PATCH] tty: Convert to using %pOF instead of full_name

2017-07-18 Thread David Miller
From: Rob Herring Date: Tue, 18 Jul 2017 16:43:34 -0500 > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring For sparc bits: Acked-by

Re: [PATCH] ide: pmac: Convert to using %pOF instead of full_name

2017-07-18 Thread David Miller
From: Rob Herring Date: Tue, 18 Jul 2017 16:43:07 -0500 > Now that we have a custom printf format specifier, convert users of > full_name to use %pOF instead. This is preparation to remove storing > of the full path string for each node. > > Signed-off-by: Rob Herring Acked-by: David S. Miller

Re: [PATCH] net: ibm: ibmveth: constify dev_pm_ops structures.

2017-06-29 Thread David Miller
From: Arvind Yadav Date: Thu, 29 Jun 2017 11:14:50 +0530 > dev_pm_ops are not supposed to change at runtime. All functions > working with dev_pm_ops provided by work with const > dev_pm_ops. So mark the non-const structs as const. > > File size before: >text data bss dec

Re: [PATCH v2] fsl/fman: add dependency on HAS_DMA

2017-06-27 Thread David Miller
From: Madalin Bucur Date: Mon, 26 Jun 2017 18:47:00 +0300 > A previous commit (5567e989198b5a8d) inserted a dependency on DMA > API that requires HAS_DMA to be added in Kconfig. > > Signed-off-by: Madalin Bucur Applied, thank you.

Re: [PATCH net-next] udp: fix poll()

2017-06-23 Thread David Miller
From: Paolo Abeni Date: Fri, 23 Jun 2017 14:19:51 +0200 > Michael reported an UDP breakage caused by the commit b65ac44674dd > ("udp: try to avoid 2 cache miss on dequeue"). > The function __first_packet_length() can update the checksum bits > of the pending skb, making the scratched area out-of-

Re: [PATCH 0/2] fix loadable module for DPAA Ethernet

2017-06-20 Thread David Miller
From: Madalin Bucur Date: Mon, 19 Jun 2017 18:04:15 +0300 > The DPAA Ethernet makes use of a symbol that is not exported. > Address the issue by propagating the dma_ops rather than calling > arch_setup_dma_ops(). Series applied, thanks.

Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread David Miller
From: David Miller Date: Mon, 12 Jun 2017 10:25:25 -0400 (EDT) > From: Yuval Shaia > Date: Mon, 12 Jun 2017 17:15:08 +0300 > >> Make return value void since function never return meaningfull value >> >> Signed-off-by: Yuval Shaia >> Acked-by: S

Re: [PATCH v2] net: phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread David Miller
From: Yuval Shaia Date: Mon, 12 Jun 2017 17:15:08 +0300 > Make return value void since function never return meaningfull value > > Signed-off-by: Yuval Shaia > Acked-by: Sergei Shtylyov > --- > v0 ->v1: > * These files were missing in v0 > * drivers/net/ethernet/renesas/rav

Re: [PATCH v1] net/phy: Make phy_ethtool_ksettings_get return void

2017-06-12 Thread David Miller
From: Yuval Shaia Date: Mon, 12 Jun 2017 10:42:33 +0300 > Make return value void since function never return meaningfull value > > Signed-off-by: Yuval Shaia > Acked-by: Sergei Shtylyov > --- > Re-sending since last time forgot to add netdev-list > v0 ->v1: > * These files were missing i

Re: [PATCH 28/44] sparc: remove arch specific dma_supported implementations

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:53 +0200 > Usually dma_supported decisions are done by the dma_map_ops instance. > Switch sparc to that model by providing a ->dma_supported instance for > sbus that always returns false, and implementations tailored to the sun4u > and sun4v ca

Re: [PATCH 20/44] sparc: implement ->mapping_error

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:45 +0200 > DMA_ERROR_CODE is going to go away, so don't rely on it. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller

Re: [PATCH 27/44] sparc: remove leon_dma_ops

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:52 +0200 > We can just use pci32_dma_ops. > > Btw, given that leon is 32-bit and appears to be PCI based, do even need > the special case for it in get_arch_dma_ops at all? I would need to defer to the LEON developers on that, but they haven'

Re: [PATCH 02/44] ibmveth: properly unwind on init errors

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:27 +0200 > That way the driver doesn't have to rely on DMA_ERROR_CODE, which > is not a public API and going away. > > Signed-off-by: Christoph Hellwig Acked-by: David S. Miller

Re: clean up and modularize arch dma_mapping interface

2017-06-08 Thread David Miller
From: Christoph Hellwig Date: Thu, 8 Jun 2017 15:25:25 +0200 > for a while we have a generic implementation of the dma mapping routines > that call into per-arch or per-device operations. But right now there > still are various bits in the interfaces where don't clearly operate > on these ops.

Re: [PATCH net-next] powerpc: use asm-generic/socket.h as much as possible

2017-06-01 Thread David Miller
From: Stephen Rothwell Date: Wed, 31 May 2017 15:43:37 +1000 > asm-generic/socket.h already has an exception for the differences that > powerpc needs, so just include it after defining the differences. > > Signed-off-by: Stephen Rothwell > --- > arch/powerpc/include/uapi/asm/socket.h | 92 > +

Re: [v3 0/9] parallelized "struct page" zeroing

2017-05-31 Thread David Miller
From: Michal Hocko Date: Wed, 31 May 2017 18:31:31 +0200 > On Tue 30-05-17 13:16:50, Pasha Tatashin wrote: >> >Could you be more specific? E.g. how are other stores done in >> >__init_single_page safe then? I am sorry to be dense here but how does >> >the full 64B store differ from other stores d

Re: [PATCH] Documentation: networking: add DPAA Ethernet document

2017-05-30 Thread David Miller
From: Madalin Bucur Date: Mon, 29 May 2017 09:22:06 +0300 > Signed-off-by: Madalin Bucur > Signed-off-by: Camelia Groza Applied.

Re: [PATCH net-next v2] ibmveth: Support to enable LSO/CSO for Trunk VEA.

2017-05-21 Thread David Miller
From: Sivakumar Krishnasamy Date: Fri, 19 May 2017 05:30:38 -0400 ... > Signed-off-by: Sivakumar Krishnasamy Applied, thanks for the more detailed commit message.

Re: [PATCH net-next] ibmvnic: fix missing unlock on error in __ibmvnic_reset()

2017-05-18 Thread David Miller
From: Wei Yongjun Date: Thu, 18 May 2017 15:24:52 + > From: Wei Yongjun > > Add the missing unlock before return from function __ibmvnic_reset() > in the error handling case. > > Fixes: ed651a10875f ("ibmvnic: Updated reset handling") > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH] dt-bindings: net: move FMan binding

2017-05-15 Thread David Miller
From: Madalin Bucur Date: Mon, 15 May 2017 16:36:38 +0300 > Besides the PPC SoCs, the QorIQ DPAA FMan is also present on ARM SoCs, > moving the device tree binding document into the bindings/net folder. > > Signed-off-by: Madalin Bucur What tree is this targetted at for merging?

Re: [v3 0/9] parallelized "struct page" zeroing

2017-05-12 Thread David Miller
From: Pasha Tatashin Date: Fri, 12 May 2017 13:24:52 -0400 > Right now it is larger, but what I suggested is to add a new optimized > routine just for this case, which would do STBI for 64-bytes but > without membar (do membar at the end of memmap_init_zone() and > deferred_init_memmap() > > #de

Re: [v3 0/9] parallelized "struct page" zeroing

2017-05-12 Thread David Miller
From: Pasha Tatashin Date: Thu, 11 May 2017 16:59:33 -0400 > We should either keep memset() only for deferred struct pages as what > I have in my patches. > > Another option is to add a new function struct_page_clear() which > would default to memset() and to something else on platforms that > d

Re: [v3 0/9] parallelized "struct page" zeroing

2017-05-12 Thread David Miller
From: Pasha Tatashin Date: Thu, 11 May 2017 16:47:05 -0400 > So, moving memset() into __init_single_page() benefits Intel. I am > actually surprised why memset() is so slow on intel when it is called > from memblock. But, hurts SPARC, I guess these membars at the end of > memset() kills the perfo

Re: [v3 0/9] parallelized "struct page" zeroing

2017-05-11 Thread David Miller
From: Michal Hocko Date: Thu, 11 May 2017 10:05:38 +0200 > Anyway, do you agree that doing the struct page initialization along > with other writes to it shouldn't add a measurable overhead comparing > to pre-zeroing of larger block of struct pages? We already have an > exclusive cache line and

Re: [v3 0/9] parallelized "struct page" zeroing

2017-05-10 Thread David Miller
From: Matthew Wilcox Date: Wed, 10 May 2017 10:17:03 -0700 > On Wed, May 10, 2017 at 11:19:43AM -0400, David Miller wrote: >> From: Michal Hocko >> Date: Wed, 10 May 2017 16:57:26 +0200 >> >> > Have you measured that? I do not think it would be super hard to

Re: [v3 0/9] parallelized "struct page" zeroing

2017-05-10 Thread David Miller
From: Pasha Tatashin Date: Wed, 10 May 2017 11:01:40 -0400 > Perhaps you are right, and I will measure on x86. But, I suspect hit > can become unacceptable on some platfoms: there is an overhead of > calling a function, even if it is leaf-optimized, and there is an > overhead in memset() to check

Re: [v3 0/9] parallelized "struct page" zeroing

2017-05-10 Thread David Miller
From: Michal Hocko Date: Wed, 10 May 2017 16:57:26 +0200 > Have you measured that? I do not think it would be super hard to > measure. I would be quite surprised if this added much if anything at > all as the whole struct page should be in the cache line already. We do > set reference count and o

Re: [v2 3/5] mm: add "zero" argument to vmemmap allocators

2017-05-03 Thread David Miller
From: Pavel Tatashin Date: Fri, 24 Mar 2017 15:19:50 -0400 > Allow clients to request non-zeroed memory from vmemmap allocator. > The following two public function have a new boolean argument called zero: > > __vmemmap_alloc_block_buf() > vmemmap_alloc_block() > > When zero is true, memory that

Re: [PATCH net] bnx2x: Align RX buffers

2017-04-30 Thread David Miller
From: Scott Wood Date: Fri, 28 Apr 2017 19:17:41 -0500 > The bnx2x driver is not providing proper alignment on the receive buffers it > passes to build_skb(), causing skb_shared_info to be misaligned. > skb_shared_info contains an atomic, and while PPC normally supports > unaligned accesses, it d

Re: [PATCH] ibmveth: Support to enable LSO/CSO for Trunk VEA.

2017-04-08 Thread David Miller
From: Sivakumar Krishnasamy Date: Fri, 7 Apr 2017 05:57:59 -0400 > Enable largesend and checksum offload for ibmveth configured in trunk mode. > Added support to SKB frag_list in TX path by skb_linearize'ing such SKBs. > > Signed-off-by: Sivakumar Krishnasamy Why is linearization necessary?

Re: [RFC][PATCH] spin loop arch primitives for busy waiting

2017-04-05 Thread David Miller
From: Nicholas Piggin Date: Tue, 4 Apr 2017 13:02:33 +1000 > On Mon, 3 Apr 2017 17:43:05 -0700 > Linus Torvalds wrote: > >> But that depends on architectures having some pattern that we *can* >> abstract. Would some "begin/in-loop/end" pattern like the above be >> sufficient? > > Yes. begin/in

Re: [PATCH] dpaa_eth: use AVOIDBLOCK for Tx confirmation queues

2017-04-01 Thread David Miller
From: Madalin Bucur Date: Thu, 30 Mar 2017 16:24:15 +0300 > The AVOIDBLOCK flag determines the Tx confirmation queues processing > to be redirected to any available CPU when the current one is slow > in processing them. This may result in a higher Tx confirmation > interrupt count but may reduce

Re: [PATCH] fsl/fman: take into account all RGMII modes

2017-04-01 Thread David Miller
From: Madalin Bucur Date: Thu, 30 Mar 2017 16:21:40 +0300 > Accept the internal delay RGMII variants. > > Signed-off-by: Madalin Bucur Applied, thanks.

Re: [PATCH net-next] net: ibmvnic: Remove unused net_stats member from struct ibmvnic_adapter

2017-03-27 Thread David Miller
From: Tobias Klauser Date: Mon, 27 Mar 2017 08:56:59 +0200 > The ibmvnic driver keeps its statistics in net_device->stats, so the > net_stats member in struct ibmvnic_adapter is unused. Remove it. > > Signed-off-by: Tobias Klauser Applied.

Re: [PATCH net-next] net: ibmveth: Remove unused stats member from struct ibmveth_adapter

2017-03-27 Thread David Miller
From: Tobias Klauser Date: Mon, 27 Mar 2017 08:56:15 +0200 > The ibmveth driver keeps its statistics in net_device->stats, so the > stats member in struct ibmveth_adapter is unused. Remove it. > > Signed-off-by: Tobias Klauser Applied.

Re: [v1 0/5] parallelized "struct page" zeroing

2017-03-23 Thread David Miller
From: Matthew Wilcox Date: Thu, 23 Mar 2017 16:26:38 -0700 > On Thu, Mar 23, 2017 at 07:01:48PM -0400, Pavel Tatashin wrote: >> When deferred struct page initialization feature is enabled, we get a >> performance gain of initializing vmemmap in parallel after other CPUs are >> started. However, w

Re: [PATCH] net: ethernet: fs_enet: Remove useless includes

2017-03-16 Thread David Miller
From: Christophe Leroy Date: Thu, 16 Mar 2017 10:18:04 +0100 (CET) > CONFIG_8xx is being deprecated. Since the includes dependent on > CONFIG_8xx are useless, just drop them. > > Signed-off-by: Christophe Leroy Applied.

Re: [PATCH] isdn: hardware: mISDN: Remove reference to CONFIG_8xx

2017-03-16 Thread David Miller
From: Christophe Leroy Date: Thu, 16 Mar 2017 10:18:02 +0100 (CET) > CONFIG_8xx is deprecated and should soon be removed in favor > of CONFIG_PPC_8xx. > Anyway, hfc_multi_8xx.h only uses 8xx I/O ports which are > linked to the CPM1 communication processor included in the 8xx > rather than the 8xx

Re: [net-next v2 00/10] QorIQ DPAA 1 updates

2017-03-12 Thread David Miller
From: Madalin Bucur Date: Thu, 9 Mar 2017 16:36:55 +0200 > This patch set introduces a series of fixes and features to the DPAA 1 > drivers. Besides activating hardware Rx checksum offloading, four traffic > classes are added for Tx traffic prioritisation. > > The changes are also available on t

Re: [PATCH] net: toshiba: ps3_genic_net: use new api ethtool_{get|set}_link_ksettings

2017-03-08 Thread David Miller
From: Philippe Reynes Date: Sun, 5 Mar 2017 23:21:06 +0100 > The ethtool api {get|set}_settings is deprecated. > We move this driver to new api {get|set}_link_ksettings. > > As I don't have the hardware, I'd be very pleased if > someone may test this patch. > > Signed-off-by: Philippe Reynes

<    1   2   3   4   5   6   7   8   9   10   >