Re: [PATCH v2 2/2] net/fsl_pq_mdio: fix computed address for the TBI register

2015-10-13 Thread David Miller
From: Gerlando Falauto Date: Mon, 12 Oct 2015 09:18:41 +0200 > commit afae5ad78b342f401c28b0bb1adb3cd494cb125a > "net/fsl_pq_mdio: streamline probing of MDIO nodes" > > added support for different types of MDIO devices: > 1) Gianfar MDIO nodes that only map the MII registers > 2) Gianfar MDIO

Re: [PATCH v2 1/2] net/fsl_pq_mdio: check TBI address for consistency with mapped range

2015-10-13 Thread David Miller
From: Gerlando Falauto Date: Mon, 12 Oct 2015 09:18:40 +0200 > When configuring the MDIO subsystem it is also necessary to configure > the TBI register. Make sure the TBI is contained within the mapped > register range in order to: > a) make sure the address is computed correctly > b) make users

Re: [v3 2/8] dpaa_eth: add support for DPAA Ethernet

2015-09-25 Thread David Miller
From: Madalin Bucur Date: Thu, 24 Sep 2015 18:00:13 +0300 > +#define DPA_NAPI_WEIGHT 64 This is just the default, so simply use "NAPI_POLL_WEIGHT" rather than defining your own macro unnecessarily for this. > +static int dpa_eth_priv_stop(struct net_device *net_dev) > +{ > + in

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread David Miller
From: Florian Fainelli Date: Thu, 24 Sep 2015 18:39:56 -0700 > On 24/09/15 12:17, Russell King - ARM Linux wrote: >> Hi, >> >> The third version of this series fixes the build error which David >> identified, and drops the broken changes for the Cavium Thunger BGX >> ethernet driver as this driv

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread David Miller
From: Andrew Lunn Date: Fri, 25 Sep 2015 00:26:54 +0200 > On Thu, Sep 24, 2015 at 03:15:54PM -0700, David Miller wrote: >> From: Andrew Lunn >> Date: Thu, 24 Sep 2015 23:57:31 +0200 >> >> > I built the FEC driver as a module, and it won't unload: >

Re: [PATCH v3 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-24 Thread David Miller
From: Andrew Lunn Date: Thu, 24 Sep 2015 23:57:31 +0200 > I built the FEC driver as a module, and it won't unload: > > kernel:unregister_netdevice: waiting for eth1 to become free. Usage count = 1 > unregister_netdevice: waiting for eth1 to become free. Usage count = 1 > > i assume because DSA

Re: [PATCH v2 0/9] Phy, mdiobus, and netdev struct device fixes

2015-09-23 Thread David Miller
From: Russell King - ARM Linux Date: Tue, 22 Sep 2015 17:17:10 +0100 > This is the second version of the series, with the comments David had > on the first patch fixed up. Original series description with updated > diffstat below. This needs some build fixes: drivers/net/ethernet/apm/xgene/xge

Re: [PATCH 0/9] powerpc32: set of optimisation of network checksum functions

2015-09-23 Thread David Miller
From: Christophe Leroy Date: Tue, 22 Sep 2015 16:34:17 +0200 (CEST) > This patch serie gather patches related to checksum functions on powerpc. > Some of those patches have already been submitted individually. I'm assuming that the powerpc folks will integrate this series. Let me know if I shou

Re: [PATCH 1/7] phy: fix of_mdio_find_bus() device refcount leak

2015-09-21 Thread David Miller
From: Russell King - ARM Linux Date: Mon, 21 Sep 2015 20:32:07 +0100 > In the case of the mdio mux code, I'm dropping the reference when > either (a) we've encountered an error during initialisation and > we're cleaning up, or (b) when the mdio mux code is being torn down > after the mdiomux bus

Re: [PATCH 1/7] phy: fix of_mdio_find_bus() device refcount leak

2015-09-21 Thread David Miller
From: Russell King Date: Fri, 18 Sep 2015 10:54:55 +0100 > Update the comment, and arrange for the only user of this function > to drop this refcount when disposing of a reference to it. mdio_mux is not the only user of of_mdio_find_bus(), DSA uses it as well. So if anything this commit message

Re: [PATCH 29/31] parisc: handle page-less SG entries

2015-08-13 Thread David Miller
From: James Bottomley Date: Thu, 13 Aug 2015 20:59:20 -0700 > On Thu, 2015-08-13 at 20:30 -0700, Dan Williams wrote: >> On Thu, Aug 13, 2015 at 7:31 AM, Christoph Hellwig wrote: >> > On Wed, Aug 12, 2015 at 09:01:02AM -0700, Linus Torvalds wrote: >> >> I'm assuming that anybody who wants to use

Re: [PATCH] net: fs_enet: mask interrupts for TX partial frames.

2015-08-11 Thread David Miller
From: Christophe Leroy Date: Tue, 11 Aug 2015 12:11:03 +0200 (CEST) > We are not interested in interrupts for partially transmitted frames. > Unlike SCC and FCC, the FEC doesn't handle the I bit in buffer > descriptors, instead it defines two interrupt bits, TXB and TXF. > > We have to mask TXB

Re: [PATCH] net: fs_enet: explicitly remove I flag on TX partial frames

2015-08-11 Thread David Miller
From: Christophe Leroy Date: Tue, 11 Aug 2015 12:11:00 +0200 (CEST) > We are not interested in interrupts for partially transmitted frames, > we have to clear BD_ENET_TX_INTR explicitly otherwise it may remain > from a previously used descriptor. > > Signed-off-by: Christophe Leroy Applied. __

Re: [v2 8/9] dpaa_eth: add debugfs entries

2015-08-07 Thread David Miller
From: Madalin Bucur Date: Wed, 5 Aug 2015 18:41:28 +0300 > Export per CPU counters through debugfs. > > Signed-off-by: Madalin Bucur This is absolutely inappropriate. You can export these just fine via ethtool statistics. There is zero reason to add ugly debugfs crap for something like this.

Re: [v4, 0/9] Freescale DPAA FMan

2015-08-07 Thread David Miller
From: Date: Wed, 5 Aug 2015 12:25:16 +0300 > The Freescale Data Path Acceleration Architecture (DPAA) > is a set of hardware components on specific QorIQ multicore processors. > This architecture provides the infrastructure to support simplified > sharing of networking interfaces and accelerators

Re: [PATCH 03/10] dpaa_eth: add configurable bpool thresholds

2015-07-26 Thread David Miller
From: Madalin-Cristian Bucur Date: Fri, 24 Jul 2015 15:49:39 + >> -Original Message- >> From: Joe Perches [mailto:j...@perches.com] >> On Wed, 2015-07-22 at 19:16 +0300, Madalin Bucur wrote: >> > Allow the user to tweak the refill threshold and the total number >> > of buffers in the

Re: [PATCH v2] openvswitch: allocate nr_node_ids flow_stats instead of num_possible_nodes

2015-07-21 Thread David Miller
From: Chris J Arges Date: Tue, 21 Jul 2015 12:36:33 -0500 > Some architectures like POWER can have a NUMA node_possible_map that > contains sparse entries. This causes memory corruption with openvswitch > since it allocates flow_cache with a multiple of num_possible_nodes() and > assumes the node

Re: [PATCH net-next] ibmveth: add support for TSO6

2015-07-15 Thread David Miller
From: Thomas Falcon Date: Tue, 14 Jul 2015 10:51:51 -0500 > This patch adds support for a new method of signalling the firmware > that TSO packets are being sent. The new method removes the need to > alter the ip and tcp checksums and allows TSO6 support. > > Signed-off-by: Thomas Falcon Appli

Re: [PATCH v2 1/1] net: fs_enet: Fix NETIF_F_SG feature for Freescale MPC5121

2015-06-23 Thread David Miller
From: Alexander Popov Date: Sun, 21 Jun 2015 01:32:46 +0300 > Commit 4fc9b87bae25 ("net: fs_enet: Implement NETIF_F_SG feature") > brings a trouble to Freescale MPC512x: a kernel oops happens > during sending non-linear sk_buff with .data not aligned by 4. > > Log quotation: ... > The reason: >

Re: [PATCH 1/1 linux-next] net: fs_enet: use swap() in fs_enet_rx_napi()

2015-06-11 Thread David Miller
From: Fabian Frederick Date: Wed, 10 Jun 2015 18:33:19 +0200 > Use kernel.h macro definition. > > Thanks to Julia Lawall for Coccinelle scripting support. > > Signed-off-by: Fabian Frederick Applied. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.

Re: [PATCH] net/ps3_gelic: Fix build error with DEBUG

2015-06-11 Thread David Miller
From: Geoff Levand Date: Wed, 10 Jun 2015 10:19:48 -0700 > When the DEBUG preprocessor macro is defined the ps3_gelic_net driver build > fails due to an undeclared routine gelic_descr_get_status(). This problem > was introduced during the code cleanup of commit > 6b0c21cede22be1f68f0a632c0ca3800

Re: [PATCH 1/1] net: fs_enet: Disable NETIF_F_SG feature for Freescale MPC5121

2015-06-09 Thread David Miller
From: Alexander Popov Date: Wed, 10 Jun 2015 02:57:42 +0300 > skb_copy_from_linear_data() which doesn't work well for non-linear sk_buff: The correct fix is to use an SKB copy routine which can handle non-linear data. ___ Linuxppc-dev mailing list Lin

Re: [PATCH net-next v3 4/4] ibmveth: Add support for Large Receive Offload

2015-04-30 Thread David Miller
From: Thomas Falcon Date: Wed, 29 Apr 2015 16:25:47 -0500 > Enables receiving large packets from other LPARs. These packets > have a -1 IP header checksum, so we must recalculate to have > a valid checksum. > > Signed-off-by: Brian King > Signed-off-by: Thomas Falcon > --- > v3: > -Removed co

Re: [PATCH net-next v3 3/4] ibmveth: Add GRO support

2015-04-30 Thread David Miller
From: Thomas Falcon Date: Wed, 29 Apr 2015 16:25:46 -0500 > Cc: Brian King > Signed-off-by: Thomas Falcon Applied. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH net-next v3 2/4] ibmveth: Add support for TSO

2015-04-30 Thread David Miller
From: Thomas Falcon Date: Wed, 29 Apr 2015 16:25:45 -0500 > Add support for TSO. TSO is turned off by default and > must be enabled and configured by the user. The driver > version number is increased so that users can be sure > that they are using ibmveth with TSO support. > > Cc: Brian King

Re: [PATCH net-next v3 1/4] ibmveth: change rx buffer default allocation for CMO

2015-04-30 Thread David Miller
From: Thomas Falcon Date: Wed, 29 Apr 2015 16:25:44 -0500 > This patch enables 64k rx buffer pools by default. If Cooperative > Memory Overcommitment (CMO) is enabled, the number of 64k buffers > is reduced to save memory. > > Cc: Brian King > Signed-off-by: Thomas Falcon Applied. __

Re: [PATCH] ehea: Fix memory hook reference counting crashes

2015-04-25 Thread David Miller
From: Michael Ellerman Date: Fri, 24 Apr 2015 15:52:32 +1000 > The recent commit to only register the EHEA memory hotplug hooks on > adapter probe has a few problems. > > Firstly the reference counting is wrong for multiple adapters, in that > the hooks are registered multiple times. Secondly th

Re: [PATCHv2] ibmveth: Fix off-by-one error in ibmveth_change_mtu()

2015-04-23 Thread David Miller
From: David Gibson Date: Thu, 23 Apr 2015 14:43:05 +1000 > AFAIK the PAPR document which defines the virtual device interface used by > the ibmveth driver doesn't specify a specific maximum MTU. So, in the > ibmveth driver, the maximum allowed MTU is determined by the maximum > allocated buffer

Re: sparc64: Build failure due to commit f1600e549b94 (sparc: Make sparc64 use scalable lib/iommu-common.c functions)

2015-04-20 Thread David Miller
From: Guenter Roeck Date: Mon, 20 Apr 2015 09:44:31 -0700 > On Mon, Apr 20, 2015 at 12:25:19PM -0400, David Miller wrote: >> From: Guenter Roeck >> Date: Sun, 19 Apr 2015 22:17:21 -0700 >> >> > The debug option is intended for all _other_ architectures, to >

Re: sparc64: Build failure due to commit f1600e549b94 (sparc: Make sparc64 use scalable lib/iommu-common.c functions)

2015-04-20 Thread David Miller
From: Guenter Roeck Date: Sun, 19 Apr 2015 22:17:21 -0700 > The debug option is intended for all _other_ architectures, to > ensure that changes made for those don't break alpha/s390 > builds. alpha/s390 have ARCH_NEEDS_WEAK_PER_CPU and don't need the > debug option. Ironically this would not cr

Re: [PATCH v10 0/3] Generic IOMMU pooled allocator

2015-04-16 Thread David Miller
From: Sowmini Varadhan Date: Thu, 9 Apr 2015 15:33:29 -0400 > Investigation of network performance on Sparc shows a high > degree of locking contention in the IOMMU allocator, and it > was noticed that the PowerPC code has a better locking model. > > This patch series tries to extract the gener

Re: [PATCH 1/5] ibmveth: change rx buffer default allocation for CMO

2015-04-14 Thread David Miller
The net-next tree is closed, so new feature submissions are not appropriate at this time. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v10 0/3] Generic IOMMU pooled allocator

2015-04-09 Thread David Miller
From: Sowmini Varadhan Date: Thu, 9 Apr 2015 15:33:29 -0400 > v10: resend patchv9 without RFC tag, and a new mail Message-Id, > (previous non-RFC attempt did not show up on the patchwork queue?) Yes, if the patch is identical the patch postings hashes to the same value as the RFC ones, and ther

Re: [PATCH v8 RFC 1/3] sparc: Break up monolithic iommu table/lock into finer graularity pools and lock

2015-04-02 Thread David Miller
From: Sowmini Varadhan Date: Thu, 2 Apr 2015 17:54:53 -0400 > the other question that comes to my mind is: the whole lazy_flush > optimization probably works best when there is exactly one pool, > and no large pools. In most other cases, we'd end up doing a lazy_flush > when we wrap within our po

Re: [PATCH v8 RFC 0/3] Generic IOMMU pooled allocator

2015-04-02 Thread David Miller
From: Sowmini Varadhan Date: Thu, 2 Apr 2015 08:51:52 -0400 > do I need to resubmit this without the RFC tag? Perhaps I should > have dropped that some time ago. I want to hear from the powerpc folks whether they can positively adopt the new generic code or not. _

Re: [PATCH v2 1/3] envctrl: Ignore orderly_poweroff return value

2015-04-01 Thread David Miller
From: Joel Stanley Date: Wed, 1 Apr 2015 17:34:46 +1030 > orderly_poweroff() unconditionally returns 0, so remove the dead code > that checks the return value. > > A future patch will change the return type to void. > > Signed-off-by: Joel Stanley Acked-by: David S. Miller _

Re: [PATCH v8 RFC 0/3] Generic IOMMU pooled allocator

2015-03-31 Thread David Miller
From: Sowmini Varadhan Date: Tue, 31 Mar 2015 21:08:18 -0400 > I'm starting to wonder if some approximation of dma premapped > buffers may be needed. Doing a map/unmap on each packet is expensive. It's much more amortized with smart buffering strategies, which are common on current generation n

Re: [PATCH v8 RFC 0/3] Generic IOMMU pooled allocator

2015-03-31 Thread David Miller
From: Sowmini Varadhan Date: Tue, 31 Mar 2015 14:06:42 -0400 > Having bravely said that.. > > the IB team informs me that they see a 10% degradation using > the spin_lock as opposed to the trylock. > > one path going forward is to continue processing this patch-set > as is. I can investigate

Re: Generic IOMMU pooled allocator

2015-03-26 Thread David Miller
From: casca...@linux.vnet.ibm.com Date: Wed, 25 Mar 2015 21:43:42 -0300 > On Mon, Mar 23, 2015 at 10:15:08PM -0400, David Miller wrote: >> From: Benjamin Herrenschmidt >> Date: Tue, 24 Mar 2015 13:08:10 +1100 >> >> > For the large pool, we don't keep a hint

Re: [PATCH v7 0/3] Generic IOMMU pooled allocator

2015-03-25 Thread David Miller
From: Sowmini Varadhan Date: Wed, 25 Mar 2015 13:34:45 -0400 > Changes from patchv6: moved pool_hash initialization to > lib/iommu-common.c and cleaned up code duplication from > sun4v/sun4u/ldc. Looks good to me. PowerPC folks, what do you think? _

Re: [PATCH v6 0/3] Generic IOMMU pooled allocator

2015-03-24 Thread David Miller
From: Sowmini Varadhan Date: Tue, 24 Mar 2015 13:10:27 -0400 > Deltas from patchv5: > - removed iommu_tbl_ops, and instead pass the ->flush_all as > an indirection to iommu_tbl_pool_init() > - only invoke ->flush_all when there is no large_pool, based on > the assumption that large-pool usage

Re: Generic IOMMU pooled allocator

2015-03-23 Thread David Miller
From: Benjamin Herrenschmidt Date: Tue, 24 Mar 2015 13:08:10 +1100 > For the large pool, we don't keep a hint so we don't know it's > wrapped, in fact we purposefully don't use a hint to limit > fragmentation on it, but then, it should be used rarely enough that > flushing always is, I suspect, a

Re: Generic IOMMU pooled allocator

2015-03-23 Thread David Miller
From: Benjamin Herrenschmidt Date: Tue, 24 Mar 2015 09:21:05 +1100 > Dave, what's your feeling there ? Does anybody around still have > some HW that we can test with ? I don't see what the actual problem is. Even if you use multiple pools, which we should for scalability on sun4u too, just do t

Re: Generic IOMMU pooled allocator

2015-03-23 Thread David Miller
From: Sowmini Varadhan Date: Mon, 23 Mar 2015 12:54:06 -0400 > If it was only an optimization (i.e., removing it would not break > any functionality), and if this was done for older hardware, > and *if* we believe that the direction of most architectures is to > follow the sun4v/HV model, then,

Re: Generic IOMMU pooled allocator

2015-03-23 Thread David Miller
From: Sowmini Varadhan Date: Sun, 22 Mar 2015 15:27:26 -0400 > That leaves only the odd iommu_flushall() hook, I'm trying > to find the history behind that (needed for sun4u platforms, > afaik, and not sure if there are other ways to achieve this). In order to elide the IOMMU flush as much as po

Re: Generic IOMMU pooled allocator

2015-03-18 Thread David Miller
From: Benjamin Herrenschmidt Date: Thu, 19 Mar 2015 13:46:15 +1100 > Sounds like a good idea ! CC'ing Anton who wrote the pool stuff. I'll > try to find somebody to work on that here & will let you know asap. Thanks a lot Ben. ___ Linuxppc-dev mailing

Generic IOMMU pooled allocator

2015-03-18 Thread David Miller
PowerPC folks, we're trying to kill the locking contention in our IOMMU allocators and noticed that you guys have a nice solution to this in your IOMMU code. Sowmini put together a patch series that tries to extract out the generic parts of your code and place it in lib/iommu-common.c so that bot

Re: [PATCH 00/16 linux-next] drivers/net: constify of_device_id array

2015-03-17 Thread David Miller
From: Fabian Frederick Date: Tue, 17 Mar 2015 19:37:31 +0100 > This small patchset adds const to of_device_id arrays in > drivers/net branch. Series applied, thanks. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/l

Re: [PATCH 7/8] isdn: replace CONFIG_8xx by CONFIG_PPC_8xx

2015-03-12 Thread David Miller
From: Christophe Leroy Date: Thu, 12 Mar 2015 16:24:09 +0100 (CET) > Two config options exist to define powerpc MPC8xx: > * CONFIG_PPC_8xx > * CONFIG_8xx > In addition, CONFIG_PPC_8xx also defines CONFIG_CPM1 as > communication co-processor > > arch/powerpc/platforms/Kconfig.cputype has containe

Re: [PATCH 4/8] net: freescale: replace CONFIG_8xx by CONFIG_PPC_8xx

2015-03-12 Thread David Miller
From: Christophe Leroy Date: Thu, 12 Mar 2015 16:23:54 +0100 (CET) > Two config options exist to define powerpc MPC8xx: > * CONFIG_PPC_8xx > * CONFIG_8xx > In addition, CONFIG_PPC_8xx also defines CONFIG_CPM1 as > communication co-processor > > arch/powerpc/platforms/Kconfig.cputype has containe

Re: [PATCH v3] ibmveth: Add function to enable live MAC address changes

2015-03-03 Thread David Miller
From: Thomas Falcon Date: Mon, 2 Mar 2015 11:56:12 -0600 > Add a function that will enable changing the MAC address > of an ibmveth interface while it is still running. > > Signed-off-by: Thomas Falcon Applied, thanks. ___ Linuxppc-dev mailing list

Re: [PATCH] ibmveth: Add function to enable live MAC address changes

2015-02-27 Thread David Miller
From: Thomas Falcon Date: Wed, 25 Feb 2015 18:34:24 -0600 > Add a function that will enable changing the MAC address > of an ibmveth interface while it is still running. > > Signed-off-by: Thomas Falcon > --- > drivers/net/ethernet/ibm/ibmveth.c | 20 +++- > 1 file changed, 19

Re: bpf: Enable BPF JIT on ppc32

2015-02-20 Thread David Miller
aFrom: Denis Kirjanov Date: Tue, 17 Feb 2015 10:04:37 +0300 > This patch series enables BPF JIT on ppc32. There are relatevily > few chnages in the code to make it work. > > All test_bpf tests passed both on 7447a and P2041-based machines. > > Changelog: > v1 - > v2: Reordered Kconfig patch in

Re: bpf: Enable BPF JIT on ppc32

2015-02-19 Thread David Miller
From: Denis Kirjanov Date: Tue, 17 Feb 2015 10:04:37 +0300 > This patch series enables BPF JIT on ppc32. There are relatevily > few chnages in the code to make it work. > > All test_bpf tests passed both on 7447a and P2041-based machines. > > Changelog: > v1 - > v2: Reordered Kconfig patch in t

Re: [PATCH RFC] Update kernel math-emu code from current glibc soft-fp

2015-02-19 Thread David Miller
From: Joseph Myers Date: Thu, 19 Feb 2015 18:40:34 + > On Thu, 19 Feb 2015, David Miller wrote: > >> From: Joseph Myers >> Date: Fri, 6 Feb 2015 17:25:29 + >> >> > * On SPARC, comparisons now use raw unpacking (this should not in fact >> > c

Re: [PATCH net-next 1/6] ppc: Kconfig: Enable BPF JIT on ppc32

2015-02-15 Thread David Miller
From: Joe Perches Date: Sun, 15 Feb 2015 10:15:54 -0800 > On Sun, 2015-02-15 at 21:06 +0300, Denis Kirjanov wrote: > [] >> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > [] >> @@ -126,7 +126,7 @@ config PPC >> select IRQ_FORCED_THREADING >> select HAVE_RCU_TABLE_FREE if SMP

Re: [PATCH] net: fs_enet: Implement NETIF_F_SG feature

2015-02-04 Thread David Miller
From: Christophe Leroy Date: Mon, 2 Feb 2015 18:06:54 +0100 (CET) > Freescale ethernet controllers have the capability to re-assemble fragmented > data into a single ethernet frame. This patch uses this capability and > implements NETIP_F_SG feature into the fs_enet ethernet driver. > > On a MP

Re: [PATCH v3] net/fsl_pq_mdio: Document supported compatibles

2015-02-03 Thread David Miller
From: Emil Medve Date: Sun, 1 Feb 2015 15:58:31 -0600 > From: Shruti Kanetkar > > The device tree binding(s) document has fallen out of sync with the > driver code. Update the list of supported devices to reflect current > driver capabilities > > Change-Id: I440d8de2ee2d9c3b7b23e69b3da851cab18

Re: [PATCH net-next] PPC: bpf_jit_comp: Unify BPF_MOD | BPF_X and BPF_DIV | BPF_X

2014-11-18 Thread David Miller
From: Alexei Starovoitov Date: Tue, 18 Nov 2014 07:37:21 -0800 > On Mon, Nov 17, 2014 at 10:58 PM, Denis Kirjanov > wrote: >> Hi Michael, >> >> This patch added no new functionality so I haven't put the test >> results (of course I ran the test suite to check the patch). >> >> The output : >> [

Re: [PATCH v2 net-next] PPC: bpf_jit_comp: add SKF_AD_HATYPE instruction

2014-11-11 Thread David Miller
From: Denis Kirjanov Date: Mon, 10 Nov 2014 08:59:43 +0300 > Add BPF extension SKF_AD_HATYPE to ppc JIT to check > the hw type of the interface > > Before: > [ 57.723666] test_bpf: #20 LD_HATYPE > [ 57.723675] BPF filter opcode 0020 (@0) unsupported > [ 57.724168] 48 48 PASS > > After: >

Re: [PATCH net-next] PPC: bpf_jit_comp: add SKF_AD_HATYPE instruction

2014-11-07 Thread David Miller
From: Denis Kirjanov Date: Thu, 6 Nov 2014 09:02:35 +0300 > Add BPF extension SKF_AD_HATYPE to ppc JIT to check > the hw type of the interface > > JIT off: > [ 69.106783] test_bpf: #20 LD_HATYPE 48 48 PASS > JIT on: > [ 64.721757] test_bpf: #20 LD_HATYPE 7 6 PASS > > CC: Alexei Starovoitov

Re: [PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction

2014-11-03 Thread David Miller
From: Alexei Starovoitov Date: Mon, 3 Nov 2014 09:21:03 -0800 > On Mon, Nov 3, 2014 at 9:06 AM, David Miller wrote: >> From: Denis Kirjanov >> Date: Thu, 30 Oct 2014 09:12:15 +0300 >> >>> Add BPF extension SKF_AD_PKTTYPE to ppc JIT to load >>&

Re: [PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction

2014-11-03 Thread David Miller
From: Denis Kirjanov Date: Thu, 30 Oct 2014 09:12:15 +0300 > Add BPF extension SKF_AD_PKTTYPE to ppc JIT to load > skb->pkt_type field. > > Before: > [ 88.262622] test_bpf: #11 LD_IND_NET 86 97 99 PASS > [ 88.265740] test_bpf: #12 LD_PKTTYPE 109 107 PASS > > After: > [ 80.605964] test_bpf

Re: [PATCH V4 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-11-01 Thread David Miller
From: "Aneesh Kumar K.V" Date: Wed, 29 Oct 2014 13:49:44 +0530 > Update generic gup implementation with powerpc specific details. > On powerpc at pmd level we can have hugepte, normal pmd pointer > or a pointer to the hugepage directory. > > Signed-off-by: Aneesh Kumar K.V > --- > Changes from

Re: [PATCH V4 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-11-01 Thread David Miller
From: "Aneesh Kumar K.V" Date: Wed, 29 Oct 2014 13:49:44 +0530 > +/* > + * Some architectures requires a hugepage directory format that is > + * required to support multiple hugepage sizes. For example > + * a4fe3ce7699bfe1bd88f816b55d42d8fe1dac655 introduced the same > + * on powerpc. This allow

Re: [PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction

2014-11-01 Thread David Miller
From: Denis Kirjanov Date: Sat, 1 Nov 2014 21:49:27 +0400 > David, you need a feedback from other guys to apply this patch, right? > > Alexei wanted some output before/after the patch. > Michael Ellerman wanted the explanation what a BPF_ANC | SKF_AD_PKTTYPE means. > So I'm waiting the ack/nack

Re: [PATCH v2] PPC: bpf_jit_comp: add SKF_AD_PKTTYPE instruction

2014-11-01 Thread David Miller
From: Denis Kirjanov Date: Sat, 1 Nov 2014 20:19:09 +0400 > ping What specifically are you waiting for? ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH V2 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-23 Thread David Miller
From: Benjamin Herrenschmidt Date: Fri, 24 Oct 2014 10:40:35 +1100 > Another option would be to make the generic code use something defined > by the arch to decide whether to use speculative get or > not. I like the idea of keeping the bulk of that code generic... Me too. We could have inlines

Re: [PATCH V2 1/2] mm: Update generic gup implementation to handle hugepage directory

2014-10-23 Thread David Miller
Hey guys, was looking over the generic GUP while working on a sparc64 issue and I noticed that you guys do speculative page gets, and after talking with Johannes Weiner (CC:'d) about this we don't see how it could be necessary. If interrupts are disabled during the page table scan (which they are

Re: [PATCH] net: fs_enet: set back promiscuity mode after restart

2014-10-22 Thread David Miller
From: Christophe Leroy Date: Wed, 22 Oct 2014 09:05:47 +0200 (CEST) > After interface restart (eg: after link disconnection/reconnection), the > bridge > function doesn't work anymore. This is due to the promiscuous mode being > cleared > by the restart. > > The mac-fcc already includes code t

Re: [PATCH v3 25/27] Sparc/MSI: Use MSI chip framework to configure MSI/MSI-X irq

2014-10-14 Thread David Miller
From: Yijing Wang Date: Wed, 15 Oct 2014 11:07:13 +0800 > Use MSI chip framework instead of arch MSI functions to configure > MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework. > > Signed-off-by: Yijing Wang Acked-by: David S. Miller

Re: [PATCH] net: fs_enet: error: 'SCCE_ENET_TXF' undeclared

2014-10-09 Thread David Miller
From: Christophe Leroy Date: Thu, 9 Oct 2014 16:54:43 +0200 (CEST) > [linux-devel:devel-hourly-2014100909 3763/3915] > drivers/net/ethernet/freescale/fs_enet/mac-scc.c:119:32: error: > 'SCCE_ENET_TXF' undeclared > > Due to patch d43a396 net: fs_enet: Add NAPI TX, it appears that some target >

Re: [PATCH 0/2] net: fs_enet: Remove non NAPI RX and add NAPI for TX

2014-10-08 Thread David Miller
From: Christophe Leroy Date: Tue, 7 Oct 2014 15:04:53 +0200 (CEST) > When using a MPC8xx as a router, 'perf' shows a significant time spent in > fs_enet_interrupt() and fs_enet_start_xmit(). > 'perf annotate' shows that the time spent in fs_enet_start_xmit is indeed > spent > between spin_unlo

Re: [PATCH] ibmveth: Fix endian issues with rx_no_buffer statistic

2014-08-22 Thread David Miller
From: Anton Blanchard Date: Fri, 22 Aug 2014 11:36:52 +1000 > Hidden away in the last 8 bytes of the buffer_list page is a solitary > statistic. It needs to be byte swapped or else ethtool -S will > produce numbers that terrify the user. > > Since we do this in multiple places, create a helper f

Re: [PATCH] net: ucc_geth: fix build failure

2014-08-10 Thread David Miller
From: Uwe Kleine-König Date: Sun, 10 Aug 2014 20:32:05 +0200 > My series to fix the reference counting of dt nodes introduced a build > failure. Fix it. > > Fixes: fa310789a488 ("net: ucc_geth: drop acquired references in probe error > path and remove") > Signed-off-by: Uwe Kleine-König Appli

Re: [PATCH 1/3] net: ucc_geth: drop acquired references in probe error path and remove

2014-08-08 Thread David Miller
From: Uwe Kleine-König Date: Fri, 8 Aug 2014 22:34:56 +0200 > @davem: Should I send a fixup or a new version? Fixup, please. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 3/3] net: ucc_geth: Don't use the MAC as PHY without a fixed link

2014-08-07 Thread David Miller
From: Uwe Kleine-König Date: Thu, 7 Aug 2014 23:48:26 +0200 > This matches what the other drivers using fixed-link support do and > restores the behaviour before commit 87009814cdbb ("ucc_geth: use the > new fixed PHY helpers") for the affected device trees (i.e. no > phy-handle and no fixed-lin

Re: [PATCH 2/3] net: ucc_geth: make probe consistently acquire a reference to the phy node

2014-08-07 Thread David Miller
From: Uwe Kleine-König Date: Thu, 7 Aug 2014 23:48:25 +0200 > When the driver attaches to a device that has a phy handle the probe > routine returns with a reference to that node. This reference is > correctly dropped in the error path and the remove function. In the > fixed phy case however no

Re: [PATCH 1/3] net: ucc_geth: drop acquired references in probe error path and remove

2014-08-07 Thread David Miller
From: Uwe Kleine-König Date: Thu, 7 Aug 2014 23:48:24 +0200 > The ucc_geth_probe function assigns to ug_info->tbi_node and > ug_info->phy_node a value returned by of_parse_phandle which returns a > new reference. Put this reference again in the error path of > ucc_geth_probe and when removing th

Re: [PATCH] net: fs_enet: fix reference counting for phy_node

2014-08-07 Thread David Miller
From: Uwe Kleine-König Date: Thu, 7 Aug 2014 23:06:00 +0200 > Make sure that fs_enet_probe is left with a reference to the phy node. > In the presence of a phy handle this is already the case as > of_parse_phandle returns a reference. In the fixed phy case a call to > of_node_get is necessary. O

Re: [PATCH 00/30] drivers/net: remove unnecessary break after return

2014-07-20 Thread David Miller
From: Fabian Frederick Date: Sun, 20 Jul 2014 16:16:08 +0200 > Second patchset after "remove unnecessary break after goto" addressing break > redundancy on drivers/net branch > (suggested by Joe Perches) All applied except the i40e patch, which did not apply to net-next at all.

Re: [PATCH v2 2/2] powerpc: bpf: Fix the broken LD_VLAN_TAG_PRESENT test

2014-06-27 Thread David Miller
From: Denis Kirjanov Date: Wed, 25 Jun 2014 21:34:57 +0400 > We have to return the boolean here if the tag presents > or not, not just ANDing the TCI with the mask which results to: > > [ 709.412097] test_bpf: #18 LD_VLAN_TAG_PRESENT > [ 709.412245] ret 4096 != 1 > [ 709.412332] ret 4096 != 1

Re: [PATCH v2 1/2] powerpc: bpf: Use correct mask while accessing the VLAN tag

2014-06-27 Thread David Miller
From: Denis Kirjanov Date: Wed, 25 Jun 2014 21:34:56 +0400 > To get a full tag (and not just a VID) we should access the TCI > except the VLAN_TAG_PRESENT field (which means that 802.1q header > is present). Also ensure that the VLAN_TAG_PRESENT stay on its place > > Signed-off-by: Denis Kirjano

Re: [PATCH 2/2] powerpc/8xx: Remove empty asm/mpc8xx.h

2014-06-20 Thread David Miller
From: Scott Wood Date: Fri, 20 Jun 2014 20:02:07 -0500 > m8xx_pcmcia_ops was the only thing in this file (other than a comment > that describes a usage that doesn't match the file's contents); now > that m8xx_pcmcia_ops is gone, remove the empty file. > > Signed-off-by: Scott Wood For networki

Re: [PATCH net-next v2 0/9] net: of_phy_connect_fixed_link removal

2014-05-22 Thread David Miller
From: Florian Fainelli Date: Thu, 22 May 2014 09:47:42 -0700 > This patch set removes of_phy_connect_fixed_link() from the tree now that > we have a better solution for dealing with fixed PHY (emulated PHY) devices > for drivers that require them. > > First two patches update the 'fixed-link' De

Re: [PATCH RESEND 0/9 net-next] net: of_phy_connect_fixed_link removal

2014-05-22 Thread David Miller
Please address Sergei's feedback, except the indentation one which as you stated is correct. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] [resend] net: get rid of SET_ETHTOOL_OPS

2014-05-13 Thread David Miller
From: Wilfried Klaebe Date: Sun, 11 May 2014 00:12:32 + > net: get rid of SET_ETHTOOL_OPS > > Dave Miller mentioned he'd like to see SET_ETHTOOL_OPS gone. > This does that. > > Mostly done via coccinelle script: > @@ > struct ethtool_ops *ops; > struct net_device *dev; > @@ > - SET_ET

Re: [PATCH 07/13] sparc/PCI: Use new pci_is_bridge() to simplify code

2014-04-25 Thread David Miller
From: Yijing Wang Date: Fri, 25 Apr 2014 17:18:29 +0800 > Now we can use new pci_is_bridge() helper function > to simplify code. > > Signed-off-by: Yijing Wang Acked-by: David S. Miller ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org htt

Re: [PATCH V2 1/2] mm: move FAULT_AROUND_ORDER to arch/

2014-04-04 Thread David Miller
From: Dave Hansen Date: Fri, 04 Apr 2014 09:18:43 -0700 > On 04/03/2014 11:27 PM, Madhavan Srinivasan wrote: >> This patch creates infrastructure to move the FAULT_AROUND_ORDER >> to arch/ using Kconfig. This will enable architecture maintainers >> to decide on suitable FAULT_AROUND_ORDER value b

Re: [PATCH v2] phy/at8031: enable at8031 to work on interrupt mode

2014-03-29 Thread David Miller
From: Zhao Qiang Date: Fri, 28 Mar 2014 15:39:41 +0800 > The at8031 can work on polling mode and interrupt mode. > Add ack_interrupt and config intr funcs to enable > interrupt mode for it. > > Signed-off-by: Zhao Qiang > --- > changes for v2: > - when interrupt is not enabled, write 0 to

Re: rfc: checkpatch logical line continuations

2014-03-07 Thread David Miller
From: Joe Perches Date: Fri, 07 Mar 2014 13:02:44 -0800 > Right now, checkpatch emits a --strict only warning on "&&" or "||" > at the beginning of line but that could be changed to any "$Operators" > > our $Arithmetic = qr{\+|-|\*|\/|%}; > our $Operators= qr{ > <=|

Re: [PATCH 2/5] IBM Akebono: Add support for a new PHY interface to the IBM emac driver

2014-03-07 Thread David Miller
From: Alistair Popple Date: Thu, 6 Mar 2014 14:52:25 +1100 > + out_be32(dev->reg, in_be32(dev->reg) | WKUP_ETH_RGMIIEN > + | WKUP_ETH_TX_OE | WKUP_ETH_RX_IE); When an expression spans multiple lines, the lines should end with operators rather than begin with them. Also, it wou

Re: ibmveth: Fix endian issues with MAC addresses

2014-03-06 Thread David Miller
From: Anton Blanchard Date: Wed, 5 Mar 2014 14:51:37 +1100 > The code to load a MAC address into a u64 for passing to the > hypervisor via a register is broken on little endian. > > Create a helper function called ibmveth_encode_mac_addr > which does the right thing in both big and little endian

Re: [PATCH] net/mlx4: Support shutdown() interface

2014-03-05 Thread David Miller
From: Gavin Shan Date: Tue, 4 Mar 2014 15:35:20 +0800 > In kexec scenario, we failed to load the mlx4 driver in the > second kernel because the ownership bit was hold by the first > kernel without release correctly. > > The patch adds shutdown() interface so that the ownership can > be released

Re: [PATCH 2/2] sparc64: Remove unused sparc64_multi_core

2014-03-04 Thread David Miller
From: Bjorn Helgaas Date: Tue, 04 Mar 2014 14:07:44 -0700 > Remove sparc64_multi_core because it's not used any more. > > It was added by a2f9f6bbb30e ("Fix {mc,smt}_capable()"), and the last uses > were removed by e637d96bf462 ("sched: Remove unused mc_capable() and > smt_capable()"). > > Sign

Re: [PATCH 1/2] sched: Remove unused mc_capable() and smt_capable()

2014-03-04 Thread David Miller
From: Bjorn Helgaas Date: Tue, 04 Mar 2014 14:07:37 -0700 > Remove mc_capable() and smt_capable(). Neither is used. > > Both were added by 5c45bf279d37 ("sched: mc/smt power savings sched > policy"). Uses of both were removed by 8e7fbcbc22c1 ("sched: Remove stale > power aware scheduling remna

Re: [PATCH 10/10] Kconfig: cleanup SERIO_I8042 dependencies

2013-12-15 Thread David Miller
From: Mark Salter Date: Sun, 15 Dec 2013 10:50:26 -0500 > On Sun, 2013-12-15 at 02:36 -0800, Dmitry Torokhov wrote: >> How are we going to merge this? In bulk through input tree or peacemeal >> through all arches first? > > They should all go together to eliminate the chance of bisect breakage. >

Re: 3.13-rc1: eth0 hw csum failure on powerpc (bisected)

2013-12-14 Thread David Miller
From: Christian Kujau Date: Sat, 14 Dec 2013 16:40:39 -0800 (PST) > And sure enough, today's 3.13-rc3 with only that commit reverted boots > just fine on this PowerBook G4 system. It's reverted in my 'net' tree, that tree simple hasn't been pushed to Linus just yet, please be patient. _

Re: [PATCH] phy: Add Vitesse 8514 phy ID

2013-11-28 Thread David Miller
From: Date: Mon, 25 Nov 2013 12:40:49 +0800 > From: Shaohui Xie > > Phy is compatible with Vitesse 82xx > > Signed-off-by: Shaohui Xie Applied, thank you. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo

Re: "powerpc/83xx: gianfar_ptp: select 1588 clock source through dts file" was added twice

2013-10-12 Thread David Miller
From: Aida Mynzhasova Date: Sat, 12 Oct 2013 18:54:42 +0400 > Hi, > > recently I looked through commits in kernel/git/torvalds/linux.git and > I noticed that my patch (old and new version) was added twice (by > David S. Miller): > > e58f6f4fb4eada7867014bfaec898f03afbce5c2 > 894116bd0e9b7749a0c

<    1   2   3   4   5   6   7   8   9   10   >