Re: [PATCH] macintosh/via-pmu: Fix build failure when CONFIG_INPUT is disabled

2022-03-21 Thread Finn Thain
On Mon, 21 Mar 2022, Geert Uytterhoeven wrote: > On Mon, Mar 21, 2022 at 9:29 AM Finn Thain wrote: > > On Mon, 21 Mar 2022, Christophe Leroy wrote: > > > Le 21/03/2022 à 05:30, Finn Thain a écrit : > > > > drivers/macintosh/via-pmu-event.o: In function `via_pmu_e

[PATCH] macintosh/via-pmu: Fix build failure when CONFIG_INPUT is disabled

2022-03-20 Thread Finn Thain
: Randy Dunlap Signed-off-by: Finn Thain --- This is equivalent to the patch I sent a couple of days ago. This one is slightly longer and adds a new symbol so that Kconfig logic can been used instead of Makefile logic in case reviewers prefer that. --- drivers/macintosh/Kconfig | 5 + drivers

[PATCH] Subject: [PATCH] macintosh/via-pmu: Avoid compiler warnings when CONFIG_PROC_FS is disabled

2022-03-21 Thread Finn Thain
) ^~ Rearrange some code and add some #ifdefs to avoid unused code warnings when CONFIG_PROC_FS is disabled. Reported-by: Randy Dunlap Cc: Randy Dunlap Cc: Christophe Leroy Signed-off-by: Finn Thain --- drivers/macintosh/via-pmu.c | 4 1 file changed, 4 insertions(+) diff

Re: [PATCH] Subject: [PATCH] macintosh/via-pmu: Avoid compiler warnings when CONFIG_PROC_FS is disabled

2022-03-21 Thread Finn Thain
Please disregard. I'll send v2 with corrected commit log entry.

[PATCH v2] macintosh/via-pmu: Avoid compiler warnings when CONFIG_PROC_FS is disabled

2022-03-21 Thread Finn Thain
) ^~ Add some #ifdefs to avoid unused code warnings when CONFIG_PROC_FS is disabled. Cc: Randy Dunlap Cc: Christophe Leroy Reported-by: Randy Dunlap Suggested-by: Christophe Leroy Signed-off-by: Finn Thain --- Changed since v1: - Simplified to take advantage of the fact

Re: [PATCH] macintosh: fix via-pmu and via-cuda build errors

2022-04-07 Thread Finn Thain
On Wed, 6 Apr 2022, Randy Dunlap wrote: > When CONFIG_RTC_CLASS is not set, rtc_tm_to_time64() is not defined. > > ... > > m68k-linux-ld: drivers/macintosh/via-pmu.o: in function `pmu_set_rtc_time': > drivers/macintosh/via-pmu.c:1758: undefined reference to `rtc_tm_to_time64' > m68k-linux-ld:

Re: [PATCH] macintosh: fix via-pmu and via-cuda build errors

2022-04-07 Thread Finn Thain
On Thu, 7 Apr 2022, Christophe Leroy wrote: > Le 07/04/2022 à 05:16, Randy Dunlap a écrit : > > > > > > On 4/6/22 19:37, Randy Dunlap wrote: > >> When CONFIG_INPUT=m, the input_*() family of functions is not > >> available to builtin drivers. > >> > >> When CONFIG_RTC_CLASS is not set,

[PATCH v2] macintosh/via-pmu: Fix build failure when CONFIG_INPUT is disabled

2022-04-07 Thread Finn Thain
test robot Signed-off-by: Finn Thain --- Changed since v1: - Adopted IS_ENABLED to avoid an ifdef as suggested by Christophe. - Added the ADB_PMU_EVENT symbol as suggested by Geert, though this adds a new Kconfig symbol for little gain AFAICS. --- drivers/macintosh/Kconfig | 4

Re: Does anyone use Appletalk?

2023-11-01 Thread Finn Thain
On Wed, 1 Nov 2023, Arnd Bergmann wrote: > > If we had not removed all localtalk support already, ipddp might have > been used to bridge between a pre-ethernet mac running macip and an IP > based AFP server (netatalk or time machine). Without localtalk support, > that is not all that

Re: [RFC v2 01/39] Kconfig: introduce HAS_IOPORT option and select it as necessary

2022-05-06 Thread Finn Thain
On Thu, 5 May 2022, Bjorn Helgaas wrote: > On Thu, May 05, 2022 at 07:39:42PM +0200, Arnd Bergmann wrote: > > On Thu, May 5, 2022 at 6:10 PM Bjorn Helgaas wrote: > > > On Wed, May 04, 2022 at 11:31:28PM +0200, Arnd Bergmann wrote: > > > > > > > > The main goal is to avoid c), which is what

Re: [RFC v2 01/39] Kconfig: introduce HAS_IOPORT option and select it as necessary

2022-05-06 Thread Finn Thain
On Fri, 6 May 2022, Niklas Schnelle wrote: > On Fri, 2022-05-06 at 19:12 +1000, Finn Thain wrote: > > > > On Thu, 5 May 2022, Bjorn Helgaas wrote: > > > > > On Thu, May 05, 2022 at 07:39:42PM +0200, Arnd Bergmann wrote: > > > > On Thu, M

Re: [RFC v2 01/39] Kconfig: introduce HAS_IOPORT option and select it as necessary

2022-05-07 Thread Finn Thain
Hi Arnd, On Sat, 7 May 2022, Arnd Bergmann wrote: > On Sat, May 7, 2022 at 2:01 AM Finn Thain wrote: > > On Fri, 6 May 2022, Niklas Schnelle wrote: > > > On Fri, 2022-05-06 at 19:12 +1000, Finn Thain wrote: > > > > On Thu, 5 May 2022, Bjorn Helgaas wrote: >

Re: [RFC v2 01/39] Kconfig: introduce HAS_IOPORT option and select it as necessary

2022-05-07 Thread Finn Thain
On Sun, 8 May 2022, I wrote: > > That suggests to me that we need a "bool CONFIG_WARINGS_INTO_ERRORS" to > control -Werror, which could be disabled for .config files (like make > allmodconfig) where it is not helping. > I just noticed that we already have CONFIG_WERROR. So perhaps

Re: [PATCH] MAINTAINERS: Exclude m68k-only drivers from powerpc entry

2023-05-31 Thread Finn Thain
On Wed, 31 May 2023, Geert Uytterhoeven wrote: > On Wed, May 31, 2023 at 2:50 PM Michael Ellerman wrote: > > The powerpc section has a "F:" entry for drivers/macintosh, matching > > all files in or below drivers/macintosh. That is correct for the most > > part, but there are a couple of

[PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-03-27 Thread Finn Thain
st_acpi_subsys_init+0x0/0x8 [ 14.56] [<0063991e>] console_on_rootfs+0x0/0x60 [ 14.56] [<00638410>] _sinittext+0x410/0xadc [ 14.56] Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: "Aneesh Kumar K.V" Cc: "Nave

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-03 Thread Finn Thain
ges since v6.8. > > Link: https://github.com/vivier/qemu-m68k/issues/44 > > Link: https://lore.kernel.org/all/1078874617.9746.36.camel@gaston/ > > Missed Fixes tag? > Would this be ok: Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") I have to ask because some reviewers do

[PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Finn Thain
com/vivier/qemu-m68k/issues/44 Link: https://lore.kernel.org/all/1078874617.9746.36.camel@gaston/ Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Finn Thain --- Changed since v1: - Reworked commit log according to comments from Andy Shevchenko. --- drivers/tty/seri

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Finn Thain
On Fri, 5 Apr 2024, Michael Ellerman wrote: > >> > > --- > >> > (here is a good location for Cc:) > >> > >> Documentation/process/submitting-patches.rst indicats that it should > >> be above the "---" separator together with Acked-by etc. Has this > >> convention changed recently? > > The

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Finn Thain
On Thu, 4 Apr 2024, Andy Shevchenko wrote: > > > > > --- > > > (here is a good location for Cc:) > > > > Documentation/process/submitting-patches.rst indicats that it should > > be above the "---" separator together with Acked-by etc. Has this > > convention changed recently? > > I see, I

Re: [PATCH v2] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-05 Thread Finn Thain
On Fri, 5 Apr 2024, Michael Ellerman wrote: > I assume you have tested this on an actual pmac, as well as qemu? > I tested the patched driver and its console functionality using Zilog SCC hardware in a Mac IIci, as well as QEMU's q800 virtual machine. That should suffice from a code coverage

[PATCH v3] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-08 Thread Finn Thain
g/all/1078874617.9746.36.camel@gaston/ Acked-by: Michael Ellerman (powerpc) Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Finn Thain --- Changed since v1: - Reworked commit log according to comments from Andy Shevchenko. Changed since v2: - Added Acked-by and Cc tags. -

Re: [PATCH 2/2] MAINTAINERS: Make cxl obsolete

2024-04-10 Thread Finn Thain
On Wed, 10 Apr 2024, Michael Ellerman wrote: > > > > Could we do something similar, write a message at boottime when the > > CXL driver gets probed ? > > Yeah, I think so. > > There's still the problem that people tend not to look at dmesg until > something breaks, but at least we can try

<    1   2   3   4   5   6