Hi Gustavo,
On 1/8/19 1:00 PM, Gustavo A. R. Silva wrote:
> One of the more common cases of allocation size calculations is finding the
> size of a structure that has a zero-sized array at the end, along with memory
> for some number of elements for that array. For example:
>
> struct foo {
>
_params;
> +} saved_params;
Seems fine.
Acked-by: Geoff Levand
t; ---
> sound/ppc/snd_ps3.c | 4
> 1 file changed, 4 deletions(-)
Seems OK. Thanks for submitting.
Acked-by: Geoff Levand
Seems fine.
Acked-by: Geoff Levand
To aid debugging wrapper troubles, output a linker map file
'wrapper.map' when the build is verbose.
Signed-off-by: Geoff Levand
---
arch/powerpc/boot/wrapper | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index
From: Markus Elfring
Remove duplicate memory allocation failure error messages.
Signed-off-by: Markus Elfring
Signed-off-by: Geoff Levand
---
arch/powerpc/platforms/ps3/os-area.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/ps3/os-area.c
b
typically install on the PS3.
Cc: Geert Uytterhoeven
Signed-off-by: Geoff Levand
---
arch/powerpc/configs/ps3_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/powerpc/configs/ps3_defconfig
b/arch/powerpc/configs/ps3_defconfig
index 4db51719342a..81b55c880fc3 100644
--- a/arch
Remove the '-m4' option to grep to allow grep to process all of nm's
output. This avoids the nm warning:
nm terminated with signal 13 [Broken pipe]
Signed-off-by: Geoff Levand
---
arch/powerpc/tools/head_check.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch
)
Dan Carpenter (1):
powerpc/ps3: remove an unneeded NULL check
Emmanuel Nicolet (1):
ps3disk: use the default segment boundary
Geoff Levand (4):
powerpc/ps3: Set CONFIG_UEVENT_HELPER=y in ps3_defconfig
powerpc/ps3
lv1_panic takes a single parameter, 0=halt, 1=reboot, and it will
never return.
Signed-off-by: Geoff Levand
---
arch/powerpc/boot/ppc_asm.h| 6 ++
arch/powerpc/include/asm/ppc_asm.h | 6 ++
2 files changed, 12 insertions(+)
diff --git a/arch/powerpc/boot/ppc_asm.h b/arch
To aid debugging build problems turn on shell tracing for the
head_check script when the build is verbose.
Signed-off-by: Geoff Levand
---
arch/powerpc/tools/head_check.sh | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/tools/head_check.sh b/arch/powerpc
The ps3's otheros flash loader has a size limit of 16 MiB for the
uncompressed image. If that limit will be reached output the
flash image file as 'otheros-too-big.bld'.
Signed-off-by: Geoff Levand
---
arch/powerpc/boot/wrapper | 13 +++--
1 file changed, 11 insertions(+), 2 deletions
From: Markus Elfring
Remove duplicate memory allocation failure error messages.
Signed-off-by: Markus Elfring
Signed-off-by: Geoff Levand
---
drivers/ps3/ps3-lpm.c | 2 --
drivers/ps3/ps3-vuart.c | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/ps3/ps3-lpm.c b/drivers/ps3/ps3
ak anything.
Signed-off-by: Emmanuel Nicolet
Signed-off-by: Geoff Levand
---
drivers/block/ps3disk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c
index c5c6487a19d5..7b55811c2a81 100644
--- a/drivers/block/ps3disk.c
+++ b/drivers/block/ps3dis
BUG_ON() won't work in the early init code, so replace it with
a new routine udbg_panic() that uses udbg_printf() and lv1_panic().
Signed-off-by: Geoff Levand
---
arch/powerpc/platforms/ps3/mm.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms
From: Markus Elfring
Remove an extra message for a memory allocation failure in
function gelic_descr_prepare_rx().
Signed-off-by: Markus Elfring
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net
the PS3 and it worked
as expected.
Tested by: Geoff Levand
)
Geoff Levand (3):
powerpc/head_check: Automatic verbosity
powerpc/wrapper: Output linker map file
powerpc/head_check: Avoid broken pipe
arch/powerpc/boot/wrapper| 3 ++-
arch/powerpc/tools/head_check.sh | 8 +---
2 files changed, 7 insertions(+), 4 deletions
From: Dan Carpenter
Static checkers don't like the inconsistent NULL checking on "ops".
This function is only called once and "ops" isn't NULL so the check can
be removed.
Signed-off-by: Dan Carpenter
Signed-off-by: Geoff Levand
---
drivers/ps3/sys-manager-core.c | 2 +
Hi Geert,
On 3/29/20 7:00 AM, Geert Uytterhoeven wrote:
>> --- a/arch/powerpc/boot/wrapper
>> +++ b/arch/powerpc/boot/wrapper
>>
>> odir="$(dirname "$ofile.bin")"
>> -rm -f "$odir/otheros.bld"
>> -gzip -n --force -9 --stdout "$ofile.bin" > "$odir/otheros.bld"
>> +
>> +# The ps3's
The ps3's otheros flash loader has a size limit of 16 MiB for the
uncompressed image. If that limit will be reached output the
flash image file as 'otheros-too-big.bld'.
Signed-off-by: Geoff Levand
---
arch/powerpc/boot/wrapper | 17 +++--
1 file changed, 15 insertions(+), 2
Hi Michael,
On 5/14/20 7:02 PM, Michael Ellerman wrote:
> Geoff Levand writes:
...
>> +# The ps3's flash loader has a size limit of 16 MiB for the uncompressed
>> +# image. If a compressed image that exceeded this limit is written to
>> +# flash the loader will
The ps3's otheros flash loader has a size limit of 16 MiB for the
uncompressed image. If that limit will be reached output the
flash image file as 'otheros-too-big.bld'.
Signed-off-by: Geoff Levand
---
v2: Change from decimal to hex values. Output an INFO message to screen.
v3: Remove the INFO
N_INBUF to HVC_N_INBUF.
Typical usage in the backend source file would be:
#define HVC_N_OUTBUF 32
#define HVC_N_INBUF 32
#include "hvc_console.h"
Signed-off-by: Geoff Levand
---
drivers/tty/hvc/hvc_console.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
Remove the '-m4' option to grep to allow grep to process all of nm's
output. This avoids the nm warning:
nm terminated with signal 13 [Broken pipe]
Signed-off-by: Geoff Levand
---
arch/powerpc/tools/head_check.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch
To aid debugging wrapper troubles, output a linker map file
'wrapper.map' when the build is verbose.
Signed-off-by: Geoff Levand
---
arch/powerpc/boot/wrapper | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/wrapper b/arch/powerpc/boot/wrapper
index
ps3_mm_region_destroy() and
ps3_mm_vas_destroy() and replace any error reporting with calls
to lv1_panic.
With this change builds with 'DEBUG' defined will not cause kexec
reboots to hang, and builds with 'DEBUG' defined or not will end
in lv1_panic if an error is encountered.
Signed-off-by: Geoff Levand
N_INBUF to HVC_N_INBUF.
Typical usage in the backend source file would be:
Signed-off-by: Geoff Levand
---
drivers/tty/hvc/hvc_console.c | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c
index
To aid debugging build problems turn on shell tracing for the
head_check script when the build is verbose.
Signed-off-by: Geoff Levand
---
arch/powerpc/tools/head_check.sh | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/tools/head_check.sh b/arch/powerpc
):
ps3disk: use the default segment boundary
Geoff Levand (6):
powerpc/head_check: Automatic verbosity
powerpc/wrapper: Output linker map file
powerpc/head_check: Avoid broken pipe
powerpc/ps3: Add check for otheros image size
powerpc/ps3: Fix kexec shutdown hang
The ps3's otheros flash loader has a size limit of 16 MiB for the
uncompressed image. If that limit will be reached output the
flash image file as 'otheros-too-big.bld'.
Signed-off-by: Geoff Levand
---
arch/powerpc/boot/wrapper | 17 +++--
1 file changed, 15 insertions(+), 2
From: Markus Elfring
Remove duplicate memory allocation failure error messages.
Signed-off-by: Markus Elfring
Signed-off-by: Geoff Levand
---
drivers/ps3/ps3-lpm.c | 2 --
drivers/ps3/ps3-vuart.c | 1 -
2 files changed, 3 deletions(-)
diff --git a/drivers/ps3/ps3-lpm.c b/drivers/ps3/ps3
From: Markus Elfring
Remove an extra message for a memory allocation failure in
function gelic_descr_prepare_rx().
Signed-off-by: Markus Elfring
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net
ak anything.
Signed-off-by: Emmanuel Nicolet
Signed-off-by: Geoff Levand
---
drivers/block/ps3disk.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/ps3disk.c b/drivers/block/ps3disk.c
index c5c6487a19d5..7b55811c2a81 100644
--- a/drivers/block/ps3disk.c
+++ b/drivers/block/ps3dis
Hi,
On 3/19/20 3:26 AM, Sebastian Andrzej Siewior wrote:
> On 2020-03-19 03:04:59 [-0700], Christoph Hellwig wrote:
>> But I wonder how alive the whole PS3 support is to start with..
>
> OtherOS can only be used on "old" PS3 which do not have have their
> firmware upgraded past version 3.21,
ed with diff + objdump -Dr).
Thanks for your patch. I tested this patch applied to v5.8-rc2 on a
PS3 and it seems OK.
Tested-by: Geoff Levand
ed-off-by: Leonard Goehrs
Seems OK with v5.9 on PS3.
Tested by: Geoff Levand
;
> Signed-off-by: Uwe Kleine-König
Seems OK with v5.9 on PS3.
Tested by: Geoff Levand
>
> Signed-off-by: Uwe Kleine-König
I tested your two patches plus Leonard's patch 'ALSA: ppc: remove
redundant checks in PS3 driver probe' applied to v5.9 on the PS3,
and they seem to work fine.
Thanks for both your efforts.
Tested by: Geoff Levand
On 12/13/20 10:26 AM, Vincent Stehlé wrote:
> The DMA address returned by dma_map_single() should be checked with
> dma_mapping_error(). Fix the ps3stor_setup() function accordingly.
>
> Fixes: 80071802cb9c ("[POWERPC] PS3: Storage Driver Core")
> Signed-off-by: Vincent S
Hi Carlos,
On 11/19/20 1:07 PM, Carlos Eduardo de Paula wrote:
> I was able in the petitboot shell to set the timeout for booting an image by
> using ps3-bl-options (that uses ps3-flash-util itself) but if I use these
> utilities in my booted linux, I get "magic_num failed" error and can't do
Li
> ---
> arch/powerpc/platforms/ps3/system-bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks for your patch, it looks good.
Acked-by: Geoff Levand
-Geoff
patch set applied to v5.13-rc6 on PS3 and it seemed to be
working OK.
I did some rsync's, some dd's, some fsck's, etc. If you have anything
you could suggest that you think would exercise your changes I could
try that also.
Tested-by: Geoff Levand
General source cleanups and improved logging messages.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 395 ++-
1 file changed, 216 insertions(+), 179 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet
to 4adcfc9735bf8d1987d2bc82e914be154f2ffad8:
net/ps3_gelic: Cleanups, improve logging (2021-06-01 12:27:43 -0700)
Geoff Levand (5):
powerpc/ps3: Add CONFIG_PS3_VERBOSE_RESULT option
powerpc/ps3: Warn on PS3 device errors
powerpc/ps3: Add dma_mask
-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 573 +++
drivers/net/ethernet/toshiba/ps3_gelic_net.h | 24 +-
2 files changed, 341 insertions(+), 256 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet/toshiba
to this new variable.
Fixes runtime errors like these:
ps3_system_bus_match:349: dev=8.0(sb_01), drv=8.0(ps3flash): match
WARNING: CPU: 0 PID: 1 at kernel/dma/mapping.c:151
ps3flash sb_01: ps3stor_setup:193: map DMA region failed
Signed-off-by: Geoff Levand
---
arch/powerpc/include/asm/ps3.h
To aid debugging, add a new PS3 kernel config option
PS3_VERBOSE_RESULT that, when enabled, will print more
verbose messages for the result of LV1 hypercalls.
Signed-off-by: Geoff Levand
---
arch/powerpc/include/asm/ps3.h | 2 +-
arch/powerpc/platforms/ps3/Kconfig | 9 +
2 files
To aid debugging PS3 boot problems change the log level
of several PS3 device errors from pr_debug to pr_warn.
Signed-off-by: Geoff Levand
---
arch/powerpc/platforms/ps3/system-bus.c | 9 +
drivers/ps3/ps3-vuart.c | 2 +-
drivers/ps3/ps3av.c | 22
Hi,
On 5/20/21 5:20 AM, Michael Ellerman wrote:
> Zhen Lei writes:
>> When call ps3_start_probe_thread() failed, further initialization should
>> be stopped and the returned error code should be propagated.
...
>> --- a/arch/powerpc/platforms/ps3/device-init.c
>>
>> result =
your alloc_disk-part2 branch on PS3, and it seemed to be working OK.
Tested-by: Geoff Levand
Add a new sysfs entry /sys/firmware/ps3/fw-version that exports
the PS3's firmware version.
The firmware version is available through an LV1 hypercall, and we've
been printing it to the boot log, but haven't provided an easy way for
user utilities to get it.
Signed-off-by: Geoff Levand
)
Geoff Levand (2):
powerpc/ps3: Add firmware version to sysfs
powerpc/ps3: Re-align DTB in image
arch/powerpc/boot/zImage.ps3.lds.S | 2 +-
arch/powerpc/platforms/ps3/setup.c | 43 +++---
2 files changed, 41 insertions(+), 4 deletions
Change the PS3 linker script to align the DTB at 8 bytes,
the same alignment as that of the of the 'generic' powerpc
linker script.
Signed-off-by: Geoff Levand
---
arch/powerpc/boot/zImage.ps3.lds.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/zImage.ps3
General source cleanups and improved logging messages.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 395 ++-
1 file changed, 216 insertions(+), 179 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet
to this new variable.
Fixes runtime errors like these:
ps3_system_bus_match:349: dev=8.0(sb_01), drv=8.0(ps3flash): match
WARNING: CPU: 0 PID: 1 at kernel/dma/mapping.c:151
.dma_map_page_attrs+0x34/0x1e0
ps3flash sb_01: ps3stor_setup:193: map DMA region failed
Signed-off-by: Geoff Levand
To aid debugging PS3 boot problems change the log level
of several PS3 device errors from pr_debug to pr_warn.
Signed-off-by: Geoff Levand
---
arch/powerpc/platforms/ps3/system-bus.c | 9 +
drivers/ps3/ps3-vuart.c | 2 +-
drivers/ps3/ps3av.c | 22
To aid debugging, add a new PS3 kernel config option
PS3_VERBOSE_RESULT that, when enabled, will print more
verbose messages for the result of LV1 hypercalls.
Signed-off-by: Geoff Levand
---
arch/powerpc/include/asm/ps3.h | 2 +-
arch/powerpc/platforms/ps3/Kconfig | 9 +
2 files
-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 573 +++
drivers/net/ethernet/toshiba/ps3_gelic_net.h | 24 +-
2 files changed, 341 insertions(+), 256 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet/toshiba
for you to fetch changes up to c944a7aa07cbe1893a2426cfd6ed506bc6aebbbc:
net/ps3_gelic: Cleanups, improve logging (2021-06-03 11:47:01 -0700)
Geoff Levand (2):
net/ps3_gelic: Add gelic_descr structures
net/ps3_gelic
to 562d0c9ea0100a30c3b186bcc7adb34b0bbd2cd7:
powerpc/ps3: Add dma_mask to ps3_dma_region (2021-06-01 12:27:43 -0700)
Geoff Levand (3):
powerpc/ps3: Add CONFIG_PS3_VERBOSE_RESULT option
powerpc/ps3: Warn on PS3 device errors
Hi Michael,
On 6/2/21 10:38 PM, Michael Ellerman wrote:
> Geoff Levand writes:
>> Hi,
>>
>> This is a set of patches that fix various DMA related problems in the PS3
>> device drivers, and add better error checking and improved message logging.
>>
>>
ev)
> __func__, __LINE__, drv->core.name);
>
> pr_debug(" <- %s:%d: %s\n", __func__, __LINE__, dev_name(>core));
> - return 0;
> }
PS3 part looks fine.
Acked-by: Geoff Levand
General source cleanups and improved logging messages.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 395 ++-
1 file changed, 216 insertions(+), 179 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet
/linux/kernel/git/geoff/ps3-linux.git
for-merge-dma-net
for you to fetch changes up to ffb7b2f4ac085986f563131e3851e07393cd514f:
net/ps3_gelic: Cleanups, improve logging (2021-07-10 20:42:42 -0700)
Geoff Levand (2):
net
-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 573 +++
drivers/net/ethernet/toshiba/ps3_gelic_net.h | 24 +-
2 files changed, 341 insertions(+), 256 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet/toshiba
On 7/4/21 2:38 AM, Colin King wrote:
> - Enables more verbose log mesages for LV1 hypercall results.
> + Enables more verbose log messages for LV1 hypercall results.
Looks good. Thanks.
Acked by: Geoff Levand
Change the Spidernet network driver from supported to
maintained, add the linuxppc-dev ML, and add myself as
a 'maintainer'.
Cc: Ishizaki Kou
Signed-off-by: Geoff Levand
---
MAINTAINERS | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index
Add a new proc FS entry /proc/ps3/firmware-version that exports the
PS3's firmware version.
The firmware version is available through an LV1 hypercall, and we've
been printing it to the boot log, but haven't provided an easy way for
user utilities to get it.
Signed-off-by: Geoff Levand
)
Geoff Levand (2):
powerpc/ps3: Add firmware version to proc
powerpc/ps3: Re-align DTB in image
arch/powerpc/boot/zImage.ps3.lds.S | 2 +-
arch/powerpc/platforms/ps3/setup.c | 62 --
2
Change the PS3 linker script to align the DTB at 8 bytes,
the same alignment as that of the of the 'generic' powerpc
linker script.
Signed-off-by: Geoff Levand
---
arch/powerpc/boot/zImage.ps3.lds.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/boot/zImage.ps3
On 3/23/21 1:55 AM, caizhichao wrote:
> From: caizhichao
>
> vaules -> values
>
> Signed-off-by: caizhichao
> ---
> sound/ppc/snd_ps3_reg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Seems fine. Thanks for your contribution.
Acked-by: Geoff Levand
Hi Christophe,
On 8/27/21 12:56 PM, Christophe JAILLET wrote:
> It has *not* been compile tested because I don't have the needed
> configuration or cross-compiler.
The powerpc ppc64_defconfig has CONFIG_SPIDER_NET set. My
tdd-builder Docker image has the needed gcc-powerpc-linux-gnu
cross
Hi Christophe,
On 8/27/21 6:34 PM, Geoff Levand wrote:
> On 8/27/21 12:56 PM, Christophe JAILLET wrote:
>> It has *not* been compile tested because I don't have the needed
>> configuration or cross-compiler.
>
> The powerpc ppc64_defconfig has CONFIG_SPIDER_NET set. My
>
Hi Luis,
On 10/15/21 4:52 PM, Luis Chamberlain wrote:
> This patch set consists of al the straggler drivers for which we have
> have no patch reviews done for yet. I'd like to ask for folks to please
> consider chiming in, specially if you're the maintainer for the driver.
> Additionally if you
Hi Luis,
On 10/18/21 9:15 AM, Luis Chamberlain wrote:
> On Sun, Oct 17, 2021 at 08:26:33AM -0700, Geoff Levand wrote:
>> Hi Luis,
>>
>> On 10/15/21 4:52 PM, Luis Chamberlain wrote:
>>> This patch set consists of al the straggler drivers for which we have
>>
nfig. Thanks
for your contribution.
Acked-by: Geoff Levand
handling branch
on PS3 and the ps3disk changes seem to be working OK.
Tested-by: Geoff Levand
is change will be OK.
Acked-by: Geoff Levand
Hi Christophe,
On 7/11/21 7:03 AM, Christophe Leroy wrote:
>
> Your patch has a lot of cosmetic changes. Several of them are just wrong. The
> other ones belong to another patch. This patch should focus only on the
> changes it targets.
>
> Your patch is way too big and addresses several
In an effort to make the PS3 gelic driver easier to maintain, cleanup the
the driver source file formatting to be more consistent.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 379 ++-
1 file changed, 193 insertions(+), 186 deletions(-)
diff
Put the common code for unmaping a link into its own routine,
gelic_unmap_link, and add some debugging checks.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 23 +++-
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/drivers/net
In an effort to make the PS3 gelic driver easier to maintain, rename
the gelic_card_init_chain parameter 'no' to 'descr_count'.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net
Add new helper routine gelic_work_to_card that converts a work_struct
to a gelic_card.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers
In an effort to make the PS3 gelic driver easier to maintain, add a
local variable dev to those routines that use the device structure that
makes the use the device structure more consistent.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 340
Add a new preprocessor macro BUG_ON_DEBUG, that expands to BUG_ON when
the preprocessor macro DEBUG is defined, or to WARN_ON when DEBUG is not
defined. Also, replace all occurrences of BUG_ON with BUG_ON_DEBUG.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 13
hardware device. struct gelic_chain_link holds variables used to manage
the driver's linked list of gelic descr structures.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 133 ++-
drivers/net/ethernet/toshiba/ps3_gelic_net.h | 24 ++--
2 files changed
errors like these, and also other randomly occurring errors:
IP-Config: Complete:
DMA-API: ps3_gelic_driver sb_05: device driver failed to check map error
WARNING: CPU: 0 PID: 0 at kernel/dma/debug.c:1027 .check_unmap+0x888/0x8dc
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba
-0700)
Geoff Levand (10):
net/ps3_gelic: Add gelic_descr structures
net/ps3_gelic: Use local dev variable
net/ps3_gelic: Format cleanups
net/ps3_gelic: Add new macro BUG_ON_DEBUG
net/ps3_gelic: Add vlan_id
In an effort to make the PS3 gelic driver easier to maintain, add
a definition for the vlan_id structure.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/toshiba
In an effort to make the PS3 gelic driver easier to maintain, change the
gelic_card_enable_rxdmac routine to use the optimizer to remove
debug code.
Signed-off-by: Geoff Levand
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 19 +--
1 file changed, 9 insertions(+), 10
Hi Paul,
On 2/13/22 22:55, Paul Menzel wrote:
> Currently, `git status` lists the file as untracked by git, so tell git
> to ignore it.
Thanks for your contribution.
Acked-by: Geoff Levand
rd;
>
> netdev = alloc_etherdev(struct_size(card, darray,
> - tx_descriptors + rx_descriptors));
> + size_add(tx_descriptors,
> rx_descriptors)));
> if (!netdev)
> return NULL;
>
Looks good to me. Thanks for your fix-up.
Signed-off-by: Geoff Levand
On 10/12/23 17:41, Johannes Berg wrote:
> But seriously - is it worth to try to keep a wireless driver for it if
> we don't even know anyone using a PS3 at all?
There is still a considerable user base for the PS3, so we
must keep the ps3-gelic-wireless driver.
-Geoff
+++ b/arch/powerpc/platforms/ps3/repository.c
> @@ -73,9 +73,9 @@ static void _dump_node(unsigned int lpar_id, u64 n1, u64
> n2, u64 n3, u64 n4,
I tested this on PS3 and it seems to be working OK.
Tested-by: Geoff Levand
| 1 +
> drivers/net/ethernet/toshiba/ps3_gelic_net.h | 6 --
> 3 files changed, 7 insertions(+), 6 deletions(-)
Seems good to me. I'll test it next chance I get.
Signed-off-by: Geoff Levand
netif_napi_add(netdev, >napi,
> -spider_net_poll, SPIDER_NET_NAPI_WEIGHT);
> +spider_net_poll, NAPI_POLL_WEIGHT);
This seems fine. Both SPIDER_NET_NAPI_WEIGHT and NAPI_POLL_WEIGHT
are defined as 64. Thanks for your contribution.
Acked-by: Geoff Levand
+ strscpy(gendisk->disk_name, DEVICE_NAME, sizeof(gendisk->disk_name));
> set_capacity(gendisk, priv->size >> 9);
> blk_queue_max_segments(gendisk->queue, BLK_MAX_SEGMENTS);
> blk_queue_max_segment_size(gendisk->queue, BLK_MAX_SEGMENT_SIZE);
Seems OK for ps3vram.
Acked-by: Geoff Levand
ERSION, sizeof(drvinfo->version));
> + strscpy(drvinfo->fw_version, "no information",
> sizeof(drvinfo->fw_version));
> - strlcpy(drvinfo->bus_info, pci_name(card->pdev),
> + strscpy(drvinfo->bus_info, pci_name(card->pdev),
> sizeof(drvinfo->bus_info));
> }
Seems OK for both ps3_gelic_net and spider_net_ethtool.
Acked-by: Geoff Levand
ve them.
I did a test build with this patch applied to v6.0-rc5 and had no errors.
Acked-by: Geoff Levand
401 - 500 of 541 matches
Mail list logo
