Re: physmap_of and partitions (mtd concat support)

2009-03-23 Thread Grant Likely
additional properties need to be added to describe the concat layout? g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: physmap_of and partitions (mtd concat support)

2009-03-24 Thread Grant Likely
On Tue, Mar 24, 2009 at 3:07 AM, Stefan Roese s...@denx.de wrote: On Monday 23 March 2009, Grant Likely wrote: On Mon, Mar 23, 2009 at 4:51 AM, Stefan Roese s...@denx.de wrote: I just noticed that physmap_of can't handle multiple devices of different type described in one device node

Re: physmap_of and partitions (mtd concat support)

2009-03-24 Thread Grant Likely
On Tue, Mar 24, 2009 at 9:39 AM, Stefan Roese s...@denx.de wrote: On Tuesday 24 March 2009, Grant Likely wrote: Sounds to me like a physmap_of driver bug.  I don't think there is any advantage in changing the partition syntax since concatenated flash will always be used as a single device

[RFC PATCH v2 0/2] Second posting of RFC patches

2009-03-24 Thread Grant Likely
These aren't actually done yet, but I've received some interest in them, so I'm posting the current state. g. -- Grant Likely, B.Sc. P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman

[PATCH v2 1/2] powerpc/5200: add general purpose timer API for the MPC5200

2009-03-24 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca This patch adds an interface for controlling the timer function of the MPC5200 GPT devices. Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/powerpc/include/asm/mpc52xx.h|7 ++ arch/powerpc/platforms/52xx/mpc52xx_gpt.c

[PATCH v2 2/2] powerpc/5200: add LocalPlus bus FIFO device driver

2009-03-24 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca This is a driver for the LocalPlus bus FIFO device Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/powerpc/include/asm/mpc52xx.h| 11 + arch/powerpc/platforms/52xx/Kconfig |4 arch/powerpc/platforms/52xx

Re: physmap_of and partitions (mtd concat support)

2009-03-25 Thread Grant Likely
On Wed, Mar 25, 2009 at 3:35 AM, Stefan Roese s...@denx.de wrote: On Tuesday 24 March 2009, Grant Likely wrote: OK, in the example above such a spanning partition is not so likely. But think about my original example, the Intel P30 with two different cfi compatible chips on one die. Here

Re: [PATCH v3 1/4] NAND: FSL-UPM: add multi chip support

2009-03-25 Thread Grant Likely
] = 0) +                        gpio_free(fun-rnb_gpio[i]); +        }        kfree(fun); -- 1.6.0.6 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev -- Grant Likely, B.Sc., P.Eng

Re: [PATCH v3 1/4] NAND: FSL-UPM: add multi chip support

2009-03-25 Thread Grant Likely
On Wed, Mar 25, 2009 at 7:31 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Mar 25, 2009 at 4:08 AM, Wolfgang Grandegger w...@grandegger.com wrote: This patch adds support for multi-chip NAND devices to the FSL-UPM driver. This requires support for multiple GPIOs for the RNB pins

Re: [PATCH v3 1/4] NAND: FSL-UPM: add multi chip support

2009-03-25 Thread Grant Likely
On Wed, Mar 25, 2009 at 7:43 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Wed, Mar 25, 2009 at 7:31 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Mar 25, 2009 at 4:08 AM, Wolfgang Grandegger w...@grandegger.com wrote: This patch adds support

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-25 Thread Grant Likely
___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [RFC] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-25 Thread Grant Likely
); ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-25 Thread Grant Likely
On Wed, Mar 25, 2009 at 2:48 PM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: For the chip offset, it's not clear what the meaning is.  First, does the UPM controller support access of multiple chips simultaneously? The offset drives the corresponding address lines

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-26 Thread Grant Likely
On Thu, Mar 26, 2009 at 1:42 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Wed, Mar 25, 2009 at 2:48 PM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: For the chip offset, it's not clear what the meaning is.  First, does the UPM controller

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-26 Thread Grant Likely
On Thu, Mar 26, 2009 at 9:33 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: Does using the reg property give the driver enough information to reliably program the MAR for NAND connections that use the address line chip select scheme?  Related to that, should

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-26 Thread Grant Likely
On Thu, Mar 26, 2009 at 10:35 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Thu, Mar 26, 2009 at 9:33 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: Does using the reg property give the driver enough information to reliably program

Re: [PATCH v3 3/4] powerpc: NAND: FSL UPM: document new bindings

2009-03-26 Thread Grant Likely
On Thu, Mar 26, 2009 at 4:14 PM, Wolfgang Grandegger w...@grandegger.com wrote: Anton Vorontsov wrote: On Thu, Mar 26, 2009 at 11:02:06AM -0600, Grant Likely wrote: In other words, this device is not register-level compatible with the fsl,upm-nand device.  Give the node a new compatible value

Re: DTC sources move

2009-03-27 Thread Grant Likely
yourself to move dtc. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v2 03/13] phylib: rework to prepare for OF registration of PHYs

2009-03-28 Thread Grant Likely
Andy, can you please make comment on patch 3, 4 and 5 of this series? I think they are ready to merge and the driver changes can be applied any time after the phylib changes. g. On Sat, Mar 21, 2009 at 4:28 PM, Grant Likely grant.lik...@secretlab.ca wrote: From: Grant Likely grant.lik

Re: BUS_ID_SIZE is going away

2009-03-28 Thread Grant Likely
can push it through the driver-core tree. gianfar_platform_data and several other symbols in that file are actually obsolete and unused. They can be removed entirely from include/linux/fsl_devices.h. I'll prepare a patch. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: Interrupts on GPIO

2009-03-30 Thread Grant Likely
IRQ2. These numbers are *Linux internal* virtual irq numbers. They have no relation to the physical IRQ number for each interrupt controller. Just make sure your Device Tree maps the IRQs correctly and you'll be okay. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: using IRQ1 in mpc5121ads

2009-03-30 Thread Grant Likely
() to register your of_platform_driver in your module's init function. Are we on the right track here? Is there sample/ tutorial code you could point us to? Search for of_register_platform_driver() in the kernel source. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

[PATCH] net/fec_mpc52xx: fix BUG on missing dma_ops

2009-03-30 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca The driver triggers a BUG_ON() when allocating DMA buffers if the arch/powerpc dma_ops from the of_platform device are not copied into net_device structure. Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- David, do you want to pick this one

[PATCH] net/fec_mpc52xx: fix BUG on missing dma_ops

2009-03-30 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca The driver triggers a BUG_ON() when allocating DMA buffers if the arch/powerpc dma_ops from the of_platform device are not copied into net_device structure. Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- Becky, does this look better to you

Re: Inconsistent fsl_get_sys_freq() implementation

2009-03-31 Thread Grant Likely
the 52xx support to use common code. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 00/14] Add common OF device tree support for MDIO busses

2009-03-31 Thread Grant Likely
): Merge git://git.kernel.org/.../davem/net-2.6 are available in the git repository at: git://git.secretlab.ca/git/linux-2.6-mpc52xx for-davem Grant Likely (15): net/fec_mpc52xx: fix BUG on missing dma_ops of: add of_parse_phandle() helper for parsing phandle properties

[PATCH 01/14] of: add of_parse_phandle() helper for parsing phandle properties

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca of_parse_phandle() is a helper function to read and parse a phandle property and return a pointer to the resulting device_node. Signed-off-by: Grant Likely grant.lik...@secretlab.ca CC: Michael Ellerman mich...@ellerman.id.au --- drivers/of/base.c

[PATCH 02/14] net/fec_mpc52xx: Migrate to net_device_ops.

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca Since not using net_device_ops gets you shunned out the cool crowd, this patch modifies the fec_mpc52xx Ethernet driver to provide the management hooks via a struct net_device_ops. Reported-by: Henk Stegeman henk.stege...@gmail.com Signed-off

[PATCH 03/14] net/fec_mpc52xx: Don't dereference phy_device if it is NULL

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca The FEC Ethernet device isn't always attached to a phy. Be careful not to dereference phy_device if it is NULL. Reported-by: Henk Stegeman henk.stege...@gmail.com Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- drivers/net/fec_mpc52xx.c

[PATCH 04/14] phylib: rework to prepare for OF registration of PHYs

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca This patch makes changes in preparation for supporting open firmware device tree descriptions of MDIO busses. Changes include: - Cleanup handling of phy_map[] entries; they are already NULLed when registering and so don't need to be re-cleared

[PATCH 05/14] phylib: add *_direct() variants of phy_connect and phy_attach functions

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca Add phy_connect_direct() and phy_attach_direct() functions so that drivers can use a pointer to the phy_device instead of trying to determine the phy's bus_id string. This patch is useful for OF device tree descriptions of phy devices where the driver

[PATCH 06/14] openfirmware: Add OF phylib support code

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca Add support for parsing the device tree for PHY devices on an MDIO bus CC: Andy Fleming aflem...@freescale.com CC: linuxppc-dev@ozlabs.org CC: devtree-disc...@ozlabs.org Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- drivers/of/Kconfig

[PATCH 07/14] net: Rework mpc5200 fec driver to use of_mdio infrastructure.

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca The patch reworks the MPC5200 Fast Ethernet Controller (FEC) driver to use the of_mdio infrastructure for registering PHY devices from data out openfirmware device tree, and eliminates the assumption that the PHY for the FEC is always attached

[PATCH 08/14] net: rework fsl_pq_mdio driver to use of_mdio infrastructure

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca This patch simplifies the driver by making use of more common code. Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- drivers/net/fsl_pq_mdio.c | 53 +++-- 1 files changed, 4 insertions(+), 49

[PATCH 09/14] net: Rework gianfar driver to use of_mdio infrastructure.

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca This patch simplifies the driver by making use of more common code. Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- drivers/net/gianfar.c | 103 ++--- drivers/net/gianfar.h |3 + 2 files

[PATCH 10/14] net: Rework ucc_geth driver to use of_mdio infrastructure

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca This patch simplifies the driver by making use of more common code. Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- drivers/net/ucc_geth.c | 47 --- drivers/net/ucc_geth.h |2 +- 2 files

[PATCH 11/14] net: Rework pasemi_mac driver to use of_mdio infrastructure

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca This patch simplifies the driver by making use of more common code. Tested-by: Olof Johansson o...@lixom.net Acked-by: Olof Johansson o...@lixom.net Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/powerpc/platforms/pasemi/gpio_mdio.c

[PATCH 12/14] powerpc/82xx: Rework Embedded Planet ep8248e platform to use of_mdio

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca This patch modifies the bitbanged MDIO driver in the ep8248e platform code to use the common of_mdio infrastructure. Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/powerpc/platforms/82xx/ep8248e.c |9 +++-- 1 files changed, 3

[PATCH 14/14] net: add Xilinx ll_temac device driver

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca This patch adds support for the Xilinx ll_temac 10/100/1000 Ethernet device. The ll_temac ipcore is typically used on Xilinx Virtex and Spartan designs attached to either a PowerPC 4xx or Microblaze processor. At the present moment, this driver only

[PATCH 13/14] net: Rework fs_enet driver to use of_mdio infrastructure

2009-03-31 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca This patch simplifies the driver by making use of more common code. Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- drivers/net/fs_enet/fs_enet-main.c | 69 ++-- drivers/net/fs_enet/mii-bitbang.c | 29

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-31 Thread Grant Likely
On Tue, Mar 31, 2009 at 3:35 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: I agree 100% with David's comments, and I have some additional ones below. On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegger w...@grandegger.com wrote: +       soc8...@e000

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-31 Thread Grant Likely
On Tue, Mar 31, 2009 at 7:36 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Tue, Mar 31, 2009 at 3:35 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: I agree 100% with David's comments, and I have some additional ones below. On Thu, Mar 19

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Grant Likely
i2c_clock, u32 i2c_flags) +{ [...] +} +EXPORT_SYMBOL(fsl_i2c_get_fdr); does not work on a multiplatform kernel. Both 8xxx and 52xx support can be selected at the same time. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc

Re: [PATCH 1/2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Grant Likely
. The code block should be moved down. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 3/8] powerpc/85xx: Add support for the socrates board (MPC8544).

2009-03-31 Thread Grant Likely
: {.type = IRQ_TYPE_LEVEL_HIGH}, Static variables are initialized to zero. Everything that is 0 can be dropped from this initializer (lines 0 and 3-7, and the irq_line field). g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-03-31 Thread Grant Likely
On Tue, Mar 31, 2009 at 9:54 AM, Anton Vorontsov avoront...@ru.mvista.com wrote: On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] +       soc8...@e000 { +               #address-cells = 1; +               #size-cells = 1; +               device_type = soc; Drop

Re: [PATCH 0/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-03-31 Thread Grant Likely
caused. Heh, no worries. At least this way you get a bonus round of review. :-) g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Patch: Fix fec_mpc52xx driver to use net_device_ops

2009-03-31 Thread Grant Likely
for the patches I sent out last night (labeled [PATCH 02/14] and [PATCH 03/14]) and reply to each of them with an Acked-by: line if they look good to you. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev

Re: Patch: Fix fec_mpc52xx driver to use net_device_ops

2009-03-31 Thread Grant Likely
, +       .ndo_set_mac_address    = mpc52xx_fec_set_mac_address, +       .ndo_do_ioctl           = mpc52xx_fec_ioctl, What about change_mtu? Don't you want:          .ndo_change_mtu         = eth_change_mtu, Yes, you're right. fixed. Thanks, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies

Re: [PATCH] net/fec_mpc52xx: fix BUG on missing dma_ops

2009-03-31 Thread Grant Likely
Thanks Becky. g. 2009/3/31 Becky Bruce bec...@kernel.crashing.org: On Mar 30, 2009, at 9:25 PM, Grant Likely wrote: From: Grant Likely grant.lik...@secretlab.ca The driver triggers a BUG_ON() when allocating DMA buffers if the arch/powerpc dma_ops from the of_platform device

Re: [PATCH v2] powerpc: i2c-mpc: preserve I2C clocking

2009-03-31 Thread Grant Likely
the FSL 5200 clocking mechanism. + - fsl,preserve-clocking : boolean; if defined, the clock settings +   from the bootloader are preserved (not touched).  Example :        ...@3000 { -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: Build error

2009-03-31 Thread Grant Likely
now. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Build error

2009-03-31 Thread Grant Likely
if my mailer wraps it, it's a one-liner, you can handle it I'm sure :-) Signed-off-by: Segher Boessenkool seg...@kernel.crashing.org Heh, you beat me to it Segher. Acked-by: Grant Likely grant.lik...@secretlab.ca g. Author: Segher Boessenkool seg...@kernel.crashing.org Date:   Fri Mar 27

Re: [PATCH 00/14] Add common OF device tree support for MDIO busses

2009-03-31 Thread Grant Likely
On Tue, Mar 31, 2009 at 3:57 PM, David Miller da...@davemloft.net wrote: From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 31 Mar 2009 02:26:43 -0600 David, as I mentioned below, I'd really like to get the core changes (1, 4, 5  6) merged into 2.6.30 (assuming Andy confirms

Re: [PATCH 00/14] Add common OF device tree support for MDIO busses

2009-03-31 Thread Grant Likely
On Tue, Mar 31, 2009 at 4:22 PM, David Miller da...@davemloft.net wrote: From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 31 Mar 2009 16:19:42 -0600 On Tue, Mar 31, 2009 at 3:57 PM, David Miller da...@davemloft.net wrote: It therefore didn't get any -next exposure, so it's

Re: [PATCH 00/14] Add common OF device tree support for MDIO busses

2009-03-31 Thread Grant Likely
On Tue, Mar 31, 2009 at 9:38 PM, David Miller da...@davemloft.net wrote: From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 31 Mar 2009 19:45:02 -0600 Dammit.  Why did you have to go and sound so reasonable when I was all geared up for a pointless flame war. well... alright... but I

Re: [PATCH 00/14] Add common OF device tree support for MDIO busses

2009-03-31 Thread Grant Likely
On Tue, Mar 31, 2009 at 11:16 PM, David Miller da...@davemloft.net wrote: From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 31 Mar 2009 22:56:38 -0600 At the very least, please consider picking up patches 2 3.  They address a real bug (unrelated to the MDIO rework), and only touch

[PATCH 0/3] Series short description

2009-04-01 Thread Grant Likely
files changed, 44 insertions(+), 33 deletions(-) Cheers, g. -- Grant Likely, B.Sc. P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 1/3] net/fec_mpc52xx: fix BUG on missing dma_ops

2009-04-01 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca The driver triggers a BUG_ON() when allocating DMA buffers because the arch/powerpc dma_ops aren't in the net_device's struct device. This patch fixes the problem by using the parent of_device which does have the correct dma_ops set. Signed-off

[PATCH 2/3] net/fec_mpc52xx: Migrate to net_device_ops.

2009-04-01 Thread Grant Likely
From: Henk Stegeman henk.stege...@gmail.com Since not using net_device_ops gets you shunned out the cool crowd, this patch modifies the fec_mpc52xx Ethernet driver to provide the management hooks via a struct net_device_ops. Reported-by: Henk Stegeman henk.stege...@gmail.com Signed-off-by: Grant

[PATCH 3/3] net/fec_mpc52xx: Don't dereference phy_device if it is NULL

2009-04-01 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca The FEC Ethernet device isn't always attached to a phy. Be careful not to dereference phy_device if it is NULL. Also eliminates an unnecessary extra function from the ioctl path. Reported-by: Henk Stegeman henk.stege...@gmail.com Signed-off

Re: powerpc/85xx: Add support for the socrates board (MPC8544)

2009-04-01 Thread Grant Likely
On Wed, Apr 1, 2009 at 1:36 AM, Wolfgang Grandegger w...@grandegger.com wrote: Anton Vorontsov wrote: On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote: [...] +       soc8...@e000 { +               #address-cells = 1; +               #size-cells = 1

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Grant Likely
On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: The table definition is more verbose this way, but I think it results in more understandable and easier to extend code.  It also adds lets the compiler do more type checking for you. OK but I

Re: [PATCH v2] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Grant Likely
-04-01 12:09:18.796719327 +0200 @@ -39,7 +39,7 @@  #include sysdev/fsl_soc.h  #include mm/mmu_decl.h  #include asm/cpm2.h - +#define DEBUG ^^^ oops? g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc

Re: [PATCH v2] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Grant Likely
On Wed, Apr 1, 2009 at 7:44 AM, Grant Likely grant.lik...@secretlab.ca wrote: On Wed, Apr 1, 2009 at 7:13 AM, Wolfgang Grandegger w...@grandegger.com wrote: This patch makes the I2C bus speed configurable by using the I2C node property clock-frequency. If the property is not defined, the old

Re: [PATCH 5/8] powerpc: i2c-mpc: make I2C bus speed configurable

2009-04-01 Thread Grant Likely
On Wed, Apr 1, 2009 at 7:41 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: The table definition is more verbose this way, but I think it results in more understandable

Re: [PATCH 0/3] Series short description

2009-04-02 Thread Grant Likely
On Thu, Apr 2, 2009 at 1:57 AM, David Miller da...@davemloft.net wrote: From: Grant Likely grant.lik...@secretlab.ca Date: Wed, 01 Apr 2009 00:16:46 -0600 Here are the fec_mpc52xx patches which should be picked up for 2.6.29. Patch #1 fixes a dma related BUG_ON() discovered after the merge

Re: [PATCH] mtd: physmap_of: Add multiple regions and concatenation support

2009-04-03 Thread Grant Likely
post the binding documentation. Signed-off-by: Stefan Roese s...@denx.de CC: Grant Likely grant.lik...@secretlab.ca ---  drivers/mtd/maps/physmap_of.c |  174 -  1 files changed, 120 insertions(+), 54 deletions(-) diff --git a/drivers/mtd/maps

Re: [PATCH] fec fix: Use OF 'ethernet' device as a provider of dma ops.

2009-04-03 Thread Grant Likely
= of_address_to_resource(op-node, 0, mem);        if (rv) { -- 1.5.2.2 -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: Draft version of ML510 Linux patch (patch inlined)

2009-04-03 Thread Grant Likely
On Wed, Apr 1, 2009 at 1:16 PM, Roderick Colenbrander thunderbir...@gmail.com wrote: Hi, As requested by Grant Likely here the same patch but now inlined. word wrapped. neener neener. Mostly looks good to me. It would help to split the PCI driver out into a separate patch from the board

Re: GDB problem with Xilinx GIT Linux on Virtex5FX PPC440

2009-04-03 Thread Grant Likely
partition) Type of the rootfs Thank you very much in advance. Best regards, Frederic ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev -- Grant Likely, B.Sc., P.Eng. Secret Lab

Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-05 Thread Grant Likely
);                substream-runtime-private_data = NULL; -- 1.5.6.5 ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [PATCH] ASoC: fsl_dma: Pass the proper device for dma mapping routines

2009-04-05 Thread Grant Likely
On Sun, Apr 5, 2009 at 2:52 AM, Anton Vorontsov avoront...@ru.mvista.com wrote: On Sat, Apr 04, 2009 at 11:59:39PM -0600, Grant Likely wrote: Becky Kumar, Considering these fixups, would it be advisable for the dma functions to climb up the dev-parent linkage when dma_ops are NULL? pcm-dev

Re: [PATCH] powerpc: Print information about mapping hw irqs to virtual irqs

2009-04-06 Thread Grant Likely
when we map an irq. The message is only printed the first time the irq is mapped, and it's KERN_DEBUG so most people won't see it. Signed-off-by: Michael Ellerman mich...@ellerman.id.au Acked-by: Grant Likely grant.lik...@secretlab.ca ---  arch/powerpc/kernel/irq.c |    4 +++-  1 files

Re: [PATCH v3 3/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-07 Thread Grant Likely
Wolfgang. Acked-by: Grant Likely grant.lik...@secretlab.ca ---  drivers/i2c/busses/i2c-mpc.c |  262 +++  1 file changed, 242 insertions(+), 20 deletions(-) Index: linux-2.6-galak/drivers/i2c/busses/i2c-mpc.c

Re: [PATCH v3 1/5] i2c: i2c-mpc: various coding style fixes

2009-04-07 Thread Grant Likely
On Tue, Apr 7, 2009 at 1:20 AM, Wolfgang Grandegger w...@grandegger.com wrote: Fix errors reported by checkpatch (indention, long lines, trailing white space, etc.). Signed-off-by: Wolfgang Grandegger w...@grandegger.com Acked-by: Grant Likely grant.lik...@secretlab.ca ---  drivers/i2c

Re: [PATCH v3 2/5] i2c: i2c-mpc: use dev based printout function

2009-04-07 Thread Grant Likely
On Tue, Apr 7, 2009 at 1:20 AM, Wolfgang Grandegger w...@grandegger.com wrote: This patch used the dev_dbg, dev_err, etc. functions for debug and error output instead of printk and pr_debug. Signed-off-by: Wolfgang Grandegger w...@grandegger.com Acked-by: Grant Likely grant.lik

Re: [PATCH v3 4/5] powerpc: i2c-mpc: document new FSL I2C bindings and cleanup

2009-04-07 Thread Grant Likely
-off-by: Wolfgang Grandegger w...@grandegger.com Acked-by: Grant Likely grant.lik...@secretlab.ca ---  Documentation/powerpc/dts-bindings/fsl/i2c.txt |   46 -  include/linux/fsl_devices.h                    |    4 --  2 files changed, 31 insertions(+), 19 deletions

Re: AMCC 440EP phy detection

2009-04-07 Thread Grant Likely
is the broadcast address. All phys will usually respond to address 0 accesses. Off the top of my head, It sounds like one PHY is responding to addresses 0 1, and the other phy isn't responding at all. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-07 Thread Grant Likely
the board one got picked up by Ben.  I'll deal with the doc/binding update. hrummm. As I mentioned in my reply, I'm not convinced that the board one is the right thing in this case. I would have preferred it to be deferred. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-07 Thread Grant Likely
On Tue, Apr 7, 2009 at 10:22 PM, Kumar Gala ga...@kernel.crashing.org wrote: On Apr 8, 2009, at 12:16 AM, Grant Likely wrote: On Tue, Apr 7, 2009 at 10:11 PM, Kumar Gala ga...@kernel.crashing.org wrote: On Apr 7, 2009, at 3:20 AM, Wolfgang Grandegger wrote: This patch series makes the I2C

Re: [PATCH v3 5/5] powerpc/85xx: i2c-mpc: use new I2C bindings for the Socates board

2009-04-08 Thread Grant Likely
On Wed, Apr 8, 2009 at 12:16 AM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: On Tue, Apr 7, 2009 at 1:20 AM, Wolfgang Grandegger w...@grandegger.com wrote: Preserve I2C clock settings for the Socrates MPC8544 board. I had thought that the preserve-clocking property

Re: AMCC 440EP phy detection

2009-04-08 Thread Grant Likely
better is the platform specific boot code (firmware or equivalent) g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] Xilinx : Framebuffer Driver: Add PLB support (non-DCR)

2009-04-09 Thread Grant Likely
about that? Andrei was copied on the patch, we'll see if he has any thoughts about it. I also hold copyright on this file and I want the license to stay GPLv2. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing

Re: [PATCH] Xilinx : Framebuffer Driver: Add PLB support (non-DCR)

2009-04-09 Thread Grant Likely
below 2GB (or even below 1GB). It depends on the design. Regardless, it is good practice to use phys_addr_t instead of u32 for physical addresses. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH 1/4 v2] mtd: physmap_of: Add multiple regions and concatenation support

2009-04-11 Thread Grant Likely
of 2 non-identical NOR chips on one die. Additionally partitions now can span over multiple chips. [...] Signed-off-by: Stefan Roese s...@denx.de CC: Grant Likely grant.lik...@secretlab.ca Looks good to me. To comments below, but neither are enough to hold back my: Reviewd-by: Grant Likely

Re: [PATCH 3/4 v2] mtd/powerpc: Remove unused device-width property

2009-04-12 Thread Grant Likely
CC: Grant Likely grant.lik...@secretlab.ca The device tree describes the hardware, not what Linux happens to do with it at the moment. I'd rather keep it. I find it rather confusing to see such bindings that are not supported. One could expect something to happen/change after defining

Re: [PATCH 4/4 v2] mtd/powerpc: Describe multiple reg tuples usage

2009-04-12 Thread Grant Likely
On Tue, Apr 7, 2009 at 2:39 AM, Stefan Roese s...@denx.de wrote: Signed-off-by: Stefan Roese s...@denx.de CC: Grant Likely grant.lik...@secretlab.ca ---  Documentation/powerpc/dts-bindings/mtd-physmap.txt |   20 +++-  1 files changed, 19 insertions(+), 1 deletions(-) diff

Re: [PATCH 2/4 v2] mtd/powerpc: Factor out MTD physmap bindings into mtd-physmap.txt

2009-04-12 Thread Grant Likely
On Tue, Apr 7, 2009 at 2:39 AM, Stefan Roese s...@denx.de wrote: Signed-off-by: Stefan Roese s...@denx.de Acked-by: Grant Likely grant.lik...@secretlab.ca But you should really have a commit message of some sort describing the reason for the change. g. ---  Documentation/powerpc/booting

Re: [PATCH] [V2] Xilinx : Framebuffer Driver: Add PLB support (non-DCR)

2009-04-12 Thread Grant Likely
applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [PATCH] Powerpc: Xilinx: Intc: Fix level irqs which have duplicates

2009-04-12 Thread Grant Likely
attachments immediately. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] [V2] Xilinx : Framebuffer Driver: Add PLB support(non-DCR)

2009-04-13 Thread Grant Likely
: Add PLB support(non-DCR) I thought it was based on mainline, but I now see the weirdness you're talking about.  I'll dig in on this and let you know more as I'm confused also. -- John -Original Message- From: Grant Likely [mailto:grant.lik...@secretlab.ca] Sent: Sunday

Re: [BUILD FAILURE 11/12] Next April 14 : PPC64 randconfig [drivers/spi/mpc52xx_psc_spi.c]

2009-04-14 Thread Grant Likely
: *** [drivers] Error 2 --- Regards-- Subrata -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [RFC v2] virtio: add virtio-over-PCI driver

2009-04-14 Thread Grant Likely
many issues in this area. As you say, it won't take much to code it up. I'll be poking my VHDL engineer to make it do what I want it to. :-) I'll keep you up to date on my progress. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [RFC v2] virtio: add virtio-over-PCI driver

2009-04-14 Thread Grant Likely
the host to the boards (reads). Our bandwidth requirements are 'to the host', so we can live with the asymmetry in performance. Fortunately I don't have very high bandwidth requirements for the first spin, so I have some room to experiment. :-) g. -- Grant Likely, B.Sc., P.Eng. Secret Lab

Re: [BUILD FAILURE 11/12] Next April 14 : PPC64 randconfig [drivers/spi/mpc52xx_psc_spi.c]

2009-04-14 Thread Grant Likely
Damn. I didn't reply to all earlier in the thread. Adding back the mailing list. On Tue, Apr 14, 2009 at 4:27 PM, Anton Vorontsov avoront...@ru.mvista.com wrote: On Tue, Apr 14, 2009 at 04:19:56PM -0600, Grant Likely wrote: On Tue, Apr 14, 2009 at 4:02 PM, Anton Vorontsov avoront

Re: [PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

2009-04-15 Thread Grant Likely
applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [PATCH] powerpc/fsl: Remove cell-index from PCI nodes

2009-04-15 Thread Grant Likely
...@kernel.crashing.org Acked-by: Grant Likely grant.lik...@secretlab.ca ---  arch/powerpc/boot/dts/mpc832x_mds.dts          |    1 -  arch/powerpc/boot/dts/mpc832x_rdb.dts          |    1 -  arch/powerpc/boot/dts/mpc8349emitx.dts         |    2 --  arch/powerpc/boot/dts/mpc8349emitxgp.dts

Re: [PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

2009-04-15 Thread Grant Likely
? How about when MMIO is used? g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] [V3] Xilinx : Framebuffer Driver: Add PLB support and cleanup DCR

2009-04-15 Thread Grant Likely
On Wed, Apr 15, 2009 at 10:44 AM, Stephen Neuendorffer stephen.neuendorf...@xilinx.com wrote: -Original Message- From: Grant Likely [mailto:grant.lik...@secretlab.ca] Sent: Wednesday, April 15, 2009 9:03 AM To: Stephen Neuendorffer Cc: John Linn; jwbo...@linux.vnet.ibm.com; linux

<    1   2   3   4   5   6   7   8   9   10   >