From: Grant Likely
Remove old artifacts leftover from the platform driver gianfar and
fsl_i2c drivers. These symbols became unused when the drivers
were migrated over to use the of_platform bus.
Signed-off-by: Grant Likely
---
include/linux/fsl_devices.h | 22 --
1
causes me some problems as I need int18 to
> map to external IRQ2.
These numbers are *Linux internal* virtual irq numbers. They have no
relation to the physical IRQ number for each interrupt controller.
Just make sure your Device Tree maps the IRQs correctly and you'll be
operty in your GPS node.
> A secondary question: where to properly add this function call in the file
> system?
Use of_register_platform_driver() to register your of_platform_driver
in your module's init function.
> Are we on the right track here? Is there sa
From: Grant Likely
The driver triggers a BUG_ON() when allocating DMA buffers if the
arch/powerpc dma_ops from the of_platform device are not copied
into net_device structure.
Signed-off-by: Grant Likely
---
David, do you want to pick this one up right away, or should I merge it
through Ben&#
From: Grant Likely
The driver triggers a BUG_ON() when allocating DMA buffers if the
arch/powerpc dma_ops from the of_platform device are not copied
into net_device structure.
Signed-off-by: Grant Likely
---
Becky, does this look better to you?
g.
drivers/net/fec_mpc52xx.c | 19
f the functions are
duplicated, then I've got no problem changing the 52xx support to use
common code.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
32541285ee752b935c1c85:
Linus Torvalds (1):
Merge git://git.kernel.org/.../davem/net-2.6
are available in the git repository at:
git://git.secretlab.ca/git/linux-2.6-mpc52xx for-davem
Grant Likely (15):
net/fec_mpc52xx: fix BUG on missing dma_ops
of: add of_parse_phan
From: Grant Likely
of_parse_phandle() is a helper function to read and parse a phandle
property and return a pointer to the resulting device_node.
Signed-off-by: Grant Likely
CC: Michael Ellerman
---
drivers/of/base.c | 24
include/linux/of.h |3 +++
2 files
From: Grant Likely
Since not using net_device_ops gets you shunned out the cool crowd,
this patch modifies the fec_mpc52xx Ethernet driver to provide the
management hooks via a struct net_device_ops.
Reported-by: Henk Stegeman
Signed-off-by: Grant Likely
---
drivers/net/fec_mpc52xx.c | 35
From: Grant Likely
The FEC Ethernet device isn't always attached to a phy. Be careful
not to dereference phy_device if it is NULL.
Reported-by: Henk Stegeman
Signed-off-by: Grant Likely
---
drivers/net/fec_mpc52xx.c | 22 --
1 files changed, 12 insertions(+
From: Grant Likely
This patch makes changes in preparation for supporting open firmware
device tree descriptions of MDIO busses. Changes include:
- Cleanup handling of phy_map[] entries; they are already NULLed when
registering and so don't need to be re-cleared, and it is good practice
From: Grant Likely
Add phy_connect_direct() and phy_attach_direct() functions so that
drivers can use a pointer to the phy_device instead of trying to determine
the phy's bus_id string.
This patch is useful for OF device tree descriptions of phy devices where
the driver doesn't ne
From: Grant Likely
Add support for parsing the device tree for PHY devices on an MDIO bus
CC: Andy Fleming
CC: linuxppc-dev@ozlabs.org
CC: devtree-disc...@ozlabs.org
Signed-off-by: Grant Likely
---
drivers/of/Kconfig |6 ++
drivers/of/Makefile |1
drivers/of/of_mdio.c
From: Grant Likely
The patch reworks the MPC5200 Fast Ethernet Controller (FEC) driver to
use the of_mdio infrastructure for registering PHY devices from data out
openfirmware device tree, and eliminates the assumption that the PHY
for the FEC is always attached to the FEC's own MDIO bus.
From: Grant Likely
This patch simplifies the driver by making use of more common code.
Signed-off-by: Grant Likely
---
drivers/net/fsl_pq_mdio.c | 53 +++--
1 files changed, 4 insertions(+), 49 deletions(-)
diff --git a/drivers/net/fsl_pq_mdio.c b
From: Grant Likely
This patch simplifies the driver by making use of more common code.
Signed-off-by: Grant Likely
---
drivers/net/gianfar.c | 103 ++---
drivers/net/gianfar.h |3 +
2 files changed, 40 insertions(+), 66 deletions(-)
diff
From: Grant Likely
This patch simplifies the driver by making use of more common code.
Signed-off-by: Grant Likely
---
drivers/net/ucc_geth.c | 47 ---
drivers/net/ucc_geth.h |2 +-
2 files changed, 13 insertions(+), 36 deletions(-)
diff
From: Grant Likely
This patch simplifies the driver by making use of more common code.
Tested-by: Olof Johansson
Acked-by: Olof Johansson
Signed-off-by: Grant Likely
---
arch/powerpc/platforms/pasemi/gpio_mdio.c | 32 +
drivers/net/pasemi_mac.c
From: Grant Likely
This patch modifies the bitbanged MDIO driver in the ep8248e platform
code to use the common of_mdio infrastructure.
Signed-off-by: Grant Likely
---
arch/powerpc/platforms/82xx/ep8248e.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch
From: Grant Likely
This patch adds support for the Xilinx ll_temac 10/100/1000 Ethernet
device. The ll_temac ipcore is typically used on Xilinx Virtex and
Spartan designs attached to either a PowerPC 4xx or Microblaze
processor.
At the present moment, this driver only works with Virtex5
From: Grant Likely
This patch simplifies the driver by making use of more common code.
Signed-off-by: Grant Likely
---
drivers/net/fs_enet/fs_enet-main.c | 69 ++--
drivers/net/fs_enet/mii-bitbang.c | 29 +--
drivers/net/fs_enet/mii-fec.c
On Tue, Mar 31, 2009 at 3:35 AM, Wolfgang Grandegger
wrote:
> Grant Likely wrote:
>> I agree 100% with David's comments, and I have some additional ones below.
>>
>> On Thu, Mar 19, 2009 at 9:26 AM, Wolfgang Grandegger
>> wrote:
>>> + soc8...@e000
On Tue, Mar 31, 2009 at 7:36 AM, Wolfgang Grandegger
wrote:
> Grant Likely wrote:
>> On Tue, Mar 31, 2009 at 3:35 AM, Wolfgang Grandegger
>> wrote:
>>> Grant Likely wrote:
>>>> I agree 100% with David's comments, and I have some additional ones below.
nd this ...
> --- linux-2.6.orig/arch/powerpc/platforms/52xx/mpc52xx_common.c 2009-03-31
> 13:25:08.0 +0200
> +++ linux-2.6/arch/powerpc/platforms/52xx/mpc52xx_common.c 2009-03-31
> 13:28:54.309718526 +0200
> +int fsl_i2c_get_fdr(struct device_node *node, u32 i2c
gt;> > + mpc_i2c_setclock(i2c);
>> > + }
>>
>> No, because the I2C registers are not yet mapped.
>
> Sorry, I used misleading words :) With 'here' I meant 'at this
> position', i.e. insert my above block where mpc_i2c_setclock was used
= {0, IRQ_TYPE_NONE},
> + [7] = {0, IRQ_TYPE_NONE},
> + [8] = {0, IRQ_TYPE_LEVEL_HIGH},
> +};
It is good practice to use named elements in initializers: {.type =
IRQ_TYPE_LEVEL_HIGH},
Static variables are initialized to zero. Everything that is 0 can be
dropped from t
On Tue, Mar 31, 2009 at 9:54 AM, Anton Vorontsov
wrote:
> On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote:
> [...]
>> >>>>> + soc8...@e000 {
>> >>>>> + #address-cells = <1>;
>> >>>>&
aused.
Heh, no worries. At least this way you get a bonus round of review. :-)
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
ches I sent out last
night (labeled [PATCH 02/14] and [PATCH 03/14]) and reply to each of
them with an "Acked-by:" line if they look good to you.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
+ .ndo_validate_addr = eth_validate_addr,
>> + .ndo_set_mac_address = mpc52xx_fec_set_mac_address,
>> + .ndo_do_ioctl = mpc52xx_fec_ioctl,
>>
> What about change_mtu? Don't you want:
> .ndo_change_mtu = eth_change_mtu,
Ye
Thanks Becky.
g.
2009/3/31 Becky Bruce :
>
> On Mar 30, 2009, at 9:25 PM, Grant Likely wrote:
>
>> From: Grant Likely
>>
>> The driver triggers a BUG_ON() when allocating DMA buffers if the
>> arch/powerpc dma_ops from the of_platform device are not co
On Tue, Mar 31, 2009 at 2:01 PM, Wolfgang Grandegger
wrote:
> The i2c node property "fsl,preserve-clocking" allows to overtake the
> clock settings from the boot loader avoiding the hard-coded settings.
>
> Signed-off-by: Wolfgang Grandegger
Acked-by: Grant Likely
; branch...
>
> Ah .. .weird :-)
>
> Oh well, I'll see if it still happens after I pull back from Linus (who
> merged all our stuff) and if it does, I'll send you my .config.
It is triggered when the driver is built as a module. I'm going to
post the fix right now.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
told
> you about it (on IRC), but you were too busy or something :-)
>
> A simple ppc6xx_defconfig is enough to reproduce, fwiw.
>
> Here's the patch I used, sorry if my mailer wraps it, it's a one-liner,
> you can handle it I'm sure :-)
>
> Sig
On Tue, Mar 31, 2009 at 2:59 PM, Yann Pelletier
wrote:
>> Message: 7
>> Date: Mon, 30 Mar 2009 10:32:17 -0600
>> From: Grant Likely
>> Subject: > To: Yann Pelletier
>> Cc: "linuxppc-dev@ozlabs.org"
>> Message-ID:
>>
>> Cont
On Tue, Mar 31, 2009 at 3:57 PM, David Miller wrote:
> From: Grant Likely
> Date: Tue, 31 Mar 2009 02:26:43 -0600
>
>> David, as I mentioned below, I'd really like to get the core changes
>> (1, 4, 5 6) merged into 2.6.30 (assuming Andy confirms they are okay).
>
&
On Tue, Mar 31, 2009 at 4:22 PM, David Miller wrote:
> From: Grant Likely
> Date: Tue, 31 Mar 2009 16:19:42 -0600
>
>> On Tue, Mar 31, 2009 at 3:57 PM, David Miller wrote:
>> > It therefore didn't get any -next exposure, so it's unreasonable to
>> >
On Tue, Mar 31, 2009 at 9:38 PM, David Miller wrote:
> From: Grant Likely
> Date: Tue, 31 Mar 2009 19:45:02 -0600
>
>> Dammit. Why did you have to go and sound so reasonable when I was all
>> geared up for a pointless flame war.
>>
>> well... alright... but I r
On Tue, Mar 31, 2009 at 11:16 PM, David Miller wrote:
> From: Grant Likely
> Date: Tue, 31 Mar 2009 22:56:38 -0600
>
>> At the very least, please consider picking up patches 2 & 3. They
>> address a real bug (unrelated to the MDIO rework), and only touch the
>>
--
1 files changed, 44 insertions(+), 33 deletions(-)
Cheers,
g.
--
Grant Likely, B.Sc. P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
From: Grant Likely
The driver triggers a BUG_ON() when allocating DMA buffers because the
arch/powerpc dma_ops aren't in the net_device's struct device. This
patch fixes the problem by using the parent of_device which does have
the correct dma_ops set.
Signed-off-by: Grant Likely
R
From: Henk Stegeman
Since not using net_device_ops gets you shunned out the cool crowd,
this patch modifies the fec_mpc52xx Ethernet driver to provide the
management hooks via a struct net_device_ops.
Reported-by: Henk Stegeman
Signed-off-by: Grant Likely
---
drivers/net/fec_mpc52xx.c
From: Grant Likely
The FEC Ethernet device isn't always attached to a phy. Be careful
not to dereference phy_device if it is NULL. Also eliminates an
unnecessary extra function from the ioctl path.
Reported-by: Henk Stegeman
Signed-off-by: Grant Likely
---
drivers/net/fec_mpc52xx.c |
On Wed, Apr 1, 2009 at 1:36 AM, Wolfgang Grandegger wrote:
> Anton Vorontsov wrote:
>> On Tue, Mar 31, 2009 at 09:05:28AM -0600, Grant Likely wrote:
>> [...]
>>>>>>>> + soc8...@e000 {
>>>>>>>> +
On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger wrote:
> Grant Likely wrote:
>> The table definition is more verbose this way, but I think it results
>> in more understandable and easier to extend code. It also adds lets
>> the compiler do more type checking for you.
&g
k %d Hz (dfsrr=%d fdr=%d)\n",
> + clock, fdr >> 8, fdr & 0xff);
> }
Very neat and tidy indeed. I like this.
> Index: linux-2.6/arch/powerpc/sysdev/fsl_soc.c
> =======
> --- linu
On Wed, Apr 1, 2009 at 7:44 AM, Grant Likely wrote:
> On Wed, Apr 1, 2009 at 7:13 AM, Wolfgang Grandegger
> wrote:
>> This patch makes the I2C bus speed configurable by using the I2C node
>> property "clock-frequency". If the property is not defined, the old
>>
On Wed, Apr 1, 2009 at 7:27 AM, Kumar Gala wrote:
>
> On Apr 1, 2009, at 8:10 AM, Wolfgang Grandegger wrote:
>
>> Grant Likely wrote:
>>>
>>> On Wed, Apr 1, 2009 at 1:36 AM, Wolfgang Grandegger
>>> wrote:
>>>>
>>>> Anton Vor
On Wed, Apr 1, 2009 at 7:41 AM, Wolfgang Grandegger wrote:
> Grant Likely wrote:
>> On Wed, Apr 1, 2009 at 1:51 AM, Wolfgang Grandegger
>> wrote:
>>> Grant Likely wrote:
>>>> The table definition is more verbose this way, but I think it results
>>>
On Thu, Apr 2, 2009 at 1:57 AM, David Miller wrote:
> From: Grant Likely
> Date: Wed, 01 Apr 2009 00:16:46 -0600
>
>> Here are the fec_mpc52xx patches which should be picked up for 2.6.29.
>> Patch #1 fixes a dma related BUG_ON() discovered after the merge window
>
extra credit,
factor out the MTD stuff and move it to
Documentation/powerpc/dts-bindings/. Remember to cc: the
devicetree-disc...@ozlabs.org list when you post the binding
documentation.
> Signed-off-by: Stefan Roese
> CC: Grant Likely
> ---
> drivers/mtd/maps/physmap_of.c | 174
>
);
>
> bcom_submit_next_buffer(priv->rx_dmatsk, rskb);
>
> @@ -499,7 +510,7 @@ static irqreturn_t mpc52xx_fec_rx_interrupt(int irq, void
> *dev_id)
> bcom_prepare_next_buffer(priv->rx_dmatsk);
>
> bd->status
On Wed, Apr 1, 2009 at 1:16 PM, Roderick Colenbrander
wrote:
> Hi,
>
> As requested by Grant Likely here the same patch but now inlined.
word wrapped. neener neener.
Mostly looks good to me. It would help to split the PCI driver out
into a separate patch from the board support.
n
> location of the rootfs (ramdisk, SysACE partition, flash Uboot partition)
> Type of the rootfs
>
> Thank you very much in advance.
>
> Best regards,
>
> Frederic
>
>
>
> ___
> Linuxppc-dev mailing list
&
oherent(substream->pcm->dev,
> + dma_free_coherent(substream->pcm->card->dev,
> sizeof(struct fsl_dma_private),
> dma_private, dma_private->ld_buf_phys);
> substream->runtime->private_data = NULL;
> --
> 1.5.6.5
> ___
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
On Sun, Apr 5, 2009 at 2:52 AM, Anton Vorontsov
wrote:
> On Sat, Apr 04, 2009 at 11:59:39PM -0600, Grant Likely wrote:
>> Becky & Kumar,
>>
>> Considering these fixups, would it be advisable for the dma functions
>> to climb up the dev->parent linkage when dma_
when we map an
> irq. The message is only printed the first time the irq is mapped,
> and it's KERN_DEBUG so most people won't see it.
>
> Signed-off-by: Michael Ellerman
Acked-by: Grant Likely
> ---
> arch/powerpc/kernel/irq.c | 4 +++-
> 1 files changed, 3 inser
s they are obsolete.
>
> Signed-off-by: Wolfgang Grandegger
I haven't tested it, but it looks good and I trust Wolfgang.
Acked-by: Grant Likely
> ---
> drivers/i2c/busses/i2c-mpc.c | 262
> +
On Tue, Apr 7, 2009 at 1:20 AM, Wolfgang Grandegger wrote:
> Fix errors reported by checkpatch (indention, long lines, trailing
> white space, etc.).
>
> Signed-off-by: Wolfgang Grandegger
Acked-by: Grant Likely
> ---
> drivers/i2c/busse
On Tue, Apr 7, 2009 at 1:20 AM, Wolfgang Grandegger wrote:
> This patch used the dev_dbg, dev_err, etc. functions for debug
> and error output instead of printk and pr_debug.
>
> Signed-off-by: Wolfgang Grandegger
Acked-by: Grant Likely
> ---
> drivers/i2c/busse
cell-index = <1>;
> - compatible = "fsl-i2c";
> + compatible = "fsl,mpc8544-i2c", "fsl-i2c";
> reg = <0x3100 0x100>;
> interrupts = <43 2>
> Signed-off-by: Wolfgang Grandegger
Acked-by: Grant Likely
> ---
> Documentation/powerpc/dts-bindings/fsl/i2c.txt | 46
> -
> include/linux/fsl_devices.h | 4 --
> 2 files changed, 31 insertions(+), 19 deletions(-)
>
> Index: li
have run into a
> similar problem or have a suggestion.
Phy address 0 is the broadcast address. All phys will usually respond
to address 0 accesses. Off the top of my head, It sounds like one PHY
is responding to addresses 0 & 1, and the other phy isn&
xx: i2c-mpc: use new I2C bindings for the Socates board
>
> I would have preferred these two go via me, but it looks like the board one
> got picked up by Ben. I'll deal with the doc/binding update.
hrummm. As I mentioned in my reply, I'm not convinced that the board
one is the
On Tue, Apr 7, 2009 at 10:22 PM, Kumar Gala wrote:
>
> On Apr 8, 2009, at 12:16 AM, Grant Likely wrote:
>
>> On Tue, Apr 7, 2009 at 10:11 PM, Kumar Gala
>> wrote:
>>>
>>> On Apr 7, 2009, at 3:20 AM, Wolfgang Grandegger wrote:
>>>
>>>&g
On Wed, Apr 8, 2009 at 12:16 AM, Wolfgang Grandegger
wrote:
> Grant Likely wrote:
>> On Tue, Apr 7, 2009 at 1:20 AM, Wolfgang Grandegger
>> wrote:
>>> Preserve I2C clock settings for the Socrates MPC8544 board.
>>
>> I had thought that the preserve-clockin
ewemac
> driver since it is very platform/board specific. The platform code is
> definitely a better place.
Even better is the platform specific boot code (firmware or equivalent)
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
of the GNU General Public
>> > + * License along with this program; if not, write to the Free
>> > + * Software Foundation, Inc., 675 Mass Ave, Cambridge, MA
>> > + * 02139, USA.
>>
>> This changes the license for this file (from "GPLv2" to &
fb_info info; /* FB driver info record */
>> >
>> >+ u32 regs_phys; /* phys. address of the control
>> >+ registers */
>>
>> Is this driver usable on the 440 based Xilinx devices? If
onsists of 2 non-identical NOR chips on one die. Additionally
> partitions now can span over multiple chips.
>
[...]
> Signed-off-by: Stefan Roese
> CC: Grant Likely
Looks good to me. To comments below, but neither are enough to hold back my:
Reviewd-by: Grant Likely
However, I ha
>
>> > Signed-off-by: Stefan Roese
>> > CC: Grant Likely
>>
>> The device tree describes the hardware, not what Linux happens to do
>> with it at the moment.
>>
>> I'd rather keep it.
>
> I find it rather confusing to "see" s
On Tue, Apr 7, 2009 at 2:39 AM, Stefan Roese wrote:
> Signed-off-by: Stefan Roese
> CC: Grant Likely
> ---
> Documentation/powerpc/dts-bindings/mtd-physmap.txt | 20
> +++-
> 1 files changed, 19 insertions(+), 1 deletions(-)
>
> diff --git a/D
On Tue, Apr 7, 2009 at 2:39 AM, Stefan Roese wrote:
> Signed-off-by: Stefan Roese
Acked-by: Grant Likely
But you should really have a commit message of some sort describing
the reason for the change.
g.
> ---
> Documentation/powerpc/booting-without-of.txt
.a", },
> { .compatible = "xlnx,plb-dvi-cntlr-ref-1.00.c", },
> {},
> @@ -412,22 +515,6 @@ static struct of_platform_driver xilinxfb_of_driver = {
> },
> };
>
> -/* Registration helpers to keep the number of #ifdefs to a minimum */
> -static inli
amp;xilinx_intc_level_irqchip,
> + handle_level_irq);
> + } else {
> + set_irq_chip_and_handler(virq, &xilinx_intc_edge_irqchip,
> + handle_edge_irq);
> + }
> return 0;
> }
; d...@ozlabs.org; akonova...@ru.mvista.com
>> Subject: RE: [PATCH] [V2] Xilinx : Framebuffer Driver: Add PLB
>> support(non-DCR)
>>
>> I thought it was based on mainline, but I now see the weirdness you're
>> talking about. I'll dig in on
>>
s/spi] Error 2
> make: *** [drivers] Error 2
> ---
>
> Regards--
> Subrata
>
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
ked closely at the xilinx pci data sheet
yet, but I don't expect too many issues in this area. As you say, it
won't take much to code it up. I'll be poking my VHDL engineer to
make it do what I want it to. :-)
I'll keep you up to date on my progress.
g.
--
Grant Likely, B.Sc.,
So the PCI target board DMA controllers are used to
> transfer data efficiently to the x86 host (writes)
> and less efficiently from the host to the boards
> (reads). Our bandwidth requirements are 'to the host',
> so we can live with the asymmetry in performance.
Fortunately I d
Damn. I didn't "reply to all" earlier in the thread. Adding back the
mailing list.
On Tue, Apr 14, 2009 at 4:27 PM, Anton Vorontsov
wrote:
> On Tue, Apr 14, 2009 at 04:19:56PM -0600, Grant Likely wrote:
>> On Tue, Apr 14, 2009 at 4:02 PM, Anton Vorontsov
>> wrote
ter(void) { }
> -#endif /* CONFIG_OF */
>
> /* -----
> * Module setup and teardown
> @@ -500,28 +523,18 @@ static inline void __exit xilinxfb_of_unregister(void)
> { }
> static int __init
> xilinxfb_init(void)
> {
> - int rc;
> - rc = xilinxfb_of_register();
> - if (rc)
> - return rc;
> -
> - rc = platform_driver_register(&xilinxfb_platform_driver);
> - if (rc)
> - xilinxfb_of_unregister();
> -
> - return rc;
> + return of_register_platform_driver(&xilinxfb_of_driver);
> }
>
> static void __exit
> xilinxfb_cleanup(void)
> {
> - platform_driver_unregister(&xilinxfb_platform_driver);
> - xilinxfb_of_unregister();
> + of_unregister_platform_driver(&xilinxfb_of_driver);
> }
>
> module_init(xilinxfb_init);
> module_exit(xilinxfb_cleanup);
>
> MODULE_AUTHOR("MontaVista Software, Inc. ");
> -MODULE_DESCRIPTION(DRIVER_DESCRIPTION);
> +MODULE_DESCRIPTION("Xilinx TFT frame buffer driver");
> MODULE_LICENSE("GPL");
> --
> 1.6.2.1
>
>
>
> This email and any attachments are intended for the sole use of the named
> recipient(s) and contain(s) confidential information that may be proprietary,
> privileged or copyrighted under applicable law. If you are not the intended
> recipient, do not read, copy, or forward this email message or any
> attachments. Delete this email message and any attachments immediately.
>
>
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
On Wed, Apr 15, 2009 at 9:40 AM, Kumar Gala wrote:
> The cell-index property isn't used on PCI nodes and is ill defined.
> Remove it for now and if someone comes up with a good reason and
> consistent definition for it we can add it back
>
> Signed-off-by: Kumar Gala
Ac
erator for
> this core has both dcr-reg and reg properties (where the reg has been
> translated back through the bridge).
So, what is in the regs and dcr-regs properties when DCR is used?
How about when MMIO is used?
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
On Wed, Apr 15, 2009 at 10:44 AM, Stephen Neuendorffer
wrote:
>
>
>> -Original Message-----
>> From: Grant Likely [mailto:grant.lik...@secretlab.ca]
>> Sent: Wednesday, April 15, 2009 9:03 AM
>> To: Stephen Neuendorffer
>> Cc: John Linn; jwbo...@li
d/powerpc: Factor out MTD physmap bindings into mtd-physmap.txt
>> mtd/powerpc: Describe multiple "reg" tuples usage
>>
>> v2 addresses all comments from Grant Likely, including factoring out the
>> MTD dts bindings documentation into a separate file.
>>
to not clutter booting-without-of.txt more.
>
> Signed-off-by: Stefan Roese
> Acked-by: Grant Likely
> ---
> Changes in ver3:
> - Added short patch desciption to commit message.
>
> Documentation/powerpc/booting-without-of.txt | 89
> +++-
>
On Thu, Apr 16, 2009 at 6:11 AM, Stefan Roese wrote:
> Signed-off-by: Stefan Roese
> CC: Grant Likely
Acked-by: Grant Likely
I'll pick this one up too.
> ---
> Changes in ver3:
> - Removed reference to Intel P30 parts
> - Added exact chip compatible pro
nk-width = <2>;
> partit...@0 {
> label = "test-part1";
> reg = <0 0x0400>;
> };
> };
>
> Signed-off-by: Stefan Roese
> Reviewd-by: Grant Likely
Yup, still looks good to me. What boards h
On Thu, Apr 16, 2009 at 7:37 AM, Stefan Roese wrote:
> On Thursday 16 April 2009, Grant Likely wrote:
>> > Signed-off-by: Stefan Roese
>> > Reviewd-by: Grant Likely
>>
>> Yup, still looks good to me. What boards has this been tested on?
>
> I tested th
On Thu, Apr 16, 2009 at 7:51 AM, Artem Bityutskiy
wrote:
> On Thu, 2009-04-16 at 07:46 -0600, Grant Likely wrote:
>> On Thu, Apr 16, 2009 at 7:37 AM, Stefan Roese wrote:
>> > On Thursday 16 April 2009, Grant Likely wrote:
>> >> > Signed-off-by: Stefan Roese
_var = {
> .activate = FB_ACTIVATE_NOW
> };
>
> +
> +#define PLB_ACCESS_FLAG 0x1 /* 1 = PLB, 0 = DCR */
> +
Also, this define is no longer required.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
whis is EVIL
> in my opinion. Watch out for that.
They're just numbers and they are intended to by interrupt controller
specific values. Some IRQ controllers don't even have a 'flags' field
for instance. The binding author is free to choose values he or she
deems suita
>> */
>>
>> static void __devinit init_hwif_ali15x3 (ide_hwif_t *hwif)
>> @@ -455,7 +456,7 @@ static void __devinit init_hwif_ali15x3 (ide_hwif_t
>> *hwif)
>> }
>> #else
>> #define init_hwif_ali15x3 NULL
>> -#endif /* !defined(CONFIG_SPARC64) && !defined(
Vorontsov (1):
powerpc/5200: Bring the legacy fsl_spi_platform_data hooks back
Grant Likely (1):
powerpc/5200: Add FLASH nodes to lite5200 device tree
Stefan Roese (2):
powerpc/of-device-tree: Factor MTD physmap bindings out of
booting-without-of
powerpc/device-tree: Document MTD
return -EINVAL;
> + if ((index + 1) * intsize > intlen) {
> + res = -EINVAL;
> + goto out;
> + }
>
> /* Get new specifier and map it */
> res = of_irq_map_raw(p, intspec + index * intsize, intsize,
>
devices are present based on the PCI vendor and
device IDs.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
stem be setting those
> registers in a guest KVM system so the guest could be debugged with
> gdb... Hollis, any idea on that?
>
> josh
>
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
triction.
>
> Might be worth checking if external debug is enabled, and override it
> only if it's not.
ppc440x5_um.pdf says that both can be enabled.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
ame behavior.
>
> Yes, that is a cleaner way to handle the LEDs. Do you know why this
> patch wasn't accepted at the time? A quick google shows that Grant
> Likely acked it.
>
> The patch will no longer apply since default state does not exist.
It got left here:
On Sun, Jan
On Fri, Apr 17, 2009 at 4:07 PM, Ilpo Järvinen
wrote:
> On Fri, 17 Apr 2009, Ilpo Järvinen wrote:
>
>> On Fri, 17 Apr 2009, Michal Simek wrote:
>>
>> > Grant Likely wrote:
>> > > On Fri, Apr 17, 2009 at 12:08 AM, Michal Simek wrote:
>> > >&
901 - 1000 of 3247 matches
Mail list logo
