Re: Regression in 3.15 on POWER8 with multipath SCSI

2014-06-30 Thread Hannes Reinecke
running LVM on top of multipathing. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg

Re: Regression in 3.15 on POWER8 with multipath SCSI

2014-06-30 Thread Hannes Reinecke
On 06/30/2014 01:02 PM, Paul Mackerras wrote: On Mon, Jun 30, 2014 at 12:52:29PM +0200, Hannes Reinecke wrote: On 06/30/2014 12:30 PM, Paul Mackerras wrote: I have a machine on which 3.15 usually fails to boot, and 3.14 boots every time. The machine is a POWER8 2-socket server with 20 cores

Re: Regression in 3.15 on POWER8 with multipath SCSI

2014-06-30 Thread Hannes Reinecke
On 06/30/2014 11:28 PM, Paul Mackerras wrote: On Mon, Jun 30, 2014 at 01:35:20PM +0200, Hannes Reinecke wrote: On 06/30/2014 01:02 PM, Paul Mackerras wrote: [ .. ] No, I'm not using LVM, and in fact I deleted all the physical volumes that were on any of the disks (they were installations

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 07:01 PM, Mike Snitzer wrote: On Wed, Nov 25 2015 at 4:04am -0500, Hannes Reinecke <h...@suse.de> wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ o

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-25 Thread Hannes Reinecke
On 11/25/2015 06:56 PM, Jens Axboe wrote: On 11/25/2015 02:04 AM, Hannes Reinecke wrote: On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ of time trying to debug things here

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-25 Thread Hannes Reinecke
On 11/20/2015 04:28 PM, Ewan Milne wrote: > On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: >> Can't we have a joint effort here? >> I've been spending a _LOT_ of time trying to debug things here, but >> none of the ideas I've come up with have been able to fix any

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-20 Thread Hannes Reinecke
On 11/20/2015 03:38 PM, Ewan Milne wrote: > On Thu, 2015-11-19 at 16:35 +0100, Hannes Reinecke wrote: >> On 11/19/2015 09:23 AM, Christoph Hellwig wrote: >>> It's pretty much guaranteed a block layer bug, most likely in the >>> merge bios to request infrastucture wher

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-22 Thread Hannes Reinecke
On 11/20/2015 04:28 PM, Ewan Milne wrote: On Fri, 2015-11-20 at 15:55 +0100, Hannes Reinecke wrote: Can't we have a joint effort here? I've been spending a _LOT_ of time trying to debug things here, but none of the ideas I've come up with have been able to fix anything. Yes. I'm not the one

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

2015-11-19 Thread Hannes Reinecke
ric block-layer problem. Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB

Re: [PATCH v2 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-28 Thread Hannes Reinecke
ult = -ENOMSG; >>>> +bsg_reply = job->reply; >>>> + bsg_reply->reply_payload_rcv_len = 0; >>>> +bsg_reply->result = -ENOMSG; > > Compiler optimization re-ordered above two lines and the first pointer > derefence i

Re: [PATCH v2 10/16] scsi: change FC drivers to use 'struct bsg_job'

2016-10-13 Thread Hannes Reinecke
+++---- > 17 files changed, 138 insertions(+), 163 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 6

Re: [PATCH v2 04/16] scsi: Unify interfaces of fc_bsg_jobdone and bsg_job_done

2016-10-13 Thread Hannes Reinecke
- > drivers/scsi/qla2xxx/qla_bsg.c | 66 +- > drivers/scsi/scsi_transport_fc.c | 22 +++-- > include/scsi/scsi_transport_fc.h | 3 +- > 8 files changed, 116 insertions(+), 60 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com>

Re: [PATCH v2 03/16] scsi: fc: Export fc_bsg_jobdone and use it in FC drivers

2016-10-13 Thread Hannes Reinecke
2 +- > 8 files changed, 50 insertions(+), 51 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5

Re: [PATCH v2 02/16] scsi: don't use fc_bsg_job::request and fc_bsg_job::reply directly

2016-10-13 Thread Hannes Reinecke
les changed, 387 insertions(+), 263 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürn

Re: [PATCH v2 05/16] scsi: fc: provide fc_bsg_to_shost() helper

2016-10-13 Thread Hannes Reinecke
gt; drivers/scsi/qla2xxx/qla_bsg.c | 54 > > drivers/scsi/scsi_transport_fc.c | 2 +- > include/scsi/scsi_transport_fc.h | 5 > 8 files changed, 56 insertions(+), 53 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- D

Re: [PATCH v2 06/16] scsi: fc: provide fc_bsg_to_rport() helper

2016-10-13 Thread Hannes Reinecke
+- > include/scsi/scsi_transport_fc.h | 5 + > 7 files changed, 17 insertions(+), 10 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckeTeamlead Storage & Networking h...@suse.de

Re: [PATCH v2 13/16] scsi: fc: use bsg_job_done

2016-10-13 Thread Hannes Reinecke
++ > drivers/scsi/scsi_transport_fc.c | 41 +++-- > include/scsi/scsi_transport_fc.h | 2 -- > 8 files changed, 50 insertions(+), 87 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Ha

[PATCH] powerpc: conditionally compile platform-specific serial drivers

2017-06-27 Thread Hannes Reinecke
mpsc.c and mpc52xx-psc.c are platform-specific serial drivers, and should be compiled for the respective platforms only. Signed-off-by: Hannes Reinecke <h...@suse.com> --- arch/powerpc/boot/Makefile | 7 --- arch/powerpc/boot/serial.c | 4 2 files changed, 8 insertions(+), 3 del

Re: [PATCH 3/3] cxlflash: Update debug prints in reset handlers

2017-06-29 Thread Hannes Reinecke
cable given the function scope. > > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> > --- > drivers/scsi/cxlflash/main.c | 18 +++--- > 1 file changed, 3 insertions(+), 15 deletions(-) > Reviewed-by: Hannes Reinecke &l

Re: [PATCH 2/3] cxlflash: Update send_tmf() parameters

2017-06-29 Thread Hannes Reinecke
-- > drivers/scsi/cxlflash/main.c | 27 +-- > 1 file changed, 13 insertions(+), 14 deletions(-) > Reviewed-by: Hannes Reinecke <h...@suse.com> Cheers, Hannes -- Dr. Hannes ReineckezSeries & Storage h...@suse.com

Re: [PATCH 1/3] cxlflash: Avoid double free of character device

2017-06-29 Thread Hannes Reinecke
> Fixes: a834a36b57d9 ("scsi: cxlflash: Create character device to provide host > management interface") > Signed-off-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>> --- > drivers/scsi/cxlflash/main.c | 1 - > 1 file changed, 1 deletion(-) > Reviewed-

Re: [mainline] rcu stalls on CPU when unbinding mpt3sas driver

2017-12-15 Thread Hannes Reinecke
90] [c03a03c4] sysfs_kf_write+0x64/0xa0 > [c07792d47cb0] [c039f1b0] kernfs_fop_write+0x170/0x250 > [c07792d47d00] [c02fd370] __vfs_write+0x40/0x200 > [c07792d47d90] [c02fd748] vfs_write+0xc8/0x240 > [c07792d47de0] [c02fda80] SyS_w

Re: [PATCH v2 01/17] ibmvfc: add vhost fields and defaults for MQ enablement

2020-12-07 Thread Hannes Reinecke
ncreasing the number of requests will increase the memory footprint of the driver (as each request will be statically allocated). Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solut

Re: [PATCH 00/13] ibmvfc: initial MQ development

2020-12-02 Thread Hannes Reinecke
? Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Re: [PATCH 03/26] block: automatically enable GENHD_FL_EXT_DEVT

2021-05-23 Thread Hannes Reinecke
/nvdimm/pmem.c| 1 - drivers/nvme/host/core.c | 1 - drivers/nvme/host/multipath.c| 1 - 10 files changed, 2 insertions(+), 13 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de

Re: [PATCH 16/26] nvdimm-btt: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
| 2 -- 2 files changed, 7 insertions(+), 19 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809

Re: [PATCH 18/26] nvme-multipath: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
ruct nvme_ctrl *ctrl) What about the check for GENHD_FL_UP a bit further up in line 766? Can this still happen with the new allocation scheme, ie is there still a difference in lifetime between ->disk and ->disk->queue? Cheers, Hannes -- Dr. Hannes ReineckeKernel Storag

Re: [PATCH 19/26] nfblock: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
insertions(+), 15 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer

Re: [PATCH 24/26] xpram: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
insertions(+), 17 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg

Re: [PATCH 25/26] null_blk: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
Hellwig --- drivers/block/null_blk/main.c | 38 +-- 1 file changed, 19 insertions(+), 19 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911

Re: [PATCH 01/26] block: refactor device number setup in __device_add_disk

2021-05-23 Thread Hannes Reinecke
- block/partitions/core.c | 15 +-- 3 files changed, 49 insertions(+), 66 deletions(-) ... and also fixes an issue with GENHD_FL_UP remained set in an error path in __device_add_disk(). Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage

Re: [PATCH 09/26] rsxx: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
/block/rsxx/rsxx_priv.h | 1 - 2 files changed, 15 insertions(+), 25 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5

Re: [PATCH 17/26] nvdimm-pmem: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
(+), 10 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix

Re: [PATCH 10/26] zram: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
insertions(+), 15 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer

Re: [PATCH 11/26] lightnvm: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
insertions(+), 18 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer

Re: [PATCH 26/26] block: unexport blk_alloc_queue

2021-05-23 Thread Hannes Reinecke
insertions(+), 2 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg

Re: [PATCH 02/26] block: move the DISK_MAX_PARTS sanity check into __device_add_disk

2021-05-23 Thread Hannes Reinecke
, 7 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Re: [PATCH 06/26] brd: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
RAMDISK_MAJOR, "ramdisk"); pr_info("brd: module NOT loaded !!!\n"); - return -ENOMEM; + return err; } static void __exit brd_exit(void) Other than that: Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeK

Re: [PATCH 13/26] dm: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
init_waitqueue_head(>wait); INIT_WORK(>work, dm_wq_work); @@ -1888,6 +1885,7 @@ static struct mapped_device *alloc_dev(int minor) md->disk->major = _major; md->disk->first_minor = minor; + md->disk->minors = 1; md->disk->

Re: [PATCH 20/26] simdisk: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
file changed, 7 insertions(+), 22 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg

Re: [PATCH 21/26] n64cart: convert to blk_alloc_disk

2021-05-23 Thread Hannes Reinecke
-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

Re: [PATCH 04/26] block: add a flag to make put_disk on partially initalized disks safer

2021-05-23 Thread Hannes Reinecke
of drivers did get wrong or still do. Signed-off-by: Christoph Hellwig --- block/genhd.c | 7 +-- include/linux/genhd.h | 1 + 2 files changed, 6 insertions(+), 2 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage

Re: [PATCH 05/26] block: add blk_alloc_disk and blk_cleanup_disk APIs

2021-05-23 Thread Hannes Reinecke
+++ include/linux/genhd.h | 22 ++ 2 files changed, 57 insertions(+) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH

Re: [PATCH 07/26] drbd: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
insertions(+), 15 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg

Re: [PATCH 08/26] pktcdvd: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix

Re: [PATCH 12/26] bcache: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
(+), 11 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix

Re: [PATCH 15/26] nvdimm-blk: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
insertions(+), 20 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer

Re: [PATCH 14/26] md: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
et_stacking_limits(>queue->limits); blk_queue_write_cache(mddev->queue, true, true); /* Allow extended partitions. This makes the * 'mdp' device redundant, but we can't really Wouldn't it make sense to introduce a helper 'blk_queue_from_disk()' or somesuch to avoi

Re: [PATCH 22/26] ps3vram: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
, 8 insertions(+), 23 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg

Re: [PATCH 23/26] dcssblk: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-23 Thread Hannes Reinecke
, 8 insertions(+), 18 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg

Re: [PATCH 14/26] md: convert to blk_alloc_disk/blk_cleanup_disk

2021-05-24 Thread Hannes Reinecke
On 5/24/21 9:26 AM, Christoph Hellwig wrote: On Sun, May 23, 2021 at 10:12:49AM +0200, Hannes Reinecke wrote: + blk_set_stacking_limits(>queue->limits); blk_queue_write_cache(mddev->queue, true, true); /* Allow extended partitions. This makes the * 'md

Re: [PATCH v7 2/3 RESEND] block: sed-opal: keystore access for SED Opal keys

2023-08-16 Thread Hannes Reinecke
) < 0) { + memset(init_sed_key, '\0', sizeof(init_sed_key)); + keylen = OPAL_KEY_MAX - 1; + } + + return update_sed_opal_key(OPAL_AUTH_KEY, init_sed_key, keylen); } late_initcall(sed_opal_init); See the previous patch for comments about 'struct key'. Che

Re: [PATCH v7 3/3 RESEND] powerpc/pseries: PLPKS SED Opal keystore support

2023-08-16 Thread Hannes Reinecke
/platforms/pseries/plpks_sed_ops.c Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer

Re: [PATCH v7 1/3 RESEND] block:sed-opal: SED Opal keystore

2023-08-16 Thread Hannes Reinecke
*keyname, char *key, u_int keylen) +{ + return -EOPNOTSUPP; +} Hmm. We do have security/keys, which is using a 'struct key' for their operations. Why don't you leverage that structure? Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de

Re: [PATCH v2 2/3] scsi: BusLogic remove bus_to_virt

2022-06-21 Thread Hannes Reinecke
depends on PCI && SCSI && VIRT_TO_BUS + depends on PCI && SCSI help This is support for BusLogic MultiMaster and FlashPoint SCSI Host Adapters. Consult the SCSI-HOWTO, available from CCB handling in the driver is ugly anyway, so that'll

Re: [PATCH v2 1/3] scsi: dpt_i2o: drop stale VIRT_TO_BUS dependency

2022-06-21 Thread Hannes Reinecke
else { /* Ick, we should *never* be here */ printk(KERN_ERR "dpti: reply frame not from pool\n"); - reply = (u8 *)bus_to_virt(m); + goto out; } if (readl(reply) & MSG_FAIL) { Rev

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-11-29 Thread Hannes Reinecke
DED = 0, /* key[] is the key */ + OPAL_KEYRING, /* key is in keyring */ +}; + struct opal_key { __u8 lr; __u8 key_len; - __u8 __align[6]; + __u8 key_type; + __u8 __align[5]; __u8 key[OPAL_KEY_MAX]; }; Cheers, Hannes -- Dr. Hannes

Re: [PATCH v3 2/3] block: sed-opal: Implement IOC_OPAL_REVERT_LSP

2022-11-29 Thread Hannes Reinecke
-opal.h | 1 + include/uapi/linux/sed-opal.h | 11 ++ 4 files changed, 56 insertions(+) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes ReineckeKernel Storage Architect h...@suse.de +49 911 74053 688 SUSE Software Solutions

Re: [PATCH v3 1/3] block: sed-opal: Implement IOC_OPAL_DISCOVERY

2022-11-29 Thread Hannes Reinecke
-by: Jonathan Derrick --- block/sed-opal.c | 38 --- include/linux/sed-opal.h | 1 + include/uapi/linux/sed-opal.h | 6 ++ 3 files changed, 42 insertions(+), 3 deletions(-) Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-12-01 Thread Hannes Reinecke
On 12/1/22 19:03, Greg Joyce wrote: On Wed, 2022-11-30 at 08:00 +0100, Hannes Reinecke wrote: On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: From: Greg Joyce Extend the SED block driver so it can alternatively obtain a key from a sed-opal kernel keyring. The SED ioctls will indicate