[PATCH v4 00/25] Add FADump support on PowerNV platform

2019-07-16 Thread Hari Bathini
for MPIPL support: https://patchwork.ozlabs.org/project/skiboot/list/?series=119169 ("MPIPL support") Changes in v4: * Split the patches. * Rebased to latest upstream kernel version. * Updated according to latest OPAL changes. --- Hari Bathini (25): powerpc/fa

[PATCH v4 20/25] powerpc/fadump: update documentation about CONFIG_PRESERVE_FA_DUMP

2019-07-16 Thread Hari Bathini
Kernel config option CONFIG_PRESERVE_FA_DUMP is introduced to ensure crash data, from previously crash'ed kernel, is preserved. Update documentation with this details. Signed-off-by: Hari Bathini --- Documentation/powerpc/firmware-assisted-dump.txt |9 + 1 file changed, 9 insertions

[PATCH v4 23/25] powernv/opalcore: provide an option to invalidate /sys/firmware/opal/core file

2019-07-16 Thread Hari Bathini
Writing '1' to /sys/kernel/fadump_release_opalcore would release the memory held by kernel in exporting /sys/firmware/opal/core file. Signed-off-by: Hari Bathini --- arch/powerpc/platforms/powernv/opal-core.c | 38 1 file changed, 38 insertions(+) diff --git

[PATCH v4 06/25] pseries/fadump: define register/un-register callback functions

2019-07-16 Thread Hari Bathini
Make RTAS calls to register and un-register for FADump. Also, update how fadump_region contents are diplayed to provide more information. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump-common.h |2 arch/powerpc/kernel/fadump.c | 164

[PATCH v4 18/25] powernv/fadump: process architected register state data provided by firmware

2019-07-16 Thread Hari Bathini
From: Hari Bathini Firmware provides architected register state data at the time of crash. Process this data and build CPU notes to append to ELF core. Signed-off-by: Hari Bathini Signed-off-by: Vasant Hegde --- arch/powerpc/kernel/fadump-common.h |4 + arch/powerpc/platforms

[PATCH v4 24/25] powernv/fadump: consider f/w load area

2019-07-16 Thread Hari Bathini
enforce a minimum boot memory size of 768MB on OPAL platform. Also, skip using FADump if a newer F/W version loads kernel & initrd above 768MB. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump-common.h | 11 +- arch/powerpc/kernel/fadump.c

[PATCH v4 08/25] powerpc/fadump: use FADump instead of fadump for how it is pronounced

2019-07-16 Thread Hari Bathini
fadump is pronounced f-a-dump. Update documentation accordingly. Also, update how fadump_region contents look like with recent changes. Signed-off-by: Hari Bathini --- Documentation/powerpc/firmware-assisted-dump.txt | 71 -- 1 file changed, 39 insertions(+), 32 deletions

[PATCH v4 22/25] powernv/fadump: Warn before processing partial crashdump

2019-07-16 Thread Hari Bathini
If not all kernel boot memory regions are registered for MPIPL before system crashes, try processing the partial crashdump but warn the user before proceeding. Signed-off-by: Hari Bathini --- arch/powerpc/platforms/powernv/opal-fadump.c | 21 + 1 file changed, 21

[PATCH v4 04/25] pseries/fadump: move rtas specific definitions to platform code

2019-07-16 Thread Hari Bathini
Currently, FADump is only supported on pSeries but that is going to change soon with FADump support being added on PowerNV platform. So, move rtas specific definitions to platform code to allow FADump to have multiple platforms support. Signed-off-by: Hari Bathini --- arch/powerpc/include/asm

[PATCH v4 14/25] powernv/fadump: process the crashdump by exporting it as /proc/vmcore

2019-07-16 Thread Hari Bathini
Add support in the kernel to process the crash'ed kernel's memory preserved during MPIPL and export it as /proc/vmcore file for the userland scripts to filter and analyze it later. Signed-off-by: Hari Bathini --- arch/powerpc/platforms/powernv/opal-fadump.c | 190 ++ 1

[PATCH v4 05/25] pseries/fadump: introduce callbacks for platform specific operations

2019-07-16 Thread Hari Bathini
Introduce callback functions for platform specific operations like register, unregister, invalidate & such. Also, define place-holders for the same on pSeries platform. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump-common.h | 33 ++ arch/powerpc/kernel/fadu

[PATCH v4 12/25] powernv/fadump: define register/un-register callback functions

2019-07-16 Thread Hari Bathini
Make OPAL calls to register and un-register with firmware for MPIPL. Signed-off-by: Hari Bathini --- arch/powerpc/platforms/powernv/opal-fadump.c | 71 +- 1 file changed, 69 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal-fadump.c b

[PATCH v4 17/25] powerpc/fadump: consider reserved ranges while releasing memory

2019-07-16 Thread Hari Bathini
ved ranges is not overlapped with memory released by capture kernel aftering saving vmcore. Also, fix the off-by-one error in fadump_release_reserved_area function while releasing memory. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump.c | 61 +- 1 file c

[PATCH v4 21/25] powernv/opalcore: export /sys/firmware/opal/core for analysing opal crashes

2019-07-16 Thread Hari Bathini
From: Hari Bathini Export /sys/firmware/opal/core file to analyze opal crashes. Since OPAL core can be generated independent of CONFIG_FA_DUMP support in kernel, add this support under a new kernel config option CONFIG_OPAL_CORE. Also, avoid code duplication by moving common code used while

[PATCH v4 02/25] powerpc/fadump: move internal code to a new file

2019-07-16 Thread Hari Bathini
Make way for refactoring platform specific FADump code by moving code that could be referenced from multiple places to fadump-common.c file. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/Makefile|2 arch/powerpc/kernel/fadump-common.c | 144

[PATCH v4 13/25] powernv/fadump: support copying multiple kernel memory regions

2019-07-16 Thread Hari Bathini
memory regions. This allows having an adequate FADump capture kernel size for different scenarios. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump-common.c | 15 ++ arch/powerpc/kernel/fadump-common.h | 16 ++ arch/powerpc/kernel/fadump.c | 173

[PATCH v4 19/25] powernv/fadump: add support to preserve crash data on FADUMP disabled kernel

2019-07-16 Thread Hari Bathini
for this config option is petitboot kernel. As OPAL allows registering address with it in the first kernel and retrieving it after MPIPL, use it to store the top of boot memory. A kernel that intends to preserve crash data retrieves it and avoids using memory beyond this address. Signed-off-by: Hari Bathini

[PATCH v4 03/25] powerpc/fadump: Improve fadump documentation

2019-07-16 Thread Hari Bathini
The figures depicting FADump's (Firmware-Assisted Dump) memory layout are missing some finer details like different memory regions and what they represent. Improve the documentation by updating those details. Signed-off-by: Hari Bathini --- Documentation/powerpc/firmware-assisted-dump.txt

[PATCH v4 10/25] powernv/fadump: add fadump support on powernv

2019-07-16 Thread Hari Bathini
Add basic callback functions for FADump on PowerNV platform. Signed-off-by: Hari Bathini --- arch/powerpc/Kconfig |5 + arch/powerpc/kernel/fadump-common.h | 10 +++ arch/powerpc/kernel/fadump.c |3 + arch/powerpc/platforms/powernv

[PATCH v4 15/25] powerpc/fadump: Update documentation about OPAL platform support

2019-07-16 Thread Hari Bathini
With FADump support now available on both pseries and OPAL platforms, update FADump documentation with these details. Signed-off-by: Hari Bathini --- Documentation/powerpc/firmware-assisted-dump.txt | 104 +- 1 file changed, 63 insertions(+), 41 deletions(-) diff --git

[PATCH v4 25/25] powernv/fadump: update documentation about option to release opalcore

2019-07-16 Thread Hari Bathini
With /sys/firmware/opal/core support available on OPAL based machines and an option to the release memory used by kernel in exporting this core file, update FADump documentation with these details. Signed-off-by: Hari Bathini --- Documentation/powerpc/firmware-assisted-dump.txt | 19

Re: [PATCH v4 11/25] powernv/fadump: register kernel metadata address with opal

2019-08-14 Thread Hari Bathini
On 13/08/19 4:11 PM, Mahesh J Salgaonkar wrote: > On 2019-07-16 17:03:15 Tue, Hari Bathini wrote: >> OPAL allows registering address with it in the first kernel and >> retrieving it after MPIPL. Setup kernel metadata and register its >> address with OPAL to use it for proc

Re: [PATCH v4 05/25] pseries/fadump: introduce callbacks for platform specific operations

2019-08-14 Thread Hari Bathini
On 12/08/19 3:12 PM, Mahesh J Salgaonkar wrote: > On 2019-07-16 17:02:30 Tue, Hari Bathini wrote: >> Introduce callback functions for platform specific operations like >> register, unregister, invalidate & such. Also, define place-holders >> for the same on pSeries p

Re: [PATCH v4 06/25] pseries/fadump: define register/un-register callback functions

2019-08-14 Thread Hari Bathini
On 12/08/19 9:31 PM, Mahesh J Salgaonkar wrote: > On 2019-07-16 17:02:38 Tue, Hari Bathini wrote: >> Make RTAS calls to register and un-register for FADump. Also, update >> how fadump_region contents are diplayed to provide more information. >> >> Signed-off-by: Ha

Re: [PATCH v4 12/25] powernv/fadump: define register/un-register callback functions

2019-08-14 Thread Hari Bathini
On 13/08/19 8:04 PM, Mahesh J Salgaonkar wrote: > On 2019-07-16 17:03:23 Tue, Hari Bathini wrote: >> Make OPAL calls to register and un-register with firmware for MPIPL. >> >> Signed-off-by: Hari Bathini >> --- >> arch/powerpc/platf

Re: [PATCH v4 13/25] powernv/fadump: support copying multiple kernel memory regions

2019-08-14 Thread Hari Bathini
On 13/08/19 8:33 PM, Mahesh J Salgaonkar wrote: > On 2019-07-16 17:03:30 Tue, Hari Bathini wrote: >> Firmware uses 32-bit field for region size while copying/backing-up >> memory during MPIPL. So, the maximum copy size for a region would >> be a page less than 4GB

Re: [PATCH v4 14/25] powernv/fadump: process the crashdump by exporting it as /proc/vmcore

2019-08-14 Thread Hari Bathini
On 14/08/19 3:48 PM, Mahesh J Salgaonkar wrote: > On 2019-07-16 17:03:38 Tue, Hari Bathini wrote: >> Add support in the kernel to process the crash'ed kernel's memory >> preserved during MPIPL and export it as /proc/vmcore file for the >> userland scripts to filter

Re: [PATCH v4 18/25] powernv/fadump: process architected register state data provided by firmware

2019-08-15 Thread Hari Bathini
On 14/08/19 10:45 PM, Mahesh J Salgaonkar wrote: > On 2019-07-16 17:04:08 Tue, Hari Bathini wrote: >> From: Hari Bathini >> >> Firmware provides architected register state data at the time of crash. >> Process this data and build CPU notes to append to ELF core

Re: [PATCH v4 11/25] powernv/fadump: register kernel metadata address with opal

2019-08-19 Thread Hari Bathini
On 14/08/19 3:51 PM, Mahesh Jagannath Salgaonkar wrote: > On 8/14/19 12:36 PM, Hari Bathini wrote: >> >> >> On 13/08/19 4:11 PM, Mahesh J Salgaonkar wrote: >>> On 2019-07-16 17:03:15 Tue, Hari Bathini wrote: >>>> OPAL allows registering address with

[PATCH v5 00/31] Add FADump support on PowerNV platform

2019-08-20 Thread Hari Bathini
hesh on V4. --- Hari Bathini (31): powerpc/fadump: move internal macros/definitions to a new header powerpc/fadump: move internal code to a new file powerpc/fadump: Improve fadump documentation pseries/fadump: move rtas specific definitions to platform code pseries/fadump:

[PATCH v5 01/31] powerpc/fadump: move internal macros/definitions to a new header

2019-08-20 Thread Hari Bathini
Though asm/fadump.h is meant to be used by other components dealing with FADump, it also has macros/definitions internal to FADump code. Move them to a new header file used within FADump code. This also makes way for refactoring platform specific FADump code. Signed-off-by: Hari Bathini

[PATCH v5 07/31] powerpc/fadump: release all the memory above boot memory size

2019-08-20 Thread Hari Bathini
Except for reserve dump area which is permanent reserved, all memory above boot memory size is released when the dump is invalidated. Make this a bit more explicit in the code. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump.c | 34 ++ 1 file changed

[PATCH v5 02/31] powerpc/fadump: move internal code to a new file

2019-08-20 Thread Hari Bathini
Make way for refactoring platform specific FADump code by moving code that could be referenced from multiple places to fadump-common.c file. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/Makefile|2 arch/powerpc/kernel/fadump-common.c | 140

[PATCH v5 10/31] opal: add MPIPL interface definitions

2019-08-20 Thread Hari Bathini
Signed-off-by: Hari Bathini --- arch/powerpc/include/asm/opal-api.h| 50 +++- arch/powerpc/include/asm/opal.h|6 +++ arch/powerpc/platforms/powernv/opal-call.c |3 ++ 3 files changed, 58 insertions(+), 1 deletion(-) diff --git a/arch/powerpc

[PATCH v5 15/31] powernv/fadump: support copying multiple kernel boot memory regions

2019-08-20 Thread Hari Bathini
errors. So, request firmware to copy multiple kernel boot memory regions instead of just one (which worked fine for pseries as 64-bit field was used for size there). Signed-off-by: Hari Bathini --- arch/powerpc/platforms/powernv/opal-fadump.c | 35 +- 1 file changed, 28

[PATCH v5 20/31] powerpc/fadump: use smaller offset while finding memory for reservation

2019-08-20 Thread Hari Bathini
failure. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump-common.h |8 arch/powerpc/kernel/fadump.c|2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/fadump-common.h b/arch/powerpc/kernel/fadump-common.h index d2dd117

[PATCH v5 24/31] powerpc/fadump: improve how crashed kernel's memory is reserved

2019-08-20 Thread Hari Bathini
The size parameter to fadump_reserve_crash_area() function is not needed as all the memory above boot memory size must be preserved anyway. Update the function by dropping this redundant parameter. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump.c | 53

[PATCH v5 28/31] powernv/opalcore: provide an option to invalidate /sys/firmware/opal/core file

2019-08-20 Thread Hari Bathini
Writing '1' to /sys/kernel/fadump_release_opalcore would release the memory held by kernel in exporting /sys/firmware/opal/core file. Signed-off-by: Hari Bathini --- arch/powerpc/platforms/powernv/opal-core.c | 38 1 file changed, 38 insertions(+) diff --git

[PATCH v5 05/31] pseries/fadump: introduce callbacks for platform specific operations

2019-08-20 Thread Hari Bathini
Introduce callback functions for platform specific operations like register, unregister, invalidate & such. Also, define place-holders for the same on pSeries platform. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump-common.h | 26 + arch/powerpc/kernel/fadu

[PATCH v5 21/31] powernv/fadump: process architected register state data provided by firmware

2019-08-20 Thread Hari Bathini
From: Hari Bathini Firmware provides architected register state data at the time of crash. Process this data and build CPU notes to append to ELF core. Signed-off-by: Hari Bathini Signed-off-by: Vasant Hegde --- arch/powerpc/kernel/fadump-common.h |4 + arch/powerpc/platforms

[PATCH v5 26/31] powerpc/fadump: update documentation about CONFIG_PRESERVE_FA_DUMP

2019-08-20 Thread Hari Bathini
Kernel config option CONFIG_PRESERVE_FA_DUMP is introduced to ensure crash data, from previously crash'ed kernel, is preserved. Update documentation with this details. Signed-off-by: Hari Bathini --- Documentation/powerpc/firmware-assisted-dump.rst |9 + 1 file changed, 9 insertions

[PATCH v5 09/31] powerpc/fadump: use FADump instead of fadump for how it is pronounced

2019-08-20 Thread Hari Bathini
fadump is pronounced f-a-dump. Update documentation accordingly. Also, update how fadump_region contents look like with recent changes. Signed-off-by: Hari Bathini --- Documentation/powerpc/firmware-assisted-dump.rst | 55 -- 1 file changed, 30 insertions(+), 25 deletions

[PATCH v5 16/31] powernv/fadump: process the crashdump by exporting it as /proc/vmcore

2019-08-20 Thread Hari Bathini
Add support in the kernel to process the crash'ed kernel's memory preserved during MPIPL and export it as /proc/vmcore file for the userland scripts to filter and analyze it later. Signed-off-by: Hari Bathini --- arch/powerpc/platforms/powernv/opal-fadump.c | 165 ++ 1

[PATCH v5 23/31] powerpc/fadump: consider reserved ranges while releasing memory

2019-08-20 Thread Hari Bathini
ved ranges is not overlapped with memory released by capture kernel aftering saving vmcore. Also, fix the off-by-one error in fadump_release_reserved_area function while releasing memory. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump.c | 150 +++--- 1 file ch

[PATCH v5 27/31] powernv/opalcore: export /sys/firmware/opal/core for analysing opal crashes

2019-08-20 Thread Hari Bathini
From: Hari Bathini Export /sys/firmware/opal/core file to analyze opal crashes. Since OPAL core can be generated independent of CONFIG_FA_DUMP support in kernel, add this support under a new kernel config option CONFIG_OPAL_CORE. Also, avoid code duplication by moving common code used while

[PATCH v5 06/31] pseries/fadump: define register/un-register callback functions

2019-08-20 Thread Hari Bathini
Make RTAS calls to register and un-register for FADump. Also, update how fadump_region contents are diplayed to provide more information. Signed-off-by: Hari Bathini Reviewed-by: Mahesh Salgaonkar --- arch/powerpc/kernel/fadump-common.h |2 arch/powerpc/kernel/fadump.c

[PATCH v5 19/31] powerpc/fadump: Update documentation about OPAL platform support

2019-08-20 Thread Hari Bathini
With FADump support now available on both pseries and OPAL platforms, update FADump documentation with these details. Signed-off-by: Hari Bathini --- Documentation/powerpc/firmware-assisted-dump.rst | 104 +- 1 file changed, 63 insertions(+), 41 deletions(-) diff --git

[PATCH v5 25/31] powernv/fadump: add support to preserve crash data on FADUMP disabled kernel

2019-08-20 Thread Hari Bathini
arch_reserved_kernel_pages() function as it is needed for both FA_DUMP and PRESERVE_FA_DUMP configurations. Signed-off-by: Hari Bathini --- arch/powerpc/Kconfig |9 +++ arch/powerpc/include/asm/fadump.h|9 ++- arch/powerpc/kernel/Makefile |6 ++ arch

[PATCH v5 04/31] pseries/fadump: move rtas specific definitions to platform code

2019-08-20 Thread Hari Bathini
Currently, FADump is only supported on pSeries but that is going to change soon with FADump support being added on PowerNV platform. So, move rtas specific definitions to platform code to allow FADump to have multiple platforms support. Signed-off-by: Hari Bathini --- arch/powerpc/include/asm

[PATCH v5 12/31] powernv/fadump: register kernel metadata address with opal

2019-08-20 Thread Hari Bathini
OPAL allows registering address with it in the first kernel and retrieving it after MPIPL. Setup kernel metadata and register its address with OPAL to use it for processing the crash dump. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump-common.h |4 + arch/powerpc/kernel

[PATCH v5 03/31] powerpc/fadump: Improve fadump documentation

2019-08-20 Thread Hari Bathini
The figures depicting FADump's (Firmware-Assisted Dump) memory layout are missing some finer details like different memory regions and what they represent. Improve the documentation by updating those details. Signed-off-by: Hari Bathini --- Documentation/powerpc/firmware-assisted-dump.rst

[PATCH v5 08/31] pseries/fadump: move out platform specific support from generic code

2019-08-20 Thread Hari Bathini
Move code that supports processing the crash'ed kernel's memory preserved by firmware to platform specific callback functions. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump.c | 343 +- arch/powerpc/platforms/pseries/rtas-fadump.c | 280

[PATCH v5 11/31] powernv/fadump: add fadump support on powernv

2019-08-20 Thread Hari Bathini
Add basic callback functions for FADump on PowerNV platform. Signed-off-by: Hari Bathini --- arch/powerpc/Kconfig |5 + arch/powerpc/kernel/fadump-common.h |9 ++ arch/powerpc/kernel/fadump.c |3 + arch/powerpc/platforms/powernv

[PATCH v5 14/31] powernv/fadump: define register/un-register callback functions

2019-08-20 Thread Hari Bathini
Make OPAL calls to register and un-register with firmware for MPIPL. Signed-off-by: Hari Bathini --- arch/powerpc/platforms/powernv/opal-fadump.c | 79 +- 1 file changed, 77 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal-fadump.c b

[PATCH v5 22/31] powerpc/fadump: make crash memory ranges array allocation generic

2019-08-20 Thread Hari Bathini
Make allocate_crash_memory_ranges() and free_crash_memory_ranges() functions generic to reuse them for memory management of all types of dynamic memory range arrays. This change helps in memory management of reserved ranges array to be added later. Signed-off-by: Hari Bathini --- arch/powerpc

[PATCH v5 31/31] powernv/fadump: support holes in kernel boot memory area

2019-08-20 Thread Hari Bathini
With support to copy multiple kernel boot memory regions owing to copy size limitation, also handle holes in the memory area to be preserved. Support as many as 128 kernel boot memory regions. This allows having an adequate FADump capture kernel size for different scenarios. Signed-off-by: Hari

[PATCH v5 13/31] powernv/fadump: reset metadata address during clean up

2019-08-20 Thread Hari Bathini
During kexec boot, metadata address needs to be reset to avoid running into errors interpreting stale metadata address, in case the kexec'ed kernel crashes before metadata address could be setup again. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump-common.h |1 + arch

[PATCH v5 18/31] powernv/fadump: handle invalidation of crashdump and re-registraion

2019-08-20 Thread Hari Bathini
Make OPAL call to indicate that the dump is processed and the metadata area in OPAL can be cleared/released. Also, setup/initialize FADump for re-registration. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump.c |7 ++- arch/powerpc/platforms/powernv/opal

[PATCH v5 29/31] powerpc/fadump: consider f/w load area

2019-08-20 Thread Hari Bathini
requirements on systems with 512M/1024M RMA size. Signed-off-by: Hari Bathini --- arch/powerpc/kernel/fadump-common.h | 11 +- arch/powerpc/kernel/fadump.c | 11 +- arch/powerpc/platforms/powernv/opal-fadump.c | 29 ++ arch/power

[PATCH v5 17/31] powernv/fadump: Warn before processing partial crashdump

2019-08-20 Thread Hari Bathini
If all kernel boot memory regions are not registered for MPIPL before system crashes, try processing the partial crashdump but warn the user before proceeding. Signed-off-by: Hari Bathini --- arch/powerpc/platforms/powernv/opal-fadump.c | 24 1 file changed, 24

[PATCH v5 30/31] powernv/fadump: update documentation about option to release opalcore

2019-08-20 Thread Hari Bathini
With /sys/firmware/opal/core support available on OPAL based machines and an option to the release memory used by kernel in exporting this core file, update FADump documentation with these details. Signed-off-by: Hari Bathini --- Documentation/powerpc/firmware-assisted-dump.rst | 19

Re: [PATCH v3] powerpc/fadump: sysfs for fadump memory reservation

2019-08-27 Thread Hari Bathini
On 27/08/19 8:49 AM, Michael Ellerman wrote: > Hari Bathini writes: >> On 26/08/19 4:14 PM, Sourabh Jain wrote: >>> On 8/26/19 3:46 PM, Sourabh Jain wrote: >>>> On 8/26/19 3:29 PM, Hari Bathini wrote: >>>>> On 10/08/19 11:29 PM, Sourabh Jain wrote:

[RESEND PATCH v5 13/31] powernv/fadump: reset metadata address during clean up

2019-08-27 Thread Hari Bathini
During kexec boot, metadata address needs to be reset to avoid running into errors interpreting stale metadata address, in case the kexec'ed kernel crashes before metadata address could be setup again. Signed-off-by: Hari Bathini --- * Added check in fadump_cleanup() function for whether FADump

Re: [PATCH v5 13/31] powernv/fadump: reset metadata address during clean up

2019-08-27 Thread Hari Bathini
On 20/08/19 5:35 PM, Hari Bathini wrote: > During kexec boot, metadata address needs to be reset to avoid running > into errors interpreting stale metadata address, in case the kexec'ed > kernel crashes before metadata address could be setup again. > > Signed-off-b

Re: [PATCH rebased] powerpc/fadump: when fadump is supported register the fadump sysfs files.

2019-08-27 Thread Hari Bathini
Hi Michal, Thanks for the patch. On 20/08/19 11:42 PM, Michal Suchanek wrote: > Currently it is not possible to distinguish the case when fadump is > supported by firmware and disabled in kernel and completely unsupported > using the kernel sysfs interface. User can investigate the devicetree

Re: [PATCH v5 01/31] powerpc/fadump: move internal macros/definitions to a new header

2019-09-03 Thread Hari Bathini
On 03/09/19 4:39 PM, Michael Ellerman wrote: > Hari Bathini writes: >> Though asm/fadump.h is meant to be used by other components dealing >> with FADump, it also has macros/definitions internal to FADump code. >> Move them to a new header file used within FADump code. T

Re: [PATCH v5 11/31] powernv/fadump: add fadump support on powernv

2019-09-03 Thread Hari Bathini
On 03/09/19 4:40 PM, Michael Ellerman wrote: > Hari Bathini writes: >> Add basic callback functions for FADump on PowerNV platform. > > I assume this doesn't actually work yet? > > Does something block it from appearing to work at runtime? With this patch, "fadum

Re: [PATCH v5 07/31] powerpc/fadump: release all the memory above boot memory size

2019-09-03 Thread Hari Bathini
On 03/09/19 4:40 PM, Michael Ellerman wrote: > Hari Bathini writes: > >> Except for reserve dump area which is permanent reserved, all memory > permanently > >> above boot memory size is released when the dump is invalidated.

Re: [PATCH v5 02/31] powerpc/fadump: move internal code to a new file

2019-09-03 Thread Hari Bathini
On 03/09/19 4:39 PM, Michael Ellerman wrote: > Hari Bathini writes: >> Make way for refactoring platform specific FADump code by moving code >> that could be referenced from multiple places to fadump-common.c file. >> >> Signed-off-by: Hari Bathini >> ---

Re: [PATCH v5 05/31] pseries/fadump: introduce callbacks for platform specific operations

2019-09-03 Thread Hari Bathini
On 03/09/19 4:40 PM, Michael Ellerman wrote: > Hari Bathini writes: >> Introduce callback functions for platform specific operations like >> register, unregister, invalidate & such. Also, define place-holders >> for the same on pSeries platform. > > W

Re: [PATCH v5 10/31] opal: add MPIPL interface definitions

2019-09-03 Thread Hari Bathini
On 03/09/19 4:40 PM, Michael Ellerman wrote: > Hari Bathini writes: >> diff --git a/arch/powerpc/include/asm/opal-api.h >> b/arch/powerpc/include/asm/opal-api.h >> index 383242e..c8a5665 100644 >> --- a/arch/powerpc/include/asm/opal-api.h >> +++ b/ar

Re: [PATCH v5 06/31] pseries/fadump: define register/un-register callback functions

2019-09-03 Thread Hari Bathini
On 03/09/19 4:40 PM, Michael Ellerman wrote: > Hari Bathini writes: >> Make RTAS calls to register and un-register for FADump. Also, update >> how fadump_region contents are diplayed to provide more information. > > That sounds like two independent changes, so can t

Re: [PATCH v3] powerpc/fadump: sysfs for fadump memory reservation

2019-08-26 Thread Hari Bathini
On 10/08/19 11:29 PM, Sourabh Jain wrote: > Add a sys interface to allow querying the memory reserved by > fadump for saving the crash dump. > > Add an ABI doc entry for new sysfs interface. >- /sys/kernel/fadump_mem_reserved > > Signed-off-by: Sourabh Jain > --- > Changelog: > v1 -> v2:

Re: [PATCH v3] powerpc/fadump: sysfs for fadump memory reservation

2019-08-26 Thread Hari Bathini
On 26/08/19 4:14 PM, Sourabh Jain wrote: > > > On 8/26/19 3:46 PM, Sourabh Jain wrote: >> >> >> On 8/26/19 3:29 PM, Hari Bathini wrote: >>> >>> >>> On 10/08/19 11:29 PM, Sourabh Jain wrote: >>>> Add a sys interface to allow que

Re: [PATCH rebased] powerpc/fadump: when fadump is supported register the fadump sysfs files.

2019-08-28 Thread Hari Bathini
On 28/08/19 10:37 PM, Michal Suchánek wrote: > On Tue, 27 Aug 2019 17:57:31 +0530 > Hari Bathini wrote: > [...] >> Also, get rid of the error message when fadump is >> not supported as it is already taken care of in fadump_reserve_mem() >> function. >

Re: [PATCH v2] powerpc/fadump: when fadump is supported register the fadump sysfs files.

2019-08-28 Thread Hari Bathini
message already logged during early boot in fadump_reserve_mem() function. I am not strongly against this though. So... Acked-by: Hari Bathini

Re: [PATCH v5 02/31] powerpc/fadump: move internal code to a new file

2019-09-04 Thread Hari Bathini
On 04/09/19 2:32 PM, Mahesh Jagannath Salgaonkar wrote: > On 9/3/19 9:35 PM, Hari Bathini wrote: >> >> >> On 03/09/19 4:39 PM, Michael Ellerman wrote: >>> Hari Bathini writes: >>>> Make way for refactoring platform specific FADump code by moving code &

Re: [PATCH v5 11/31] powernv/fadump: add fadump support on powernv

2019-09-04 Thread Hari Bathini
On 03/09/19 10:01 PM, Hari Bathini wrote: > [...] >>> diff --git a/arch/powerpc/kernel/fadump-common.h >>> b/arch/powerpc/kernel/fadump-common.h >>> index d2c5b16..f6c52d3 100644 >>> --- a/arch/powerpc/kernel/fadump-common.h >>> +++ b/arch/powe

Re: [PATCH v5 15/31] powernv/fadump: support copying multiple kernel boot memory regions

2019-09-04 Thread Hari Bathini
On 04/09/19 5:00 PM, Michael Ellerman wrote: > Hari Bathini writes: >> Firmware uses 32-bit field for region size while copying/backing-up > > Which firmware exactly is imposing that limit? I think the MDST/MDRT tables in the f/w. Vasant,

Re: [PATCH v5 05/31] pseries/fadump: introduce callbacks for platform specific operations

2019-09-06 Thread Hari Bathini
On 03/09/19 9:36 PM, Hari Bathini wrote: > > > On 03/09/19 4:40 PM, Michael Ellerman wrote: >> Hari Bathini writes: >>> Introduce callback functions for platform specific operations like >>> register, unregister, invalidate & such. Also, define plac

Re: [PATCH v5 21/31] powernv/fadump: process architected register state data provided by firmware

2019-09-10 Thread Hari Bathini
On 09/09/19 9:03 PM, Oliver O'Halloran wrote: > On Mon, Sep 9, 2019 at 11:23 PM Hari Bathini wrote: >> >> On 04/09/19 5:50 PM, Michael Ellerman wrote: >>> Hari Bathini writes: >>> >> >> [...] >> >>>> +/* >>>> + * CPU

Re: [PATCH v5 21/31] powernv/fadump: process architected register state data provided by firmware

2019-09-10 Thread Hari Bathini
On 10/09/19 7:35 PM, Michael Ellerman wrote: > Hari Bathini writes: >> On 09/09/19 9:03 PM, Oliver O'Halloran wrote: >>> On Mon, Sep 9, 2019 at 11:23 PM Hari Bathini wrote: >>>> On 04/09/19 5:50 PM, Michael Ellerman wrote: >>>>> Hari Bathini writ

Re: [PATCH v5 21/31] powernv/fadump: process architected register state data provided by firmware

2019-09-09 Thread Hari Bathini
On 04/09/19 5:50 PM, Michael Ellerman wrote: > Hari Bathini writes: > [...] >> +/* >> + * CPU state data is provided by f/w. Below are the definitions >> + * provided in HDAT spec. Refer to latest HDAT specification for >> + * any update to this format. >>

Re: [PATCH v5 16/31] powernv/fadump: process the crashdump by exporting it as /proc/vmcore

2019-09-04 Thread Hari Bathini
On 04/09/19 5:12 PM, Michael Ellerman wrote: > Hari Bathini writes: >> diff --git a/arch/powerpc/platforms/powernv/opal-fadump.c >> b/arch/powerpc/platforms/powernv/opal-fadump.c >> index a755705..10f6086 100644 >> --- a/arch/powerpc/platforms/powernv/opal-fad

Re: [PATCH v5 14/31] powernv/fadump: define register/un-register callback functions

2019-09-05 Thread Hari Bathini
On 05/09/19 12:53 PM, Michael Ellerman wrote: > Hari Bathini writes: >> diff --git a/arch/powerpc/platforms/powernv/opal-fadump.c >> b/arch/powerpc/platforms/powernv/opal-fadump.c >> index e466f7e..91fb909 100644 >> --- a/arch/powerpc/platforms/powernv/opal-fad

[PATCH v6 02/36] powerpc/fadump: add helper functions

2019-09-11 Thread Hari Bathini
tual address is used often. Signed-off-by: Hari Bathini --- * New patch to add a few helper functions. Also, save vaddr for CPU notes buffer in fw_dump structure. arch/powerpc/include/asm/fadump-internal.h |2 arch/powerpc/kernel/fadump.c | 127 +++

[PATCH v6 04/36] powerpc/fadump: Improve fadump documentation

2019-09-11 Thread Hari Bathini
The figures depicting FADump's (Firmware-Assisted Dump) memory layout are missing some finer details like different memory regions and what they represent. Improve the documentation by updating those details. Signed-off-by: Hari Bathini --- * No changes in v6. Documentation/powerpc/firmware

[PATCH v6 08/36] pseries/fadump: define RTAS register/un-register callback functions

2019-09-11 Thread Hari Bathini
Move platform specific register/un-register code, the RTAS calls, to register/un-register callback functions. This would also mean moving code that initializes and prints the platform specific FADump data. Signed-off-by: Hari Bathini Reviewed-by: Mahesh Salgaonkar --- Changes in v6: * Split

[PATCH v6 00/36] Add FADump support on PowerNV platform

2019-09-11 Thread Hari Bathini
the patches based on discussions with mahesh on V4. --- Hari Bathini (36): powerpc/fadump: move internal macros/definitions to a new header powerpc/fadump: add helper functions powerpc/fadump: declare helper functions in internal header file powerpc/fadump: Improve fadump

[PATCH v6 05/36] powerpc/fadump: use helper functions to reserve/release cpu notes buffer

2019-09-11 Thread Hari Bathini
Use helper functions to simplify memory allocation, pinning down and freeing the memory used for CPU notes buffer. Signed-off-by: Hari Bathini --- * New patch to improve CPU notes buffer allocation. arch/powerpc/kernel/fadump.c | 21 ++--- 1 file changed, 6 insertions

[PATCH v6 06/36] pseries/fadump: move rtas specific definitions to platform code

2019-09-11 Thread Hari Bathini
Currently, FADump is only supported on pSeries but that is going to change soon with FADump support being added on PowerNV platform. So, move rtas specific definitions to platform code to allow FADump to have multiple platforms support. Signed-off-by: Hari Bathini --- Changes in v6: * Use

[PATCH v6 07/36] pseries/fadump: introduce callbacks for platform specific operations

2019-09-11 Thread Hari Bathini
Introduce callback functions for platform specific operations like register, unregister, invalidate & such. Also, define place-holders for the same on pSeries platform. Signed-off-by: Hari Bathini --- Changes in v6: * Drop using unnecessary return type for platform specific DT scan func

[PATCH v6 09/36] pseries/fadump: add source info while displaying region contents

2019-09-11 Thread Hari Bathini
Improve how fadump_region contents are displayed by adding source information of memory regions that are to be dumped by f/w. Signed-off-by: Hari Bathini --- * New patch to update how fadump region contents are displayed. arch/powerpc/platforms/pseries/rtas-fadump.c |8 1 file

[PATCH v6 01/36] powerpc/fadump: move internal macros/definitions to a new header

2019-09-11 Thread Hari Bathini
Though asm/fadump.h is meant to be used by other components dealing with FADump, it also has macros/definitions internal to FADump code. Move them to a new header file used within FADump code. This also makes way for refactoring platform specific FADump code. Signed-off-by: Hari Bathini

[PATCH v6 03/36] powerpc/fadump: declare helper functions in internal header file

2019-09-11 Thread Hari Bathini
Declare helper functions, that can be reused by multiple platforms, in the internal header file. Signed-off-by: Hari Bathini --- Changes in v6: * Declare helper functions in internal header while keeping the definitions in arch/powerpc/kernel/fadump.c itself. arch/powerpc/include/asm

[PATCH v6 10/36] powerpc/fadump: release all the memory above boot memory size

2019-09-11 Thread Hari Bathini
), is released when the dump is invalidated. Make this a bit more explicit in the code. Signed-off-by: Hari Bathini --- Changes in v6: * Changelog update. arch/powerpc/kernel/fadump.c | 34 ++ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/arch

[PATCH v6 11/36] pseries/fadump: move out platform specific support from generic code

2019-09-11 Thread Hari Bathini
Move code that supports processing the crash'ed kernel's memory preserved by firmware to platform specific callback functions. Signed-off-by: Hari Bathini --- * No major changes in v6. arch/powerpc/kernel/fadump.c | 329 +- arch/powerpc/platforms

[PATCH v6 12/36] powerpc/fadump: use FADump instead of fadump for how it is pronounced

2019-09-11 Thread Hari Bathini
fadump is pronounced f-a-dump. Update documentation accordingly. Also, update how fadump_region contents look like with recent changes. Signed-off-by: Hari Bathini --- * No changes in v6. Documentation/powerpc/firmware-assisted-dump.rst | 55 -- 1 file changed, 30

[PATCH v6 14/36] powernv/fadump: add fadump support on powernv

2019-09-11 Thread Hari Bathini
Add basic callback functions for FADump on PowerNV platform. Signed-off-by: Hari Bathini --- Changes in v6: * Drop using unnecessary return type for platform specific DT scan function. arch/powerpc/Kconfig |5 + arch/powerpc/include/asm/fadump-internal.h

[PATCH v6 16/36] powernv/fadump: register kernel metadata address with opal

2019-09-11 Thread Hari Bathini
OPAL allows registering address with it in the first kernel and retrieving it after MPIPL. Setup kernel metadata and register its address with OPAL to use it for processing the crash dump. Signed-off-by: Hari Bathini --- Changes in v6: * Use kernel types instead of ulong and such * Drop

<    1   2   3   4   5   6   7   8   >