[RFC Patch 0/2] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver XV

2010-03-23 Thread K.Prasad
to code comments as per community reviews for previous version. - Minor coding-style changes in hw_breakpoint.c as per review comments. - Re-based to commit ae6be51ed01d6c4aaf249a207b4434bc7785853b of linux-2.6 Thanks, K.Prasad Changelog - ver XIV (Version XIII: linuxppc-dev ref

[RFC Patch 1/2] PPC64-HWBKPT: Disable interrupts for data breakpoint exceptions

2010-03-23 Thread K.Prasad
Data address breakpoint exceptions are currently handled along with page-faults which require interrupts to remain in enabled state. Since exception handling for data breakpoints aren't pre-empt safe, we handle them separately. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc

[RFC Patch 2/2] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2010-03-23 Thread K.Prasad
Implement perf-events based hw-breakpoint interfaces for PPC64 processors. These interfaces help arbitrate requests from various users and schedules them as appropriate. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig |1 arch/powerpc/include

Re: [Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2010-03-15 Thread K.Prasad
of the patch with the fixes as agreed above. Thanks, K.Prasad ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[Patch 0/1] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver XIV

2010-03-08 Thread K.Prasad
in hw_breakpoint_handler() and single_step_dabr_instruction(). - Re-based to commit 25cf84cf377c0aae5dbcf937ea89bc7893db5176 of linux-2.6 Thanks, K.Prasad Changelog - ver XIII (Version XII: linuxppc-dev ref: 20100121084640.ga3...@in.ibm.com) - Fixed a bug for user-space breakpoints

[Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2010-03-08 Thread K.Prasad
Implement perf-events based hw-breakpoint interfaces for PPC64 processors. These interfaces help arbitrate requests from various users and schedules them as appropriate. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig |1 arch/powerpc/include

Re: [Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2010-03-08 Thread K.Prasad
On Fri, Feb 26, 2010 at 02:58:12AM +0100, Frederic Weisbecker wrote: On Mon, Feb 22, 2010 at 06:47:46PM +0530, K.Prasad wrote: The 'name' field here is actually a legacy inherited from x86 code. It is part of x86's arch-specific hw-breakpoint structure since: - inspired by the kprobe

Re: [Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2010-02-23 Thread K.Prasad
On Mon, Feb 22, 2010 at 06:47:46PM +0530, K.Prasad wrote: On Sun, Feb 21, 2010 at 02:01:37AM +0100, Frederic Weisbecker wrote: On Mon, Feb 15, 2010 at 11:29:14AM +0530, K.Prasad wrote: [snipped] Also, do you think addr/len/type is enough to abstract out any ppc breakpoints? This looks

Re: [Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2010-02-22 Thread K.Prasad
On Sun, Feb 21, 2010 at 02:01:37AM +0100, Frederic Weisbecker wrote: On Mon, Feb 15, 2010 at 11:29:14AM +0530, K.Prasad wrote: +struct arch_hw_breakpoint { + u8 len; /* length of the target symbol */ + int type; + char*name; /* Contains name

[Patch 0/1] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver XIII

2010-02-14 Thread K.Prasad
for user-space breakpoints (triggered following the failure of a breakpoint request) causing data exception (due to access of NULL/spurious address). - Re-based on commit 724e6d3fe8003c3f60bf404bf22e4e331327c596 of linux-2.6 Thanks, K.Prasad Changelog - ver XII (Version XI

[Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2010-02-14 Thread K.Prasad
Implement perf-events based hw-breakpoint interfaces for PPC64 processors. These interfaces help arbitrate requests from various users and schedules them as appropriate. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig |1 arch/powerpc/include

Re: [RFC:PATCH 00/03] powerpc: Expose BookE debug registers through extended ptrace interface

2010-01-27 Thread K.Prasad
On Mon, Jan 25, 2010 at 07:32:00AM +1100, Benjamin Herrenschmidt wrote: On Mon, 2010-01-25 at 00:48 +0530, K.Prasad wrote: Some of the benefits of using these generic interfaces include: - Interoperability with other users of debug register (such as parallel kernel requests) i.e. non

Re: [RFC:PATCH 00/03] powerpc: Expose BookE debug registers through extended ptrace interface

2010-01-24 Thread K.Prasad
(such as parallel kernel requests) i.e. non-exclusive use of debug registers. - Enables debugging/tracing tools such as perf-events and ftrace to make use of debug registers. - Re-use of common code available in kernel (kernel/hw_breakpoint.c). Let me know what you think. Thanks, K.Prasad

[Patch 0/1] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver XII

2010-01-21 Thread K.Prasad
of the exception. - User-space instructions are not emulated from kernel-space, they are instead single-stepped. Looking forward for your comments. Thanks, K.Prasad Changelog - ver XI -- (Version X: linuxppc-dev ref: 20091211160144.ga23...@in.ibm.com) - Conditionally unset MSR_SE

Re: [Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2010-01-21 Thread K.Prasad
.) but with the reasons you pointed out, it is much better than having uncertain/incorrect code. Thanks for your comments. -- K.Prasad ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2010-01-19 Thread K.Prasad
Implement perf-events based hw-breakpoint interfaces for PPC64 processors. These interfaces help arbitrate requests from various users and schedules them as appropriate. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig |1 arch/powerpc/include

Re: [Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2009-12-17 Thread K.Prasad
but as I learn, it seems fine now. It is just that the kernel code needs to be tweaked keeping this in mind. Thanks, K.Prasad ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2009-12-14 Thread K.Prasad
the breakpoints (surviving a pre-emption), I will send out a new patch that resorts to a one-shot behaviour for user-space (kernel-space is fine though). Thank you for the insightful comments! K.Prasad ___ Linuxppc-dev mailing list Linuxppc-dev

[Patch 0/1] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver X

2009-12-11 Thread K.Prasad
ksym_tracer and watchpoints over GDB and are found to work fine. Kindly let me know your comments at the earliest to expedite their upstream integration. Thanks, K.Prasad Changelog - ver IX --- - Invocation of user-defined callback will be 'trigger-after-execute' (except for ptrace

[Patch 1/1] PPC64-HWBKPT: Implement hw-breakpoints for PPC64

2009-12-11 Thread K.Prasad
Implement perf-events based hw-breakpoint interfaces for PPC64 processors. These interfaces help arbitrate requests from various users and schedules them as appropriate. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig |1 arch/powerpc/include

[Patch 0/6] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver IX

2009-09-03 Thread K.Prasad
hw_breakpoint' and can accomodate requests for a subset of CPUs in the system. - Introduced arch_disable_hw_breakpoint() required for enabledisable_hw_breakpoint() APIs. Kindly let me know your comments on the same. Thanks, K.Prasad Changelog - ver VIII --- - Reverting changes

[Patch 1/6] PPC64-HWBKPT: Prepare the PowerPC platform for HW Breakpoint infrastructure

2009-09-03 Thread K.Prasad
Prepare the PowerPC code for HW Breakpoint infrastructure patches by including relevant constant definitions and function declarations. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/include/asm/hw_breakpoint.h | 61 +++ arch/powerpc/include/asm

[Patch 4/6] PPC64-HWBKPT: Modify process/processor code to recognise hardware debug registers

2009-09-03 Thread K.Prasad
Modify process handling code to recognise hardware debug registers during copy and flush operations. Introduce a new TIF_DEBUG task flag to indicate a process's use of debug register. Load the debug register values into a new CPU during initialisation. Signed-off-by: K.Prasad pra

[Patch 5/6] PPC64-HWBKPT: Modify Data storage exception code to recognise DABR match first

2009-09-03 Thread K.Prasad
Modify Data storage exception code to first lookout for a DABR match before recognising a kprobe or xmon exception. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/mm/fault.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) Index: linux-2.6-tip.hbkpt

Re: [Patch 0/6] [Patch 0/6] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver VIII

2009-08-03 Thread K.Prasad
On Fri, Jul 31, 2009 at 04:10:13PM +1000, David Gibson wrote: On Mon, Jul 27, 2009 at 05:41:52AM +0530, K.Prasad wrote: edited Reasons - Signal delivery before execution of instruction requires complex workarounds - One of the plausible workarounds is a two-pass hw

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-08-03 Thread K.Prasad
On Fri, Jul 31, 2009 at 04:16:46PM +1000, David Gibson wrote: On Mon, Jul 27, 2009 at 05:43:17AM +0530, K.Prasad wrote: Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile

[Patch 0/6] [Patch 0/6] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver VIII

2009-07-26 Thread K.Prasad
in arch_validate_hwbkpt_settings(). - put_cpu_no_resched() is no longer available. Converted to put_cpu(). Thanks, K.Prasad Previous changelogs --- Changelog - ver VII --- - Allow the one-shot behaviour for exception handlers to be defined by the user. A new 'is_one_shot' flag is added

[Patch 1/6] Prepare the PowerPC platform for HW Breakpoint infrastructure

2009-07-26 Thread K.Prasad
Prepare the PowerPC code for HW Breakpoint infrastructure patches by including relevant constant definitions and function declarations. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/include/asm/hw_breakpoint.h | 59 +++ arch/powerpc/include/asm

[Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-07-26 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile

[Patch 4/6] Modify process and processor handling code to recognise hardware debug registers

2009-07-26 Thread K.Prasad
Modify process handling code to recognise hardware debug registers during copy and flush operations. Introduce a new TIF_DEBUG task flag to indicate a process's use of debug register. Load the debug register values into a new CPU during initialisation. Signed-off-by: K.Prasad pra

[Patch 5/6] Modify Data storage exception code to recognise DABR match first

2009-07-26 Thread K.Prasad
Modify Data storage exception code to first lookout for a DABR match before recognising a kprobe or xmon exception. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/mm/fault.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) Index: linux-2.6-tip.hbkpt

[Patch 6/6] Adapt kexec and samples code to recognise PPC64 hardware breakpoint usage

2009-07-26 Thread K.Prasad
Modify kexec code to disable DABR registers before a reboot. Adapt the samples code to populate PPC64-arch specific fields. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel/machine_kexec_64.c |3 +++ samples/hw_breakpoint/data_breakpoint.c |4 2 files

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-07-03 Thread K.Prasad
On Fri, Jun 19, 2009 at 03:04:09PM +1000, David Gibson wrote: On Thu, Jun 18, 2009 at 11:50:45PM +0530, K.Prasad wrote: On Wed, Jun 17, 2009 at 02:32:24PM +1000, David Gibson wrote: On Wed, Jun 10, 2009 at 02:38:06PM +0530, K.Prasad wrote: [snip] With apologies for the long delay here's my

Re: [Patch 4/6] Modify process and processor handling code to recognise hardware debug registers

2009-06-18 Thread K.Prasad
On Wed, Jun 17, 2009 at 02:14:20PM +1000, David Gibson wrote: On Wed, Jun 10, 2009 at 02:38:18PM +0530, K.Prasad wrote: Modify process handling code to recognise hardware debug registers during copy and flush operations. Introduce a new TIF_DEBUG task flag to indicate a process's use

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-18 Thread K.Prasad
On Wed, Jun 17, 2009 at 02:32:24PM +1000, David Gibson wrote: On Wed, Jun 10, 2009 at 02:38:06PM +0530, K.Prasad wrote: Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-15 Thread K.Prasad
On Mon, Jun 15, 2009 at 04:40:45PM +1000, David Gibson wrote: On Wed, Jun 10, 2009 at 12:13:49PM +0530, K.Prasad wrote: On Fri, Jun 05, 2009 at 03:11:58PM +1000, David Gibson wrote: On Wed, Jun 03, 2009 at 10:05:11PM +0530, K.Prasad wrote: + else

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-10 Thread K.Prasad
On Fri, Jun 05, 2009 at 03:11:58PM +1000, David Gibson wrote: On Wed, Jun 03, 2009 at 10:05:11PM +0530, K.Prasad wrote: Hi David, Sorry for the delay in response below. In the meanwhile, I discovered an issue in detecting stray exceptions that affected user-space handling of breakpoints

Re: [Patch 3/6] Modify ptrace code to use Hardware Breakpoint interfaces

2009-06-10 Thread K.Prasad
On Fri, Jun 05, 2009 at 03:13:45PM +1000, David Gibson wrote: On Wed, Jun 03, 2009 at 10:05:24PM +0530, K.Prasad wrote: Modify the ptrace code to use the hardware breakpoint interfaces for user-space. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel

[Patch 0/6] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver VI

2009-06-10 Thread K.Prasad
of the 'watched' kernel symbol into 'symbolsize' field in arch_store_info(0 routine. - Verify if the above described condition is true when is_one_shot is FALSE in hw_breakpoint_handler(). Kindly let me know your comments on the same. Thanks, K.Prasad

[Patch 3/6] Modify ptrace code to use Hardware Breakpoint interfaces

2009-06-10 Thread K.Prasad
Modify the ptrace code to use the hardware breakpoint interfaces for user-space. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel/ptrace.c | 43 +++ 1 file changed, 43 insertions(+) Index: linux-2.6-tip.hbkpt/arch/powerpc/kernel

[Patch 4/6] Modify process and processor handling code to recognise hardware debug registers

2009-06-10 Thread K.Prasad
Modify process handling code to recognise hardware debug registers during copy and flush operations. Introduce a new TIF_DEBUG task flag to indicate a process's use of debug register. Load the debug register values into a new CPU during initialisation. Signed-off-by: K.Prasad pra

[Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-10 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile

[Patch 5/6] Modify Data storage exception code to recognise DABR match first

2009-06-10 Thread K.Prasad
Modify Data storage exception code to first lookout for a DABR match before recognising a kprobe or xmon exception. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/mm/fault.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) Index: linux-2.6-tip.hbkpt

[Patch 6/6] Adapt kexec and samples code to recognise PPC64 hardware breakpoint usage

2009-06-10 Thread K.Prasad
Modify kexec code to disable DABR registers before a reboot. Adapt the samples code to populate PPC64-arch specific fields. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel/machine_kexec_64.c |3 +++ samples/hw_breakpoint/data_breakpoint.c |4 2 files

[Patch 0/6] PPC64-HWBKPT: Hardware Breakpoint interfaces - ver V

2009-06-03 Thread K.Prasad
acceptance. Thanks, K.Prasad ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-06-03 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile

[Patch 3/6] Modify ptrace code to use Hardware Breakpoint interfaces

2009-06-03 Thread K.Prasad
Modify the ptrace code to use the hardware breakpoint interfaces for user-space. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel/ptrace.c | 47 +++ 1 file changed, 47 insertions(+) Index: linux-2.6-tip.hbkpt/arch/powerpc/kernel

[Patch 4/6] Modify process and processor handling code to recognise hardware debug registers

2009-06-03 Thread K.Prasad
Modify process handling code to recognise hardware debug registers during copy and flush operations. Introduce a new TIF_DEBUG task flag to indicate a process's use of debug register. Load the debug register values into a new CPU during initialisation. Signed-off-by: K.Prasad pra

[Patch 5/6] Modify Data storage exception code to recognise DABR match first

2009-06-03 Thread K.Prasad
Modify Data storage exception code to first lookout for a DABR match before recognising a kprobe or xmon exception. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/mm/fault.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) Index: linux-2.6-tip.hbkpt

[Patch 6/6] Adapt kexec and samples code to recognise PPC64 hardware breakpoint usage

2009-06-03 Thread K.Prasad
Modify kexec code to disable DABR registers before a reboot. Adapt the samples code to populate PPC64-arch specific fields. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel/machine_kexec_64.c |3 +++ samples/hw_breakpoint/data_breakpoint.c |4 2 files

Re: [Patch 1/6] Prepare the PowerPC platform for HW Breakpoint infrastructure

2009-05-29 Thread K.Prasad
On Fri, May 29, 2009 at 01:20:48PM +1000, David Gibson wrote: On Mon, May 25, 2009 at 06:44:23AM +0530, K.Prasad wrote: Prepare the PowerPC code for HW Breakpoint infrastructure patches by including relevant constant definitions and function declarations. Signed-off-by: K.Prasad pra

Re: [Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-05-29 Thread K.Prasad
On Fri, May 29, 2009 at 02:18:49PM +1000, David Gibson wrote: On Mon, May 25, 2009 at 06:45:22AM +0530, K.Prasad wrote: +/* + * Handle debug exception notifications. + */ +int __kprobes hw_breakpoint_handler(struct die_args *args) +{ + int rc = NOTIFY_STOP; + struct

[Patch 0/6] PPC64: Hardware Breakpoint interfaces - ver IV

2009-05-24 Thread K.Prasad
integrated into this facility as described in Ver I. Kindly review the patches and let me know if they're in a form that is ready for upstream inclusion. Thanks, K.Prasad ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman

[Patch 1/6] Prepare the PowerPC platform for HW Breakpoint infrastructure

2009-05-24 Thread K.Prasad
Prepare the PowerPC code for HW Breakpoint infrastructure patches by including relevant constant definitions and function declarations. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/include/asm/hw_breakpoint.h | 57 +++ arch/powerpc/include/asm

[Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-05-24 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile

[Patch 3/6] Modify ptrace code to use Hardware Breakpoint interfaces

2009-05-24 Thread K.Prasad
Modify the ptrace code to use the hardware breakpoint interfaces for user-space. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel/ptrace.c | 44 +++ 1 file changed, 44 insertions(+) Index: linux-2.6-tip.hbkpt/arch/powerpc/kernel

[Patch 5/6] Modify Data storage exception code to recognise DABR match first

2009-05-24 Thread K.Prasad
Modify Data storage exception code to first lookout for a DABR match before recognising a kprobe or xmon exception. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/mm/fault.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) Index: linux-2.6-tip.hbkpt

[Patch 6/6] Adapt kexec and samples code to recognise PPC64 hardware breakpoint usage

2009-05-24 Thread K.Prasad
Modify kexec code to disable DABR registers before a reboot. Adapt the samples code to populate PPC64-arch specific fields. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel/machine_kexec_64.c |3 +++ samples/hw_breakpoint/data_breakpoint.c |4 2 files

Re: [RFC Patch 2/6] Introduce PPC64 specific Hardware Breakpointinterfaces

2009-05-21 Thread K.Prasad
On Mon, May 18, 2009 at 12:30:41PM -0400, Alan Stern wrote: On Mon, 18 May 2009, K.Prasad wrote: +int __kprobes hw_breakpoint_handler(struct die_args *args) +{ + int rc = NOTIFY_STOP; + struct hw_breakpoint *bp; + struct pt_regs *regs = args-regs

[RFC Patch 0/6] PPC64: Hardware Breakpoint interfaces - ver III

2009-05-21 Thread K.Prasad
in 'struct hw_breakpoint' to avoid handling of exceptions that belong to kprobe/Xmon. Thanks, K.Prasad ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[RFC Patch 1/6] Prepare the PowerPC platform for HW Breakpoint infrastructure

2009-05-21 Thread K.Prasad
Prepare the PowerPC code for HW Breakpoint infrastructure patches by including relevant constant definitions and function declarations. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/include/asm/hw_breakpoint.h | 57 +++ arch/powerpc/include/asm

[RFC Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-05-21 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile

[RFC Patch 3/6] Modify ptrace code to use Hardware Breakpoint interfaces

2009-05-21 Thread K.Prasad
Modify the ptrace code to use the hardware breakpoint interfaces for user-space. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel/ptrace.c | 45 +++ 1 file changed, 45 insertions(+) Index: linux-2.6-tip.hbkpt/arch/powerpc/kernel

[RFC Patch 4/6] Modify process and processor handling code to recognise hardware debug registers

2009-05-21 Thread K.Prasad
Modify process handling code to recognise hardware debug registers during copy and flush operations. Introduce a new TIF_DEBUG task flag to indicate a process's use of debug register. Load the debug register values into a new CPU during initialisation. Signed-off-by: K.Prasad pra

[RFC Patch 5/6] Modify Data storage exception code to recognise DABR match first

2009-05-21 Thread K.Prasad
Modify Data storage exception code to first lookout for a DABR match before recognising a kprobe or xmon exception. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/mm/fault.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) Index: linux-2.6-tip.hbkpt

[RFC Patch 6/6] Adapt kexec and samples code to recognise PPC64 hardware breakpoint usage

2009-05-21 Thread K.Prasad
Modify kexec code to disable DABR registers before a reboot. Adapt the samples code to populate PPC64-arch specific fields. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel/machine_kexec_64.c |3 +++ samples/hw_breakpoint/data_breakpoint.c |4 2 files

Re: [RFC Patch 6/6] Adapt kexec and samples code to recognise PPC64hardware breakpoint usage

2009-05-18 Thread K.Prasad
On Thu, May 14, 2009 at 04:21:48PM -0400, Alan Stern wrote: On Thu, 14 May 2009, K.Prasad wrote: Index: linux-2.6-tip.hbkpt/samples/hw_breakpoint/data_breakpoint.c === --- linux-2.6-tip.hbkpt.orig/samples/hw_breakpoint

Re: [RFC Patch 1/6] Prepare the PowerPC platform for HW Breakpoint infrastructure

2009-05-18 Thread K.Prasad
On Mon, May 18, 2009 at 01:35:32PM +1000, Benjamin Herrenschmidt wrote: On Thu, 2009-05-14 at 19:13 +0530, K.Prasad wrote: plain text document attachment (ppc64_prepare_code_01) Prepare the PowerPC code for HW Breakpoint infrastructure patches by including relevant constant definitions

[RFC Patch 0/6] PPC64: Hardware Breakpoint interfaces - ver II

2009-05-14 Thread K.Prasad
INSTRUCTION_LEN in reg.h Thanks, K.Prasad ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[RFC Patch 1/6] Prepare the PowerPC platform for HW Breakpoint infrastructure

2009-05-14 Thread K.Prasad
Prepare the PowerPC code for HW Breakpoint infrastructure patches by including relevant constant definitions and function declarations. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/include/asm/hw_breakpoint.h | 49 + arch/powerpc/include/asm/processor.h |1

[RFC Patch 2/6] Introduce PPC64 specific Hardware Breakpoint interfaces

2009-05-14 Thread K.Prasad
Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel/hw_breakpoint.c. Enable the HAVE_HW_BREAKPOINT flag and the Makefile. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig|1 arch/powerpc/kernel/Makefile

[RFC Patch 3/6] Modify ptrace code to use Hardware Breakpoint interfaces

2009-05-14 Thread K.Prasad
Modify the ptrace code to use the hardware breakpoint interfaces for user-space. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel/ptrace.c | 48 + Index: linux-2.6-tip.hbkpt/arch/powerpc/kernel/ptrace.c

[RFC Patch 4/6] Modify process handling code to handle hardware debug registers

2009-05-14 Thread K.Prasad
Modify process handling code to recognise hardware debug registers during copy and flush operations. Introduce a new TIF_DEBUG task flag to indicate a process's use of debug register. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/include/asm/thread_info.h |2 arch

[RFC Patch 5/6] Modify Data storage exception code to recognise DABR match first

2009-05-14 Thread K.Prasad
Modify Data storage exception code to first lookout for a DABR match before recognising a kprobe or xmon exception. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/mm/fault.c | 14 - Index: linux-2.6-tip.hbkpt/arch/powerpc/mm/fault.c

[RFC Patch 6/6] Adapt kexec and samples code to recognise PPC64 hardware breakpoint usage

2009-05-14 Thread K.Prasad
Modify kexec code to disable DABR registers before a reboot. Adapt the samples code to populate PPC64-arch specific fields. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/kernel/machine_kexec_64.c |6 samples/hw_breakpoint/data_breakpoint.c |4 Index: linux-2.6

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-14 Thread K.Prasad
On Wed, May 13, 2009 at 12:57:17PM +1000, David Gibson wrote: On Wed, May 13, 2009 at 01:55:45AM +0530, K.Prasad wrote: On Tue, May 12, 2009 at 07:51:49AM -0400, Josh Boyer wrote: On Tue, May 12, 2009 at 01:33:55AM +0530, K.Prasad wrote: [snip] It seems to me that a kind of minimal

Re: [RFC Patch 6/6] Adapt kexec and samples code to recognise PPC64hardware breakpoint usage

2009-05-14 Thread K.Prasad
On Thu, May 14, 2009 at 03:59:45PM +0200, Geert Uytterhoeven wrote: On Thu, 14 May 2009, K.Prasad wrote: Modify kexec code to disable DABR registers before a reboot. Adapt the samples code to populate PPC64-arch specific fields. Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com

Re: [RFC Patch 2/6] Introduce PPC64 specific Hardware Breakpointinterfaces

2009-05-14 Thread K.Prasad
On Fri, May 15, 2009 at 12:50:11AM +1000, Michael Ellerman wrote: On Thu, 2009-05-14 at 19:14 +0530, K.Prasad wrote: plain text document attachment (ppc64_arch_hwbkpt_implementation_02) Introduce PPC64 implementation for the generic hardware breakpoint interfaces defined in kernel

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-12 Thread K.Prasad
of breakpoints through bdops. (Note: On a Power5 machine running 2.6.29, Xmon could not trigger HW Breakpoints when tested). Kindly let me know your comments. Thanks, K.Prasad Signed-off-by: K.Prasad pra...@linux.vnet.ibm.com --- arch/powerpc/Kconfig

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-12 Thread K.Prasad
On Tue, May 12, 2009 at 07:51:49AM -0400, Josh Boyer wrote: On Tue, May 12, 2009 at 01:33:55AM +0530, K.Prasad wrote: Hi PPC Dev folks, Please find a patch below that implements the proposed Hardware Breakpoint interfaces for PPC64 architecture. As a brief introduction, the proposed

Re: [RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-12 Thread K.Prasad
On Tue, May 12, 2009 at 11:47:38AM -0500, Scott Wood wrote: On Tue, May 12, 2009 at 07:51:49AM -0400, Josh Boyer wrote: On Tue, May 12, 2009 at 01:33:55AM +0530, K.Prasad wrote: - The patch is currently implemented only for PPC64 architecture. Other architectures (especially Book-E

[RFC] Hardware Breakpoint interfaces implementation for PPC64

2009-05-11 Thread K.Prasad
in a mutually exclusive manner. Xmon's integration is pending and is dependant on successful triggering of breakpoints through bdops. (Note: On a Power5 machine running 2.6.29, Xmon could not trigger HW Breakpoints when tested). Kindly let me know your comments. Thanks, K.Prasad Signed-off

<    1   2