Re: (subset) [PATCH v4 01/10] leds: aw2013: unlock mutex before destroying it
On Thu, 14 Dec 2023 20:36:05 +0300, George Stark wrote: > In the probe() callback in case of error mutex is destroyed being locked > which is not allowed so unlock the mutex before destroying. > > Applied, thanks! [01/10] leds: aw2013: unlock mutex before destroying it commit: eb0f0a751c8e26b212f78fe7325fa2506c5cbb4b -- Lee Jones [李琼斯]
Re: [PATCH v4 00/10] devm_led_classdev_register() usage problem
s-an30259a.c | 15 +-- > drivers/leds/leds-aw200xx.c | 33 ++--- > drivers/leds/leds-aw2013.c | 27 +++ > drivers/leds/leds-lm3532.c | 30 ++ > drivers/leds/leds-lp3952.c | 21 +++-- > drivers/leds/leds-mlxreg.c | 17 ++--- > drivers/leds/leds-nic78bx.c | 25 +++++++++---- > drivers/leds/leds-powernv.c | 23 --- FYI: I'll conduct my review once the locking side is settled. > include/linux/mutex.h| 23 +++ > kernel/locking/mutex-debug.c | 22 ++ > 10 files changed, 143 insertions(+), 93 deletions(-) > > -- > 2.25.1 > > -- Lee Jones [李琼斯]
Re: (subset) [PATCH v4 23/28] mfd: core: Ensure disabled devices are skiped without aborting
On Fri, 18 Aug 2023 18:39:17 +0200, Christophe Leroy wrote: > The loop searching for a matching device based on its compatible > string is aborted when a matching disabled device is found. > This abort prevents to add devices as soon as one disabled device > is found. > > Continue searching for an other device instead of aborting on the > first disabled one fixes the issue. > > [...] Applied, thanks! [23/28] mfd: core: Ensure disabled devices are skiped without aborting commit: 36d139dc63db18eb95165fcc2bd3c670c948d605 -- Lee Jones [李琼斯]
Re: [PATCH v4 23/28] mfd: core: Ensure disabled devices are skiped without aborting
On Fri, 18 Aug 2023, Christophe Leroy wrote:
> From: Herve Codina
>
> The loop searching for a matching device based on its compatible
> string is aborted when a matching disabled device is found.
> This abort prevents to add devices as soon as one disabled device
> is found.
>
> Continue searching for an other device instead of aborting on the
> first disabled one fixes the issue.
>
> Fixes: 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored
> without error")
> Signed-off-by: Herve Codina
> Reviewed-by: Christophe Leroy
> Signed-off-by: Christophe Leroy
> ---
> drivers/mfd/mfd-core.c | 17 -
> 1 file changed, 12 insertions(+), 5 deletions(-)
This is too big of a change to be added this late in the cycle.
Pushing review until after v6.5 is out.
--
Lee Jones [李琼斯]
Re: [PATCH v2 22/28] mfd: core: Ensure disabled devices are skiped without aborting
On Wed, 26 Jul 2023, Herve Codina wrote:
> The loop searching for a matching device based on its compatible
> string is aborted when a matching disabled device is found.
> This abort avoid to add devices as soon as one disabled device
> is found.
>
> Continue searching for an other device instead of aborting on the
> first disabled one fixes the issue.
>
> Fixes: 22380b65dc70 ("mfd: mfd-core: Ensure disabled devices are ignored
> without error")
> Signed-off-by: Herve Codina
> ---
> drivers/mfd/mfd-core.c | 18 +-
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mfd/mfd-core.c b/drivers/mfd/mfd-core.c
> index 0ed7c0d7784e..bcc26e64639a 100644
> --- a/drivers/mfd/mfd-core.c
> +++ b/drivers/mfd/mfd-core.c
> @@ -146,6 +146,7 @@ static int mfd_add_device(struct device *parent, int id,
> struct platform_device *pdev;
> struct device_node *np = NULL;
> struct mfd_of_node_entry *of_entry, *tmp;
> + bool disabled;
> int ret = -ENOMEM;
> int platform_id;
> int r;
> @@ -181,13 +182,13 @@ static int mfd_add_device(struct device *parent, int id,
> goto fail_res;
>
> if (IS_ENABLED(CONFIG_OF) && parent->of_node && cell->of_compatible) {
> + disabled = false;
This does not appear to reside in a loop.
Why not set it to false on declaration?
> for_each_child_of_node(parent->of_node, np) {
> if (of_device_is_compatible(np, cell->of_compatible)) {
> - /* Ignore 'disabled' devices error free */
> + /* Skip 'disabled' devices */
> if (!of_device_is_available(np)) {
> - of_node_put(np);
Doesn't this result in a resource leak?
> - ret = 0;
> - goto fail_alias;
> + disabled = true;
> + continue;
> }
>
> ret = mfd_match_of_node_to_dev(pdev, np, cell);
> @@ -197,10 +198,17 @@ static int mfd_add_device(struct device *parent, int id,
> if (ret)
> goto fail_alias;
>
> - break;
> + goto match;
> }
> }
>
> + if (disabled) {
> + /* Ignore 'disabled' devices error free */
> + ret = 0;
> + goto fail_alias;
> + }
> +
> +match:
> if (!pdev->dev.of_node)
> pr_warn("%s: Failed to locate of_node [id: %d]\n",
> cell->name, platform_id);
> --
> 2.41.0
>
--
Lee Jones [李琼斯]
Re: [PATCH v3 06/12] gpiolib: split linux/gpio/driver.h out of linux/gpio.h
On Tue, 07 Feb 2023, Andy Shevchenko wrote: > From: Arnd Bergmann > > Almost all gpio drivers include linux/gpio/driver.h, and other > files should not rely on includes from this header. > > Remove the indirect include from here and include the correct > headers directly from where they are used. > > Reviewed-by: Andy Shevchenko > Signed-off-by: Arnd Bergmann > Reviewed-by: Linus Walleij > Signed-off-by: Andy Shevchenko > --- > arch/arm/mach-omap1/irq.c | 1 + > arch/arm/mach-orion5x/board-rd88f5182.c| 1 + > arch/arm/mach-s3c/s3c64xx.c| 1 + > arch/arm/mach-sa1100/assabet.c | 1 + > arch/arm/plat-orion/gpio.c | 1 + > drivers/net/wireless/broadcom/brcm80211/brcmsmac/led.c | 1 + > include/linux/gpio.h | 2 -- > include/linux/mfd/ucb1x00.h| 1 + Acked-by: Lee Jones > 8 files changed, 7 insertions(+), 2 deletions(-) -- Lee Jones [李琼斯]
Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property
On Thu, 26 Jan 2023, Sam Ravnborg wrote: > Hi Lee, > On Thu, Jan 26, 2023 at 02:27:26PM +0000, Lee Jones wrote: > > On Sat, 07 Jan 2023, Sam Ravnborg via B4 Submission Endpoint wrote: > > > > > From: Sam Ravnborg > > > > > > With all users gone remove the deprecated fb_blank member in > > > backlight_properties. > > > > > > Signed-off-by: Sam Ravnborg > > > Cc: Lee Jones > > > Cc: Daniel Thompson > > > Cc: Jingoo Han > > > --- > > > drivers/video/backlight/backlight.c | 2 -- > > > include/linux/backlight.h | 22 -- > > > 2 files changed, 24 deletions(-) > > > > Applied, thanks > > Some of the dependent patches in this series are not yet applied. > I have them queued up for processing this weekend, but I missed the -rc6 > window for drm-misc so they will likely not hit upstream in the upcoming > merge window. > I can try to expedite it. > > But if you have not yet pushed it, please revert this patch. > Then I will resend only when the remaining patches are upstream. Thanks for the info. Dropped. -- Lee Jones [李琼斯]
Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property
On Sat, 07 Jan 2023, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg > > With all users gone remove the deprecated fb_blank member in > backlight_properties. > > Signed-off-by: Sam Ravnborg > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > --- > drivers/video/backlight/backlight.c | 2 -- > include/linux/backlight.h | 22 -- > 2 files changed, 24 deletions(-) Applied, thanks -- Lee Jones [李琼斯]
Re: [PATCH v3 3/5] dt-bindings: usb: Convert OMAP OHCI/EHCI bindings to schema
On Mon, 23 Jan 2023, Rob Herring wrote: > The OMAP OHCI and EHCI USB host bindings follow the generic binding, so > add the compatibles and remove the old txt binding docs. > > The examples in omap-usb-host.txt don't match actual users, so update > them dropping the fallback compatible. > > Signed-off-by: Rob Herring > --- > v3: > - Fix document references to generic-ehci.yaml and generic-ohci.yaml (0-day) > v2: > - New patch > --- > .../devicetree/bindings/mfd/omap-usb-host.txt | 8 +++--- Acked-by: Lee Jones > .../devicetree/bindings/usb/ehci-omap.txt | 31 > -- > .../devicetree/bindings/usb/generic-ehci.yaml | 1 + > .../devicetree/bindings/usb/generic-ohci.yaml | 4 ++- > .../devicetree/bindings/usb/ohci-omap3.txt | 15 --- > 5 files changed, 8 insertions(+), 51 deletions(-) -- Lee Jones [李琼斯]
Re: [PATCH RESEND 0/8] Resend LED patches
On Fri, 20 Jan 2023, Arnd Bergmann wrote: > On Fri, Jan 20, 2023, at 18:15, Lee Jones wrote: > > On Fri, 20 Jan 2023, Arnd Bergmann wrote: > > >> > Marek Behún (3): > >> > leds: turris-omnia: support HW controlled mode via private trigger > >> > leds: turris-omnia: initialize multi-intensity to full > >> > leds: turris-omnia: change max brightness from 255 to 1 > >> > > >> > Pali Rohár (5): > >> > dt-bindings: leds: register-bit-led: Add active-low property > >> > leds: syscon: Implement support for active-low property > >> > powerpc/85xx: DTS: Add CPLD definitions for P1021RDB Combo Board CPL > >> > Design > >> > dt-bindings: leds: Add cznic,turris1x-leds.yaml binding > >> > leds: Add support for Turris 1.x LEDs > >> > > >> > .../testing/sysfs-class-led-driver-turris1x | 31 ++ > >> > .../bindings/leds/cznic,turris1x-leds.yaml| 118 + > >> > .../bindings/leds/register-bit-led.yaml | 5 + > >> > arch/powerpc/boot/dts/fsl/p1020mbg-pc.dtsi| 92 > >> > arch/powerpc/boot/dts/fsl/p1020mbg-pc_32b.dts | 6 +- > >> > arch/powerpc/boot/dts/fsl/p1020mbg-pc_36b.dts | 6 +- > >> > arch/powerpc/boot/dts/fsl/p1020rdb-pd.dts | 44 +- > >> > arch/powerpc/boot/dts/fsl/p1020utm-pc.dtsi| 37 ++ > >> > arch/powerpc/boot/dts/fsl/p1020utm-pc_32b.dts | 4 +- > >> > arch/powerpc/boot/dts/fsl/p1020utm-pc_36b.dts | 4 +- > >> > arch/powerpc/boot/dts/fsl/p1021rdb-pc.dtsi| 37 ++ > >> > arch/powerpc/boot/dts/fsl/p1021rdb-pc_32b.dts | 5 +- > >> > arch/powerpc/boot/dts/fsl/p1021rdb-pc_36b.dts | 5 +- > >> > arch/powerpc/boot/dts/fsl/p2020rdb-pc.dtsi| 33 +- > > > >> > drivers/leds/Kconfig | 10 + > >> > drivers/leds/Makefile | 1 + > >> > drivers/leds/leds-syscon.c| 14 +- > >> > drivers/leds/leds-turris-1x.c | 474 ++ > >> > drivers/leds/leds-turris-omnia.c | 46 +- > > > > If everyone is convinced that applying these drivers is the correct > > thing to do, I'd be happy to (rather) take them via LEDs. > > Ok, thanks. I had not actually looked at the patches until today. > They were in the soc tree backlog but appeared to be misplaced > there until I read the 0/10 message text. > > Looking at it now, I see: > > - patches 1 and 2 seem obvious and have been reviewed by > others already > > - patch 3 is for arch/powerpc and should get merged through > there if there are no objections to the binding in patch 4. > > - patch 5 is the big driver patch, with a Reviewed-by tag > from Marek Behún, who is the author of the last three patches. > An earlier version of this patch was sent in June and got > a few Acks and detailed feedback from Andy [1], but he's also > not on Cc, and I don't know if his comments are all resolved > in this version. > > - Patches 6, 7 and 8 all seem simple LED subsystem patches, > they just need review from you in order to get applied. > These are also missing a Signed-off-by from the submitter > in addition to the author in order to be applied. Very well. Let's have them resent then please (with past reviewers on Cc:) and we'll go from there. -- Lee Jones [李琼斯]
Re: [PATCH RESEND 0/8] Resend LED patches
On Fri, 20 Jan 2023, Arnd Bergmann wrote: > On Mon, Dec 26, 2022, at 13:36, Pali Rohár wrote: > > Linus Walleij suggested me to send these patches to SoC tree [1] > > instead. So I'm doing it. > > > > This patch series contains LED patches which are on the linux-leds > > mailing list for a long time without any future movement. Could you > > please handle them here via SoC tree? Thanks. > > > > [1] - > > https://lore.kernel.org/linux-leds/cacrpkdad6wdo7rgfa4mw8zz0mlxmcpho+sec-ylqnrz_kdr...@mail.gmail.com/ > > I'm going through the backlog of patches sent to s...@kernel.org > and came across this series. While I don't mind taking these > patches through the soc tree in principle, it is important > that this is only done as an exception, and with all the > relevant parties on Cc. > > In particular, the original series that you got no > feedback for did not include the arch/powerpc/ changes, > and I would assume those should go through the powerpc > tree anyway. We have recently decided to take > risc-v and loongarch dts changes through the soc > tree, and I don't mind doing it for powerpc as well > if the powerpc maintainers prefer that, but this is > not something we have even discussed so far. > > I've added everyone to Cc on this mail, but please > resend the series once more so everyone has the patches, > and then we can decide who will pick up what. Thanks Arnd (PSB). > > Marek Behún (3): > > leds: turris-omnia: support HW controlled mode via private trigger > > leds: turris-omnia: initialize multi-intensity to full > > leds: turris-omnia: change max brightness from 255 to 1 > > > > Pali Rohár (5): > > dt-bindings: leds: register-bit-led: Add active-low property > > leds: syscon: Implement support for active-low property > > powerpc/85xx: DTS: Add CPLD definitions for P1021RDB Combo Board CPL > > Design > > dt-bindings: leds: Add cznic,turris1x-leds.yaml binding > > leds: Add support for Turris 1.x LEDs > > > > .../testing/sysfs-class-led-driver-turris1x | 31 ++ > > .../bindings/leds/cznic,turris1x-leds.yaml| 118 + > > .../bindings/leds/register-bit-led.yaml | 5 + > > arch/powerpc/boot/dts/fsl/p1020mbg-pc.dtsi| 92 > > arch/powerpc/boot/dts/fsl/p1020mbg-pc_32b.dts | 6 +- > > arch/powerpc/boot/dts/fsl/p1020mbg-pc_36b.dts | 6 +- > > arch/powerpc/boot/dts/fsl/p1020rdb-pd.dts | 44 +- > > arch/powerpc/boot/dts/fsl/p1020utm-pc.dtsi| 37 ++ > > arch/powerpc/boot/dts/fsl/p1020utm-pc_32b.dts | 4 +- > > arch/powerpc/boot/dts/fsl/p1020utm-pc_36b.dts | 4 +- > > arch/powerpc/boot/dts/fsl/p1021rdb-pc.dtsi| 37 ++ > > arch/powerpc/boot/dts/fsl/p1021rdb-pc_32b.dts | 5 +- > > arch/powerpc/boot/dts/fsl/p1021rdb-pc_36b.dts | 5 +- > > arch/powerpc/boot/dts/fsl/p2020rdb-pc.dtsi| 33 +- > > drivers/leds/Kconfig | 10 + > > drivers/leds/Makefile | 1 + > > drivers/leds/leds-syscon.c | 14 +- > > drivers/leds/leds-turris-1x.c | 474 ++ > > drivers/leds/leds-turris-omnia.c | 46 +- If everyone is convinced that applying these drivers is the correct thing to do, I'd be happy to (rather) take them via LEDs. -- Lee Jones [李琼斯]
Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property
On Mon, 09 Jan 2023, Sam Ravnborg wrote: > Hi Daniel. > > On Mon, Jan 09, 2023 at 11:06:35AM +, Daniel Thompson wrote: > > On Sat, Jan 07, 2023 at 07:26:29PM +0100, Sam Ravnborg via B4 Submission > > Endpoint wrote: > > > From: Sam Ravnborg > > > > > > With all users gone remove the deprecated fb_blank member in > > > backlight_properties. > > > > > > Signed-off-by: Sam Ravnborg > > > Cc: Lee Jones > > > Cc: Daniel Thompson > > > Cc: Jingoo Han > > > > > > Reviewed-by: Daniel Thompson > > Thanks for the follow-up on all the backlight related patches. > > > > > > > PS Please don't treat this like a maintainer Acked-by: and merge it > >(Lee's not on holiday so work with Lee to figure out the merge > >strategy ;-) ). > Nope, I am aware that the usual pattern here and wait for Lee to show > up. It's on the list. Only 50 more reviews in the backlog now! > For this patch there is a bug as I need to update a comment. > I will fix this when I resend after all the patches in flight has > landed. So likely after the next merge window, -- Lee Jones [李琼斯]
Re: [PATCH 000/606] i2c: Complete conversion to i2c_probe_new
| 6 +++--- > drivers/mfd/ti-lmu.c | 5 +++-- > drivers/mfd/tps6105x.c | 5 ++--- > drivers/mfd/tps65010.c | 6 +++--- > drivers/mfd/tps6507x.c | 5 ++--- > drivers/mfd/tps65086.c | 5 ++--- > drivers/mfd/tps65090.c | 5 ++--- > drivers/mfd/tps65218.c | 5 ++--- > drivers/mfd/tps6586x.c | 5 ++--- > drivers/mfd/tps65910.c | 6 +++--- > drivers/mfd/tps65912-i2c.c | 5 ++--- > drivers/mfd/twl-core.c | 5 +++-- > drivers/mfd/twl6040.c| 5 ++--- > drivers/mfd/wl1273-core.c| 5 ++--- > drivers/mfd/wm831x-i2c.c | 6 +++--- > drivers/mfd/wm8350-i2c.c | 5 ++--- > drivers/mfd/wm8400-core.c| 5 ++--- > drivers/mfd/wm8994-core.c| 6 +++--- For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones > drivers/video/backlight/adp8860_bl.c | 6 +++--- > drivers/video/backlight/adp8870_bl.c | 6 +++--- > drivers/video/backlight/arcxcnn_bl.c | 4 ++-- > drivers/video/backlight/bd6107.c | 5 ++--- > drivers/video/backlight/lm3630a_bl.c | 5 ++--- > drivers/video/backlight/lm3639_bl.c | 5 ++--- > drivers/video/backlight/lp855x_bl.c | 5 +++-- > drivers/video/backlight/lv5207lp.c | 5 ++--- > drivers/video/backlight/tosa_bl.c| 5 ++--- > drivers/video/fbdev/matrox/matroxfb_maven.c | 5 ++--- For my own reference (apply this as-is to your sign-off block): Acked-for-Backlight-by: Lee Jones -- Lee Jones [李琼斯]
Re: [PATCH v2 28/45] mfd: rn5t618: Use devm_register_power_handler()
On Thu, 28 Oct 2021, Dmitry Osipenko wrote: > Use devm_register_power_handler() that replaces global pm_power_off > variable and allows to register multiple power-off handlers. It also > provides restart-handler support, i.e. all in one API. > > Signed-off-by: Dmitry Osipenko > --- > drivers/mfd/rn5t618.c | 56 --- > 1 file changed, 21 insertions(+), 35 deletions(-) For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
[PATCH v2 1/3] arch: Export machine_restart() instances so they can be called from modules
A recent attempt to convert the Power Reset Restart driver to tristate
failed because of the following compile error (reported once merged by
Stephen Rothwell via Linux Next):
ERROR: "machine_restart" [drivers/power/reset/restart-poweroff.ko] undefined!
This error occurs since some of the machine_restart() instances are
not currently exported for use in modules. This patch aims to rectify
that.
Cc: Vineet Gupta
Cc: Will Deacon
Cc: Guo Ren
Cc: Yoshinori Sato
Cc: Brian Cain
Cc: Michal Simek
Cc: John Crispin
Cc: Ley Foon Tan
Cc: Jonas Bonn
Cc: Stefan Kristiansson
Cc: Stafford Horne
Cc: James E.J. Bottomley
Cc: Helge Deller
Cc: Michael Ellerman
Cc: Paul Walmsley
Cc: Palmer Dabbelt
Cc: Albert Ou
Cc: Heiko Carstens
Cc: Vasily Gorbik
Cc: Christian Borntraeger
Cc: Rich Felker
Cc: David S. Miller
Cc: Jeff Dike
Cc: Richard Weinberger
Cc: Anton Ivanov
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: Borislav Petkov
Cc: Chris Zankel
Cc: Max Filippov
Cc: linux-snps-...@lists.infradead.org
Cc: linux-ker...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-c...@vger.kernel.org
Cc: uclinux-h8-de...@lists.sourceforge.jp
Cc: linux-hexa...@vger.kernel.org
Cc: linux-m...@lists.linux-m68k.org
Cc: linux-m...@vger.kernel.org
Cc: openr...@lists.librecores.org
Cc: linux-par...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-ri...@lists.infradead.org
Cc: linux-s...@vger.kernel.org
Cc: linux...@vger.kernel.org
Cc: sparcli...@vger.kernel.org
Cc: linux...@lists.infradead.org
Cc: linux-xte...@linux-xtensa.org
Signed-off-by: Lee Jones
Acked-by: Geert Uytterhoeven
Acked-by: Catalin Marinas
Acked-by: Thomas Bogendoerfer
---
arch/arc/kernel/reset.c| 1 +
arch/arm/kernel/reboot.c | 1 +
arch/arm64/kernel/process.c| 1 +
arch/csky/kernel/power.c | 1 +
arch/h8300/kernel/process.c| 1 +
arch/hexagon/kernel/reset.c| 1 +
arch/m68k/kernel/process.c | 1 +
arch/microblaze/kernel/reset.c | 1 +
arch/mips/kernel/reset.c | 1 +
arch/mips/lantiq/falcon/reset.c| 1 +
arch/mips/sgi-ip27/ip27-reset.c| 1 +
arch/nds32/kernel/process.c| 2 +-
arch/nios2/kernel/process.c| 1 +
arch/openrisc/kernel/process.c | 1 +
arch/parisc/kernel/process.c | 1 +
arch/powerpc/kernel/setup-common.c | 1 +
arch/riscv/kernel/reset.c | 1 +
arch/s390/kernel/setup.c | 1 +
arch/sh/kernel/reboot.c| 1 +
arch/sparc/kernel/process_32.c | 1 +
arch/sparc/kernel/reboot.c | 1 +
arch/um/kernel/reboot.c| 1 +
arch/x86/kernel/reboot.c | 1 +
arch/xtensa/kernel/setup.c | 1 +
24 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/arch/arc/kernel/reset.c b/arch/arc/kernel/reset.c
index fd6c3eb930bad..1f5d8ce532e2f 100644
--- a/arch/arc/kernel/reset.c
+++ b/arch/arc/kernel/reset.c
@@ -20,6 +20,7 @@ void machine_restart(char *__unused)
pr_info("Put your restart handler here\n");
machine_halt();
}
+EXPORT_SYMBOL_GPL(machine_restart);
void machine_power_off(void)
{
diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c
index 3044fcb8d0736..95cdcb17251af 100644
--- a/arch/arm/kernel/reboot.c
+++ b/arch/arm/kernel/reboot.c
@@ -146,3 +146,4 @@ void machine_restart(char *cmd)
printk("Reboot failed -- System halted\n");
while (1);
}
+EXPORT_SYMBOL_GPL(machine_restart);
diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index c8989b999250d..d7557f649dbd6 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -148,6 +148,7 @@ void machine_restart(char *cmd)
printk("Reboot failed -- System halted\n");
while (1);
}
+EXPORT_SYMBOL_GPL(machine_restart);
#define bstr(suffix, str) [PSR_BTYPE_ ## suffix >> PSR_BTYPE_SHIFT] = str
static const char *const btypes[] = {
diff --git a/arch/csky/kernel/power.c b/arch/csky/kernel/power.c
index 923ee4e381b81..1787de5b13ba6 100644
--- a/arch/csky/kernel/power.c
+++ b/arch/csky/kernel/power.c
@@ -28,3 +28,4 @@ void machine_restart(char *cmd)
do_kernel_restart(cmd);
asm volatile ("bkpt");
}
+EXPORT_SYMBOL_GPL(machine_restart);
diff --git a/arch/h8300/kernel/process.c b/arch/h8300/kernel/process.c
index 2ac27e4248a46..f92f473a1934a 100644
--- a/arch/h8300/kernel/process.c
+++ b/arch/h8300/kernel/process.c
@@ -66,6 +66,7 @@ void machine_restart(char *__unused)
local_irq_disable();
__asm__("jmp @@0");
}
+EXPORT_SYMBOL_GPL(machine_restart);
void machine_halt(void)
{
diff --git a/arch/hexagon/kernel/reset.c b/arch/hexagon/kernel/reset.c
index da36114d928f0..ed79e0e5a0318 100644
--- a/arch/hexagon/kernel/reset.c
+++ b/arch/hexagon/kernel/reset.c
@@ -19,6 +19,7 @@ void machine_halt(void)
void machine_restart(char *cmd)
{
}
+EXPORT_SYMBOL_GPL(machine_restart);
void (*pm_power_off)(void) = NULL;
EXPO
[PATCH v2 0/3] power: reset: Convert Power-Off driver to tristate
Provide support to compile the Power-Off driver as a module. v1 => v2: - s/EXPORT_SYMBOL/EXPORT_SYMBOL_GPL/ Elliot Berman (2): reboot: Export reboot_mode power: reset: Enable tristate on restart power-off driver Lee Jones (1): arch: Export machine_restart() instances so they can be called from modules arch/arc/kernel/reset.c| 1 + arch/arm/kernel/reboot.c | 1 + arch/arm64/kernel/process.c| 1 + arch/csky/kernel/power.c | 1 + arch/h8300/kernel/process.c| 1 + arch/hexagon/kernel/reset.c| 1 + arch/m68k/kernel/process.c | 1 + arch/microblaze/kernel/reset.c | 1 + arch/mips/kernel/reset.c | 1 + arch/mips/lantiq/falcon/reset.c| 1 + arch/mips/sgi-ip27/ip27-reset.c| 1 + arch/nds32/kernel/process.c| 2 +- arch/nios2/kernel/process.c| 1 + arch/openrisc/kernel/process.c | 1 + arch/parisc/kernel/process.c | 1 + arch/powerpc/kernel/setup-common.c | 1 + arch/riscv/kernel/reset.c | 1 + arch/s390/kernel/setup.c | 1 + arch/sh/kernel/reboot.c| 1 + arch/sparc/kernel/process_32.c | 1 + arch/sparc/kernel/reboot.c | 1 + arch/um/kernel/reboot.c| 1 + arch/x86/kernel/reboot.c | 1 + arch/xtensa/kernel/setup.c | 1 + drivers/power/reset/Kconfig| 2 +- kernel/reboot.c| 2 ++ 26 files changed, 27 insertions(+), 2 deletions(-) Cc: Albert Ou Cc: Anton Ivanov Cc: Borislav Petkov Cc: Brian Cain Cc: Christian Borntraeger Cc: Chris Zankel Cc: David S. Miller Cc: Guo Ren Cc: Heiko Carstens Cc: Helge Deller Cc: Ingo Molnar Cc: James E.J. Bottomley Cc: Jeff Dike Cc: John Crispin Cc: Jonas Bonn Cc: Ley Foon Tan Cc: linux-arm-ker...@lists.infradead.org Cc: linux-c...@vger.kernel.org Cc: linux-hexa...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: linux-m...@lists.linux-m68k.org Cc: linux-m...@vger.kernel.org Cc: linux-par...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ri...@lists.infradead.org Cc: linux-s...@vger.kernel.org Cc: linux...@vger.kernel.org Cc: linux-snps-...@lists.infradead.org Cc: linux...@lists.infradead.org Cc: linux-xte...@linux-xtensa.org Cc: Max Filippov Cc: Michael Ellerman Cc: Michal Simek Cc: openr...@lists.librecores.org Cc: Palmer Dabbelt Cc: Paul Walmsley Cc: Richard Weinberger Cc: Rich Felker Cc: sparcli...@vger.kernel.org Cc: Stafford Horne Cc: Stefan Kristiansson Cc: Thomas Gleixner Cc: uclinux-h8-de...@lists.sourceforge.jp Cc: Vasily Gorbik Cc: Vineet Gupta Cc: Will Deacon Cc: Yoshinori Sato -- 2.33.0.153.gba50c8fa24-goog
Re: [PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules
On Thu, 05 Aug 2021, Greg Kroah-Hartman wrote:
> On Thu, Aug 05, 2021 at 06:36:25PM +0100, Catalin Marinas wrote:
> > On Thu, Aug 05, 2021 at 08:50:30AM +0100, Lee Jones wrote:
> > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
> > > index b4bb67f17a2ca..cf89ce91d7145 100644
> > > --- a/arch/arm64/kernel/process.c
> > > +++ b/arch/arm64/kernel/process.c
> > > @@ -212,6 +212,7 @@ void machine_restart(char *cmd)
> > > printk("Reboot failed -- System halted\n");
> > > while (1);
> > > }
> > > +EXPORT_SYMBOL(machine_restart);
> >
> > Should we make this EXPORT_SYMBOL_GPL? I suppose it's not for general
> > use by out of tree drivers and it matches the other pm_power_off symbol
> > we export in this file.
>
> Yes please.
Sure.
Thanks for the feedback.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
[PATCH 1/3] arch: Export machine_restart() instances so they can be called from modules
A recent attempt to convert the Power Reset Restart driver to tristate
failed because of the following compile error (reported once merged by
Stephen Rothwell via Linux Next):
ERROR: "machine_restart" [drivers/power/reset/restart-poweroff.ko] undefined!
This error occurs since some of the machine_restart() instances are
not currently exported for use in modules. This patch aims to rectify
that.
Cc: Vineet Gupta
Cc: Catalin Marinas
Cc: Will Deacon
Cc: Guo Ren
Cc: Yoshinori Sato
Cc: Brian Cain
Cc: Geert Uytterhoeven
Cc: Michal Simek
Cc: Thomas Bogendoerfer
Cc: John Crispin
Cc: Ley Foon Tan
Cc: Jonas Bonn
Cc: Stefan Kristiansson
Cc: Stafford Horne
Cc: James E.J. Bottomley
Cc: Helge Deller
Cc: Michael Ellerman
Cc: Paul Walmsley
Cc: Palmer Dabbelt
Cc: Albert Ou
Cc: Heiko Carstens
Cc: Vasily Gorbik
Cc: Christian Borntraeger
Cc: Rich Felker
Cc: David S. Miller
Cc: Jeff Dike
Cc: Richard Weinberger
Cc: Anton Ivanov
Cc: Thomas Gleixner
Cc: Ingo Molnar
Cc: Borislav Petkov
Cc: Chris Zankel
Cc: Max Filippov
Cc: Greg Kroah-Hartman
Cc: Sebastian Reichel
Cc: linux-snps-...@lists.infradead.org
Cc: linux-ker...@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-c...@vger.kernel.org
Cc: uclinux-h8-de...@lists.sourceforge.jp
Cc: linux-hexa...@vger.kernel.org
Cc: linux-m...@lists.linux-m68k.org
Cc: linux-m...@vger.kernel.org
Cc: openr...@lists.librecores.org
Cc: linux-par...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-ri...@lists.infradead.org
Cc: linux-s...@vger.kernel.org
Cc: linux...@vger.kernel.org
Cc: sparcli...@vger.kernel.org
Cc: linux...@lists.infradead.org
Cc: linux-xte...@linux-xtensa.org
Signed-off-by: Lee Jones
---
The 2 patches this change supports have the required Acks already.
NB: If it's safe to omit some of these, let me know and I'll revise the patch.
arch/arc/kernel/reset.c| 1 +
arch/arm/kernel/reboot.c | 1 +
arch/arm64/kernel/process.c| 1 +
arch/csky/kernel/power.c | 1 +
arch/h8300/kernel/process.c| 1 +
arch/hexagon/kernel/reset.c| 1 +
arch/m68k/kernel/process.c | 1 +
arch/microblaze/kernel/reset.c | 1 +
arch/mips/kernel/reset.c | 1 +
arch/mips/lantiq/falcon/reset.c| 1 +
arch/mips/sgi-ip27/ip27-reset.c| 1 +
arch/nios2/kernel/process.c| 1 +
arch/openrisc/kernel/process.c | 1 +
arch/parisc/kernel/process.c | 1 +
arch/powerpc/kernel/setup-common.c | 1 +
arch/riscv/kernel/reset.c | 1 +
arch/s390/kernel/setup.c | 1 +
arch/sh/kernel/reboot.c| 1 +
arch/sparc/kernel/process_32.c | 1 +
arch/sparc/kernel/reboot.c | 1 +
arch/um/kernel/reboot.c| 1 +
arch/x86/kernel/reboot.c | 1 +
arch/xtensa/kernel/setup.c | 1 +
23 files changed, 23 insertions(+)
diff --git a/arch/arc/kernel/reset.c b/arch/arc/kernel/reset.c
index fd6c3eb930bad..ae4f8a43b0af4 100644
--- a/arch/arc/kernel/reset.c
+++ b/arch/arc/kernel/reset.c
@@ -20,6 +20,7 @@ void machine_restart(char *__unused)
pr_info("Put your restart handler here\n");
machine_halt();
}
+EXPORT_SYMBOL(machine_restart);
void machine_power_off(void)
{
diff --git a/arch/arm/kernel/reboot.c b/arch/arm/kernel/reboot.c
index 0ce388f154226..2878260efd130 100644
--- a/arch/arm/kernel/reboot.c
+++ b/arch/arm/kernel/reboot.c
@@ -150,3 +150,4 @@ void machine_restart(char *cmd)
printk("Reboot failed -- System halted\n");
while (1);
}
+EXPORT_SYMBOL(machine_restart);
diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
index b4bb67f17a2ca..cf89ce91d7145 100644
--- a/arch/arm64/kernel/process.c
+++ b/arch/arm64/kernel/process.c
@@ -212,6 +212,7 @@ void machine_restart(char *cmd)
printk("Reboot failed -- System halted\n");
while (1);
}
+EXPORT_SYMBOL(machine_restart);
#define bstr(suffix, str) [PSR_BTYPE_ ## suffix >> PSR_BTYPE_SHIFT] = str
static const char *const btypes[] = {
diff --git a/arch/csky/kernel/power.c b/arch/csky/kernel/power.c
index 923ee4e381b81..b466c825cbb3c 100644
--- a/arch/csky/kernel/power.c
+++ b/arch/csky/kernel/power.c
@@ -28,3 +28,4 @@ void machine_restart(char *cmd)
do_kernel_restart(cmd);
asm volatile ("bkpt");
}
+EXPORT_SYMBOL(machine_restart);
diff --git a/arch/h8300/kernel/process.c b/arch/h8300/kernel/process.c
index 46b1342ce515b..8203ac5cd33ec 100644
--- a/arch/h8300/kernel/process.c
+++ b/arch/h8300/kernel/process.c
@@ -66,6 +66,7 @@ void machine_restart(char *__unused)
local_irq_disable();
__asm__("jmp @@0");
}
+EXPORT_SYMBOL(machine_restart);
void machine_halt(void)
{
diff --git a/arch/hexagon/kernel/reset.c b/arch/hexagon/kernel/reset.c
index da36114d928f0..433378d52063c 100644
--- a/arch/hexagon/kernel/reset.c
+++ b/arch/hexagon/kernel/reset.c
@@ -19,6 +19,7 @@ void machine_halt(void)
void machine
[PATCH 0/3] power: reset: Convert Power-Off driver to tristate
Provide support to compile the Power-Off driver as a module. Elliot Berman (2): reboot: Export reboot_mode power: reset: Enable tristate on restart power-off driver Lee Jones (1): arch: Export machine_restart() instances so they can be called from modules arch/arc/kernel/reset.c| 1 + arch/arm/kernel/reboot.c | 1 + arch/arm64/kernel/process.c| 1 + arch/csky/kernel/power.c | 1 + arch/h8300/kernel/process.c| 1 + arch/hexagon/kernel/reset.c| 1 + arch/m68k/kernel/process.c | 1 + arch/microblaze/kernel/reset.c | 1 + arch/mips/kernel/reset.c | 1 + arch/mips/lantiq/falcon/reset.c| 1 + arch/mips/sgi-ip27/ip27-reset.c| 1 + arch/nios2/kernel/process.c| 1 + arch/openrisc/kernel/process.c | 1 + arch/parisc/kernel/process.c | 1 + arch/powerpc/kernel/setup-common.c | 1 + arch/riscv/kernel/reset.c | 1 + arch/s390/kernel/setup.c | 1 + arch/sh/kernel/reboot.c| 1 + arch/sparc/kernel/process_32.c | 1 + arch/sparc/kernel/reboot.c | 1 + arch/um/kernel/reboot.c| 1 + arch/x86/kernel/reboot.c | 1 + arch/xtensa/kernel/setup.c | 1 + drivers/power/reset/Kconfig| 2 +- kernel/reboot.c| 2 ++ 25 files changed, 26 insertions(+), 1 deletion(-) Cc: Albert Ou Cc: Anton Ivanov Cc: Borislav Petkov Cc: Brian Cain Cc: Catalin Marinas Cc: Christian Borntraeger Cc: Chris Zankel Cc: David S. Miller Cc: Geert Uytterhoeven Cc: Guo Ren Cc: Heiko Carstens Cc: Helge Deller Cc: Ingo Molnar Cc: James E.J. Bottomley Cc: Jeff Dike Cc: John Crispin Cc: Jonas Bonn Cc: Ley Foon Tan Cc: linux-arm-ker...@lists.infradead.org Cc: linux-c...@vger.kernel.org Cc: linux-hexa...@vger.kernel.org Cc: linux-ker...@vger.kernel.org Cc: linux-m...@lists.linux-m68k.org Cc: linux-m...@vger.kernel.org Cc: linux-par...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ri...@lists.infradead.org Cc: linux-s...@vger.kernel.org Cc: linux...@vger.kernel.org Cc: linux-snps-...@lists.infradead.org Cc: linux...@lists.infradead.org Cc: linux-xte...@linux-xtensa.org Cc: Max Filippov Cc: Michael Ellerman Cc: Michal Simek Cc: openr...@lists.librecores.org Cc: Palmer Dabbelt Cc: Paul Walmsley Cc: Richard Weinberger Cc: Rich Felker Cc: sparcli...@vger.kernel.org Cc: Stafford Horne Cc: Stefan Kristiansson Cc: Thomas Bogendoerfer Cc: Thomas Gleixner Cc: uclinux-h8-de...@lists.sourceforge.jp Cc: Vasily Gorbik Cc: Vineet Gupta Cc: Will Deacon Cc: Yoshinori Sato -- 2.32.0.605.g8dce9f2422-goog
Re: [PATCH] bus: Make remove callback return void
On Tue, 06 Jul 2021, Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > > Signed-off-by: Uwe Kleine-König > --- > Hello, > > this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove > return void" that is not yet applied, see > https://lore.kernel.org/r/20210223090757.57604-1-u.kleine-koe...@pengutronix.de. > > I tested it using allmodconfig on amd64 and arm, but I wouldn't be > surprised if I still missed to convert a driver. So it would be great to > get this into next early after the merge window closes. > > I send this mail to all people that get_maintainer.pl emits for this > patch. I wonder how many recipents will refuse this mail because of the > long Cc: list :-) > > Best regards > Uwe > > arch/arm/common/locomo.c | 3 +-- > arch/arm/common/sa.c | 4 +--- > arch/arm/mach-rpc/ecard.c | 4 +--- > arch/mips/sgi-ip22/ip22-gio.c | 3 +-- > arch/parisc/kernel/drivers.c | 5 ++--- > arch/powerpc/platforms/ps3/system-bus.c | 3 +-- > arch/powerpc/platforms/pseries/ibmebus.c | 3 +-- > arch/powerpc/platforms/pseries/vio.c | 3 +-- > drivers/acpi/bus.c| 3 +-- > drivers/amba/bus.c| 4 +--- > drivers/base/auxiliary.c | 4 +--- > drivers/base/isa.c| 4 +--- > drivers/base/platform.c | 4 +--- > drivers/bcma/main.c | 6 ++ > drivers/bus/sunxi-rsb.c | 4 +--- > drivers/cxl/core.c| 3 +-- > drivers/dax/bus.c | 4 +--- > drivers/dma/idxd/sysfs.c | 4 +--- > drivers/firewire/core-device.c| 4 +--- > drivers/firmware/arm_scmi/bus.c | 4 +--- > drivers/firmware/google/coreboot_table.c | 4 +--- > drivers/fpga/dfl.c| 4 +--- > drivers/hid/hid-core.c| 4 +--- > drivers/hid/intel-ish-hid/ishtp/bus.c | 4 +--- > drivers/hv/vmbus_drv.c| 5 + > drivers/hwtracing/intel_th/core.c | 4 +--- > drivers/i2c/i2c-core-base.c | 5 + > drivers/i3c/master.c | 4 +--- > drivers/input/gameport/gameport.c | 3 +-- > drivers/input/serio/serio.c | 3 +-- > drivers/ipack/ipack.c | 4 +--- > drivers/macintosh/macio_asic.c| 4 +--- > drivers/mcb/mcb-core.c | 4 +--- > drivers/media/pci/bt8xx/bttv-gpio.c | 3 +-- > drivers/memstick/core/memstick.c | 3 +-- > drivers/mfd/mcp-core.c| 3 +-- Acked-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 00/21] Rid W=1 warnings from IDE
On Mon, 07 Jun 2021, Christoph Hellwig wrote: > Please don't touch this code as it is about to be removed entirely. Do you have an ETA for this work? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
[PATCH 21/21] ide: pmac: Staticise local function 'pmac_ide_probe'
Fixes the following W=1 kernel build warning(s):
drivers/ide/pmac.c:1418:12: warning: no previous prototype for
‘pmac_ide_probe’ [-Wmissing-prototypes]
Cc: "David S. Miller"
Cc: Michael Ellerman
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linux-...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
drivers/ide/pmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c
index ea0b064b5f56b..d51a2e252b6f2 100644
--- a/drivers/ide/pmac.c
+++ b/drivers/ide/pmac.c
@@ -1415,7 +1415,7 @@ static struct pci_driver pmac_ide_pci_driver = {
};
MODULE_DEVICE_TABLE(pci, pmac_ide_pci_match);
-int __init pmac_ide_probe(void)
+static int __init pmac_ide_probe(void)
{
int error;
--
2.31.1
[PATCH 00/21] Rid W=1 warnings from IDE
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (21):
ide: alim15x3: Document alim15x3_init_one()'s 'id' param
ide: ide-dma: Document ide_dma_unmap_sg()'s missing 'cmd' param
ide: ide-dma-sff: Provide some missing 'param' descriptions
ide: ide-io: Fix a few kernel-doc misdemeanours
ide: ide-proc: Strip out unused fops structure and accompanying
call-back
ide: cs5530: Fix incorrect documentation for function
init_chipset_cs5530()
ide: ide-probe: Fix-up incorrectly documented function
probe_for_drive()
ide: hpt366: Provide some missing descriptions for 'f_{low,high}'
ide: piix: Remove unused variable 'sitre'
ide: pdc202xx_new: Supply missing description for 'set_indexed_reg()'s
'value' param
ide: slc90e66: Remove unused variable 'sitre'
ide: it821x: Fix a couple of incorrectly documented functions
ide: siimage: Fix some incorrectly documented functions/params
ide: via82cxxx: Fix misdocumentation of via_set_speed()'s 'hwif' param
ide: ide-cd_ioctl: Remove unused variable 'stat'
ide: ide-cd: Demote kernel-doc abuse
ide: ide-acpi: Mark debugging variable 'bus' as __maybe_unused
ide: ide-io: Document ide_intr()'s param 'irq'
ide: piix: Fix incorrectly documented param 'hwif'
ide: ide-acpi: Provide missing description for param 'obj_loc'
ide: pmac: Staticise local function 'pmac_ide_probe'
drivers/ide/alim15x3.c | 1 +
drivers/ide/cs5530.c | 2 +-
drivers/ide/hpt366.c | 2 ++
drivers/ide/ide-acpi.c | 4 +++-
drivers/ide/ide-cd.c | 2 +-
drivers/ide/ide-cd_ioctl.c | 3 +--
drivers/ide/ide-dma-sff.c | 4
drivers/ide/ide-dma.c | 1 +
drivers/ide/ide-io.c | 9 +
drivers/ide/ide-probe.c| 2 +-
drivers/ide/ide-proc.c | 13 -
drivers/ide/it821x.c | 4 ++--
drivers/ide/pdc202xx_new.c | 1 +
drivers/ide/piix.c | 4 +---
drivers/ide/pmac.c | 2 +-
drivers/ide/siimage.c | 4 ++--
drivers/ide/slc90e66.c | 3 +--
drivers/ide/via82cxxx.c| 2 +-
18 files changed, 29 insertions(+), 34 deletions(-)
Cc: Adrian Sun
Cc: Alan Cox
Cc: Andre Hedrick
Cc: Benjamin Herrenschmidt
Cc: Benoit Poulot-Cazajous
Cc: Christian Brunner
Cc: "Christopher J. Reimer"
Cc: CJ
Cc: Clear Zhang
Cc: "David S. Miller"
Cc: Duncan Laurie
Cc: Erik Andersen
Cc: Frank Tiernan
Cc: Gadi Oxman
Cc: Jens Axboe
Cc: linux-...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Mark Lord
Cc: Michael Ellerman
Cc: Mike Waychison
Cc: or
Cc: Paul Mackerras
Cc: Robert Bringman
Cc: Scott Snyder
Cc: Sergei Shtylyov
Cc: "Software, Inc"
Cc: support to
Cc: Tim Hockin
--
2.31.1
Re: [PATCH 00/16] Rid W=1 warnings from Char
On Fri, 21 May 2021, Greg Kroah-Hartman wrote: > On Fri, May 21, 2021 at 09:42:29AM +0200, Greg Kroah-Hartman wrote: > > On Fri, May 21, 2021 at 08:22:36AM +0100, Lee Jones wrote: > > > On Thu, 20 May 2021, Arnd Bergmann wrote: > > > > > > > On Thu, May 20, 2021 at 2:13 PM Lee Jones wrote: > > > > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > > kernel builds, which are currently overwhelmingly riddled with > > > > > niggly little warnings. > > > > > > > > > > Lee Jones (16): > > > > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > > > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > > > > char: random: Include header containing our prototypes > > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > > > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > > > > 'byte_reset_it' > > > > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > > > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > > > > char: agp: backend: Demote some non-conformant kernel-doc headers > > > > > char: agp: frontend: Include header file containing our prototypes > > > > > char: agp: via-agp: Remove unused variable 'current_size' > > > > > char: hpet: Remove unused variable 'm' > > > > > char: agp: generic: Place braces around optimised out function in > > > > > if() > > > > > char: agp: uninorth-agp: Remove unused variable 'size' > > > > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc > > > > > header > > > > > char: mem: Provide local prototype for non-static function > > > > > > > > Thanks a lot! > > > > > > > > I've looked all the patches now and commented on patches 6 and 16. > > > > With my comments addressed > > > > > > > > Reviewed-by: Arnd Bergmann > > > > > > Thanks Arnd. > > > > > > Would it be possible for the remaining 14 patches to be taken in > > > please? I will work on the 2 Arnd commented on in due course and > > > resubmit them independently. > > > > Yes, I can queue them up, thanks. > > Wait, I can take the ones for code that I maintain, not for others. > drivers/char/ is "fun" in that some subdirs have active > trees/maintainers that are not me and Arnd so they go to Linus through > other ways. I'll queue up the ones that I am "allowed" to and you will > get the emails from that. Understood, thanks. Hopefully the other maintainers will be as on the ball as you are. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 00/16] Rid W=1 warnings from Char
On Thu, 20 May 2021, Arnd Bergmann wrote: > On Thu, May 20, 2021 at 2:13 PM Lee Jones wrote: > > > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > Lee Jones (16): > > char: pcmcia: cm4000_cs: Remove unused variable 'tmp' > > char: pcmcia: cm4040_cs: Remove unused variable 'uc' > > char: random: Include header containing our prototypes > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues > > char: applicom: Remove 3 unused variables 'ret' and 2 instances of > > 'byte_reset_it' > > char: tpm: tpm1-cmd: Fix a couple of misnamed functions > > char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours > > char: agp: backend: Demote some non-conformant kernel-doc headers > > char: agp: frontend: Include header file containing our prototypes > > char: agp: via-agp: Remove unused variable 'current_size' > > char: hpet: Remove unused variable 'm' > > char: agp: generic: Place braces around optimised out function in if() > > char: agp: uninorth-agp: Remove unused variable 'size' > > char: hw_random: pseries-rng: Demote non-conformant kernel-doc header > > char: mem: Provide local prototype for non-static function > > Thanks a lot! > > I've looked all the patches now and commented on patches 6 and 16. > With my comments addressed > > Reviewed-by: Arnd Bergmann Thanks Arnd. Would it be possible for the remaining 14 patches to be taken in please? I will work on the 2 Arnd commented on in due course and resubmit them independently. TIA. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
[PATCH 15/16] char: hw_random: pseries-rng: Demote non-conformant kernel-doc header
Fixes the following W=1 kernel build warning(s): drivers/char/hw_random/pseries-rng.c:42: warning: Function parameter or member 'vdev' not described in 'pseries_rng_get_desired_dma' Cc: Matt Mackall Cc: Herbert Xu Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Lijun Pan Cc: "Uwe Kleine-König" Cc: Tyrel Datwyler Cc: Greg Kroah-Hartman Cc: Michael Neuling Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/char/hw_random/pseries-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/hw_random/pseries-rng.c b/drivers/char/hw_random/pseries-rng.c index f4949b689bd5a..62bdd5af1339f 100644 --- a/drivers/char/hw_random/pseries-rng.c +++ b/drivers/char/hw_random/pseries-rng.c @@ -29,7 +29,7 @@ static int pseries_rng_read(struct hwrng *rng, void *data, size_t max, bool wait return 8; } -/** +/* * pseries_rng_get_desired_dma - Return desired DMA allocate for CMO operations * * This is a required function for a driver to operate in a CMO environment -- 2.31.1
[PATCH 00/16] Rid W=1 warnings from Char
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (16): char: pcmcia: cm4000_cs: Remove unused variable 'tmp' char: pcmcia: cm4040_cs: Remove unused variable 'uc' char: random: Include header containing our prototypes char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues char: applicom: Remove 3 unused variables 'ret' and 2 instances of 'byte_reset_it' char: tpm: tpm1-cmd: Fix a couple of misnamed functions char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours char: agp: backend: Demote some non-conformant kernel-doc headers char: agp: frontend: Include header file containing our prototypes char: agp: via-agp: Remove unused variable 'current_size' char: hpet: Remove unused variable 'm' char: agp: generic: Place braces around optimised out function in if() char: agp: uninorth-agp: Remove unused variable 'size' char: hw_random: pseries-rng: Demote non-conformant kernel-doc header char: mem: Provide local prototype for non-static function drivers/char/agp/backend.c | 4 +- drivers/char/agp/frontend.c | 1 + drivers/char/agp/generic.c | 3 +- drivers/char/agp/uninorth-agp.c | 3 -- drivers/char/agp/via-agp.c | 3 -- drivers/char/applicom.c | 10 ++-- drivers/char/hpet.c | 4 +- drivers/char/hw_random/pseries-rng.c | 2 +- drivers/char/mem.c | 2 + drivers/char/pcmcia/cm4000_cs.c | 3 +- drivers/char/pcmcia/cm4040_cs.c | 3 +- drivers/char/pcmcia/synclink_cs.c| 74 +++- drivers/char/random.c| 1 + drivers/char/tpm/tpm1-cmd.c | 4 +- drivers/char/tpm/tpm_ftpm_tee.c | 6 +-- 15 files changed, 60 insertions(+), 63 deletions(-) Cc: Arnd Bergmann Cc: Benjamin Herrenschmidt Cc: Bob Picco Cc: Clemens Ladisch Cc: "C. Scott Ananian" Cc: "cs.c" Cc: Dave Safford Cc: David Airlie Cc: dw...@infradead.org Cc: Greg Kroah-Hartman Cc: Harald Welte Cc: Herbert Xu Cc: Jarkko Sakkinen Cc: "Jason A. Donenfeld" Cc: Jason Gunthorpe Cc: Jerome Glisse Cc: Kanoj Sarcar Cc: Kylene Hall Cc: Lee Jones Cc: Lijun Pan Cc: linux-cry...@vger.kernel.org Cc: linux-integr...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Matt Mackall Cc: Michael Ellerman Cc: Michael Neuling Cc: pau...@microgate.com Cc: Paul Mackerras Cc: Peter Huewe Cc: Reiner Sailer Cc: "Theodore Ts'o" Cc: Thirupathaiah Annapureddy Cc: Tyrel Datwyler Cc: "Uwe Kleine-König" Cc: van Doorn -- 2.31.1
[PATCH 2/3] crypto: nx: nx-aes-gcm: Kernel-doc formatting should not be used for headers
Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx-aes-gcm.c:26: warning: Function parameter or member 'tfm' not described in 'gcm_aes_nx_set_key' drivers/crypto/nx/nx-aes-gcm.c:26: warning: Function parameter or member 'in_key' not described in 'gcm_aes_nx_set_key' drivers/crypto/nx/nx-aes-gcm.c:26: warning: Function parameter or member 'key_len' not described in 'gcm_aes_nx_set_key' drivers/crypto/nx/nx-aes-gcm.c:26: warning: expecting prototype for Nest Accelerators driver(). Prototype was for gcm_aes_nx_set_key() instead drivers/crypto/nx/nx-aes-ecb.c:24: warning: Function parameter or member 'tfm' not described in 'ecb_aes_nx_set_key' drivers/crypto/nx/nx-aes-ecb.c:24: warning: Function parameter or member 'in_key' not described in 'ecb_aes_nx_set_key' drivers/crypto/nx/nx-aes-ecb.c:24: warning: Function parameter or member 'key_len' not described in 'ecb_aes_nx_set_key' drivers/crypto/nx/nx-aes-ecb.c:24: warning: expecting prototype for Nest Accelerators driver(). Prototype was for ecb_aes_nx_set_key() instead drivers/crypto/nx/nx-aes-ccm.c:26: warning: Function parameter or member 'tfm' not described in 'ccm_aes_nx_set_key' drivers/crypto/nx/nx-aes-ccm.c:26: warning: Function parameter or member 'in_key' not described in 'ccm_aes_nx_set_key' drivers/crypto/nx/nx-aes-ccm.c:26: warning: Function parameter or member 'key_len' not described in 'ccm_aes_nx_set_key' drivers/crypto/nx/nx-aes-ccm.c:26: warning: expecting prototype for Nest Accelerators driver(). Prototype was for ccm_aes_nx_set_key() instead drivers/crypto/nx/nx-aes-ctr.c:25: warning: Function parameter or member 'tfm' not described in 'ctr_aes_nx_set_key' drivers/crypto/nx/nx-aes-ctr.c:25: warning: Function parameter or member 'in_key' not described in 'ctr_aes_nx_set_key' drivers/crypto/nx/nx-aes-ctr.c:25: warning: Function parameter or member 'key_len' not described in 'ctr_aes_nx_set_key' drivers/crypto/nx/nx-aes-ctr.c:25: warning: expecting prototype for Nest Accelerators driver(). Prototype was for ctr_aes_nx_set_key() instead drivers/crypto/nx/nx-aes-xcbc.c:22: warning: cannot understand function prototype: 'struct xcbc_state ' drivers/crypto/nx/nx-sha256.c:21: warning: Function parameter or member 'tfm' not described in 'nx_crypto_ctx_sha256_init' drivers/crypto/nx/nx-sha256.c:21: warning: expecting prototype for SHA(). Prototype was for nx_crypto_ctx_sha256_init() instead drivers/crypto/nx/nx-sha512.c:20: warning: Function parameter or member 'tfm' not described in 'nx_crypto_ctx_sha512_init' drivers/crypto/nx/nx-sha512.c:20: warning: expecting prototype for SHA(). Prototype was for nx_crypto_ctx_sha512_init() instead drivers/crypto/nx/nx-842-pseries.c:280: warning: Function parameter or member 'wmem' not described in 'nx842_pseries_compress' drivers/crypto/nx/nx-842-pseries.c:280: warning: Excess function parameter 'wrkmem' description in 'nx842_pseries_compress' drivers/crypto/nx/nx-842-pseries.c:410: warning: Function parameter or member 'wmem' not described in 'nx842_pseries_decompress' drivers/crypto/nx/nx-842-pseries.c:410: warning: Excess function parameter 'wrkmem' description in 'nx842_pseries_decompress' drivers/crypto/nx/nx-842-pseries.c:523: warning: Function parameter or member 'devdata' not described in 'nx842_OF_set_defaults' drivers/crypto/nx/nx-842-pseries.c:548: warning: Function parameter or member 'prop' not described in 'nx842_OF_upd_status' drivers/crypto/nx/nx-842-pseries.c:582: warning: Function parameter or member 'devdata' not described in 'nx842_OF_upd_maxsglen' drivers/crypto/nx/nx-842-pseries.c:582: warning: Function parameter or member 'prop' not described in 'nx842_OF_upd_maxsglen' drivers/crypto/nx/nx-842-pseries.c:630: warning: Function parameter or member 'devdata' not described in 'nx842_OF_upd_maxsyncop' drivers/crypto/nx/nx-842-pseries.c:630: warning: Function parameter or member 'prop' not described in 'nx842_OF_upd_maxsyncop' drivers/crypto/nx/nx-842-pseries.c:692: warning: Cannot understand * drivers/crypto/nx/nx-842-pseries.c:825: warning: Function parameter or member 'data' not described in 'nx842_OF_notifier' drivers/crypto/nx/nx-842-pseries.c:825: warning: Excess function parameter 'update' description in 'nx842_OF_notifier' Cc: Haren Myneni Cc: Herbert Xu Cc: "David S. Miller" Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Robert Jennings Cc: Seth Jennings Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx-842-pseries.c | 24 +++- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/drivers/crypto/nx/nx-842-pseries.c b/drivers/crypto/nx/nx-842-pseries.c index 8ee547ee378ec..67caff73f058f 100644 --- a/drivers/crypto/nx/nx-842-pseries.c +++ b/drivers/crypto/nx/nx-842-pseries.c @@ -264,8 +264,8 @@ static int nx842_validate_result(struct device *dev, * @inl
[PATCH 0/3] Rid W=1 warnings from Crypto
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (3): crypto: cavium: Fix a bunch of kernel-doc related issues crypto: nx: nx-aes-gcm: Kernel-doc formatting should not be used for headers crypto: ccp: ccp-dev: Fix a little doc-rot drivers/crypto/cavium/cpt/cptpf_main.c| 2 +- drivers/crypto/cavium/cpt/cptvf_reqmanager.c | 4 ++-- drivers/crypto/cavium/nitrox/nitrox_main.c| 4 ++-- drivers/crypto/cavium/nitrox/nitrox_mbx.c | 4 ++-- drivers/crypto/cavium/nitrox/nitrox_reqmgr.c | 12 ++ .../crypto/cavium/nitrox/nitrox_skcipher.c| 2 +- drivers/crypto/ccp/ccp-dev.c | 2 +- drivers/crypto/nx/nx-842-pseries.c| 24 +-- 8 files changed, 27 insertions(+), 27 deletions(-) Cc: Benjamin Herrenschmidt Cc: "David S. Miller" Cc: Gary R Hook Cc: George Cherian Cc: Haren Myneni Cc: Herbert Xu Cc: John Allen Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Michael Ellerman Cc: Paul Mackerras Cc: Robert Jennings Cc: Seth Jennings Cc: Tom Lendacky -- 2.31.1
Re: [RESEND 1/1] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location
On Wed, 03 Mar 2021, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for > ‘hvc_vio_init_early’ [-Wmissing-prototypes] > 385 | void __init hvc_vio_init_early(void) > | ^~ > > Cc: Michael Ellerman > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Lee Jones > Acked-by: Michael Ellerman > --- > arch/powerpc/include/asm/hvconsole.h | 3 +++ > arch/powerpc/platforms/pseries/pseries.h | 3 --- > arch/powerpc/platforms/pseries/setup.c | 1 + > 3 files changed, 4 insertions(+), 3 deletions(-) Any idea who might pick this up please? It's been on the list for months. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 00/36] [Set 4] Rid W=1 warnings in SCSI
On Thu, 18 Mar 2021, Martin K. Petersen wrote: > > Lee, > > > This set is part of a larger effort attempting to clean-up W=1 kernel > > builds, which are currently overwhelmingly riddled with niggly little > > warnings. > > Applied to 5.13/scsi-staging, thanks! I fixed a few little things. Thanks for your continued support Martin. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
[PATCH v3 00/10] Rid W=1 warnings in Crypto
This is set 1 of 2 sets required to fully clean Crypto. v2: No functional changes since v1. v3: Description change and additional struct header fix Lee Jones (10): crypto: hisilicon: sec_drv: Supply missing description for 'sec_queue_empty()'s 'queue' param crypto: bcm: Fix a whole host of kernel-doc misdemeanours crypto: chelsio: chcr_core: Fix some kernel-doc issues crypto: ux500: hash: hash_core: Fix worthy kernel-doc headers and remove others crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs crypto: atmel-ecc: Struct headers need to start with keyword 'struct' crypto: caam: caampkc: Provide the name of the function and provide missing descriptions crypto: vmx: Source headers are not good kernel-doc candidates crypto: nx: nx-aes-cbc: Repair some kernel-doc problems crypto: cavium: nitrox_isr: Demote non-compliant kernel-doc headers drivers/crypto/atmel-ecc.c| 2 +- drivers/crypto/bcm/cipher.c | 7 ++-- drivers/crypto/bcm/spu.c | 16 - drivers/crypto/bcm/spu2.c | 43 +-- drivers/crypto/bcm/util.c | 4 +-- drivers/crypto/caam/caamalg_qi2.c | 3 ++ drivers/crypto/caam/caampkc.c | 3 +- drivers/crypto/cavium/nitrox/nitrox_isr.c | 4 +-- drivers/crypto/chelsio/chcr_algo.c| 8 ++--- drivers/crypto/chelsio/chcr_core.c| 2 +- drivers/crypto/hisilicon/sec/sec_drv.c| 1 + drivers/crypto/keembay/ocs-hcu.c | 8 ++--- drivers/crypto/nx/nx-aes-cbc.c| 2 +- drivers/crypto/nx/nx.c| 5 +-- drivers/crypto/nx/nx_debugfs.c| 2 +- drivers/crypto/ux500/cryp/cryp.c | 5 +-- drivers/crypto/ux500/cryp/cryp_core.c | 5 +-- drivers/crypto/ux500/cryp/cryp_irq.c | 2 +- drivers/crypto/ux500/hash/hash_core.c | 15 +++- drivers/crypto/vmx/vmx.c | 2 +- 20 files changed, 73 insertions(+), 66 deletions(-) Cc: Alexandre Belloni Cc: Andreas Westin Cc: Atul Gupta Cc: Aymen Sghaier Cc: Ayush Sawal Cc: Benjamin Herrenschmidt Cc: Berne Hebark Cc: "Breno Leitão" Cc: Daniele Alessandrelli Cc: "David S. Miller" Cc: Declan Murphy Cc: Harsh Jain Cc: Henrique Cerri Cc: Herbert Xu Cc: "Horia Geantă" Cc: Jitendra Lulla Cc: Joakim Bech Cc: Jonas Linde Cc: Jonathan Cameron Cc: Kent Yoder Cc: linux-arm-ker...@lists.infradead.org Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Ludovic Desroches Cc: Manoj Malviya Cc: Michael Ellerman Cc: M R Gowda Cc: Nayna Jain Cc: Nicolas Ferre Cc: Niklas Hernaeus Cc: Paul Mackerras Cc: Paulo Flabiano Smorigo Cc: Rob Rice Cc: Rohit Maheshwari Cc: Shujuan Chen Cc: Tudor Ambarus Cc: Vinay Kumar Yadav Cc: Zaibo Xu -- 2.27.0
[PATCH 09/10] crypto: nx: nx-aes-cbc: Repair some kernel-doc problems
Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'tfm' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'in_key' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'key_len' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: expecting prototype for Nest Accelerators driver(). Prototype was for cbc_aes_nx_set_key() instead drivers/crypto/nx/nx_debugfs.c:34: warning: Function parameter or member 'drv' not described in 'nx_debugfs_init' drivers/crypto/nx/nx_debugfs.c:34: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_debugfs_init() instead drivers/crypto/nx/nx.c:31: warning: Incorrect use of kernel-doc format: * nx_hcall_sync - make an H_COP_OP hcall for the passed in op structure drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'nx_ctx' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'op' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'may_sleep' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_hcall_sync() instead drivers/crypto/nx/nx.c:209: warning: Function parameter or member 'nbytes' not described in 'trim_sg_list' Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx-aes-cbc.c | 2 +- drivers/crypto/nx/nx.c | 5 +++-- drivers/crypto/nx/nx_debugfs.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/nx/nx-aes-cbc.c b/drivers/crypto/nx/nx-aes-cbc.c index 92e921eceed75..d6314ea9ae896 100644 --- a/drivers/crypto/nx/nx-aes-cbc.c +++ b/drivers/crypto/nx/nx-aes-cbc.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * AES CBC routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. diff --git a/drivers/crypto/nx/nx.c b/drivers/crypto/nx/nx.c index 1d0e8a1ba1605..010e87d9da36b 100644 --- a/drivers/crypto/nx/nx.c +++ b/drivers/crypto/nx/nx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. @@ -200,7 +200,8 @@ struct nx_sg *nx_walk_and_build(struct nx_sg *nx_dst, * @sg: sg list head * @end: sg lisg end * @delta: is the amount we need to crop in order to bound the list. - * + * @nbytes: length of data in the scatterlists or data length - whichever + * is greater. */ static long int trim_sg_list(struct nx_sg *sg, struct nx_sg *end, diff --git a/drivers/crypto/nx/nx_debugfs.c b/drivers/crypto/nx/nx_debugfs.c index 1975bcbee9974..ee7cd88bb10a7 100644 --- a/drivers/crypto/nx/nx_debugfs.c +++ b/drivers/crypto/nx/nx_debugfs.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * debugfs routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. -- 2.27.0
[PATCH 08/10] crypto: vmx: Source headers are not good kernel-doc candidates
Fixes the following W=1 kernel build warning(s): drivers/crypto/vmx/vmx.c:23: warning: expecting prototype for Routines supporting VMX instructions on the Power 8(). Prototype was for p8_init() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Henrique Cerri Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/vmx/vmx.c b/drivers/crypto/vmx/vmx.c index a40d08e75fc0b..7eb713cc87c8c 100644 --- a/drivers/crypto/vmx/vmx.c +++ b/drivers/crypto/vmx/vmx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Routines supporting VMX instructions on the Power 8 * * Copyright (C) 2015 International Business Machines Inc. -- 2.27.0
[PATCH 00/36] [Set 4] Rid W=1 warnings in SCSI
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (36): scsi: myrb: Demote non-conformant kernel-doc headers and fix others scsi: ipr: Fix incorrect function names in their headers scsi: mvumi: Fix formatting and doc-rot issues scsi: sd_zbc: Place function name into header scsi: pmcraid: Fix a whole host of kernel-doc issues scsi: sd: Fix function name in header scsi: aic94xx: aic94xx_dump: Correct misspelling of function asd_dump_seq_state() scsi: be2iscsi: be_main: Ensure function follows directly after its header scsi: dc395x: Fix some function param descriptions scsi: initio: Fix a few kernel-doc misdemeanours scsi: a100u2w: Fix some misnaming and formatting issues scsi: myrs: Add missing ':' to make the kernel-doc checker happy scsi: pmcraid: Correct function name pmcraid_show_adapter_id() in header scsi: mpt3sas: mpt3sas_scs: Fix a few kernel-doc issues scsi: be2iscsi: be_main: Demote incomplete/non-conformant kernel-doc header scsi: isci: phy: Fix a few different kernel-doc related issues scsi: fnic: fnic_scsi: Demote non-conformant kernel-doc headers scsi: fnic: fnic_fcs: Kernel-doc headers must contain the function name scsi: isci: phy: Provide function name and demote non-conforming header scsi: isci: request: Fix a myriad of kernel-doc issues scsi: isci: host: Fix bunch of kernel-doc related issues scsi: isci: task: Demote non-conformant header and remove superfluous param scsi: isci: remote_node_table: Fix a bunch of kernel-doc misdemeanours scsi: isci: remote_node_context: Fix one function header and demote a couple more scsi: isci: port_config: Fix a bunch of doc-rot and demote abuses scsi: isci: remote_device: Fix a bunch of doc-rot issues scsi: isci: request: Fix doc-rot issue relating to 'ireq' param scsi: isci: port: Fix a bunch of kernel-doc issues scsi: isci: remote_node_context: Demote kernel-doc abuse scsi: isci: remote_node_table: Provide some missing params and remove others scsi: cxlflash: main: Fix a little do-rot scsi: cxlflash: superpipe: Fix a few misnaming issues scsi: ibmvscsi: Fix a bunch of kernel-doc related issues scsi: ibmvscsi: ibmvfc: Fix a bunch of misdocumentation scsi: ibmvscsi_tgt: ibmvscsi_tgt: Remove duplicate section 'NOTE' scsi: cxlflash: vlun: Fix some misnaming related doc-rot drivers/scsi/a100u2w.c | 8 +-- drivers/scsi/aic94xx/aic94xx_dump.c | 2 +- drivers/scsi/be2iscsi/be_main.c | 5 +- drivers/scsi/cxlflash/main.c | 8 +-- drivers/scsi/cxlflash/superpipe.c| 6 +- drivers/scsi/cxlflash/vlun.c | 8 +-- drivers/scsi/dc395x.c| 3 +- drivers/scsi/fnic/fnic_fcs.c | 2 +- drivers/scsi/fnic/fnic_scsi.c| 6 +- drivers/scsi/ibmvscsi/ibmvfc.c | 29 ++ drivers/scsi/ibmvscsi/ibmvscsi.c | 70 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 8 +-- drivers/scsi/initio.c| 13 ++--- drivers/scsi/ipr.c | 8 +-- drivers/scsi/isci/host.c | 37 ++--- drivers/scsi/isci/phy.c | 34 ++-- drivers/scsi/isci/port.c | 58 ++-- drivers/scsi/isci/port_config.c | 37 +++-- drivers/scsi/isci/remote_device.c| 31 ++- drivers/scsi/isci/remote_node_context.c | 13 + drivers/scsi/isci/remote_node_table.c| 64 +++--- drivers/scsi/isci/request.c | 60 ++-- drivers/scsi/isci/task.c | 3 +- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 18 +++--- drivers/scsi/mvumi.c | 5 +- drivers/scsi/myrb.c | 47 drivers/scsi/myrs.c | 6 +- drivers/scsi/pmcraid.c | 70 drivers/scsi/sd.c| 2 +- drivers/scsi/sd_zbc.c| 2 +- 30 files changed, 329 insertions(+), 334 deletions(-) Cc: Alan Cox Cc: Alex Davis Cc: Ali Akcaagac Cc: Anil Ravindranath Cc: Artur Paszkiewicz Cc: Badari Pulavarty Cc: Bas Vermeulen Cc: Benjamin Herrenschmidt Cc: Brian King Cc: Brian King Cc: Brian Macy Cc: "Bryant G. Ly" Cc: Christoph Hellwig Cc: "C.L. Huang" Cc: Colin DeVilbiss Cc: Dave Boutcher Cc: Dave Boutcher Cc: David Chaw Cc: dc3...@twibble.org Cc: Douglas Gilbert Cc: Doug Ledford Cc: Drew Eckhardt Cc: Erich Chen Cc: Eric Youngdale Cc: FUJITA Tomonori Cc: Hannes Reinecke Cc: Hannes Reinecke Cc: "James E.J. Bottomley" Cc: Jamie Lenehan Cc: Jirka Hanika Cc: Jitendra Bhivare Cc: Karan Tilak Kumar Cc: Ketan Mukadam Cc: Kurt Garloff Cc: Lee Jones Cc: Le Moal Cc: "Leonard N. Zubkoff" Cc: Lind
[PATCH 34/36] scsi: ibmvscsi: ibmvfc: Fix a bunch of misdocumentation
Fixes the following W=1 kernel build warning(s):
drivers/scsi/ibmvscsi/ibmvfc.c:331: warning: Function parameter or member
'vhost' not described in 'ibmvfc_get_err_result'
drivers/scsi/ibmvscsi/ibmvfc.c:653: warning: Excess function parameter
'job_step' description in 'ibmvfc_del_tgt'
drivers/scsi/ibmvscsi/ibmvfc.c:773: warning: Function parameter or member
'queue' not described in 'ibmvfc_init_event_pool'
drivers/scsi/ibmvscsi/ibmvfc.c:773: warning: Function parameter or member
'size' not described in 'ibmvfc_init_event_pool'
drivers/scsi/ibmvscsi/ibmvfc.c:823: warning: Function parameter or member
'queue' not described in 'ibmvfc_free_event_pool'
drivers/scsi/ibmvscsi/ibmvfc.c:1413: warning: Function parameter or member
'vhost' not described in 'ibmvfc_gather_partition_info'
drivers/scsi/ibmvscsi/ibmvfc.c:1483: warning: Function parameter or member
'queue' not described in 'ibmvfc_get_event'
drivers/scsi/ibmvscsi/ibmvfc.c:1483: warning: Excess function parameter
'vhost' description in 'ibmvfc_get_event'
drivers/scsi/ibmvscsi/ibmvfc.c:1630: warning: Function parameter or member 't'
not described in 'ibmvfc_timeout'
drivers/scsi/ibmvscsi/ibmvfc.c:1630: warning: Excess function parameter 'evt'
description in 'ibmvfc_timeout'
drivers/scsi/ibmvscsi/ibmvfc.c:1893: warning: Function parameter or member
'shost' not described in 'ibmvfc_queuecommand'
drivers/scsi/ibmvscsi/ibmvfc.c:1893: warning: Excess function parameter 'done'
description in 'ibmvfc_queuecommand'
drivers/scsi/ibmvscsi/ibmvfc.c:2324: warning: Function parameter or member
'rport' not described in 'ibmvfc_match_rport'
drivers/scsi/ibmvscsi/ibmvfc.c:2324: warning: Excess function parameter
'device' description in 'ibmvfc_match_rport'
drivers/scsi/ibmvscsi/ibmvfc.c:3133: warning: Function parameter or member
'evt_doneq' not described in 'ibmvfc_handle_crq'
drivers/scsi/ibmvscsi/ibmvfc.c:3317: warning: Excess function parameter
'reason' description in 'ibmvfc_change_queue_depth'
drivers/scsi/ibmvscsi/ibmvfc.c:3390: warning: Function parameter or member
'attr' not described in 'ibmvfc_show_log_level'
drivers/scsi/ibmvscsi/ibmvfc.c:3413: warning: Function parameter or member
'attr' not described in 'ibmvfc_store_log_level'
drivers/scsi/ibmvscsi/ibmvfc.c:3413: warning: Function parameter or member
'count' not described in 'ibmvfc_store_log_level'
drivers/scsi/ibmvscsi/ibmvfc.c:4121: warning: Function parameter or member
'done' not described in '__ibmvfc_tgt_get_implicit_logout_evt'
drivers/scsi/ibmvscsi/ibmvfc.c:4438: warning: Function parameter or member 't'
not described in 'ibmvfc_adisc_timeout'
drivers/scsi/ibmvscsi/ibmvfc.c:4438: warning: Excess function parameter 'tgt'
description in 'ibmvfc_adisc_timeout'
drivers/scsi/ibmvscsi/ibmvfc.c:4641: warning: Function parameter or member
'target' not described in 'ibmvfc_alloc_target'
drivers/scsi/ibmvscsi/ibmvfc.c:4641: warning: Excess function parameter
'scsi_id' description in 'ibmvfc_alloc_target'
drivers/scsi/ibmvscsi/ibmvfc.c:5068: warning: Function parameter or member
'evt' not described in 'ibmvfc_npiv_logout_done'
drivers/scsi/ibmvscsi/ibmvfc.c:5068: warning: Excess function parameter
'vhost' description in 'ibmvfc_npiv_logout_done'
Cc: Tyrel Datwyler
Cc: Michael Ellerman
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: Brian King
Cc: linux-s...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
drivers/scsi/ibmvscsi/ibmvfc.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
index a38d9d5d90ba3..a7a9b647ea178 100644
--- a/drivers/scsi/ibmvscsi/ibmvfc.c
+++ b/drivers/scsi/ibmvscsi/ibmvfc.c
@@ -326,6 +326,7 @@ static const char *ibmvfc_get_cmd_error(u16 status, u16
error)
/**
* ibmvfc_get_err_result - Find the scsi status to return for the fcp response
+ * @vhost: ibmvfc host struct
* @vfc_cmd: ibmvfc command struct
*
* Return value:
@@ -650,8 +651,6 @@ static void ibmvfc_reinit_host(struct ibmvfc_host *vhost)
/**
* ibmvfc_del_tgt - Schedule cleanup and removal of the target
* @tgt: ibmvfc target struct
- * @job_step: job step to perform
- *
**/
static void ibmvfc_del_tgt(struct ibmvfc_target *tgt)
{
@@ -768,6 +767,8 @@ static int ibmvfc_send_crq_init_complete(struct ibmvfc_host
*vhost)
/**
* ibmvfc_init_event_pool - Allocates and initializes the event pool for a host
* @vhost: ibmvfc host who owns the event pool
+ * @queue: ibmvfc queue struct
+ * @size: pool size
*
* Returns zero on success.
**/
@@ -820,6 +821,7 @@ static int ibmvfc_init_event_pool(struct ibmvfc_host *vhost,
/**
* ibmvfc_free_event_pool - Frees memory of the event pool of a host
* @vhost: ibmvfc host who owns the event pool
+ * @queue: ibmvfc queue struct
[PATCH 33/36] scsi: ibmvscsi: Fix a bunch of kernel-doc related issues
Fixes the following W=1 kernel build warning(s): drivers/scsi/ibmvscsi/ibmvscsi.c:143: warning: Function parameter or member 'hostdata' not described in 'ibmvscsi_release_crq_queue' drivers/scsi/ibmvscsi/ibmvscsi.c:143: warning: Function parameter or member 'max_requests' not described in 'ibmvscsi_release_crq_queue' drivers/scsi/ibmvscsi/ibmvscsi.c:143: warning: expecting prototype for release_crq_queue(). Prototype was for ibmvscsi_release_crq_queue() instead drivers/scsi/ibmvscsi/ibmvscsi.c:286: warning: expecting prototype for reset_crq_queue(). Prototype was for ibmvscsi_reset_crq_queue() instead drivers/scsi/ibmvscsi/ibmvscsi.c:328: warning: Function parameter or member 'max_requests' not described in 'ibmvscsi_init_crq_queue' drivers/scsi/ibmvscsi/ibmvscsi.c:328: warning: expecting prototype for initialize_crq_queue(). Prototype was for ibmvscsi_init_crq_queue() instead drivers/scsi/ibmvscsi/ibmvscsi.c:414: warning: expecting prototype for reenable_crq_queue(). Prototype was for ibmvscsi_reenable_crq_queue() instead drivers/scsi/ibmvscsi/ibmvscsi.c:536: warning: expecting prototype for ibmvscsi_free(). Prototype was for free_event_struct() instead drivers/scsi/ibmvscsi/ibmvscsi.c:558: warning: expecting prototype for get_evt_struct(). Prototype was for get_event_struct() instead drivers/scsi/ibmvscsi/ibmvscsi.c:587: warning: Function parameter or member 'evt_struct' not described in 'init_event_struct' drivers/scsi/ibmvscsi/ibmvscsi.c:587: warning: Excess function parameter 'evt' description in 'init_event_struct' drivers/scsi/ibmvscsi/ibmvscsi.c:608: warning: Function parameter or member 'cmd' not described in 'set_srp_direction' drivers/scsi/ibmvscsi/ibmvscsi.c:608: warning: Function parameter or member 'srp_cmd' not described in 'set_srp_direction' drivers/scsi/ibmvscsi/ibmvscsi.c:608: warning: Function parameter or member 'numbuf' not described in 'set_srp_direction' drivers/scsi/ibmvscsi/ibmvscsi.c:641: warning: Function parameter or member 'evt_struct' not described in 'unmap_cmd_data' drivers/scsi/ibmvscsi/ibmvscsi.c:683: warning: Function parameter or member 'evt_struct' not described in 'map_sg_data' drivers/scsi/ibmvscsi/ibmvscsi.c:757: warning: Function parameter or member 'evt_struct' not described in 'map_data_for_srp_cmd' drivers/scsi/ibmvscsi/ibmvscsi.c:783: warning: Function parameter or member 'error_code' not described in 'purge_requests' drivers/scsi/ibmvscsi/ibmvscsi.c:846: warning: Function parameter or member 't' not described in 'ibmvscsi_timeout' drivers/scsi/ibmvscsi/ibmvscsi.c:846: warning: Excess function parameter 'evt_struct' description in 'ibmvscsi_timeout' drivers/scsi/ibmvscsi/ibmvscsi.c:1043: warning: Function parameter or member 'cmnd' not described in 'ibmvscsi_queuecommand_lck' drivers/scsi/ibmvscsi/ibmvscsi.c:1043: warning: expecting prototype for ibmvscsi_queue(). Prototype was for ibmvscsi_queuecommand_lck() instead drivers/scsi/ibmvscsi/ibmvscsi.c:1351: warning: expecting prototype for init_host(). Prototype was for enable_fast_fail() instead drivers/scsi/ibmvscsi/ibmvscsi.c:1464: warning: Function parameter or member 'hostdata' not described in 'init_adapter' drivers/scsi/ibmvscsi/ibmvscsi.c:1475: warning: Function parameter or member 'evt_struct' not described in 'sync_completion' drivers/scsi/ibmvscsi/ibmvscsi.c:1488: warning: Function parameter or member 'cmd' not described in 'ibmvscsi_eh_abort_handler' drivers/scsi/ibmvscsi/ibmvscsi.c:1488: warning: expecting prototype for ibmvscsi_abort(). Prototype was for ibmvscsi_eh_abort_handler() instead drivers/scsi/ibmvscsi/ibmvscsi.c:1627: warning: Function parameter or member 'cmd' not described in 'ibmvscsi_eh_device_reset_handler' drivers/scsi/ibmvscsi/ibmvscsi.c:1893: warning: Excess function parameter 'reason' description in 'ibmvscsi_change_queue_depth' drivers/scsi/ibmvscsi/ibmvscsi.c:2221: warning: Function parameter or member 'vdev' not described in 'ibmvscsi_probe' drivers/scsi/ibmvscsi/ibmvscsi.c:2221: warning: Function parameter or member 'id' not described in 'ibmvscsi_probe' drivers/scsi/ibmvscsi/ibmvscsi.c:2221: warning: expecting prototype for Called by bus code for each adapter(). Prototype was for ibmvscsi_probe() instead drivers/scsi/ibmvscsi/ibmvscsi.c:2381: warning: cannot understand function prototype: 'const struct vio_device_id ibmvscsi_device_table[] = ' Cc: Tyrel Datwyler Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Cc: Colin DeVilbiss Cc: Santiago Leon Cc: Dave Boutcher Cc: linux-s...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/scsi/ibmvscsi/ibmvscsi.c | 70 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/scsi/ibmvscsi/ibmvscsi.c b/drivers/scsi/ibmvscsi/ibmvscsi.c index 77fafb1bc173a..9ffd71e425f90 100644 --- a/d
[PATCH 09/10] crypto: nx: nx-aes-cbc: Repair some kernel-doc problems
Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'tfm' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'in_key' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'key_len' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: expecting prototype for Nest Accelerators driver(). Prototype was for cbc_aes_nx_set_key() instead drivers/crypto/nx/nx_debugfs.c:34: warning: Function parameter or member 'drv' not described in 'nx_debugfs_init' drivers/crypto/nx/nx_debugfs.c:34: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_debugfs_init() instead drivers/crypto/nx/nx.c:31: warning: Incorrect use of kernel-doc format: * nx_hcall_sync - make an H_COP_OP hcall for the passed in op structure drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'nx_ctx' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'op' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'may_sleep' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_hcall_sync() instead drivers/crypto/nx/nx.c:209: warning: Function parameter or member 'nbytes' not described in 'trim_sg_list' Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx-aes-cbc.c | 2 +- drivers/crypto/nx/nx.c | 5 +++-- drivers/crypto/nx/nx_debugfs.c | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/nx/nx-aes-cbc.c b/drivers/crypto/nx/nx-aes-cbc.c index 92e921eceed75..d6314ea9ae896 100644 --- a/drivers/crypto/nx/nx-aes-cbc.c +++ b/drivers/crypto/nx/nx-aes-cbc.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * AES CBC routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. diff --git a/drivers/crypto/nx/nx.c b/drivers/crypto/nx/nx.c index 1d0e8a1ba1605..010e87d9da36b 100644 --- a/drivers/crypto/nx/nx.c +++ b/drivers/crypto/nx/nx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. @@ -200,7 +200,8 @@ struct nx_sg *nx_walk_and_build(struct nx_sg *nx_dst, * @sg: sg list head * @end: sg lisg end * @delta: is the amount we need to crop in order to bound the list. - * + * @nbytes: length of data in the scatterlists or data length - whichever + * is greater. */ static long int trim_sg_list(struct nx_sg *sg, struct nx_sg *end, diff --git a/drivers/crypto/nx/nx_debugfs.c b/drivers/crypto/nx/nx_debugfs.c index 1975bcbee9974..ee7cd88bb10a7 100644 --- a/drivers/crypto/nx/nx_debugfs.c +++ b/drivers/crypto/nx/nx_debugfs.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * debugfs routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. -- 2.27.0
[PATCH 08/10] crypto: vmx: Source headers are not good kernel-doc candidates
Fixes the following W=1 kernel build warning(s): drivers/crypto/vmx/vmx.c:23: warning: expecting prototype for Routines supporting VMX instructions on the Power 8(). Prototype was for p8_init() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Henrique Cerri Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/vmx/vmx.c b/drivers/crypto/vmx/vmx.c index a40d08e75fc0b..7eb713cc87c8c 100644 --- a/drivers/crypto/vmx/vmx.c +++ b/drivers/crypto/vmx/vmx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Routines supporting VMX instructions on the Power 8 * * Copyright (C) 2015 International Business Machines Inc. -- 2.27.0
[PATCH v2 00/10] Rid W=1 warnings in Crypto
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. This is set 1 of 2 sets required to fully clean Crypto. No functional changes since v1. Lee Jones (10): crypto: hisilicon: sec_drv: Supply missing description for 'sec_queue_empty()'s 'queue' param crypto: bcm: Fix a whole host of kernel-doc misdemeanours crypto: chelsio: chcr_core: Fix some kernel-doc issues crypto: ux500: hash: hash_core: Fix worthy kernel-doc headers and remove others crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs crypto: atmel-ecc: Struct headers need to start with keyword 'struct' crypto: caam: caampkc: Provide the name of the function and provide missing descriptions crypto: vmx: Source headers are not good kernel-doc candidates crypto: nx: nx-aes-cbc: Repair some kernel-doc problems crypto: cavium: nitrox_isr: Demote non-compliant kernel-doc headers drivers/crypto/atmel-ecc.c| 2 +- drivers/crypto/bcm/cipher.c | 7 ++-- drivers/crypto/bcm/spu.c | 16 - drivers/crypto/bcm/spu2.c | 43 +-- drivers/crypto/bcm/util.c | 4 +-- drivers/crypto/caam/caamalg_qi2.c | 2 ++ drivers/crypto/caam/caampkc.c | 3 +- drivers/crypto/cavium/nitrox/nitrox_isr.c | 4 +-- drivers/crypto/chelsio/chcr_algo.c| 8 ++--- drivers/crypto/chelsio/chcr_core.c| 2 +- drivers/crypto/hisilicon/sec/sec_drv.c| 1 + drivers/crypto/keembay/ocs-hcu.c | 6 ++-- drivers/crypto/nx/nx-aes-cbc.c| 2 +- drivers/crypto/nx/nx.c| 5 +-- drivers/crypto/nx/nx_debugfs.c| 2 +- drivers/crypto/ux500/cryp/cryp.c | 5 +-- drivers/crypto/ux500/cryp/cryp_core.c | 5 +-- drivers/crypto/ux500/cryp/cryp_irq.c | 2 +- drivers/crypto/ux500/hash/hash_core.c | 15 +++- drivers/crypto/vmx/vmx.c | 2 +- 20 files changed, 71 insertions(+), 65 deletions(-) Cc: Alexandre Belloni Cc: Andreas Westin Cc: Atul Gupta Cc: Aymen Sghaier Cc: Ayush Sawal Cc: Benjamin Herrenschmidt Cc: Berne Hebark Cc: "Breno Leitão" Cc: Daniele Alessandrelli Cc: "David S. Miller" Cc: Declan Murphy Cc: Harsh Jain Cc: Henrique Cerri Cc: Herbert Xu Cc: "Horia Geantă" Cc: Jitendra Lulla Cc: Joakim Bech Cc: Jonas Linde Cc: Jonathan Cameron Cc: Kent Yoder Cc: linux-arm-ker...@lists.infradead.org Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Ludovic Desroches Cc: Manoj Malviya Cc: Michael Ellerman Cc: M R Gowda Cc: Nayna Jain Cc: Nicolas Ferre Cc: Niklas Hernaeus Cc: Paul Mackerras Cc: Paulo Flabiano Smorigo Cc: Rob Rice Cc: Rohit Maheshwari Cc: Shujuan Chen Cc: Tudor Ambarus Cc: Vinay Kumar Yadav Cc: Zaibo Xu -- 2.27.0
[RESEND 1/1] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location
Fixes the following W=1 kernel build warning(s): drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for ‘hvc_vio_init_early’ [-Wmissing-prototypes] 385 | void __init hvc_vio_init_early(void) | ^~ Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Michael Ellerman --- arch/powerpc/include/asm/hvconsole.h | 3 +++ arch/powerpc/platforms/pseries/pseries.h | 3 --- arch/powerpc/platforms/pseries/setup.c | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/hvconsole.h b/arch/powerpc/include/asm/hvconsole.h index 999ed5ac90531..ccb2034506f0f 100644 --- a/arch/powerpc/include/asm/hvconsole.h +++ b/arch/powerpc/include/asm/hvconsole.h @@ -24,5 +24,8 @@ extern int hvc_get_chars(uint32_t vtermno, char *buf, int count); extern int hvc_put_chars(uint32_t vtermno, const char *buf, int count); +/* Provided by HVC VIO */ +void hvc_vio_init_early(void); + #endif /* __KERNEL__ */ #endif /* _PPC64_HVCONSOLE_H */ diff --git a/arch/powerpc/platforms/pseries/pseries.h b/arch/powerpc/platforms/pseries/pseries.h index 4fe48c04c6c20..a13438fca10a8 100644 --- a/arch/powerpc/platforms/pseries/pseries.h +++ b/arch/powerpc/platforms/pseries/pseries.h @@ -43,9 +43,6 @@ extern void pSeries_final_fixup(void); /* Poweron flag used for enabling auto ups restart */ extern unsigned long rtas_poweron_auto; -/* Provided by HVC VIO */ -extern void hvc_vio_init_early(void); - /* Dynamic logical Partitioning/Mobility */ extern void dlpar_free_cc_nodes(struct device_node *); extern void dlpar_free_cc_property(struct property *); diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index 46e1540abc229..145e3f4c999af 100644 --- a/arch/powerpc/platforms/pseries/setup.c +++ b/arch/powerpc/platforms/pseries/setup.c @@ -71,6 +71,7 @@ #include #include #include +#include #include "pseries.h" #include "../../../../drivers/pci/pci.h" -- 2.27.0
[PATCH 18/20] crypto: nx: nx_debugfs: Header comments should not be kernel-doc
Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx_debugfs.c:34: warning: Function parameter or member 'drv' not described in 'nx_debugfs_init' drivers/crypto/nx/nx_debugfs.c:34: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_debugfs_init() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/nx/nx_debugfs.c b/drivers/crypto/nx/nx_debugfs.c index 1975bcbee9974..ee7cd88bb10a7 100644 --- a/drivers/crypto/nx/nx_debugfs.c +++ b/drivers/crypto/nx/nx_debugfs.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * debugfs routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. -- 2.25.1
[PATCH 16/20] crypto: vmx: Source headers are not good kernel-doc candidates
Fixes the following W=1 kernel build warning(s): drivers/crypto/vmx/vmx.c:23: warning: expecting prototype for Routines supporting VMX instructions on the Power 8(). Prototype was for p8_init() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Henrique Cerri Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/vmx/vmx.c b/drivers/crypto/vmx/vmx.c index a40d08e75fc0b..7eb713cc87c8c 100644 --- a/drivers/crypto/vmx/vmx.c +++ b/drivers/crypto/vmx/vmx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Routines supporting VMX instructions on the Power 8 * * Copyright (C) 2015 International Business Machines Inc. -- 2.25.1
[PATCH 17/20] crypto: nx: nx-aes-cbc: Headers comments should not be kernel-doc
Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'tfm' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'in_key' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'key_len' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: expecting prototype for Nest Accelerators driver(). Prototype was for cbc_aes_nx_set_key() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx-aes-cbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/nx/nx-aes-cbc.c b/drivers/crypto/nx/nx-aes-cbc.c index 92e921eceed75..d6314ea9ae896 100644 --- a/drivers/crypto/nx/nx-aes-cbc.c +++ b/drivers/crypto/nx/nx-aes-cbc.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * AES CBC routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. -- 2.25.1
[PATCH 19/20] crypto: nx: Demote header comment and add description for 'nbytes'
Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx.c:31: warning: Incorrect use of kernel-doc format: * nx_hcall_sync - make an H_COP_OP hcall for the passed in op structure drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'nx_ctx' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'op' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: Function parameter or member 'may_sleep' not described in 'nx_hcall_sync' drivers/crypto/nx/nx.c:43: warning: expecting prototype for Nest Accelerators driver(). Prototype was for nx_hcall_sync() instead drivers/crypto/nx/nx.c:209: warning: Function parameter or member 'nbytes' not described in 'trim_sg_list' Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/crypto/nx/nx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/nx/nx.c b/drivers/crypto/nx/nx.c index 0d2dc5be7f192..010be6793c9fc 100644 --- a/drivers/crypto/nx/nx.c +++ b/drivers/crypto/nx/nx.c @@ -1,5 +1,5 @@ // SPDX-License-Identifier: GPL-2.0-only -/** +/* * Routines supporting the Power 7+ Nest Accelerators driver * * Copyright (C) 2011-2012 International Business Machines Inc. @@ -200,7 +200,8 @@ struct nx_sg *nx_walk_and_build(struct nx_sg *nx_dst, * @sg: sg list head * @end: sg lisg end * @delta: is the amount we need to crop in order to bound the list. - * + * @nbytes: length of data in the scatterlists or data length - whichever + * is greater. */ static long int trim_sg_list(struct nx_sg *sg, struct nx_sg *end, -- 2.25.1
[PATCH 00/20] Rid W=1 warnings in Crypto
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. This is set 1 of 2 sets required to fully clean Crypto. Lee Jones (20): crypto: hisilicon: sec_drv: Supply missing description for 'sec_queue_empty()'s 'queue' param crypto: bcm: util: Repair a couple of documentation formatting issues crypto: chelsio: chcr_core: File headers are not good candidates for kernel-doc crypto: ux500: hash: hash_core: Fix worthy kernel-doc headers and remove others crypto: bcm: spu: Fix formatting and misspelling issues crypto: keembay: ocs-hcu: Fix incorrectly named functions/structs crypto: bcm: spu2: Fix a whole host of kernel-doc misdemeanours crypto: ux500: cryp: Demote some conformant non-kernel headers fix another crypto: ux500: cryp_irq: File headers are not good kernel-doc candidates crypto: chelsio: chcr_algo: Fix a couple of kernel-doc issues caused by doc-rot crypto: ux500: cryp_core: Fix formatting issue and add description for 'session_id' crypto: atmel-ecc: Struct headers need to start with keyword 'struct' crypto: bcm: cipher: Provide description for 'req' and fix formatting issues crypto: caam: caampkc: Provide the name of the function crypto: caam: caamalg_qi2: Supply a couple of 'fallback' related descriptions crypto: vmx: Source headers are not good kernel-doc candidates crypto: nx: nx-aes-cbc: Headers comments should not be kernel-doc crypto: nx: nx_debugfs: Header comments should not be kernel-doc crypto: nx: Demote header comment and add description for 'nbytes' crypto: cavium: nitrox_isr: Demote non-compliant kernel-doc headers drivers/crypto/atmel-ecc.c| 2 +- drivers/crypto/bcm/cipher.c | 7 ++-- drivers/crypto/bcm/spu.c | 16 - drivers/crypto/bcm/spu2.c | 43 +-- drivers/crypto/bcm/util.c | 4 +-- drivers/crypto/caam/caamalg_qi2.c | 2 ++ drivers/crypto/caam/caampkc.c | 3 +- drivers/crypto/cavium/nitrox/nitrox_isr.c | 4 +-- drivers/crypto/chelsio/chcr_algo.c| 8 ++--- drivers/crypto/chelsio/chcr_core.c| 2 +- drivers/crypto/hisilicon/sec/sec_drv.c| 1 + drivers/crypto/keembay/ocs-hcu.c | 6 ++-- drivers/crypto/nx/nx-aes-cbc.c| 2 +- drivers/crypto/nx/nx.c| 5 +-- drivers/crypto/nx/nx_debugfs.c| 2 +- drivers/crypto/ux500/cryp/cryp.c | 5 +-- drivers/crypto/ux500/cryp/cryp_core.c | 5 +-- drivers/crypto/ux500/cryp/cryp_irq.c | 2 +- drivers/crypto/ux500/hash/hash_core.c | 15 +++- drivers/crypto/vmx/vmx.c | 2 +- 20 files changed, 71 insertions(+), 65 deletions(-) Cc: Alexandre Belloni Cc: Andreas Westin Cc: Atul Gupta Cc: Aymen Sghaier Cc: Ayush Sawal Cc: Benjamin Herrenschmidt Cc: Berne Hebark Cc: "Breno Leitão" Cc: Daniele Alessandrelli Cc: "David S. Miller" Cc: Declan Murphy Cc: "Gustavo A. R. Silva" Cc: Harsh Jain Cc: Henrique Cerri Cc: Herbert Xu Cc: "Horia Geantă" Cc: Jitendra Lulla Cc: Joakim Bech Cc: Jonas Linde Cc: Jonathan Cameron Cc: Kent Yoder Cc: linux-arm-ker...@lists.infradead.org Cc: linux-cry...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Ludovic Desroches Cc: Manoj Malviya Cc: Michael Ellerman Cc: M R Gowda Cc: Nayna Jain Cc: Nicolas Ferre Cc: Niklas Hernaeus Cc: Paul Mackerras Cc: Paulo Flabiano Smorigo Cc: Rob Rice Cc: Rohit Maheshwari Cc: Shujuan Chen Cc: Takashi Iwai Cc: Tudor Ambarus Cc: Vinay Kumar Yadav Cc: Zaibo Xu -- 2.25.1
[PATCH 6/7] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter
or member 'irq' not described in 'gelic_card_interrupt'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter
or member 'ptr' not described in 'gelic_card_interrupt'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1407: warning: Function parameter
or member 'txqueue' not described in 'gelic_net_tx_timeout'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1439: warning: Function parameter
or member 'napi' not described in 'gelic_ether_setup_netdev_ops'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1639: warning: Function parameter
or member 'dev' not described in 'ps3_gelic_driver_probe'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1795: warning: Function parameter
or member 'dev' not described in 'ps3_gelic_driver_remove'
Cc: Geoff Levand
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Michael Ellerman
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Utz Bacher
Cc: Jens Osterkamp
Cc: net...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Reviewed-by: Andrew Lunn
Signed-off-by: Lee Jones
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
index 3d1fc8d2ca667..55e652624bd76 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
@@ -1100,7 +1100,7 @@ static int gelic_net_poll(struct napi_struct *napi, int
budget)
return packets_done;
}
-/**
+/*
* gelic_card_interrupt - event handler for gelic_net
*/
static irqreturn_t gelic_card_interrupt(int irq, void *ptr)
@@ -1400,6 +1400,7 @@ static void gelic_net_tx_timeout_task(struct work_struct
*work)
/**
* gelic_net_tx_timeout - called when the tx timeout watchdog kicks in.
* @netdev: interface device structure
+ * @txqueue: unused
*
* called, if tx hangs. Schedules a task that resets the interface
*/
@@ -1431,6 +1432,7 @@ static const struct net_device_ops gelic_netdevice_ops = {
/**
* gelic_ether_setup_netdev_ops - initialization of net_device operations
* @netdev: net_device structure
+ * @napi: napi structure
*
* fills out function pointers in the net_device structure
*/
@@ -1632,7 +1634,7 @@ static void gelic_card_get_vlan_info(struct gelic_card
*card)
dev_info(ctodev(card), "internal vlan %s\n",
card->vlan_required? "enabled" : "disabled");
}
-/**
+/*
* ps3_gelic_driver_probe - add a device to the control of this driver
*/
static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev)
@@ -1787,7 +1789,7 @@ static int ps3_gelic_driver_probe(struct
ps3_system_bus_device *dev)
return result;
}
-/**
+/*
* ps3_gelic_driver_remove - remove a device from the control of this driver
*/
--
2.25.1
[PATCH 5/7] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours
Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'skb' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_len' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_field' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'scrq_arr' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'num_entries' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'adapter' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'rwi' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'reset_state' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'adapter' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'rwi' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'reset_state' not described in 'do_reset' Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: net...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ibm/ibmvnic.c | 27 +-- drivers/net/xen-netfront.c | 6 +++--- 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index aed985e08e8ad..4c4252e68de5a 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1384,10 +1384,10 @@ static int ibmvnic_close(struct net_device *netdev) /** * build_hdr_data - creates L2/L3/L4 header data buffer - * @hdr_field - bitfield determining needed headers - * @skb - socket buffer - * @hdr_len - array of header lengths - * @tot_len - total length of data + * @hdr_field: bitfield determining needed headers + * @skb: socket buffer + * @hdr_len: array of header lengths + * @hdr_data: buffer to write the header to * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1444,11 +1444,11 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors - * @hdr_field - bitfield determining needed headers - * @data - buffer containing header data - * @len - length of data buffer - * @hdr_len - array of individual header lengths - * @scrq_arr - descriptor array + * @hdr_field: bitfield determining needed headers + * @hdr_data: buffer containing header data + * @len: length of data buffer + * @hdr_len: array of individual header lengths + * @scrq_arr: descriptor array * * Creates header and, if needed, header extension descriptors and * places them in a descriptor array, scrq_arr @@ -1496,10 +1496,9 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb - socket buffer - * @num_entries - number of descriptors to be sent - * @subcrq - first TX descriptor - * @hdr_field - bit field determining which headers will be sent + * @txbuff: tx buffer + * @num_entries: number of descriptors to be sent + * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descri
[RESEND v2 0/7] Rid W=1 warnings in Ethernet
Resending the stragglers again. This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. No changes since v2, just a rebase onto net-next. v2: - Squashed IBM patches - Fixed real issue in SMSC - Added Andrew's Reviewed-by tags on remainder Lee Jones (7): net: ethernet: smsc: smc91x: Fix function name in kernel-doc header net: xen-netback: xenbus: Demote nonconformant kernel-doc headers net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters drivers/net/ethernet/ibm/ibmvnic.c | 27 ++-- drivers/net/ethernet/smsc/smc91x.c | 2 +- drivers/net/ethernet/ti/am65-cpsw-qos.c | 2 +- drivers/net/ethernet/ti/am65-cpts.c | 2 +- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +++--- drivers/net/ethernet/toshiba/spider_net.c| 18 - drivers/net/xen-netback/xenbus.c | 4 +-- drivers/net/xen-netfront.c | 6 ++--- 8 files changed, 37 insertions(+), 32 deletions(-) Cc: Alexei Starovoitov Cc: Benjamin Herrenschmidt Cc: b...@vger.kernel.org Cc: Daniel Borkmann Cc: Dany Madden Cc: Daris A Nevil Cc: "David S. Miller" Cc: Erik Stahlman Cc: Geoff Levand Cc: Grygorii Strashko Cc: "Gustavo A. R. Silva" Cc: Ishizaki Kou Cc: Ivan Khoronzhuk Cc: Jakub Kicinski Cc: Jens Osterkamp Cc: Jesper Dangaard Brouer Cc: John Allen Cc: John Fastabend Cc: Kurt Kanzenbach Cc: Lijun Pan Cc: linuxppc-dev@lists.ozlabs.org Cc: Michael Ellerman Cc: net...@vger.kernel.org Cc: Nicolas Pitre Cc: Paul Durrant Cc: Paul Mackerras Cc: Peter Cammaert Cc: Russell King Cc: Rusty Russell Cc: Santiago Leon Cc: Sukadev Bhattiprolu Cc: Thomas Falcon Cc: Utz Bacher Cc: Wei Liu Cc: xen-de...@lists.xenproject.org -- 2.25.1
Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet
On Fri, 15 Jan 2021, Christophe Leroy wrote: > > > Le 15/01/2021 à 12:18, Lee Jones a écrit : > > On Thu, 14 Jan 2021, Lee Jones wrote: > > > > > On Thu, 14 Jan 2021, Jakub Kicinski wrote: > > > > > > > On Thu, 14 Jan 2021 08:33:49 + Lee Jones wrote: > > > > > On Wed, 13 Jan 2021, Jakub Kicinski wrote: > > > > > > > > > > > On Wed, 13 Jan 2021 16:41:16 + Lee Jones wrote: > > > > > > > Resending the stragglers again. > > > > > > > > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > > > > kernel builds, which are currently overwhelmingly riddled with > > > > > > > niggly little warnings. > > > > > > > v2: > > > > > > > - Squashed IBM patches > > > > > > > - Fixed real issue in SMSC > > > > > > > - Added Andrew's Reviewed-by tags on remainder > > > > > > > > > > > > Does not apply, please rebase on net-next/master. > > > > > > > > > > These are based on Tuesday's next/master. > > > > > > > > What's next/master? > > > > > > I'm not sure if this is a joke, or not? :) > > > > > > next/master == Linux Next. The daily merged repo where all of the > > > *-next branches end up to ensure interoperability. It's also the > > > branch that is most heavily tested by the auto-builders to ensure the > > > vast majority of issues are ironed out before hitting Mainline. > > > > > > > This is net-next: > > > > > > > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/ > > > > > > Looks like net-next gets merged into next/master: > > > > > > commit 452958f1f3d1c8980a8414f9c37c8c6de24c7d32 > > > Merge: 1eabba209a17a f50e2f9f79164 > > > Author: Stephen Rothwell > > > Date: Thu Jan 14 10:35:40 2021 +1100 > > > > > > Merge remote-tracking branch 'net-next/master' > > > > > > So I'm not sure what it's conflicting with. > > > > > > Do you have patches in net-next that didn't make it into next/master > > > for some reason? > > > > > > I'll try to rebase again tomorrow. > > > > > > Hopefully I am able to reproduce your issue by then. > > > > Okay so my development branch rebased again with no issue. > > Rebasing is not same as patches application. > > > > > I also took the liberty to checkout net-next and cherry-pick the > > patches [0], which again didn't cause a problem. > > Also normal, cherry-picking is not the same as applying a patch series. > > > > > I'm not sure what else to suggest. Is your local copy up-to-date? > > I guess so, I have the same problem as Jakub, see below. I had to use 'git > am -3' to apply you series. As you can see, git falls back to 3 way merge > for patch 1, which means your series is close to but not fully in sync with > net-next. > > > [root@localhost linux-powerpc]# git remote -v > net-next > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git (fetch) > net-next > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git (push) > > [root@localhost linux-powerpc]# git checkout net-next/master -b net-next > Switched to a new branch 'net-next' > > [root@localhost linux-powerpc]# git am > /root/Downloads/Rid-W-1-warnings-in-Ethernet.patch > Applying: net: ethernet: smsc: smc91x: Fix function name in kernel-doc header > error: patch failed: drivers/net/ethernet/smsc/smc91x.c:2192 > error: drivers/net/ethernet/smsc/smc91x.c: patch does not apply > Patch failed at 0001 net: ethernet: smsc: smc91x: Fix function name in > kernel-doc header > hint: Use 'git am --show-current-patch' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > > [root@localhost linux-powerpc]# git am --abort > > [root@localhost linux-powerpc]# git am -3 > /root/Downloads/Rid-W-1-warnings-in-Ethernet.patch > Applying: net: ethernet: smsc: smc91x: Fix function name in kernel-doc header > Using index info to reconstruct a base tree... > M drivers/net/ethernet/smsc/smc91x.c > Falling back to patching base and 3-way merge... > Auto-merging drivers/net/ethernet/smsc/smc91x.c > Ap
Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet
On Thu, 14 Jan 2021, Lee Jones wrote: > On Thu, 14 Jan 2021, Jakub Kicinski wrote: > > > On Thu, 14 Jan 2021 08:33:49 +0000 Lee Jones wrote: > > > On Wed, 13 Jan 2021, Jakub Kicinski wrote: > > > > > > > On Wed, 13 Jan 2021 16:41:16 + Lee Jones wrote: > > > > > Resending the stragglers again. > > > > > > > > > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > > > > > > > kernel builds, which are currently overwhelmingly riddled with > > > > > > > > > > niggly little warnings. > > > > > > > > > > > > > > > > > > > > v2: > > > > > > > > > > - Squashed IBM patches > > > > > > > > > > - Fixed real issue in SMSC > > > > > - Added Andrew's Reviewed-by tags on remainder > > > > > > > > Does not apply, please rebase on net-next/master. > > > > > > These are based on Tuesday's next/master. > > > > What's next/master? > > I'm not sure if this is a joke, or not? :) > > next/master == Linux Next. The daily merged repo where all of the > *-next branches end up to ensure interoperability. It's also the > branch that is most heavily tested by the auto-builders to ensure the > vast majority of issues are ironed out before hitting Mainline. > > > This is net-next: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/ > > Looks like net-next gets merged into next/master: > > commit 452958f1f3d1c8980a8414f9c37c8c6de24c7d32 > Merge: 1eabba209a17a f50e2f9f79164 > Author: Stephen Rothwell > Date: Thu Jan 14 10:35:40 2021 +1100 > > Merge remote-tracking branch 'net-next/master' > > So I'm not sure what it's conflicting with. > > Do you have patches in net-next that didn't make it into next/master > for some reason? > > I'll try to rebase again tomorrow. > > Hopefully I am able to reproduce your issue by then. Okay so my development branch rebased again with no issue. I also took the liberty to checkout net-next and cherry-pick the patches [0], which again didn't cause a problem. I'm not sure what else to suggest. Is your local copy up-to-date? [0] lee@dell:~/projects/linux/kernel [net-next]$ gcp 0cea4b05acd57..924e1f46aba5e Auto-merging drivers/net/ethernet/smsc/smc91x.c [net-next 19811db3120a2] net: ethernet: smsc: smc91x: Fix function name in kernel-doc header Date: Mon Oct 19 12:47:11 2020 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [net-next dc6f4490cb64e] net: xen-netback: xenbus: Demote nonconformant kernel-doc headers Date: Tue Oct 20 08:00:43 2020 +0100 1 file changed, 2 insertions(+), 2 deletions(-) [net-next a3363cb09ae59] net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header Date: Tue Oct 20 09:05:38 2020 +0100 1 file changed, 1 insertion(+), 1 deletion(-) [net-next 005462f886c3e] net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter Date: Tue Oct 20 09:06:57 2020 +0100 1 file changed, 1 insertion(+), 1 deletion(-) Auto-merging drivers/net/xen-netfront.c [net-next 9fcc32e395e09] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours Date: Tue Oct 20 09:42:19 2020 +0100 2 files changed, 16 insertions(+), 17 deletions(-) [net-next 15ba865fef481] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours Date: Tue Oct 20 10:10:14 2020 +0100 1 file changed, 5 insertions(+), 3 deletions(-) [net-next f815eb7cbd7f5] net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters Date: Tue Oct 20 10:18:21 2020 +0100 1 file changed, 11 insertions(+), 7 deletions(-) -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet
On Thu, 14 Jan 2021, Jakub Kicinski wrote: > On Thu, 14 Jan 2021 08:33:49 +0000 Lee Jones wrote: > > On Wed, 13 Jan 2021, Jakub Kicinski wrote: > > > > > On Wed, 13 Jan 2021 16:41:16 + Lee Jones wrote: > > > > Resending the stragglers again. > > > > > > > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > > > > > kernel builds, which are currently overwhelmingly riddled with > > > > > > > > niggly little warnings. > > > > > > > > > > > > > > > > v2: > > > > > > > > - Squashed IBM patches > > > > > > > > - Fixed real issue in SMSC > > > > - Added Andrew's Reviewed-by tags on remainder > > > > > > Does not apply, please rebase on net-next/master. > > > > These are based on Tuesday's next/master. > > What's next/master? I'm not sure if this is a joke, or not? :) next/master == Linux Next. The daily merged repo where all of the *-next branches end up to ensure interoperability. It's also the branch that is most heavily tested by the auto-builders to ensure the vast majority of issues are ironed out before hitting Mainline. > This is net-next: > > https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/ Looks like net-next gets merged into next/master: commit 452958f1f3d1c8980a8414f9c37c8c6de24c7d32 Merge: 1eabba209a17a f50e2f9f79164 Author: Stephen Rothwell Date: Thu Jan 14 10:35:40 2021 +1100 Merge remote-tracking branch 'net-next/master' So I'm not sure what it's conflicting with. Do you have patches in net-next that didn't make it into next/master for some reason? I'll try to rebase again tomorrow. Hopefully I am able to reproduce your issue by then. > > I just rebased them now with no issue. > > > > What conflict are you seeing? > > Applying: net: ethernet: smsc: smc91x: Fix function name in kernel-doc header > error: patch failed: drivers/net/ethernet/smsc/smc91x.c:2192 > error: drivers/net/ethernet/smsc/smc91x.c: patch does not apply > Patch failed at 0001 net: ethernet: smsc: smc91x: Fix function name in > kernel-doc header > hint: Use 'git am --show-current-patch=diff' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH v2 0/7] Rid W=1 warnings in Ethernet
On Wed, 13 Jan 2021, Jakub Kicinski wrote: > On Wed, 13 Jan 2021 16:41:16 +0000 Lee Jones wrote: > > Resending the stragglers again. > > > > > > This set is part of a larger effort attempting to clean-up W=1 > > > > kernel builds, which are currently overwhelmingly riddled with > > > > niggly little warnings. > > > > > > > > v2: > > > > - Squashed IBM patches > > > > - Fixed real issue in SMSC > > - Added Andrew's Reviewed-by tags on remainder > > Does not apply, please rebase on net-next/master. These are based on Tuesday's next/master. I just rebased them now with no issue. What conflict are you seeing? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
[PATCH 6/7] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter
or member 'irq' not described in 'gelic_card_interrupt'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter
or member 'ptr' not described in 'gelic_card_interrupt'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1407: warning: Function parameter
or member 'txqueue' not described in 'gelic_net_tx_timeout'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1439: warning: Function parameter
or member 'napi' not described in 'gelic_ether_setup_netdev_ops'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1639: warning: Function parameter
or member 'dev' not described in 'ps3_gelic_driver_probe'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1795: warning: Function parameter
or member 'dev' not described in 'ps3_gelic_driver_remove'
Cc: Geoff Levand
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Michael Ellerman
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Utz Bacher
Cc: Jens Osterkamp
Cc: net...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Reviewed-by: Andrew Lunn
Signed-off-by: Lee Jones
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
index 3d1fc8d2ca667..55e652624bd76 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
@@ -1100,7 +1100,7 @@ static int gelic_net_poll(struct napi_struct *napi, int
budget)
return packets_done;
}
-/**
+/*
* gelic_card_interrupt - event handler for gelic_net
*/
static irqreturn_t gelic_card_interrupt(int irq, void *ptr)
@@ -1400,6 +1400,7 @@ static void gelic_net_tx_timeout_task(struct work_struct
*work)
/**
* gelic_net_tx_timeout - called when the tx timeout watchdog kicks in.
* @netdev: interface device structure
+ * @txqueue: unused
*
* called, if tx hangs. Schedules a task that resets the interface
*/
@@ -1431,6 +1432,7 @@ static const struct net_device_ops gelic_netdevice_ops = {
/**
* gelic_ether_setup_netdev_ops - initialization of net_device operations
* @netdev: net_device structure
+ * @napi: napi structure
*
* fills out function pointers in the net_device structure
*/
@@ -1632,7 +1634,7 @@ static void gelic_card_get_vlan_info(struct gelic_card
*card)
dev_info(ctodev(card), "internal vlan %s\n",
card->vlan_required? "enabled" : "disabled");
}
-/**
+/*
* ps3_gelic_driver_probe - add a device to the control of this driver
*/
static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev)
@@ -1787,7 +1789,7 @@ static int ps3_gelic_driver_probe(struct
ps3_system_bus_device *dev)
return result;
}
-/**
+/*
* ps3_gelic_driver_remove - remove a device from the control of this driver
*/
--
2.25.1
[PATCH v2 0/7] Rid W=1 warnings in Ethernet
Resending the stragglers again. This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. v2: - Squashed IBM patches - Fixed real issue in SMSC - Added Andrew's Reviewed-by tags on remainder Lee Jones (7): net: ethernet: smsc: smc91x: Fix function name in kernel-doc header net: xen-netback: xenbus: Demote nonconformant kernel-doc headers net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters drivers/net/ethernet/ibm/ibmvnic.c | 27 ++-- drivers/net/ethernet/smsc/smc91x.c | 2 +- drivers/net/ethernet/ti/am65-cpsw-qos.c | 2 +- drivers/net/ethernet/ti/am65-cpts.c | 2 +- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +++--- drivers/net/ethernet/toshiba/spider_net.c| 18 - drivers/net/xen-netback/xenbus.c | 4 +-- drivers/net/xen-netfront.c | 6 ++--- 8 files changed, 37 insertions(+), 32 deletions(-) Cc: Alexei Starovoitov Cc: Benjamin Herrenschmidt Cc: b...@vger.kernel.org Cc: Daniel Borkmann Cc: Dany Madden Cc: Daris A Nevil Cc: "David S. Miller" Cc: Erik Stahlman Cc: Geoff Levand Cc: Grygorii Strashko Cc: "Gustavo A. R. Silva" Cc: Ishizaki Kou Cc: Ivan Khoronzhuk Cc: Jakub Kicinski Cc: Jens Osterkamp Cc: Jesper Dangaard Brouer Cc: John Allen Cc: John Fastabend Cc: Kurt Kanzenbach Cc: Lijun Pan Cc: linuxppc-dev@lists.ozlabs.org Cc: Michael Ellerman Cc: net...@vger.kernel.org Cc: Nicolas Pitre Cc: Paul Durrant Cc: Paul Mackerras Cc: Peter Cammaert Cc: Russell King Cc: Rusty Russell Cc: Santiago Leon Cc: Sukadev Bhattiprolu Cc: Thomas Falcon Cc: Utz Bacher Cc: Wei Liu Cc: xen-de...@lists.xenproject.org -- 2.25.1
[PATCH 5/7] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours
Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'skb' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_len' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_field' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'scrq_arr' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'num_entries' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'adapter' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'rwi' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'reset_state' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'adapter' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'rwi' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'reset_state' not described in 'do_reset' Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: net...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ibm/ibmvnic.c | 27 +-- drivers/net/xen-netfront.c | 6 +++--- 2 files changed, 16 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index aed985e08e8ad..4c4252e68de5a 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1384,10 +1384,10 @@ static int ibmvnic_close(struct net_device *netdev) /** * build_hdr_data - creates L2/L3/L4 header data buffer - * @hdr_field - bitfield determining needed headers - * @skb - socket buffer - * @hdr_len - array of header lengths - * @tot_len - total length of data + * @hdr_field: bitfield determining needed headers + * @skb: socket buffer + * @hdr_len: array of header lengths + * @hdr_data: buffer to write the header to * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1444,11 +1444,11 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors - * @hdr_field - bitfield determining needed headers - * @data - buffer containing header data - * @len - length of data buffer - * @hdr_len - array of individual header lengths - * @scrq_arr - descriptor array + * @hdr_field: bitfield determining needed headers + * @hdr_data: buffer containing header data + * @len: length of data buffer + * @hdr_len: array of individual header lengths + * @scrq_arr: descriptor array * * Creates header and, if needed, header extension descriptors and * places them in a descriptor array, scrq_arr @@ -1496,10 +1496,9 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb - socket buffer - * @num_entries - number of descriptors to be sent - * @subcrq - first TX descriptor - * @hdr_field - bit field determining which headers will be sent + * @txbuff: tx buffer + * @num_entries: number of descriptors to be sent + * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descri
Re: [PATCH 5/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours
On Sun, 29 Nov 2020, Andrew Lunn wrote:
> Hi Lee
>
> > /**
> > * build_hdr_data - creates L2/L3/L4 header data buffer
> > - * @hdr_field - bitfield determining needed headers
> > - * @skb - socket buffer
> > - * @hdr_len - array of header lengths
> > - * @tot_len - total length of data
> > + * @hdr_field: bitfield determining needed headers
> > + * @skb: socket buffer
> > + * @hdr_len: array of header lengths
> > + * @tot_len: total length of data
> > *
> > * Reads hdr_field to determine which headers are needed by firmware.
> > * Builds a buffer containing these headers. Saves individual header
>
> The code is:
>
> static int build_hdr_data(u8 hdr_field, struct sk_buff *skb,
> int *hdr_len, u8 *hdr_data)
> {
>
> What about hdr_data?
>
> > /**
> > * create_hdr_descs - create header and header extension descriptors
> > - * @hdr_field - bitfield determining needed headers
> > - * @data - buffer containing header data
> > - * @len - length of data buffer
> > - * @hdr_len - array of individual header lengths
> > - * @scrq_arr - descriptor array
> > + * @hdr_field: bitfield determining needed headers
> > + * @data: buffer containing header data
> > + * @len: length of data buffer
> > + * @hdr_len: array of individual header lengths
> > + * @scrq_arr: descriptor array
>
> static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len,
> union sub_crq *scrq_arr)
>
> There is no data parameter.
>
> It looks like you just changes - to :, but did not validate the
> parameters are actually correct.
Right. This is a 'quirk' of my current process.
I build once, then use a script to parse the output, fixing each
issue in the order the compiler presents them. Then, either after
fixing a reasonable collection, or all issues, I re-run the compile
and fix the next batch (if any).
This patch is only fixing the formatting issue(s). As you've seen,
there is a subsequent patch in the series which fixes the disparity.
I can squash them though. No problem.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 8/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues
On Sun, 29 Nov 2020, Andrew Lunn wrote: > On Thu, Nov 26, 2020 at 01:38:53PM +0000, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > from drivers/net/ethernet/ibm/ibmvnic.c:35: > > inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: > > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or > > member 'hdr_data' not described in 'build_hdr_data' > > drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Excess function > > parameter 'tot_len' description in 'build_hdr_data' > > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or > > member 'hdr_data' not described in 'create_hdr_descs' > > drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Excess function > > parameter 'data' description in 'create_hdr_descs' > > drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or > > member 'txbuff' not described in 'build_hdr_descs_arr' > > drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function > > parameter 'skb' description in 'build_hdr_descs_arr' > > drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function > > parameter 'subcrq' description in 'build_hdr_descs_arr' > > Hi Lee > > It looks like this should be squashed into the previous patch to this > file. It certainly looks that way. Will fix. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
[PATCH 8/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues
Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Excess function parameter 'tot_len' description in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Excess function parameter 'data' description in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function parameter 'skb' description in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function parameter 'subcrq' description in 'build_hdr_descs_arr' Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: linuxppc-dev@lists.ozlabs.org Cc: net...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ibm/ibmvnic.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 36ea37721e3c8..0687f6cb0c7a2 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1379,7 +1379,7 @@ static int ibmvnic_close(struct net_device *netdev) * @hdr_field: bitfield determining needed headers * @skb: socket buffer * @hdr_len: array of header lengths - * @tot_len: total length of data + * @hdr_data: buffer to write the header to * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1437,7 +1437,7 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors * @hdr_field: bitfield determining needed headers - * @data: buffer containing header data + * @hdr_data: buffer containing header data * @len: length of data buffer * @hdr_len: array of individual header lengths * @scrq_arr: descriptor array @@ -1488,9 +1488,8 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb: socket buffer + * @txbuff: tx buffer * @num_entries: number of descriptors to be sent - * @subcrq: first TX descriptor * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descriptor array with applicable -- 2.25.1
[PATCH 6/8] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter
or member 'irq' not described in 'gelic_card_interrupt'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter
or member 'ptr' not described in 'gelic_card_interrupt'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1407: warning: Function parameter
or member 'txqueue' not described in 'gelic_net_tx_timeout'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1439: warning: Function parameter
or member 'napi' not described in 'gelic_ether_setup_netdev_ops'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1639: warning: Function parameter
or member 'dev' not described in 'ps3_gelic_driver_probe'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1795: warning: Function parameter
or member 'dev' not described in 'ps3_gelic_driver_remove'
Cc: Geoff Levand
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Michael Ellerman
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Utz Bacher
Cc: Jens Osterkamp
Cc: net...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
index d9a5722f561b5..f886e23f8ed0a 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
@@ -1100,7 +1100,7 @@ static int gelic_net_poll(struct napi_struct *napi, int
budget)
return packets_done;
}
-/**
+/*
* gelic_card_interrupt - event handler for gelic_net
*/
static irqreturn_t gelic_card_interrupt(int irq, void *ptr)
@@ -1400,6 +1400,7 @@ static void gelic_net_tx_timeout_task(struct work_struct
*work)
/**
* gelic_net_tx_timeout - called when the tx timeout watchdog kicks in.
* @netdev: interface device structure
+ * @txqueue: unused
*
* called, if tx hangs. Schedules a task that resets the interface
*/
@@ -1431,6 +1432,7 @@ static const struct net_device_ops gelic_netdevice_ops = {
/**
* gelic_ether_setup_netdev_ops - initialization of net_device operations
* @netdev: net_device structure
+ * @napi: napi structure
*
* fills out function pointers in the net_device structure
*/
@@ -1632,7 +1634,7 @@ static void gelic_card_get_vlan_info(struct gelic_card
*card)
dev_info(ctodev(card), "internal vlan %s\n",
card->vlan_required? "enabled" : "disabled");
}
-/**
+/*
* ps3_gelic_driver_probe - add a device to the control of this driver
*/
static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev)
@@ -1787,10 +1789,9 @@ static int ps3_gelic_driver_probe(struct
ps3_system_bus_device *dev)
return result;
}
-/**
+/*
* ps3_gelic_driver_remove - remove a device from the control of this driver
*/
-
static int ps3_gelic_driver_remove(struct ps3_system_bus_device *dev)
{
struct gelic_card *card = ps3_system_bus_get_drvdata(dev);
--
2.25.1
[PATCH 5/8] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours
Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'skb' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_len' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_field' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'scrq_arr' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'num_entries' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'adapter' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'rwi' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'reset_state' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'adapter' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'rwi' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'reset_state' not described in 'do_reset' Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: net...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ibm/ibmvnic.c | 28 ++-- drivers/net/xen-netfront.c | 6 +++--- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index b0884eba568d7..36ea37721e3c8 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1376,10 +1376,10 @@ static int ibmvnic_close(struct net_device *netdev) /** * build_hdr_data - creates L2/L3/L4 header data buffer - * @hdr_field - bitfield determining needed headers - * @skb - socket buffer - * @hdr_len - array of header lengths - * @tot_len - total length of data + * @hdr_field: bitfield determining needed headers + * @skb: socket buffer + * @hdr_len: array of header lengths + * @tot_len: total length of data * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1436,11 +1436,11 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors - * @hdr_field - bitfield determining needed headers - * @data - buffer containing header data - * @len - length of data buffer - * @hdr_len - array of individual header lengths - * @scrq_arr - descriptor array + * @hdr_field: bitfield determining needed headers + * @data: buffer containing header data + * @len: length of data buffer + * @hdr_len: array of individual header lengths + * @scrq_arr: descriptor array * * Creates header and, if needed, header extension descriptors and * places them in a descriptor array, scrq_arr @@ -1488,10 +1488,10 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb - socket buffer - * @num_entries - number of descriptors to be sent - * @subcrq - first TX descriptor - * @hdr_field - bit field determining which headers will be sent + * @skb: socket buffer + * @num_entries: number of descriptors to be sent + * @subcrq: first TX descriptor + * @hdr_field: bit field determining which headers will be sent * * This function will
[PATCH 0/8] Rid W=1 warnings in Net
Resending the stragglers. This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (8): net: ethernet: smsc: smc91x: Demote non-conformant kernel function header net: xen-netback: xenbus: Demote nonconformant kernel-doc headers net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues drivers/net/ethernet/ibm/ibmvnic.c | 27 ++-- drivers/net/ethernet/smsc/smc91x.c | 2 +- drivers/net/ethernet/ti/am65-cpsw-qos.c | 2 +- drivers/net/ethernet/ti/am65-cpts.c | 2 +- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 9 --- drivers/net/ethernet/toshiba/spider_net.c| 18 - drivers/net/xen-netback/xenbus.c | 4 +-- drivers/net/xen-netfront.c | 6 ++--- 8 files changed, 37 insertions(+), 33 deletions(-) Cc: Alexei Starovoitov Cc: Benjamin Herrenschmidt Cc: b...@vger.kernel.org Cc: Daniel Borkmann Cc: Dany Madden Cc: Daris A Nevil Cc: "David S. Miller" Cc: Erik Stahlman Cc: Geoff Levand Cc: Grygorii Strashko Cc: "Gustavo A. R. Silva" Cc: Ishizaki Kou Cc: Ivan Khoronzhuk Cc: Jakub Kicinski Cc: Jens Osterkamp Cc: Jesper Dangaard Brouer Cc: John Allen Cc: John Fastabend Cc: Kurt Kanzenbach Cc: Lijun Pan Cc: linuxppc-dev@lists.ozlabs.org Cc: Michael Ellerman Cc: net...@vger.kernel.org Cc: Nicolas Pitre Cc: Paul Durrant Cc: Paul Mackerras Cc: Peter Cammaert Cc: Russell King Cc: Rusty Russell Cc: Santiago Leon Cc: Sukadev Bhattiprolu Cc: Thomas Falcon Cc: Utz Bacher Cc: Wei Liu Cc: xen-de...@lists.xenproject.org -- 2.25.1
[PATCH v2 31/36] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location
Fixes the following W=1 kernel build warning(s): drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for ‘hvc_vio_init_early’ [-Wmissing-prototypes] 385 | void __init hvc_vio_init_early(void) | ^~ Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Michael Ellerman --- v2: - Removed 'extern' keyword arch/powerpc/include/asm/hvconsole.h | 3 +++ arch/powerpc/platforms/pseries/pseries.h | 3 --- arch/powerpc/platforms/pseries/setup.c | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/hvconsole.h b/arch/powerpc/include/asm/hvconsole.h index 999ed5ac90531..ccb2034506f0f 100644 --- a/arch/powerpc/include/asm/hvconsole.h +++ b/arch/powerpc/include/asm/hvconsole.h @@ -24,5 +24,8 @@ extern int hvc_get_chars(uint32_t vtermno, char *buf, int count); extern int hvc_put_chars(uint32_t vtermno, const char *buf, int count); +/* Provided by HVC VIO */ +void hvc_vio_init_early(void); + #endif /* __KERNEL__ */ #endif /* _PPC64_HVCONSOLE_H */ diff --git a/arch/powerpc/platforms/pseries/pseries.h b/arch/powerpc/platforms/pseries/pseries.h index 593840847cd3d..693f58d784b5b 100644 --- a/arch/powerpc/platforms/pseries/pseries.h +++ b/arch/powerpc/platforms/pseries/pseries.h @@ -43,9 +43,6 @@ extern void pSeries_final_fixup(void); /* Poweron flag used for enabling auto ups restart */ extern unsigned long rtas_poweron_auto; -/* Provided by HVC VIO */ -extern void hvc_vio_init_early(void); - /* Dynamic logical Partitioning/Mobility */ extern void dlpar_free_cc_nodes(struct device_node *); extern void dlpar_free_cc_property(struct property *); diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index 090c13f6c8815..b5513eefd12c9 100644 --- a/arch/powerpc/platforms/pseries/setup.c +++ b/arch/powerpc/platforms/pseries/setup.c @@ -71,6 +71,7 @@ #include #include #include +#include #include "pseries.h" #include "../../../../drivers/pci/pci.h" -- 2.25.1
Re: [PATCH v3 23/23] mtd: devices: powernv_flash: Add function names to headers and fix 'dev'
On Thu, 19 Nov 2020, Miquel Raynal wrote: > On Mon, 2020-11-09 at 18:22:06 UTC, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * > > @mtd: the device > > drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * > > @mtd: the device > > drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * > > @mtd: the device > > drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or > > member 'dev' not described in 'powernv_flash_set_driver_info' > > > > Cc: Miquel Raynal > > Cc: Richard Weinberger > > Cc: Vignesh Raghavendra > > Cc: Michael Ellerman > > Cc: Benjamin Herrenschmidt > > Cc: Paul Mackerras > > Cc: linux-...@lists.infradead.org > > Cc: linuxppc-dev@lists.ozlabs.org > > Signed-off-by: Lee Jones > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git > nand/next, thanks. Superstar. Thanks for your help Miquel. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function attribute 'addr'
On Thu, 12 Nov 2020, Leo Li wrote:
>
>
> > -Original Message-
> > From: Lee Jones
> > Sent: Thursday, November 12, 2020 4:33 AM
> > To: linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org;
> > Qiang Zhao ; Leo Li ; Scott
> > Wood ; act ; Dan Malek
> > ; Software, Inc ; Vitaly
> > Bordug ; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function
> > attribute 'addr'
> >
> > On Tue, 03 Nov 2020, Lee Jones wrote:
> >
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > drivers/soc/fsl/qe/qe_common.c:237: warning: Function parameter or
> > member 'addr' not described in 'cpm_muram_dma'
> > > drivers/soc/fsl/qe/qe_common.c:237: warning: Excess function parameter
> > 'offset' description in 'cpm_muram_dma'
> > >
> > > Cc: Qiang Zhao
> > > Cc: Li Yang
> > > Cc: Scott Wood
> > > Cc: act
> > > Cc: Dan Malek
> > > Cc: "Software, Inc"
> > > Cc: Vitaly Bordug
> > > Cc: linuxppc-dev@lists.ozlabs.org
> > > Signed-off-by: Lee Jones
> > > ---
> > > drivers/soc/fsl/qe/qe_common.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/soc/fsl/qe/qe_common.c
> > > b/drivers/soc/fsl/qe/qe_common.c index 75075591f6308..497a7e0fd0272
> > > 100644
> > > --- a/drivers/soc/fsl/qe/qe_common.c
> > > +++ b/drivers/soc/fsl/qe/qe_common.c
> > > @@ -231,7 +231,7 @@ EXPORT_SYMBOL(cpm_muram_offset);
> > >
> > > /**
> > > * cpm_muram_dma - turn a muram virtual address into a DMA address
> > > - * @offset: virtual address from cpm_muram_addr() to convert
> > > + * @addr: virtual address from cpm_muram_addr() to convert
> > > */
> > > dma_addr_t cpm_muram_dma(void __iomem *addr) {
> >
> > Any idea who will pick this up?
>
> I can pick them up through my tree, but I haven't created the
> for-next branch for the next kernel yet. Will look through this
> series soon. Thanks.
Thank you Leo.
There's not rush. Just trying to ensure they don't get forgotten.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
[PATCH v2 4/4] tty: serial: pmac_zilog: Remove unused disposable variable 'garbage'
Fixes the following W=1 kernel build warning(s):
drivers/tty/serial/pmac_zilog.h:365:58: warning: variable ‘garbage’ set but
not used [-Wunused-but-set-variable]
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: Michael Ellerman
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linux-ser...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
drivers/tty/serial/pmac_zilog.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/pmac_zilog.h b/drivers/tty/serial/pmac_zilog.h
index bb874e76810e0..fa85b0de5c2fd 100644
--- a/drivers/tty/serial/pmac_zilog.h
+++ b/drivers/tty/serial/pmac_zilog.h
@@ -362,10 +362,10 @@ static inline void zssync(struct uart_pmac_port *port)
/* Misc macros */
#define ZS_CLEARERR(port)(write_zsreg(port, 0, ERR_RES))
-#define ZS_CLEARFIFO(port) do { volatile unsigned char garbage; \
-garbage = read_zsdata(port); \
-garbage = read_zsdata(port); \
-garbage = read_zsdata(port); \
+#define ZS_CLEARFIFO(port) do { \
+read_zsdata(port); \
+read_zsdata(port); \
+read_zsdata(port); \
} while(0)
#define ZS_IS_CONS(UP) ((UP)->flags & PMACZILOG_FLAG_IS_CONS)
--
2.25.1
[PATCH v2 3/4] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location
Fixes the following W=1 kernel build warning(s): drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for ‘hvc_vio_init_early’ [-Wmissing-prototypes] 385 | void __init hvc_vio_init_early(void) | ^~ Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones Acked-by: Michael Ellerman --- arch/powerpc/include/asm/hvconsole.h | 3 +++ arch/powerpc/platforms/pseries/pseries.h | 3 --- arch/powerpc/platforms/pseries/setup.c | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/hvconsole.h b/arch/powerpc/include/asm/hvconsole.h index 999ed5ac90531..ccb2034506f0f 100644 --- a/arch/powerpc/include/asm/hvconsole.h +++ b/arch/powerpc/include/asm/hvconsole.h @@ -24,5 +24,8 @@ extern int hvc_get_chars(uint32_t vtermno, char *buf, int count); extern int hvc_put_chars(uint32_t vtermno, const char *buf, int count); +/* Provided by HVC VIO */ +void hvc_vio_init_early(void); + #endif /* __KERNEL__ */ #endif /* _PPC64_HVCONSOLE_H */ diff --git a/arch/powerpc/platforms/pseries/pseries.h b/arch/powerpc/platforms/pseries/pseries.h index 13fa370a87e4e..7be5b054dfc36 100644 --- a/arch/powerpc/platforms/pseries/pseries.h +++ b/arch/powerpc/platforms/pseries/pseries.h @@ -43,9 +43,6 @@ extern void pSeries_final_fixup(void); /* Poweron flag used for enabling auto ups restart */ extern unsigned long rtas_poweron_auto; -/* Provided by HVC VIO */ -extern void hvc_vio_init_early(void); - /* Dynamic logical Partitioning/Mobility */ extern void dlpar_free_cc_nodes(struct device_node *); extern void dlpar_free_cc_property(struct property *); diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index 633c45ec406da..6999b83f06612 100644 --- a/arch/powerpc/platforms/pseries/setup.c +++ b/arch/powerpc/platforms/pseries/setup.c @@ -71,6 +71,7 @@ #include #include #include +#include #include "pseries.h" #include "../../../../drivers/pci/pci.h" -- 2.25.1
[PATCH v2 0/4] Rid W=1 issues from TTY
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. v2: - Remove unused variable completely - Remove unnecessary 'extern' keyword Lee Jones (4): tty: tty_ldisc: Fix some kernel-doc related misdemeanours tty: serial: 8250: 8250_port: Move prototypes to shared location powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location tty: serial: pmac_zilog: Remove unused disposable variable 'garbage' arch/powerpc/include/asm/hvconsole.h | 3 +++ arch/powerpc/platforms/pseries/pseries.h | 3 --- arch/powerpc/platforms/pseries/setup.c | 1 + drivers/tty/serial/8250/8250_early.c | 3 --- drivers/tty/serial/pmac_zilog.h | 8 drivers/tty/tty_ldisc.c | 10 +- include/linux/serial_8250.h | 5 + 7 files changed, 18 insertions(+), 15 deletions(-) Cc: Benjamin Herrenschmidt Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-ser...@vger.kernel.org Cc: Michael Ellerman Cc: Mike Hudson Cc: Paul Mackerras -- 2.25.1
Re: [PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function attribute 'addr'
On Tue, 03 Nov 2020, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/soc/fsl/qe/qe_common.c:237: warning: Function parameter or member
> 'addr' not described in 'cpm_muram_dma'
> drivers/soc/fsl/qe/qe_common.c:237: warning: Excess function parameter
> 'offset' description in 'cpm_muram_dma'
>
> Cc: Qiang Zhao
> Cc: Li Yang
> Cc: Scott Wood
> Cc: act
> Cc: Dan Malek
> Cc: "Software, Inc"
> Cc: Vitaly Bordug
> Cc: linuxppc-dev@lists.ozlabs.org
> Signed-off-by: Lee Jones
> ---
> drivers/soc/fsl/qe/qe_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/fsl/qe/qe_common.c b/drivers/soc/fsl/qe/qe_common.c
> index 75075591f6308..497a7e0fd0272 100644
> --- a/drivers/soc/fsl/qe/qe_common.c
> +++ b/drivers/soc/fsl/qe/qe_common.c
> @@ -231,7 +231,7 @@ EXPORT_SYMBOL(cpm_muram_offset);
>
> /**
> * cpm_muram_dma - turn a muram virtual address into a DMA address
> - * @offset: virtual address from cpm_muram_addr() to convert
> + * @addr: virtual address from cpm_muram_addr() to convert
> */
> dma_addr_t cpm_muram_dma(void __iomem *addr)
> {
Any idea who will pick this up?
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
[PATCH 3/3] hwmon: ibmpowernv: Silence strncpy() warning
Fixes the following W=1 kernel build warning(s): from drivers/hwmon/ibmpowernv.c:11: In function ‘strncpy’, inlined from ‘get_sensor_index_attr’ at drivers/hwmon/ibmpowernv.c:243:2, inlined from ‘create_device_attrs’ at drivers/hwmon/ibmpowernv.c:280:8: include/linux/string.h:297:30: warning: ‘__builtin_strncpy’ specified bound 32 equals destination size [-Wstringop-truncation] 297 | #define __underlying_strncpy __builtin_strncpy | ^ include/linux/string.h:307:9: note: in expansion of macro ‘__underlying_strncpy’ 307 | return __underlying_strncpy(p, q, size); | ^~~~ Cc: Jean Delvare Cc: Guenter Roeck Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Neelesh Gupta Cc: linux-hw...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/hwmon/ibmpowernv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/ibmpowernv.c b/drivers/hwmon/ibmpowernv.c index a750647e66a47..8e3724728cce0 100644 --- a/drivers/hwmon/ibmpowernv.c +++ b/drivers/hwmon/ibmpowernv.c @@ -240,7 +240,7 @@ static int get_sensor_index_attr(const char *name, u32 *index, char *attr) if (err) return err; - strncpy(attr, dash_pos + 1, MAX_ATTR_LEN); + strscpy(attr, dash_pos + 1, MAX_ATTR_LEN); return 0; } -- 2.25.1
[PATCH 0/3] Rid W=1 warnings from HWMON
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (3): hwmon: adm1177: Fix kerneldoc attribute formatting hwmon: ina3221: Demote seemingly unintentional kerneldoc header hwmon: ibmpowernv: Silence strncpy() warning drivers/hwmon/adm1177.c| 10 +- drivers/hwmon/ibmpowernv.c | 2 +- drivers/hwmon/ina3221.c| 2 +- 3 files changed, 7 insertions(+), 7 deletions(-) Cc: "Andrew F. Davis" Cc: Beniamin Bia Cc: Benjamin Herrenschmidt Cc: Guenter Roeck Cc: Jean Delvare Cc: linux-hw...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: Michael Ellerman Cc: Michael Hennerich Cc: Neelesh Gupta Cc: Paul Mackerras -- 2.25.1
[PATCH v3 23/23] mtd: devices: powernv_flash: Add function names to headers and fix 'dev'
Fixes the following W=1 kernel build warning(s): drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or member 'dev' not described in 'powernv_flash_set_driver_info' Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linux-...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/mtd/devices/powernv_flash.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c index 0b757d9ba2f6b..6950a87648151 100644 --- a/drivers/mtd/devices/powernv_flash.c +++ b/drivers/mtd/devices/powernv_flash.c @@ -126,6 +126,7 @@ static int powernv_flash_async_op(struct mtd_info *mtd, enum flash_op op, } /** + * powernv_flash_read * @mtd: the device * @from: the offset to read from * @len: the number of bytes to read @@ -142,6 +143,7 @@ static int powernv_flash_read(struct mtd_info *mtd, loff_t from, size_t len, } /** + * powernv_flash_write * @mtd: the device * @to: the offset to write to * @len: the number of bytes to write @@ -158,6 +160,7 @@ static int powernv_flash_write(struct mtd_info *mtd, loff_t to, size_t len, } /** + * powernv_flash_erase * @mtd: the device * @erase: the erase info * Returns 0 if erase successful or -ERRNO if an error occurred @@ -176,7 +179,7 @@ static int powernv_flash_erase(struct mtd_info *mtd, struct erase_info *erase) /** * powernv_flash_set_driver_info - Fill the mtd_info structure and docg3 - * structure @pdev: The platform device + * @dev: The device structure * @mtd: The structure to fill */ static int powernv_flash_set_driver_info(struct device *dev, -- 2.25.1
[PATCH v3 00/23] Rid W=1 warnings in MTD
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. v2 => v3: - Reworded subject lines v1 => v2: - Added tags - Satisfied Miquel's review comments Lee Jones (23): mtd: mtdpart: Fix misdocumented function parameter 'mtd' mtd: devices: phram: File headers are not good candidates for kernel-doc mtd: onenand: onenand_base: Fix expected kernel-doc formatting mtd: devices: docg3: Fix kernel-doc 'bad line' and 'excessive doc' issues mtd: Fix misspelled function parameter 'section' mtd: onenand: onenand_bbt: Fix expected kernel-doc formatting mtd: spi-nor: hisi-sfc: Demote non-conformant kernel-doc mtd: ubi: build: Document 'ubi_num' in struct mtd_dev_param mtd: spinand: toshiba: Demote non-conformant kernel-doc header mtd: ubi: kapi: Correct documentation for 'ubi_leb_read_sg's 'sgl' parameter mtd: ubi: eba: Fix a couple of misdocumentation issues mtd: ubi: wl: Fix a couple of kernel-doc issues mtd: rawnand: brcmnand: Demote non-conformant kernel-doc headers mtd: ubi: gluebi: Fix misnamed function parameter documentation mtd: rawnand: diskonchip: Marking unused variables as __always_unused mtd: rawnand: cafe_nand: Remove superfluous param doc and add another mtd: rawnand: s3c2410: Add documentation for 2 missing struct members mtd: rawnand: omap_elm: Finish half populated function header, demote empty ones mtd: rawnand: omap2: Fix a bunch of kernel-doc misdemeanours mtd: rawnand: sunxi: Document 'sunxi_nfc's 'caps' member mtd: rawnand: arasan: Document 'anfc_op's 'buf' member mtd: onenand: Fix some kernel-doc misdemeanours mtd: devices: powernv_flash: Add function names to headers and fix 'dev' drivers/mtd/devices/docg3.c | 5 +- drivers/mtd/devices/phram.c | 2 +- drivers/mtd/devices/powernv_flash.c | 5 +- drivers/mtd/mtdcore.c | 2 +- drivers/mtd/mtdpart.c | 2 +- drivers/mtd/nand/onenand/onenand_base.c | 444 +- drivers/mtd/nand/onenand/onenand_bbt.c| 32 +- drivers/mtd/nand/raw/arasan-nand-controller.c | 1 + drivers/mtd/nand/raw/brcmnand/brcmnand.c | 6 +- drivers/mtd/nand/raw/cafe_nand.c | 2 +- drivers/mtd/nand/raw/diskonchip.c | 4 +- drivers/mtd/nand/raw/omap2.c | 18 +- drivers/mtd/nand/raw/omap_elm.c | 7 +- drivers/mtd/nand/raw/s3c2410.c| 4 +- drivers/mtd/nand/raw/sunxi_nand.c | 1 + drivers/mtd/nand/spi/toshiba.c| 2 +- drivers/mtd/spi-nor/controllers/hisi-sfc.c| 2 +- drivers/mtd/ubi/build.c | 1 + drivers/mtd/ubi/eba.c | 3 +- drivers/mtd/ubi/gluebi.c | 2 +- drivers/mtd/ubi/kapi.c| 2 +- drivers/mtd/ubi/wl.c | 3 +- 22 files changed, 278 insertions(+), 272 deletions(-) Cc: Adrian Hunter Cc: bcm-kernel-feedback-l...@broadcom.com Cc: Ben Dooks Cc: Benjamin Herrenschmidt Cc: Boris BREZILLON Cc: Boris Brezillon Cc: Brian Norris Cc: Chen-Yu Tsai Cc: Choudary Kalluri Cc: "Christian König" Cc: Dan Brown Cc: David Woodhouse Cc: Dmitriy B Cc: dri-de...@lists.freedesktop.org Cc: Frieder Schrempf Cc: Jian Zhang Cc: "Jochen Schäuble" Cc: Kamal Dasu Cc: Krzysztof Kozlowski Cc: Kukjin Kim Cc: Kyungmin Park Cc: linaro-mm-...@lists.linaro.org Cc: linux-me...@vger.kernel.org Cc: linux-...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-samsung-...@vger.kernel.org Cc: Maxime Ripard Cc: Michael Ellerman Cc: Miquel Raynal Cc: Naga Sureshkumar Relli Cc: Nicolas Pitre Cc: Paul Mackerras Cc: Philipp Zabel Cc: Qiang Yu Cc: Richard Weinberger Cc: Robert Jarzmik Cc: Sergey Lapin Cc: Sumit Semwal Cc: Thomas Gleixner Cc: Thomas Gleixner Cc: Tudor Ambarus Cc: Vignesh Raghavendra Cc: Yoshio Furuyama -- 2.25.1
[PATCH v2 23/23] mtd: devices: powernv_flash: Add function names to headers and fix 'dev'
Fixes the following W=1 kernel build warning(s): drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or member 'dev' not described in 'powernv_flash_set_driver_info' Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linux-...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/mtd/devices/powernv_flash.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c index 0b757d9ba2f6b..6950a87648151 100644 --- a/drivers/mtd/devices/powernv_flash.c +++ b/drivers/mtd/devices/powernv_flash.c @@ -126,6 +126,7 @@ static int powernv_flash_async_op(struct mtd_info *mtd, enum flash_op op, } /** + * powernv_flash_read * @mtd: the device * @from: the offset to read from * @len: the number of bytes to read @@ -142,6 +143,7 @@ static int powernv_flash_read(struct mtd_info *mtd, loff_t from, size_t len, } /** + * powernv_flash_write * @mtd: the device * @to: the offset to write to * @len: the number of bytes to write @@ -158,6 +160,7 @@ static int powernv_flash_write(struct mtd_info *mtd, loff_t to, size_t len, } /** + * powernv_flash_erase * @mtd: the device * @erase: the erase info * Returns 0 if erase successful or -ERRNO if an error occurred @@ -176,7 +179,7 @@ static int powernv_flash_erase(struct mtd_info *mtd, struct erase_info *erase) /** * powernv_flash_set_driver_info - Fill the mtd_info structure and docg3 - * structure @pdev: The platform device + * @dev: The device structure * @mtd: The structure to fill */ static int powernv_flash_set_driver_info(struct device *dev, -- 2.25.1
[PATCH v2 00/23] Rid W=1 warnings in MTD
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. v1 => v2: - Added tags - Satisfied Miquel's review comments Lee Jones (23): mtd: mtdpart: Fix misdocumented function parameter 'mtd' mtd: devices: phram: File headers are not good candidates for kernel-doc mtd: nand: onenand: onenand_base: Fix expected kernel-doc formatting mtd: devices: docg3: Fix kernel-doc 'bad line' and 'excessive doc' issues mtd: mtdcore: Fix misspelled function parameter 'section' mtd: nand: onenand: onenand_bbt: Fix expected kernel-doc formatting mtd: spi-nor: controllers: hisi-sfc: Demote non-conformant kernel-doc mtd: ubi: build: Document 'ubi_num' in struct mtd_dev_param mtd: nand: spi: toshiba: Demote non-conformant kernel-doc header mtd: ubi: kapi: Correct documentation for 'ubi_leb_read_sg's 'sgl' parameter mtd: ubi: eba: Fix a couple of misdocumentation issues mtd: ubi: wl: Fix a couple of kernel-doc issues mtd: nand: raw: brcmnand: brcmnand: Demote non-conformant kernel-doc headers mtd: ubi: gluebi: Fix misnamed function parameter documentation mtd: nand: raw: diskonchip: Marking unused variables as __always_unused mtd: nand: raw: cafe_nand: Remove superfluous param doc and add another mtd: nand: raw: s3c2410: Add documentation for 2 missing struct members mtd: nand: raw: omap_elm: Finish half populated function header, demote empty ones mtd: nand: raw: omap2: Fix a bunch of kernel-doc misdemeanours mtd: nand: raw: sunxi_nand: Document 'sunxi_nfc's 'caps' member mtd: nand: raw: arasan-nand-controller: Document 'anfc_op's 'buf' member mtd: nand: onenand: onenand_base: Fix some kernel-doc misdemeanours mtd: devices: powernv_flash: Add function names to headers and fix 'dev' drivers/mtd/devices/docg3.c | 5 +- drivers/mtd/devices/phram.c | 2 +- drivers/mtd/devices/powernv_flash.c | 5 +- drivers/mtd/mtdcore.c | 2 +- drivers/mtd/mtdpart.c | 2 +- drivers/mtd/nand/onenand/onenand_base.c | 444 +- drivers/mtd/nand/onenand/onenand_bbt.c| 32 +- drivers/mtd/nand/raw/arasan-nand-controller.c | 1 + drivers/mtd/nand/raw/brcmnand/brcmnand.c | 6 +- drivers/mtd/nand/raw/cafe_nand.c | 2 +- drivers/mtd/nand/raw/diskonchip.c | 4 +- drivers/mtd/nand/raw/omap2.c | 18 +- drivers/mtd/nand/raw/omap_elm.c | 7 +- drivers/mtd/nand/raw/s3c2410.c| 4 +- drivers/mtd/nand/raw/sunxi_nand.c | 1 + drivers/mtd/nand/spi/toshiba.c| 2 +- drivers/mtd/spi-nor/controllers/hisi-sfc.c| 2 +- drivers/mtd/ubi/build.c | 1 + drivers/mtd/ubi/eba.c | 3 +- drivers/mtd/ubi/gluebi.c | 2 +- drivers/mtd/ubi/kapi.c| 2 +- drivers/mtd/ubi/wl.c | 3 +- 22 files changed, 278 insertions(+), 272 deletions(-) Cc: Adrian Hunter Cc: bcm-kernel-feedback-l...@broadcom.com Cc: Ben Dooks Cc: Benjamin Herrenschmidt Cc: Boris BREZILLON Cc: Boris Brezillon Cc: Brian Norris Cc: Chen-Yu Tsai Cc: Choudary Kalluri Cc: "Christian König" Cc: Dan Brown Cc: David Woodhouse Cc: Dmitriy B Cc: dri-de...@lists.freedesktop.org Cc: Frieder Schrempf Cc: Jian Zhang Cc: "Jochen Schäuble" Cc: Kamal Dasu Cc: Krzysztof Kozlowski Cc: Kukjin Kim Cc: Kyungmin Park Cc: linaro-mm-...@lists.linaro.org Cc: linux-me...@vger.kernel.org Cc: linux-...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-samsung-...@vger.kernel.org Cc: Maxime Ripard Cc: Michael Ellerman Cc: Miquel Raynal Cc: Naga Sureshkumar Relli Cc: Nicolas Pitre Cc: Paul Mackerras Cc: Philipp Zabel Cc: Qiang Yu Cc: Richard Weinberger Cc: Robert Jarzmik Cc: Sergey Lapin Cc: Sumit Semwal Cc: Thomas Gleixner Cc: Thomas Gleixner Cc: Tudor Ambarus Cc: Vignesh Raghavendra Cc: Yoshio Furuyama -- 2.25.1
Re: [PATCH 0/2] tty: Remove obsolete drivers
On Thu, 05 Nov 2020, Christophe Leroy wrote: > Hi, > > Le 05/11/2020 à 13:33, Lee Jones a écrit : > > As per the vendor's request. > > Is the vendor in copy of the patch ? Not directly. Only interested parties as indicated by `get_maintainer.pl` were included. My assumption is that he'd pick this set up in the same manner he picked up the last one (filters?). > What about the other synclink adapters, namely the synclink_gt ? And the > synclink_cs in the drivers/char/pcmcia/ ? Ref *_cs: If it wasn't directly mentioned, I've left it in place. Ref *_gt: "synclink_gt.c is still in production and the driver still actively used." > > Lee Jones (2): > >tty: Remove redundant synclink driver > >tty: Remove redundant synclinkmp driver > > > > arch/powerpc/configs/ppc6xx_defconfig |2 - > > drivers/tty/Kconfig | 27 - > > drivers/tty/Makefile |2 - > > drivers/tty/synclink.c| 7899 - > > drivers/tty/synclinkmp.c | 5580 - > > 5 files changed, 13510 deletions(-) > > delete mode 100644 drivers/tty/synclink.c > > delete mode 100644 drivers/tty/synclinkmp.c > > > > Cc: Benjamin Herrenschmidt > > Cc: Greg Kroah-Hartman > > Cc: Jiri Slaby > > Cc: linuxppc-dev@lists.ozlabs.org > > Cc: Michael Ellerman > > Cc: Paul Mackerras > > -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
[PATCH 0/2] tty: Remove obsolete drivers
As per the vendor's request. Lee Jones (2): tty: Remove redundant synclink driver tty: Remove redundant synclinkmp driver arch/powerpc/configs/ppc6xx_defconfig |2 - drivers/tty/Kconfig | 27 - drivers/tty/Makefile |2 - drivers/tty/synclink.c| 7899 - drivers/tty/synclinkmp.c | 5580 - 5 files changed, 13510 deletions(-) delete mode 100644 drivers/tty/synclink.c delete mode 100644 drivers/tty/synclinkmp.c Cc: Benjamin Herrenschmidt Cc: Greg Kroah-Hartman Cc: Jiri Slaby Cc: linuxppc-dev@lists.ozlabs.org Cc: Michael Ellerman Cc: Paul Mackerras -- 2.25.1
Re: [PATCH 34/36] tty: serial: pmac_zilog: Make disposable variable __always_unused
On Thu, 05 Nov 2020, Jiri Slaby wrote:
> On 05. 11. 20, 9:36, Lee Jones wrote:
> > On Thu, 05 Nov 2020, Jiri Slaby wrote:
> >
> > > On 05. 11. 20, 8:04, Christophe Leroy wrote:
> > > >
> > > >
> > > > Le 04/11/2020 à 20:35, Lee Jones a écrit :
> > > > > Fixes the following W=1 kernel build warning(s):
> > > > >
> > > > > drivers/tty/serial/pmac_zilog.h:365:58: warning: variable
> > > > > ‘garbage’ set but not used [-Wunused-but-set-variable]
> > > >
> > > > Explain how you are fixing this warning.
> > > >
> > > > Setting __always_unused is usually not the good solution for fixing
> > > > this warning, but here I guess this is likely the good solution. But it
> > > > should be explained why.
> >
> > There are normally 3 ways to fix this warning;
> >
> > - Start using/checking the variable/result
> > - Remove the variable
> > - Mark it as __{always,maybe}_unused
> >
> > The later just tells the compiler that not checking the resultant
> > value is intentional. There are some functions (as Jiri mentions
> > below) which are marked as '__must_check' which *require* a dummy
> > (garbage) variable to be used.
> >
> > > Or, why is the "garbage =" needed in the first place? read_zsdata is not
> > > defined with __warn_unused_result__.
> >
> > I used '__always_used' here for fear of breaking something.
> >
> > However, if it's safe to remove it, then all the better.
>
> Yes please -- this "garbage" is one of the examples of volatile misuses. If
> readb didn't work on volatile pointer, marking the return variable as
> volatile wouldn't save it.
>
> > > And even if it was, would (void)!read_zsdata(port) fix it?
> >
> > That's hideous. :D
>
> Sure, marking reads as must_check would be insane.
>
> > *Much* better to just use '__always_used' in that use-case.
>
> Then using a dummy variable to fool must_check must mean must_check is used
> incorrectly, no :)? But there are always exceptions…
Agreed on all points.
Will fix.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 31/36] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location
On Thu, 05 Nov 2020, Michael Ellerman wrote: > Lee Jones writes: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for > > ‘hvc_vio_init_early’ [-Wmissing-prototypes] > > 385 | void __init hvc_vio_init_early(void) > > | ^~ > > > > Cc: Michael Ellerman > > Cc: Benjamin Herrenschmidt > > Cc: Paul Mackerras > > Cc: linuxppc-dev@lists.ozlabs.org > > Signed-off-by: Lee Jones > > --- > > arch/powerpc/include/asm/hvconsole.h | 3 +++ > > arch/powerpc/platforms/pseries/pseries.h | 3 --- > > arch/powerpc/platforms/pseries/setup.c | 1 + > > 3 files changed, 4 insertions(+), 3 deletions(-) > > Acked-by: Michael Ellerman Thanks. > > diff --git a/arch/powerpc/include/asm/hvconsole.h > > b/arch/powerpc/include/asm/hvconsole.h > > index 999ed5ac90531..936a1ee1ac786 100644 > > --- a/arch/powerpc/include/asm/hvconsole.h > > +++ b/arch/powerpc/include/asm/hvconsole.h > > @@ -24,5 +24,8 @@ > > extern int hvc_get_chars(uint32_t vtermno, char *buf, int count); > > extern int hvc_put_chars(uint32_t vtermno, const char *buf, int count); > > > > +/* Provided by HVC VIO */ > > +extern void hvc_vio_init_early(void); > > extern isn't needed, but don't feel you need to respin just to drop it. That's fine. I don't mind re-spinning. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 31/36] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location
On Thu, 05 Nov 2020, Christophe Leroy wrote: > > > Le 04/11/2020 à 20:35, Lee Jones a écrit : > > Fixes the following W=1 kernel build warning(s): > > > > drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for > > ‘hvc_vio_init_early’ [-Wmissing-prototypes] > > 385 | void __init hvc_vio_init_early(void) > > | ^~ > > > > Cc: Michael Ellerman > > Cc: Benjamin Herrenschmidt > > Cc: Paul Mackerras > > Cc: linuxppc-dev@lists.ozlabs.org > > Signed-off-by: Lee Jones > > --- > > arch/powerpc/include/asm/hvconsole.h | 3 +++ > > arch/powerpc/platforms/pseries/pseries.h | 3 --- > > arch/powerpc/platforms/pseries/setup.c | 1 + > > 3 files changed, 4 insertions(+), 3 deletions(-) > > > > diff --git a/arch/powerpc/include/asm/hvconsole.h > > b/arch/powerpc/include/asm/hvconsole.h > > index 999ed5ac90531..936a1ee1ac786 100644 > > --- a/arch/powerpc/include/asm/hvconsole.h > > +++ b/arch/powerpc/include/asm/hvconsole.h > > @@ -24,5 +24,8 @@ > > extern int hvc_get_chars(uint32_t vtermno, char *buf, int count); > > extern int hvc_put_chars(uint32_t vtermno, const char *buf, int count); > > +/* Provided by HVC VIO */ > > +extern void hvc_vio_init_early(void); > > + > > Declaring a prototype 'extern' is pointless. Don't add new misuse of 'extern' > keyword. No new code (misuse or otherwise) is being added in this patch. It's just moved from one place to another. I can also strip out 'extern' if it's preferred. > > #endif /* __KERNEL__ */ > > #endif /* _PPC64_HVCONSOLE_H */ > > diff --git a/arch/powerpc/platforms/pseries/pseries.h > > b/arch/powerpc/platforms/pseries/pseries.h > > index 13fa370a87e4e..7be5b054dfc36 100644 > > --- a/arch/powerpc/platforms/pseries/pseries.h > > +++ b/arch/powerpc/platforms/pseries/pseries.h > > @@ -43,9 +43,6 @@ extern void pSeries_final_fixup(void); > > /* Poweron flag used for enabling auto ups restart */ > > extern unsigned long rtas_poweron_auto; > > -/* Provided by HVC VIO */ > > -extern void hvc_vio_init_early(void); > > - > > /* Dynamic logical Partitioning/Mobility */ > > extern void dlpar_free_cc_nodes(struct device_node *); > > extern void dlpar_free_cc_property(struct property *); > > diff --git a/arch/powerpc/platforms/pseries/setup.c > > b/arch/powerpc/platforms/pseries/setup.c > > index 633c45ec406da..6999b83f06612 100644 > > --- a/arch/powerpc/platforms/pseries/setup.c > > +++ b/arch/powerpc/platforms/pseries/setup.c > > @@ -71,6 +71,7 @@ > > #include > > #include > > #include > > +#include > > #include "pseries.h" > > #include "../../../../drivers/pci/pci.h" > > > > Christophe -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 34/36] tty: serial: pmac_zilog: Make disposable variable __always_unused
On Thu, 05 Nov 2020, Jiri Slaby wrote:
> On 05. 11. 20, 8:04, Christophe Leroy wrote:
> >
> >
> > Le 04/11/2020 à 20:35, Lee Jones a écrit :
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > drivers/tty/serial/pmac_zilog.h:365:58: warning: variable
> > > ‘garbage’ set but not used [-Wunused-but-set-variable]
> >
> > Explain how you are fixing this warning.
> >
> > Setting __always_unused is usually not the good solution for fixing
> > this warning, but here I guess this is likely the good solution. But it
> > should be explained why.
There are normally 3 ways to fix this warning;
- Start using/checking the variable/result
- Remove the variable
- Mark it as __{always,maybe}_unused
The later just tells the compiler that not checking the resultant
value is intentional. There are some functions (as Jiri mentions
below) which are marked as '__must_check' which *require* a dummy
(garbage) variable to be used.
> Or, why is the "garbage =" needed in the first place? read_zsdata is not
> defined with __warn_unused_result__.
I used '__always_used' here for fear of breaking something.
However, if it's safe to remove it, then all the better.
> And even if it was, would (void)!read_zsdata(port) fix it?
That's hideous. :D
*Much* better to just use '__always_used' in that use-case.
> > > Cc: Greg Kroah-Hartman
> > > Cc: Jiri Slaby
> > > Cc: Michael Ellerman
> > > Cc: Benjamin Herrenschmidt
> > > Cc: Paul Mackerras
> > > Cc: linux-ser...@vger.kernel.org
> > > Cc: linuxppc-dev@lists.ozlabs.org
> > > Signed-off-by: Lee Jones
> > > ---
> > > drivers/tty/serial/pmac_zilog.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/tty/serial/pmac_zilog.h
> > > b/drivers/tty/serial/pmac_zilog.h
> > > index bb874e76810e0..968aec7c1cf82 100644
> > > --- a/drivers/tty/serial/pmac_zilog.h
> > > +++ b/drivers/tty/serial/pmac_zilog.h
> > > @@ -362,7 +362,7 @@ static inline void zssync(struct uart_pmac_port
> > > *port)
> > > /* Misc macros */
> > > #define ZS_CLEARERR(port) (write_zsreg(port, 0, ERR_RES))
> > > -#define ZS_CLEARFIFO(port) do { volatile unsigned char garbage; \
> > > +#define ZS_CLEARFIFO(port) do { volatile unsigned char
> > > __always_unused garbage; \
> > > garbage = read_zsdata(port); \
> > > garbage = read_zsdata(port); \
> > > garbage = read_zsdata(port); \
> > >
>
> thanks,
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
[PATCH 33/36] tty: hvc: hvc_opal: Staticify function invoked by reference
Fixes the following W=1 kernel build warning(s):
drivers/tty/hvc/hvc_opal.c:106:6: warning: no previous prototype for
‘hvc_opal_hvsi_hangup’ [-Wmissing-prototypes]
Cc: Michael Ellerman
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
drivers/tty/hvc/hvc_opal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
index c66412566efce..056ae21a51214 100644
--- a/drivers/tty/hvc/hvc_opal.c
+++ b/drivers/tty/hvc/hvc_opal.c
@@ -103,7 +103,7 @@ static void hvc_opal_hvsi_close(struct hvc_struct *hp, int
data)
notifier_del_irq(hp, data);
}
-void hvc_opal_hvsi_hangup(struct hvc_struct *hp, int data)
+static void hvc_opal_hvsi_hangup(struct hvc_struct *hp, int data)
{
struct hvc_opal_priv *pv = hvc_opal_privs[hp->vtermno];
--
2.25.1
[PATCH 34/36] tty: serial: pmac_zilog: Make disposable variable __always_unused
Fixes the following W=1 kernel build warning(s):
drivers/tty/serial/pmac_zilog.h:365:58: warning: variable ‘garbage’ set but
not used [-Wunused-but-set-variable]
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: Michael Ellerman
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: linux-ser...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
drivers/tty/serial/pmac_zilog.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/pmac_zilog.h b/drivers/tty/serial/pmac_zilog.h
index bb874e76810e0..968aec7c1cf82 100644
--- a/drivers/tty/serial/pmac_zilog.h
+++ b/drivers/tty/serial/pmac_zilog.h
@@ -362,7 +362,7 @@ static inline void zssync(struct uart_pmac_port *port)
/* Misc macros */
#define ZS_CLEARERR(port)(write_zsreg(port, 0, ERR_RES))
-#define ZS_CLEARFIFO(port) do { volatile unsigned char garbage; \
+#define ZS_CLEARFIFO(port) do { volatile unsigned char __always_unused
garbage; \
garbage = read_zsdata(port); \
garbage = read_zsdata(port); \
garbage = read_zsdata(port); \
--
2.25.1
[PATCH 32/36] tty: hvc: hvc_vio: Staticify function invoked only by reference
Fixes the following W=1 kernel build warning(s):
drivers/tty/hvc/hvc_vio.c:181:6: warning: no previous prototype for
‘hvterm_hvsi_hangup’ [-Wmissing-prototypes]
181 | void hvterm_hvsi_hangup(struct hvc_struct *hp, int data)
| ^~
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
drivers/tty/hvc/hvc_vio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/hvc/hvc_vio.c b/drivers/tty/hvc/hvc_vio.c
index 7af54d6ed5b84..798f27f40cc2d 100644
--- a/drivers/tty/hvc/hvc_vio.c
+++ b/drivers/tty/hvc/hvc_vio.c
@@ -178,7 +178,7 @@ static void hvterm_hvsi_close(struct hvc_struct *hp, int
data)
notifier_del_irq(hp, data);
}
-void hvterm_hvsi_hangup(struct hvc_struct *hp, int data)
+static void hvterm_hvsi_hangup(struct hvc_struct *hp, int data)
{
struct hvterm_priv *pv = hvterm_privs[hp->vtermno];
--
2.25.1
[PATCH 31/36] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location
Fixes the following W=1 kernel build warning(s): drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for ‘hvc_vio_init_early’ [-Wmissing-prototypes] 385 | void __init hvc_vio_init_early(void) | ^~ Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- arch/powerpc/include/asm/hvconsole.h | 3 +++ arch/powerpc/platforms/pseries/pseries.h | 3 --- arch/powerpc/platforms/pseries/setup.c | 1 + 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/include/asm/hvconsole.h b/arch/powerpc/include/asm/hvconsole.h index 999ed5ac90531..936a1ee1ac786 100644 --- a/arch/powerpc/include/asm/hvconsole.h +++ b/arch/powerpc/include/asm/hvconsole.h @@ -24,5 +24,8 @@ extern int hvc_get_chars(uint32_t vtermno, char *buf, int count); extern int hvc_put_chars(uint32_t vtermno, const char *buf, int count); +/* Provided by HVC VIO */ +extern void hvc_vio_init_early(void); + #endif /* __KERNEL__ */ #endif /* _PPC64_HVCONSOLE_H */ diff --git a/arch/powerpc/platforms/pseries/pseries.h b/arch/powerpc/platforms/pseries/pseries.h index 13fa370a87e4e..7be5b054dfc36 100644 --- a/arch/powerpc/platforms/pseries/pseries.h +++ b/arch/powerpc/platforms/pseries/pseries.h @@ -43,9 +43,6 @@ extern void pSeries_final_fixup(void); /* Poweron flag used for enabling auto ups restart */ extern unsigned long rtas_poweron_auto; -/* Provided by HVC VIO */ -extern void hvc_vio_init_early(void); - /* Dynamic logical Partitioning/Mobility */ extern void dlpar_free_cc_nodes(struct device_node *); extern void dlpar_free_cc_property(struct property *); diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c index 633c45ec406da..6999b83f06612 100644 --- a/arch/powerpc/platforms/pseries/setup.c +++ b/arch/powerpc/platforms/pseries/setup.c @@ -71,6 +71,7 @@ #include #include #include +#include #include "pseries.h" #include "../../../../drivers/pci/pci.h" -- 2.25.1
[PATCH 00/36] Rid W=1 issues from TTY
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (36): tty: serdev: core: Remove unused variable 'dummy' tty: serdev: core: Provide missing description for 'owner' tty: tty_baudrate: Add missing description for 'tty' tty: tty_io: Move 'tty_sysctl_init's prototype to shared space tty: tty_buffer: Add missing description for 'limit' tty: tty_port: Demote obvious abuse of kernel-doc formatting tty: tty_jobctrl: Add missing function parameter descriptions tty: tty_ldisc: Fix some kernel-doc related misdemeanours tty: vt: consolemap: Demote weakly documented function header tty: n_tty: Add 2 missing parameter descriptions tty: serial: jsm: jsm_cls: Remove unused variable 'discard' tty: tty_io: Fix some kernel-doc issues tty: serial: 8250: 8250_port: Staticify functions referenced by pointers tty: serial: 8250: serial_cs: Remove unused/unchecked variable 'err' tty: tty_audit: Demote non-conformant kernel-doc headers tty: pty: Provide descriptions for the 'file' parameters tty: serial: amba-pl011: Mark 'sbsa_uart_acpi_match' as __maybe_unused tty: n_gsm: Demote obvious abuse of kernel-doc and supply other missing docss tty: serial: lpc32xx_hs: Remove unused variable 'tmp' tty: serial: msm_serial: Remove set but unused variable 'status' tty: serial: ifx6x60: Fix function documentation headers tty: serial: xilinx_uartps: Supply description for missing member 'cts_override' tty: synclink_gt: Demote one kernel-doc header and repair another tty: serial: serial-tegra: Struct headers should start with 'struct ' tty: serial: sifive: Struct headers should start with 'struct ' tty: synclinkmp: Add missing description for function param 'txqueue' tty: synclinkmp: Mark never checked 'readval' as __always_unused tty: serial: stm32-usart: Remove set but unused 'cookie' variables tty: tty_ldisc: Supply missing description for 'tty_ldisc_get's 'tty' param tty: serial: serial-tegra: Provide some missing struct member descriptions powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location tty: hvc: hvc_vio: Staticify function invoked only by reference tty: hvc: hvc_opal: Staticify function invoked by reference tty: serial: pmac_zilog: Make disposable variable __always_unused tty: synclink: Mark disposable variables as __always_unused tty: synclink: Provide missing description for 'hdlcdev_tx_timeout's 'txqueue' param arch/powerpc/include/asm/hvconsole.h | 3 +++ arch/powerpc/platforms/pseries/pseries.h | 3 --- arch/powerpc/platforms/pseries/setup.c | 1 + drivers/tty/hvc/hvc_opal.c | 2 +- drivers/tty/hvc/hvc_vio.c| 2 +- drivers/tty/n_gsm.c | 4 +++- drivers/tty/n_tty.c | 2 ++ drivers/tty/pty.c| 2 ++ drivers/tty/serdev/core.c| 6 ++ drivers/tty/serial/8250/8250_port.c | 4 ++-- drivers/tty/serial/8250/serial_cs.c | 9 +++-- drivers/tty/serial/amba-pl011.c | 2 +- drivers/tty/serial/ifx6x60.c | 3 ++- drivers/tty/serial/jsm/jsm_cls.c | 4 +--- drivers/tty/serial/lpc32xx_hs.c | 3 +-- drivers/tty/serial/msm_serial.c | 3 +-- drivers/tty/serial/pmac_zilog.h | 2 +- drivers/tty/serial/serial-tegra.c| 7 ++- drivers/tty/serial/sifive.c | 3 ++- drivers/tty/serial/stm32-usart.c | 6 ++ drivers/tty/serial/xilinx_uartps.c | 1 + drivers/tty/synclink.c | 5 +++-- drivers/tty/synclink_gt.c| 3 ++- drivers/tty/synclinkmp.c | 3 ++- drivers/tty/tty_audit.c | 12 ++-- drivers/tty/tty_baudrate.c | 1 + drivers/tty/tty_buffer.c | 1 + drivers/tty/tty_io.c | 12 +++- drivers/tty/tty_jobctrl.c| 3 +++ drivers/tty/tty_ldisc.c | 11 ++- drivers/tty/tty_port.c | 4 ++-- drivers/tty/vt/consolemap.c | 3 +-- include/linux/tty.h | 1 + 33 files changed, 73 insertions(+), 58 deletions(-) Cc: Alexandre Torgue Cc: "Andrew J. Kroll" Cc: Andrew Morton Cc: Andy Gross Cc: Benjamin Herrenschmidt Cc: Bill Hawes Cc: Bjorn Andersson Cc: "Christian König" Cc: Colin Ian King Cc: "C. Scott Ananian" Cc: "David A. Hinds" Cc: dri-de...@lists.freedesktop.org Cc: Filip Aben Cc: Gerald Baeza Cc: Greg Kroah-Hartman Cc: Jakub Jelinek Cc: Jan Dumon Cc: Jiri Slaby Cc: Jonathan Hunter Cc: Joseph Barrow Cc: -- Cc: Kevin Wells Cc: Laxman Dewangan Cc: linaro-mm-...@lists.linaro.org Cc: linux-arm-...@vger.kernel.org Cc: linux-me...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux
[PATCH 12/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues
Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Excess function parameter 'tot_len' description in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Excess function parameter 'data' description in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function parameter 'skb' description in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Excess function parameter 'subcrq' description in 'build_hdr_descs_arr' Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: linuxppc-dev@lists.ozlabs.org Cc: net...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ibm/ibmvnic.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index b30e1f5784bad..08dab7a94b7ea 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1360,7 +1360,7 @@ static int ibmvnic_close(struct net_device *netdev) * @hdr_field: bitfield determining needed headers * @skb: socket buffer * @hdr_len: array of header lengths - * @tot_len: total length of data + * @hdr_data: buffer to write the header to * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1418,7 +1418,7 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors * @hdr_field: bitfield determining needed headers - * @data: buffer containing header data + * @hdr_data: buffer containing header data * @len: length of data buffer * @hdr_len: array of individual header lengths * @scrq_arr: descriptor array @@ -1469,9 +1469,8 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb: socket buffer + * @txbuff: tx buffer * @num_entries: number of descriptors to be sent - * @subcrq: first TX descriptor * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descriptor array with applicable -- 2.25.1
[PATCH 10/12] net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours
Fixes the following W=1 kernel build warning(s):
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter
or member 'irq' not described in 'gelic_card_interrupt'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1107: warning: Function parameter
or member 'ptr' not described in 'gelic_card_interrupt'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1407: warning: Function parameter
or member 'txqueue' not described in 'gelic_net_tx_timeout'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1439: warning: Function parameter
or member 'napi' not described in 'gelic_ether_setup_netdev_ops'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1639: warning: Function parameter
or member 'dev' not described in 'ps3_gelic_driver_probe'
drivers/net/ethernet/toshiba/ps3_gelic_net.c:1795: warning: Function parameter
or member 'dev' not described in 'ps3_gelic_driver_remove'
Cc: Geoff Levand
Cc: "David S. Miller"
Cc: Jakub Kicinski
Cc: Michael Ellerman
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Utz Bacher
Cc: Jens Osterkamp
Cc: net...@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
drivers/net/ethernet/toshiba/ps3_gelic_net.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
index d9a5722f561b5..f886e23f8ed0a 100644
--- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
+++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
@@ -1100,7 +1100,7 @@ static int gelic_net_poll(struct napi_struct *napi, int
budget)
return packets_done;
}
-/**
+/*
* gelic_card_interrupt - event handler for gelic_net
*/
static irqreturn_t gelic_card_interrupt(int irq, void *ptr)
@@ -1400,6 +1400,7 @@ static void gelic_net_tx_timeout_task(struct work_struct
*work)
/**
* gelic_net_tx_timeout - called when the tx timeout watchdog kicks in.
* @netdev: interface device structure
+ * @txqueue: unused
*
* called, if tx hangs. Schedules a task that resets the interface
*/
@@ -1431,6 +1432,7 @@ static const struct net_device_ops gelic_netdevice_ops = {
/**
* gelic_ether_setup_netdev_ops - initialization of net_device operations
* @netdev: net_device structure
+ * @napi: napi structure
*
* fills out function pointers in the net_device structure
*/
@@ -1632,7 +1634,7 @@ static void gelic_card_get_vlan_info(struct gelic_card
*card)
dev_info(ctodev(card), "internal vlan %s\n",
card->vlan_required? "enabled" : "disabled");
}
-/**
+/*
* ps3_gelic_driver_probe - add a device to the control of this driver
*/
static int ps3_gelic_driver_probe(struct ps3_system_bus_device *dev)
@@ -1787,10 +1789,9 @@ static int ps3_gelic_driver_probe(struct
ps3_system_bus_device *dev)
return result;
}
-/**
+/*
* ps3_gelic_driver_remove - remove a device from the control of this driver
*/
-
static int ps3_gelic_driver_remove(struct ps3_system_bus_device *dev)
{
struct gelic_card *card = ps3_system_bus_get_drvdata(dev);
--
2.25.1
[PATCH 09/12] net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours
Fixes the following W=1 kernel build warning(s): from drivers/net/ethernet/ibm/ibmvnic.c:35: inlined from ‘handle_vpd_rsp’ at drivers/net/ethernet/ibm/ibmvnic.c:4124:3: drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'skb' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_len' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1362: warning: Function parameter or member 'hdr_data' not described in 'build_hdr_data' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_field' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_data' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'hdr_len' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1423: warning: Function parameter or member 'scrq_arr' not described in 'create_hdr_descs' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'txbuff' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'num_entries' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1474: warning: Function parameter or member 'hdr_field' not described in 'build_hdr_descs_arr' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'adapter' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'rwi' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1832: warning: Function parameter or member 'reset_state' not described in 'do_change_param_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'adapter' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'rwi' not described in 'do_reset' drivers/net/ethernet/ibm/ibmvnic.c:1911: warning: Function parameter or member 'reset_state' not described in 'do_reset' Cc: Dany Madden Cc: Lijun Pan Cc: Sukadev Bhattiprolu Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Santiago Leon Cc: Thomas Falcon Cc: John Allen Cc: net...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/net/ethernet/ibm/ibmvnic.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c index 1dc3cfdb38abc..b30e1f5784bad 100644 --- a/drivers/net/ethernet/ibm/ibmvnic.c +++ b/drivers/net/ethernet/ibm/ibmvnic.c @@ -1357,10 +1357,10 @@ static int ibmvnic_close(struct net_device *netdev) /** * build_hdr_data - creates L2/L3/L4 header data buffer - * @hdr_field - bitfield determining needed headers - * @skb - socket buffer - * @hdr_len - array of header lengths - * @tot_len - total length of data + * @hdr_field: bitfield determining needed headers + * @skb: socket buffer + * @hdr_len: array of header lengths + * @tot_len: total length of data * * Reads hdr_field to determine which headers are needed by firmware. * Builds a buffer containing these headers. Saves individual header @@ -1417,11 +1417,11 @@ static int build_hdr_data(u8 hdr_field, struct sk_buff *skb, /** * create_hdr_descs - create header and header extension descriptors - * @hdr_field - bitfield determining needed headers - * @data - buffer containing header data - * @len - length of data buffer - * @hdr_len - array of individual header lengths - * @scrq_arr - descriptor array + * @hdr_field: bitfield determining needed headers + * @data: buffer containing header data + * @len: length of data buffer + * @hdr_len: array of individual header lengths + * @scrq_arr: descriptor array * * Creates header and, if needed, header extension descriptors and * places them in a descriptor array, scrq_arr @@ -1469,10 +1469,10 @@ static int create_hdr_descs(u8 hdr_field, u8 *hdr_data, int len, int *hdr_len, /** * build_hdr_descs_arr - build a header descriptor array - * @skb - socket buffer - * @num_entries - number of descriptors to be sent - * @subcrq - first TX descriptor - * @hdr_field - bit field determining which headers will be sent + * @skb: socket buffer + * @num_entries: number of descriptors to be sent + * @subcrq: first TX descriptor + * @hdr_field: bit field determining which headers will be sent * * This function will build a TX descriptor array with applicable
[PATCH 00/12] [Set 2] Rid W=1 warnings in Net
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. This is the last set. Lee Jones (12): net: usb: lan78xx: Remove lots of set but unused 'ret' variables net: ethernet: smsc: smc911x: Mark 'status' as __maybe_unused net: ethernet: xilinx: xilinx_emaclite: Document 'txqueue' even if it is unused net: ethernet: smsc: smc91x: Demote non-conformant kernel function header net: xen-netback: xenbus: Demote nonconformant kernel-doc headers net: ethernet: ti: am65-cpsw-qos: Demote non-conformant function header net: ethernet: ti: am65-cpts: Document am65_cpts_rx_enable()'s 'en' parameter net: xen-netfront: Demote non-kernel-doc headers to standard comment blocks net: ethernet: ibm: ibmvnic: Fix some kernel-doc misdemeanours net: ethernet: toshiba: ps3_gelic_net: Fix some kernel-doc misdemeanours net: ethernet: toshiba: spider_net: Document a whole bunch of function parameters net: ethernet: ibm: ibmvnic: Fix some kernel-doc issues drivers/net/ethernet/ibm/ibmvnic.c| 27 ++- drivers/net/ethernet/smsc/smc911x.c | 6 +- drivers/net/ethernet/smsc/smc91x.c| 2 +- drivers/net/ethernet/ti/am65-cpsw-qos.c | 2 +- drivers/net/ethernet/ti/am65-cpts.c | 2 +- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 9 +- drivers/net/ethernet/toshiba/spider_net.c | 18 +- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 1 + drivers/net/usb/lan78xx.c | 212 +- drivers/net/xen-netback/xenbus.c | 4 +- drivers/net/xen-netfront.c| 6 +- 11 files changed, 141 insertions(+), 148 deletions(-) Cc: Alexei Starovoitov Cc: Andrii Nakryiko Cc: Benjamin Herrenschmidt Cc: Boris Ostrovsky Cc: b...@vger.kernel.org Cc: Daniel Borkmann Cc: Dany Madden Cc: Daris A Nevil Cc: "David S. Miller" Cc: Dustin McIntire Cc: Erik Stahlman Cc: Geoff Levand Cc: Grygorii Strashko Cc: "Gustavo A. R. Silva" Cc: Ishizaki Kou Cc: Ivan Khoronzhuk Cc: Jakub Kicinski Cc: Jens Osterkamp Cc: Jesper Dangaard Brouer Cc: John Allen Cc: John Fastabend Cc: John Williams Cc: Juergen Gross Cc: KP Singh Cc: Kurt Kanzenbach Cc: Lijun Pan Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-...@vger.kernel.org Cc: Martin Habets Cc: Martin KaFai Lau Cc: Michael Ellerman Cc: "Michael S. Tsirkin" Cc: Michal Simek Cc: Microchip Linux Driver Support Cc: net...@vger.kernel.org Cc: Nicolas Pitre Cc: Paul Durrant Cc: Paul Mackerras Cc: Peter Cammaert Cc: Russell King Cc: Rusty Russell Cc: Santiago Leon Cc: Shannon Nelson Cc: Song Liu Cc: Stefano Stabellini Cc: Sukadev Bhattiprolu Cc: Thomas Falcon Cc: Utz Bacher Cc: Wei Liu Cc: Woojung Huh Cc: xen-de...@lists.xenproject.org Cc: Yonghong Song -- 2.25.1
[PATCH 25/25] soc: fsl: qbman: qman: Remove unused variable 'dequeue_wq'
Fixes the following W=1 kernel build warning(s):
drivers/soc/fsl/qbman/qman.c: In function ‘qman_shutdown_fq’:
drivers/soc/fsl/qbman/qman.c:2700:8: warning: variable ‘dequeue_wq’ set but
not used [-Wunused-but-set-variable]
Cc: Li Yang
Cc: YueHaibing
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
drivers/soc/fsl/qbman/qman.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
index 9888a70618730..62b182c3a8b04 100644
--- a/drivers/soc/fsl/qbman/qman.c
+++ b/drivers/soc/fsl/qbman/qman.c
@@ -2622,7 +2622,7 @@ int qman_shutdown_fq(u32 fqid)
union qm_mc_command *mcc;
union qm_mc_result *mcr;
int orl_empty, drain = 0, ret = 0;
- u32 channel, wq, res;
+ u32 channel, res;
u8 state;
p = get_affine_portal();
@@ -2655,7 +2655,7 @@ int qman_shutdown_fq(u32 fqid)
DPAA_ASSERT((mcr->verb & QM_MCR_VERB_MASK) == QM_MCR_VERB_QUERYFQ);
/* Need to store these since the MCR gets reused */
channel = qm_fqd_get_chan(>queryfq.fqd);
- wq = qm_fqd_get_wq(>queryfq.fqd);
+ qm_fqd_get_wq(>queryfq.fqd);
if (channel < qm_channel_pool1) {
channel_portal = get_portal_for_channel(channel);
@@ -2697,7 +2697,6 @@ int qman_shutdown_fq(u32 fqid)
* to dequeue from the channel the FQ is scheduled on
*/
int found_fqrn = 0;
- u16 dequeue_wq = 0;
/* Flag that we need to drain FQ */
drain = 1;
@@ -2705,11 +2704,8 @@ int qman_shutdown_fq(u32 fqid)
if (channel >= qm_channel_pool1 &&
channel < qm_channel_pool1 + 15) {
/* Pool channel, enable the bit in the portal */
- dequeue_wq = (channel -
- qm_channel_pool1 + 1)<<4 | wq;
} else if (channel < qm_channel_pool1) {
/* Dedicated channel */
- dequeue_wq = wq;
} else {
dev_err(dev, "Can't recover FQ 0x%x, ch: 0x%x",
fqid, channel);
--
2.25.1
[PATCH 11/25] soc: fsl: qe: qe_common: Fix misnamed function attribute 'addr'
Fixes the following W=1 kernel build warning(s):
drivers/soc/fsl/qe/qe_common.c:237: warning: Function parameter or member
'addr' not described in 'cpm_muram_dma'
drivers/soc/fsl/qe/qe_common.c:237: warning: Excess function parameter
'offset' description in 'cpm_muram_dma'
Cc: Qiang Zhao
Cc: Li Yang
Cc: Scott Wood
Cc: act
Cc: Dan Malek
Cc: "Software, Inc"
Cc: Vitaly Bordug
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
drivers/soc/fsl/qe/qe_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/fsl/qe/qe_common.c b/drivers/soc/fsl/qe/qe_common.c
index 75075591f6308..497a7e0fd0272 100644
--- a/drivers/soc/fsl/qe/qe_common.c
+++ b/drivers/soc/fsl/qe/qe_common.c
@@ -231,7 +231,7 @@ EXPORT_SYMBOL(cpm_muram_offset);
/**
* cpm_muram_dma - turn a muram virtual address into a DMA address
- * @offset: virtual address from cpm_muram_addr() to convert
+ * @addr: virtual address from cpm_muram_addr() to convert
*/
dma_addr_t cpm_muram_dma(void __iomem *addr)
{
--
2.25.1
[PATCH 04/25] soc: fsl: dpio: qbman-portal: Fix a bunch of kernel-doc misdemeanours
Fixes the following W=1 kernel build warning(s):
drivers/soc/fsl/dpio/qbman-portal.c:430: warning: Function parameter or member
'inhibit' not described in 'qbman_swp_interrupt_set_inhibit'
drivers/soc/fsl/dpio/qbman-portal.c:430: warning: Excess function parameter
'mask' description in 'qbman_swp_interrupt_set_inhibit'
drivers/soc/fsl/dpio/qbman-portal.c:518: warning: Function parameter or member
'd' not described in 'qbman_eq_desc_clear'
drivers/soc/fsl/dpio/qbman-portal.c:529: warning: Function parameter or member
'respond_success' not described in 'qbman_eq_desc_set_no_orp'
drivers/soc/fsl/dpio/qbman-portal.c:529: warning: Excess function parameter
'response_success' description in 'qbman_eq_desc_set_no_orp'
drivers/soc/fsl/dpio/qbman-portal.c:941: warning: Function parameter or member
's' not described in 'qbman_swp_push_get'
drivers/soc/fsl/dpio/qbman-portal.c:941: warning: Excess function parameter
'p' description in 'qbman_swp_push_get'
drivers/soc/fsl/dpio/qbman-portal.c:955: warning: Function parameter or member
's' not described in 'qbman_swp_push_set'
drivers/soc/fsl/dpio/qbman-portal.c:955: warning: Excess function parameter
'p' description in 'qbman_swp_push_set'
drivers/soc/fsl/dpio/qbman-portal.c:1052: warning: Function parameter or
member 'd' not described in 'qbman_pull_desc_set_fq'
drivers/soc/fsl/dpio/qbman-portal.c:1065: warning: Function parameter or
member 'd' not described in 'qbman_pull_desc_set_wq'
drivers/soc/fsl/dpio/qbman-portal.c:1079: warning: Function parameter or
member 'd' not described in 'qbman_pull_desc_set_channel'
drivers/soc/fsl/dpio/qbman-portal.c:1403: warning: Function parameter or
member 'd' not described in 'qbman_release_desc_clear'
drivers/soc/fsl/dpio/qbman-portal.c:1412: warning: Function parameter or
member 'd' not described in 'qbman_release_desc_set_bpid'
drivers/soc/fsl/dpio/qbman-portal.c:1412: warning: Function parameter or
member 'bpid' not described in 'qbman_release_desc_set_bpid'
drivers/soc/fsl/dpio/qbman-portal.c:1421: warning: Function parameter or
member 'd' not described in 'qbman_release_desc_set_rcdi'
drivers/soc/fsl/dpio/qbman-portal.c:1421: warning: Function parameter or
member 'enable' not described in 'qbman_release_desc_set_rcdi'
Cc: Roy Pledge
Cc: Li Yang
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
drivers/soc/fsl/dpio/qbman-portal.c | 18 +-
1 file changed, 13 insertions(+), 5 deletions(-)
diff --git a/drivers/soc/fsl/dpio/qbman-portal.c
b/drivers/soc/fsl/dpio/qbman-portal.c
index 659b4a570d5b5..f13da4d7d1c52 100644
--- a/drivers/soc/fsl/dpio/qbman-portal.c
+++ b/drivers/soc/fsl/dpio/qbman-portal.c
@@ -424,7 +424,7 @@ int qbman_swp_interrupt_get_inhibit(struct qbman_swp *p)
/**
* qbman_swp_interrupt_set_inhibit() - write interrupt mask register
* @p: the given software portal object
- * @mask: The mask to set in SWP_IIR register
+ * @inhibit: whether to inhibit the IRQs
*/
void qbman_swp_interrupt_set_inhibit(struct qbman_swp *p, int inhibit)
{
@@ -510,7 +510,7 @@ enum qb_enqueue_commands {
#define QB_ENQUEUE_CMD_TARGET_TYPE_SHIFT 4
#define QB_ENQUEUE_CMD_DCA_EN_SHIFT 7
-/**
+/*
* qbman_eq_desc_clear() - Clear the contents of a descriptor to
* default/starting state.
*/
@@ -522,7 +522,7 @@ void qbman_eq_desc_clear(struct qbman_eq_desc *d)
/**
* qbman_eq_desc_set_no_orp() - Set enqueue descriptor without orp
* @d:the enqueue descriptor.
- * @response_success: 1 = enqueue with response always; 0 = enqueue with
+ * @respond_success: 1 = enqueue with response always; 0 = enqueue with
*rejections returned on a FQ.
*/
void qbman_eq_desc_set_no_orp(struct qbman_eq_desc *d, int respond_success)
@@ -932,7 +932,7 @@ int qbman_swp_enqueue_multiple_desc_mem_back(struct
qbman_swp *s,
/**
* qbman_swp_push_get() - Get the push dequeue setup
- * @p: the software portal object
+ * @s: the software portal object
* @channel_idx: the channel index to query
* @enabled: returned boolean to show whether the push dequeue is enabled
* for the given channel
@@ -947,7 +947,7 @@ void qbman_swp_push_get(struct qbman_swp *s, u8
channel_idx, int *enabled)
/**
* qbman_swp_push_set() - Enable or disable push dequeue
- * @p: the software portal object
+ * @s: the software portal object
* @channel_idx: the channel index (0 to 15)
* @enable: enable or disable push dequeue
*/
@@ -1046,6 +1046,7 @@ void qbman_pull_desc_set_numframes(struct qbman_pull_desc
*d, u8 numframes)
/**
* qbman_pull_desc_set_fq() - Set fqid from which the dequeue command dequeues
+ * @d:the pull dequeue descriptor to be set
* @fqid: the frame queue index of the given FQ
*/
void qbman_pull_desc_set_fq(struct qbman_pull_desc *d, u32 fqid)
@@ -1057,6 +1058,7 @@ void qbman_pull_desc_set_fq(struct qbman_pull_desc *d,
u32 fqid
[PATCH 00/25] Rid W=1 warnings in SoC
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (25): soc: bcm: brcmstb: pm: pm-arm: Provide prototype for brcmstb_pm_s3_finish() soc: qcom: qcom_aoss: Remove set but unused variable 'tlen' soc: qcom: qcom_aoss: Add missing description for 'cooling_devs' soc: fsl: dpio: qbman-portal: Fix a bunch of kernel-doc misdemeanours soc: rockchip: io-domain: Remove incorrect and incomplete comment header soc: ti: knav_qmss_queue: Remove set but unchecked variable 'ret' soc: ti: knav_qmss_queue: Fix a whole host of function documentation issues soc: ti: knav_dma: Fix a kernel function doc formatting issue soc: ti: pm33xx: Remove set but unused variable 'ret' soc: ti: wkup_m3_ipc: Document 'm3_ipc' parameter throughout soc: fsl: qe: qe_common: Fix misnamed function attribute 'addr' soc: qcom: qcom-geni-se: Fix misnamed function parameter 'rx_rfr' soc: tegra: fuse: speedo-tegra124: Remove some set but unused variables soc: samsung: s3c-pm-check: Fix incorrectly named variable 'val' soc: qcom: rpmh: Fix possible doc-rot in rpmh_write()'s header soc: qcom: smem: Fix formatting and missing documentation issues soc: qcom: smsm: Fix some kernel-doc formatting and naming problems soc: qcom: wcnss_ctrl: Demote non-conformant struct header and fix function headers soc: qcom: smp2p: Remove unused struct attribute provide another soc: qcom: llcc-qcom: Fix expected kernel-doc formatting soc: qcom: rpmhpd: Provide some missing struct member descriptions soc: qcom: kryo-l2-accessors: Fix misnaming of 'val' soc: ti: k3-ringacc: Provide documentation for 'k3_ring's 'state' soc: tegra: fuse: speedo-tegra210: Remove a group of set but unused variables soc: fsl: qbman: qman: Remove unused variable 'dequeue_wq' drivers/soc/bcm/brcmstb/pm/pm-arm.c | 2 + drivers/soc/fsl/dpio/qbman-portal.c | 18 +-- drivers/soc/fsl/qbman/qman.c | 8 +-- drivers/soc/fsl/qe/qe_common.c | 2 +- drivers/soc/qcom/kryo-l2-accessors.c | 2 +- drivers/soc/qcom/llcc-qcom.c | 2 +- drivers/soc/qcom/qcom-geni-se.c | 5 +- drivers/soc/qcom/qcom_aoss.c | 4 +- drivers/soc/qcom/rpmh.c | 2 +- drivers/soc/qcom/rpmhpd.c| 3 ++ drivers/soc/qcom/smem.c | 3 +- drivers/soc/qcom/smp2p.c | 3 +- drivers/soc/qcom/smsm.c | 4 +- drivers/soc/qcom/wcnss_ctrl.c| 8 +-- drivers/soc/rockchip/io-domain.c | 3 -- drivers/soc/samsung/s3c-pm-check.c | 2 +- drivers/soc/tegra/fuse/speedo-tegra124.c | 7 ++- drivers/soc/tegra/fuse/speedo-tegra210.c | 8 +-- drivers/soc/ti/k3-ringacc.c | 1 + drivers/soc/ti/knav_dma.c| 2 +- drivers/soc/ti/knav_qmss_queue.c | 62 drivers/soc/ti/pm33xx.c | 4 +- drivers/soc/ti/wkup_m3_ipc.c | 8 ++- 23 files changed, 86 insertions(+), 77 deletions(-) Cc: act Cc: Andy Gross Cc: bcm-kernel-feedback-l...@broadcom.com Cc: Ben Dooks Cc: Bjorn Andersson Cc: Cyril Chemparathy Cc: Dan Malek Cc: Dave Gerlach Cc: Doug Anderson Cc: Florian Fainelli Cc: Heiko Stuebner Cc: Jonathan Hunter Cc: Krzysztof Kozlowski Cc: Liam Girdwood Cc: linux-arm-...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Cc: linux-rockc...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Cc: linux-te...@vger.kernel.org Cc: Li Yang Cc: Mark Brown Cc: Qiang Zhao Cc: "Rafael J. Wysocki" Cc: Roy Pledge Cc: Sandeep Nair Cc: Santosh Shilimkar Cc: Scott Wood Cc: "Software, Inc" Cc: Thierry Reding Cc: Vitaly Bordug Cc: YueHaibing -- 2.25.1
[PATCH v2 2/2] misc: ocxl: config: Rename function attribute description
Fixes the following W=1 kernel build warning(s): drivers/misc/ocxl/config.c:81: warning: Function parameter or member 'dev' not described in 'get_function_0' drivers/misc/ocxl/config.c:81: warning: Excess function parameter 'device' description in 'get_function_0' Cc: Frederic Barrat Cc: Andrew Donnellan Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/misc/ocxl/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c index 4d490b92d951f..a68738f382521 100644 --- a/drivers/misc/ocxl/config.c +++ b/drivers/misc/ocxl/config.c @@ -73,7 +73,7 @@ static int find_dvsec_afu_ctrl(struct pci_dev *dev, u8 afu_idx) /** * get_function_0() - Find a related PCI device (function 0) - * @device: PCI device to match + * @dev: PCI device to match * * Returns a pointer to the related device, or null if not found */ -- 2.25.1
[PATCH 23/23] mtd: devices: powernv_flash: Add function names to headers and fix 'dev'
Fixes the following W=1 kernel build warning(s): drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * @mtd: the device drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or member 'dev' not described in 'powernv_flash_set_driver_info' Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Cyril Bur Cc: linux-...@lists.infradead.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/mtd/devices/powernv_flash.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c index 0b757d9ba2f6b..32cb0e649096f 100644 --- a/drivers/mtd/devices/powernv_flash.c +++ b/drivers/mtd/devices/powernv_flash.c @@ -126,6 +126,8 @@ static int powernv_flash_async_op(struct mtd_info *mtd, enum flash_op op, } /** + * powernv_flash_read + * * @mtd: the device * @from: the offset to read from * @len: the number of bytes to read @@ -142,6 +144,7 @@ static int powernv_flash_read(struct mtd_info *mtd, loff_t from, size_t len, } /** + * powernv_flash_write * @mtd: the device * @to: the offset to write to * @len: the number of bytes to write @@ -158,6 +161,7 @@ static int powernv_flash_write(struct mtd_info *mtd, loff_t to, size_t len, } /** + * powernv_flash_erase * @mtd: the device * @erase: the erase info * Returns 0 if erase successful or -ERRNO if an error occurred @@ -176,7 +180,7 @@ static int powernv_flash_erase(struct mtd_info *mtd, struct erase_info *erase) /** * powernv_flash_set_driver_info - Fill the mtd_info structure and docg3 - * structure @pdev: The platform device + * @dev: The device structure * @mtd: The structure to fill */ static int powernv_flash_set_driver_info(struct device *dev, -- 2.25.1
[PATCH 2/2] misc: ocxl: config: Rename function attribute description
Fixes the following W=1 kernel build warning(s): drivers/misc/ocxl/config.c:81: warning: Function parameter or member 'dev' not described in 'get_function_0' drivers/misc/ocxl/config.c:81: warning: Excess function parameter 'device' description in 'get_function_0' Cc: Frederic Barrat Cc: Andrew Donnellan Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Lee Jones --- drivers/misc/ocxl/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c index 4d490b92d951f..a68738f382521 100644 --- a/drivers/misc/ocxl/config.c +++ b/drivers/misc/ocxl/config.c @@ -73,7 +73,7 @@ static int find_dvsec_afu_ctrl(struct pci_dev *dev, u8 afu_idx) /** * get_function_0() - Find a related PCI device (function 0) - * @device: PCI device to match + * @dev: PCI device to match * * Returns a pointer to the related device, or null if not found */ -- 2.25.1
[PATCH v2 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'
Cc: Timur Tabi
Cc: Nicolin Chen
Cc: Xiubo Li
Cc: Fabio Estevam
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
---
sound/soc/fsl/fsl-asoc-card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/fsl-asoc-card.c b/sound/soc/fsl/fsl-asoc-card.c
index faac6ce9a82cb..dbacdd25dfe76 100644
--- a/sound/soc/fsl/fsl-asoc-card.c
+++ b/sound/soc/fsl/fsl-asoc-card.c
@@ -92,7 +92,7 @@ struct fsl_asoc_card_priv {
};
/*
- * This dapm route map exits for DPCM link only.
+ * This dapm route map exists for DPCM link only.
* The other routes shall go through Device Tree.
*
* Note: keep all ASRC routes in the second half
--
2.25.1
Re: [PATCH 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'
On Wed, 15 Jul 2020, Lee Jones wrote: > On Wed, 15 Jul 2020, Mark Brown wrote: > > > On Wed, Jul 15, 2020 at 10:44:47AM +0100, Lee Jones wrote: > > > > > /* > > > - * This dapm route map exits for DPCM link only. > > > + * This dapm route map exists for DPCM link only. > > > * The other routes shall go through Device Tree. > > > > This doesn't apply against current code, please check and resend. > > What is 'current code'? It's applied against today's -next. Hmm... something went wrong. Stand by ... -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 1/1] ASoC: fsl: fsl-asoc-card: Trivial: Fix misspelling of 'exists'
On Wed, 15 Jul 2020, Mark Brown wrote: > On Wed, Jul 15, 2020 at 10:44:47AM +0100, Lee Jones wrote: > > > /* > > - * This dapm route map exits for DPCM link only. > > + * This dapm route map exists for DPCM link only. > > * The other routes shall go through Device Tree. > > This doesn't apply against current code, please check and resend. What is 'current code'? It's applied against today's -next. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
