Re: [PATCH v1 2/4] soc/fsl/guts: Add definition for LX2160A

2019-04-02 Thread Li Yang
> Signed-off-by: Yinbo Zhu > Acked-by: Li Yang > --- > drivers/soc/fsl/guts.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c > index 302e0c8..bcab1ee 100644 > --- a/drivers/soc/fsl/guts.c > +++ b/drivers

Re: [PATCH] soc/fsl/qe: Fix an error code in qe_pin_request()

2019-04-02 Thread Li Yang
On Thu, Mar 28, 2019 at 9:21 AM Dan Carpenter wrote: > > We forgot to set "err" on this error path. > > Fixes: 1a2d397a6eb5 ("gpio/powerpc: Eliminate duplication of > of_get_named_gpio_flags()") > Signed-off-by: Dan Carpenter Applied to fix branch. Thanks. Regards, Leo > --- >

Re: [PATCH 02/13] soc/fsl/bman: map FBPR area in the iommu

2019-03-29 Thread Li Yang
On Fri, Mar 29, 2019 at 9:03 AM wrote: > > From: Laurentiu Tudor > > Add a one-to-one iommu mapping for bman private data memory (FBPR). > This is required for BMAN to work without faults behind an iommu. > > Signed-off-by: Laurentiu Tudor > --- > drivers/soc/fsl/qbman/bman_ccsr.c | 11

Re: [PATCH 01/13] soc/fsl/qman: fixup liodns only on ppc targets

2019-03-29 Thread Li Yang
On Fri, Mar 29, 2019 at 9:01 AM wrote: > > From: Laurentiu Tudor > > ARM SoCs use SMMU so the liodn fixup done in the qman driver is no > longer making sense and it also breaks the ICID settings inherited > from u-boot. Do the fixups only for PPC targets. > > Signed-off-by: Laurentiu Tudor >

Re: [PATCH 05/13] soc/fsl/bqman: page align iommu mapping sizes

2019-03-29 Thread Li Yang
On Fri, Mar 29, 2019 at 9:01 AM wrote: > > From: Laurentiu Tudor > > Prior to calling iommu_map()/iommu_unmap() page align the size or > failures such as below could happen: > > iommu: unaligned: iova 0x... pa 0x... size 0x4000 min_pagesz 0x1 > qman_portal 5.qman-portal: failed to

Re: [PATCH 06/13] soc/fsl/qbman_portals: add APIs to retrieve the probing status

2019-04-01 Thread Li Yang
On Fri, Mar 29, 2019 at 9:03 AM wrote: > > From: Laurentiu Tudor > > Add a couple of new APIs to check the probing status of the required > cpu bound qman and bman portals: > 'int bman_portals_probed()' and 'int qman_portals_probed()'. > They return the following values. > * 1 if qman/bman

Re: [PATCH] soc: fsl: guts: make fsl_guts_get_svr() static

2019-02-26 Thread Li Yang
On Fri, Feb 22, 2019 at 2:09 AM Y.b. Lu wrote: > > > > > -Original Message- > > From: Horia Geantă > > Sent: Thursday, February 21, 2019 6:38 PM > > To: Leo Li > > Cc: Y.b. Lu ; linuxppc-dev@lists.ozlabs.org; > > linux-arm-ker...@lists.infradead.org; linux-ker...@vger.kernel.org > >

Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-29 Thread Li Yang
ndent netdev_reset_queue() calls in open/close functions. Regards, Leo > > -Original Message- > From: Li Yang [mailto:leoyang...@nxp.com] > Sent: Monday, 28 January 2019 22:37 > To: Mathias Thore > Cc: Christophe Leroy ; net...@vger.kernel.org; > linuxppc-dev@lists.ozl

Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

2019-01-28 Thread Li Yang
On Mon, Jan 28, 2019 at 8:37 AM Mathias Thore wrote: > > Hi, > > > This is what we observed: there was a storm on the medium so that our > controller could not do its TX, resulting in timeout. When timeout occurs, > the driver clears all descriptors from the TX queue. The function called in >

Re: [PATCH] soc: fsl: dpio: Use after free in dpaa2_dpio_remove()

2019-02-04 Thread Li Yang
On Mon, Feb 4, 2019 at 8:12 AM Dan Carpenter wrote: > > The dpaa2_io_down(priv->io) call frees "priv->io" so I've shifted the > code around a little bit to avoid the use after free. > > Fixes: 991e873223e9 ("soc: fsl: dpio: use a cpumask to identify which cpus > are unused") > Signed-off-by: Dan

Re: [PATCH v3 1/2] dt-bindings: soc: fsl: Document Qixis FPGA usage

2019-02-04 Thread Li Yang
Please include device tree binding mailing list and maintainers for binding patches(cc'ed now). On Mon, Feb 4, 2019 at 3:15 AM Pankaj Bansal wrote: > > an FPGA-based system controller, called “Qixis”, which > manages several critical system features, including: > • Reset sequencing > • Power

Re: [PATCH v3 0/6] soc/fsl/qe: cleanups and new DT binding

2019-06-04 Thread Li Yang
On Mon, May 13, 2019 at 6:17 AM Rasmus Villemoes wrote: > > This small series consists of some small cleanups and simplifications > of the QUICC engine driver, and introduces a new DT binding that makes > it much easier to support other variants of the QUICC engine IP block > that appears in the

Re: [PATCH v3 0/6] Prerequisites for NXP LS104xA SMMU enablement

2019-05-30 Thread Li Yang
On Thu, May 30, 2019 at 5:09 PM David Miller wrote: > > From: laurentiu.tu...@nxp.com > Date: Thu, 30 May 2019 17:19:45 +0300 > > > Depends on this pull request: > > > > http://lists.infradead.org/pipermail/linux-arm-kernel/2019-May/653554.html > > I'm not sure how you want me to handle this.

Re: [PATCH][next] soc: fsl: fix spelling mistake "Firmaware" -> "Firmware"

2019-05-29 Thread Li Yang
On Tue, May 21, 2019 at 3:57 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a pr_err message. Fix it. > > Signed-off-by: Colin Ian King Applied. Thanks! Regards, Leo > --- > drivers/soc/fsl/dpaa2-console.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [PATCH v2 0/2] soc: fsl: dpio: Add support for memory backed QBMan portals

2019-05-01 Thread Li Yang
On Fri, Apr 5, 2019 at 9:42 AM Roy Pledge wrote: > > This patch series adds support for QBMan memory backed portals which is > avaialble in devices containing QBMan verion 5.0 and above (for example > NXP's LX2160A SoC). > > Memory backed portals can be mapped as normal cacheable/shareable memory

Re: [PATCH v2 1/9] soc/fsl/qman: fixup liodns only on ppc targets

2019-05-01 Thread Li Yang
On Sat, Apr 27, 2019 at 2:14 AM wrote: > > From: Laurentiu Tudor > > ARM SoCs use SMMU so the liodn fixup done in the qman driver is no > longer making sense and it also breaks the ICID settings inherited > from u-boot. Do the fixups only for PPC targets. > > Signed-off-by: Laurentiu Tudor

Re: [PATCH v2 2/9] soc/fsl/qbman_portals: add APIs to retrieve the probing status

2019-05-01 Thread Li Yang
On Sat, Apr 27, 2019 at 2:14 AM wrote: > > From: Laurentiu Tudor > > Add a couple of new APIs to check the probing status of the required > cpu bound qman and bman portals: > 'int bman_portals_probed()' and 'int qman_portals_probed()'. > They return the following values. > * 1 if qman/bman

Re: [PATCH] soc: fsl: qe: gpio: Fix an error code in qe_pin_request()

2019-05-03 Thread Li Yang
On Fri, May 3, 2019 at 8:19 AM Dan Carpenter wrote: > > There was a missing error code in this path. It meant that we returned > ERR_PTR(0) which is NULL and would result in a NULL dereference in the > caller. Thanks Dan. An early version of this patch has been included in a pending pull

Re: [PATCH v3 0/7] soc/fsl/qbman: Enable Kexec for DPAA1 devices

2019-08-15 Thread Li Yang
On Thu, Aug 1, 2019 at 3:20 PM Roy Pledge wrote: > > Most DPAA1 devices do not support a soft reset which is an issue if > Kexec starts a new kernel. This patch series allows Kexec to function > by detecting that the QBMan device was previously initialized. > > The patches fix some issues with

Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

2019-11-04 Thread Li Yang
On Mon, Nov 4, 2019 at 2:39 AM Rasmus Villemoes wrote: > > On 01/11/2019 23.31, Leo Li wrote: > > > > > >> -Original Message- > >> From: Christophe Leroy > >> Sent: Friday, November 1, 2019 11:30 AM > >> To: Rasmus Villemoes ; Qiang Zhao > >> ; Leo Li > >> Cc:

Re: [PATCH -next] soc: fsl: Enable COMPILE_TEST

2019-11-08 Thread Li Yang
On Fri, Nov 8, 2019 at 9:20 AM Alexandre Belloni wrote: > > Hi, > > On 08/11/2019 21:02:13+0800, YueHaibing wrote: > > When do COMPILE_TEST buiding for RTC_DRV_FSL_FTM_ALARM, > > we get this warning: > > > > WARNING: unmet direct dependencies detected for FSL_RCPM > > Depends on [n]: PM_SLEEP

Re: [PATCH v3 35/36] net/wan: make FSL_UCC_HDLC explicitly depend on PPC32

2019-11-05 Thread Li Yang
On Tue, Nov 5, 2019 at 4:47 PM Rasmus Villemoes wrote: > > On 04/11/2019 21.56, Li Yang wrote: > > >> No, this patch cannot be dropped. Please see the kbuild complaints for > >> v2,23/23 about use of IS_ERR_VALUE on not-sizeof(long) entities. I see > >> kbuild

[PATCH] rtc: fsl-ftm-alarm: remove select FSL_RCPM and default y from Kconfig

2019-11-08 Thread Li Yang
The Flextimer alarm is primarily used as a wakeup source for system power management. But it shouldn't select the power management driver as they don't really have dependency of each other. Also remove the default y as it is not a critical feature for the systems. Signed-off-by: Li Yang

Re: [PATCH v4 47/47] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE

2019-11-08 Thread Li Yang
On Fri, Nov 8, 2019 at 7:05 AM Rasmus Villemoes wrote: > > There are also ARM and ARM64 based SOCs with a QUICC Engine, and the > core QE code as well as net/wan/fsl_ucc_hdlc and tty/serial/ucc_uart > has now been modified to not rely on ppcisms. > > So extend the architectures that can select

Re: [PATCH v4 47/47] soc: fsl: qe: remove PPC32 dependency from CONFIG_QUICC_ENGINE

2019-11-11 Thread Li Yang
On Mon, Nov 11, 2019 at 1:36 AM Rasmus Villemoes wrote: > > On 09/11/2019 00.48, Li Yang wrote: > > On Fri, Nov 8, 2019 at 7:05 AM Rasmus Villemoes > > wrote: > >> > >> There are also ARM and ARM64 based SOCs with a QUICC Engine, and the > >> core QE

Re: [PATCH v4 46/47] net: ethernet: freescale: make UCC_GETH explicitly depend on PPC32

2019-11-14 Thread Li Yang
On Thu, Nov 14, 2019 at 10:37 PM Timur Tabi wrote: > > On Fri, Nov 8, 2019 at 7:04 AM Rasmus Villemoes > wrote: > > > > Currently, QUICC_ENGINE depends on PPC32, so this in itself does not > > change anything. In order to allow removing the PPC32 dependency from > > QUICC_ENGINE and avoid

Re: [PATCH v4 00/47] QUICC Engine support on ARM and ARM64

2019-11-12 Thread Li Yang
On Mon, Nov 11, 2019 at 5:39 PM Li Yang wrote: > > On Fri, Nov 8, 2019 at 7:05 AM Rasmus Villemoes > wrote: > > > > I'm generally ok with these enhencements and cleanups. But as the > whole patch series touched multiple subsystems, I would like to > collect th

Re: [PATCH v4 00/47] QUICC Engine support on ARM and ARM64

2019-11-11 Thread Li Yang
ses. Nobody > has requested that I allow that driver to be built for arm{,64}, so > instead of growing this series even bigger, I kept that addition. It's > trivial to remove if somebody cares enough to fix the build > errors/warnings and actually has a platform to test the result on

Re: [PATCH v6 00/49] QUICC Engine support on ARM, ARM64, PPC64

2019-12-09 Thread Li Yang
on. > > 48 fixes a build issue on ARM reported by the kbuild bot. > > Finally patch 49 lifts the PPC32 restriction from QUICC_ENGINE. At the > request of Li Yang, it doesn't remove the PPC32 dependency but instead > changes it to PPC|| ARM || ARM64 (or COMPILE_TEST), i.e. listing >

Re: [PATCH 0/7] towards QE support on ARM

2019-10-21 Thread Li Yang
On Mon, Oct 21, 2019 at 3:46 AM Rasmus Villemoes wrote: > > On 18/10/2019 23.52, Li Yang wrote: > > On Fri, Oct 18, 2019 at 3:54 PM Rasmus Villemoes > > wrote: > >> > >> On 18/10/2019 22.16, Leo Li wrote: > >>> > >>>> > &g

Re: [PATCH 0/7] towards QE support on ARM

2019-10-24 Thread Li Yang
On Tue, Oct 22, 2019 at 9:54 PM Qiang Zhao wrote: > > On 22/10/2019 18:18, Rasmus Villemoes wrote: > > -Original Message- > > From: Rasmus Villemoes > > Sent: 2019年10月22日 18:18 > > To: Qiang Zhao ; Leo Li > > Cc: Timur Tabi ; Greg Kroah-Hartman > > ; linux-ker...@vger.kernel.org; > >

Re: [PATCH v10 1/3] PM: wakeup: Add routine to help fetch wakeup source object.

2019-10-29 Thread Li Yang
On Thu, Oct 24, 2019 at 4:29 AM Ran Wang wrote: > > Some user might want to go through all registered wakeup sources > and doing things accordingly. For example, SoC PM driver might need to > do HW programming to prevent powering down specific IP which wakeup > source depending on. So add this

Re: [PATCH v9 3/3] soc: fsl: add RCPM driver

2019-10-23 Thread Li Yang
On Wed, Oct 23, 2019 at 3:24 AM Ran Wang wrote: > > The NXP's QorIQ Processors based on ARM Core have RCPM module Actually not just ARM based QorIQ processors are having RCPM, PowerPC based QorIQ SoCs also have RCPM. Does this driver also work with the PowerPC SoCs? Please clarify in the

Re: [PATCH 0/7] towards QE support on ARM

2019-10-18 Thread Li Yang
On Fri, Oct 18, 2019 at 3:54 PM Rasmus Villemoes wrote: > > On 18/10/2019 22.16, Leo Li wrote: > > > >> > >> There have been several attempts in the past few years to allow building > >> the > >> QUICC engine drivers for platforms other than PPC. This is (the beginning > >> of) > >> yet another

Re: [PATCH v5 45/48] net/wan/fsl_ucc_hdlc: fix reading of __be16 registers

2019-11-20 Thread Li Yang
On Mon, Nov 18, 2019 at 5:26 AM Rasmus Villemoes wrote: > Hi David, What do you think about the patch 45-47 from the series for net related changes? If it is ok with you, I can merge them with the whole series through the soc tree with your ACK. Regards, Leo > When releasing the allocated

Re: [PATCH v5 13/48] powerpc/83xx: remove mpc83xx_ipic_and_qe_init_IRQ

2019-11-20 Thread Li Yang
On Mon, Nov 18, 2019 at 5:29 AM Rasmus Villemoes wrote: Hi Scott, What do you think of the PowerPC related changes(patch 13,14)? Can we have you ACK and merge the series from soc tree? Regards, Leo > > This is now exactly the same as mpc83xx_ipic_init_IRQ, so just use > that directly. > >

Re: [PATCH v6 00/49] QUICC Engine support on ARM, ARM64, PPC64

2019-12-02 Thread Li Yang
for platforms other than PPC32. This > >> is yet another attempt. > >> > >> v5 can be found > >> here:https://lore.kernel.org/lkml/20191118112324.22725-1-li...@rasmusvillemoes.dk/ > >> > > > > If it helps: > > > > Entire series: > > Acke

Re: [v3, 3/3] Documentation: dt: binding: fsl: Add 'fsl, ippdexpcr-alt-addr' property

2019-09-25 Thread Li Yang
On Tue, Sep 24, 2019 at 11:27 PM Biwen Li wrote: > > > > > > > > > > > > > > > > > > > > > > > > > The 'fsl,ippdexpcr-alt-addr' property is used to handle > > > > > > > > > > an errata > > > > > > > > > > A-008646 on LS1021A > > > > > > > > > > > > > > > > > > > > Signed-off-by: Biwen Li > > > >

Re: [PATCH 0/3] soc: fsl: dpio: Enable QMAN batch enqueuing

2020-02-19 Thread Li Yang
On Thu, Feb 6, 2020 at 2:41 PM Roy Pledge wrote: > > On 12/12/2019 12:01 PM, Youri Querry wrote: > > This patch set consists of: > > - We added an interface to enqueue several packets at a time and > >improve performance. > > - Make the algorithm decisions once at initialization and use > >

Re: [PATCH -next] soc: fsl: qe: remove set but not used variable 'mm_gc'

2020-01-08 Thread Li Yang
On Wed, Jan 8, 2020 at 7:12 AM YueHaibing wrote: > > drivers/soc/fsl/qe/gpio.c: In function qe_pin_request: > drivers/soc/fsl/qe/gpio.c:163:26: warning: variable mm_gc set but not used > [-Wunused-but-set-variable] > > commit 1e714e54b5ca ("powerpc: qe_lib-gpio: use gpiochip data pointer") >

Re: [PATCH -next] soc: fsl: dpio: remove set but not used variable 'addr_cena'

2020-03-09 Thread Li Yang
On Fri, Feb 21, 2020 at 2:38 AM YueHaibing wrote: > > commit 3b2abda7d28c ("soc: fsl: dpio: Replace QMAN array > mode with ring mode enqueue") introduced this, but not > used, so remove it. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/soc/fsl/dpio/qbman-portal.c | 4

[PATCH 5/6] soc: fsl: qe: fix sparse warnings for ucc_fast.c

2020-03-12 Thread Li Yang
[noderef] * drivers/soc/fsl/qe/ucc_fast.c:219:22: warning: incorrect type in assignment (different base types) drivers/soc/fsl/qe/ucc_fast.c:219:22:expected unsigned int [noderef] [usertype] *p_uccm drivers/soc/fsl/qe/ucc_fast.c:219:22:got restricted __be32 [noderef] * Signed-off-by: Li

[PATCH 1/6] soc: fsl: qe: fix sparse warnings for qe.c

2020-03-12 Thread Li Yang
] [usertype] extended_modes drivers/soc/fsl/qe/qe.c:528:41:got restricted __be64 const [usertype] extended_modes Signed-off-by: Li Yang --- drivers/soc/fsl/qe/qe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index

[PATCH 2/6] soc: fsl: qe: fix sparse warning for qe_common.c

2020-03-12 Thread Li Yang
-off-by: Li Yang --- drivers/soc/fsl/qe/qe_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/qe/qe_common.c b/drivers/soc/fsl/qe/qe_common.c index a81a1a79f1ca..75075591f630 100644 --- a/drivers/soc/fsl/qe/qe_common.c +++ b/drivers/soc/fsl/qe/qe_common.c

[PATCH 4/6] soc: fsl: qe: fix sparse warnings for qe_ic.c

2020-03-12 Thread Li Yang
/fsl/qe/qe_ic.c:450:26:expected restricted __be32 [noderef] [usertype] *base drivers/soc/fsl/qe/qe_ic.c:450:26:got unsigned int [noderef] [usertype] *regs Signed-off-by: Li Yang --- drivers/soc/fsl/qe/qe_ic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH 3/6] soc: fsl: qe: fix sparse warnings for ucc.c

2020-03-12 Thread Li Yang
address spaces) drivers/soc/fsl/qe/ucc.c:652:9:expected void volatile [noderef] *addr drivers/soc/fsl/qe/ucc.c:652:9:got restricted __be32 * Signed-off-by: Li Yang --- drivers/soc/fsl/qe/ucc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/fsl/qe/ucc.c b

[PATCH 0/6] Fix sparse warnings for common qe library code

2020-03-12 Thread Li Yang
and hence triggered more sparse warnings for the endian mismatch. Some of these endian issues are real issues that need to be fixed. While at it, fixed some direct de-references of IO memory space and suppressed other __iomem address space mismatch issues by adding correct address space attributes. Li

[PATCH 6/6] soc: fsl: qe: fix sparse warnings for ucc_slow.c

2020-03-12 Thread Li Yang
drivers/soc/fsl/qe/ucc_slow.c:297:9:got restricted __be16 * Also removed the unneccessary clearing for kzalloc'ed structure. Signed-off-by: Li Yang --- drivers/soc/fsl/qe/ucc_slow.c | 33 + include/soc/fsl/qe/ucc_slow.h | 13 ++--- 2 files changed, 19

Re: usb: gadget: fsl_udc_core: Checking for a failed platform_get_irq() call in fsl_udc_probe()

2020-04-08 Thread Li Yang
On Wed, Apr 8, 2020 at 9:19 AM Markus Elfring wrote: > > Hello, > > I have taken another look at the implementation of the function > “fsl_udc_probe”. > A software analysis approach points the following source code out for > further development considerations. >

Re: [PATCH 6/6] soc: fsl: qe: fix sparse warnings for ucc_slow.c

2020-03-17 Thread Li Yang
On Mon, Mar 16, 2020 at 4:08 PM Rasmus Villemoes wrote: > > On 12/03/2020 23.28, Li Yang wrote: > > Fixes the following sparse warnings: > > > [snip] > > > > Also removed the unneccessary clearing for kzalloc'ed structure. > > Please don't mix that in the s

Re: [PATCH] soc: fsl: qe: Replace one-element array and use struct_size() helper

2020-05-20 Thread Li Yang
On Mon, May 18, 2020 at 5:57 PM Kees Cook wrote: > > On Mon, May 18, 2020 at 05:19:04PM -0500, Gustavo A. R. Silva wrote: > > The current codebase makes use of one-element arrays in the following > > form: > > > > struct something { > > int length; > > u8 data[1]; > > }; > > > > struct

Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

2020-09-01 Thread Li Yang
On Mon, Aug 31, 2020 at 8:57 PM Herbert Xu wrote: > > On Tue, Sep 01, 2020 at 01:50:38AM +, Leo Li wrote: > > > > Sorry for the late response. I missed this email previously. > > > > These structures are descriptors used by hardware, we cannot have _ANY_ > > padding from the compiler. The

Re: [PATCH v1] soc: fsl: rcpm: Add ACPI support

2020-09-22 Thread Li Yang
On Wed, Sep 16, 2020 at 1:12 AM Ard Biesheuvel wrote: > > On 9/16/20 3:32 AM, Ran Wang wrote: > > Hi Ard, > > > > On Tuesday, September 15, 2020 7:10 PM, Ard Biesheuvel wrote: > >> Subject: Re: [PATCH v1] soc: fsl: rcpm: Add ACPI support > >> > >> On 9/15/20 1:06 PM, kuldip dwivedi wrote: > >>>

Re: [PATCH -next] soc/qman: convert to use be32_add_cpu()

2020-09-22 Thread Li Yang
On Sun, Sep 13, 2020 at 10:56 PM Liu Shixin wrote: > > Signed-off-by: Liu Shixin > drivers/soc/fsl/qbman/qman_test_api.c--- The patch seems to be messed up here. I have fixed that, and applied for next. Thanks. > drivers/soc/fsl/qbman/qman_test_api.c | 2 +- > 1 file changed, 1

Re: [PATCH] soc: fsl: dpio: remove set but not used 'addr_cena'

2020-09-22 Thread Li Yang
On Sun, Sep 20, 2020 at 3:20 PM Krzysztof Kozlowski wrote: > > On Thu, 10 Sep 2020 at 16:57, Jason Yan wrote: > > > > This addresses the following gcc warning with "make W=1": > > > > drivers/soc/fsl/dpio/qbman-portal.c: In function > > ‘qbman_swp_enqueue_multiple_direct’: > >

Re: [PATCH -next] soc: fsl: qe: Remove unnessesary check in ucc_set_tdm_rxtx_clk

2020-09-22 Thread Li Yang
On Tue, Aug 4, 2020 at 9:04 AM Wang Hai wrote: > > Fix smatch warning: > > drivers/soc/fsl/qe/ucc.c:526 > ucc_set_tdm_rxtx_clk() warn: unsigned 'tdm_num' is never less than zero. > > 'tdm_num' is u32 type, never less than zero. > > Signed-off-by: Wang Hai Applied for next. Thanks. > --- >

Re: [PATCH] soc: fsl: qbman: Fix return value on success

2020-09-22 Thread Li Yang
On Sun, Sep 20, 2020 at 3:27 PM Krzysztof Kozlowski wrote: > > On error the function was meant to return -ERRNO. This also fixes > compile warning: > > drivers/soc/fsl/qbman/bman.c:640:6: warning: variable 'err' set but not > used [-Wunused-but-set-variable] > > Fixes: 0505d00c8dba

Re: [v3 2/2] dts: ppc: t1024rdb: remove interrupts property

2020-05-27 Thread Li Yang
: > $ hwclock.util-linux > hwclock.util-linux: select() to /dev/rtc0 > to wait for clock tick timed out > > Signed-off-by: Biwen Li Acked-by: Li Yang > --- > arch/powerpc/boot/dts/fsl/t1024rdb.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerp

Re: [v3 1/2] dts: ppc: t4240rdb: remove interrupts property

2020-05-27 Thread Li Yang
: > $ hwclock.util-linux > hwclock.util-linux: select() to /dev/rtc0 > to wait for clock tick timed out > > Signed-off-by: Biwen Li Acked-by: Li Yang > --- > arch/powerpc/boot/dts/fsl/t4240rdb.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/powerp

Re: [PATCH] soc: fsl: qe: Replace one-element array and use struct_size() helper

2020-05-26 Thread Li Yang
On Sun, May 24, 2020 at 9:49 PM Qiang Zhao wrote: > > On Wed, May 23, 2020 at 5:22 PM Li Yang > > -Original Message- > > From: Li Yang > > Sent: 2020年5月23日 5:22 > > To: Kees Cook > > Cc: Gustavo A. R. Silva ; Qiang Zhao > > ; linuxppc-dev ;

Re: [v2 2/2] dts: ppc: t1024rdb: remove interrupts property

2020-05-22 Thread Li Yang
On Wed, May 20, 2020 at 4:21 AM Biwen Li wrote: > > From: Biwen Li > > This removes interrupts property to drop warning as follows: > - $ hwclock.util-linux > hwclock.util-linux: select() to /dev/rtc0 > to wait for clock tick timed out > > My case: > - RTC ds1339s INT pin

Re: [v2 1/2] dts: ppc: t4240rdb: remove interrupts property

2020-05-22 Thread Li Yang
On Wed, May 20, 2020 at 4:21 AM Biwen Li wrote: > > From: Biwen Li > > This removes interrupts property to drop warning as follows: > - $ hwclock.util-linux > hwclock.util-linux: select() to /dev/rtc0 > to wait for clock tick timed out > > My case: > - RTC ds1374's INT pin is

Re: [PATCH] soc: fsl: qe: clean up an indentation issue

2020-05-22 Thread Li Yang
On Fri, Mar 27, 2020 at 11:15 AM Colin King wrote: > > From: Colin Ian King > > There is a statement that not indented correctly, remove the > extraneous space. > > Signed-off-by: Colin Ian King Applied for next. Thanks. > --- > drivers/soc/fsl/qe/ucc.c | 2 +- > 1 file changed, 1

Re: [PATCH -next] soc: fsl: dpio: Remove unused inline function qbman_write_eqcr_am_rt_register

2020-05-22 Thread Li Yang
On Fri, May 8, 2020 at 9:13 AM YueHaibing wrote: > > There's no callers in-tree anymore since commit > 3b2abda7d28c ("soc: fsl: dpio: Replace QMAN array mode with ring mode > enqueue") > > Signed-off-by: YueHaibing Applied to next. Thanks. Regards, Leo > --- >

Re: [PATCH] soc: fsl: qe: Replace one-element array and use struct_size() helper

2020-05-22 Thread Li Yang
On Wed, May 20, 2020 at 10:24 PM Kees Cook wrote: > > On Wed, May 20, 2020 at 06:52:21PM -0500, Li Yang wrote: > > On Mon, May 18, 2020 at 5:57 PM Kees Cook wrote: > > > Hm, looking at this code, I see a few other things that need to be > > > fixed: > > >

Re: [PATCH] treewide: Replace zero-length array with flexible-array

2020-05-22 Thread Li Yang
On Thu, May 7, 2020 at 1:49 PM Gustavo A. R. Silva wrote: > > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99:

Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()

2020-05-22 Thread Li Yang
;> Thus adjust the error detection and corresponding exception handling. > >> Got it. > > Wow... > > > > No, don't listen to Markus when it comes to writing commit messages. > > You couldn't find worse advice anywhere. :P > > I'm actively waiting for a reply from the maintainer. Thank you very much. Sorry for the late response. Acked-by: Li Yang Regards, Leo

Re: [PATCH] soc: fsl: qe: Replace one-element array and use struct_size() helper

2020-05-22 Thread Li Yang
On Mon, May 18, 2020 at 5:16 PM Gustavo A. R. Silva wrote: > > The current codebase makes use of one-element arrays in the following > form: > > struct something { > int length; > u8 data[1]; > }; > > struct something *instance; > > instance = kmalloc(sizeof(*instance) + size,

Re: [PATCH -next] soc: fsl: qbman: Remove unused inline function qm_eqcr_get_ci_stashing

2020-05-22 Thread Li Yang
On Fri, May 8, 2020 at 9:11 AM YueHaibing wrote: > > There's no callers in-tree anymore. > > Signed-off-by: YueHaibing Applied for next. Thanks. Regards, Leo > --- > drivers/soc/fsl/qbman/qman.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/soc/fsl/qbman/qman.c

Re: [PATCH] net/ethernet/freescale: Fix incorrect IS_ERR_VALUE macro usages

2020-11-25 Thread Li Yang
On Tue, Nov 24, 2020 at 8:00 PM liwei (GF) wrote: > > Hi Yang, > > On 2020/11/25 6:13, Li Yang wrote: > > On Tue, Nov 24, 2020 at 3:44 PM Li Yang wrote: > >> > >> On Tue, Nov 24, 2020 at 12:24 AM Wei Li wrote: > >>> > >>> IS

Re: [PATCH 02/20] ethernet: ucc_geth: fix definition and size of ucc_geth_tx_global_pram

2020-12-08 Thread Li Yang
On Sat, Dec 5, 2020 at 1:21 PM Rasmus Villemoes wrote: > > Table 8-53 in the QUICC Engine Reference manual shows definitions of > fields up to a size of 192 bytes, not just 128. But in table 8-111, > one does find the text > > Base Address of the Global Transmitter Parameter RAM Page. [...] >

Re: [PATCH] net/ethernet/freescale: Fix incorrect IS_ERR_VALUE macro usages

2020-11-24 Thread Li Yang
On Tue, Nov 24, 2020 at 12:24 AM Wei Li wrote: > > IS_ERR_VALUE macro should be used only with unsigned long type. > Especially it works incorrectly with unsigned shorter types on > 64bit machines. This is truly a problem for the driver to run on 64-bit architectures. But from an earlier

Re: [PATCH] net/ethernet/freescale: Fix incorrect IS_ERR_VALUE macro usages

2020-11-24 Thread Li Yang
On Tue, Nov 24, 2020 at 3:44 PM Li Yang wrote: > > On Tue, Nov 24, 2020 at 12:24 AM Wei Li wrote: > > > > IS_ERR_VALUE macro should be used only with unsigned long type. > > Especially it works incorrectly with unsigned shorter types on > > 64bit machine

Re: [PATCH 25/25] soc: fsl: qbman: qman: Remove unused variable 'dequeue_wq'

2020-11-23 Thread Li Yang
d-but-set-variable] > > Cc: Li Yang > Cc: YueHaibing > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Lee Jones > --- > drivers/soc/fsl/qbman/qman.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/soc/fsl/qbman/qman.c b/dr

Re: [PATCH v3] soc: fsl: dpio: Get the cpumask through cpumask_of(cpu)

2020-11-23 Thread Li Yang
On Mon, Oct 19, 2020 at 9:15 PM Yi Wang wrote: > > From: Hao Si > > The local variable 'cpumask_t mask' is in the stack memory, and its address > is assigned to 'desc->affinity' in 'irq_set_affinity_hint()'. > But the memory area where this variable is located is at risk of being > modified. > >

Re: [PATCH 00/25] Rid W=1 warnings in SoC

2020-11-23 Thread Li Yang
on > Cc: Florian Fainelli > Cc: Heiko Stuebner > Cc: Jonathan Hunter > Cc: Krzysztof Kozlowski > Cc: Liam Girdwood > Cc: linux-arm-...@vger.kernel.org > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-rockc...@lists.infradead.org > Cc: linux-samsung-...@vger.kernel

Re: [PATCH v6 04/49] soc: fsl: qe: introduce qe_io{read, write}* wrappers

2021-01-19 Thread Li Yang
On Tue, Jan 19, 2021 at 11:35 AM Christophe Leroy wrote: > > Hi Rasmus, > > Le 28/11/2019 à 15:55, Rasmus Villemoes a écrit : > > The QUICC engine drivers use the powerpc-specific out_be32() etc. In > > order to allow those drivers to build for other architectures, those > > must be replaced by

[PATCH] usb: gadget: fsl: properly remove remnant of MXC support

2021-06-11 Thread Li Yang
Commit a390bef7db1f ("usb: gadget: fsl_mxc_udc: Remove the driver") didn't remove all the MXC related stuff which can cause build problem for LS1021 when enabled again in Kconfig. This patch remove all the remnants. Signed-off-by: Li Yang --- drivers/usb/gadget/udc/fsl_udc_c

Re: [PATCH] soc/fsl: qbman: fix conflicting alignment attributes

2021-03-25 Thread Li Yang
On Tue, Mar 23, 2021 at 8:17 AM Arnd Bergmann wrote: > > From: Arnd Bergmann > > When building with W=1, gcc points out that the __packed attribute > on struct qm_eqcr_entry conflicts with the 8-byte alignment > attribute on struct qm_fd inside it: > > drivers/soc/fsl/qbman/qman.c:189:1: error:

Re: [PATCH v6] soc: fsl: enable acpi support in RCPM driver

2021-04-06 Thread Li Yang
On Fri, Mar 12, 2021 at 2:56 AM Ran Wang wrote: > > From: Peng Ma > > This patch enables ACPI support in RCPM driver. > > Signed-off-by: Peng Ma > Signed-off-by: Ran Wang > --- > Change in v6: > - Remove copyright udpate to rebase on latest mainline > > Change in v5: > - Fix panic when

Re: [PATCH v1 0/3] Remove qe_io{read,write}* IO accessors

2021-04-06 Thread Li Yang
On Sat, Mar 6, 2021 at 12:11 PM Christophe Leroy wrote: > > Commit 6ac9b61786cc ("soc: fsl: qe: introduce qe_io{read,write}* > wrappers") added specific I/O accessors for qe because at that > time ioread/iowrite functions were sub-optimal on powerpc/32 > compared to the architecture specific

Re: [PATCH v7] soc: fsl: enable acpi support in RCPM driver

2021-04-08 Thread Li Yang
On Wed, Apr 7, 2021 at 9:58 PM Ran Wang wrote: > > From: Peng Ma > > This patch enables ACPI support in RCPM driver. > > Signed-off-by: Peng Ma > Signed-off-by: Ran Wang Applied for next. Thanks. > --- > Change in v7: > - Update comment for checking RCPM node which refferred to > > Change

Re: [PATCH] soc: fsl: qe: fix static checker warning

2021-08-13 Thread Li Yang
On Wed, Aug 11, 2021 at 2:10 AM Maxim Kochetkov wrote: > > The patch be7ecbd240b2: "soc: fsl: qe: convert QE interrupt > controller to platform_device" from Aug 3, 2021, leads to the > following static checker warning: > > drivers/soc/fsl/qe/qe_ic.c:438 qe_ic_init() > warn:

Re: [PATCH] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-07-14 Thread Li Yang
On Mon, Jul 5, 2021 at 6:12 AM Maxim Kochetkov wrote: > > Since 5.13 QE's ucc nodes can't get interrupts from devicetree: > > ucc@2000 { > cell-index = <1>; > reg = <0x2000 0x200>; > interrupts = <32>; > interrupt-parent =

Re: [PATCH] soc: fsl: guts: Fix a resource leak in the error handling path of 'fsl_guts_probe()'

2021-10-21 Thread Li Yang
On Wed, Aug 18, 2021 at 4:23 PM Christophe JAILLET wrote: > > If an error occurs after 'of_find_node_by_path()', the reference taken for > 'root' will never be released and some memory will leak. Thanks for finding this. This truly is a problem. > > Instead of adding an error handling path and

Re: [PATCH 1/2] soc: fsl: guts: Make use of the helper function devm_platform_ioremap_resource()

2021-10-21 Thread Li Yang
On Wed, Sep 8, 2021 at 2:19 AM Cai Huoqing wrote: > > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Applied for next. Thanks. > --- > drivers/soc/fsl/guts.c | 4 +--- > 1

Re: [PATCH 2/2] soc: fsl: rcpm: Make use of the helper function devm_platform_ioremap_resource()

2021-10-21 Thread Li Yang
On Wed, Sep 8, 2021 at 2:20 AM Cai Huoqing wrote: > > Use the devm_platform_ioremap_resource() helper instead of > calling platform_get_resource() and devm_ioremap_resource() > separately > > Signed-off-by: Cai Huoqing Applied for next. Thanks. > --- > drivers/soc/fsl/rcpm.c | 7 +-- > 1

Re: [PATCH v2] soc: fsl: dpio: instead smp_processor_id with raw_smp_processor_id

2021-10-19 Thread Li Yang
On Mon, Oct 18, 2021 at 9:46 PM wrote: > > From: Meng Li > > When enable debug kernel configs,there will be calltrace as below: > > BUG: using smp_processor_id() in preemptible [] code: swapper/0/1 > caller is debug_smp_processor_id+0x20/0x30 > CPU: 6 PID: 1 Comm: swapper/0 Not tainted

Re: [PATCH] driver: soc: dpio: use the whole functions to protect critical zone

2021-10-19 Thread Li Yang
On Mon, Oct 18, 2021 at 10:07 PM wrote: > > From: Meng Li > > In orininal code, use 2 function spin_lock() and local_irq_save() to > protect the critical zone. But when enable the kernel debug config, > there are below inconsistent lock state detected. > >

Re: [PATCH 1/5] dt-bindings: memory: fsl: convert ifc binding to yaml schema

2021-10-08 Thread Li Yang
On Mon, Oct 4, 2021 at 4:32 AM Krzysztof Kozlowski wrote: > > On 01/10/2021 18:17, Li Yang wrote: > > On Fri, Oct 1, 2021 at 5:01 AM Krzysztof Kozlowski > > wrote: > >> > > (...) > > >>> + > >>> + interrupts: > >

Re: [PATCH 2/5] memory: fsl_ifc: populate child devices without relying on simple-bus

2021-10-08 Thread Li Yang
On Mon, Oct 4, 2021 at 12:14 PM Rob Herring wrote: > > On Thu, Sep 30, 2021 at 07:09:21PM -0500, Li Yang wrote: > > After we update the binding to not use simple-bus compatible for the > > controller, we need the driver to populate the child devices explicitly. > > &g

[PATCH 1/5] dt-bindings: memory: fsl: convert ifc binding to yaml schema

2021-09-30 Thread Li Yang
r to probe the child devices to work properly. Signed-off-by: Li Yang --- updates from previous submission: - Drop "simple-bus" from binding and only "fsl,ifc" as compatible - Fix one identiation problem of "reg" - Add type restriction to "little-endian" prop

[PATCH 3/5] ARM: dts: ls1021a: remove "simple-bus" compatible from ifc node

2021-09-30 Thread Li Yang
The binding of ifc device has been updated. Update dts to match accordingly. Signed-off-by: Li Yang --- arch/arm/boot/dts/ls1021a.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index 7cddc05825a1

[PATCH 0/5] convert ifc binding to yaml and drop "simple-bus"

2021-09-30 Thread Li Yang
ng changes if DTS maintainer is ok with it or after the driver changes are applied. Li Yang (5): dt-bindings: memory: fsl: convert ifc binding to yaml schema memory: fsl_ifc: populate child devices without relying on simple-bus ARM: dts: ls1021a: remove "simple-bus" compatible from i

[PATCH 4/5] arm64: dts: remove "simple-bus" compatible from ifc node

2021-09-30 Thread Li Yang
The binding of ifc device has been updated. Update dts to match accordingly. Signed-off-by: Li Yang --- arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 2 +- arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 2 +- arch/arm64/boot/dts

[PATCH 5/5] powerpc/mpc85xx: remove "simple-bus" compatible from ifc node

2021-09-30 Thread Li Yang
The binding of ifc device has been updated. Update dts to match accordingly. Signed-off-by: Li Yang --- arch/powerpc/boot/dts/fsl/b4si-post.dtsi | 2 +- arch/powerpc/boot/dts/fsl/bsc9131si-post.dtsi | 2 +- arch/powerpc/boot/dts/fsl/bsc9132si-post.dtsi | 2 +- arch/powerpc/boot/dts/fsl

[PATCH 2/5] memory: fsl_ifc: populate child devices without relying on simple-bus

2021-09-30 Thread Li Yang
After we update the binding to not use simple-bus compatible for the controller, we need the driver to populate the child devices explicitly. Signed-off-by: Li Yang --- drivers/memory/fsl_ifc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/memory/fsl_ifc.c b/drivers

Re: [PATCH 1/5] dt-bindings: memory: fsl: convert ifc binding to yaml schema

2021-10-01 Thread Li Yang
On Fri, Oct 1, 2021 at 5:01 AM Krzysztof Kozlowski wrote: > > On 01/10/2021 02:09, Li Yang wrote: > > Convert the txt binding to yaml format and add description. Drop the > > "simple-bus" compatible string from the example and not allowed by the > > binding an

Re: [PATCH 1/5] dt-bindings: memory: fsl: convert ifc binding to yaml schema

2021-10-01 Thread Li Yang
On Fri, Oct 1, 2021 at 8:18 AM Rob Herring wrote: > > On Thu, 30 Sep 2021 19:09:20 -0500, Li Yang wrote: > > Convert the txt binding to yaml format and add description. Drop the > > "simple-bus" compatible string from the example and not allowed by the > >

Re: [PATCH 0/5] convert ifc binding to yaml and drop "simple-bus"

2021-10-01 Thread Li Yang
On Fri, Oct 1, 2021 at 4:46 AM Krzysztof Kozlowski wrote: > > On 01/10/2021 02:09, Li Yang wrote: > > Convert the ifc binding to yaml schema, in the mean while remove the > > "simple-bus" compatible from the binding to make sure ifc device probes > > before

<    1   2   3   4   5   6   >