Re: [PATCH] Only disable/enable LSI interrupts in EEH

2009-02-10 Thread Linas Vepstas
Looks good to me. Acked-by: Linas Vepstas linasveps...@gmail.com On a somewhat-related note: there was an issue (I forget the details) where the kernel needed to shadow some sort of MSI state so that it could be correctly, um, kept-track-of, after an EEH reset (it didn't need to be restored

Re: [PATCH] Only disable/enable LSI interrupts in EEH

2009-02-10 Thread Linas Vepstas
2009/2/10 Michael Ellerman mich...@ellerman.id.au: On Tue, 2009-02-10 at 11:14 -0600, Linas Vepstas wrote: On a somewhat-related note: there was an issue (I forget the details) where the kernel needed to shadow some sort of MSI state so that it could be correctly, um, kept-track-of, after

Re: [PATCH] Set error_state to pci_channel_io_normal in eeh_report_reset()

2009-04-14 Thread Linas Vepstas
and the e1000 did, too ... Hmm. Perhaps these used their own, private flag for the same purpose, and reset it at the earlier, correct time. Thanks for the fix! Signed-off-by: Linas Vepstas linasveps...@gmail.com ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem

2008-02-15 Thread Linas Vepstas
On 14/02/2008, Tony Breeds [EMAIL PROTECTED] wrote: On Tue, Feb 12, 2008 at 01:11:58AM -0600, Manish Ahuja wrote: +static ssize_t +show_release_region(struct kset * kset, char *buf) +{ + return sprintf(buf, ola\n); +} + +static struct subsys_attribute rr =

Re: [PATCH 3/8] pseries: phyp dump: use sysfs to release reserved mem

2008-03-12 Thread Linas Vepstas
On 11/03/2008, Paul Mackerras [EMAIL PROTECTED] wrote: -- This line needs to be exactly 3 dashes, because otherwise the tools include the diffstat into the commit message. Putting 4 or more dashes was an annoying habit Linas had, and it means I have to fix it manually (usually

Re: [PATCH 2/8] pseries: phyp dump: reserve-release proof-of-concept

2008-03-12 Thread Linas Vepstas
On 10/03/2008, Michael Ellerman [EMAIL PROTECTED] wrote: On Thu, 2008-02-28 at 18:24 -0600, Manish Ahuja wrote: + +/* Global, used to communicate data between early boot and late boot */ +static struct phyp_dump phyp_dump_global; +struct phyp_dump *phyp_dump_info = phyp_dump_global;

Re: [PATCH] pseries: phyp dump: Variable size reserve space.

2008-04-16 Thread Linas Vepstas
On 07/04/2008, Manish Ahuja [EMAIL PROTECTED] wrote: A small proposed change in the amount of reserve space we allocate during boot. Currently we reserve 256MB only. The proposed change does one of the 3 things. A. It checks to see if there is cmdline variable set and if found sets the

[PATCH] pseries: Re: Minor: Removed double return.

2007-07-06 Thread Linas Vepstas
You want to say its a patch in the subject line. --linas On Fri, Jul 06, 2007 at 04:59:55PM -0500, Manish Ahuja wrote: Found 2 instances of return one right after each other in arch_add_memory(). This minor patch fixes it. Signed-off-by:Manish Ahuja [EMAIL PROTECTED] Index:

Re: [PATCH] Allow exec on 32-bit from readable, non-exec pages, with a warning.

2007-07-09 Thread Linas Vepstas
On Mon, Jul 09, 2007 at 04:16:40PM -0500, Scott Wood wrote: Arnd Bergmann wrote: I may be missing the obvious, but doesn't that defeat the purpose of non-executable mappings? The hardware in question doesn't support non-executable mappings; otherwise, it'd never have worked in the first

Re: [PATCH 1/2] [ide] mmio ide support

2007-07-10 Thread Linas Vepstas
On Sun, Jul 08, 2007 at 03:15:41PM +0200, Bartlomiej Zolnierkiewicz wrote: on the argument that drivers/ide/ is going away soon. Most current distros have already moved over to using libata exclusively. The in-kernel default for PATA systems is still IDE subsystem. In part because

Re: [PATCH] crash in 2.6.22-git2 sysctl_set_parent()

2007-07-16 Thread Linas Vepstas
On Fri, Jul 13, 2007 at 07:06:56PM -0600, Eric W. Biederman wrote: .data = ipv4_devconf.loop, .maxlen = sizeof(int), .mode = 0644, + .child = 0x0, .proc_handler

[PATCH] iommu virtual merge no longer experimental

2007-07-17 Thread Linas Vepstas
Per conversations with BenH, iommu virtual merging should no longer be considered to be an experimental feature. In particular, CONFIG_VMERGE has been set to y in te defconfigs for quite a while. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/Kconfig | 11 ++- 1

Re: dlopen source

2007-07-26 Thread Linas Vepstas
On Thu, Jul 26, 2007 at 12:47:57PM -0700, Siva Prasad wrote: Hi, Can some one point to where I can find the source code for dlopen() function. ? Should be in glibc, right? I don't remember f it requires binutils pieces or not. (Yes, glibc is a rats nest, so understanding how it works is a

[PATCH 0/3] powerpc/eeh: for 2.6.23: a fix for bridges, and tweaks

2007-07-26 Thread Linas Vepstas
Paul, The following three patches should be low impact, and I think they could go into 2.6.23 if its not too late. -- two are formating/printing fixes/enhancements -- one fixes the way PCI cards with bridges are handled; in particular, it avoids a nll pointer deref, so is a serious bugfix.

[PATCH 3/3] powerpc/eeh: dump pci bridge status on event

2007-07-26 Thread Linas Vepstas
Gather bridge-specific data on EEH events. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/platforms/pseries/eeh.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) Index: linux-2.6.22-git2/arch/powerpc/platforms/pseries/eeh.c

[PATCH 1/3] powerpc/eeh: tweak printk message.

2007-07-26 Thread Linas Vepstas
Print return code to print message. Also fix whitespace. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/platforms/pseries/eeh.c |8 1 file changed, 4 insertions(+), 4 deletions(-) Index: linux-2.6.22-git2/arch/powerpc/platforms/pseries/eeh.c

EDAC PCI error recovery (was Re: [PATCH 2/2] powerpc: MPC85xx EDAC device driver)

2007-08-01 Thread Linas Vepstas
On Mon, Jul 30, 2007 at 03:47:05PM -0700, Doug Thompson wrote: --- Linas Vepstas [EMAIL PROTECTED] wrote: Also: please note that the linux kernel has a pci error recovery mechanism built in; its used by pseries and PCI-E. I'm not clear on what any of this has to do with EDAC, which I

Re: [PATCH]: PCI Error Recovery: Symbios SCSI device driver

2007-08-02 Thread Linas Vepstas
On Thu, Jul 05, 2007 at 12:54:06PM -0600, Matthew Wilcox wrote: On Thu, Jul 05, 2007 at 11:28:38AM -0700, Andrew Morton wrote: Well you've sent it a couple of times, and I've sent it in five more times over the past year. Once we were told awaiting maintainer ack. This situation is

Page faults blowing up ... [was Re: [PATCH] Fix special PTE code for secondary hash bucket

2007-08-03 Thread Linas Vepstas
On Fri, Aug 03, 2007 at 06:58:51PM +1000, Paul Mackerras wrote: The code for mapping special 4k pages on kernels using a 64kB base page size was missing the code for doing the RPN (real page number) manipulation when inserting the hardware PTE in the secondary hash bucket. It needs the same

[PATCH 0/6] pseries: rtas nvram cleanup/simpilification

2007-08-08 Thread Linas Vepstas
Paul, Please apply te following for 2.6.24 The following sequence of patches cleanup, simplify and shorten the pseries code having to do with error logging. Several global variables shared across directories are removed, and the rtasd initialization sequence is rearranged and simplified, making

[PATCH 2/6] pseries: use rtas_token instead of hand-rolled code

2007-08-08 Thread Linas Vepstas
The rtas_token() call does the same thing as this hand-rolled code. This makes the code easier to read. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/platforms/pseries/rtasd.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) Index: linux-2.6.22-git2

[PATCH 4/6] powerpc: remove nvram forward declarations

2007-08-08 Thread Linas Vepstas
Forward declarations serve no purpose in this file. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/kernel/nvram_64.c |5 - 1 file changed, 5 deletions(-) Index: linux-2.6.22-git2/arch/powerpc/kernel/nvram_64.c

Re: [PATCH 1/6] pseries: avoid excess rtas calls

2007-08-08 Thread Linas Vepstas
On Wed, Aug 08, 2007 at 04:57:39PM -0500, Nathan Lynch wrote: Linas Vepstas wrote: We don't need to look up the rtas event token once per cpu per second. This avoids some misc string ops and rtas calls and provides some minor performance improvement. It does not avoid any calls

Re: [PATCH 6/6] pseries: eliminate global var

2007-08-08 Thread Linas Vepstas
On Wed, Aug 08, 2007 at 04:57:14PM -0500, Nathan Lynch wrote: Linas Vepstas wrote: + +#ifdef CONFIG_PPC_PSERIES +extern int pSeries_nvram_init(void); +extern int nvram_write_error_log(char * buff, int length, +unsigned int err_type, unsigned int

[PATCH 6/6 v2] pseries: eliminate global var

2007-08-09 Thread Linas Vepstas
Eliminate the use of error_log_cnt as a global var shared across differnt directories. Pass it as a subroutine arg instead. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Respin of earlier patch, with the CONFIG_PSERIES junk removed from the header file. arch/powerpc/kernel/nvram_64.c

[PATCH 1/6 v2] pseries: avoid excess rtas calls

2007-08-09 Thread Linas Vepstas
We don't need to look up the rtas event token once per cpu per second. This avoids some misc device-tree lookups and string ops and so provides some minor performance improvement. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Revised commit-log message. arch/powerpc/platforms/pseries

[PATCH 1/2] pseries: device node status can be ok or okay

2007-08-09 Thread Linas Vepstas
exceptions, and we'll have a very unhappy system. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Paul, This is a bug with serious reprecussions ... but appearently affects only a few systems, so far. I've never seen it before. Your pick as to whether to jam this into 2.6.23 or wait

Re: [PATCH 1/2] Add scaled time to taskstats based process accounting

2007-08-16 Thread Linas Vepstas
On Thu, Aug 16, 2007 at 05:09:22PM +1000, Michael Neuling wrote: This adds two items to the taststats struct to account for user and system time based on scaling the CPU frequency and instruction issue rates. Adds account_(user|system)_time_scaled callbacks which architectures can use to

Re: [PATCH 1/2] Add scaled time to taskstats based process accounting

2007-08-17 Thread Linas Vepstas
On Fri, Aug 17, 2007 at 08:22:40AM +1000, Paul Mackerras wrote: Linas Vepstas writes: My gut impression (maybe wrong?) is that the scaled time is, in a certain sense, more accurate than the unscaled time. The unscaled time is just time, as in how many seconds did this task spend

Re: How to port PReP to arch/powerpc?

2007-08-22 Thread Linas Vepstas
On Wed, Aug 22, 2007 at 07:29:56AM -0500, Josh Boyer wrote: David Gibson and Rob Landley had a quite interesting discussion about PReP last night on IRC. ?? Where? I scrolled back on #ppc64 on freenode, and see no such conversation. --linas ___

Re: [PATCH] ppc: remove unused amiga_request_irq and mach_request_irq

2007-08-22 Thread Linas Vepstas
On Wed, Aug 22, 2007 at 07:44:41PM +1000, Paul Mackerras wrote: Fernando Luis Vázquez Cao writes: amiga_request_irq and mach_request_irq are never used, so delete them. OK, but is there a particular reason you want to do this? The whole of arch/ppc is going away eventually, so I don't

Re: RFC: issues concerning the next NAPI interface

2007-08-24 Thread Linas Vepstas
On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote: 3) On modern systems the incoming packets are processed very fast. Especially    on SMP systems when we use multiple queues we process only a few packets    per napi poll cycle. So NAPI does not work very well here and the

Re: RFC: issues concerning the next NAPI interface

2007-08-24 Thread Linas Vepstas
On Fri, Aug 24, 2007 at 08:52:03AM -0700, Stephen Hemminger wrote: You need hardware support for deferred interrupts. Most devices have it (e1000, sky2, tg3) and it interacts well with NAPI. It is not a generic thing you want done by the stack, you want the hardware to hold off interrupts

Re: RFC: issues concerning the next NAPI interface

2007-08-24 Thread Linas Vepstas
On Fri, Aug 24, 2007 at 09:04:56PM +0200, Bodo Eggert wrote: Linas Vepstas [EMAIL PROTECTED] wrote: On Fri, Aug 24, 2007 at 03:59:16PM +0200, Jan-Bernd Themann wrote: 3) On modern systems the incoming packets are processed very fast. Especially on SMP systems when we use multiple queues

Re: RFC: issues concerning the next NAPI interface

2007-08-24 Thread Linas Vepstas
On Fri, Aug 24, 2007 at 02:44:36PM -0700, David Miller wrote: From: David Stevens [EMAIL PROTECTED] Date: Fri, 24 Aug 2007 09:50:58 -0700 Problem is if it increases rapidly, you may drop packets before you notice that the ring is full in the current estimated interval. This is

Re: [PATCH 2.6.23] ibmebus: Prevent bus_id collisions

2007-08-30 Thread Linas Vepstas
On Thu, Aug 30, 2007 at 04:00:56PM +0200, Joachim Fenkes wrote: Plus, I rather like using the full_name since it also contains a descriptive name as opposed to being just nondescript numbers, helping the layman (ie user) to make sense out of a dev_id. Yes, well, but no. The location code

Re: Keep On Debugging You

2007-09-06 Thread Linas Vepstas
On Thu, Sep 06, 2007 at 10:21:43AM -0500, Timur Tabi wrote: Zhang Wei-r63237 wrote: Oops! Could you give us a live show version? :D Sorry, I'm booked up for the rest of the year. Hmm. Maybe someone could sneak a videocam into one of the venues, and, you know, post a pirated, illegal

[PATCH 0/3] powerpc: whitespace cleanup, grammar corrections

2007-09-06 Thread Linas Vepstas
These popped out at me while I was reading code. Its all janitorial. --linas ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH 2/3] powerpc: prom whitespace cleanup

2007-09-06 Thread Linas Vepstas
Whitespace cleanup: badly indented lines. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/kernel/prom.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Index: linux-2.6.22-git2/arch/powerpc/kernel/prom.c

[PATCH 1/3] powerpc: prom_init whitespace cleanup, typo fix.

2007-09-06 Thread Linas Vepstas
Whitespace cleanup: badly indented lines. Typo in comment. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/kernel/prom_init.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) Index: linux-2.6.22-git2/arch/powerpc/kernel/prom_init.c

[PATCH 3/3] powerpc: setup_64 comment cleanup.

2007-09-06 Thread Linas Vepstas
Gramatical corrections to comments. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/kernel/prom.c |8 +--- arch/powerpc/kernel/setup_64.c |6 +++--- 2 files changed, 8 insertions(+), 6 deletions(-) Index: linux-2.6.22-git2/arch/powerpc/kernel/setup_64.c

Re: [EMAIL PROTECTED]: 2.6.23-rc6-mm1 -- powerpc pSeries_log_error panic in rtas_call/early_enable_eeh]

2007-09-24 Thread Linas Vepstas
I just got back from vacation. I'll give this a whirl shortly. --linas On Sun, Sep 23, 2007 at 11:17:40AM -0500, Anton Blanchard wrote: Hi Linas, Looks like EEH could be involved :) Anton - Forwarded message from Andy Whitcroft [EMAIL PROTECTED] - From: Andy Whitcroft

Re: Help! Debian ppc64

2007-09-27 Thread Linas Vepstas
debian/ubuntu do not -- AIX on pSeries? +++ AIX has various enterprise features that Debian does not. You might try talking to RedHat/SuSE product support, and also to IBM pSeries sales. Linas Vepstas ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH 5/7] Celleb: Supports VFD on Celleb 2

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 11:07:33AM +0200, Arnd Bergmann wrote: On Thursday 27 September 2007, Ishizaki Kou wrote: This is a patch to support VFD on Celleb 2. VFD is a small LCD to show miscellaneous messages. Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] My feeling is that your

Re: tg3: PCI error recovery

2007-09-27 Thread Linas Vepstas
During a private conversation about how to save and restore device state after a pci error is detected, and the device is reset, the following came up: On Wed, Sep 26, 2007 at 04:48:38PM -0700, Michael Chan wrote: 1b) If so, is it safe to call pci_save_state() in

Re: 2.6.23-rc8 dies somewhere during boot!?

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 09:12:33PM +0200, Gerhard Pircher wrote: Hi, I'm working on a 2.6.23 kernel for the AmigaOne. [...] 6PCI: Probing PCI hardware. 7PCI: Scanning bus 0... ...00:00:07.0. 7PCI: Calling quirk... ...CI: Found :00:07.2 [1106/303... Any chance that this thing has

Re: 2.6.23-rc8 dies somewhere during boot!?

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 09:31:31PM +0200, Gerhard Pircher wrote: Betreff: Re: 2.6.23-rc8 dies somewhere during boot!? I'm working on a 2.6.23 kernel for the AmigaOne. Have you tried 2.6.22, or does that fail also? --linas ___ Linuxppc-dev

Re: 2.6.23-rc8 dies somewhere during boot!?

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 11:17:00PM +0200, Gerhard Pircher wrote: Betreff: Re: 2.6.23-rc8 dies somewhere during boot!? Do you have an idea how to debug it? Not particularly. What caught my eye was the failure right near the PCI quirk stuff, as I was having problems there as well (but

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-27 Thread Linas Vepstas
On Wed, Sep 26, 2007 at 09:02:16AM -0600, Matthew Wilcox wrote: On Fri, Apr 20, 2007 at 03:47:20PM -0500, Linas Vepstas wrote: Implement the so-called first failure data capture (FFDC) for the symbios PCI error recovery. After a PCI error event is reported, the driver requests that MMIO

Re: 2.6.23-rc8 dies somewhere during boot!?

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 11:57:35PM +0200, Gerhard Pircher wrote: Based on your boot messages, it looks like you are failing somewhere in pci probe. My olde-fashioned, slow, but-usually-works method is to sprinkle enough printk's into the code to catch it in the act. I guess the code in

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-27 Thread Linas Vepstas
On Thu, Sep 27, 2007 at 04:10:31PM -0600, Matthew Wilcox wrote: In the error handler, we wait_for_completion(io_reset_wait). In sym2_io_error_detected, we init_completion(io_reset_wait). Isn't it possible that we hit the error handler before we hit the io_error_detected path, and thus the

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-01 Thread Linas Vepstas
On Mon, Oct 01, 2007 at 02:12:47PM -0600, Matthew Wilcox wrote: I think the fundamental problem is that completions aren't really supposed to be used like this. Here's one attempt at using completions perhaps a little more the way they're supposed to be used, Yes, that looks very good to

[PATCH] powerpc: another use of zalloc_maybe_bootmem()

2007-10-02 Thread Linas Vepstas
Use alloc_maybe_bootmem() which wraps the if(mem_init_done) malloc clause. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] On Tue, Oct 02, 2007 at 01:37:53PM +1000, Stephen Rothwell wrote: This patch introduces zalloc_maybe_bootmem and uses it so that we don;t have to mark a whole

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-02 Thread Linas Vepstas
On Mon, Oct 01, 2007 at 07:27:30PM -0600, Matthew Wilcox wrote: Fine by me. Do you have the ability to produce failures on a whim on your platforms? Yes, although it is very platform specific -- there are actually transistors in the pci bridge chip, which actually short out lines, and so,

Re: 2.6.23-rc7-mm1 -- powerpc rtas panic

2007-10-02 Thread Linas Vepstas
On Mon, Sep 24, 2007 at 01:35:31PM +0100, Andy Whitcroft wrote: Seeing the following from an older power LPAR, pretty sure we had this in the previous -mm also: I haven't forgetten about this ... and am looking at it now. Seems that whenever I go to reserve the machine pSeries-102, someone else

[PATCH] powerpc: fix crash in rtas during early boot.

2007-10-03 Thread Linas Vepstas
RTAS messages can occur very early during boot, before the error message buffer has been allocated. The current code will lead to a null-pointer deref. Explicitly protect against this. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Cc: Andy Whitcroft [EMAIL PROTECTED] Andy Whitcroft's

Re: 2.6.23-rc7-mm1 -- powerpc rtas panic

2007-10-03 Thread Linas Vepstas
On Wed, Oct 03, 2007 at 02:09:46PM +1000, Michael Ellerman wrote: Until we initialise what exactly? Until we allocate the error log buffer. The original crash was for a null-pointer deref of the unallocated buffer. I just sent out a patch to fix this; its a bit simpler than the below. In

Re: Stdout console clogging = 300ms blocked

2007-10-04 Thread Linas Vepstas
Hi Bernard, On Wed, Oct 03, 2007 at 08:49:12PM +, Hollis Blanchard wrote: On Tue, 02 Oct 2007 09:41:28 +0200, Willaert, Bernard wrote: Problem: When we log debug output via the serial console on a multithreaded application, the console throughput may get clogged and then we

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-10-04 Thread Linas Vepstas
On Mon, Oct 01, 2007 at 07:27:30PM -0600, Matthew Wilcox wrote: The thing to remember is that sym2 is in transition from being a dual BSD/Linux driver to being a purely Linux driver. I was wondering about that; couldn't tell if the split in the code was historical, or being intentionally

Re: 2.6.23-rc7-mm1 -- powerpc rtas panic

2007-10-05 Thread Linas Vepstas
On Thu, Oct 04, 2007 at 05:01:47PM -0700, Nish Aravamudan wrote: On 10/2/07, Tony Breeds [EMAIL PROTECTED] wrote: On Wed, Oct 03, 2007 at 10:30:16AM +1000, Michael Ellerman wrote: I realise it'll make the patch bigger, but this doesn't seem like a particularly good name for the variable

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Linas Vepstas
On Mon, Oct 08, 2007 at 02:41:54PM -0500, Kumar Gala wrote: On Oct 8, 2007, at 2:03 PM, Grant Likely wrote: I can't see a good reason for eval board platform code to mess with the ROOT_DEV value instead of using the default behaviour (so I'm Powermac and pseries also do this

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Linas Vepstas
On Mon, Oct 08, 2007 at 03:42:21PM -0500, Linas Vepstas wrote: On Mon, Oct 08, 2007 at 02:41:54PM -0500, Kumar Gala wrote: On Oct 8, 2007, at 2:03 PM, Grant Likely wrote: I can't see a good reason for eval board platform code to mess with the ROOT_DEV value instead of using

Re: [patch v2] PS3: Add os-area database routines

2007-10-09 Thread Linas Vepstas
On Mon, Oct 08, 2007 at 06:07:24PM -0700, Geoff Levand wrote: Subject: PS3: Add os-area database routines Add support for a simple tagged database in the PS3 flash rom os-area. The database allows the flash rom os-area to be shared between a bootloader and installed operating systems. The

Re: Hard hang in hypervisor!?

2007-10-09 Thread Linas Vepstas
On Tue, Oct 09, 2007 at 04:18:19PM -0500, Nathan Lynch wrote: Linas Vepstas wrote: I was futzing with linux-2.6.23-rc8-mm1 in a power6 lpar when, for whatever reason, a spinlock locked up. The bizarre thing was that the rest of system locked up as well: an ssh terminal, and also

never mind .. [was Re: Hard hang in hypervisor!?

2007-10-09 Thread Linas Vepstas
On Tue, Oct 09, 2007 at 04:28:10PM -0500, Linas Vepstas wrote: Perhaps I should IRC this ... yeah. I guess I'd forgotten how funky things can get. So never mind ... --linas ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org

Re: [PATCH v4 or so] Use 1TB segments

2007-10-11 Thread Linas Vepstas
On Thu, Oct 11, 2007 at 08:37:10PM +1000, Paul Mackerras wrote: This makes the kernel use 1TB segments for all kernel mappings and for user addresses of 1TB and above, on machines which support them (currently POWER5+, POWER6 and PA6T). Gack. A system dump might take a while on these machines

Re: Merge dtc

2007-10-17 Thread Linas Vepstas
On Wed, Oct 17, 2007 at 02:59:04PM -0500, Timur Tabi wrote: Kumar Gala wrote: Just out of interest who's complaining? We don't include mkimage for u-boot related builds and I haven't seen any gripes related to that. I think we should include mkimage *and* dtc. But then, I'm not sure

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-17 Thread Linas Vepstas
On Wed, Oct 17, 2007 at 05:12:27PM +1000, Michael Ellerman wrote: +struct device_node *of_get_pci_dev_node(struct pci_dev *pdev) +{ + return of_node_get(pci_device_to_OF_node(pdev)); +} [...] - dn = of_node_get(pci_device_to_OF_node(dev)); + dn = of_get_pci_dev_node(dev);

Re: [PATCH 2/2] Use of_get_pci_dev_node() in axon_msi.c

2007-10-18 Thread Linas Vepstas
, then. Excellent reason. I didn't get that from the patch commit comments. So, FWIW: Ack'ed-by: Linas Vepstas [EMAIL PROTECTED] --linas ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-19 Thread Linas Vepstas
Hi, On Fri, Oct 19, 2007 at 05:27:06PM -0700, David Miller wrote: From: [EMAIL PROTECTED] (Linas Vepstas) Date: Fri, 19 Oct 2007 19:04:21 -0500 I'm working in linux-2.6.23-rc8-mm1 at the moment, and I don't see that happening. viz. read_msi_msg() is not called anywhere, and I need

Re: [BUG] powerpc does not save msi state [was Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Linas Vepstas
On Fri, Oct 19, 2007 at 05:53:08PM -0700, David Miller wrote: From: [EMAIL PROTECTED] (Linas Vepstas) Date: Fri, 19 Oct 2007 19:46:10 -0500 FWIW, it looks like not all that many arches do this; the output for grep -r address_hi * is pretty thin. Then, looking at i386/kernel/io_apic.c

Re: [PATCH 5/7] pci: Export the pci_restore_msi_state() function

2007-10-22 Thread Linas Vepstas
On Tue, Oct 23, 2007 at 07:24:27AM +1000, Benjamin Herrenschmidt wrote: On Mon, 2007-10-22 at 13:13 -0500, Linas Vepstas wrote: On Mon, Oct 22, 2007 at 11:49:24AM +1000, Michael Ellerman wrote: On pseries there's a chance it will work for PCI error recovery, but if so it's just

[PATCH 0/3] powerpc eeh: bug fixes for crashes, bad handling

2007-11-02 Thread Linas Vepstas
Hi Paul, Please forward upstream the following three tiny patches for EEH bugs, including on crash, and one failure to reset correctly. (I was planning on blasting you many many more patches, involving MSI, but have had nothing but broken hardware for the last few weeks, and so have nothing to

[PATCH 1/3] powerpc eeh: cleanup comments

2007-11-02 Thread Linas Vepstas
Clean up commentary, remove dead code. Signed-off-by Linas Vepstas [EMAIL PROTECTED] arch/powerpc/platforms/pseries/eeh_driver.c |8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) Index: linux-2.6.23-rc8-mm1/arch/powerpc/platforms/pseries/eeh_driver.c

[PATCH 2/3]: powerpc eeh: drivers that need reset trump others

2007-11-02 Thread Linas Vepstas
Bugfix: if a driver controlling one part of a multi-function pci card has asked for a reset, honor that request above all othres. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/platforms/pseries/eeh_driver.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions

[PATCH 3/3]: powerpc eeh: avoid crash on null device.

2007-11-02 Thread Linas Vepstas
Bugfix: avoid crash if there's no pci device for a given openfirmware node. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/platforms/pseries/eeh.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) Index: linux-2.6.23-rc8-mm1/arch/powerpc/platforms/pseries

Re: [PATCH 11/16] Use of_get_next_child() in eeh_restore_bars()

2007-11-05 Thread Linas Vepstas
On Mon, Oct 29, 2007 at 02:46:13PM +1100, Michael Ellerman wrote: On Fri, 2007-10-26 at 17:29 +1000, Stephen Rothwell wrote: On Fri, 26 Oct 2007 16:54:43 +1000 (EST) Michael Ellerman [EMAIL PROTECTED] wrote: - dn = pdn-node-child; - while (dn) { + for (dn = NULL; (dn =

[PATCH] powerpc/eeh: make sure warning message is printed.

2007-11-07 Thread Linas Vepstas
Fix old buglet; a warning message should have been printed when a hardware reset takes too long. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/platforms/pseries/eeh.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.23-rc8-mm1/arch/powerpc

[PATCH] pci hotplug: fix rpaphp directory naming

2007-11-13 Thread Linas Vepstas
Fix presentation of the slot number in the /sys/bus/pci/slots directory to match that used in the majority of other drivers. -- On Tue, Nov 13, 2007 at 02:58:30PM -0700, Matthew Wilcox wrote: On Tue, Nov 13, 2007 at 03:41:21PM -0600, Linas Vepstas wrote: /sys/bus/pci/slots /sys/bus

[PATCH] pci hotplug: rm bogus item in rpaphp struct

2007-11-13 Thread Linas Vepstas
Remove unused struct element. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] drivers/pci/hotplug/rpaphp.h |1 - drivers/pci/hotplug/rpaphp_pci.c |1 - 2 files changed, 2 deletions(-) Index: linux-2.6.23-rc8-mm1/drivers/pci/hotplug/rpaphp.h

Re: [PATCH] [POWERPC] pSeries: make pseries_defconfig minus PCI build again

2007-11-14 Thread Linas Vepstas
On Wed, Nov 14, 2007 at 03:07:39PM +1100, Stephen Rothwell wrote: Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] Acked-by: Linas Vepstas [EMAIL PROTECTED] --- arch/powerpc/platforms/pseries/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- Cheers, Stephen

[PATCH v2] pci hotplug: fix rpaphp directory naming

2007-11-14 Thread Linas Vepstas
Fix presentation of the slot number in the /sys/bus/pci/slots directory to match that used in the majority of other drivers. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] -- On Tue, Nov 13, 2007 at 07:26:07PM -0800, Greg KH wrote: We need a signed-off-by: to be able to apply

[PATCH 1/3] powerpc: EEH: work with device endpoint, always

2007-11-15 Thread Linas Vepstas
Perform all error checking at the partitonable endpoint of the device. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/platforms/pseries/eeh.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.23-rc8-mm1/arch/powerpc/platforms/pseries/eeh.c

[PATCH 3/3]: powerpc/eeh: report errors as soon as possible.

2007-11-15 Thread Linas Vepstas
Do not wait for the pci slot status before reporting an error to the device driver. Some systems may take many seconds to report the slot status, and this can confuse unsuspecting device drivers. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] arch/powerpc/platforms/pseries/eeh_driver.c

Re: hangs after Freeing unused kernel memory

2007-11-19 Thread Linas Vepstas
On Thu, Nov 15, 2007 at 04:00:09PM -0800, Siva Prasad wrote: Hi, This sounds like a familiar problem, but could not get answers in posts that came up in google search. My system hangs after printing the message Freeing unused kernel memory. It should execute init after that, but not sure

[PATCH] powerpc: fix os-term usage on kernel panic

2007-11-19 Thread Linas Vepstas
the hypervisor happy to avoid service, dump and error reporting problems. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] One could make a strong argument to move all of this code from kernel/rtas.c to platforms/pseries/setup.c I did not do this, just so as to make the changes minimal. arch/powerpc

[PATCH] powerpc/pseries: tell phyp to auto-restart

2007-11-20 Thread Linas Vepstas
The pseries hypervisor attempts to detect and prevent an infinite loop of kernel crashes and auto-reboots. It does so by refusing to auto-reboot unless we indicate that the current boot was sucessful. So, indicate success late in the boot sequence. Signed-off-by: Linas Vepstas [EMAIL

[PATCH/RFC 0/6]: phyp dump: hypervisor-assisted dump

2007-11-21 Thread Linas Vepstas
The following series of patches implement a basic framework for hypervisor-assisted dump. The very first patch provides documentation explaining what this is :-). Yes, its supposed to be an improvement over kdump. The patches mostly sort-of work; a list of open issues is inculded in the

[PATCH/RFC 1/6]: phyp dump: Documentation

2007-11-21 Thread Linas Vepstas
Basic documentation for hypervisor-assisted dump. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Documentation/powerpc/phyp-assisted-dump.txt | 126 +++ 1 file changed, 126 insertions(+) Index: linux-2.6.24-rc3-git1/Documentation/powerpc/phyp-assisted-dump.txt

[PATCH/RFC 2/6]: phyp dump: config file

2007-11-21 Thread Linas Vepstas
Add hypervisor-assisted dump to kernel config Signed-off-by: Linas Vepstas [EMAIL PROTECTED] - arch/powerpc/Kconfig | 11 +++ 1 file changed, 11 insertions(+) Index: linux-2.6.24-rc2-git4/arch/powerpc/Kconfig

[PATCH/RFC 4/6]: phyp dump: use sysfs to release reserved mem

2007-11-21 Thread Linas Vepstas
/kernel/release_region will release 256MB starting at the 1GB. The released memory becomes free for general use. Signed-off-by: Linas Vepstas [EMAIL PROTECTED] Signed-off-by: Manish Ahuja [EMAIL PROTECTED] -- arch/powerpc/platforms/pseries/phyp_dump.c | 101 +++-- 1

[PATCH/RFC 5/6]: phyp dump: register the dump area

2007-11-21 Thread Linas Vepstas
Set up the actual dump header, register it with the hypervisor. Signed-off-by: Manish Ahuja [EMAIL PROTECTED] Signed-off-by: Linas Vepstas [EMAIL PROTECTED] -- arch/powerpc/platforms/pseries/phyp_dump.c | 169 +++-- 1 file changed, 163 insertions(+), 6 deletions

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-28 Thread Linas Vepstas
On Tue, Nov 27, 2007 at 06:15:59PM -0600, Will Schmidt wrote: (resending with the proper from addr this time). I'm seeing some funky behavior on power5/power6 partitions with this patch.A /sbin/reboot is now behaving much more like a /sbin/halt. Anybody else seeing this, or is it

Re: [PATCH] powerpc: fix os-term usage on kernel panic

2007-11-28 Thread Linas Vepstas
On Wed, Nov 28, 2007 at 12:00:37PM +0100, Olaf Hering wrote: On Tue, Nov 27, Will Schmidt wrote: -void rtas_os_term(char *str) +void rtas_panic_msg(char *str) - if (panic_timeout) - return; This change is wrong. Booting with panic=123 really means the system has to

Re: [PATCH 2/2] eeh: fixing pci_dev dependency

2010-01-29 Thread Linas Vepstas
On 28 January 2010 18:04, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2010-01-27 at 12:43 -0600, lei...@linux.vnet.ibm.com wrote: Currently pci_dev can be null when EEH is in action. This patch just assure that we pci_dev is not NULL before calling pci_dev_put. Like all

Re: [PATCH] eeh: Fixing a bug when pci structure is null

2010-02-19 Thread Linas Vepstas
Hi Paul, Breno, Some confusion -- I've been out of the loop for a while -- I assume its still Paul who is pushing these patches upstream, and not Ben? So Breno, maybe you should resend the patch to Paul? --linas On 19 February 2010 10:43, Breno Leitao lei...@linux.vnet.ibm.com wrote: Hi Ben,

Re: [PATCH] powerpc: eeh: Fix oops when probing in early boot

2010-05-11 Thread Linas Vepstas
just do a hot reset if the pcidev is NULL. Signed-off-by: Anton Blanchard an...@samba.org --- Acked-by: Linas Vepstas linasveps...@gmail.com I'm cc'ing Brian King, he's the one who figured out the proper fix for a hot-reset/fundamental-reset hardware feature that added this line of code

Re: [PATCH] Restore PERR/SERR bit settings during EEH device recovery

2008-07-08 Thread Linas Vepstas
) + cmd |= PCI_COMMAND_SERR; else cmd = ~PCI_COMMAND_SERR; + rtas_write_config(pdn, PCI_COMMAND, 4, cmd); } Other than that, I'll add an Acked-by: Linas Vepstas [EMAIL PROTECTED] --linas ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH 01/15] ppc: fix return type of BUID_{HI,LO} macros

2010-09-16 Thread Linas Vepstas
Acked-by: Linas Vepstas linasveps...@gmail.com I'm guessing this worked up til now because the rtas_call function prototype was telling compiler to cast these to 32-bit before passing them as args. (and since these would still get passed as one arg per 64-bit reg, it still wouldn't go wrong

Re: [RFC PATCH] ppc: don't override CONFIG_PPC_PSERIES_DEBUG

2010-10-14 Thread Linas Vepstas
On 14 October 2010 12:48, Nishanth Aravamudan n...@us.ibm.com wrote: These files undef DEBUG, but I think they were added before the ability to control this from Kconfig. Right. It's really annoying to only get some of the debug messages! I don't get the big picture. Will there be some

  1   2   >