Sorry,
I think i sent the wrong patch file, it shouldn't have my printk statement in
there. Let me re-send
the correct file and let me test it once more to make sure it does the right
thing.
-Manish
Paul Mackerras wrote:
Manish Ahuja writes:
Initial patch for reserving memory in early
Basic documentation for hypervisor-assisted dump.
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Documentation/powerpc/phyp-assisted-dump.txt | 127 +++
1 file changed, 127 insertions(+)
Index: 2.6.24-rc5/Documentation
The following series of patches implement a basic framework
for hypervisor-assisted dump. The very first patch provides
documentation explaining what this is :-). Yes, its supposed
to be an improvement over kdump.
A list of open issues / todo list is included in the documentation.
It also
Provide some basic debugging support.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepsts [EMAIL PROTECTED]
-
arch/powerpc/platforms/pseries/phyp_dump.c | 64 +++--
1 file changed, 60 insertions(+), 4 deletions(-)
Index: 2.6.24-rc5/arch
Routines to
a. invalidate dump
b. Calculate region that is reserved and needs to be freed. This is
exported through sysfs interface.
Unregister has been removed for now as it wasn't being used.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
-
---
arch/powerpc/platforms/pseries
This patch tracks the size freed. For now it does a simple
rudimentary calculation of the ranges freed. The idea is
to keep it simple at the external shell script level and
send in large chunks for now.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
-
---
arch/powerpc/platforms/pseries
Add hypervisor-assisted dump to kernel config
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
-
arch/powerpc/Kconfig | 11 +++
1 file changed, 11 insertions(+)
Index: 2.6.24-rc5/arch/powerpc/Kconfig
===
---
/kernel/release_region
will release 256MB starting at the 1GB. The released memory
becomes free for general use.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
--
arch/powerpc/platforms/pseries/phyp_dump.c | 88 +++--
1
Set up the actual dump header, register it with the hypervisor.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
--
arch/powerpc/platforms/pseries/phyp_dump.c | 136 +++--
1 file changed, 129 insertions(+), 7 deletions
Michael,
Fixed.
-Manish
--
Initial patch for reserving memory in early boot, and freeing it later.
If the previous boot had ended with a crash, the reserved memory would contain
a copy of the crashed kernel data.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas
As noted, its fixed in patch 4.
If its okay for this time, I will prefer to leave it there.
-Manish
Stephen Rothwell wrote:
Hi Manish,
Just a small comment.
On Tue, 12 Feb 2008 01:11:58 -0600 Manish Ahuja [EMAIL PROTECTED] wrote:
+/* Is there dump data waiting for us
For now, if we can leave this patch as is, that will be great. That move
requires me
to work all remaining patches as they apply uncleanly after that.
I will bunch those two together functionally next time onwards.
Thanks,
Manish
Stephen Rothwell wrote:
Hi Manish,
-/* Is there dump
as it wasn't being used.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
-
---
arch/powerpc/platforms/pseries/phyp_dump.c | 85 +
include/asm-powerpc/phyp_dump.h|3 +
2 files changed, 77 insertions(+), 11 deletions(-)
Index: 2.6.24-rc5/arch
Olof,
I will run it through checkpatch before resubmitting.
Thanks,
Manish
Olof Johansson wrote:
On Thu, Feb 14, 2008 at 02:46:21PM +1100, Tony Breeds wrote:
Hi Manish,
Sorry for the minor nits but this should be:
---
* Linas Vepstas, Manish Ahuja 2008
* Copyright 2008 IBM
Tony Breeds wrote:
On Tue, Feb 12, 2008 at 01:11:58AM -0600, Manish Ahuja wrote:
snip
+static ssize_t
+show_release_region(struct kset * kset, char *buf)
+{
+return sprintf(buf, ola\n);
+}
+
+static struct subsys_attribute rr = __ATTR(release_region, 0600
The following series of patches implement a basic framework
for hypervisor-assisted dump. The very first patch provides
documentation explaining what this is :-) . Yes, its supposed
to be an improvement over kdump.
A list of open issues / todo list is included in the documentation.
It also
Basic documentation for hypervisor-assisted dump.
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Documentation/powerpc/phyp-assisted-dump.txt | 127 +++
1 file changed, 127 insertions(+)
Index: 2.6.25-rc1
/kernel/release_region
will release 256MB starting at the 1GB. The released memory
becomes free for general use.
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
--
arch/powerpc/platforms/pseries/phyp_dump.c | 81 +++--
1
Set up the actual dump header, register it with the hypervisor.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
--
arch/powerpc/platforms/pseries/phyp_dump.c | 137 +++--
1 file changed, 131 insertions(+), 6 deletions
Provide some basic debugging support.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
-
arch/powerpc/platforms/pseries/phyp_dump.c | 61 -
1 file changed, 59 insertions(+), 2 deletions(-)
Index: 2.6.25-rc1/arch
Routines to
a. invalidate dump
b. Calculate region that is reserved and needs to be freed. This is
exported through sysfs interface.
Unregister has been removed for now as it wasn't being used.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
-
---
arch/powerpc/platforms/pseries
This patch tracks the size freed. For now it does a simple
rudimentary calculation of the ranges freed. The idea is
to keep it simple at the external shell script level and
send in large chunks for now.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
-
---
arch/powerpc/platforms/pseries
Add hypervisor-assisted dump to kernel config
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
-
arch/powerpc/Kconfig | 11 +++
1 file changed, 11 insertions(+)
Index: 2.6.25-rc1/arch/powerpc/Kconfig
===
---
wrote:
On Sun, 2008-02-17 at 22:53 -0600, Manish Ahuja wrote:
The following series of patches implement a basic framework
for hypervisor-assisted dump. The very first patch provides
documentation explaining what this is :-) . Yes, its supposed
to be an improvement over kdump.
A list
Basic documentation for hypervisor-assisted dump.
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Documentation/powerpc/phyp-assisted-dump.txt | 127 +++
1 file changed, 127 insertions(+)
Index: 2.6.25-rc1
Initial patch for reserving memory in early boot, and freeing it later.
If the previous boot had ended with a crash, the reserved memory would contain
a copy of the crashed kernel data.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
arch
/kernel/release_region
will release 256MB starting at the 1GB. The released memory
becomes free for general use.
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
--
arch/powerpc/platforms/pseries/phyp_dump.c | 82 +++--
1
Set up the actual dump header, register it with the hypervisor.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
--
arch/powerpc/platforms/pseries/phyp_dump.c | 137 +++--
1 file changed, 131 insertions(+), 6 deletions
Provide some basic debugging support.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
-
arch/powerpc/platforms/pseries/phyp_dump.c | 61 -
1 file changed, 59 insertions(+), 2 deletions(-)
Index: 2.6.25-rc1/arch
Routines to
a. invalidate dump
b. Calculate region that is reserved and needs to be freed. This is
exported through sysfs interface.
Unregister has been removed for now as it wasn't being used.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
-
---
arch/powerpc/platforms/pseries
This patch tracks the size freed. For now it does a simple
rudimentary calculation of the ranges freed. The idea is
to keep it simple at the external shell script level and
send in large chunks for now.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
-
---
arch/powerpc/platforms/pseries
Add hypervisor-assisted dump to kernel config
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
-
arch/powerpc/Kconfig | 11 +++
1 file changed, 11 insertions(+)
Index: 2.6.25-rc1/arch/powerpc/Kconfig
===
---
Thanks for the review. I will try and make the recommended changes and repost
it soon.
Manish
Paul Mackerras wrote:
Manish Ahuja writes:
+config PHYP_DUMP
+bool Hypervisor-assisted dump (EXPERIMENTAL)
+depends on PPC_PSERIES EXPERIMENTAL
+default y
I think this should
If Mike and Paul are okay, then I will leave this bit as is and fix all
other issues and comments.
Thanks,
Manish
Linas Vepstas wrote:
On 10/03/2008, Michael Ellerman [EMAIL PROTECTED] wrote:
On Thu, 2008-02-28 at 18:24 -0600, Manish Ahuja wrote:
+
+/* Global, used to communicate
The following series of patches implement a basic framework
for hypervisor-assisted dump. The very first patch provides
documentation explaining what this is.
A list of open issues / todo list is included in the documentation.
It also appears that the not-yet-released firmware versions this was
Basic documentation for hypervisor-assisted dump.
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
---
Documentation/powerpc/phyp-assisted-dump.txt | 127 +++
1 file changed, 127 insertions(+)
Index: 2.6.25-rc1/Documentation
Initial patch for reserving memory in early boot, and freeing it later.
If the previous boot had ended with a crash, the reserved memory would contain
a copy of the crashed kernel data.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
---
arch
/kernel/release_region
will release 256MB starting at the 1GB. The released memory
becomes free for general use.
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
---
arch/powerpc/platforms/pseries/phyp_dump.c | 81 +++--
1
Set up the actual dump header, register it with the hypervisor.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
---
arch/powerpc/platforms/pseries/phyp_dump.c | 137 +++--
1 file changed, 131 insertions(+), 6 deletions
Provide some basic debugging support.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
---
arch/powerpc/platforms/pseries/phyp_dump.c | 61 -
1 file changed, 59 insertions(+), 2 deletions(-)
Index: 2.6.25-rc1/arch
Routines to
a. invalidate dump
b. Calculate region that is reserved and needs to be freed. This is
exported through sysfs interface.
Unregister has been removed for now as it wasn't being used.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
---
arch/powerpc/platforms/pseries
This patch tracks the size freed. For now it does a simple
rudimentary calculation of the ranges freed. The idea is
to keep it simple at the external shell script level and
send in large chunks for now.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
---
arch/powerpc/platforms/pseries
Add hypervisor-assisted dump to kernel config
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
---
arch/powerpc/Kconfig | 10 ++
1 file changed, 10 insertions(+)
Index: 2.6.25-rc1/arch/powerpc/Kconfig
can use this on cmdline (phyp_dump=0)
to disable phyp-dump during boot when enabling itself. This will ensure only
one dumping mechanism is active at any given time.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
---
arch/powerpc/kernel/prom.c |5 +
arch/powerpc/platforms
Patch 2:
Addition of /sys/kernel/phyp_dump_active so that kdump init scripts may
look for it and take appropriate action if this file is found. This
file is only loaded when phyp_dump has been registered.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
---
arch/powerpc/platforms/pseries
Olof Johansson wrote:
These make for some really long variable names and lines. I know from
experience, since I've picked unneccessary long driver names in the past
myself. :)
How about just naming the new variables reserve_bootvar, etc? The name
of the struct they're in makes it obvious
Olof Johansson wrote:
+static inline unsigned long phyp_dump_calculate_reserve_size(void)
+{
+unsigned long tmp;
+
+if (phyp_dump_info-phyp_dump_reserve_bootvar)
+return phyp_dump_info-phyp_dump_reserve_bootvar;
+
+/* divide by 20 to get 5% of value */
+tmp =
Hmmm,
You are possibly right.
Okay I can check and fix that.
-Manish
Olof Johansson wrote:
That's 512MB, isn't it?
My calculations in the example I gave in the last email were wrong.
In mentally did 10% instead of 5%. But the premise is same.
So assuming 5% of some memory is 400 MB, it
and returns larger of 256MB or the new
computed value.
Again this is for large systems who have excess memory.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
---
arch/powerpc/kernel/prom.c | 35 +++--
arch/powerpc/platforms/pseries/phyp_dump.c |9
too
little memory on very very large systems during those few minutes.
-Manish
Paul Mackerras wrote:
Manish Ahuja writes:
B. It computers 5% of total ram and rounds it down to multiples of 256MB.
C. Compares the rounded down value and returns larger of 256MB or the new
computed value
Yeah, that makes sense, I will shortly send a documentation patch for all the
boot vars
that I have added.
Thanks for reminding.
-Manish
Linas Vepstas wrote:
On 07/04/2008, Manish Ahuja [EMAIL PROTECTED] wrote:
A small proposed change in the amount of reserve space we allocate during
Ah yes, my mistake. Does it require a repost then ?
Thanks,
Manish
Linas Vepstas wrote:
You want to say its a patch in the subject line.
--linas
On Fri, Jul 06, 2007 at 04:59:55PM -0500, Manish Ahuja wrote:
Found 2 instances of return one right after each other in
arch_add_memory
Fix to correct a possible infinite loop or an always true check when the
unsigned long counter i is used in
lmb_add_region() in the following for loop:
for (i = rgn-cnt-1; i = 0; i--)
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
---
arch/powerpc/mm/lmb.c |4 ++--
1 file changed, 2
Repost to fix my email id.
Fix to correct a possible infinite loop or an always true check when the
unsigned long counter i is used in
lmb_add_region() in the following for loop:
for (i = rgn-cnt-1; i = 0; i--)
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
---
arch/powerpc/mm/lmb.c |4
Paul Mackerras wrote:
Andreas Schwab writes:
??? There is no rgn-cnt involved in the comparison.
Look further down in lmb_add_region; there is a second for loop that
does
for (i = rgn-cnt-1; i = 0; i--)
Which is exactly the one quoted above. I still don't see
Yes,
That is required. It is in the patches that I sent to Ben, Paul Brad.
I just waiting to post it with other patches.
Acked-by: Manish Ahuja mahu...@gmail.com
Tony Breeds wrote:
ibm_configure_kernel_dump, is passed as the token to rtas_call() but I
cannot see where it is initialised
Acked-by: Manish Ahuja mahu...@gmail.com
Tony Breeds wrote:
print_dump_header() will be called at least once with a NULL pointer in
a normal boot sequence. if DEBUG is defined then we will get a deref,
add a quick fix to exit early in the NULL pointer case.
Signed-off-by: Tony Breeds t
The following series of patches implement a basic framework
for hypervisor-assisted dump. The very first patch provides
documentation explaining what this is :-) . Yes, its supposed
to be an improvement over kdump.
The patches mostly work; a list of open issues / todo list
is included in the
Basic documentation for hypervisor-assisted dump.
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Documentation/powerpc/phyp-assisted-dump.txt | 129 +++
1 file changed, 129 insertions(+)
Index: 2.6.24-rc5
Add hypervisor-assisted dump to kernel config
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
-
arch/powerpc/Kconfig | 11 +++
1 file changed, 11 insertions(+)
Index: linux-2.6.24-rc2-git4/arch/powerpc/Kconfig
===
Initial patch for reserving memory in early boot, and freeing it later.
If the previous boot had ended with a crash, the reserved memory would contain
a copy of the crashed kernel data.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
arch
Check to see if there actually is data from a previously
crashed kernel waiting. If so, Allow user-sapce tools to
grab the data (by reading /proc/kcore). When user-space
finishes dumping a section, it must release that memory
by writing to sysfs. For example,
echo 0x4000 0x1000
Initial patch for reserving memory in early boot, and freeing it later.
If the previous boot had ended with a crash, the reserved memory would contain
a copy of the crashed kernel data.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
arch
Set up the actual dump header, register it with the hypervisor.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
--
arch/powerpc/platforms/pseries/phyp_dump.c | 169 +++--
1 file changed, 163 insertions(+), 6 deletions
Provide some basic debugging support.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepsts [EMAIL PROTECTED]
-
arch/powerpc/platforms/pseries/phyp_dump.c | 53 -
1 file changed, 52 insertions(+), 1 deletion(-)
Index: 2.6.24-rc5/arch
This patch tracks the size freed. For now it does a simple
rudimentary calculation of the ranges freed. The idea is
to keep it simple at the external shell script level and
send in large chunks for now.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
-
---
arch/powerpc/platforms/pseries
sure he will chime in with more details about it when he gets the
opportunity.
Thanks,
Manish
Arnd Bergmann wrote:
On Tuesday 08 January 2008, Manish Ahuja wrote:
Initial patch for reserving memory in early boot, and freeing it later.
If the previous boot had ended with a crash
Stephen,
+/* Add addr value if not initialized before */
+if (ph-cpu_data.destination_address == 0) {
+ph-cpu_data.destination_address += addr;
Could be just '=' like further down, right?
Actually the one below should be += as well. Thanks for catching it.
+/*
I used the word actually. I already know that it is intended to be
faster. :)
it should blow it away, as, after all,
it requires one less reboot!
There's more than rebooting going on during system dump processing.
Depending on the system type, booting may not be where most time is
It's in production with 256MB of RAM? Err. Sure as the dump progresses
more RAM will be freed, but that's hardly production. I think Nathan's
right, any sysadmin who wants predictability will probably double reboot
anyway.
Thats a changeable parameter. Its something we chose for now. It by no
The following series of patches implement a basic framework
for hypervisor-assisted dump. The very first patch provides
documentation explaining what this is :-) . Yes, its supposed
to be an improvement over kdump.
A list of open issues / todo list is included in the documentation.
It also
The following series of patches implement a basic framework
for hypervisor-assisted dump. The very first patch provides
documentation explaining what this is:-) . Yes, its supposed
to be an improvement over kdump.
A list of open issues / todo list is included in the documentation.
It also
Check to see if there actually is data from a previously
crashed kernel waiting. If so, Allow user-sapce tools to
grab the data (by reading /proc/kcore). When user-space
finishes dumping a section, it must release that memory
by writing to sysfs. For example,
echo 0x4000 0x1000
Reposted this one. I got the email id wrong in this one.
Sorry about that.
Manish
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Provide some basic debugging support.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
-
arch/powerpc/platforms/pseries/phyp_dump.c | 64 +++--
1 file changed, 60 insertions(+), 4 deletions(-)
Index: 2.6.24-rc5/arch
-by: Manish Ahuja [EMAIL PROTECTED]
-
---
arch/powerpc/platforms/pseries/phyp_dump.c | 101 +
include/asm/phyp_dump.h|3
2 files changed, 93 insertions(+), 11 deletions(-)
Index: 2.6.24-rc5/arch/powerpc/platforms/pseries/phyp_dump.c
This patch tracks the size freed. For now it does a simple
rudimentary calculation of the ranges freed. The idea is
to keep it simple at the external shell script level and
send in large chunks for now.
Signed-off-by: Manish Ahuja [EMAIL PROTECTED]
-
---
arch/powerpc/platforms/pseries
To: linuxppc-dev@ozlabs.org
Add hypervisor-assisted dump to kernel config
Signed-off-by: Linas Vepstas [EMAIL PROTECTED]
-
arch/powerpc/Kconfig | 11 +++
1 file changed, 11 insertions(+)
Index: linux-2.6.24-rc2-git4/arch/powerpc/Kconfig
78 matches
Mail list logo
