[PATCH] powerpc/powernv: Free name on error in opal_event_init()

2024-09-20 Thread Michael Ellerman
q.com> Closes: https://lore.kernel.org/linuxppc-dev/87wmjp3wig.fsf@mail.lhotse Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/powernv/opal-irqchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/powernv/opal-irqchip.c b/arch/powerpc/platforms/powernv/opal

Re: [PATCH] powerpc/vdso32: Fix use of crtsavres for PPC64

2024-09-20 Thread Michael Ellerman
On Thu, 19 Sep 2024 20:55:57 +0200, Christophe Leroy wrote: > crtsavres.S content is encloded by a #ifndef CONFIG_PPC64 > > To be used on VDSO32 on PPC64 it's content must available on PPC64 as > well. > > Replace #ifndef CONFIG_PPC64 by #ifndef __powerpc64__ as __powerpc64__ > is not set when bu

Re: [PATCH] powerpc/pseries/eeh: move pseries_eeh_err_inject() outside CONFIG_DEBUG_FS block

2024-09-20 Thread Michael Ellerman
On Tue, 17 Sep 2024 09:24:45 -0400, Narayana Murty N wrote: > Makes pseries_eeh_err_inject() available even when debugfs > is disabled (CONFIG_DEBUG_FS=n). It moves eeh_debugfs_break_device() > and eeh_pe_inject_mmio_error() out of the CONFIG_DEBUG_FS block > and renames it as eeh_break_device(). >

Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits

2024-09-19 Thread Michael Ellerman
Charlie Jenkins writes: > On Wed, Sep 11, 2024 at 11:38:55PM +1000, Michael Ellerman wrote: >> Geert Uytterhoeven writes: >> > Hi Christophe, >> > >> > On Tue, Sep 10, 2024 at 11:21 AM Christophe Leroy >> > wrote: >> >> >>> diff

Re: [PATCH] powerpc/perf: Use guard(irqsave)() in eight functions

2024-09-19 Thread Michael Ellerman
Markus Elfring writes: > From: Markus Elfring > Date: Mon, 16 Sep 2024 19:25:00 +0200 > > Scope-based resource management became supported for some > programming interfaces by contributions of Peter Zijlstra on 2023-05-26. > See also the commit 54da6a0924311c7cf5015533991e44fb8eb12773 ("locking:

Re: [FSL P50x0] [GIT KERNEL] [VDSO] compiling issue

2024-09-19 Thread Michael Ellerman
Christian Zigotzky writes: > Hi All, > > The compiling of the latest Git kernel doesn’t work anymore for our FSL > P5020/P5040 boards [1] since the random-6.12-rc1 updates [2]. > > Error messages: > > arch/powerpc/kernel/vdso/vdso32.so.dbg: dynamic relocations are not supported > > make[2]: *** [

Re: [RFC PATCH] powerpc/tlb: enable arch want batched unmap tlb flush

2024-09-19 Thread Michael Ellerman
Luming Yu writes: > On Thu, Sep 19, 2024 at 01:22:21PM +1000, Michael Ellerman wrote: >> Luming Yu writes: >> > From: Yu Luming >> > >> > ppc always do its own tracking for batch tlb. >> >> I don't think it does? :) >> >> I

Re: [PATCH] powerpc/atomic: Use YZ constraints for DS-form instructions

2024-09-19 Thread Michael Ellerman
Segher Boessenkool writes: > Hi! > > On Mon, Sep 16, 2024 at 10:05:10PM +1000, Michael Ellerman wrote: >> The 'ld' and 'std' instructions require a 4-byte aligned displacement >> because they are DS-form instructions. But the "m" asm constrai

Re: [PATCH] crypto: Removing CRYPTO_AES_GCM_P10.

2024-09-18 Thread Michael Ellerman
Danny Tsen writes: > Removing CRYPTO_AES_GCM_P10 in Kconfig first so that we can apply the > subsequent patches to fix data mismatch over ipsec tunnel. This change log needs to stand on its own. ie. it needs to explain what the problem is and why the feature is being disabled, without reference t

Re: [PATCH v2] crash, powerpc: Default to CRASH_DUMP=n on PPC_BOOK3S_32

2024-09-18 Thread Michael Ellerman
3 +++ > arch/powerpc/Kconfig | 4 > arch/riscv/Kconfig | 3 +++ > arch/s390/Kconfig | 3 +++ > arch/sh/Kconfig| 3 +++ > arch/x86/Kconfig | 3 +++ > kernel/Kconfig.kexec | 2 +- > 10 files changed, 29 insertions(+), 1 deletion(-) Acked-by: Michael Ellerman (powerpc) cheers

Re: [RFC PATCH] powerpc/tlb: enable arch want batched unmap tlb flush

2024-09-18 Thread Michael Ellerman
Luming Yu writes: > From: Yu Luming > > ppc always do its own tracking for batch tlb. I don't think it does? :) I think you're referring to the batch handling in arch/powerpc/include/asm/book3s/64/tlbflush-hash.h ? But that's only used for 64-bit Book3S with the HPT MMU. > By trivially enabl

[GIT PULL] Please pull powerpc/linux.git powerpc-6.12-1 tag

2024-09-18 Thread Michael Ellerman
Constify struct kobj_type Jinjie Ruan (1): powerpc: Remove useless config comment in asm/percpu.h Madhavan Srinivasan (2): powerpc/xmon: Fix tmpstr length check in scanhex selftests/powerpc: Allow building without static libc Michael Ellerman (13): MAINTAINERS: Mark

Re: [RFC PATCH] powerpc/vdso: Should VDSO64 functions be flagged as functions like VDSO32 ?

2024-09-17 Thread Michael Ellerman
Christophe Leroy writes: > On powerpc64 as shown below by readelf, vDSO functions symbols have > type NOTYPE. > > $ powerpc64-linux-gnu-readelf -a arch/powerpc/kernel/vdso/vdso64.so.dbg > ELF Header: > Magic: 7f 45 4c 46 02 02 01 00 00 00 00 00 00 00 00 00 > Class:

Re: [PATCH] powerpc/atomic: Use YZ constraints for DS-form instructions

2024-09-17 Thread Michael Ellerman
On Mon, 16 Sep 2024 22:05:10 +1000, Michael Ellerman wrote: > The 'ld' and 'std' instructions require a 4-byte aligned displacement > because they are DS-form instructions. But the "m" asm constraint > doesn't enforce that. > > That can lead to

Re: [PATCH] MAINTAINERS: powerpc: Add Maddy

2024-09-17 Thread Michael Ellerman
On Tue, 27 Aug 2024 16:36:51 +1000, Michael Ellerman wrote: > Maddy will be helping out with upstream maintenance, add him as a > reviewer. > > Applied to powerpc/next. [1/1] MAINTAINERS: powerpc: Add Maddy https://git.kernel.org/powerpc/c/b77d36bb9a3de774950ba712a0e47f9d33c6f6d7 cheers

Re: [PATCH] powerpc/atomic: Use YZ constraints for DS-form instructions

2024-09-16 Thread Michael Ellerman
Mina Almasry writes: > On Mon, Sep 16, 2024 at 5:05 AM Michael Ellerman wrote: >> >> The 'ld' and 'std' instructions require a 4-byte aligned displacement >> because they are DS-form instructions. But the "m" asm constraint >> doesn&#

[PATCH] powerpc/atomic: Use YZ constraints for DS-form instructions

2024-09-16 Thread Michael Ellerman
s. Fixes: 9f0cbea0d8cc ("[POWERPC] Implement atomic{, 64}_{read, write}() without volatile") Cc: sta...@vger.kernel.org # v2.6.24+ Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/all/20240913125302.0a06b...@canb.auug.org.au Signed-off-by: Michael Ellerman --- arch/po

Re: [PATCH net-next v2] page_pool: fix build on powerpc with GCC 14

2024-09-15 Thread Michael Ellerman
Christophe Leroy writes: > Le 14/09/2024 à 04:02, Michael Ellerman a écrit : ... >> >> diff --git a/arch/powerpc/include/asm/atomic.h >> b/arch/powerpc/include/asm/atomic.h >> index 5bf6a4d49268..0e41c1da82dd 100644 >> --- a/arch/powerpc/include/asm/atomic.h

Re: [PATCH net-next v2] page_pool: fix build on powerpc with GCC 14

2024-09-13 Thread Michael Ellerman
Mina Almasry writes: > Building net-next with powerpc with GCC 14 compiler results in this > build error: > > /home/sfr/next/tmp/ccuSzwiR.s: Assembler messages: > /home/sfr/next/tmp/ccuSzwiR.s:2579: Error: operand out of domain (39 is > not a multiple of 4) > make[5]: *** [/home/sfr/next/next/scri

Re: [PATCH] of: address: Unify resource bounds overflow checking

2024-09-13 Thread Michael Ellerman
Rob Herring writes: > On Fri, Sep 13, 2024 at 8:15 AM Michael Ellerman wrote: >> Thomas Weißschuh writes: >> > The members "start" and "end" of struct resource are of type >> > "resource_size_t" which can be 32bit wide. >> > Val

Re: [PATCH] of: address: Unify resource bounds overflow checking

2024-09-13 Thread Michael Ellerman
Thomas Weißschuh writes: > The members "start" and "end" of struct resource are of type > "resource_size_t" which can be 32bit wide. > Values read from OF however are always 64bit wide. > > Refactor the diff overflow checks into a helper function. > Also extend the checks to validate each calculat

Re: [PATCH 1/1] crypto: Fix data mismatch over ipsec tunnel encrypted/decrypted with ppc64le AES/GCM module.

2024-09-12 Thread Michael Ellerman
Danny Tsen writes: > This patch is to fix an issue when simd is not usable that data mismatch > may occur over ipsec tunnel. The fix is to register algs as SIMD modules > so that the algorithm is excecuted when SIMD instructions is usable. > > A new module rfc4106(gcm(aes)) is also added. Re-write

Re: [PATCH] powerpc: Switch back to struct platform_driver::remove()

2024-09-12 Thread Michael Ellerman
On Mon, 09 Sep 2024 15:09:02 +0200, Uwe Kleine-König wrote: > After commit 0edb555a65d1 ("platform: Make platform_driver::remove() > return void") .remove() is (again) the right callback to implement for > platform drivers. > > Convert all pwm drivers to use .remove(), with the eventual goal to dr

Re: [PATCH v3] powerpc/pseries/eeh: Fix pseries_eeh_err_inject

2024-09-12 Thread Michael Ellerman
On Mon, 09 Sep 2024 09:02:20 -0500, Narayana Murty N wrote: > VFIO_EEH_PE_INJECT_ERR ioctl is currently failing on pseries > due to missing implementation of err_inject eeh_ops for pseries. > This patch implements pseries_eeh_err_inject in eeh_ops/pseries > eeh_ops. Implements support for injecting

Re: [PATCH v2] selftest/powerpc/benchmark: remove requirement libc-dev

2024-09-12 Thread Michael Ellerman
On Mon, 12 Aug 2024 15:11:52 +0530, Madhavan Srinivasan wrote: > Currently exec-target.c file is linked as static and this > post a requirement to install libc dev package to build. > Without it, build-break when compiling selftest/powerpc/benchmark. > > CC exec_target > /usr/bin/ld: canno

Re: [PowerPC][linux-next-6.11-rc7-20240910] Kernel Warnings at kernel/jump_label.c:266

2024-09-11 Thread Michael Ellerman
Venkat Rao Bagalkote writes: > Greetings!!! > > I am observing kernel warnings while booting with > linux-next-6.11-rc7-20240910 kernel. Below are the warnings. > > [   63.613506] WARNING: CPU: 20 PID: 214 at kernel/jump_label.c:266 > static_key_dec+0x78/0x8c > [   63.613518] Modules linked in: e

Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits

2024-09-11 Thread Michael Ellerman
"Arnd Bergmann" writes: > On Mon, Sep 9, 2024, at 23:22, Charlie Jenkins wrote: >> On Fri, Sep 06, 2024 at 10:52:34AM +0100, Lorenzo Stoakes wrote: >>> On Fri, Sep 06, 2024 at 09:14:08AM GMT, Arnd Bergmann wrote: >>> The intent is to optionally be able to run a process that keeps higher bits >>> f

Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits

2024-09-11 Thread Michael Ellerman
Geert Uytterhoeven writes: > Hi Christophe, > > On Tue, Sep 10, 2024 at 11:21 AM Christophe Leroy > wrote: >> >>> diff --git a/include/uapi/linux/personality.h >> >>> b/include/uapi/linux/personality.h >> >>> index 49796b7756af..cd3b8c154d9b 100644 >> >>> --- a/include/uapi/linux/personality.h >

Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits

2024-09-11 Thread Michael Ellerman
Charlie Jenkins writes: > On Fri, Sep 06, 2024 at 04:59:40PM +1000, Michael Ellerman wrote: >> Charlie Jenkins writes: >> > Create a personality flag ADDR_LIMIT_47BIT to support applications >> > that wish to transition from running in environments that support

Re: [PATCH v2] powerpc/pseries/eeh: Fix pseries_eeh_err_inject

2024-09-10 Thread Michael Ellerman
Narayana Murty N writes: > On 05/09/24 6:33 PM, Michael Ellerman wrote: >> Narayana Murty N writes: >>> VFIO_EEH_PE_INJECT_ERR ioctl is currently failing on pseries >>> due to missing implementation of err_inject eeh_ops for pseries. >>> This patch implemen

Re: [PATCH] powerpc/ftrace: restore r2 to caller's stack on livepatch sibling call

2024-09-10 Thread Michael Ellerman
"Ryan B. Sullivan" writes: > Hello all, > > Just wanted to ping and see if there was any further feedback or > questions regarding the patch? Hi Ryan, I'd really like a selftest that triggers the sibling call behaviour. As I said upthread I tried writing one but failed. Which you later explaine

Re: [PATCH -next,v2] MIPS: Remove the obsoleted code for include/linux/mv643xx.h

2024-09-09 Thread Michael Ellerman
Gaosheng Cui writes: > Most of the drivers which used this header have been deleted, most > of these code is obsoleted, move the only defines that are actually > used into arch/powerpc/platforms/chrp/pegasos_eth.c and delete the > file completely. > > Signed-off-by: Gaosheng Cui > --- > v2: Delet

Re: [PATCH v4 RESEND] powerpc: Replace kretprobe code with rethook on powerpc

2024-09-08 Thread Michael Ellerman
Masami Hiramatsu (Google) writes: > On Fri, 06 Sep 2024 21:52:52 +1000 > Michael Ellerman wrote: > >> On Fri, 30 Aug 2024 07:31:31 -0400, Abhishek Dubey wrote: >> > This is an adaptation of commit f3a112c0c40d ("x86,rethook,kprobes: >> > Replace kret

Re: [PATCH] crash: Default to CRASH_DUMP=n when support for it is unlikely

2024-09-08 Thread Michael Ellerman
Dave Vasilevsky writes: > I received a notification from Patchwork that my patch is now in the > state "Handled Elsewhere".[0] Does that mean someone merged it > somewhere? Or that I should be using a different mailing list? Or > something else? > > I'd appreciate some guidance. It was sent/Cc'ed

Re: [PATCH] powerpc/xive: Use cpumask_intersects()

2024-09-08 Thread Michael Ellerman
Costa Shulyupin writes: > Replace `cpumask_any_and(a, b) >= nr_cpu_ids` > with the more readable `!cpumask_intersects(a, b)`. I agree it's more readable. It would be nice if the change log told me that both functions have similar performance behaviour. I'm not saying this is a super hot path, bu

Re: [PATCH 1/2] powerpc/vdso: Fix VDSO data access when running in a non-root time namespace

2024-09-08 Thread Michael Ellerman
"Jason A. Donenfeld" writes: > On Fri, Sep 06, 2024 at 03:43:17PM +0200, Jason A. Donenfeld wrote: >> On Fri, Sep 06, 2024 at 10:23:08PM +1000, Michael Ellerman wrote: >> > Christophe Leroy writes: >> > > When running in a non-root time namespace, the glo

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.11-3 tag

2024-09-06 Thread Michael Ellerman
Linus Torvalds writes: > On Fri, 6 Sept 2024 at 05:08, Michael Ellerman wrote: >> >> Please pull some more powerpc fixes for 6.11: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git >> tags/powerpc-6.11-3 > > Hmm. New pgp key? Ple

Re: [PATCH 1/2] powerpc/vdso: Fix VDSO data access when running in a non-root time namespace

2024-09-06 Thread Michael Ellerman
Christophe Leroy writes: > When running in a non-root time namespace, the global VDSO data page > is replaced by a dedicated namespace data page and the global data > page is mapped next to it. Detailed explanations can be found at > commit 660fd04f9317 ("lib/vdso: Prepare for time namespace suppo

[GIT PULL] Please pull powerpc/linux.git powerpc-6.11-3 tag

2024-09-06 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Linus, Please pull some more powerpc fixes for 6.11: The following changes since commit 227bbaabe64b6f9cd98aa051454c1d4a194a8c6a: powerpc/topology: Check if a core is online (2024-08-13 10:32:17 +1000) are available in the git repository at:

Re: [PATCH] KVM: PPC: remove unused varible

2024-09-06 Thread Michael Ellerman
On Fri, 16 Aug 2024 17:33:12 +0800, al...@kernel.org wrote: > During build testing, we found a error: > /arch/powerpc/kvm/book3s_hv.c:4052:17: error: variable 'loops' set but not > used [-Werror,-Wunused-but-set-variable] > unsigned long loops = 0; > 1 error generated. > > Remove

Re: [PATCH] powerpc/configs/64s: Enable DEFERRED_STRUCT_PAGE_INIT

2024-09-06 Thread Michael Ellerman
On Tue, 20 Aug 2024 16:57:05 +1000, Michael Ellerman wrote: > It can speed up initialisation of page structs at boot on large > machines. > > Applied to powerpc/next. [1/1] powerpc/configs/64s: Enable DEFERRED_STRUCT_PAGE_INIT https://git.kernel.o

Re: [PATCH] powerpc/64s/mm: Move __real_pte stubs into hash-4k.h

2024-09-06 Thread Michael Ellerman
On Wed, 21 Aug 2024 18:07:29 +1000, Michael Ellerman wrote: > The stub versions of __real_pte() etc are only used with HPT & 4K pages, > so move them into the hash-4k.h header. > > Applied to powerpc/next. [1/1] powerpc/64s/mm: Move __real_pte stubs into hash-4k.h https:

Re: [PATCH 0/2] Use helper function for_each_child_of_node()

2024-09-06 Thread Michael Ellerman
On Thu, 22 Aug 2024 16:54:28 +0800, Zhang Zekun wrote: > Use for_each_child_of_node() to iterate through the device_node, this > can make code more simple. > > Zhang Zekun (2): > powerpc/powermac/pfunc_base: Use helper function > for_each_child_of_node() > powerpc/pseries/dlpar: Use helper

Re: [PATCH] powerpc: Stop using no_llseek

2024-09-06 Thread Michael Ellerman
On Tue, 03 Sep 2024 21:19:51 +1000, Michael Ellerman wrote: > Since commit 868941b14441 ("fs: remove no_llseek"), no_llseek() is > simply defined to be NULL, and a NULL llseek means seeking is > unsupported. > > So for statically defined file_operations, such as all th

Re: [PATCH] powerpc/64s: Remove the "fast endian switch" syscall

2024-09-06 Thread Michael Ellerman
On Fri, 23 Aug 2024 17:08:30 +1000, Michael Ellerman wrote: > The non-standard "fast endian switch" syscall was added in 2008[1], > but was never widely used. It was disabled by default in 2017[2], and > there's no evidence it's ever been used since. > > Remov

Re: [PATCH] powerpc/64s: Make mmu_hash_ops __ro_after_init

2024-09-06 Thread Michael Ellerman
On Wed, 21 Aug 2024 18:07:45 +1000, Michael Ellerman wrote: > The mmu_hash_ops are only assigned to during boot, so mark them > __ro_after_init to prevent any further modification. > > Applied to powerpc/next. [1/1] powerpc/64s: Make mmu_hash_ops __ro_after_init https://gi

Re: [PATCH] macintosh/via-pmu: register_pmu_pm_ops() can be __init

2024-09-06 Thread Michael Ellerman
On Wed, 21 Aug 2024 18:21:01 +1000, Michael Ellerman wrote: > register_pmu_pm_ops() is only called at init time, via > device_initcall(), so can be marked __init. The driver can't be built as > a module. > > Applied to powerpc/next. [1/1] macintosh/via-pmu: register_pmu_pm

Re: [PATCH 1/2] powerpc/mm/64s: Move THP reqs into a separate symbol

2024-09-06 Thread Michael Ellerman
On Fri, 23 Aug 2024 13:29:10 +1000, Michael Ellerman wrote: > Move the Kconfig symbols related to transparent hugepages (THP) under a > separate config symbol, separate from CONFIG_PPC_BOOK3S_64. > > The new symbol is automatically enabled if CONFIG_PPC_BOOK3S_64 is > enabled,

Re: [PATCH v3] powerpc/xmon: Fix tmpstr length check in scanhex

2024-09-06 Thread Michael Ellerman
On Mon, 26 Aug 2024 12:12:17 +0530, Madhavan Srinivasan wrote: > If a function name is greater than 63 char long, xmon command > may not find them. For example, here is a test that > executed an illegal instruction in a kernel function and one of > call stack function has name >63 char long, > > c

Re: [PATCH -next 1/3] powerpc: Constify struct kobj_type

2024-09-06 Thread Michael Ellerman
On Mon, 26 Aug 2024 23:09:55 +0800, Huang Xiaojia wrote: > 'struct kobj_type' is not modified. It is only used in > kobject_init_and_add()/kobject_init() which takes > a 'const struct kobj_type *ktype' parameter. > > Constifying this structure moves some data to a read-only section, > so increase

Re: [PATCH v3 1/3] powerpc/pseries: Use correct data types from pseries_hp_errorlog struct

2024-09-06 Thread Michael Ellerman
On Wed, 21 Aug 2024 19:50:26 -0700, Haren Myneni wrote: > _be32 type is defined for some elements in pseries_hp_errorlog > struct but also used them u32 after be32_to_cpu() conversion. > > Example: In handle_dlpar_errorlog() > hp_elog->_drc_u.drc_index = be32_to_cpu(hp_elog->_drc_u.drc_index); >

Re: [PATCH -next] powerpc/powernv/pci: Remove obsoleted declaration for pnv_pci_init_ioda_hub

2024-09-06 Thread Michael Ellerman
On Thu, 22 Aug 2024 21:00:43 +0800, Gaosheng Cui wrote: > The pnv_pci_init_ioda_hub() have been removed since > commit 5ac129cdb50b ("powerpc/powernv/pci: Remove ioda1 support"), > and now it is useless, so remove it. > > Applied to powerpc/next. [1/1] powerpc/powernv/pci: Remove obsoleted decl

Re: [PATCH -next 0/4] Remove obsoleted declaration for powerpc

2024-09-06 Thread Michael Ellerman
On Thu, 22 Aug 2024 21:06:05 +0800, Gaosheng Cui wrote: > Remove obsoleted declaration for powerpc, thanks! > > Gaosheng Cui (4): > powerpc: Remove obsoleted declaration for _get_SP > powerpc: Remove obsoleted declaration for maple_calibrate_decr > powerpc: Remove obsoleted declaration for p

Re: [PATCH 00/14] Reduce alignment constraint on STRICT_KERNEL_RWX and speed-up TLB misses on 8xx and 603

2024-09-06 Thread Michael Ellerman
On Tue, 20 Aug 2024 19:23:44 +0200, Christophe Leroy wrote: > This series does mainly two things: > - Remove the 8M alignment constraint on STRICT_KERNEL_RWX on 8xx to > avoid wasting memory. > - Speed-up TLB misses by duplicating kernel PGD entries into each > task's PGDIRs to avoid the address co

Re: [PATCH] powerpc/vdso: Inconditionally use CFUNC macro

2024-09-06 Thread Michael Ellerman
On Thu, 22 Aug 2024 10:00:29 +0200, Christophe Leroy wrote: > During merge of commit 4e991e3c16a3 ("powerpc: add CFUNC assembly > label annotation") a fallback version of CFUNC macro was added at > the last minute, so it can be used inconditionally. > > Applied to powerpc/next. [1/1] powerpc/vd

Re: [PATCH v2] powerpc/32: Implement validation of emergency stack

2024-09-06 Thread Michael Ellerman
On Tue, 20 Aug 2024 14:26:54 +0200, Christophe Leroy wrote: > VMAP stack added an emergency stack on powerpc/32 for when there is > a stack overflow, but failed to add stack validation for that > emergency stack. That validation is required for show stack. > > Implement it. > > > [...] Applied

Re: [PATCH v4 RESEND] powerpc: Replace kretprobe code with rethook on powerpc

2024-09-06 Thread Michael Ellerman
On Fri, 30 Aug 2024 07:31:31 -0400, Abhishek Dubey wrote: > This is an adaptation of commit f3a112c0c40d ("x86,rethook,kprobes: > Replace kretprobe with rethook on x86") to powerpc. > > Rethook follows the existing kretprobe implementation, but separates > it from kprobes so that it can be used by

Re: [PATCH v2] powerpc/qspinlock: Fix deadlock in MCS queue

2024-09-06 Thread Michael Ellerman
On Thu, 29 Aug 2024 07:58:27 +0530, Nysal Jan K.A. wrote: > If an interrupt occurs in queued_spin_lock_slowpath() after we increment > qnodesp->count and before node->lock is initialized, another CPU might > see stale lock values in get_tail_qnode(). If the stale lock value happens > to match the l

Re: [oss-security] Linux kernel: memory leak in arch/powerpc/platforms/powernv/opal-irqchip.c: opal_event_init()

2024-09-06 Thread Michael Ellerman
Solar Designer writes: > Hi, > > This bug report is misaddressed. Per upstream's preference and common > sense (given how many issue reports there are against the Linux kernel), > most Linux kernel (maybe-)issues should first be reported to Linux > kernel maintainers/lists or (if you're reasonabl

Re: [PATCH RFC v3 1/2] mm: Add personality flag to limit address to 47 bits

2024-09-05 Thread Michael Ellerman
Charlie Jenkins writes: > Create a personality flag ADDR_LIMIT_47BIT to support applications > that wish to transition from running in environments that support at > most 47-bit VAs to environments that support larger VAs. This > personality can be set to cause all allocations to be below the 47-b

Re: [PATCH v2] powerpc/pseries/eeh: Fix pseries_eeh_err_inject

2024-09-05 Thread Michael Ellerman
Narayana Murty N writes: > VFIO_EEH_PE_INJECT_ERR ioctl is currently failing on pseries > due to missing implementation of err_inject eeh_ops for pseries. > This patch implements pseries_eeh_err_inject in eeh_ops/pseries > eeh_ops. Implements support for injecting MMIO load/store error > for testi

Re: [PATCH 13/15] powerpc/rtas: Use fsleep() to minimize additional sleep duration

2024-09-05 Thread Michael Ellerman
*/ > - if (ms <= 20) > - usleep_range(ms * 100, ms * 1000); > - else > - msleep(ms); > + fsleep(ms * 1000); > break; > case RTAS_BUSY: > ret = true; Acked-by: Michael Ellerman (powerpc) cheers

Re: [PATCH v5 0/5] Wire up getrandom() vDSO implementation on powerpc

2024-09-05 Thread Michael Ellerman
get it merged and get some wider test coverage. There is an existing comment in the a/p/vdso/Makefile about the fixed-r30 thing, tldr is it's a workaround to avoid breaking old versions of Go. For the series: Acked-by: Michael Ellerman (powerpc) If you can include Maddy's test results from Power9 in the change log for patch 5 that'd be nice. cheers

Re: [PATCH 2/3] mm: Pass vm_flags to generic_get_unmapped_area()

2024-09-03 Thread Michael Ellerman
mentation in the radix_enabled() case. > > Signed-off-by: Mark Brown > --- > arch/powerpc/mm/book3s64/slice.c | 4 ++-- > include/linux/sched/mm.h | 4 ++-- > mm/mmap.c| 10 ++ > 3 files changed, 10 insertions(+), 8 deletions(-) Ack

[PATCH] powerpc: Stop using no_llseek

2024-09-03 Thread Michael Ellerman
Since commit 868941b14441 ("fs: remove no_llseek"), no_llseek() is simply defined to be NULL, and a NULL llseek means seeking is unsupported. So for statically defined file_operations, such as all these, there's no need or benefit to set llseek = no_llseek. Signed-off-by: M

Re: [PATCH] tty: hvc: convert comma to semicolon

2024-09-02 Thread Michael Ellerman
Chen Ni writes: > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Chen Ni > --- > drivers/tty/hvc/hvsi_lib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Michael Ellerman (powerpc) cheers > diff --git a/drivers

Re: [PATCH v4 RESEND] powerpc: Replace kretprobe code with rethook on powerpc

2024-09-02 Thread Michael Ellerman
Abhishek Dubey writes: > This is an adaptation of commit f3a112c0c40d ("x86,rethook,kprobes: > Replace kretprobe with rethook on x86") to powerpc. > > Rethook follows the existing kretprobe implementation, but separates > it from kprobes so that it can be used by fprobe (ftrace-based > function en

Re: [PATCH v3 1/5] mm: Define VM_DROPPABLE for powerpc/32

2024-09-01 Thread Michael Ellerman
Christophe Leroy writes: > Commit 9651fcedf7b9 ("mm: add MAP_DROPPABLE for designating always > lazily freeable mappings") only adds VM_DROPPABLE for 64 bits > architectures. > > In order to also use the getrandom vDSO implementation on powerpc/32, > use VM_ARCH_1 for VM_DROPPABLE on powerpc/32. T

Re: [PATCH] powerpc: Use printk instead of WARN in change_memory_attr

2024-08-30 Thread Michael Ellerman
Christophe Leroy writes: > Le 27/08/2024 à 11:12, Ritesh Harjani (IBM) a écrit : >> [Vous ne recevez pas souvent de courriers de ritesh.l...@gmail.com. >> Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> Use pr_warn_once instead of WARN_ON_ONCE as

Re: [PATCH -next 1/4] powerpc: Remove obsoleted declaration for _get_SP

2024-08-30 Thread Michael Ellerman
cuigaosheng writes: > On 2024/8/22 22:16, LEROY Christophe wrote: >> >> Le 22/08/2024 à 15:06, Gaosheng Cui a écrit : >>> [Vous ne recevez pas souvent de courriers de cuigaoshe...@huawei.com. >>> Découvrez pourquoi ceci est important à >>> https://aka.ms/LearnAboutSenderIdentification ] >>> >>>

Re: [PATCH v2 05/17] vdso: Avoid call to memset() by getrandom

2024-08-30 Thread Michael Ellerman
Segher Boessenkool writes: > On Thu, Aug 29, 2024 at 07:36:38PM +0200, Christophe Leroy wrote: >> >> >> Le 28/08/2024 à 19:25, Segher Boessenkool a écrit : >> > >> >>Not sure about static binaries, though: do those even use the VDSO? >> > >> >With "static binary" people usually mean "a binary no

Re: [PATCH RFC v2 1/4] mm: Add MAP_BELOW_HINT

2024-08-29 Thread Michael Ellerman
Charlie Jenkins writes: > Some applications rely on placing data in free bits addresses allocated > by mmap. Various architectures (eg. x86, arm64, powerpc) restrict the > address returned by mmap to be less than the 48-bit address space, > unless the hint address uses more than 47 bits (the 48th

Re: [PATCH v3 3/3] powerpc/pseries/dlpar: Add device tree nodes for DLPAR IO add

2024-08-28 Thread Michael Ellerman
Haren Myneni writes: > On Wed, 2024-08-28 at 18:12 +1000, Michael Ellerman wrote: >> Hi Haren, >> >> One query below about the of_node refcounting. >> >> Haren Myneni writes: >> > In the powerpc-pseries specific implementation, the IO hotplug >>

Re: [PATCH v3 3/3] powerpc/pseries/dlpar: Add device tree nodes for DLPAR IO add

2024-08-28 Thread Michael Ellerman
Hi Haren, One query below about the of_node refcounting. Haren Myneni writes: > In the powerpc-pseries specific implementation, the IO hotplug > event is handled in the user space (drmgr tool). For the DLPAR > IO ADD, the corresponding device tree nodes and properties will > be added to the devi

Re: [PATCH] powerpc/qspinlock: Fix deadlock in MCS queue

2024-08-27 Thread Michael Ellerman
"Nysal Jan K.A." writes: > If an interrupt occurs in queued_spin_lock_slowpath() after we increment > qnodesp->count and before node->lock is initialized, another CPU might > see stale lock values in get_tail_qnode(). If the stale lock value happens > to match the lock on that CPU, then we write t

Re: [PATCH v2] powerpc/mm: Fix return type of pgd_val()

2024-08-27 Thread Michael Ellerman
On Thu, 22 Aug 2024 09:58:42 +0200, Christophe Leroy wrote: > Commit 6b0e82791bd0 ("powerpc/e500: switch to 64 bits PGD on 85xx > (32 bits)") switched PGD entries to 64 bits, but pgd_val() returns > an unsigned long which is 32 bits on PPC32. This is not a problem > for regular PMD entries because

Re: [PATCH] powerpc/vdso: Don't discard rela sections

2024-08-27 Thread Michael Ellerman
On Tue, 20 Aug 2024 13:28:07 +0200, Christophe Leroy wrote: > After building the VDSO, there is a verification that it contains > no dynamic relocation, see commit aff69273af61 ("vdso: Improve > cmd_vdso_check to check all dynamic relocations"). > > This verification uses readelf -r and doesn't wo

Re: [PATCH] powerpc/64e: Define mmu_pte_psize static

2024-08-27 Thread Michael Ellerman
On Tue, 20 Aug 2024 14:42:38 +0200, Christophe Leroy wrote: > mmu_pte_psize is only used in the tlb_64e.c, define it static. > > Applied to powerpc/fixes. [1/1] powerpc/64e: Define mmu_pte_psize static https://git.kernel.org/powerpc/c/d92b5cc29c792f1d3f0aaa3b29dddfe816c03e88 cheers

Re: [PATCH 1/2] MAINTAINERS: Mark powerpc Cell as orphaned

2024-08-27 Thread Michael Ellerman
On Fri, 26 Jul 2024 22:33:21 +1000, Michael Ellerman wrote: > Arnd is no longer actively maintaining Cell, mark it as orphan. > > Also drop the dead developerworks link. > > Applied to powerpc/next. [1/2] MAINTAINERS: Mark powerpc Cell as orphaned https://git.kerne

Re: [PATCH v4 0/5] Add generic data patching functions

2024-08-27 Thread Michael Ellerman
On Wed, 15 May 2024 12:44:40 +1000, Benjamin Gray wrote: > Currently patch_instruction() bases the write length on the value being > written. If the value looks like a prefixed instruction it writes 8 bytes, > otherwise it writes 4 bytes. This makes it potentially buggy to use for > writing arbitra

Re: [PATCH] powerpc: Remove LHZX_BE macro

2024-08-27 Thread Michael Ellerman
On Wed, 21 Aug 2024 08:47:51 +0200, Christophe Leroy wrote: > LHZX_BE has been unused since commit dbf44daf7c88 ("bpf, ppc64: remove > ld_abs/ld_ind") > > Remove it. > > Applied to powerpc/next. [1/1] powerpc: Remove LHZX_BE macro https://git.kernel.org/powerpc/c/a540ad3e386f8f84bc6d600b

[PATCH] MAINTAINERS: powerpc: Add Maddy

2024-08-26 Thread Michael Ellerman
Maddy will be helping out with upstream maintenance, add him as a reviewer. Signed-off-by: Michael Ellerman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 878dcd23b331..0ee724dcc05a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12912,6

Re: linux-next: boot warning after merge of the vfs-brauner tree

2024-08-26 Thread Michael Ellerman
"Pankaj Raghav (Samsung)" writes: > On Mon, Aug 26, 2024 at 05:59:31PM +1000, Stephen Rothwell wrote: >> Hi all, >> >> After merging the vfs-brauner tree, today's linux-next boot test (powerpc >> pseries_le_defconfig) produced this warning: > > iomap dio calls set_memory_ro() on the page that is

Re: [PATCH v2] ata: pata_macio: Use WARN instead of BUG

2024-08-26 Thread Michael Ellerman
Sergei Shtylyov writes: > On 8/20/24 6:04 AM, Michael Ellerman wrote: > >> The overflow/underflow conditions in pata_macio_qc_prep() should never >> happen. But if they do there's no need to kill the system entirely, a >> WARN and failing the IO request should be s

Re: [PATCH] crash: Default to CRASH_DUMP=n when support for it is unlikely

2024-08-25 Thread Michael Ellerman
Geert Uytterhoeven writes: > Hi Dave, > > On Fri, Aug 23, 2024 at 2:54 PM Dave Vasilevsky wrote: >> Fixes boot failures on 6.9 on PPC_BOOK3S_32 machines using >> Open Firmware. On these machines, the kernel refuses to boot >> from non-zero PHYSICAL_START, which occurs when CRASH_DUMP is on. >> >>

[PATCH 1/3] powerpc/64: Remove maple platform

2024-08-23 Thread Michael Ellerman
nux-fullhistory.git/commit/?id=f0d068d65c5e555ffcfbc189de32598f6f00770c Signed-off-by: Michael Ellerman --- Documentation/arch/powerpc/booting.rst | 4 +- arch/powerpc/Kconfig.debug | 6 - arch/powerpc/boot/.gitignore | 1 - arch/powerpc/boot/Makefile | 3 +- arch/powerpc/b

[PATCH 3/3] EDAC/powerpc: Remove "maple" drivers

2024-08-23 Thread Michael Ellerman
These two drivers are only buildable for the powerpc "maple" platform, which has now been removed. Remove the drivers. Signed-off-by: Michael Ellerman --- drivers/edac/Kconfig| 18 -- drivers/edac/Makefile | 2 - drivers/edac/amd8111_ed

[PATCH 2/3] cpufreq: maple: Remove maple driver

2024-08-23 Thread Michael Ellerman
es to support those machines. Signed-off-by: Michael Ellerman --- drivers/cpufreq/Kconfig.powerpc | 7 - drivers/cpufreq/Makefile| 1 - drivers/cpufreq/maple-cpufreq.c | 241 3 files changed, 249 deletions(-) delete mode 100644 drivers/cpufreq/maple-cp

[PATCH] powerpc/64s: Remove the "fast endian switch" syscall

2024-08-23 Thread Michael Ellerman
264b ("[POWERPC] Add fast little-endian switch system call") [2]: 529d235a0e19 ("powerpc: Add a proper syscall for switching endianness") [3]: 727f13616c45 ("powerpc: Disable the fast-endian switch syscall by default") Signed-off-by: Michael Ellerman --- arch/powerpc

[PATCH 1/2] powerpc/mm/64s: Move THP reqs into a separate symbol

2024-08-22 Thread Michael Ellerman
. Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/Kconfig.cputype | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 4b0d7d4f88f6..9536e591c72a 100644 --- a/arch/powerpc

[PATCH 2/2] powerpc/mm/64s: Restrict THP to Radix or HPT w/64K pages

2024-08-22 Thread Michael Ellerman
never run. See the stubs in arch/powerpc/include/asm/book3s/64/hash-4k.h. Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/Kconfig.cputype | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/platforms/Kconfig.cputype b/arch/powerpc/platforms/Kconfig.cputype index 9536e59

Re: [PATCH] powerpc/pseries: Use correct data types from pseries_hp_errorlog struct

2024-08-21 Thread Michael Ellerman
Haren Myneni writes: > _be32 type is defined for some elements in pseries_hp_errorlog > struct but also used them u32 after be32_to_cpu() conversion. > > Example: In handle_dlpar_errorlog() > hp_elog->_drc_u.drc_index = be32_to_cpu(hp_elog->_drc_u.drc_index); > > And later assigned to u32 type > d

[PATCH] macintosh/via-pmu: register_pmu_pm_ops() can be __init

2024-08-21 Thread Michael Ellerman
register_pmu_pm_ops() is only called at init time, via device_initcall(), so can be marked __init. The driver can't be built as a module. Signed-off-by: Michael Ellerman --- drivers/macintosh/via-pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/macintos

[PATCH] powerpc/64s: Make mmu_hash_ops __ro_after_init

2024-08-21 Thread Michael Ellerman
The mmu_hash_ops are only assigned to during boot, so mark them __ro_after_init to prevent any further modification. Signed-off-by: Michael Ellerman --- arch/powerpc/mm/book3s64/hash_utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/mm/book3s64

[PATCH] powerpc/64s/mm: Move __real_pte stubs into hash-4k.h

2024-08-21 Thread Michael Ellerman
The stub versions of __real_pte() etc are only used with HPT & 4K pages, so move them into the hash-4k.h header. Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/book3s/64/hash-4k.h | 20 +++ arch/powerpc/include/asm/book3s/64/pgtable.h | 26 2 f

[PATCH] powerpc/configs/64s: Enable DEFERRED_STRUCT_PAGE_INIT

2024-08-19 Thread Michael Ellerman
It can speed up initialisation of page structs at boot on large machines. Signed-off-by: Michael Ellerman --- arch/powerpc/configs/ppc64_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/configs/ppc64_defconfig b/arch/powerpc/configs/ppc64_defconfig index 544a65fda77b

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

2024-08-19 Thread Michael Ellerman
Linus Torvalds writes: > On Mon, 19 Aug 2024 at 13:15, Linus Torvalds > wrote: >> >> Ok, I did a quick hack-job to remove that disgusting >> install_special_mapping() legacy case. >> >> With this [..] > > I forgot to actually attach that "this". Here it is. For real, this time. > >

[PATCH v2] ata: pata_macio: Use WARN instead of BUG

2024-08-19 Thread Michael Ellerman
The overflow/underflow conditions in pata_macio_qc_prep() should never happen. But if they do there's no need to kill the system entirely, a WARN and failing the IO request should be sufficient and might allow the system to keep running. Signed-off-by: Michael Ellerman --- driver

[PATCH v2] ata: pata_macio: Fix DMA table overflow

2024-08-19 Thread Michael Ellerman
nel.org/all/3b6441b8-06e6-45da-9e55-f92f2c869...@ufal.mff.cuni.cz/ Tested-by: Kolbjørn Barmen Signed-off-by: Michael Ellerman --- drivers/ata/pata_macio.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) v2: Namespace the defines as requested by Damien. Tab align t

Re: [PATCH v3 14/16] modules: Support extended MODVERSIONS info

2024-08-19 Thread Michael Ellerman
Matthew Maurer writes: > On Fri, Aug 16, 2024 at 4:04 PM Michael Ellerman wrote: >> Matthew Maurer writes: >> > Adds a new format for MODVERSIONS which stores each field in a separate >> > ELF section. This initially adds support for variable length names, but >

  1   2   3   4   5   6   7   8   9   10   >