Re: [PATCH 13/13] powerpc/rtas: place tracepoints in do_enter_rtas()

2022-11-28 Thread Michael Ellerman
Nathan Lynch writes: > "Nicholas Piggin" writes: >> On Sat Nov 19, 2022 at 1:07 AM AEST, Nathan Lynch wrote: >>> Call the just-added rtas tracepoints in do_enter_rtas(), taking care >>> to avoid function name lookups in the CPU offline path. >>> >>> Signed-off-by: Nathan Lynch >>> --- >>>

Re: [PATCH 2/3] powerpc/book3e: remove #include

2022-11-27 Thread Michael Ellerman
Thomas Weißschuh writes: > On 2022-11-26 07:36+, Christophe Leroy wrote: >> Le 26/11/2022 à 06:10, Thomas Weißschuh a écrit : >>> Commit 7ad4bd887d27 ("powerpc/book3e: get rid of #include >>> ") >>> removed the usage of the define UTS_VERSION but forgot to drop the >>> include. >> >> What

[PATCH] powerpc/64s: Add missing declaration for machine_check_early_boot()

2022-11-25 Thread Michael Ellerman
There's no declaration for machine_check_early_boot(), which leads to a build failure with W=1. Add one. Fixes: 2f5182cffa43 ("powerpc/64s: early boot machine check handler") Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/interrupt.h | 1 + 1 file changed, 1 insertio

Re: [PATCH linux-next] powerpc/cell/axon_msi: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2022-11-24 Thread Michael Ellerman
Christophe Leroy writes: > Hi, > > Le 23/11/2022 à 10:06, zhang.son...@zte.com.cn a écrit : >> From: zhang songyi >> >> Fix the following coccicheck warning: >> /arch/powerpc/platforms/cell/axon_msi.c:457:0-23: WARNING: >> fops_msic should be defined with DEFINE_DEBUGFS_ATTRIBUTE > > What's the

Re: [PATCH v2] powerpc/hv-gpci: Fix hv_gpci event list

2022-11-24 Thread Michael Ellerman
quests") > Signed-off-by: Kajol Jain > Reviewed-by: Madhavan Srinivasan > --- > Changelog: > > v1 -> v2 > - As suggested by Michael Ellerman, using counter_info_version value > rather then cpu_has_feature() to assign hv-gpci event list. >

Re: [PATCH] powerpc/pseries: Add a null judgment after iommu_pseries_alloc_group

2022-11-24 Thread Michael Ellerman
Deming Wang writes: > We should avoid use the return value directly after call > iommu_pseries_alloc_group. Because it_may return a null. We should probably at least print a warning in that case though? Otherwise someone's PCI device will not work with no indication why, or more likely the

Re: [PATCH] cxl: fix typo in comment

2022-11-24 Thread Michael Ellerman
Christophe Leroy writes: > Le 23/05/2022 à 01:27, Andrew Donnellan a écrit : >> On 21/5/22 21:11, Julia Lawall wrote: >>> Spelling mistake (triple letters) in comment. >>> Detected with the help of Coccinelle. >>> >>> Signed-off-by: Julia Lawall >> >> Acked-by: Andrew Donnellan >> >> > > How

Re: linux-next: manual merge of the tip tree with the powerpc-objtool tree

2022-11-24 Thread Michael Ellerman
Christophe Leroy writes: > Le 24/11/2022 à 02:29, Stephen Rothwell a écrit : >> Hi all, >> >> Today's linux-next merge of the tip tree got a conflict in: >> >>tools/objtool/check.c >> >> between commit: >> >>efb11fdb3e1a ("objtool: Fix SEGFAULT") >> >> from the powerpc-objtool tree

[GIT PULL] Please pull powerpc/linux.git powerpc-6.1-5 tag

2022-11-19 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull another powerpc fix for 6.1: The following changes since commit 02a771c9a68a9f08cce4ec5e324fb1bc4dce7202: powerpc/32: Select ARCH_SPLIT_ARG64 (2022-11-01 15:27:12 +1100) are available in the git repository at:

Re: [PATCH] powerpc: Fix writable sections being moved into the rodata region

2022-11-19 Thread Michael Ellerman
On Wed, 16 Nov 2022 14:39:53 +1000, Nicholas Piggin wrote: > .data.rel.ro* catches .data.rel.root_cpuacct, and the kernel crashes on > a store in css_clear_dir. At least we know read-only data protection is > working... > > Applied to powerpc/fixes. [1/1] powerpc: Fix writable sections being

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.1-4 tag

2022-11-03 Thread Michael Ellerman
Linus Torvalds writes: > On Wed, Nov 2, 2022 at 7:09 PM Michael Ellerman wrote: >> >> - Fix an endian thinko in the asm-generic compat_arg_u64() which led to >> syscall arguments >>being swapped for some compat syscalls. > > Am I mis-reading this, or did t

Re: [PATCH v5 0/2] powerpc module arch checks

2022-11-03 Thread Michael Ellerman
Luis Chamberlain writes: > On Mon, Oct 31, 2022 at 10:07:31PM +1000, Nicholas Piggin wrote: >> Luis if you would be okay for patch 1 to be merged via powerpc or >> prefer to take it in the module tree (or maybe you object to the >> code in the first place). > > Looks good to me, and nothing on my

[GIT PULL] Please pull powerpc/linux.git powerpc-6.1-4 tag

2022-11-02 Thread Michael Ellerman
. - -- Andreas Schwab (2): asm-generic: compat: fix compat_arg_u64() and compat_arg_u64_dual() powerpc/32: fix syscall wrappers with 64-bit arguments Michael Ellerman (3): Merge tag 'v6.1-rc2' into fixes powerpc/64e: Fix

Re: Issues with the first PowerPC updates for the kernel 6.1 #forregzbot

2022-11-02 Thread Michael Ellerman
Thorsten Leemhuis writes: > [Note: this mail is primarily send for documentation purposes and/or for > regzbot, my Linux kernel regression tracking bot. That's why I removed > most or all folks from the list of recipients, but left any that looked > like a mailing lists. These mails usually

Re: [PATCH v5 02/16] powerpc: Override __ALIGN and __ALIGN_STR macros

2022-11-02 Thread Michael Ellerman
Christophe Leroy writes: > Le 28/10/2022 à 16:33, Sathvika Vasireddy a écrit : >> In a subsequent patch, we would want to annotate powerpc assembly functions >> with SYM_FUNC_START_LOCAL macro. This macro depends on __ALIGN macro. >> >> The default expansion of __ALIGN macro is: >>

Re: [PATCH] powerpc/32: fix syscall wrappers with 64-bit arguments

2022-11-01 Thread Michael Ellerman
On Mon, 31 Oct 2022 15:47:35 +0100, Andreas Schwab wrote: > With the introducion of syscall wrappers all wrappers for syscalls with > 64-bit arguments must be handled specially, not only those that have > unaligned 64-bit arguments. This left out the fallocate and > sync_file_range2 syscalls. >

Re: [PATCH] asm-generic: compat: fix compat_arg_u64 and compat_arg_u64_dual

2022-11-01 Thread Michael Ellerman
On Mon, 31 Oct 2022 14:23:13 +0100, Andreas Schwab wrote: > The macros are defined backwards. > > Applied to powerpc/fixes. [1/1] asm-generic: compat: fix compat_arg_u64 and compat_arg_u64_dual https://git.kernel.org/powerpc/c/40ff21432883216aa440b6619d559ad8f7d7a7d9 cheers

Re: [PATCH] powerpc/32: Select ARCH_SPLIT_ARG64

2022-11-01 Thread Michael Ellerman
On Tue, 1 Nov 2022 14:48:52 +1100, Michael Ellerman wrote: > On 32-bit kernels, 64-bit syscall arguments are split into two > registers. For that to work with syscall wrappers, the prototype of the > syscall must have the argument split so that the wrapper macro properly > unpacks t

Re: [PATCH] powerpc/64e: Fix amdgpu build on Book3E w/o AltiVec

2022-11-01 Thread Michael Ellerman
On Thu, 27 Oct 2022 23:56:26 +1100, Michael Ellerman wrote: > There's a build failure for Book3E without AltiVec: > Error: cc1: error: AltiVec not supported in this target > make[6]: *** [/linux/scripts/Makefile.build:250: > drivers/gpu/drm/amd/amdgpu/../display/dc/dml/displa

[PATCH] powerpc/32: Select ARCH_SPLIT_ARG64

2022-10-31 Thread Michael Ellerman
scall wrapper") Signed-off-by: Michael Ellerman --- arch/powerpc/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index 20fb1765238c..2ca5418457ed 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -147,6 +147,7 @@

Re: [PATCH v6 21/25] powerpc: Provide syscall wrapper

2022-10-30 Thread Michael Ellerman
Andreas Schwab writes: > On Okt 30 2022, Arnd Bergmann wrote: > >> On Sun, Oct 30, 2022, at 16:34, Andreas Schwab wrote: >>> This breaks powerpc32. The fallocate syscall misinterprets its >>> arguments. >> >> It was fixed in > > Nope. Ack.

[GIT PULL] Please pull powerpc/linux.git powerpc-6.1-3 tag

2022-10-29 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull some more powerpc fixes for 6.1: The following changes since commit 9abf2313adc1ca1b6180c508c25f22f9395cc780: Linux 6.1-rc1 (2022-10-16 15:36:24 -0700) are available in the git repository at:

Re: [PATCH 1/3] powerpc/64s: Disable preemption in hash lazy mmu mode

2022-10-28 Thread Michael Ellerman
On Fri, 14 Oct 2022 01:16:45 +1000, Nicholas Piggin wrote: > apply_to_page_range on kernel pages does not disable preemption, which > is a requirement for hash's lazy mmu mode, which keeps track of the > TLBs to flush with a per-cpu array. > > Applied to powerpc/fixes. [1/3] powerpc/64s:

Re: [PATCH v2 0/2] powerpc: misc interrupt and context tracking

2022-10-28 Thread Michael Ellerman
On Fri, 14 Oct 2022 13:07:27 +1000, Nicholas Piggin wrote: > These are several fixes for regressions and crash bugs. Since v1 > I cut down the fixes to a minimum. > > Thanks, > Nick > > Nicholas Piggin (2): > KVM: PPC: BookS PR-KVM and BookE do not support context tracking >

Re: [PATCH] powerpc/64s/interrupt: Fix clear of PACA_IRQS_HARD_DIS when returning to soft-masked context

2022-10-28 Thread Michael Ellerman
On Sat, 22 Oct 2022 15:22:07 +1000, Nicholas Piggin wrote: > Commit a4cb3651a1743 ("powerpc/64s/interrupt: Fix lost interrupts when > returning to soft-masked context") fixed the problem of pending irqs > pending cleared when clearing the HARD_DIS bit, but then it didn't clear > the bit at all.

Re: [PATCH 1/3] powerpc/64s: Add lockdep for HPTE lock

2022-10-28 Thread Michael Ellerman
On Fri, 14 Oct 2022 09:07:08 +1000, Nicholas Piggin wrote: > Add lockdep annotation for the HPTE bit-spinlock. Modern systems don't > take the tlbie lock, so this shows up some of the same lockdep warnings > that were being reported by the ppc970. And they're not taken in exactly > the same places

Re: (subset) [PATCH 0/4] powerpc: misc interrupt and context tracking fixes

2022-10-28 Thread Michael Ellerman
On Fri, 7 Oct 2022 00:04:09 +1000, Nicholas Piggin wrote: > These are several fixes for regressions and bugs that can crash > the host. > > Thanks, > Nick > > Nicholas Piggin (4): > KVM: PPC: BookS PR-KVM and BookE do not support context tracking > powerpc/64s/interrupt: Perf NMI should not

[PATCH] powerpc/64e: Fix amdgpu build on Book3E w/o AltiVec

2022-10-27 Thread Michael Ellerman
by PPC_LONG_DOUBLE_128, but that symbol can be enabled even though AltiVec is disabled. The only user of PPC_LONG_DOUBLE_128 is amdgpu, so just add a dependency on AltiVec to that symbol to fix the build. Signed-off-by: Michael Ellerman --- arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1

Re: Linux 6.1-rc2

2022-10-25 Thread Michael Ellerman
Guenter Roeck writes: > On Tue, Oct 25, 2022 at 09:41:50AM -0700, Linus Torvalds wrote: >> On Tue, Oct 25, 2022 at 9:24 AM Guenter Roeck wrote: >> > >> > Build results: >> > total: 152 pass: 152 fail: 0 >> > Qemu test results: >> > total: 499 pass: 499 fail: 0 >> >> Woo-hoo! >>

Re: [PATCH] powerpc/pseries: Use lparcfg to reconfig VAS windows for DLPAR CPU

2022-10-20 Thread Michael Ellerman
On Thu, 06 Oct 2022 22:29:59 -0700, Haren Myneni wrote: > The hypervisor assigns VAS (Virtual Accelerator Switchboard) > windows depends on cores configured in LPAR. The kernel uses > OF reconfig notifier to reconfig VAS windows for DLPAR CPU event. > In the case of shared CPU mode partition, the

Re: [PATCH v3] powerpc/pseries/vas: Add VAS IRQ primary handler

2022-10-20 Thread Michael Ellerman
On Sun, 09 Oct 2022 20:41:25 -0700, Haren Myneni wrote: > irq_default_primary_handler() can be used only with IRQF_ONESHOT > flag, but the flag disables IRQ before executing the thread handler > and enables it after the interrupt is handled. But this IRQ disable > sets the VAS IRQ OFF state in the

Re: warning from change_protection in 6.1 rc1

2022-10-20 Thread Michael Ellerman
"Nicholas Piggin" writes: > On Wed Oct 19, 2022 at 8:21 PM AEST, Dan Horák wrote: >> Hi, >> >> in my first boot with the 6.1 rc1 kernel I have received a couple of >> warnings from change_protection on Talos II P9 system, see the details >> below. Nothing like that was noticed in 6.0 or earlier.

Re: [PATCH] mm: remove kern_addr_valid() completely

2022-10-18 Thread Michael Ellerman
3 -- > arch/mips/include/asm/pgtable.h | 2 - > arch/nios2/include/asm/pgtable.h | 2 - > arch/openrisc/include/asm/pgtable.h | 2 - > arch/parisc/include/asm/pgtable.h | 15 ---- > arch/powerpc/include/asm/pgtable.h| 7 Acked-by: Michael Ellerman (powerpc) cheers

Re: [PATCH] powerpc/hv-gpci: Fix hv_gpci event list

2022-10-18 Thread Michael Ellerman
Kajol Jain writes: > Based on getPerfCountInfo v1.018 documentation, some of the > hv_gpci events got deprecated for platforms firmware that > supports counter_info_version 0x8 or above. > > Patch fixes the hv_gpci event list by adding a new attribute > group called "hv_gpci_event_attrs_v6" and a

Re: Issues with the first PowerPC updates for the kernel 6.1

2022-10-16 Thread Michael Ellerman
Christian Zigotzky writes: > No, it’s not fine. We used the POWER4 CPU config before. We dropped POWER4 support in 2018. The recent commit just updated the help text to match reality. There were some changes to the CPU flags, but if anything they should have made things more likely to work

Re: Issues with the first PowerPC updates for the kernel 6.1

2022-10-16 Thread Michael Ellerman
Olof Johansson writes: > On Fri, Oct 14, 2022 at 9:11 AM Christian Zigotzky > wrote: >> >> make oldconfig has asked because of the CPU family. I choosed GENERIC for my >> P.A. Semi PWRficient PA6T-1682M. Is this correct? Maybe this is the problem. >> >> config GENERIC_CPU >> - bool "Generic

Re: [PATCH] powerpc/pseries: Fix CONFIG_DTL=n build

2022-10-14 Thread Michael Ellerman
On Thu, 13 Oct 2022 17:31:31 +1000, Nicholas Piggin wrote: > The recently moved dtl code must be compiled-in if > CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=y even if CONFIG_DTL=n. > > Applied to powerpc/fixes. [1/1] powerpc/pseries: Fix CONFIG_DTL=n build

Re: [PATCH] powerpc/64s/interrupt: Fix lost interrupts when returning to soft-masked context

2022-10-14 Thread Michael Ellerman
On Thu, 13 Oct 2022 16:44:18 +1000, Nicholas Piggin wrote: > It's possible for an interrupt returning to an irqs-disabled context to > lose a pending soft-masked irq because it branches to part of the exit > code for irqs-enabled contexts, which is meant to clear only the > PACA_IRQS_HARD_DIS flag

Re: (subset) [PATCH 1/2] powerpc/32: fix syscall wrappers with 64-bit arguments of unaligned register-pairs

2022-10-14 Thread Michael Ellerman
On Wed, 12 Oct 2022 13:53:34 +1000, Nicholas Piggin wrote: > powerpc 32-bit system call (and function) calling convention for 64-bit > arguments requires the next available odd-pair (two sequential registers > with the first being odd-numbered) from the standard register argument > allocation. >

[GIT PULL] Please pull powerpc/linux.git powerpc-6.1-2 tag

2022-10-14 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull powerpc fixes for 6.1: The following changes since commit ae5b6779fa8724628bbad58126a626d0cd599414: powerpc: Fix 85xx build (2022-10-11 10:13:34 -0700) are available in the git repository at:

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.1-1 tag

2022-10-12 Thread Michael Ellerman
Guenter Roeck writes: > On Wed, Oct 12, 2022 at 11:20:38AM -0600, Jason A. Donenfeld wrote: >> >> I've also managed to not hit this bug a few times. When it triggers, >> after "kprobes: kprobe jump-optimization is enabled. All kprobes are >> optimized if possible.", there's a long hang - tens

Re: [GIT PULL] virtio: fixes, features

2022-10-12 Thread Michael Ellerman
Michael Ellerman writes: > [ Cc += Bjorn & linux-pci ] > > "Michael S. Tsirkin" writes: >> On Wed, Oct 12, 2022 at 05:21:24PM +1100, Michael Ellerman wrote: >>> "Michael S. Tsirkin" writes: > ... >>> > -

Re: [GIT PULL] virtio: fixes, features

2022-10-12 Thread Michael Ellerman
[ Cc += Bjorn & linux-pci ] "Michael S. Tsirkin" writes: > On Wed, Oct 12, 2022 at 05:21:24PM +1100, Michael Ellerman wrote: >> "Michael S. Tsirkin" writes: ... >> > >> > virtio:

Re: [GIT PULL] virtio: fixes, features

2022-10-12 Thread Michael Ellerman
"Michael S. Tsirkin" writes: > The following changes since commit 4fe89d07dcc2804c8b562f6c7896a45643d34b2f: > > Linux 6.0 (2022-10-02 14:09:07 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus > > for you to

Re: [PATCH] powerpc/kasan/book3s_64: warn when running with hash MMU

2022-10-11 Thread Michael Ellerman
Nathan Lynch writes: > Michael Ellerman writes: >> Christophe Leroy writes: >>> + KASAN list >>> >>> Le 06/10/2022 à 06:10, Michael Ellerman a écrit : >>>> Nathan Lynch writes: >>>>> kasan is known to crash at boot on book

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.1-1 tag

2022-10-11 Thread Michael Ellerman
"Jason A. Donenfeld" writes: > On Tue, Oct 11, 2022 at 12:53:17PM +1100, Michael Ellerman wrote: >> "Jason A. Donenfeld" writes: >> > On Mon, Oct 10, 2022 at 01:25:25PM -0600, Jason A. Donenfeld wrote: >> >> Hi Michael, >> >> &g

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.1-1 tag

2022-10-11 Thread Michael Ellerman
"Jason A. Donenfeld" writes: > On Tue, Oct 11, 2022 at 12:44:20PM +1100, Michael Ellerman wrote: >> "Jason A. Donenfeld" writes: >> > Hi Andrew, >> > >> > On Tue, Oct 11, 2022 at 11:00:15AM +1100, Andrew Donnellan wrote: >> >&g

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.1-1 tag

2022-10-10 Thread Michael Ellerman
"Jason A. Donenfeld" writes: > On Mon, Oct 10, 2022 at 01:25:25PM -0600, Jason A. Donenfeld wrote: >> Hi Michael, >> >> On Sun, Oct 09, 2022 at 10:01:39PM +1100, Michael Ellerman wrote: >> > powerpc updates for 6.1 >> > >> > - Remove

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-6.1-1 tag

2022-10-10 Thread Michael Ellerman
"Jason A. Donenfeld" writes: > Hi Andrew, > > On Tue, Oct 11, 2022 at 11:00:15AM +1100, Andrew Donnellan wrote: >> Thanks for bisecting, this is interesting! Could you provide your >> .config and the environment you're running in? Your reproducer doesn't >> seem to trigger it on my baremetal

Re: [PATCH linux-next][RFC] powerpc: fix HOTPLUG error in rcutorture

2022-10-10 Thread Michael Ellerman
Zhouyi Zhou writes: > I think we should avoid torture offline the cpu who do tick timer > when nohz full is running. Can you tell us what the bug you're fixing is? Did you see a crash/oops/hang etc? Or are you just proposing this as something that would be a good idea? > Tested on PPC VM of

[GIT PULL] Please pull powerpc/linux.git powerpc-6.1-1 tag

2022-10-09 Thread Michael Ellerman
put() in macio_gpio_init_one() powerpc/powermac/udbg_scc: Add missing of_node_put()s in udbg_scc_init() Lukas Bulwahn (1): powerpc/configs: Update config files for removed/renamed symbols Michael Ellerman (30): powerpc/boot: Convert more files to use SPDX tags powerpc/boot: Drop unused dumm

Re: [PATCH] powerpc/64: Remove unused prom_init_toc symbols

2022-10-09 Thread Michael Ellerman
On Tue, 20 Sep 2022 23:11:57 +1000, Michael Ellerman wrote: > Commit 24d33ac5b8ff ("powerpc/64s: Make prom_init require RELOCATABLE") > made prom_init depend on CONFIG_RELOCATABLE. > > But it missed cleaning up a case in the linker script for RELOCATABLE=n, > and associ

Re: [PATCH] powerpc/64s/interrupt: stack backtrace fix

2022-10-09 Thread Michael Ellerman
On Tue, 4 Oct 2022 23:29:52 +1000, Nicholas Piggin wrote: > The value of the stack frame regs marker that gets saved on the > stack in interrupt entry code does not match the regs marker value, > which breaks stack frame marker matching. > > This stray instruction looks to have been introduced in

Re: [PATCH] KVM: PPC: Book3S HV: Fix stack frame regs marker

2022-10-09 Thread Michael Ellerman
On Fri, 7 Oct 2022 00:33:45 +1000, Nicholas Piggin wrote: > The hard-coded marker is out of date now, fix it using the nice define. > > Applied to powerpc/next. [1/1] KVM: PPC: Book3S HV: Fix stack frame regs marker

Re: [PATCH 1/2] powerpc/64s/interrupt: Change must-hard-mask interrupt check from BUG to WARN

2022-10-09 Thread Michael Ellerman
On Tue, 4 Oct 2022 15:11:56 +1000, Nicholas Piggin wrote: > This new assertion added is generally harmless and gets fixed up > naturally, but it does indicate a problem with MSR manipulation > somewhere. > > Applied to powerpc/next. [1/2] powerpc/64s/interrupt: Change must-hard-mask interrupt

Re: [PATCH] powerpc/kasan/book3s_64: warn when running with hash MMU

2022-10-07 Thread Michael Ellerman
Christophe Leroy writes: > + KASAN list > > Le 06/10/2022 à 06:10, Michael Ellerman a écrit : >> Nathan Lynch writes: >>> kasan is known to crash at boot on book3s_64 with non-radix MMU. As >>> noted in commit 41b7a347bf14 ("powerpc: Book3S

Re: [PATCH v2 06/19] powerpc/cputable: Split cpu_specs[] out of cputable.h

2022-10-07 Thread Michael Ellerman
Christophe Leroy writes: > Le 20/09/2022 à 10:56, Nicholas Piggin a écrit : >> On Tue Sep 20, 2022 at 3:01 AM AEST, Christophe Leroy wrote: >> >> This series is a nice cleanup. No comments yet but kernel/ is getting >> pretty crowded. Should we make some subdirectories for subarch things >> like

Re: [PATCH] powerpc/64s: POWER10 CPU Kconfig build option

2022-10-06 Thread Michael Ellerman
"Nicholas Piggin" writes: > On Fri Oct 7, 2022 at 9:23 AM AEST, Segher Boessenkool wrote: >> On Fri, Oct 07, 2022 at 07:56:09AM +1000, Nicholas Piggin wrote: >> > On Fri Oct 7, 2022 at 5:54 AM AEST, Segher Boessenkool wrote: >> > > On Fri, Sep 23, 2022 at 01:30:04PM +1000, Nicholas Piggin wrote:

[PATCH] powerpc: Don't add __powerpc_ prefix to syscall entry points

2022-10-06 Thread Michael Ellerman
calls.h, so drop the ones from signal.h. Fixes: 7e92e01b7245 ("powerpc: Provide syscall wrapper") Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/syscall_wrapper.h | 18 -- arch/powerpc/include/asm/syscalls.h| 2 +- arch/powerpc/kernel/signal.h

Re: [RFC PATCH 2/3] powerpc: remove the last remnants of cputime_t

2022-10-06 Thread Michael Ellerman
Nicholas Piggin writes: > cputime_t is no longer, converted to u64. Would be good to have some explanation of why we had it and why we don't need it anymore. cheers > diff --git a/arch/powerpc/include/asm/cputime.h > b/arch/powerpc/include/asm/cputime.h > index 431ae2343022..4961fb38e438

Re: [PATCH] powerpc/kasan/book3s_64: warn when running with hash MMU

2022-10-05 Thread Michael Ellerman
Nathan Lynch writes: > kasan is known to crash at boot on book3s_64 with non-radix MMU. As > noted in commit 41b7a347bf14 ("powerpc: Book3S 64-bit outline-only > KASAN support"): > > A kernel with CONFIG_KASAN=y will crash during boot on a machine > using HPT translation because not all the

[PATCH 2/2] powerpc: Print instruction dump on a single line

2022-10-05 Thread Michael Ellerman
aware of will wrap the line if it's too long, so the length should not be a functional problem. If anything it should help on consoles like VGA by using less vertical space. Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/process.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff

[PATCH 1/2] powerpc: Make instruction dump work with scripts/decodecode

2022-10-05 Thread Michael Ellerman
7c 7d295378 ^D All code 0: f0 ff c1 fb std r30,-16(r1) 4: c1 ff 21 f8 stdur1,-64(r1) 8: 78 1b 7d 7c mr r29,r3 ... Note that the script doesn't cope well with printk timestamps or printk caller info. Reported-by: Matthew Wilcox Signed

Re: [PATCH v3 5/6] powerpc/64: Add support for out-of-line static calls

2022-10-05 Thread Michael Ellerman
Christophe Leroy writes: > Le 05/10/2022 à 07:32, Benjamin Gray a écrit : >> Implement static call support for 64 bit V2 ABI. This requires making >> sure the TOC is kept correct across kernel-module boundaries. As a >> secondary concern, it tries to use the local entry point of a target >>

Re: [Bug report] BUG: Kernel NULL pointer dereference at 0x00000069, filemap_release_folio+0x88/0xb0

2022-10-05 Thread Michael Ellerman
Matthew Wilcox writes: > On Fri, Sep 30, 2022 at 12:01:26PM +1000, Michael Ellerman wrote: >> Matthew Wilcox writes: >> >> [ 4681.238745] Instruction dump: >> >> [ 4681.238749] fbc1fff0 f821ffc1 7c7d1b78 7c9c2378 ebc30028 7fdff378 >> >> 4800

Re: [PATCH 1/5] KVM: PPC: Book3S HV P9: Clear vcpu cpu fields before enabling host irqs

2022-10-04 Thread Michael Ellerman
On Thu, 8 Sep 2022 23:25:41 +1000, Nicholas Piggin wrote: > On guest entry, vcpu->cpu and vcpu->arch.thread_cpu are set after > disabling host irqs. On guest exit there is a window whre tick time > accounting briefly enables irqs before these fields are cleared. > > Move them up to ensure they

Re: [PATCH] powerpc: udbg: Remove extern function prototypes

2022-10-04 Thread Michael Ellerman
On Tue, 23 Aug 2022 01:17:51 +0200, Pali Rohár wrote: > 'extern' keywork is pointless and deprecated for function prototypes. > > Applied to powerpc/next. [1/1] powerpc: udbg: Remove extern function prototypes https://git.kernel.org/powerpc/c/6bd7ff497b4af13ea3d53781ffca7dc744dbb4da

Re: [PATCH v6 00/25] powerpc: Syscall wrapper and register clearing

2022-10-04 Thread Michael Ellerman
On Wed, 21 Sep 2022 16:55:40 +1000, Rohan McLure wrote: > V5 available here: > > Link: > https://lore.kernel.org/all/20220916053300.786330-2-rmcl...@linux.ibm.com/T/ > > Implement a syscall wrapper, causing arguments to handlers to be passed > via a struct pt_regs on the stack. The syscall

Re: [PATCH v2] powerpc: Add support for early debugging via Serial 16550 console

2022-10-04 Thread Michael Ellerman
On Tue, 23 Aug 2022 01:15:01 +0200, Pali Rohár wrote: > Currently powerpc early debugging contains lot of platform specific > options, but does not support standard UART / serial 16550 console. > > Later legacy_serial.c code supports registering UART as early debug console > from device tree but

Re: [PATCH] powerpc: dts: turris1x.dts: Fix NOR partitions labels

2022-10-04 Thread Michael Ellerman
On Wed, 31 Aug 2022 00:55:00 +0200, Pali Rohár wrote: > Partition partition@2 contains generic kernel image and it does not > have to be used only for rescue purposes. Partition partition@1c > contains bootable rescue system and partition partition@34 contains > factory image/data for

Re: [PATCH v3 0/7] powerpc/64: interrupt soft-mask and context fixes

2022-10-04 Thread Michael Ellerman
On Mon, 26 Sep 2022 15:42:58 +1000, Nicholas Piggin wrote: > No real changes since last posting, I just pulled fixes from several > series together and rearranged them and updated changelogs slightly. > > Thanks, > Nick > > Nicholas Piggin (7): > powerpc/64/interrupt: Fix false warning in

Re: [PATCH] powerpc: dts: turris1x.dts: Fix labels in DSA cpu port nodes

2022-10-04 Thread Michael Ellerman
On Sat, 27 Aug 2022 15:15:38 +0200, Pali Rohár wrote: > DSA cpu port node has to be marked with "cpu" label. > So fix it for both cpu port nodes. > > Applied to powerpc/next. [1/1] powerpc: dts: turris1x.dts: Fix labels in DSA cpu port nodes

Re: [PATCH] powerpc/boot: Explicitly disable usage of SPE instructions

2022-10-04 Thread Michael Ellerman
On Sat, 27 Aug 2022 15:44:54 +0200, Pali Rohár wrote: > uImage boot wrapper should not use SPE instructions, like kernel itself. > Boot wrapper has already disabled Altivec and VSX instructions but not SPE. > Options -mno-spe and -mspe=no already set when compilation of kernel, but > not when

Re: [PATCH v2 0/5] powerpc/64s: improve boot debugging

2022-10-04 Thread Michael Ellerman
On Mon, 26 Sep 2022 15:56:15 +1000, Nicholas Piggin wrote: > This series provides a machine check handler to catch out of > bounds memory accesses in early boot before the MMU is enabled. > > Since v1: > - 64e compile fix > > Nicholas Piggin (5): > powerpc/64s/interrupt: move early boot ILE

Re: [PATCH 1/2] powerpc: Fix SPE Power ISA properties for e500v1 platforms

2022-10-04 Thread Michael Ellerman
On Fri, 2 Sep 2022 23:21:02 +0200, Pali Rohár wrote: > Commit 2eb28006431c ("powerpc/e500v2: Add Power ISA properties to comply > with ePAPR 1.1") introduced new include file e500v2_power_isa.dtsi and > should have used it for all e500v2 platforms. But apparently it was used > also for e500v1

Re: [PATCH v4 1/2] powerpc: add ISA v3.0 / v3.1 wait opcode macro

2022-10-04 Thread Michael Ellerman
On Tue, 20 Sep 2022 22:22:58 +1000, Nicholas Piggin wrote: > The wait instruction encoding changed between ISA v2.07 and ISA v3.0. > In v3.1 the instruction gained a new field. > > Update the PPC_WAIT macro to the current encoding. Rename the older > incompatible one with a _v203 suffix as it was

Re: [PATCH v2 0/7] powerpc: build / linker improvements

2022-10-04 Thread Michael Ellerman
On Fri, 16 Sep 2022 14:07:48 +1000, Nicholas Piggin wrote: > This series is mainly about moving more things out of writable and > executable memory, and slightly moving the linker script in the > direction of the binutils ld internal linker script as we do. > > Thanks, > Nick > > [...] Applied

Re: [PATCH v2 0/5] powerpc/64: avoid GOT addressing, don't put data in TOC

2022-10-04 Thread Michael Ellerman
On Mon, 26 Sep 2022 13:40:52 +1000, Nicholas Piggin wrote: > This is a cleaned up set of the initial prep patches from the pcrel > series, dealing with regularising addressing variables from asm > and using helper macros more consistently. > > Changes since v1: > - Use "REGS" stack frame marker

Re: [PATCH] powerpc/time: avoid programming DEC at the start of the timer interrupt

2022-10-04 Thread Michael Ellerman
On Sat, 10 Sep 2022 00:24:57 +1000, Nicholas Piggin wrote: > Setting DEC to maximum at the start of the timer interrupt is not > necessary and can be avoided for performance when MSR[EE] is not > enabled during the handler as explained in commit 0faf20a1ad16 > ("powerpc/64s/interrupt: Don't enable

Re: [PATCH] powerpc: remove orphan systbl_chk.sh

2022-10-04 Thread Michael Ellerman
On Thu, 29 Sep 2022 13:21:20 +1000, Nicholas Piggin wrote: > arch/powerpc/kernel/systbl_chk.sh has not been referenced since commit > ab66dcc76d6a ("powerpc: generate uapi header and system call table > files"). Remove it. > > Applied to powerpc/next. [1/1] powerpc: remove orphan systbl_chk.sh

Re: [PATCH v3 1/4] powerpc/64s: Add DEBUG_PAGEALLOC for radix

2022-10-04 Thread Michael Ellerman
On Mon, 26 Sep 2022 07:57:23 +, Nicholas Miehlbradt wrote: > There is support for DEBUG_PAGEALLOC on hash but not on radix. > Add support on radix. > > Applied to powerpc/next. [1/4] powerpc/64s: Add DEBUG_PAGEALLOC for radix

Re: [PATCH] powerpc/pseries: move hcall_tracepoint_refcount out of .toc

2022-10-04 Thread Michael Ellerman
On Mon, 26 Sep 2022 15:38:23 +1000, Nicholas Piggin wrote: > The .toc section is not really intended for arbitrary data. Writable > data in particular prevents making the TOC read-only after relocation. > Move hcall_tracepoint_refcount into the .data section. > > Applied to powerpc/next. [1/1]

Re: [PATCH] powerpc/64s: POWER10 CPU Kconfig build option

2022-10-04 Thread Michael Ellerman
On Fri, 23 Sep 2022 13:30:04 +1000, Nicholas Piggin wrote: > This adds basic POWER10_CPU option, which builds with -mcpu=power10. > > Applied to powerpc/next. [1/1] powerpc/64s: POWER10 CPU Kconfig build option https://git.kernel.org/powerpc/c/4b2a9315f20d98576e25c9e4572e9a8e028d7aa2

Re: (subset) [PATCH 1/5] KVM: PPC: Book3S HV P9: Clear vcpu cpu fields before enabling host irqs

2022-10-04 Thread Michael Ellerman
On Thu, 8 Sep 2022 23:25:41 +1000, Nicholas Piggin wrote: > On guest entry, vcpu->cpu and vcpu->arch.thread_cpu are set after > disabling host irqs. On guest exit there is a window whre tick time > accounting briefly enables irqs before these fields are cleared. > > Move them up to ensure they

Re: [PATCH 1/2] powerpc/64s: Fix GENERIC_CPU build flags for PPC970 / G5

2022-10-04 Thread Michael Ellerman
On Wed, 21 Sep 2022 11:41:02 +1000, Nicholas Piggin wrote: > Big-endian GENERIC_CPU supports 970, but builds with -mcpu=power5. > POWER5 is ISA v2.02 whereas 970 is v2.01 plus Altivec. 2.02 added > the popcntb instruction which a compiler might use. > > Use -mcpu=power4. > > > [...] Applied to

Re: [PATCH v3] powerpc/smp: poll cpu_callin_map more aggressively in __cpu_up()

2022-10-04 Thread Michael Ellerman
On Mon, 26 Sep 2022 17:02:50 -0500, Nathan Lynch wrote: > At boot time, it is not necessary to delay between polls of > cpu_callin_map when waiting for a kicked CPU to come up. Remove the > delay intervals, but preserve the overall deadline (five seconds). > > At run time, the first poll result

Re: [PATCH v2 0/2] powerpc/pseries: restrict error injection and DT changes when locked down

2022-10-04 Thread Michael Ellerman
On Mon, 26 Sep 2022 08:16:41 -0500, Nathan Lynch wrote: > Add two new lockdown reasons for use in powerpc's pseries platform > code. > > The pseries platform allows hardware-level error injection via certain > calls to the RTAS (Run Time Abstraction Services) firmware. ACPI-based > error

Re: [PATCH] powerpc: Always select HAVE_EFFICIENT_UNALIGNED_ACCESS

2022-10-04 Thread Michael Ellerman
On Fri, 16 Sep 2022 23:15:23 +1000, Michael Ellerman wrote: > Currently powerpc selects HAVE_EFFICIENT_UNALIGNED_ACCESS in all cases > but one. The exception is if the kernel is being built little endian and > explicitly targetted for Power7. > > The combination of Power7 an

Re: [PATCH v3 1/6] powerpc: Add hardware description string

2022-10-04 Thread Michael Ellerman
On Fri, 30 Sep 2022 18:27:04 +1000, Michael Ellerman wrote: > Create a hardware description string, which we will use to record > various details of the hardware platform we are running on. > > Print the accumulated description at boot, and use it to set the generic > description w

Re: [PATCH] powerpc/64s: Remove lost/old comment

2022-10-04 Thread Michael Ellerman
On Wed, 28 Sep 2022 23:09:41 +1000, Michael Ellerman wrote: > The bulk of this was moved/reworded in: > 57f266497d81 ("powerpc: Use gas sections for arranging exception vectors") > > And now appears around line 700 in arch/powerpc/kernel/exceptions-64s.S. > > Ap

Re: [PATCH] powerpc/microwatt: Remove unused early debug code

2022-10-04 Thread Michael Ellerman
On Mon, 19 Sep 2022 15:27:55 +1000, Michael Ellerman wrote: > The original microwatt submission[1] included some early debug code for > using the Microwatt "potato" UART. > > The series that was eventually merged switched to using a standard UART, > and so doesn't nee

Re: [PATCH] powerpc: Drops STABS_DEBUG from linker scripts

2022-10-04 Thread Michael Ellerman
On Wed, 28 Sep 2022 23:09:51 +1000, Michael Ellerman wrote: > No toolchain we support should be generating stabs debug information > anymore. Drop the sections entirely from our linker scripts. > > We removed all the manual stabs annotations in commit > 12318163737c ("powerpc/

Re: [PATCH] powerpc/configs: Enable PPC_UV in powernv_defconfig

2022-10-04 Thread Michael Ellerman
On Thu, 29 Sep 2022 15:15:17 +1000, Michael Ellerman wrote: > Make sure the ultravisor code at least gets some build testing by > enabling it in powernv_defconfig. > > Applied to powerpc/next. [1/1] powerpc/configs: Enable PPC_UV in powernv_defconfig https://git.kernel.o

Re: [PATCH] powerpc/64s: Remove old STAB comment

2022-10-04 Thread Michael Ellerman
On Wed, 28 Sep 2022 23:09:12 +1000, Michael Ellerman wrote: > This used to be about the 0x4300 handler, but that was moved in commit > da2bc4644c75 ("powerpc/64s: Add new exception vector macros"). > > Note that "STAB" here refers to "Segment Table" not t

Re: [PATCH] powerpc/64: Remove unused SYS_CALL_TABLE symbol

2022-10-04 Thread Michael Ellerman
On Tue, 13 Sep 2022 22:45:45 +1000, Michael Ellerman wrote: > In interrupt_64.S, formerly entry_64.S, there are two toc entries > created for sys_call_table and compat_sys_call_table. > > These are no longer used, since the system call entry was converted from > asm to C,

Re: [PATCH 1/2] powerpc/vmlinux.lds: Ensure STRICT_ALIGN_SIZE is at least page aligned

2022-10-04 Thread Michael Ellerman
On Fri, 16 Sep 2022 23:14:21 +1000, Michael Ellerman wrote: > Add a check that STRICT_ALIGN_SIZE is aligned to at least PAGE_SIZE. > > That then makes the alignment to PAGE_SIZE immediately after the > alignment to STRICT_ALIGN_SIZE redundant, so remove it. > > Applied to p

Re: [PATCH 1/2] powerpc/mm/64s: Drop pgd_huge()

2022-10-04 Thread Michael Ellerman
On Sat, 3 Sep 2022 22:36:39 +1000, Michael Ellerman wrote: > On powerpc there are two ways for huge pages to be represented in the > top level page table, aka PGD (Page Global Directory). > > If the address space mapped by an individual PGD entry does not > correspond to a given

Re: [PATCH 1/2] powerpc: Make stack frame marker upper case

2022-10-04 Thread Michael Ellerman
On Wed, 28 Sep 2022 01:04:18 +1000, Michael Ellerman wrote: > Now that the stack frame regs marker is only 32-bits it is not as > obvious in memory dumps and easier to miss, eg: > > c4733e40 || > c4733e50 0

Re: [PATCH] powerpc: update config files

2022-10-04 Thread Michael Ellerman
On Thu, 29 Sep 2022 12:15:02 +0200, Lukas Bulwahn wrote: > Clean up config files by: > - removing configs that were deleted in the past > - removing configs not in tree and without recently pending patches > - adding new configs that are replacements for old configs in the file > > For some

Re: [PATCH] powerpc/kprobes: Fix null pointer reference in arch_prepare_kprobe()

2022-10-04 Thread Michael Ellerman
On Fri, 23 Sep 2022 17:32:53 +0800, Li Huafei wrote: > I found a null pointer reference in arch_prepare_kprobe(): > > # echo 'p cmdline_proc_show' > kprobe_events > # echo 'p cmdline_proc_show+16' >> kprobe_events > [ 67.278533][ T122] Kernel attempted to read user page (0) - exploit >

<    9   10   11   12   13   14   15   16   17   18   >