Re: [PATCH] powerpc/book3s: Inline first level of update_mmu_cache()

2022-10-04 Thread Michael Ellerman
On Mon, 5 Sep 2022 11:38:25 +0200, Christophe Leroy wrote: > update_mmu_cache() voids when hash page tables are not used. > On PPC32 that means when MMU_FTR_HPTE_TABLE is not defined. > On PPC64 that means when RADIX is enabled. > > Rename core part of update_mmu_cache() as __update_mmu_cache() >

Re: [PATCH 1/2] powerpc/nohash: Remove pgd_huge() stub

2022-10-04 Thread Michael Ellerman
On Wed, 7 Sep 2022 11:34:44 +0200, Christophe Leroy wrote: > linux/hugetlb.h has a fallback pgd_huge() macro for when > pgd_huge is not defined. > > Remove the powerpc redundant definitions. > > Applied to powerpc/next. [1/2] powerpc/nohash: Remove pgd_huge() stub

Re: [PATCH linux-next] powerpc/pseries/vas: Remove the unneeded result variable

2022-10-04 Thread Michael Ellerman
On Thu, 25 Aug 2022 07:26:57 +, cgel@gmail.com wrote: > From: ye xingchen > > Return the value vas_register_coproc_api() directly instead of storing it > in another redundant variable. > > Applied to powerpc/next. [1/1] powerpc/pseries/vas: Remove the unneeded result variable

Re: [PATCH] powerpc/mm: Fix UBSAN warning reported on hugetlb

2022-10-04 Thread Michael Ellerman
On Thu, 8 Sep 2022 12:54:40 +0530, Aneesh Kumar K.V wrote: > Powerpc architecture supports 16GB hugetlb pages with hash translation. For 4K > page size, this is implemented as a hugepage directory entry at PGD level and > for 64K it is implemented as a huge page pte at PUD level > > With 16GB

Re: [PATCH v2] powerpc/mm: Update max/min_low_pfn in the same function

2022-10-04 Thread Michael Ellerman
On Mon, 4 Jul 2022 12:08:51 +0530, Aneesh Kumar K.V wrote: > For both CONFIG_NUMA enabled/disabled use mem_topology_setup to > update max/min_low_pfn. > > This also add min_low_pfn update to CONFIG_NUMA which was initialized > to zero before. > > > [...] Applied to powerpc/next. [1/1]

Re: [PATCH linux-next] ocxl: Remove the unneeded result variable

2022-10-04 Thread Michael Ellerman
On Tue, 6 Sep 2022 07:20:06 +, cgel@gmail.com wrote: > From: ye xingchen > > Return the value opal_npu_spa_clear_cache() directly instead of storing > it in another redundant variable. > > Applied to powerpc/next. [1/1] ocxl: Remove the unneeded result variable

Re: (subset) [PATCH V2 1/3] powerpc/perf: Fix branch_filter support for multiple filters in powerpc

2022-10-04 Thread Michael Ellerman
On Wed, 21 Sep 2022 20:22:53 +0530, Athira Rajeev wrote: > For PERF_SAMPLE_BRANCH_STACK sample type, different branch_sample_type > ie branch filters are supported. The branch filters are requested via > event attribute "branch_sample_type". Multiple branch filters can be > passed in event

Re: [PATCH] powerpc/mm/book3s/hash: Rename flush_tlb_pmd_range

2022-10-04 Thread Michael Ellerman
On Wed, 7 Sep 2022 13:49:41 +0530, Aneesh Kumar K.V wrote: > This function does the hash page table update. Hence rename it to > indicate this better to avoid confusion with flush_pmd_tlb_range() > > Applied to powerpc/next. [1/1] powerpc/mm/book3s/hash: Rename flush_tlb_pmd_range

Re: [PATCH] KVM: PPC: Book3S HV: Fix decrementer migration

2022-10-04 Thread Michael Ellerman
On Tue, 16 Aug 2022 19:25:17 -0300, Fabiano Rosas wrote: > We used to have a workaround[1] for a hang during migration that was > made ineffective when we converted the decrementer expiry to be > relative to guest timebase. > > The point of the workaround was that in the absence of an explicit >

Re: [PATCH v2] i2c-pasemi: PASemi I2C controller IRQ enablement

2022-10-03 Thread Michael Ellerman
"Sven Peter" writes: > On Sun, Oct 2, 2022, at 16:07, Arminder Singh wrote: >> Hi, >> >>> #define REG_MTXFIFO0x00 >>> #define REG_MRXFIFO0x04 >>> #define REG_SMSTA 0x14 >>> +#define REG_IMASK 0x18 >> >>> This doesn't seem to be aligned correctly, this file seems to use a tab

Re: [PATCH v6 13/25] powerpc: Remove direct call to mmap2 syscall handlers

2022-09-30 Thread Michael Ellerman
"Arnd Bergmann" writes: > On Wed, Sep 28, 2022, at 2:15 PM, Michael Ellerman wrote: > >> But I think it makes more sense to do the same as mmap2() and pass the >> 4K offset through, and pass shift = PAGE_SHIFT - 12. I also borrowed the >> "off_4k&quo

Re: [PATCH] powerpc: update config files

2022-09-30 Thread Michael Ellerman
Lukas Bulwahn writes: > On Fri, Sep 30, 2022 at 9:42 AM Michael Ellerman wrote: >> >> Lukas Bulwahn writes: >> > Clean up config files by: >> > - removing configs that were deleted in the past >> > - removing configs not in tree and without re

Re: [PATCH] powerpc/pseries/vas: Pass hw_cpu_id to node associativity HCALL

2022-09-30 Thread Michael Ellerman
Michal Suchánek writes: > On Thu, Sep 29, 2022 at 05:16:40PM -0500, Nathan Lynch wrote: >> Haren Myneni writes: >> > Generally the hypervisor decides to allocate a window on different >> > VAS instances. But if the user space wishes to allocate on the >> > current VAS instance where the process

[PATCH v3 6/6] powerpc/pseries: Add firmware details to the hardware description

2022-09-30 Thread Michael Ellerman
re running under PowerVM. Failing that look for "ibm,fw-net-version" which is seen on PowerVM going back to at least Power6. eg: Hardware name: ... of:IBM,FW860.42 (SV860_138) hv:phyp Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/pseries/setup.c | 30 ++

[PATCH v3 5/6] powerpc/powernv: Add opal details to the hardware description

2022-09-30 Thread Michael Ellerman
Add OPAL version details to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: ... opal:v6.2 Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/powernv/setup.c | 22 ++ 1 file changed, 22 insertions(+) v3: Drop quotes

[PATCH v3 2/6] powerpc: Add PVR & CPU name to hardware description

2022-09-30 Thread Michael Ellerman
Add the PVR and CPU name to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: ... POWER8E (raw) 0x4b0201 Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 4 1 file changed, 4 insertions(+) v3: Drop "cpu:" and &

[PATCH v3 1/6] powerpc: Add hardware description string

2022-09-30 Thread Michael Ellerman
ed by qemu) POWER9 (raw) 0x4e1200 0xf05 of:SLOF,git-5b4c5a pSeries printk: bootconsole [udbg0] enabled Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/setup.h | 2 ++ arch/powerpc/kernel/setup-common.c | 19 ++- 2 files changed, 20 insertions(+), 1 deletion(-)

[PATCH v3 3/6] powerpc/64: Add logical PVR to the hardware description

2022-09-30 Thread Michael Ellerman
If we detect a logical PVR add that to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: ... 0xf04 Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) v3: Drop "lpvr:

[PATCH v3 4/6] powerpc: Add device-tree model to the hardware description

2022-09-30 Thread Michael Ellerman
Add the model of the machine we're on to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: IBM,8247-22L Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 19 +++ 1 file changed, 19 insertions(+) v3: Drop "model:

Re: [PATCH] powerpc: update config files

2022-09-30 Thread Michael Ellerman
Lukas Bulwahn writes: > Clean up config files by: > - removing configs that were deleted in the past > - removing configs not in tree and without recently pending patches > - adding new configs that are replacements for old configs in the file > > For some detailed information, see Link. >

Re: [PATCH -next] powerpc/mpic_msgr: fix cast removes address space of expression warnings

2022-09-30 Thread Michael Ellerman
Christophe Leroy writes: > Le 01/09/2022 à 10:54, ruanjinjie a écrit : >> [Vous ne recevez pas souvent de courriers de ruanjin...@huawei.com. >> Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> When build Linux kernel, encounter the following

Re: [PATCH 6/6] powerpc/pseries: Add firmware details to dump stack arch description

2022-09-29 Thread Michael Ellerman
Nathan Lynch writes: > Michael Ellerman writes: > >> Add firmware version details to the dump stack arch description, which >> is printed in case of an oops. >> >> Currently /hypervisor only exists on KVM, so if we don't find that >> look for something t

Re: [PATCH v2 1/6] powerpc: Add hardware description string

2022-09-29 Thread Michael Ellerman
Nathan Lynch writes: > Michael Ellerman writes: >> Create a hardware description string, which we will use to record >> various details of the hardware platform we are running on. >> >> Print the accumulated description at boot, and use it to set the generic >

Re: [PATCH v2 6/6] powerpc/pseries: Add firmware details to the hardware description

2022-09-29 Thread Michael Ellerman
Nathan Lynch writes: > Michael Ellerman writes: >> Add firmware version details to the hardware description, which is >> printed at boot and in case of an oops. >> >> Use /hypervisor if we find it, though currently it only exists if we're >> running under

Re: [Bug report] BUG: Kernel NULL pointer dereference at 0x00000069, filemap_release_folio+0x88/0xb0

2022-09-29 Thread Michael Ellerman
Matthew Wilcox writes: > On Tue, Sep 27, 2022 at 09:17:20AM +0800, Zorro Lang wrote: >> Hi mm and ppc list, >> >> Recently I started to hit a kernel panic [2] rarely on *ppc64le* with *1k >> blocksize* ext4. It's not easy to reproduce, but still has chance to trigger >> by loop running

[PATCH v2 6/6] powerpc/pseries: Add firmware details to the hardware description

2022-09-29 Thread Michael Ellerman
re running under PowerVM. Failing that look for "ibm,fw-net-version" which is seen on PowerVM going back to at least Power6. eg: Hardware name: ... of:'IBM,FW860.42 (SV860_138)' hv:'phyp' Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/pseries/setup.c | 30 ++

[PATCH v2 5/6] powerpc/powernv: Add opal details to the hardware description

2022-09-29 Thread Michael Ellerman
Add OPAL version details to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: ... opal:v6.2 Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/powernv/setup.c | 22 ++ 1 file changed, 22 insertions(+) v2: Use

[PATCH v2 4/6] powerpc: Add device-tree model to the hardware description

2022-09-29 Thread Michael Ellerman
Add the model of the machine we're on to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: model:'IBM,8247-22L' Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

[PATCH v2 3/6] powerpc/64: Add logical PVR to the hardware description

2022-09-29 Thread Michael Ellerman
If we detect a logical PVR add that to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: ... lpvr:0xf04 Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch

[PATCH v2 2/6] powerpc: Add PVR & CPU name to hardware description

2022-09-29 Thread Michael Ellerman
Add the PVR and CPU name to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: ... cpu:'POWER8E (raw)' pvr:0x4b0201 Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/powerpc

[PATCH v2 1/6] powerpc: Add hardware description string

2022-09-29 Thread Michael Ellerman
(emulated by qemu)' cpu:'POWER8 (raw)' pvr:0x4d0200 lpvr:0xf04 of:'SLOF,HEAD' machine:pSeries printk: bootconsole [udbg0] enabled Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/setup.h | 2 ++ arch/powerpc/kernel/setup-common.c | 19 ++- 2 files changed, 20

Re: [PATCH v2 1/6] powerpc: Add hardware description string

2022-09-29 Thread Michael Ellerman
Michael Ellerman writes: > Create a hardware description string, which we will use to record > various details of the hardware platform we are running on. > > Print the accumulated description at boot, and use it to set the generic > description which is printed in oopses. > &

[PATCH v2 5/6] powerpc/powernv: Add opal details to the hardware description

2022-09-29 Thread Michael Ellerman
Add OPAL version details to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: ... opal:v6.2 Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/powernv/setup.c | 22 ++ 1 file changed, 22 insertions(+) v2: Use

[PATCH v2 1/6] powerpc: Add hardware description string

2022-09-29 Thread Michael Ellerman
(emulated by qemu)' cpu:'POWER8 (raw)' pvr:0x4d0200 lpvr:0xf04 of:'SLOF,HEAD' machine:pSeries printk: bootconsole [udbg0] enabled Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/setup.h | 2 ++ arch/powerpc/kernel/setup-common.c | 19 ++- 2 files changed, 20

[PATCH v2 2/6] powerpc: Add PVR & CPU name to hardware description

2022-09-29 Thread Michael Ellerman
Add the PVR and CPU name to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: ... cpu:'POWER8E (raw)' pvr:0x4b0201 Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/powerpc

[PATCH v2 6/6] powerpc/pseries: Add firmware details to the hardware description

2022-09-29 Thread Michael Ellerman
re running under PowerVM. Failing that look for "ibm,fw-net-version" which is seen on PowerVM going back to at least Power6. eg: Hardware name: ... of:'IBM,FW860.42 (SV860_138)' hv:'phyp' Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/pseries/setup.c | 30 ++

[PATCH v2 3/6] powerpc/64: Add logical PVR to the hardware description

2022-09-29 Thread Michael Ellerman
If we detect a logical PVR add that to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: ... lpvr:0xf04 Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch

[PATCH v2 4/6] powerpc: Add device-tree model to the hardware description

2022-09-29 Thread Michael Ellerman
Add the model of the machine we're on to the hardware description, which is printed at boot and in case of an oops. eg: Hardware name: model:'IBM,8247-22L' Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 19 +++ 1 file changed, 19 insertions(+) diff --git

Re: [PATCH V2 2/3] tools/perf/tests: Fix branch stack sampling test to include sanity check for branch filter

2022-09-28 Thread Michael Ellerman
Arnaldo Carvalho de Melo writes: > Em Wed, Sep 21, 2022 at 08:22:54PM +0530, Athira Rajeev escreveu: >> commit b55878c90ab9 ("perf test: Add test for branch stack sampling") >> added test for branch stack sampling. There is a sanity check in the >> beginning to skip the test if the hardware

[PATCH] powerpc/configs: Enable PPC_UV in powernv_defconfig

2022-09-28 Thread Michael Ellerman
Make sure the ultravisor code at least gets some build testing by enabling it in powernv_defconfig. Signed-off-by: Michael Ellerman --- arch/powerpc/configs/powernv_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/powerpc/configs/powernv_defconfig b/arch/powerpc/configs

Re: [PATCH 1/7] mm/memory.c: Fix race when faulting a device private page

2022-09-28 Thread Michael Ellerman
Alistair Popple writes: > Michael Ellerman writes: >> Alistair Popple writes: >>> When the CPU tries to access a device private page the migrate_to_ram() >>> callback associated with the pgmap for the page is called. However no >>> reference is taken on the f

Re: [PATCH 1/7] mm/memory.c: Fix race when faulting a device private page

2022-09-28 Thread Michael Ellerman
Alistair Popple writes: > When the CPU tries to access a device private page the migrate_to_ram() > callback associated with the pgmap for the page is called. However no > reference is taken on the faulting page. Therefore a concurrent > migration of the device private page can free the page and

[PATCH 6/6] powerpc/pseries: Add firmware details to dump stack arch description

2022-09-28 Thread Michael Ellerman
-version seems to be a full path so is too long to add to the description. eg: Hardware name: ... of:'IBM,FW860.42 (SV860_138)' hv:phyp Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/pseries/setup.c | 36 ++ 1 file changed, 36 insertions(+) diff --git a/arch

[PATCH 2/6] powerpc: Add PVR & CPU name to dump stack arch description

2022-09-28 Thread Michael Ellerman
Add the PVR and CPU name to the dump stack arch description, which is printed in case of an oops. eg: Hardware name: ... POWER8E (raw) pvr:0x4b0201 Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/powerpc/kernel/prom.c

[PATCH 5/6] powerpc/powernv: Add opal details to dump stack arch description

2022-09-28 Thread Michael Ellerman
Add OPAL version details to the dump stack arch description, which is printed in case of an oops. eg: Hardware name: ... opal:v6.2 Signed-off-by: Michael Ellerman --- arch/powerpc/platforms/powernv/setup.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/arch

[PATCH 1/6] powerpc: Add ppc_md.name to dump stack arch description

2022-09-28 Thread Michael Ellerman
As soon as we know the name of the machine description we're using, add it to the dump stack arch description, which is printed in case of an oops. eg: Hardware name: ... machine:pSeries Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/setup.h | 2 ++ arch/powerpc/kernel/setup

[PATCH 4/6] powerpc: Add device-tree model to dump stack arch description

2022-09-28 Thread Michael Ellerman
Add the model of the machine we're on to the dump stack arch description, which is printed in case of an oops. eg: Hardware name: model:'IBM,8247-22L' Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/arch

[PATCH 3/6] powerpc/64: Add logical PVR to the dump stack arch description

2022-09-28 Thread Michael Ellerman
If we detect a logical PVR add that to the dump stack arch description, which is printed in case of an oops. eg: Hardware name: ... lpvr:0xf04 Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/prom.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/powerpc

[PATCH] powerpc: Drops STABS_DEBUG from linker scripts

2022-09-28 Thread Michael Ellerman
No toolchain we support should be generating stabs debug information anymore. Drop the sections entirely from our linker scripts. We removed all the manual stabs annotations in commit 12318163737c ("powerpc/32: Remove remaining .stabs annotations"). Signed-off-by: Michael Ellerman

[PATCH] powerpc/64s: Remove lost/old comment

2022-09-28 Thread Michael Ellerman
The bulk of this was moved/reworded in: 57f266497d81 ("powerpc: Use gas sections for arranging exception vectors") And now appears around line 700 in arch/powerpc/kernel/exceptions-64s.S. Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/exceptions-64s.S | 10 -- 1 fi

[PATCH] powerpc/64s: Remove old STAB comment

2022-09-28 Thread Michael Ellerman
This used to be about the 0x4300 handler, but that was moved in commit da2bc4644c75 ("powerpc/64s: Add new exception vector macros"). Note that "STAB" here refers to "Segment Table" not the debug format. Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/

Re: [PATCH v6 13/25] powerpc: Remove direct call to mmap2 syscall handlers

2022-09-28 Thread Michael Ellerman
Rohan McLure writes: > Syscall handlers should not be invoked internally by their symbol names, > as these symbols defined by the architecture-defined SYSCALL_DEFINE > macro. Move the compatibility syscall definition for mmap2 to > syscalls.c, so that all mmap implementations can share a helper

Re: [PATCH v6 19/25] powerpc: Remove high-order word clearing on compat syscall entry

2022-09-28 Thread Michael Ellerman
Rohan McLure writes: > Remove explicit clearing of the high order-word of user parameters when > handling compatibility syscalls in system_call_exception. The > COMPAT_SYSCALL_DEFINEx macros handle this clearing through an > explicit cast to the signature type of the target handler.

[PATCH 1/2] powerpc: Make stack frame marker upper case

2022-09-27 Thread Michael Ellerman
|| c4733eb0 || So make it upper case to make it stand out a bit more: c4733e70 53474552 |SGER| Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm

[PATCH 2/2] powerpc: Reverse stack frame marker on little endian

2022-09-27 Thread Michael Ellerman
.| Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/ptrace.h | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/powerpc/include/asm/ptrace.h b/arch/powerpc/include/asm/ptrace.h index 6c23d1d25dc7..2efec6d87049 100644 --- a/arch/powerpc/include/asm/ptrace.h +++ b/arch/power

Re: [PATCH] powerpc/fsl_msi: fix return error value in error handing path

2022-09-27 Thread Michael Ellerman
cgel@gmail.com writes: > From: Lv Ruyi > > This function fsl_msi_setup_hwirq() seems to return zero on success and > non-zero on failure, but it returns zero in error handing path. I agree it seems wrong, but I can't be sure the current code is wrong, so unless you're able to test this on

Re: [PATCH v2 1/5] powerpc/64: use 32-bit immediate for STACK_FRAME_REGS_MARKER

2022-09-27 Thread Michael Ellerman
Christophe Leroy writes: > Le 26/09/2022 à 05:40, Nicholas Piggin a écrit : >> Using a 32-bit constant for this marker allows it to be loaded with >> two ALU instructions, like 32-bit. This avoids a TOC entry and a >> TOC load that depends on the r2 value that has just been loaded from >> the

Re: [PATCH v2] powerpc: Ignore DSI error caused by the copy/paste instruction

2022-09-26 Thread Michael Ellerman
Haren Myneni writes: > DSI error will be generated when the paste operation is issued on > the suspended NX window due to NX state changes. The hypervisor Please spell out DSI and NX on the first usage. > expects the partition to ignore this error during page pault > handling. To differentiate

Re: Is PPC 44x PIKA Warp board still relevant?

2022-09-26 Thread Michael Ellerman
Christophe Leroy writes: > Hi Dmitry > > Le 25/09/2022 à 07:06, Dmitry Torokhov a écrit : >> Hi Michael, Nick, >> >> I was wondering if PIKA Warp board still relevant. The reason for my >> question is that I am interested in dropping legacy gpio APIs, >> especially OF-specific ones, in favor of

Re: [PATCH] powerpc/pasemi: Use of_root in pas_pci_init()

2022-09-23 Thread Michael Ellerman
On Tue, 6 Sep 2022 11:03:13 +1000, Michael Ellerman wrote: > Currently in pas_pci_init() a reference to the root node is leaked due > to a missing of_node_put(). Instead just use of_root directly. > > Note that converting to of_find_compatible_node(NULL, ...) would > not be enti

Re: [PATCH -next] powerpc/powernv: add missing of_node_put() in opal_export_attrs()

2022-09-23 Thread Michael Ellerman
On Tue, 6 Sep 2022 14:17:03 +, Zheng Yongjun wrote: > After using 'np' returned by of_find_node_by_path(), of_node_put() > need be called to decrease the refcount. > > Applied to powerpc/next. [1/1] powerpc/powernv: add missing of_node_put() in opal_export_attrs()

Re: [PATCH v2] powerpc/64s: add pte_needs_flush and huge_pmd_needs_flush

2022-09-23 Thread Michael Ellerman
On Thu, 1 Sep 2022 21:03:34 +1000, Nicholas Piggin wrote: > Allow PTE changes to avoid flushing the TLB when access permissions are > being relaxed, the dirty bit is being set, and the accessed bit is being > changed. > > Relaxing access permissions and setting dirty and accessed bits do not >

Re: [PATCH][next] powerpc: Fix fall-through warning for Clang

2022-09-23 Thread Michael Ellerman
On Tue, 6 Sep 2022 22:32:13 +0100, Gustavo A. R. Silva wrote: > Fix the following fallthrough warning: > > arch/powerpc/platforms/85xx/mpc85xx_cds.c:161:3: warning: unannotated > fall-through between switch labels [-Wimplicit-fallthrough] > > Applied to powerpc/next. [1/1] powerpc: Fix

Re: [PATCH] Revert "powerpc/rtas: Implement reentrant rtas call"

2022-09-23 Thread Michael Ellerman
On Wed, 7 Sep 2022 17:01:11 -0500, Nathan Lynch wrote: > At the time this was submitted by Leonardo, I confirmed -- or thought > I had confirmed -- with PowerVM partition firmware development that > the following RTAS functions: > > - ibm,get-xive > - ibm,int-off > - ibm,int-on > - ibm,set-xive >

Re: [PATCH 0/9] Remove unused declarations for powerpc

2022-09-23 Thread Michael Ellerman
On Tue, 13 Sep 2022 15:50:20 +0800, Gaosheng Cui wrote: > This series contains a few cleanup patches, to remove unused > declarations which have been removed. Thanks! > > Gaosheng Cui (9): > powerpc/xmon: remove unused ppc_parse_cpu() declaration > powerpc/spufs: remove orphan declarations

Re: [RFC PATCH 1/7] powerpc: use 16-bit immediate for STACK_FRAME_REGS_MARKER

2022-09-23 Thread Michael Ellerman
Christophe Leroy writes: > Le 19/09/2022 à 16:01, Nicholas Piggin a écrit : >> Using a 16-bit constant for this marker allows it to be loaded with >> a single 'li' instruction. On 64-bit this avoids a TOC entry and a >> TOC load that depends on the r2 value that has just been loaded from >> the

Re: [PATCH 2/2] powerpc/rtas: block error injection when locked down

2022-09-23 Thread Michael Ellerman
Paul Moore writes: > On Thu, Sep 22, 2022 at 3:38 PM Nathan Lynch wrote: >> >> The error injection facility on pseries VMs allows corruption of >> arbitrary guest memory, potentially enabling a sufficiently privileged >> user to disable lockdown or perform other modifications of the running >>

Re: [PATCH 1/2] powerpc/pseries: block untrusted device tree changes when locked down

2022-09-23 Thread Michael Ellerman
Paul Moore writes: > On Thu, Sep 22, 2022 at 3:38 PM Nathan Lynch wrote: >> >> The /proc/powerpc/ofdt interface allows the root user to freely alter >> the in-kernel device tree, enabling arbitrary physical address writes >> via drivers that could bind to malicious device nodes, thus making it

Re: [PATCH v5 27/30] RFC: KVM: powerpc: Move processor compatibility check to hardware setup

2022-09-23 Thread Michael Ellerman
int kvm_arch_check_processor_compat(void) > { > - return kvmppc_core_check_processor_compat(); > + return 0; > } The actual change seems OK. I gave it a quick test boot and ran some VMs, everything seems to work as before. Acked-by: Michael Ellerman (powerpc) cheers

Re: [PATCH v1 2/3] powerpc/prom_init: drop PROM_BUG()

2022-09-21 Thread Michael Ellerman
David Hildenbrand writes: > Unused, let's drop it. > > Signed-off-by: David Hildenbrand > --- > arch/powerpc/kernel/prom_init.c | 6 -- > 1 file changed, 6 deletions(-) Thanks. I'll take this one via the powerpc tree, and the others can go via wherever? cheers > diff --git

Re: [PATCH] powerpc: Save AMR/IAMR when switching tasks

2022-09-21 Thread Michael Ellerman
Christophe Leroy writes: > Le 19/09/2022 à 14:37, Michael Ellerman a écrit : >> Christophe Leroy writes: >>> Le 16/09/2022 à 07:05, Samuel Holland a écrit : >>>> With CONFIG_PREEMPT=y (involuntary preemption enabled), it is possible >>>> to switch a

Re: [PATCH v2 1/4] powerpc/64s: Add DEBUG_PAGEALLOC for radix

2022-09-20 Thread Michael Ellerman
Nicholas Miehlbradt writes: > There is support for DEBUG_PAGEALLOC on hash but not on radix. > Add support on radix. > > Signed-off-by: Nicholas Miehlbradt > --- > v2: Revert change to radix_memory_block_size, instead set the size > in radix_init_pgtable and radix__create_section_mapping

[PATCH] powerpc/64: Remove unused prom_init_toc symbols

2022-09-20 Thread Michael Ellerman
om_init require RELOCATABLE") Reported-by: Christophe Leroy Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/sections.h| 3 --- arch/powerpc/kernel/prom_init_check.sh | 3 +-- arch/powerpc/kernel/vmlinux.lds.S | 5 - 3 files changed, 1 insertion(+), 10 deletions(-) diff

Re: [PATCH] Revert "powerpc/rtas: Implement reentrant rtas call"

2022-09-19 Thread Michael Ellerman
Nathan Lynch writes: > Nathan Lynch writes: >> "Nicholas Piggin" writes: >>> On Wed Sep 14, 2022 at 3:39 AM AEST, Leonardo Brás wrote: On Mon, 2022-09-12 at 14:58 -0500, Nathan Lynch wrote: > Leonardo Brás writes: > > On Fri, 2022-09-09 at 09:04 -0500, Nathan Lynch wrote: >

RE: [PATCH] powerpc/83xx: update kmeter1 defconfig and dts

2022-09-19 Thread Michael Ellerman
Holger Brunck writes: >> > Le 16/12/2019 à 10:50, Holger Brunck a écrit : >> >> From: Matteo Ghidoni >> >> >> >> The defconfig is synchronized and the missing MTD_PHYSMAP, >> DEVTMPFS >> >> and I2C MUX support are switched on. >> >> >> >> Additionally the I2C mux device is added to the DTS with

Re: [PATCH] powerpc: Save AMR/IAMR when switching tasks

2022-09-19 Thread Michael Ellerman
Christophe Leroy writes: > Le 16/09/2022 à 07:05, Samuel Holland a écrit : >> With CONFIG_PREEMPT=y (involuntary preemption enabled), it is possible >> to switch away from a task inside copy_{from,to}_user. This left the CPU >> with userspace access enabled until after the next IRQ or privilege

Re: [PATCH 1/4] powerpc/64s: Add DEBUG_PAGEALLOC for radix

2022-09-19 Thread Michael Ellerman
Nicholas Miehlbradt writes: > There is support for DEBUG_PAGEALLOC on hash but not on radix. > Add support on radix. > > Signed-off-by: Nicholas Miehlbradt > --- > arch/powerpc/mm/book3s64/radix_pgtable.c | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git

Re: [PATCH v2 3/7] powerpc/build: move got, toc, plt, branch_lt sections to read-only

2022-09-18 Thread Michael Ellerman
kernel test robot writes: > Hi Nicholas, > > I love your patch! Yet something to improve: > > [auto build test ERROR on powerpc/next] > [also build test ERROR on linus/master v6.0-rc5 next-20220916] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting

[PATCH] powerpc/microwatt: Remove unused early debug code

2022-09-18 Thread Michael Ellerman
ally under the non-existent CONFIG_PPC_EARLY_DEBUG_MICROWATT. Drop the unused code. 1: https://lore.kernel.org/linuxppc-dev/20200509050340.gd1464...@thinks.paulus.ozlabs.org/ Fixes: 48b545b8018d ("powerpc/microwatt: Use standard 16550 UART for console") Reported-by: Lukas Bulwahn Si

Re: [PATCH 1/2] powerpc/vmlinux.lds: Ensure STRICT_ALIGN_SIZE is at least page aligned

2022-09-17 Thread Michael Ellerman
Christophe Leroy writes: > Le 16/09/2022 à 15:14, Michael Ellerman a écrit : >> Add a check that STRICT_ALIGN_SIZE is aligned to at least PAGE_SIZE. > > This cannot happen, the definitions in arch/powerpc/Kconfig don't allow > that. It can't happen yet :) There's e

Re: [PATCH v2 6/7] powerpc/64/build: merge .got and .toc input sections

2022-09-17 Thread Michael Ellerman
Christophe Leroy writes: > Le 16/09/2022 à 06:07, Nicholas Piggin a écrit : >> Follow the binutils ld internal linker script and merge .got and .toc >> input sections in the .got output section. >> >> Signed-off-by: Nicholas Piggin >> --- >> arch/powerpc/kernel/vmlinux.lds.S | 3 +-- >> 1

Re: [PATCH] macintosh/ams: Adapt declaration of ams_i2c_remove() to earlier change

2022-09-17 Thread Michael Ellerman
if I put it on top of my for-next branch. Yeah please do. An ack if you need it: Acked-by: Michael Ellerman (powerpc) cheers

[PATCH] powerpc: Always select HAVE_EFFICIENT_UNALIGNED_ACCESS

2022-09-16 Thread Michael Ellerman
ill have a Power7/LE machine it should hopefully continue to boot, just with some performance penality, and if not they can report a bug. Signed-off-by: Michael Ellerman --- arch/powerpc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/Kconfig b/arch/p

[PATCH 1/2] powerpc/vmlinux.lds: Ensure STRICT_ALIGN_SIZE is at least page aligned

2022-09-16 Thread Michael Ellerman
Add a check that STRICT_ALIGN_SIZE is aligned to at least PAGE_SIZE. That then makes the alignment to PAGE_SIZE immediately after the alignment to STRICT_ALIGN_SIZE redundant, so remove it. Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/vmlinux.lds.S | 5 - 1 file changed, 4

[PATCH 2/2] powerpc/vmlinux.lds: Add an explicit symbol for the SRWX boundary

2022-09-16 Thread Michael Ellerman
that __init_begin must also begin there. Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/sections.h | 1 + arch/powerpc/kernel/vmlinux.lds.S| 9 +++-- arch/powerpc/mm/book3s32/mmu.c | 2 +- arch/powerpc/mm/book3s64/radix_pgtable.c | 4 ++-- 4 files changed, 11

Re: [PATCH 2/7] powerpc: move __end_rodata to cover arch read-only sections

2022-09-16 Thread Michael Ellerman
"Nicholas Piggin" writes: > On Thu Sep 15, 2022 at 10:47 PM AEST, Michael Ellerman wrote: >> Nicholas Piggin writes: >> > powerpc has a number of read-only sections and tables that are put >> > after RO_DATA(). Move the __end_rodata symbol to cover these as w

Re: [PATCH 1/7] powerpc/build: put sys_call_table in .data.rel.ro if RELOCATABLE

2022-09-15 Thread Michael Ellerman
Christophe Leroy writes: > Le 14/09/2022 à 17:47, Nicholas Piggin a écrit : >> Const function pointers live in .data.rel.ro rather than .rodata because >> they must be relocated. This change prevents powerpc/32 from generating >> R_PPC_UADDR32 relocations (which are not handled). The

Re: [PATCH 2/7] powerpc: move __end_rodata to cover arch read-only sections

2022-09-15 Thread Michael Ellerman
Nicholas Piggin writes: > powerpc has a number of read-only sections and tables that are put > after RO_DATA(). Move the __end_rodata symbol to cover these as well. > > Setting memory to read-only at boot is done using __init_begin, > change that that to use __end_rodata. Did you just do that

[PATCH] powerpc/64: Remove unused SYS_CALL_TABLE symbol

2022-09-13 Thread Michael Ellerman
logic in C") Signed-off-by: Michael Ellerman --- arch/powerpc/kernel/interrupt_64.S | 10 -- 1 file changed, 10 deletions(-) diff --git a/arch/powerpc/kernel/interrupt_64.S b/arch/powerpc/kernel/interrupt_64.S index f9ee93e3a0d3..0093a6b6b1e1 100644 --- a/arch/powerpc/kernel/inte

Re: [PATCH v4 09/20] powerpc: Enable compile-time check for syscall handlers

2022-09-12 Thread Michael Ellerman
"Nicholas Piggin" writes: > On Wed Aug 24, 2022 at 12:05 PM AEST, Rohan McLure wrote: ... >> diff --git a/arch/powerpc/kernel/systbl.S b/arch/powerpc/kernel/systbl.c >> similarity index 59% >> rename from arch/powerpc/kernel/systbl.S >> rename to arch/powerpc/kernel/systbl.c >> index

Re: [PATCH v1 02/19] powerpc/64e: Tie PPC_BOOK3E_64 to PPC_E500MC

2022-09-09 Thread Michael Ellerman
Christophe Leroy writes: > Le 09/09/2022 à 07:50, Michael Ellerman a écrit : >> Hi Christophe, >> >> Thanks for trying to clean up this tangled mess. >> >> Christophe Leroy writes: >>> The only 64-bit Book3E CPUs we support is the e500mc. >>

[GIT PULL] Please pull powerpc/linux.git powerpc-6.0-5 tag

2022-09-09 Thread Michael Ellerman
. - -- Michael Ellerman (1): powerpc/pseries: Fix plpks crash on non-pseries arch/powerpc/platforms/pseries/plpks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -BEGIN PGP SIGNATURE- iQIzBAEBCAAdFiEEJFGtCPCthwEv2Y/bUevqPMjhpYAFAmMbMlsACgkQUevqPMjh pYDiuQ

Re: [PATCH] powerpc/xive: fix repeated words in comments

2022-09-09 Thread Michael Ellerman
On Wed, 31 Aug 2022 08:47:06 +0800, Jilin Yuan wrote: > Delete the redundant word 'set'. > > Applied to powerpc/next. [1/1] powerpc/xive: fix repeated words in comments https://git.kernel.org/powerpc/c/9b135eef0787813ad073aaeb9ff80ab57bc63e69 cheers

Re: [PATCH] powerpc/vas: fix repeated words in comments

2022-09-09 Thread Michael Ellerman
On Wed, 31 Aug 2022 08:49:14 +0800, Jilin Yuan wrote: > Delete the redundant word 'the'. > > Applied to powerpc/next. [1/1] powerpc/vas: fix repeated words in comments https://git.kernel.org/powerpc/c/0d4bb5e45aa698f2f357b1424b842bebe13b1c8b cheers

Re: [PATCH v2] powerpc: embedded6xx: Fix refcount leak bugs

2022-09-09 Thread Michael Ellerman
On Sat, 18 Jun 2022 12:10:42 +0800, Liang He wrote: > In xx_init_xx(), of_find_node_by_type() will return a node pointer > with refcount incremented. We should use of_node_put() when it is > not used anymore. > > Applied to powerpc/next. [1/1] powerpc: embedded6xx: Fix refcount leak bugs

Re: [PATCH] powerpc/mobility: fix repeated words in comments

2022-09-09 Thread Michael Ellerman
On Wed, 31 Aug 2022 08:51:09 +0800, Jilin Yuan wrote: > Delete the redundant word 'the'. > > Applied to powerpc/next. [1/1] powerpc/mobility: fix repeated words in comments https://git.kernel.org/powerpc/c/4c73cadcdc64b53248bca85baa8a19e7384701ec cheers

Re: [PATCH] powerpc: sysdev: fsl_msi: Add missing of_node_put() for of_parse_phandle()

2022-09-09 Thread Michael Ellerman
On Mon, 4 Jul 2022 22:52:33 +0800, Liang He wrote: > In fsl_setup_msi_irqs(), we should use of_node_put() for the > refernece 'np' returned by of_parse_phandle() which increases > the refcount. > > Applied to powerpc/next. [1/1] powerpc: sysdev: fsl_msi: Add missing of_node_put() for

Re: [PATCH v5] powerpc:85xx: Add missing of_node_put() in sgy_cst1000

2022-09-09 Thread Michael Ellerman
On Fri, 17 Jun 2022 18:50:11 +0800, Liang He wrote: > In gpio_halt_probe(), of_find_matching_node() will return a node > pointer with refcount incremented. We should use of_node_put() in > fail path or when it is not used anymore. > > Applied to powerpc/next. [1/1] powerpc:85xx: Add missing

Re: [PATCH v3] powerpc/powernv: Fix refcount leak bugs

2022-09-09 Thread Michael Ellerman
On Mon, 20 Jun 2022 21:25:53 +0800, Liang He wrote: > In these driver init functions, there are two kinds of errors: > > (1) missing of_put_node() for of_find_compatible_node()'s returned > pointer (refcount incremented) in fail path or when it is not > used anymore. > (2) missing

Re: [PATCH v2] powerpc/sysdev: Fix refcount leak bugs

2022-09-09 Thread Michael Ellerman
On Mon, 20 Jun 2022 21:02:21 +0800, Liang He wrote: > We need add corresponding of_node_put() to keep refcount balance > in sysdev. > > Applied to powerpc/next. [1/1] powerpc/sysdev: Fix refcount leak bugs https://git.kernel.org/powerpc/c/3d31adc47edb6d0cef122a41fba1b639db5d1c37 cheers

<    11   12   13   14   15   16   17   18   19   20   >