[PATCH v10 0/2] Add freescale S/PDIF CPU DAI and machine drivers

2013-08-20 Thread Nicolin Chen
iver calculate the clock div. * Added one optional clock source for spdif tx. * Reivsed documentation accordingly. Nicolin Chen (2): ASoC: fsl: Add S/PDIF CPU DAI driver ASoC: fsl: Add S/PDIF machine driver .../devicetree/bindings/sound/fsl,spdif.txt| 54 + .../devicetree/bi

Re: [PATCH v10 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-22 Thread Nicolin Chen
Hi Stephen, On Wed, Aug 21, 2013 at 12:30:59PM -0600, Stephen Warren wrote: > I still don't think those two properties are correct. > > Exactly what node will those phandles point at? > > There definitely should not be a DT node for any "dummy CODEC", > irrespective of whether this binding calls

[PATCH v11] ASoC: fsl: Add S/PDIF machine driver

2013-08-23 Thread Nicolin Chen
This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen --- Changelog v10->v11: * Use boolean properties for spdif-out/in switch instead of codec phand

Re: [alsa-devel] [PATCH v11] ASoC: fsl: Add S/PDIF machine driver

2013-08-26 Thread Nicolin Chen
On Fri, Aug 23, 2013 at 08:13:53PM +0100, Mark Brown wrote: > On Fri, Aug 23, 2013 at 01:08:28PM -0600, Stephen Warren wrote: > > On 08/23/2013 02:04 AM, Nicolin Chen wrote: > > > This patch implements a device-tree-only machine driver for Freescale > > > i.M

[PATCH v12] ASoC: fsl: Add S/PDIF machine driver

2013-08-27 Thread Nicolin Chen
This patch implements a device-tree-only machine driver for Freescale i.MX series Soc. It works with spdif_transmitter/spdif_receiver and fsl_spdif.c drivers. Signed-off-by: Nicolin Chen --- Changelog v11->v12: * Dropped unused spdif_pdev. * Register spdif-dit/dir depending on DT bool prope

[PATCH 1/2] ASoC: fsl: Add wrapping for dev_dbg() in fsl_spdif.c

2013-08-30 Thread Nicolin Chen
Add wrapping '\n' for dev_dbg() in fsl_spdif.c Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_spdif.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_spdif.c b/sound/soc/fsl/fsl_spdif.c index e93dc0d..98741e9 100644 --- a/sou

Re: [PATCHv1 5/8] ASoC: sgtl5000: Revise the bugs about the sgt15000 codec.

2013-10-17 Thread Nicolin Chen
), > sgtl5000->supplies); > + Ditto > ldo_regulator_remove(codec); > > return ret; > @@ -1461,6 +1471,7 @@ static int sgtl5000_remove(struct snd_soc_codec *codec) > sgtl5000->supplies); > regul

Re: [PATCHv1 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-10-28 Thread Nicolin Chen
to the -next tree ? > Or could you tell me how to find the patch please? > Are you using broonie's repository? git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git If you searched the title in for-next branch, you should have found it. Best regards, Nicolin Chen

[PATCH] ASoC: fsl_ssi: separately enable and disable TIE/RIE in trigger()

2013-10-29 Thread Nicolin Chen
This patch enables Tx-related SIER_FLAGS only when direction is PLAYBACK and does same thing for CAPTURE. Also, after TRIGGER_STOP/PAUSE, it will disable SIER_xFLAGS for symmetric. [ Passed compile-test with mpc85xx_defconfig ] Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 21

Re: [PATCH] ASoC: fsl_ssi: separately enable and disable TIE/RIE in trigger()

2013-10-29 Thread Nicolin Chen
On Tue, Oct 29, 2013 at 06:59:44AM -0500, Timur Tabi wrote: > Nicolin Chen wrote: > >This patch enables Tx-related SIER_FLAGS only when direction is PLAYBACK > >and does same thing for CAPTURE. Also, after TRIGGER_STOP/PAUSE, it will > >disable SIER_xFLAGS for symmetric. &g

Re: [PATCH] ASoC: fsl_ssi: separately enable and disable TIE/RIE in trigger()

2013-10-29 Thread Nicolin Chen
On Tue, Oct 29, 2013 at 07:18:21AM -0500, Timur Tabi wrote: > Nicolin Chen wrote: > >Well, actually I just wanted to clear T/RDMAE to disable DMA request, > >but it seems to be much easier to do it like this based on current > >code and disabling unused interrupts s

[PATCH 0/3] Add dual-fifo mode support of i.MX ssi

2013-10-29 Thread Nicolin Chen
direct dependency between them. When * ! applying them, we need to apply in one single branch. Otherwise, * ! it would break currect branches. Nicolin Chen (3): dma: imx-sdma: Add ssi dual fifo script support ASoC: fsl_ssi: Add dual fifo mode support ARM: dts: imx: use dual-fifo sdma script

[PATCH 1/3] dma: imx-sdma: Add ssi dual fifo script support

2013-10-29 Thread Nicolin Chen
There's a script for SSI missing in current sdma script list. Thus add it. This script would allow SSI use its dual fifo mode to transimit/receive data without occasional hardware underrun/overrun. This patch also fixed a counting error for total number of scripts. Signed-off-by: Nicolin

[PATCH 2/3] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-29 Thread Nicolin Chen
By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. [ Passed compile-test with mpc85xx_defconfig ] Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 24 +++- 1 file changed

[PATCH 3/3] ARM: dts: imx: use dual-fifo sdma script for ssi

2013-10-29 Thread Nicolin Chen
Use dual-fifo sdma scripts instead of shared scripts for ssi on i.MX series. Signed-off-by: Nicolin Chen --- arch/arm/boot/dts/imx51.dtsi | 4 ++-- arch/arm/boot/dts/imx53.dtsi | 4 ++-- arch/arm/boot/dts/imx6qdl.dtsi | 12 ++-- arch/arm/boot/dts/imx6sl.dtsi | 12 ++-- 4

Re: [PATCH 1/3] dma: imx-sdma: Add ssi dual fifo script support

2013-10-29 Thread Nicolin Chen
a short note. > > Please add a version check to the driver as necessary and provide a proper > firmware. > Just currently it's not easy for me to create a new proper firmware, and I's been told that besides this version number, it also lacks a decent license info. So may I

[b42...@freescale.com: Re: [PATCH 1/3] dma: imx-sdma: Add ssi dual fifo script support]

2013-10-30 Thread Nicolin Chen
Just found that I missed Sascha's mail address in my TO list of last reply. So resend it. And sorry for the duplicated mails. - Forwarded message from Nicolin Chen - Date: Wed, 30 Oct 2013 12:48:48 +0800 From: Nicolin Chen Subject: Re: [PATCH 1/3] dma: imx-sdma: Add ssi dual

[PATCH v2 0/4] Add dual-fifo mode support of i.MX ssi

2013-10-30 Thread Nicolin Chen
. * * ! This series of patches has a direct dependency between them. When * ! applying them, we need to apply in one single branch. Otherwise, * ! it would break currect branches. Nicolin Chen (4): dma: imx-sdma: Add sdma firmware version 2 support dma: imx-sdma: Add new dma type for ssi dual fifo

[PATCH v2 1/4] dma: imx-sdma: Add sdma firmware version 2 support

2013-10-30 Thread Nicolin Chen
On i.MX5/6 series, SDMA is using new version firmware to support SSI dual FIFO feature and HDMI Audio (i.MX6Q/DL only). Thus add it. Signed-off-by: Nicolin Chen --- drivers/dma/imx-sdma.c | 15 ++- include/linux/platform_data/dma-imx-sdma.h | 3 +++ 2 files

[PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-30 Thread Nicolin Chen
By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. [ Passed compile-test with mpc85xx_defconfig ] Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 24 +++- 1 file changed

[PATCH v2 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script

2013-10-30 Thread Nicolin Chen
This patch adds a new DMA_TYPE for SSI dual FIFO script, included in SDMA firmware version 2. This script would allow SSI use dual fifo mode to transimit/receive data without occasional hardware underrun/overrun. Signed-off-by: Nicolin Chen --- Documentation/devicetree/bindings/dma/fsl-imx

[PATCH v2 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi

2013-10-30 Thread Nicolin Chen
Use dual-fifo sdma scripts instead of shared scripts for ssi on i.MX series. Signed-off-by: Nicolin Chen --- arch/arm/boot/dts/imx51.dtsi | 4 ++-- arch/arm/boot/dts/imx53.dtsi | 4 ++-- arch/arm/boot/dts/imx6qdl.dtsi | 12 ++-- arch/arm/boot/dts/imx6sl.dtsi | 12 ++-- 4

Re: [PATCH v2 3/4] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-31 Thread Nicolin Chen
.maxburst *= 2; > > > > Why not using a mask here ? > ssi_private->dma_params_tx.maxburst &= ~0x1; > ssi_private->dma_params_rx.maxburst &= ~0x1; I'll use this in v3. Thank you! Nicolin Chen > > Regards, > > Philippe > >

[PATCH v3 0/4] Add dual-fifo mode support of i.MX ssi

2013-10-31 Thread Nicolin Chen
. Otherwise, * ! it would break currect branches. Nicolin Chen (4): dma: imx-sdma: Add sdma firmware version 2 support dma: imx-sdma: Add new dma type for ssi dual fifo script ASoC: fsl_ssi: Add dual fifo mode support ARM: dts: imx: use dual-fifo sdma script for ssi .../devicetree

[PATCH v3 1/4] dma: imx-sdma: Add sdma firmware version 2 support

2013-10-31 Thread Nicolin Chen
On i.MX5/6 series, SDMA is using new version firmware to support SSI dual FIFO feature and HDMI Audio (i.MX6Q/DL only). Thus add it. Signed-off-by: Nicolin Chen --- drivers/dma/imx-sdma.c | 15 ++- include/linux/platform_data/dma-imx-sdma.h | 5 + 2 files

[PATCH v3 3/4] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-31 Thread Nicolin Chen
By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. [ Passed compile-test with mpc85xx_defconfig ] Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 22 +- 1 file changed

[PATCH v3 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script

2013-10-31 Thread Nicolin Chen
This patch adds a new DMA_TYPE for SSI dual FIFO script, included in SDMA firmware version 2. This script would allow SSI use dual fifo mode to transimit/receive data without occasional hardware underrun/overrun. Signed-off-by: Nicolin Chen --- Documentation/devicetree/bindings/dma/fsl-imx

[PATCH v3 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi

2013-10-31 Thread Nicolin Chen
Use dual-fifo sdma scripts instead of shared scripts for ssi on i.MX series. Signed-off-by: Nicolin Chen --- arch/arm/boot/dts/imx51.dtsi | 4 ++-- arch/arm/boot/dts/imx53.dtsi | 4 ++-- arch/arm/boot/dts/imx6qdl.dtsi | 12 ++-- arch/arm/boot/dts/imx6sl.dtsi | 12 ++-- 4

[PATCH v4 1/4] dma: imx-sdma: Add sdma firmware version 2 support

2013-10-31 Thread Nicolin Chen
On i.MX5/6 series, SDMA is using new version firmware to support SSI dual FIFO feature and HDMI Audio (i.MX6Q/DL only). Thus add it. Signed-off-by: Nicolin Chen --- drivers/dma/imx-sdma.c | 15 ++- include/linux/platform_data/dma-imx-sdma.h | 5 + 2 files

[PATCH v4 0/4] Add dual-fifo mode support of i.MX ssi

2013-10-31 Thread Nicolin Chen
patches has a direct dependency between them. When * ! applying them, we need to apply to one single branch. Otherwise, * ! it would break currect branches. Nicolin Chen (4): dma: imx-sdma: Add sdma firmware version 2 support dma: imx-sdma: Add new dma type for ssi dual fifo script ASoC: fsl_ssi

[PATCH v4 3/4] ASoC: fsl_ssi: Add dual fifo mode support

2013-10-31 Thread Nicolin Chen
By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. [ Passed compile-test with mpc85xx_defconfig ] Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 18 +- 1 file changed, 17

[PATCH v4 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script

2013-10-31 Thread Nicolin Chen
This patch adds a new DMA_TYPE for SSI dual FIFO script, included in SDMA firmware version 2. This script would allow SSI use dual fifo mode to transimit/receive data without occasional hardware underrun/overrun. Signed-off-by: Nicolin Chen --- Documentation/devicetree/bindings/dma/fsl-imx

[PATCH v4 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi

2013-10-31 Thread Nicolin Chen
Use dual-fifo sdma scripts instead of shared scripts for ssi on i.MX series. Signed-off-by: Nicolin Chen --- arch/arm/boot/dts/imx51.dtsi | 4 ++-- arch/arm/boot/dts/imx53.dtsi | 4 ++-- arch/arm/boot/dts/imx6qdl.dtsi | 12 ++-- arch/arm/boot/dts/imx6sl.dtsi | 12 ++-- 4

Re: [PATCHv2 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-11-01 Thread Nicolin Chen
se = devm_ioremap_resource(&pdev->dev, res); > + if (IS_ERR(sai->base)) > + return PTR_ERR(sai->base); > + > + sai->clk = devm_clk_get(&pdev->dev, "sai"); > + if (IS_ERR(sai->clk)) { > + dev_err(&pde

Re: [PATCH v4 0/4] Add dual-fifo mode support of i.MX ssi

2013-11-01 Thread Nicolin Chen
d. Thank Shawn for adding for me. Much obliged. > On Thu, Oct 31, 2013 at 09:44:12PM +0800, Nicolin Chen wrote: > > Nicolin Chen (4): > > dma: imx-sdma: Add sdma firmware version 2 support > > dma: imx-sdma: Add new dma type for ssi dual fifo script > > ASoC: fsl_ssi:

Re: [PATCHv2 5/8] ASoC: SGTL5000: Enhance the SGTL5000 codec driver about regulator.

2013-11-01 Thread Nicolin Chen
ONFIG_SND_SOC_FSL_SGTL5000_VF610 Checking a platform or SoC specific define here is just a bit Could you pls find a better solution? Like I said at first, use fixed regulator or figure out why your System would hang with current sgtl5000 driver. If it really has a critical bug in its regula

Re: [PATCHv2 6/8] ASoC: fsl: add SGTL5000 based audio machine driver.

2013-11-01 Thread Nicolin Chen
de "fsl-sai.h" > + > +static unsigned int sysclk_rate; > + > +static int fsl_sgtl5000_dai_init(struct snd_soc_pcm_runtime *rtd) Naming issue here again. At least from my point of view, if you actually merged imx-sgtl5000 with vf610-sgtl5000 and made it also compatible to othe

Re: [PATCHv2 1/8] ALSA: Add SAI SoC Digital Audio Interface driver.

2013-11-03 Thread Nicolin Chen
e'. However, your driver doesn't take care of them. The SAI's synchronous mode looks like more flexible than SSI's. The driver needs to be more sophisticated so that it can handle multiple cases when TX/RX clocks are con

[PATCH v4 0/4] Add dual-fifo mode support of i.MX ssi

2013-11-08 Thread Nicolin Chen
* fifo mode. To support this mode, we need to first update sdma sciprt * list, and then enable dual fifo BIT in SSI driver, and last update DT * bindings of i.MX series. Nicolin Chen (4): dma: imx-sdma: Add sdma firmware version 2 support dma: imx-sdma: Add new dma type for ssi dual fifo

[PATCH v4 1/4] dma: imx-sdma: Add sdma firmware version 2 support

2013-11-08 Thread Nicolin Chen
On i.MX5/6 series, SDMA is using new version firmware to support SSI dual FIFO feature and HDMI Audio (i.MX6Q/DL only). Thus add it. Signed-off-by: Nicolin Chen --- drivers/dma/imx-sdma.c | 15 ++- include/linux/platform_data/dma-imx-sdma.h | 5 + 2 files

[PATCH v4 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script

2013-11-08 Thread Nicolin Chen
This patch adds a new DMA_TYPE for SSI dual FIFO script, included in SDMA firmware version 2. This script would allow SSI use dual fifo mode to transimit/receive data without occasional hardware underrun/overrun. Signed-off-by: Nicolin Chen --- Documentation/devicetree/bindings/dma/fsl-imx

[PATCH v4 3/4] ASoC: fsl_ssi: Add dual fifo mode support

2013-11-08 Thread Nicolin Chen
By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git

[PATCH v4 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi

2013-11-08 Thread Nicolin Chen
Use dual-fifo sdma scripts instead of shared scripts for ssi on i.MX series. Signed-off-by: Nicolin Chen --- arch/arm/boot/dts/imx51.dtsi | 4 ++-- arch/arm/boot/dts/imx53.dtsi | 4 ++-- arch/arm/boot/dts/imx6qdl.dtsi | 12 ++-- arch/arm/boot/dts/imx6sl.dtsi | 12 ++-- 4

Re: [PATCH v4 0/4] Add dual-fifo mode support of i.MX ssi

2013-11-08 Thread Nicolin Chen
On Fri, Nov 08, 2013 at 06:49:32PM +0800, Nicolin Chen wrote: > * ! This series of patches has a direct dependency between them. When > * ! applying them, we need to apply to one single branch. Otherwise, > * ! it would break currect branches. > > Changelog > v4: > * PAT

[PATCH v5 0/4] Add dual-fifo mode support of i.MX ssi

2013-11-08 Thread Nicolin Chen
the last two patches. v1: * SSI can reduce hardware overrun/underrun possibility when using dual * fifo mode. To support this mode, we need to first update sdma sciprt * list, and then enable dual fifo BIT in SSI driver, and last update DT * bindings of i.MX series. Nicolin Chen (4): dma: imx

[PATCH v5 1/4] dma: imx-sdma: Add sdma firmware version 2 support

2013-11-08 Thread Nicolin Chen
On i.MX5/6 series, SDMA is using new version firmware to support SSI dual FIFO feature and HDMI Audio (i.MX6Q/DL only). Thus add it. Signed-off-by: Nicolin Chen --- drivers/dma/imx-sdma.c | 15 ++- include/linux/platform_data/dma-imx-sdma.h | 5 + 2 files

[PATCH v5 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script

2013-11-08 Thread Nicolin Chen
This patch adds a new DMA_TYPE for SSI dual FIFO script, included in SDMA firmware version 2. This script would allow SSI use dual fifo mode to transimit/receive data without occasional hardware underrun/overrun. Signed-off-by: Nicolin Chen --- Documentation/devicetree/bindings/dma/fsl-imx

[PATCH v5 3/4] ASoC: fsl_ssi: Add dual fifo mode support

2013-11-08 Thread Nicolin Chen
By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git

[PATCH v5 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi

2013-11-08 Thread Nicolin Chen
Use dual-fifo sdma scripts instead of shared scripts for ssi on i.MX series. Signed-off-by: Nicolin Chen --- arch/arm/boot/dts/imx51.dtsi | 4 ++-- arch/arm/boot/dts/imx53.dtsi | 4 ++-- arch/arm/boot/dts/imx6qdl.dtsi | 12 ++-- arch/arm/boot/dts/imx6sl.dtsi | 12 ++-- 4

[PATCH v6 0/4] Add dual-fifo mode support of i.MX ssi

2013-11-10 Thread Nicolin Chen
, and then enable dual fifo BIT in SSI driver, and last update DT * bindings of i.MX series. Nicolin Chen (4): dma: imx-sdma: Add sdma firmware version 2 support dma: imx-sdma: Add new dma type for ssi dual fifo script ASoC: fsl_ssi: Add dual fifo mode support ARM: dts: imx: use dual-fifo

[PATCH v6 1/4] dma: imx-sdma: Add sdma firmware version 2 support

2013-11-10 Thread Nicolin Chen
On i.MX5/6 series, SDMA is using new version firmware to support SSI dual FIFO feature and HDMI Audio (i.MX6Q/DL only). Thus add it. Signed-off-by: Nicolin Chen --- drivers/dma/imx-sdma.c | 15 ++- include/linux/platform_data/dma-imx-sdma.h | 5 + 2 files

[PATCH v6 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script

2013-11-10 Thread Nicolin Chen
This patch adds a new DMA_TYPE for SSI dual FIFO script, included in SDMA firmware version 2. This script would allow SSI use dual fifo mode to transimit/receive data without occasional hardware underrun/overrun. Signed-off-by: Nicolin Chen --- Documentation/devicetree/bindings/dma/fsl-imx

[PATCH v6 3/4] ASoC: fsl_ssi: Add dual fifo mode support

2013-11-10 Thread Nicolin Chen
By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git

[PATCH v6 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi

2013-11-10 Thread Nicolin Chen
Use dual-fifo sdma scripts instead of shared scripts for ssi on i.MX series. Signed-off-by: Nicolin Chen --- arch/arm/boot/dts/imx51.dtsi | 4 ++-- arch/arm/boot/dts/imx53.dtsi | 4 ++-- arch/arm/boot/dts/imx6qdl.dtsi | 12 ++-- arch/arm/boot/dts/imx6sl.dtsi | 12 ++-- 4

[PATCH v7 0/4] Add dual-fifo mode support of i.MX ssi

2013-11-13 Thread Nicolin Chen
errun possibility when using dual * fifo mode. To support this mode, we need to first update sdma sciprt * list, and then enable dual fifo BIT in SSI driver, and last update DT * bindings of i.MX series. Nicolin Chen (4): dma: imx-sdma: Add sdma firmware version 2 support dma: imx-sdma: Add ne

[PATCH v7 1/4] dma: imx-sdma: Add sdma firmware version 2 support

2013-11-13 Thread Nicolin Chen
On i.MX5/6 series, SDMA is using new version firmware to support SSI dual FIFO feature and HDMI Audio (i.MX6Q/DL only). Thus add it. Signed-off-by: Nicolin Chen Acked-by: Sascha Hauer --- drivers/dma/imx-sdma.c | 15 ++- include/linux/platform_data/dma-imx

[PATCH v7 2/4] dma: imx-sdma: Add new dma type for ssi dual fifo script

2013-11-13 Thread Nicolin Chen
This patch adds a new DMA_TYPE for SSI dual FIFO script, included in SDMA firmware version 2. This script would allow SSI use dual fifo mode to transimit/receive data without occasional hardware underrun/overrun. Signed-off-by: Nicolin Chen Acked-by: Kumar Gala Acked-by: Sascha Hauer

[PATCH v7 3/4] ASoC: fsl_ssi: Add dual fifo mode support

2013-11-13 Thread Nicolin Chen
By enabling dual fifo mode, it would allow SSI enter a better performance to transimit/receive data without occasional hardware underrun/overrun. Signed-off-by: Nicolin Chen Acked-by: Timur Tabi Acked-by: Mark Brown --- sound/soc/fsl/fsl_ssi.c | 27 ++- 1 file changed

[PATCH v7 4/4] ARM: dts: imx: use dual-fifo sdma script for ssi

2013-11-13 Thread Nicolin Chen
Use dual-fifo sdma scripts instead of shared scripts for ssi on i.MX series. Signed-off-by: Nicolin Chen Acked-by: Shawn Guo --- arch/arm/boot/dts/imx51.dtsi | 4 ++-- arch/arm/boot/dts/imx53.dtsi | 4 ++-- arch/arm/boot/dts/imx6qdl.dtsi | 12 ++-- arch/arm/boot/dts/imx6sl.dtsi

[PATCH 0/2] Add monaural audio support for fsl_ssi.c

2013-11-14 Thread Nicolin Chen
i.MX platforms, just currently I don't have those boards so I drop their changes for now. Nicolin Chen (2): ARM: dts: imx: specify the value of audmux pinctrl instead of 0x8000 ASoC: fsl_ssi: Add monaural audio support for non-ac97 interface arch/arm/boot/dts/imx6qdl.dtsi

[PATCH 1/2] ARM: dts: imx: specify the value of audmux pinctrl instead of 0x80000000

2013-11-14 Thread Nicolin Chen
level one (0). Signed-off-by: Nicolin Chen --- arch/arm/boot/dts/imx6qdl.dtsi | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi index 6e096ca..6b76e55 100644 --- a/arch/arm/boot/dts/imx6qdl.

[PATCH 2/2] ASoC: fsl_ssi: Add monaural audio support for non-ac97 interface

2013-11-14 Thread Nicolin Chen
The normal mode of SSI allows it to send/receive data to/from the first slot of each period. So we can use this normal mode to trick I2S signal by puting/getting data to/from the first slot only (the left channel) so as to support monaural audio playback and recording. Signed-off-by: Nicolin Chen

Re: [PATCH 0/2] Add monaural audio support for fsl_ssi.c

2013-11-14 Thread Nicolin Chen
Hi Shawn, On Fri, Nov 15, 2013 at 11:02:49AM +0800, Shawn Guo wrote: > On Thu, Nov 14, 2013 at 07:07:08PM +0800, Nicolin Chen wrote: > > This series of patches need to be applied into one single tree because > > the second patch depends on the first one. Without it, SSI

Re: [PATCH 0/2] Add monaural audio support for fsl_ssi.c

2013-11-14 Thread Nicolin Chen
On Fri, Nov 15, 2013 at 11:22:52AM +0800, Shawn Guo wrote: > On Fri, Nov 15, 2013 at 10:59:57AM +0800, Nicolin Chen wrote: > > Hi Shawn, > > > > On Fri, Nov 15, 2013 at 11:02:49AM +0800, Shawn Guo wrote: > > > On Thu, Nov 14, 2013 at 07:07:08PM +0800, Nicolin Chen

Re: [PATCH 1/2] ARM: dts: imx: specify the value of audmux pinctrl instead of 0x80000000

2013-11-14 Thread Nicolin Chen
On Fri, Nov 15, 2013 at 02:42:01PM +0800, Shawn Guo wrote: > On Thu, Nov 14, 2013 at 07:07:09PM +0800, Nicolin Chen wrote: > > We must specify the value of audmux pinctrl if we want to use pinctrl_pm(). > > Thus change bypass value 0x8000 to what we exactly need. > >

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-12 Thread Nicolin Chen
Sir, On Thu, Jun 12, 2014 at 10:24:55PM -0500, Timur Tabi wrote: > On Thu, Dec 12, 2013 at 4:44 AM, Nicolin Chen > wrote: > > > > +static int fsl_ssi_set_dai_sysclk(struct snd_soc_dai *cpu_dai, > > + int clk_id, un

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-12 Thread Nicolin Chen
On Thu, Jun 12, 2014 at 10:44:48PM -0500, Timur Tabi wrote: > On Thu, Jun 12, 2014 at 10:21 PM, Nicolin Chen > wrote: > > > It compiles well with my ARM cross compiler. I guess it might be related > > to the compiler's version? But we should fix it anyway. Would you mi

Re: [alsa-devel] [RFC][PATCH v1] ASoC: fsl_ssi: Add DAI master mode support for SSI on i.MX series

2014-06-13 Thread Nicolin Chen
On Fri, Jun 13, 2014 at 11:00:01AM +0200, Takashi Iwai wrote: > At Thu, 12 Jun 2014 22:24:55 -0500, > Timur Tabi wrote: > > > > On Thu, Dec 12, 2013 at 4:44 AM, Nicolin Chen > > wrote: > > > > > > +static int fsl_ssi_

[RFC][PATCH 0/2] Add ASRC Peripheral to Peripheral driver

2014-06-13 Thread Nicolin Chen
This series of patches have a direct dependency between them. So we might need to push them into one branch. And sorry for this :( Patch-1 adds device to device support in SDMA driver along with a secondary request in struct imx_dma_data which's requred in the Patch-2 ASRC driver. Nicolin

[RFC][PATCH 1/2] dma: imx-sdma: Add device to device support

2014-06-13 Thread Nicolin Chen
This patch adds DEV_TO_DEV support for i.MX SDMA driver to support data tranfer between two peripheral FIFOs. The per_2_per script requires two peripheral addresses and two DMA requests. So this patch also adds them into private structure. Signed-off-by: Nicolin Chen --- drivers/dma/imx-sdma.c

Re: [RFC][PATCH 1/2] dma: imx-sdma: Add device to device support

2014-06-27 Thread Nicolin Chen
On Fri, Jun 13, 2014 at 06:07:04PM +0800, Nicolin Chen wrote: > This patch adds DEV_TO_DEV support for i.MX SDMA driver to support data > tranfer between two peripheral FIFOs. The per_2_per script requires two > peripheral addresses and two DMA requests. So this patch also adds them >

Re: [RFC][PATCH 1/2] dma: imx-sdma: Add device to device support

2014-07-11 Thread Nicolin Chen
On Fri, Jun 13, 2014 at 06:07:04PM +0800, Nicolin Chen wrote: > This patch adds DEV_TO_DEV support for i.MX SDMA driver to support data > tranfer between two peripheral FIFOs. The per_2_per script requires two > peripheral addresses and two DMA requests. So this patch also adds them >

[PATCH 0/2] ASoC: fsl_sai: Two bug fixes for fsl_sai driver

2014-07-17 Thread Nicolin Chen
Nicolin Chen (2): ASoC: fsl_sai: Reset FIFOs after disabling TE/RE ASoC: fsl_sai: Fix incorrect register writing in fsl_sai_isr() sound/soc/fsl/fsl_sai.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) -- 1.8.4 ___ Linuxppc-dev

[PATCH 1/2] ASoC: fsl_sai: Reset FIFOs after disabling TE/RE

2014-07-17 Thread Nicolin Chen
SAI will not clear their FIFOs after disabling TE/RE. Therfore, the driver should take care the task so as not to let useless data remain in the FIFO. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_sai.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl

[PATCH 2/2] ASoC: fsl_sai: Fix incorrect register writing in fsl_sai_isr()

2014-07-17 Thread Nicolin Chen
In the rx irq handling part, we should clear the flags in RCSR not TCSR. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_sai.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c index b10dbd8..1b6ee2c 100644 --- a/sound/soc

Re: [PATCH 1/2] ASoC: fsl_sai: Reset FIFOs after disabling TE/RE

2014-07-18 Thread Nicolin Chen
Mark, Please disregard this single patch. On Thu, Jul 17, 2014 at 09:21:37PM +0800, Nicolin Chen wrote: > SAI will not clear their FIFOs after disabling TE/RE. Therfore, the driver > should take care the task so as not to let useless data remain in the FIFO. > > Signed-off

Re: [PATCH 1/2] ASoC: fsl_sai: Reset FIFOs after disabling TE/RE

2014-07-23 Thread Nicolin Chen
Sir, I found this two patches are merged into for-next branch, although I haven't got the 'applied' email. Is that possible for you to drop this one? If not, I'll send another patch to fix this. Thank you, Nicolin On Fri, Jul 18, 2014 at 06:18:12PM +0800, Nicoli

Re: [PATCH 1/2] ASoC: fsl_sai: Reset FIFOs after disabling TE/RE

2014-07-23 Thread Nicolin Chen
On Wed, Jul 23, 2014 at 11:07:46AM +0100, Mark Brown wrote: > On Wed, Jul 23, 2014 at 05:52:32PM +0800, Nicolin Chen wrote: > > > I found this two patches are merged into for-next branch, although I haven't > > got the 'applied' email. > > > Is that

[PATCH 0/3] ASoC: fsl_sai: Fix some issues in fsl_sai_trigger()

2014-07-23 Thread Nicolin Chen
The series of patches focus on issue fix inside fsl_sai_trigger(). Nicolin Chen (3): ASoC: fsl_sai: Reduce race condition during TE/RE enabling ASoC: fsl_sai: Don't reset FIFO until TE/RE bit is unset ASoC: fsl_sai: Improve enable flow in fsl_sai_trigger() sound/soc/fsl/fsl_sai.c

[PATCH 1/3] ASoC: fsl_sai: Reduce race condition during TE/RE enabling

2014-07-23 Thread Nicolin Chen
From: Nicolin Chen For trigger start, we don't need to check if it's the first time to enable TE/RE or second time. It doesn't hurt to enable them any way, which in the meantime can reduce race condition for TE/RE enabling. For trigger stop, we will definitely clear FRDE of cu

[PATCH 2/3] ASoC: fsl_sai: Don't reset FIFO until TE/RE bit is unset

2014-07-23 Thread Nicolin Chen
From: Nicolin Chen TE/RE bit of T/RCSR will remain set untill the current frame is physically finished. The FIFO reset operation should wait this bit's totally cleared rather than ignoring its status which might cause TE/RE disabling failed. This patch adds delay and timeout to wait fo

[PATCH 3/3] ASoC: fsl_sai: Improve enable flow in fsl_sai_trigger()

2014-07-23 Thread Nicolin Chen
From: Nicolin Chen The previous enable flow: 1, Enable TE&RE (SAI starts to consume tx FIFO and feed rx FIFO) 2, Mask IRQ of Tx/Rx to enable its interrupt. 3, Enable DMA request of Tx/Rx. As this flow would enable DMA request later than TERE, the Tx FIFO would be easily emptied into unde

[PATCH v2 0/2] Add Freescale ASRC driver

2014-07-24 Thread Nicolin Chen
ts in fsl_asrc_dma.c driver. * PATCH-2: Refined commit comments. Nicolin Chen (2): ARM: imx: Add the secondary request into the structure for imx-sdma ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers .../devicetree/bindings/sound/fsl,asrc.txt | 62 ++ include/linux/platform_dat

[PATCH v2 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma

2014-07-24 Thread Nicolin Chen
either side later since this patch won't break any function and meanwhile it can make merge window more smoothly: we don't need to apply the change inside dmaengine branch via ASoC tree any more. -- Nicolin ] Signed-off-by: Nicolin Chen --- include/linux/platform_data/dma-imx.h | 1

[PATCH v2 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Nicolin Chen
t;WM8962 and SAI. It converts the original sample rate to a common rate supported by Back Ends for playback while converts the common rate of Back Ends to a desired rate for capture. It has 3 pairs to support three different substreams within totally 10 channels. Signed-off-by: Nicolin Chen --- ..

Re: [RFC][PATCH 0/2] Add ASRC Peripheral to Peripheral driver

2014-07-24 Thread Nicolin Chen
On Fri, Jun 13, 2014 at 06:07:03PM +0800, Nicolin Chen wrote: > This series of patches have a direct dependency between them. So we might > need to push them into one branch. And sorry for this :( > > Patch-1 adds device to device support in SDMA driver along with a secondary > re

Re: [PATCH v2 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Nicolin Chen
Hi Tobias, On Thu, Jul 24, 2014 at 05:20:45PM +0200, Tobias Klauser wrote: > On 2014-07-24 at 10:35:29 +0200, Nicolin Chen wrote: > > The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of > > a > > signal associated with an input clock into a sig

[PATCH v3 0/2] Add Freescale ASRC driver

2014-07-24 Thread Nicolin Chen
() in fsl_asrc_dma_pcm_new() * PATCH-2: Added substream check in fsl_asrc_dma_pcm_new() v2: * PATCH-1: Dropped the change to SDMA driver. * PATCH-2: Dropped useless member in private data structures. * PATCH-2: Refined some comments in fsl_asrc_dma.c driver. * PATCH-2: Refined commit comments. Nicolin Ch

[PATCH v3 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma

2014-07-24 Thread Nicolin Chen
either side later since this patch won't break any function and meanwhile it can make merge window more smoothly: we don't need to apply the change inside dmaengine branch via ASoC tree any more. -- Nicolin ] Signed-off-by: Nicolin Chen Acked-by: Shawn Guo --- include/linux/platfor

[PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Nicolin Chen
t;WM8962 and SAI. It converts the original sample rate to a common rate supported by Back Ends for playback while converts the common rate of Back Ends to a desired rate for capture. It has 3 pairs to support three different substreams within totally 10 channels. Signed-off-by: Nicolin Chen --- ..

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Nicolin Chen
Hi Varka, On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote: > On 07/25/2014 09:33 AM, Nicolin Chen wrote: > >The Asynchronous Sample Rate Converter (ASRC) converts the sampling rate of a > >signal associated with an input clock into a signal associated with a > &g

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Nicolin Chen
Hi Varka, Regarding a point you suggested. On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote: > On 07/25/2014 09:33 AM, Nicolin Chen wrote: > (...) > > >+ > >+static const struct platform_device_id fsl_asrc_devtype[] = { > >+{ > >

Re: [PATCH v3 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-24 Thread Nicolin Chen
On Fri, Jul 25, 2014 at 11:47:42AM +0530, Varka Bhadram wrote: > Hi Nicolin, > > On 07/25/2014 11:24 AM, Nicolin Chen wrote: > >Hi Varka, > > > >Regarding a point you suggested. > > > >On Fri, Jul 25, 2014 at 09:54:43AM +0530, Varka Bhadram wrote: &

[PATCH v4 0/2] Add Freescale ASRC driver

2014-07-25 Thread Nicolin Chen
pcm_new() * PATCH-2: Added substream check in fsl_asrc_dma_pcm_new() v2: * PATCH-1: Dropped the change to SDMA driver. * PATCH-2: Dropped useless member in private data structures. * PATCH-2: Refined some comments in fsl_asrc_dma.c driver. * PATCH-2: Refined commit comments. Nicolin Chen (2):

[PATCH v4 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma

2014-07-25 Thread Nicolin Chen
either side later since this patch won't break any function and meanwhile it can make merge window more smoothly: we don't need to apply the change inside dmaengine branch via ASoC tree any more. -- Nicolin ] Signed-off-by: Nicolin Chen Acked-by: Shawn Guo --- include/linux/platfor

[PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Nicolin Chen
t;WM8962 and SAI. It converts the original sample rate to a common rate supported by Back Ends for playback while converts the common rate of Back Ends to a desired rate for capture. It has 3 pairs to support three different substreams within totally 10 channels. Signed-off-by: Nicolin Chen --- ..

Re: [PATCH v4 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Nicolin Chen
Hi Varka, Thank you for the comments! On Fri, Jul 25, 2014 at 01:05:05PM +0530, Varka Bhadram wrote: > On 07/25/2014 12:49 PM, Nicolin Chen wrote: > (...) > > >+static const struct platform_device_id fsl_asrc_devtype[] = { > >+{ > >+

[PATCH v5 0/2] Add Freescale ASRC driver

2014-07-25 Thread Nicolin Chen
e comments in fsl_asrc_dma.c driver. * PATCH-2: Refined commit comments. Nicolin Chen (2): ARM: imx: Add the secondary request into the structure for imx-sdma ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers .../devicetree/bindings/sound/fsl,asrc.txt | 60 ++ include/linux/platfor

[PATCH v5 1/2] ARM: imx: Add the secondary request into the structure for imx-sdma

2014-07-25 Thread Nicolin Chen
either side later since this patch won't break any function and meanwhile it can make merge window more smoothly: we don't need to apply the change inside dmaengine branch via ASoC tree any more. -- Nicolin ] Signed-off-by: Nicolin Chen Acked-by: Shawn Guo --- include/linux/platfor

[PATCH v5 2/2] ASoC: fsl_asrc: Add ASRC ASoC CPU DAI and platform drivers

2014-07-25 Thread Nicolin Chen
t;WM8962 and SAI. It converts the original sample rate to a common rate supported by Back Ends for playback while converts the common rate of Back Ends to a desired rate for capture. It has 3 pairs to support three different substreams within totally 10 channels. Signed-off-by: Nicolin Chen --- ..

<    1   2   3   4   5   6   7   8   >