Re: [patch 4/6] ARM: move bridge enable out of pcibios_enable_resources()

2008-03-06 Thread Russell King - ARM Linux
On Wed, Feb 27, 2008 at 05:04:41PM -0700, Bjorn Helgaas wrote: Move bridge enable from pcibios_enable_resources() to platform_pci_enable_device() so the former matches other architectures and can be shared. Signed-off-by: Bjorn Helgaas [EMAIL PROTECTED] Index:

Re: [RFC,PATCH 0/7 v2] Common struct clk implementation

2010-01-12 Thread Russell King - ARM Linux
On Tue, Jan 12, 2010 at 05:58:31PM +1100, Jeremy Kerr wrote: The first two patches are for the architecture-independent kernel code, introducing the common clk API. The remaining patches are specific to the ARM 'versatile' and 'realview' platforms. You're still only touching the easy platforms

Re: [RFC,PATCH 1/7 v2] Add a common struct clk

2010-01-12 Thread Russell King - ARM Linux
On Tue, Jan 12, 2010 at 09:48:44AM +0100, Francesco VIRLINZI wrote: Hi Jeremy In November I already sent a proposal on a generic linux clk framework. On that I would suggest: +struct clk { +const struct clk_operations *ops; spinlock_t lock; const char

Re: [RFC,PATCH 3/7 v2] arm/versatile: use generic struct clk

2010-01-12 Thread Russell King - ARM Linux
On Tue, Jan 12, 2010 at 05:58:31PM +1100, Jeremy Kerr wrote: diff --git a/arch/arm/common/clkdev.c b/arch/arm/common/clkdev.c index aae5bc0..71e7596 100644 --- a/arch/arm/common/clkdev.c +++ b/arch/arm/common/clkdev.c @@ -85,11 +85,13 @@ struct clk *clk_get(struct device *dev, const char

Re: [RFC PATCH v2 4/9] add generic dmabounce support

2010-02-28 Thread Russell King - ARM Linux
On Sun, Feb 28, 2010 at 03:07:57PM +0100, Albert Herranz wrote: This patch makes part of the ARM dmabounce code available to other architectures as a generic API. There is already a generic dma bounce implementation - it's called swiotlb - lib/swiotlb.c. We should eventually switch the ARM

Re: Request review of device tree documentation

2010-06-14 Thread Russell King - ARM Linux
On Sun, Jun 13, 2010 at 11:23:45PM -0600, Grant Likely wrote: Or perhaps the MMU and caches can be turned off for the duration of the callback. I don't have the details of ARM MMUs and caches reloaded into my head yet.  Maybe next week... We've had these kinds of questions in the past.

Re: Request review of device tree documentation

2010-06-14 Thread Russell King - ARM Linux
On Sun, Jun 13, 2010 at 09:45:50PM -1000, Mitch Bradley wrote: None of this is a deal-breaker for the kind of debugging tasks that are the primary use case for the callback. Would you mind explaining what kind of tasks these callbacks will be used for?

Re: Request review of device tree documentation

2010-06-14 Thread Russell King - ARM Linux
On Mon, Jun 14, 2010 at 07:36:10PM +1000, Benjamin Herrenschmidt wrote: However, there's a lot of room for abuse here and I'm worried that if it becomes widespread, we'll start seeing vendors use that as a way to do some kind of HAL and hide various platform methods in there (clock control,

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Russell King - ARM Linux
On Fri, Jul 16, 2010 at 11:57:55AM -0600, Grant Likely wrote: Last missing piece is being able to do select FOO = n, which Stephen is currently working on. I thought Linus' idea was to use: KBUILD_KCONFIG=file make allnoconfig in which case any option which would be presented to the user

Re: [RFC PATCH] Kconfig: Enable Kconfig fragments to be used for defconfig

2010-07-16 Thread Russell King - ARM Linux
On Fri, Jul 16, 2010 at 02:19:31PM -0400, Nicolas Pitre wrote: For example, if I want CONFIG_MTD_CMDLINE_PARTS=y, the system may be smart enough to notice and automatically enable CONFIG_MTD and CONFIG_MTD_PARTITIONS without having to carry those in the defconfig. How do you sort out

Re: [PATCH] ftrace: mcountrecord.pl for arm

2008-11-21 Thread Russell King - ARM Linux
On Thu, Nov 20, 2008 at 02:11:49PM -0800, Jim Radford wrote: Ingo and Steven, Here's an updated version of the arch/arm changes for dynamic ftrace based on top of your latest tip/master. Excuse me if I'm rather confused, but... When ftrace for ARM was originally merged, neither

Re: [PATCH v1 05/24] clk: wrap I/O access for improved portability

2013-07-18 Thread Russell King - ARM Linux
On Thu, Jul 18, 2013 at 09:04:02AM +0200, Gerhard Sittig wrote: The common clock API assumes (it's part of the contract) that there are potentially expensive operations like get, put, prepare and unprepare, as well as swift and non-blocking operations like enable and disable. Let's get

Re: [PATCH v2 18/24] i2c: mpc: OF clock lookup for MPC512x

2013-07-18 Thread Russell King - ARM Linux
On Thu, Jul 18, 2013 at 10:20:52PM +0200, Gerhard Sittig wrote: + /* enable clock for the I2C peripheral (non fatal) */ + clk = of_clk_get_by_name(node, per); + if (!IS_ERR(clk)) { + clk_prepare_enable(clk); + clk_put(clk); + } + This kind of hacked

[PATCH 00/51] DMA mask changes

2013-09-19 Thread Russell King - ARM Linux
This started out as a request to look at the DMA mask situation, and how to solve the issues which we have on ARM - notably how the DMA mask should be setup. However, I started off reviewing how the dma_mask and coherent_dma_mask was being used, and what I found was rather messy, and in some

Re: [PATCH 42/51] DMA-API: usb: musb: use platform_device_register_full() to avoid directly messing with dma masks

2013-09-20 Thread Russell King - ARM Linux
On Fri, Sep 20, 2013 at 08:11:25AM -0500, Felipe Balbi wrote: Hi, On Fri, Sep 20, 2013 at 12:14:38AM +0100, Russell King wrote: Use platform_device_register_full() for those drivers which can, to avoid messing directly with DMA masks. This can only be done when the driver does not need

Re: [PATCH 39/51] DMA-API: others: use dma_set_coherent_mask()

2013-09-20 Thread Russell King - ARM Linux
On Fri, Sep 20, 2013 at 07:16:52AM -0500, Tejun Heo wrote: On Fri, Sep 20, 2013 at 12:11:38AM +0100, Russell King wrote: The correct way for a driver to specify the coherent DMA mask is not to directly access the field in the struct device, but to use dma_set_coherent_mask(). Only arch and

Re: [PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks

2013-09-20 Thread Russell King - ARM Linux
On Fri, Sep 20, 2013 at 02:21:37AM +0100, Ben Hutchings wrote: On Thu, 2013-09-19 at 22:25 +0100, Russell King wrote: [...] -dma_set_coherent_mask() will always be able to set the same or a -smaller mask as dma_set_mask(). However for the rare case that a +The coherent coherent mask will

Re: [PATCH 24/51] DMA-API: dma: pl330: add dma_set_mask_and_coherent() call

2013-09-21 Thread Russell King - ARM Linux
On Fri, Sep 20, 2013 at 07:26:27PM +0200, Heiko Stübner wrote: Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King: The DMA API requires drivers to call the appropriate dma_set_mask() functions before doing any DMA mapping. Add this required call to the AMBA PL08x driver.

Re: [alsa-devel] [PATCH 43/51] DMA-API: dma: edma.c: no need to explicitly initialize DMA masks

2013-09-23 Thread Russell King - ARM Linux
On Mon, Sep 23, 2013 at 03:55:33PM +0530, Vinod Koul wrote: On Fri, Sep 20, 2013 at 12:15:39AM +0100, Russell King wrote: register_platform_device_full() can setup the DMA mask provided the appropriate member is set in struct platform_device_info. So lets make that be the case. This

Re: [PATCH 36/51] DMA-API: usb: use dma_set_coherent_mask()

2013-09-23 Thread Russell King - ARM Linux
On Mon, Sep 23, 2013 at 02:27:39PM -0400, Alan Stern wrote: On Thu, 19 Sep 2013, Russell King wrote: The correct way for a driver to specify the coherent DMA mask is not to directly access the field in the struct device, but to use dma_set_coherent_mask(). Only arch and bus code should

Re: mm: insure topdown mmap chooses addresses above security minimum

2013-09-24 Thread Russell King - ARM Linux
On Tue, Sep 24, 2013 at 02:23:31PM -0700, Timothy Pepper wrote: diff --git a/arch/arm/mm/mmap.c b/arch/arm/mm/mmap.c index 0c63562..0e7355d 100644 --- a/arch/arm/mm/mmap.c +++ b/arch/arm/mm/mmap.c @@ -9,6 +9,7 @@ #include linux/io.h #include linux/personality.h #include linux/random.h

Re: [PATCH 28/51] DMA-API: sound: fix dma mask handling in a lot of drivers

2013-09-26 Thread Russell King - ARM Linux
On Thu, Sep 26, 2013 at 09:51:23AM +0200, Takashi Iwai wrote: Hi, sorry for the lat response, as I've been traveling in the last weeks. At Thu, 19 Sep 2013 22:53:02 +0100, Russell King wrote: This code sequence is unsafe in modules: static u64 mask = DMA_BIT_MASK(something);

Re: [PATCH 00/51] DMA mask changes

2013-09-27 Thread Russell King - ARM Linux
On Thu, Sep 26, 2013 at 10:23:08PM +0200, Rafał Miłecki wrote: 2013/9/19 Russell King - ARM Linux li...@arm.linux.org.uk: This email is only being sent to the mailing lists in question, not to anyone personally. The list of individuals is far to great to do that. I'm hoping no mailing

Re: [PATCH RFC] Simplify the Linux kernel by reducing its state space

2012-03-31 Thread Russell King - ARM Linux
On Sun, Apr 01, 2012 at 12:33:21AM +0800, Paul E. McKenney wrote: Although there have been numerous complaints about the complexity of parallel programming (especially over the past 5-10 years), the plain truth is that the incremental complexity of parallel programming over that of sequential

Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead

2012-04-02 Thread Russell King - ARM Linux
On Mon, Apr 02, 2012 at 02:28:48PM -0600, Grant Likely wrote: On Mon, 02 Apr 2012 18:29:15 +0200, Andreas Schwab sch...@linux-m68k.org wrote: Andreas Schwab sch...@linux-m68k.org writes: Grant Likely grant.lik...@secretlab.ca writes: This patch drops the powerpc-specific irq_map

Re: [PATCH v5 06/27] irq_domain/powerpc: eliminate irq_map; use irq_alloc_desc() instead

2012-04-02 Thread Russell King - ARM Linux
On Tue, Apr 03, 2012 at 08:33:25AM +1000, Benjamin Herrenschmidt wrote: On Mon, 2012-04-02 at 22:55 +0100, Russell King - ARM Linux wrote: Well, presumably someone is calling irq_set_irq_type() asking explicitly for IRQ_TYPE_NONE. The code will now (as it always used to before David's

Re: [PATCH 5/9] dmaengine: provide a common function for completing a dma descriptor

2012-04-23 Thread Russell King - ARM Linux
On Mon, Apr 23, 2012 at 06:40:06PM +0900, Boojin Kim wrote: I met a problem on DMA cyclic mode (DMA_CYCLIC) for sound playback. Kernel BUG occurs during DMA transfer with DMA cyclic mode. This patch makes the cookies into zero. But, cookies should be kept during cyclic mode because cyclic mode

Re: [PATCH 5/9] dmaengine: provide a common function for completing a dma descriptor

2012-04-23 Thread Russell King - ARM Linux
On Mon, Apr 23, 2012 at 08:06:36PM +0900, Boojin Kim wrote: I met the DMA probing fail problem on Linux 3.4. It's because the return value on regulator_get() is changed from ENODEV to EPROBE_DEFER in case not to supply a vcore regulator. So, I try to change the check value about the return

Re: [2/3][PATCH][v2] TDM Framework

2012-07-27 Thread Russell King - ARM Linux
On Fri, Jul 27, 2012 at 07:35:38PM +0530, sand...@freescale.com wrote: +static DEFINE_MUTEX(tdm_core_lock); +static DEFINE_IDR(tdm_adapter_idr); +/* List of TDM adapters registered with TDM framework */ +LIST_HEAD(adapter_list); + +/* List of TDM clients registered with TDM framework */

Re: [PATCH 3/5] mmc: sdhci-pltfm: Do not use parent as the host's device

2014-08-11 Thread Russell King - ARM Linux
On Mon, Aug 11, 2014 at 10:15:50AM +0100, Pawel Moll wrote: On Mon, 2014-08-11 at 10:07 +0100, Ulf Hansson wrote: Sorry for the delay. I suppose this make sense, but I really don't know for sure. I guess we need some testing in linux-next, to get some confidence. Would you take it

Re: [PATCH 1/4] Device tree entry for Freescale TDM controller

2013-03-07 Thread Russell King - ARM Linux
I know I'm probably missing something... but... why are these patches copied to the ARM list? They appear to be PowerPC patches. On Thu, Mar 07, 2013 at 04:57:45PM +0530, Sandeep Singh wrote: Added dtsi file for Freescale TDM controller. This controller is available on many Freescale SOCs like

Re: [PATCH 3/4 v2] net: mvmdio: enhance driver to support SMI error/done interrupts

2013-03-15 Thread Russell King - ARM Linux
On Thu, Mar 14, 2013 at 07:08:34PM +0100, Florian Fainelli wrote: + if (dev-err_interrupt == NO_IRQ) { ... + init_waitqueue_head(dev-smi_busy_wait); + + dev-err_interrupt = platform_get_irq(pdev, 0); + if (dev-err_interrupt != -ENXIO) { ... + } else +

Re: [PATCH v2 00/10] uaccess: better might_sleep/might_fault behavior

2013-05-22 Thread Russell King - ARM Linux
On Wed, May 22, 2013 at 11:25:36AM +0200, Arnd Bergmann wrote: Given the most commonly used functions and a couple of architectures I'm familiar with, these are the ones that currently call might_fault() x86-32 x86-64 arm arm64 powerpc s390generic

Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it.

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 10:40:29AM +0200, Geert Uytterhoeven wrote: On Thu, May 23, 2013 at 9:57 AM, Chen Gang gang.c...@asianux.com wrote: -config BUG - bool BUG() support if EXPERT - default y - help - Disabling this option eliminates support for BUG and

Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it.

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 11:39:37AM +0200, Arnd Bergmann wrote: On Thursday 23 May 2013, Geert Uytterhoeven wrote: The problem is: trying to fix that will mean the result is a larger kernel than if you just do the usual arch-implemented thing of placing an defined faulting instruction at

Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it.

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 03:09:50AM -0700, Eric W. Biederman wrote: Arnd Bergmann a...@arndb.de writes: On Thursday 23 May 2013, Geert Uytterhoeven wrote: The problem is: trying to fix that will mean the result is a larger kernel than if you just do the usual arch-implemented thing of

Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it.

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 12:59:43PM +0200, Arnd Bergmann wrote: On Thursday 23 May 2013, Russell King - ARM Linux wrote: So, if you want to use this, then you should update the CONFIG_BUG text to include a warning to this effect: Warning: if CONFIG_BUG is turned off, and control flow

Re: [PATCH] arch: configuration, deleting 'CONFIG_BUG' since always need it.

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 02:09:02PM +0200, Arnd Bergmann wrote: On Thursday 23 May 2013, Russell King - ARM Linux wrote: This is the problem you guys are missing - unreachable() means we lose control of the CPU at this point. I'm absolutely aware of this. Again, the current behaviour

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-24 Thread Russell King - ARM Linux
On Fri, May 24, 2013 at 01:01:25PM -0400, Jason Cooper wrote: On Fri, May 24, 2013 at 01:03:25PM +0200, Linus Walleij wrote: IMO: if you want to go down that road, what you really want is not ever more expressible device trees, but real open firmware, or ACPI or UEFI that can interpret and

Re: [RFC 10/10] irqchip: Make versatile fpga irq driver a generic chip

2013-06-10 Thread Russell King - ARM Linux
On Mon, Jun 10, 2013 at 01:49:22AM +0100, Grant Likely wrote: This is an RFC patch to convert the versatile FPGA irq controller driver to use generic irq chip. It builds on the series that extends the generic chip code to allow a linear irq domain to contain one or more generic irq chips so

Re: [PATCH] atomic: add *_dec_not_zero

2011-05-08 Thread Russell King - ARM Linux
On Tue, May 03, 2011 at 11:30:35PM +0200, Sven Eckelmann wrote: Introduce an *_dec_not_zero operation. Make this a special case of *_add_unless because batman-adv uses atomic_dec_not_zero in different places like re-broadcast queue or aggregation queue management. There are other non-final

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread Russell King - ARM Linux
On Tue, Jun 14, 2011 at 09:30:47PM -0700, H. Peter Anvin wrote: On 06/14/2011 02:33 PM, Arnd Bergmann wrote: Why on earth restrict it like that? It's just a device driver, like more or less any other device driver... I'd say any other classic ISA/PC driver, including floppy, gameport

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread Russell King - ARM Linux
On Tue, Jun 14, 2011 at 09:31:27PM -0700, H. Peter Anvin wrote: On 06/14/2011 03:08 PM, Luck, Tony wrote: I took a look at the back of all my ia64 systems - none of them have a parallel port. It seems unlikely that new systems will start adding parallel ports :-) So even if I had a

Re: [RFC,PATCH] Cleanup PC parallel port Kconfig

2011-06-15 Thread Russell King - ARM Linux
On Wed, Jun 15, 2011 at 08:08:05AM -0700, H. Peter Anvin wrote: On 06/15/2011 12:47 AM, Russell King - ARM Linux wrote: OK, serial-8250 is clearly just plain wrong, since the 8250 series UARTs are ubiquitous across just about every platform. Floppy is special (in the short bus sense

Re: [PATCH] asm-generic/gpio.h: merge basic gpiolib wrappers

2011-10-27 Thread Russell King - ARM Linux
On Thu, Oct 27, 2011 at 09:01:43AM -0400, Mike Frysinger wrote: diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h index d494001..622851c 100644 --- a/include/asm-generic/gpio.h +++ b/include/asm-generic/gpio.h @@ -170,6 +170,29 @@ extern int __gpio_cansleep(unsigned gpio);

Re: [PATCH] asm-generic/gpio.h: merge basic gpiolib wrappers

2011-10-27 Thread Russell King - ARM Linux
On Thu, Oct 27, 2011 at 03:29:40PM +0200, Mike Frysinger wrote: On Thu, Oct 27, 2011 at 15:11, Russell King - ARM Linux wrote: On Thu, Oct 27, 2011 at 09:01:43AM -0400, Mike Frysinger wrote: diff --git a/include/asm-generic/gpio.h b/include/asm-generic/gpio.h index d494001..622851c 100644

Re: [PATCH] asm-generic/gpio.h: merge basic gpiolib wrappers

2011-10-27 Thread Russell King - ARM Linux
On Thu, Oct 27, 2011 at 09:01:43AM -0400, Mike Frysinger wrote: diff --git a/arch/arm/include/asm/gpio.h b/arch/arm/include/asm/gpio.h index 11ad0bf..741efb2 100644 --- a/arch/arm/include/asm/gpio.h +++ b/arch/arm/include/asm/gpio.h @@ -5,14 +5,15 @@ #include mach/gpio.h #ifndef

Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-22 Thread Russell King - ARM Linux
On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote: Perhaps now might be the time to ask which are the remaining architectures that cannot do SG chaining and then we can fix them and pull the whole thing out. Not quite. You're making the assumption that we can be sure that all

Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-22 Thread Russell King - ARM Linux
On Sat, Mar 22, 2014 at 03:37:40PM -0700, James Bottomley wrote: On Sat, 2014-03-22 at 22:23 +, Russell King - ARM Linux wrote: On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote: Perhaps now might be the time to ask which are the remaining architectures that cannot do SG

Re: [RESEND][PATCH 1/2] lib/scatterlist: Make ARCH_HAS_SG_CHAIN an actual Kconfig

2014-03-24 Thread Russell King - ARM Linux
On Sat, Mar 22, 2014 at 03:59:11PM -0700, James Bottomley wrote: On Sat, 2014-03-22 at 22:52 +, Russell King - ARM Linux wrote: And I'm disagreeing with that statement which implies that it's something that is an architecture wide property for any particular architecture. Right now

[PATCH 00/38] MMC updates, plus CuBox-i WiFi support

2014-04-23 Thread Russell King - ARM Linux
All, This is where I'm at with trying to clean up the SDHCI mess, and sort out issues I've noticed when trying to get UHS support working on CuBoxes. This is my full patch set, but I recommend not applying patch 37 as there appears to be a hardware issue preventing it working reliably. In any

Re: [PATCH 00/38] MMC updates, plus CuBox-i WiFi support

2014-04-24 Thread Russell King - ARM Linux
On Thu, Apr 24, 2014 at 10:25:42AM +0200, Ulf Hansson wrote: I have looked though the patches up until patch 33 and this is clearly a nice piece of clean-up /fixes work for sdhci. Besides my minor comments per patch, I don't have any objections code-review wise to proceed merging them. I

Re: [PATCH 00/38] MMC updates, plus CuBox-i WiFi support

2014-04-24 Thread Russell King - ARM Linux
On Thu, Apr 24, 2014 at 12:52:11PM +0200, Ulf Hansson wrote: On 24 April 2014 12:17, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Apr 24, 2014 at 10:25:42AM +0200, Ulf Hansson wrote: I have looked though the patches up until patch 33 and this is clearly a nice piece

Re: [PATCH 00/38] MMC updates, plus CuBox-i WiFi support

2014-04-25 Thread Russell King - ARM Linux
On Thu, Apr 24, 2014 at 01:13:05PM +0200, Ulf Hansson wrote: On 24 April 2014 12:57, Russell King - ARM Linux li...@arm.linux.org.uk wrote: This is nothing new or unexpected - it was last posted back in February, and I elected that it should be held off until after the last merge window

Re: [PATCH 00/38] MMC updates, plus CuBox-i WiFi support

2014-04-25 Thread Russell King - ARM Linux
On Fri, Apr 25, 2014 at 01:18:28PM +0200, Ulf Hansson wrote: On 25 April 2014 11:03, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Apr 24, 2014 at 01:13:05PM +0200, Ulf Hansson wrote: On 24 April 2014 12:57, Russell King - ARM Linux li...@arm.linux.org.uk wrote

Re: [PATCH 23/38] mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function

2014-06-16 Thread Russell King - ARM Linux
On Wed, Apr 23, 2014 at 08:08:07PM +0100, Russell King wrote: @@ -1507,25 +1529,7 @@ static void sdhci_do_set_ios(struct sdhci_host *host, struct mmc_ios *ios) host-ops-set_clock(host, host-clock); } - if (host-ops-set_uhs_signaling) -

Re: [PATCH 23/38] mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function

2014-06-17 Thread Russell King - ARM Linux
On Mon, Jun 16, 2014 at 02:17:30PM +0200, Ulf Hansson wrote: On 16 June 2014 12:46, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Wed, Apr 23, 2014 at 08:08:07PM +0100, Russell King wrote: @@ -1507,25 +1529,7 @@ static void sdhci_do_set_ios(struct sdhci_host *host, struct

Re: [PATCH 23/38] mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function

2014-06-19 Thread Russell King - ARM Linux
On Mon, Jun 16, 2014 at 02:17:30PM +0200, Ulf Hansson wrote: Anyway, we did get some folks to test the patches and was thus fairly confident that we could merge them. Chris asked me to try to collect them in a PR for him, so I did. Sorry if I managed to screw some things up, there were several

Re: [PATCH 2/9] drivers: base: support cpu cache information interface to userspace via sysfs

2014-06-25 Thread Russell King - ARM Linux
On Wed, Jun 25, 2014 at 06:30:37PM +0100, Sudeep Holla wrote: + coherency_line_size: the minimum amount of data that gets transferred So, what value to do envision this taking for a CPU where the cache line size is 32 bytes, but each cache line has two dirty bits which allow it to

Re: [PATCH 2/9] drivers: base: support cpu cache information interface to userspace via sysfs

2014-06-26 Thread Russell King - ARM Linux
On Thu, Jun 26, 2014 at 07:41:32PM +0100, Sudeep Holla wrote: Hi, On 25/06/14 23:23, Russell King - ARM Linux wrote: On Wed, Jun 25, 2014 at 06:30:37PM +0100, Sudeep Holla wrote: + coherency_line_size: the minimum amount of data that gets transferred So, what value to do

Re: [PATCH 19/51] DMA-API: media: dt3155v4l: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-10-31 Thread Russell King - ARM Linux
On Thu, Oct 31, 2013 at 09:46:40AM -0200, Mauro Carvalho Chehab wrote: Hi Russell, Em Mon, 30 Sep 2013 13:57:47 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: On 09/19/2013 11:44 PM, Russell King wrote: Replace the following sequence: dma_set_mask(dev, mask);

Re: [PATCH 2/2] ASoC: fsl_ssi: Add monaural audio support for non-ac97 interface

2013-11-15 Thread Russell King - ARM Linux
On Thu, Nov 14, 2013 at 07:07:10PM +0800, Nicolin Chen wrote: The normal mode of SSI allows it to send/receive data to/from the first slot of each period. So we can use this normal mode to trick I2S signal by puting/getting data to/from the first slot only (the left channel) so as to support

Re: [PATCH 16/51] DMA-API: ppc: vio.c: replace dma_set_mask()+dma_set_coherent_mask() with new helper

2013-11-16 Thread Russell King - ARM Linux
On Fri, Nov 15, 2013 at 05:16:55PM +0100, Cedric Le Goater wrote: The new helper routine dma_set_mask_and_coherent() breaks the initialization of the pseries vio devices which do not have an initial dev-dma_mask. I think we need to use dma_coerce_mask_and_coherent() instead. Who wants to

Re: [RFC PATCH powerpc] Fix a dma_mask issue of vio

2013-11-20 Thread Russell King - ARM Linux
On Wed, Nov 20, 2013 at 12:28:02PM +1100, Benjamin Herrenschmidt wrote: On Tue, 2013-11-19 at 16:11 +0800, Li Zhong wrote: I encountered following issue: [0.283035] ibmvscsi 3015: couldn't initialize event pool [5.688822] ibmvscsi: probe of 3015 failed with error -1

Re: [RFC PATCH powerpc] Fix a dma_mask issue of vio

2013-11-20 Thread Russell King - ARM Linux
On Thu, Nov 21, 2013 at 11:01:42AM +1100, Benjamin Herrenschmidt wrote: On Wed, 2013-11-20 at 23:23 +, Russell King - ARM Linux wrote: Li Zong's patch works around the issue of a failing dma_set_mask(), but as I've already said elsewhere, the real fix is to get whatever created

Re: [PATCH RFC 2/3] ARM: kernel: add support for cpu cache information

2014-01-08 Thread Russell King - ARM Linux
On Wed, Jan 08, 2014 at 07:26:07PM +, Sudeep Holla wrote: +#if __LINUX_ARM_ARCH__ 7 /* pre ARMv7 */ + +#define MAX_CACHE_LEVEL 1 /* Only 1 level supported */ +#define CTR_CTYPE_SHIFT 24 +#define CTR_CTYPE_MASK (1 CTR_CTYPE_SHIFT) + +static

Re: [PATCH RFC 2/3] ARM: kernel: add support for cpu cache information

2014-01-09 Thread Russell King - ARM Linux
On Thu, Jan 09, 2014 at 07:35:03PM +, Sudeep Holla wrote: I assume you referring to some particular CPUs which don't implement this. I could not find it as optional or IMPLEMENTATION defined in ARM ARM. I might be missing to find it or there may be exceptions. Can you please provide more

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Russell King - ARM Linux
On Mon, Jan 27, 2014 at 01:08:16AM -0500, Nicolas Pitre wrote: ARM and ARM64 are the only two architectures implementing arch_cpu_idle_prepare() simply to call local_fiq_enable(). We have secondary_start_kernel() already calling local_fiq_enable() and this is done a second time in

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Russell King - ARM Linux
On Mon, Jan 27, 2014 at 09:22:55AM +0100, Daniel Lezcano wrote: On 01/27/2014 07:08 AM, Nicolas Pitre wrote: ARM and ARM64 are the only two architectures implementing arch_cpu_idle_prepare() simply to call local_fiq_enable(). We have secondary_start_kernel() already calling local_fiq_enable()

Re: [PATCH 1/9] ARM: get rid of arch_cpu_idle_prepare()

2014-01-27 Thread Russell King - ARM Linux
On Mon, Jan 27, 2014 at 10:45:59AM -0500, Nicolas Pitre wrote: On Mon, 27 Jan 2014, Russell King - ARM Linux wrote: On Mon, Jan 27, 2014 at 01:08:16AM -0500, Nicolas Pitre wrote: ARM and ARM64 are the only two architectures implementing arch_cpu_idle_prepare() simply to call

Re: [PATCH 2/6] PCI/arm: Use list_for_each_entry() for bus traversal

2014-02-13 Thread Russell King - ARM Linux
On Thu, Feb 13, 2014 at 09:13:59PM +0800, Yijing Wang wrote: Replace list_for_each() + pci_bus_b() with the simpler list_for_each_entry(). Signed-off-by: Yijing Wang wangyij...@huawei.com Acked-by: Russell King rmk+ker...@arm.linux.org.uk -- FTTC broadband for 0.8mile line: 5.8Mbps down

[PATCH RFC 00/31] SDHCI and SDIO IRQ improvements

2014-02-18 Thread Russell King - ARM Linux
The following patch series is targetted at two things - fixing the SDIO interrupt handling, and fixing problems with the sdhci driver. - the first two patches from Thomas Gleixner provide genirq support to allow us to fix the SDIO interrupt handling in a graceful manner. - patch 3 adds support

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Russell King - ARM Linux
On Mon, Jan 17, 2011 at 12:07:13PM +0100, Peter Zijlstra wrote: diff --git a/arch/alpha/kernel/smp.c b/arch/alpha/kernel/smp.c index 42aa078..c4a570b 100644 --- a/arch/alpha/kernel/smp.c +++ b/arch/alpha/kernel/smp.c @@ -587,6 +587,7 @@ handle_ipi(struct pt_regs *regs) case

Re: [PATCH] sched: provide scheduler_ipi() callback in response to smp_send_reschedule()

2011-01-17 Thread Russell King - ARM Linux
On Mon, Jan 17, 2011 at 12:41:49PM +0100, Peter Zijlstra wrote: === --- linux-2.6.orig/arch/arm/kernel/smp.c +++ linux-2.6/arch/arm/kernel/smp.c @@ -575,10 +575,7 @@ asmlinkage void __exception do_IPI(struc

Re: [PATCH 207/493] i2c: remove use of __devinit

2012-11-20 Thread Russell King - ARM Linux
On Tue, Nov 20, 2012 at 09:20:46AM +0100, Jean Delvare wrote: Hi Bill, On Mon, 19 Nov 2012 13:22:36 -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is going away as an option so __devinit is no longer needed. Can you please point me/us to the discussion explaining the rationale behind this

Re: [PATCH 192/493] scsi: remove use of __devinit

2012-11-21 Thread Russell King - ARM Linux
On Mon, Nov 19, 2012 at 01:22:21PM -0500, Bill Pemberton wrote: drivers/scsi/arm/acornscsi.c | 2 +- drivers/scsi/arm/arxescsi.c | 2 +- drivers/scsi/arm/cumana_1.c | 2 +- drivers/scsi/arm/cumana_2.c | 2 +- drivers/scsi/arm/eesox.c

Re: [PATCH 238/493] mtd: remove use of __devinit

2012-11-21 Thread Russell King - ARM Linux
On Mon, Nov 19, 2012 at 01:23:07PM -0500, Bill Pemberton wrote: drivers/mtd/maps/pismo.c | 14 +++--- drivers/mtd/maps/sa1100-flash.c| 5 ++--- For these two, Acked-by: Russell King rmk+ker...@arm.linux.org.uk ___

Re: [PATCH 198/493] ethernet: remove use of __devinit

2012-11-21 Thread Russell King - ARM Linux
On Mon, Nov 19, 2012 at 01:22:27PM -0500, Bill Pemberton wrote: drivers/net/ethernet/8390/etherh.c | 4 +- drivers/net/ethernet/amd/am79c961a.c | 2 +- drivers/net/ethernet/i825xx/ether1.c | 8 +- drivers/net/ethernet/seeq/ether3.c

Re: [PATCH 298/493] video: remove use of __devinitdata

2012-11-21 Thread Russell King - ARM Linux
On Mon, Nov 19, 2012 at 01:24:07PM -0500, Bill Pemberton wrote: drivers/video/acornfb.c| 8 +++--- drivers/video/cyber2000fb.c| 2 +- drivers/video/sa1100fb.c | 2 +- For these three, Acked-by: Russell King rmk+ker...@arm.linux.org.uk

Re: [PATCH 1/2] cpuhotplug/nohz: Remove offline cpus from nohz-idle state

2013-01-05 Thread Russell King - ARM Linux
On Thu, Jan 03, 2013 at 06:58:38PM -0800, Srivatsa Vaddagiri wrote: I also think that the wait_for_completion() based wait in ARM's __cpu_die() can be replaced with a busy-loop based one, as the wait there in general should be terminated within few cycles. Why open-code this stuff when we

Re: [PATCH v3 2/3] usb: fsl_mxc_udc: replace MX35_IO_ADDRESS to ioremap

2013-01-14 Thread Russell King - ARM Linux
On Mon, Jan 14, 2013 at 06:12:40PM +0800, Peter Chen wrote: @@ -83,15 +84,16 @@ void fsl_udc_clk_finalize(enum fsl_udc_type devtype, struct fsl_usb2_platform_data *pdata = pdev-dev.platform_data; if (devtype == IMX35_UDC) { unsigned int v; + void __iomem

Re: [PATCH v5 00/45] CPU hotplug: stop_machine()-free CPU hotplug

2013-02-08 Thread Russell King - ARM Linux
On Thu, Feb 07, 2013 at 11:41:34AM +0530, Srivatsa S. Bhat wrote: On 02/07/2013 09:44 AM, Rusty Russell wrote: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com writes: On 01/22/2013 01:03 PM, Srivatsa S. Bhat wrote: Avg. latency of 1 CPU offline (ms) [stop-cpu/stop-m/c

Re: [PATCH 2/2] of: use platform_device_add

2013-02-17 Thread Russell King - ARM Linux
On Sun, Feb 17, 2013 at 03:43:20PM +0800, Shawn Guo wrote: It also breaks all of_amba_device users. of_amba_device_create() -- amba_device_add() -- request_resource() and fails. Presumably that's because we no longer know what the parent resource is supposed to be?

Re: [PATCHv5] atomic: add *_dec_not_zero

2011-12-04 Thread Russell King - ARM Linux
On Sun, Dec 04, 2011 at 04:42:49PM +0100, Sven Eckelmann wrote: diff --git a/arch/alpha/include/asm/atomic.h b/arch/alpha/include/asm/atomic.h +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1, 0) diff --git a/arch/arm/include/asm/atomic.h b/arch/arm/include/asm/atomic.h +#define

Re: Re: [PATCHv5] atomic: add *_dec_not_zero

2011-12-04 Thread Russell King - ARM Linux
On Sun, Dec 04, 2011 at 10:49:10PM +0100, Sven Eckelmann wrote: On Sunday 04 December 2011 21:33:16 Russell King - ARM Linux wrote: [...] +#define atomic64_dec_not_zero(v) atomic64_add_unless((v), -1LL, 0LL) I think this is rather silly - all these definitions are very similar to each

Re: [RFC PATCH v2 8/9] smp: refactor on_each_cpu to void returning func

2012-01-08 Thread Russell King - ARM Linux
On Sun, Jan 08, 2012 at 03:32:28PM +0200, Gilad Ben-Yossef wrote: on_each_cpu returns the retunr value of smp_call_function which is hard coded to 0. Refactor on_each_cpu to a void function and the few callers that check the return value to save compares and branches. Signed-off-by: Gilad

Re: [PATCH] irq: make SPARSE_IRQ an optionally hidden option

2012-02-04 Thread Russell King - ARM Linux
So that everyone who received this patch knows... I've just pulled Rob's series, which includes this patch, into a stable branch in my tree and it is my intention to send this during the 3.4 merge window. This means that there is a patch in my tree which touches other architectures' Kconfig

Re: [PATCH v3 00/25] irq_domain generalization and refinement

2012-02-04 Thread Russell King - ARM Linux
On Fri, Jan 27, 2012 at 02:35:54PM -0700, Grant Likely wrote: Hey everyone, This patch series is ready for much wider consumption now. I'd like to get it into linux-next ASAP because there will be ARM board support depending on it. I'll wait a few days before I ask Stephen to pull this

Re: [PATCH v3 00/25] irq_domain generalization and refinement

2012-02-04 Thread Russell King - ARM Linux
On Sat, Feb 04, 2012 at 10:17:48PM +, Russell King - ARM Linux wrote: On Fri, Jan 27, 2012 at 02:35:54PM -0700, Grant Likely wrote: Hey everyone, This patch series is ready for much wider consumption now. I'd like to get it into linux-next ASAP because there will be ARM board

Re: [PATCH v3 00/25] irq_domain generalization and refinement

2012-02-05 Thread Russell King - ARM Linux
On Sat, Feb 04, 2012 at 05:38:53PM -0800, Tony Lindgren wrote: * Russell King - ARM Linux li...@arm.linux.org.uk [120204 14:00]: Actually, it turns out to be not that hard, because twl doesn't actually make use of the IRQ domain stuff: commit aeb5032b3f8b9ab69daa545777433fa94b3494c4

Re: [PATCH v5 00/27] irq_domain generalization and rework

2012-02-16 Thread Russell King - ARM Linux
On Thu, Feb 16, 2012 at 02:52:19PM -0800, Andrew Morton wrote: On Thu, 16 Feb 2012 02:09:01 -0700 Grant Likely grant.lik...@secretlab.ca wrote: This series generalizes the irq_host infrastructure from powerpc so that it can be used by all architectures and renames it to irq_domain.

Re: [PATCH v5 00/27] irq_domain generalization and rework

2012-02-17 Thread Russell King - ARM Linux
On Fri, Feb 17, 2012 at 06:42:31PM +0100, Cousson, Benoit wrote: Hi Grant, On 2/16/2012 11:52 PM, Andrew Morton wrote: On Thu, 16 Feb 2012 02:09:01 -0700 Grant Likelygrant.lik...@secretlab.ca wrote: This series generalizes the irq_host infrastructure from powerpc so that it can

in_be32() etc

2012-02-23 Thread Russell King - ARM Linux
What's this stuff doing in generic drivers? See drivers/gpio/gpio-xilinx.c: static int xgpio_get(struct gpio_chip *gc, unsigned int gpio) { struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc); return (in_be32(mm_gc-regs + XGPIO_DATA_OFFSET) gpio) 1; }

Re: in_be32() etc

2012-02-23 Thread Russell King - ARM Linux
On Fri, Feb 24, 2012 at 07:18:59AM +1100, Benjamin Herrenschmidt wrote: On Thu, 2012-02-23 at 11:29 +, Russell King - ARM Linux wrote: What's this stuff doing in generic drivers? Well, I suppose that's because the xilinx stuff used to be ppc only ? :-) Note that's just the first one

[PATCH 0/9] DMA engine cookie handling cleanups

2012-03-05 Thread Russell King - ARM Linux
This patch series cleans up the handling of cookies in DMA engine drivers. This is done by providing a set of inline library functions for common tasks: - moving the 'last completed cookie' into struct dma_chan - everyone has this in their driver private channel data structure - consolidate

[PATCH 6/9] dmaengine: consolidate tx_status functions

2012-03-05 Thread Russell King - ARM Linux
Now that we have the completed cookie in the dma_chan structure, we can consolidate the tx_status functions by providing a function to set the txstate structure and returning the DMA status. We also provide a separate helper to set the residue for cookies which are still in progress.

[PATCH 2/9] dmaengine: move last completed cookie into generic dma_chan structure

2012-03-05 Thread Russell King - ARM Linux
Every DMA engine implementation declares a last completed dma cookie in their private dma channel structures. This is pointless, and forces driver specific code. Move this out into the common dma_chan structure. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk ---

[PATCH 3/9] dmaengine: add private header file

2012-03-05 Thread Russell King - ARM Linux
Add a local private header file to contain definitions and declarations which should only be used by DMA engine drivers. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/dma/amba-pl08x.c|2 ++ drivers/dma/at_hdmac.c |1 + drivers/dma/coh901318.c |1 +

[PATCH 4/9] dmaengine: consolidate assignment of DMA cookies

2012-03-05 Thread Russell King - ARM Linux
Everyone deals with assigning DMA cookies in the same way (it's part of the API so they should be), so lets consolidate the common code into a helper function to avoid this duplication. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/dma/amba-pl08x.c|9 +++--

[PATCH 5/9] dmaengine: provide a common function for completing a dma descriptor

2012-03-05 Thread Russell King - ARM Linux
Provide a common function to do the cookie mechanics for completing a DMA descriptor. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk --- drivers/dma/amba-pl08x.c|2 +- drivers/dma/at_hdmac.c |2 +- drivers/dma/coh901318.c |2 +- drivers/dma/dmaengine.h |

  1   2   3   >