Re: [PATCH] sound: Don't assume i2c device probing always succeeds

At Wed, 30 Sep 2009 15:25:42 +0200, Jean Delvare wrote: If i2c device probing fails, then there is no driver to dereference after calling i2c_new_device(). Stop assuming that probing will always succeed, to avoid NULL pointer dereferences. We have an easier access to the driver anyway.

Re: [PATCH] sound: Don't assume i2c device probing always succeeds

At Wed, 30 Sep 2009 17:00:06 +0200, Jean Delvare wrote: Hi Takashi, Thanks for the swift reply. On Wed, 30 Sep 2009 16:13:49 +0200, Takashi Iwai wrote: At Wed, 30 Sep 2009 15:25:42 +0200, Jean Delvare wrote: If i2c device probing fails, then there is no driver to dereference

Re: [PATCH] sound: Don't assume i2c device probing always succeeds

At Wed, 30 Sep 2009 18:55:05 +0200, Jean Delvare wrote: On Wed, 30 Sep 2009 17:15:49 +0200, Takashi Iwai wrote: Yes, indeed I prefer NULL check because the user can know the error at the right place. I share your concern about the code addition, though :) I already made a patch

Re: [PATCH] sound: Don't assume i2c device probing always succeeds

At Sun, 4 Oct 2009 11:35:21 +0200, Jean Delvare wrote: Hi Takashi, On Thu, 01 Oct 2009 08:52:59 +0200, Takashi Iwai wrote: At Wed, 30 Sep 2009 18:55:05 +0200, Jean Delvare wrote: On Wed, 30 Sep 2009 17:15:49 +0200, Takashi Iwai wrote: Yes, indeed I prefer NULL check because

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

At Tue, 14 Apr 2009 16:37:41 +0200, Jean Delvare wrote: On Fri, 10 Apr 2009 17:02:38 +0200, Jean Delvare wrote: On Thu, 9 Apr 2009 14:19:45 +0200, Jean Delvare wrote: From: Jean Delvare kh...@linux-fr.org Subject: AOA: Convert onyx and tas codecs to new-style i2c drivers The

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

At Thu, 16 Apr 2009 09:53:39 +0200, Jean Delvare wrote: On Tue, 14 Apr 2009 16:45:38 +0200, Takashi Iwai wrote: Johannes, please let me know if the patch works. Then I'll merge them. Note if it matters: the new I2C binding model my patch uses is only available since kernel 2.6.26. Yep

Re: [PATCH] AOA: Convert onyx and tas codecs to new-style i2c drivers

Schwab sch...@linux-m68k.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Takashi Iwai ti...@suse.de --- Takashi, please push this patch to Linus quickly, as this is blocking the removal of the legacy i2c binding model, which is scheduled for 2.6.30. Applied now. Thanks

Re: [PATCH] keywest: Convert to new-style i2c driver

: Takashi Iwai ti...@suse.de --- Takashi, please push this patch to Linus quickly, as this is blocking the removal of the legacy i2c binding model, which is scheduled for 2.6.30. I did not get any test report for this one, but it's relatively simple so I am confident I got it right. Applied

Re: [PATCH] keywest: Convert to new-style i2c driver

At Tue, 21 Apr 2009 08:34:02 +1000, Paul Mackerras wrote: Jean Delvare writes: Takashi, please push this patch to Linus quickly, as this is blocking the removal of the legacy i2c binding model, which is scheduled for 2.6.30. I really don't think you can remove it from Linus' tree at

Re: [PATCH] keywest: Convert to new-style i2c driver

At Tue, 21 Apr 2009 19:33:00 +1000, Paul Mackerras wrote: Takashi Iwai writes: At least, the conversion patch Jean posted can be in 2.6.30, I think. Really? What regression, security hole or serious bug are you going to tell Linus that it fixes? :) Build warning fixes :) Takashi

Re: [PATCH] keywest: Convert to new-style i2c driver

At Tue, 21 Apr 2009 11:23:00 +0200, Jean Delvare wrote: On Tue, 21 Apr 2009 08:31:00 +0200, Takashi Iwai wrote: At Mon, 20 Apr 2009 22:56:59 +0200, Jean Delvare wrote: The legacy i2c binding model is going away soon, so convert the ppc keywest sound driver to the new model

Re: [PATCH][36/37] Clean up duplicate includes in sound/ppc/

At Sat, 21 Jul 2007 17:04:07 +0200, Jesper Juhl wrote: Hi, This patch cleans up duplicate includes in / sound/ppc? :) Signed-off-by: Jesper Juhl [EMAIL PROTECTED] Now applied to ALSA tree. Thanks. Takashi --- diff --git a/sound/ppc/snd_ps3.c b/sound/ppc/snd_ps3.c

Re: ALSA vs. non coherent DMA

Hi Ben, thanks for signaling this long-standing issue again. At Tue, 06 May 2008 10:08:28 +1000, Benjamin Herrenschmidt wrote: Hi Takashi ! I'm bringing up an old thread as I'm just discovering that the problem still hasn't been fixed. There seem to be a few issues with ALSA current

Re: [PATCH] Sam440ep support

At Tue, 06 May 2008 20:12:27 +1000, Benjamin Herrenschmidt wrote: On Tue, 2008-05-06 at 11:16 +0200, Gerhard Pircher wrote: I can't answer this question. *ducked* :-) Takashi? FYI: I posted the results of the test with Takashi's dma_mmap_coherent patch here:

Re: [PATCH] Sam440ep support

At Tue, 06 May 2008 21:25:53 +1000, Benjamin Herrenschmidt wrote: On Tue, 2008-05-06 at 13:14 +0200, Takashi Iwai wrote: sg allocations are usually lists of page, so virt_to_page shouldn't be a problem in the first place, though we still need some way to get the right prot

Re: ALSA vs. non coherent DMA

At Thu, 08 May 2008 07:53:11 +1000, Benjamin Herrenschmidt wrote: On Wed, 2008-05-07 at 09:22 -0500, Timur Tabi wrote: Takashi Iwai wrote: This is a mmap of the data record to be shared in realtime with apps. The app updates its data pointer (appl_ptr) on the mmapped buffer while

ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

At Tue, 06 May 2008 11:16:22 +0200, Gerhard Pircher wrote: Original-Nachricht Datum: Tue, 06 May 2008 18:48:39 +1000 Von: Benjamin Herrenschmidt [EMAIL PROTECTED] An: Gerhard Pircher [EMAIL PROTECTED] CC: linuxppc-dev@ozlabs.org, Takashi Iwai [EMAIL PROTECTED], [EMAIL

Re: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

At Wed, 14 May 2008 23:01:10 +0200, Gerhard Pircher wrote: Original-Nachricht Datum: Wed, 14 May 2008 14:26:53 +0200 Von: Takashi Iwai [EMAIL PROTECTED] An: Gerhard Pircher [EMAIL PROTECTED] CC: [EMAIL PROTECTED], [EMAIL PROTECTED], [EMAIL PROTECTED], linuxppc-dev

Re: ALSA fixes for non-coherent archs (Re: [PATCH] Sam440ep support)

At Mon, 19 May 2008 19:23:10 +0200, Giuseppe Coviello wrote: On mer, 14/05/2008 14.26 +0200, Takashi Iwai wrote: [cut] OK, here is another patch for testing. Since I lost my old patch somewhere (and it's not worth to dig the archive), I wrote it up quickly from scratch. This version

[PATCH 0/3] ALSA fixes for non-coherent ppc32

Hi, I've tried to renew the fixes of ALSA issues about non-coherent DMA memories. The last patch worked for SG-buffers somehow but would result in a problem if many pages are allocated because of dma_alloc_coherent() handling. Now, I chose a more simpler workaround: the SG-buffers are handled

[PATCH 1/3] ppc: Add dma_mmap_coherent() for PPC32

A very lazy version of dma_mmap_coherent() implementation for ppc32. Signed-off-by: Takashi Iwai [EMAIL PROTECTED] --- include/asm-powerpc/dma-mapping.h | 18 ++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/include/asm-powerpc/dma-mapping.h b/include/asm

[PATCH 2/3] ALSA: Fix mapping of DMA buffers

The DMA buffers allocated via dma_alloc_coherent() aren't easily mmappable for many architectures. This is a quick fix for some known archs that don't work properly with the current code. Signed-off-by: Takashi Iwai [EMAIL PROTECTED] --- sound/core/Kconfig |7 +++ sound/core

[PATCH 3/3] ALSA: Fix SG-buffer DMA with non-coherent architectures

Using SG-buffers with dma_alloc_coherent() is messy for non-coherent architectures. So, simply disable SG-buffers but just allocate normal continuous buffers instead. Signed-off-by: Takashi Iwai [EMAIL PROTECTED] --- include/sound/memalloc.h | 19 +++ include/sound/pcm.h

Re: [alsa-devel] [PATCH 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers

At Tue, 01 Jul 2008 17:53:30 -0600, Grant Likely wrote: diff --git a/sound/soc/Kconfig b/sound/soc/Kconfig index 18f28ac..c5736e5 100644 --- a/sound/soc/Kconfig +++ b/sound/soc/Kconfig @@ -23,6 +23,12 @@ config SND_SOC This ASoC audio support can also be built as a module. If so,

Re: [PATCH 0/3] ALSA fixes for non-coherent ppc32

At Wed, 09 Jul 2008 10:31:11 +0200, Gerhard Pircher wrote: Hi, Original-Nachricht Datum: Wed, 18 Jun 2008 12:38:31 +0200 Von: Takashi Iwai [EMAIL PROTECTED] An: [EMAIL PROTECTED] CC: linuxppc-dev@ozlabs.org, [EMAIL PROTECTED] Betreff: [PATCH 0/3] ALSA fixes

Re: [PATCH 0/3] ALSA fixes for non-coherent ppc32

simply it's so short and I didn't want extra exports. thanks, Takashi --- commit 2c8662fde57af4cf928d17e089dc3dd2096f4b30 Author: Takashi Iwai [EMAIL PROTECTED] Date: Tue Jun 17 16:39:04 2008 +0200 ppc: Add dma_mmap_coherent() for PPC32 A very lazy version of dma_mmap_coherent

Re: [alsa-devel] [PATCH] powerpc/drivers: use linux/of_device.h instead of asm/of_device.h

/of_device.h. If everyone is happy, we can put this through the powerpc tree. I have build tested for ppc64_defconfig and ppc6xx_defconfig (which uses the relevant drivers). After this we can remove the include of linux/of_device.h from asm/of_device.h Looks good to me. Acked-by: Takashi Iwai

Re: [alsa-devel] [PATCH] duplicate SNDRV_PCM_FMTBIT_S{16,24}_BE

At Tue, 19 Aug 2008 08:15:05 +0200 (CEST), Johannes Berg wrote: roel kluin wrote: untested, is it correct? not a clue, do you know how long ago that was? :) does the driver check endianness anywhere? AFAIK snd-aoa supports only bit-endian formats (at least in

Re: [alsa-devel] [PATCH v2] duplicate SNDRV_PCM_FMTBIT_S{16,24}_BE

At Tue, 19 Aug 2008 11:53:54 -0400, roel kluin wrote: Takashi Iwai wrote: At Tue, 19 Aug 2008 08:15:05 +0200 (CEST), Johannes Berg wrote: roel kluin wrote: untested, is it correct? not a clue, do you know how long ago that was? :) does the driver check endianness anywhere

Re: regression on imac G3: problems with sound

At Wed, 1 Oct 2008 23:47:34 +0300, [EMAIL PROTECTED] wrote: 2008/10/1, Mariusz Kozlowski [EMAIL PROTECTED]: Hello, I found that on my old iMac G3 aumix behaves weird on newer (up to 2.6.27-rc8) kernels. The sound is only present _when_ muted and is quiet I'd say 10% of 'normal'

Re: regression on imac G3: problems with sound

At Thu, 2 Oct 2008 12:39:20 +0200, Mariusz Kozlowski wrote: Hello, At Wed, 1 Oct 2008 23:47:34 +0300, [EMAIL PROTECTED] wrote: 2008/10/1, Mariusz Kozlowski [EMAIL PROTECTED]: Hello, I found that on my old iMac G3 aumix behaves weird on newer (up to

Re: [PATCH 11/11] sound: Remove pr_level uses of KERN_level

At Sat, 11 Sep 2010 22:10:59 -0700, Joe Perches wrote: Signed-off-by: Joe Perches j...@perches.com Applied to sound git tree now. Thanks. Takashi --- sound/ppc/snd_ps3.c |2 +- sound/soc/s3c24xx/s3c-dma.c |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff

Re: [alsa-devel] [PATCH] sound/ppc/powermac: remove undefined operations

At Sat, 11 Sep 2010 13:16:41 +0200, Andreas Schwab wrote: Modifying an object twice without an intervening sequence point is undefined. Signed-off-by: Andreas Schwab sch...@linux-m68k.org Applied now. Thanks. Takashi --- sound/ppc/tumbler.c |2 +- 1 files changed, 1

Re: powerpc allmodconfig

At Wed, 15 Oct 2008 21:33:37 -0700, Andrew Morton wrote: sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc-dapm.c:1026) sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at

Re: powerpc allmodconfig

At Thu, 16 Oct 2008 10:38:36 +0300, Adrian Bunk wrote: On Thu, Oct 16, 2008 at 07:57:29AM +0200, Takashi Iwai wrote: At Wed, 15 Oct 2008 21:33:37 -0700, Andrew Morton wrote: sound/soc/soc-dapm.c:1029: warning: 'snd_soc_dapm_connect_input' is deprecated (declared at sound/soc/soc

Re: powerpc allmodconfig

At Thu, 16 Oct 2008 11:21:57 +0300, Adrian Bunk wrote: On Thu, Oct 16, 2008 at 09:57:11AM +0200, Takashi Iwai wrote: At Thu, 16 Oct 2008 10:38:36 +0300, Adrian Bunk wrote: On Thu, Oct 16, 2008 at 07:57:29AM +0200, Takashi Iwai wrote: At Wed, 15 Oct 2008 21:33:37 -0700, Andrew

Re: [PATCH 09/13] powerpc/ps3: printing fixups for l64 to ll64 conversion: sound/ppc

At Wed, 14 Jan 2009 17:07:55 +1100, Stephen Rothwell wrote: Signed-off-by: Stephen Rothwell s...@canb.auug.org.au Acked-by: Takashi Iwai ti...@suse.de --- sound/ppc/snd_ps3.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Takashi, if it is OK with you, this could go

Re: [PATCH] snd-aoa: handle older machines

At Thu, 15 Jan 2009 18:21:48 +0100, Johannes Berg wrote: This patch changes snd-aoa to handle some older machines that are currently handled by snd-powermac. snd-aoa has a number of advantages though, notably it can autoload better and is generally a more modern driver. By hardcoding the

Re: [alsa-devel] [PATCH] ASoC drivers for the Freescale MPC8610 SoC

At Thu, 20 Dec 2007 08:24:35 -0600, Timur Tabi wrote: +static int fsl_dma_new(struct snd_card *card, struct snd_soc_codec_dai *dai, + struct snd_pcm *pcm) +{ + static u64 fsl_dma_dmamask = 0x; + int ret; + + if (!card-dev-dma_mask) + card-dev-dma_mask =

Re: [PATCH 28/51] DMA-API: sound: fix dma mask handling in a lot of drivers

Hi, sorry for the lat response, as I've been traveling in the last weeks. At Thu, 19 Sep 2013 22:53:02 +0100, Russell King wrote: This code sequence is unsafe in modules: static u64 mask = DMA_BIT_MASK(something); ... if (!dev-dma_mask) dev-dma_mask = mask; as if

Re: [PATCH 28/51] DMA-API: sound: fix dma mask handling in a lot of drivers

At Thu, 26 Sep 2013 08:54:25 +0100, Russell King - ARM Linux wrote: On Thu, Sep 26, 2013 at 09:51:23AM +0200, Takashi Iwai wrote: Hi, sorry for the lat response, as I've been traveling in the last weeks. At Thu, 19 Sep 2013 22:53:02 +0100, Russell King wrote: This code

Re: [PATCH 28/51] DMA-API: sound: fix dma mask handling in a lot of drivers

At Thu, 26 Sep 2013 10:25:13 +0200, Takashi Iwai wrote: At Thu, 26 Sep 2013 08:54:25 +0100, Russell King - ARM Linux wrote: On Thu, Sep 26, 2013 at 09:51:23AM +0200, Takashi Iwai wrote: Hi, sorry for the lat response, as I've been traveling in the last weeks. At Thu, 19

Re: [alsa-devel] [PATCH V1 1/3] ASoC: fsl: Kconfig: remove dependence of SND_IMX_SOC for SND_SOC_IMX_PCM_DMA

At Tue, 19 Aug 2014 09:00:06 +, li.xi...@freescale.com wrote: How about the following : diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index 5ae777a..d42f18c 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -15,7 +15,7 @@ config SND_SOC_FSL_ASRC

Re: [PATCH] sound: aoa: printk replacement

At Wed, 10 Sep 2014 20:02:04 +0530, Sudip Mukherjee wrote: On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: On Wed, 2014-09-10 at 19:21 +0530, Sudip Mukherjee wrote: as pr_* macros are more preffered over printk, so printk replaced with corresponding pr_* macros. Are

Re: [PATCH] sound: aoa: printk replacement

At Wed, 10 Sep 2014 20:37:50 +0530, Sudip Mukherjee wrote: On Wed, Sep 10, 2014 at 04:43:03PM +0200, Takashi Iwai wrote: At Wed, 10 Sep 2014 20:02:04 +0530, Sudip Mukherjee wrote: On Wed, Sep 10, 2014 at 03:57:04PM +0200, Johannes Berg wrote: On Wed, 2014-09-10 at 19:21 +0530

Re: [PATCH 4/4] sounds/hda/radeon: Disable 64-bit DMA on radeon

At Wed, 01 Oct 2014 12:09:53 +1000, Benjamin Herrenschmidt wrote: The chipset has a limitation in the number of address bits it can generate. The graphics portion uses a specific mask of 40 or 48 bits depending on the generation. For audio, it's a bit less of an issue, so just mark them as

Re: [PATCH 4/4] sounds/hda/radeon: Disable 64-bit DMA on radeon

At Wed, 01 Oct 2014 17:41:29 +1000, Benjamin Herrenschmidt wrote: On Wed, 2014-10-01 at 09:38 +0200, Takashi Iwai wrote: diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 3e6d22d..2b679d5 100644 --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c

Re: [PATCH 4/4] sounds/hda/radeon: Disable 64-bit DMA on radeon

At Wed, 01 Oct 2014 10:09:28 +0200, Takashi Iwai wrote: At Wed, 01 Oct 2014 17:41:29 +1000, Benjamin Herrenschmidt wrote: On Wed, 2014-10-01 at 09:38 +0200, Takashi Iwai wrote: diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index 3e6d22d..2b679d5 100644

Re: [PATCH v2 3/4] sound/radeon: Move 64-bit MSI quirk from arch to driver

: sta...@vger.kernel.org The attached updated patch only flags the affected asics. Alex's patch looks more comprehensive. For either patch, Reviewed-by: Takashi Iwai ti...@suse.de thanks, Takashi Alex --- arch/powerpc/kernel/pci_64.c | 6 -- sound/pci/hda/hda_intel.c| 10

Re: [PATCH v3 4/7] sound/radeon: Add quirk for broken 64-bit MSI

of maintainership, how do you want to proceed ? I'm happy to merge the whole lot via powerpc ASAP (since it's all CC'ed stable) if you guys send me the appropriate acks, otherwise, let me know. Feel free to merge through your tree. Reviewed-by: Takashi Iwai ti...@suse.de thanks, Takashi

Re: [PATCH 4/4] sound/aoa/fabrics/layout.c: remove unneeded kfree

At Sat, 20 Aug 2011 08:12:41 +0200, Julia Lawall wrote: From: Julia Lawall ju...@diku.dk The label outnodev is only used when kzalloc has not yet taken place or has failed, so there is no need for the call for kfree under this label. A simplified version of the semantic match that finds

Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED

used, it can be applied safely in 3.1-based tree, right? Anyway, if needed, take my ack: Acked-by: Takashi Iwai ti...@suse.de thanks, Takashi --- include/sound/initval.h|2 +- sound/arm/aaci.c |2 +- sound/arm/pxa2xx-ac97-lib.c|2

Re: [PATCH 53/57] sound: irq: Remove IRQF_DISABLED

At Wed, 21 Sep 2011 11:55:36 +0200 (CEST), Thomas Gleixner wrote: We run all interrupt handlers with interrupts disabled and we even check and yell when an interrupt handler returns with interrupts enabled (see commit [b738a50a: genirq: Warn when handler enables interrupts]).

Re: [PATCH] powerpc/ps3: Fix lv1_gpu_attribute hcall

At Wed, 12 Oct 2011 11:42:13 -0700, Geoff Levand wrote: The lv1_gpu_attribute hcall takes three, not five input arguments. Adjust the lv1 hcall table and all calls. Signed-off-by: Geoff Levand ge...@infradead.org CC: Takashi Iwai ti...@suse.de Acked-by: Takashi Iwai ti...@suse.de

Re: [PATCH -next 26/26] sound: Use dma_zalloc_coherent

At Sun, 15 Jun 2014 13:37:55 -0700, Joe Perches wrote: Use the zeroing function instead of dma_alloc_coherent memset(,0,) Signed-off-by: Joe Perches j...@perches.com Applied, thanks. Takashi --- sound/aoa/soundbus/i2sbus/core.c | 12 sound/sparc/dbri.c |

Re: [patch] ALSA: snd-aoa: two copy and paste bugs

At Wed, 13 Nov 2013 10:45:20 +0300, Dan Carpenter wrote: These functions were cut and paste and the tests for NULL weren't updated properly. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Thanks, applied. Takashi diff --git a/sound/aoa/fabrics/layout.c

Re: [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module

At Sat, 19 Feb 2011 15:53:46 +0100, Linux User #330250 wrote: Hello! About two years ago Johannes Berg wrote support for the PowerMac3,6 aka G4 MDD which I was using as a desktop computer then. Johannes wrote all the code, and I tested it. I now have a PowerMac3,5 – yes, an

Re: [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module

At Sun, 20 Feb 2011 22:38:28 +0100, Linux User #330250 wrote: Hello again! Sorry for sending the patch three times. (This is the fourth...) About the sign-off: I use the name I've been using since I started participating. The document $LINUX/Documentation/SubmittingPatches clearly

Re: [BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

At Fri, 25 Mar 2011 09:16:48 +1100, Benjamin Herrenschmidt wrote: Hi Takashi ! While working on endian-fixing xHCI with Matt (CC), we discovered the source of our problems with usb-audio on a board we were working on. c32d977b8157bf67cdf47729ce7dd054a26eb534 ALSA: pcm - Call

Re: [PATCH] powerpc: Implement dma_mmap_coherent()

At Fri, 25 Mar 2011 17:50:06 +1100, Benjamin Herrenschmidt wrote: This is used by Alsa to mmap buffers allocated with dma_alloc_coherent() into userspace. We need a special variant to handle machines with non-coherent DMAs as those buffers have special virt addresses and require non-cachable

Re: [PATCH] powerpc: Implement dma_mmap_coherent()

At Fri, 25 Mar 2011 20:11:57 +1100, Benjamin Herrenschmidt wrote: On Fri, 2011-03-25 at 09:06 +0100, Takashi Iwai wrote: @@ -52,6 +53,7 @@ extern void __dma_sync_page(struct page *page, unsigned long offset, #define __dma_free_coherent(size, addr) ((void)0) #define

Re: [BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

At Fri, 25 Mar 2011 20:15:33 +1100, Benjamin Herrenschmidt wrote: We must also make sure we don't go down that path for vmalloc memory though. Yes. I haven't actually checked, but I assume that the test substream-dma_buffer.dev.type == SNDRV_DMA_TYPE_DEV In

Re: ALSA: vmalloc buffers should use normal mmap

archs are supposed to use dma_mmap_coherent(). (See my separate patch that adds dma_mmap_coherent() to powerpc) Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org CC: Takashi Iwai ti...@suse.de Applied now to sound git tree. Thanks. Takashi --- include/sound/pcm.h

Re: [BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

At Fri, 25 Mar 2011 21:23:26 +1100, Benjamin Herrenschmidt wrote: On Fri, 2011-03-25 at 11:12 +0100, Takashi Iwai wrote: At Fri, 25 Mar 2011 20:15:33 +1100, Benjamin Herrenschmidt wrote: We must also make sure we don't go down that path for vmalloc memory though

Re: [alsa-devel] [PATCH] aoa: remove driver_data direct access of struct device

At Mon, 11 May 2009 21:54:51 +0200, Roel Kluin wrote: To avoid direct access to the driver_data pointer in struct device, the functions dev_get_drvdata() and dev_set_drvdata() should be used. Signed-off-by: Roel Kluin roel.kl...@gmail.com The same fix has been already in Greg's tree (and

Re: [alsa-devel] [PATCH] aoa: remove driver_data direct access of struct device

At Mon, 11 May 2009 23:57:43 -0700, Greg KH wrote: On Tue, May 12, 2009 at 08:40:05AM +0200, Takashi Iwai wrote: At Mon, 11 May 2009 21:54:51 +0200, Roel Kluin wrote: To avoid direct access to the driver_data pointer in struct device, the functions dev_get_drvdata

Re: [alsa-devel] [PATCH] aoa: remove driver_data direct access of struct device

At Tue, 12 May 2009 16:05:14 -0700, Greg KH wrote: On Tue, May 12, 2009 at 09:23:47AM +0200, Takashi Iwai wrote: At Mon, 11 May 2009 23:57:43 -0700, Greg KH wrote: On Tue, May 12, 2009 at 08:40:05AM +0200, Takashi Iwai wrote: At Mon, 11 May 2009 21:54:51 +0200, Roel Kluin

Re: [PATCH] keywest: Get rid of useless i2c_device_name() macro

At Thu, 14 May 2009 14:37:21 +0200, Jean Delvare wrote: The i2c_device_name() macro is used only once and doesn't have much value, it hurts redability more than it helps. Get rid of it. Signed-off-by: Jean Delvare kh...@linux-fr.org Cc: Benjamin Herrenschmidt b...@kernel.crashing.org

Re: [PATCH 3/3] sound: use dev_set_drvdata

At Sun, 17 May 2009 11:29:21 +0200 (CEST), Julia Lawall wrote: From: Julia Lawall ju...@diku.dk Eliminate direct accesses to the driver_data field. cf 82ab13b26f15f49be45f15ccc96bfa0b81dfd015 The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/)

Re: [PATCH] sound/ppc: update annotations of serveral functions

At Wed, 3 Jun 2009 15:35:19 +1000, Stephen Rothwell wrote: [I am not sure if this is the correct approach as I don't know if any of this actual hardware or drivers are really hot pluggable.] I thought it can be bound/unbound dynamically via sysfs. Anyway, the patch looks correct, so I

Re: [PATCH 26/33] sound/ps3: Fix checkpatch issues

At Wed, 10 Jun 2009 16:39:01 +0200, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven geert.uytterhoe...@sonycom.com Cc: alsa-de...@alsa-project.org Cc: Takashi Iwai ti...@suse.de Thanks, applied these three patches (26,27,28) to sound git tree. Takashi --- sound/ppc/snd_ps3

Re: [PATCH 26/33] sound/ps3: Fix checkpatch issues

At Mon, 15 Jun 2009 12:22:08 +1000, Benjamin Herrenschmidt wrote: On Wed, 2009-06-10 at 16:55 +0200, Takashi Iwai wrote: At Wed, 10 Jun 2009 16:39:01 +0200, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven geert.uytterhoe...@sonycom.com Cc: alsa-de...@alsa-project.org

Re: [PATCH 26/33] sound/ps3: Fix checkpatch issues

At Mon, 15 Jun 2009 15:51:03 +1000, Benjamin Herrenschmidt wrote: On Mon, 2009-06-15 at 07:43 +0200, Takashi Iwai wrote: The alsa part also already reached to the upstream, so we have to give revert patches if needed. But, in the case of sound bits, I think they can remain

Re: ALSA fixes for non-coherent ppc32 again

At Mon, 22 Jun 2009 08:34:38 +1000, Benjamin Herrenschmidt wrote: On Sun, 2009-06-21 at 20:18 +0200, Gerhard Pircher wrote: Hi, Takashi Iwai posted patches to make ALSA work on non-coherent PPC32 systems (almost exactly) a year ago. See here: http://www.nabble.com/-PATCH-0-3--ALSA

Re: ALSA fixes for non-coherent ppc32 again

At Wed, 24 Jun 2009 10:46:01 +0200, Gerhard Pircher wrote: Original-Nachricht Datum: Tue, 23 Jun 2009 23:42:24 +0200 Von: Gerhard Pircher gerhard_pirc...@gmx.net An: b...@kernel.crashing.org, ti...@suse.de CC: linuxppc-...@ozlabs.org Betreff: Re: ALSA fixes for

Re: ALSA fixes for non-coherent ppc32 again

At Wed, 08 Jul 2009 13:01:50 +1000, Benjamin Herrenschmidt wrote: On Mon, 2009-06-22 at 08:34 +1000, Benjamin Herrenschmidt wrote: On Sun, 2009-06-21 at 20:18 +0200, Gerhard Pircher wrote: Hi, Takashi Iwai posted patches to make ALSA work on non-coherent PPC32 systems (almost

Re: ALSA fixes for non-coherent ppc32 again

At Fri, 26 Jun 2009 15:14:54 +0200, Gerhard Pircher wrote: Original-Nachricht Datum: Wed, 24 Jun 2009 11:47:13 +0200 Von: Takashi Iwai ti...@suse.de An: Gerhard Pircher gerhard_pirc...@gmx.net CC: b...@kernel.crashing.org, linuxppc-...@ozlabs.org Betreff: Re: ALSA

Re: [PATCH 5/5] sound/aoa: Add kmalloc NULL tests

At Thu, 30 Jul 2009 16:29:54 +0200 (CEST), Julia Lawall wrote: On Thu, 30 Jul 2009, Johannes Berg wrote: On Thu, 2009-07-30 at 16:11 +0200, Julia Lawall wrote: From: Julia Lawall ju...@diku.dk Check that the result of kzalloc is not NULL before a dereference.

Re: [PATCH 5/5] sound/aoa: Add kmalloc NULL tests

At Fri, 31 Jul 2009 08:32:03 +0200 (CEST), Julia Lawall wrote: From: Julia Lawall ju...@diku.dk Check that the result of kzalloc is not NULL before a dereference. The semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // smpl @@ expression

Re: [PATCH -v2 0/7] powerpc: use asm-generic/dma-mapping-common.h

At Thu, 13 Aug 2009 16:51:53 +1000, Benjamin Herrenschmidt wrote: On Thu, 2009-08-13 at 16:44 +1000, Benjamin Herrenschmidt wrote: On Wed, 2009-08-05 at 14:08 +0900, FUJITA Tomonori wrote: The above swiotlb patchset was merged in -tip so I think that merging this patchset via -tip

Re: [PATCH -v2 0/7] powerpc: use asm-generic/dma-mapping-common.h

At Thu, 13 Aug 2009 18:07:57 +1000, Benjamin Herrenschmidt wrote: On Thu, 2009-08-13 at 09:11 +0200, Takashi Iwai wrote: I'm willing to rebase my patches to the generic dma_ops, so feel free to pull it first. I think I'll end up pulling Ingo's iommu branch into powerpc-next to get

Re: [PATCH] ALSA: i2sbus: Deletion of unnecessary checks before the function call release_and_free_resource

At Tue, 02 Dec 2014 22:55:57 +0100, SF Markus Elfring wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Tue, 2 Dec 2014 22:50:24 +0100 The release_and_free_resource() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is

Re: [alsa-devel] [RFC 2/2] sound: ppc: keywest: drop using attach adapter

At Thu, 4 Dec 2014 17:41:53 +0100, Wolfram Sang wrote: As we now have deferred probing, we can use a custom mechanism and finally get rid of the legacy interface from the i2c core. Signed-off-by: Wolfram Sang w...@the-dreams.de --- sound/ppc/keywest.c | 21 ++--- 1 file

Re: [alsa-devel] [PATCH 1/7 linux-next] ALSA: aoa: constify of_device_id array

At Wed, 18 Mar 2015 17:48:56 +0100, Fabian Frederick wrote: of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick f...@skynet.be Thanks, applied this one. The rest ASoC patches are left to Mark. Takashi ---

Re: [alsa-devel] [PATCH RESEND] sound: ppc: keywest: drop using attach adapter

At Sat, 9 May 2015 19:42:22 +0200, Wolfram Sang wrote: As we now have deferred probing, we can use a custom mechanism and finally get rid of this legacy interface from the i2c core. Signed-off-by: Wolfram Sang w...@the-dreams.de Tested-by: Dan DeVoto dand1...@yahoo.com Tested-by: Mark

Re: [alsa-devel] [PATCH v2] ALSA: aoa: convert bus code to use dev_groups

At Thu, 11 Jun 2015 10:03:38 +0200, Quentin Lambert wrote: The dev_attrs field of struct bus_type is going away, use dev_groups instead. This converts the soundbus code to use the correct field. Given that all other usages of the macro define the struct attribute *xxx_attrs[] in the same

Re: [alsa-devel] [PATCH v2] ALSA: aoa: convert bus code to use dev_groups

At Thu, 11 Jun 2015 14:04:45 +0200, Quentin Lambert wrote: On 11/06/2015 12:02, Takashi Iwai wrote: At Thu, 11 Jun 2015 10:03:38 +0200, Quentin Lambert wrote: The dev_attrs field of struct bus_type is going away, use dev_groups instead. This converts the soundbus code to use

Re: [PATCH v3] ALSA: aoa: convert bus code to use dev_groups

At Fri, 12 Jun 2015 12:01:42 +0200, Quentin Lambert wrote: On 12/06/2015 11:59, Andreas Schwab wrote: Quentin Lambert lambert.quen...@gmail.com writes: The dev_attrs field of struct bus_type is going away, sue dev_groups instead. s/sue/use/ I meant use do you need to fix

Re: [alsa-devel] [RFC] sound: ppc: keywest: check if DEQ was already instantiated

At Fri, 29 May 2015 20:06:09 +0900, Wolfram Sang wrote: Do you think from which stable kernel version can this be applied? The offending commit is 3a3dd0186f619b74e61e6f29dddcaf59af7d3cac (i2c/powermac: Improve detection of devices from device-tree) which came in with v3.6 if I read

Re: [alsa-devel] [RFC] sound: ppc: keywest: check if DEQ was already instantiated

At Fri, 29 May 2015 19:50:22 +0900, Wolfram Sang wrote: On Thu, May 28, 2015 at 09:33:27AM +0200, Takashi Iwai wrote: At Tue, 26 May 2015 02:19:34 -0700, Dan DeVoto wrote: Hi, I applied this patch (check if DEQ was already instantiated) on top of sound: ppc: keywest: drop

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

At Fri, 29 May 2015 17:49:06 +0200, Quentin Lambert wrote: On 28/05/2015 17:01, Takashi Iwai wrote: Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into soundbus/sysfs.c, and make it this global instead of soundbus_dev_attrs[]. Ok, I need to find a nice way to do

Re: [alsa-devel] [RFC] sound: ppc: keywest: check if DEQ was already instantiated

At Tue, 26 May 2015 02:19:34 -0700, Dan DeVoto wrote: Hi, I applied this patch (check if DEQ was already instantiated) on top of sound: ppc: keywest: drop using attach adapter and sound works great. Everything works as expected. Below is my dmesg output. Very well, shall I merge the

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

At Thu, 28 May 2015 15:59:50 +0200, Quentin Lambert wrote: On 28/05/2015 15:52, Takashi Iwai wrote: At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts the MDIO bus code to use

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts the MDIO bus code to use the correct field. These modifications were made using Coccinelle. Signed-off-by: Quentin Lambert

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

At Thu, 28 May 2015 16:43:12 +0200, Quentin Lambert wrote: On 28/05/2015 16:09, Takashi Iwai wrote: At Thu, 28 May 2015 15:59:50 +0200, Quentin Lambert wrote: On 28/05/2015 15:52, Takashi Iwai wrote: At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use

Re: [PATCH] ALSA: aoa: Drop owner assignment from i2c_driver

On Fri, 10 Jul 2015 08:39:02 +0200, Krzysztof Kozlowski wrote: i2c_driver does not need to set an owner because i2c_register_driver() will set it. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Applied, thanks. Takashi --- The coccinelle script which generated the

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On Fri, 04 Dec 2015 18:02:58 +0100, Jens Axboe wrote: > > On 12/04/2015 09:59 AM, Takashi Iwai wrote: > > On Wed, 25 Nov 2015 20:01:47 +0100, > > Hannes Reinecke wrote: > >> > >> On 11/25/2015 07:01 PM, Mike Snitzer wrote: > >>> On Wed, Nov 25

Re: kernel BUG at drivers/scsi/scsi_lib.c:1096!

On Wed, 25 Nov 2015 20:01:47 +0100, Hannes Reinecke wrote: > > On 11/25/2015 07:01 PM, Mike Snitzer wrote: > > On Wed, Nov 25 2015 at 4:04am -0500, > > Hannes Reinecke wrote: > > > >> On 11/20/2015 04:28 PM, Ewan Milne wrote: > >>> On Fri, 2015-11-20 at 15:55 +0100, Hannes

Re: [alsa-devel] [PATCH] ALSA: snd-aoa: enable sound on PowerBook G4 12"

On Wed, 24 Aug 2016 22:35:58 +0200, Aaro Koskinen wrote: > > Hi, > > On Wed, Aug 24, 2016 at 09:43:23PM +0200, Johannes Berg wrote: > > On Wed, 2016-08-24 at 20:57 +0300, Aaro Koskinen wrote: > > > Enable sound on PowerBook G4 12". > > > > Looks good to me, I assume you tested it and it works

Re: [PATCH] ALSA: squash lines for simple wrapper functions

On Tue, 06 Sep 2016 13:41:19 +0200, Masahiro Yamada wrote: > > Remove unneeded variables and assignments. > > Signed-off-by: Masahiro Yamada Applied, thanks. Takashi > --- > > sound/aoa/fabrics/layout.c | 7 +-- >

  1   2   >