Re: [PATCH] video: valkyriefb: Fix unused variable warning in set_valkyrie_clock()

On 14/09/14 12:48, Geert Uytterhoeven wrote: If CONFIG_ADB_CUDA=n: drivers/video/fbdev/valkyriefb.c: In function ‘set_valkyrie_clock’: drivers/video/fbdev/valkyriefb.c:267: warning: unused variable ‘i’ drivers/video/fbdev/valkyriefb.c:266: warning: unused variable ‘req’ Move the variable

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

On 18/10/14 00:13, Jani Nikula wrote: Documentation/kbuild/kconfig-language.txt warns to use select with care, and in general use select only for non-visible symbols and for symbols with no dependencies, because select will force a symbol to a value without visiting the dependencies. Select

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

On 23/10/14 11:10, Daniel Vetter wrote: If we want to make BACKLIGHT_CLASS_DEVICE into a library thing then I guess we could do that, but we must then also drag it out of all the other meta options to make sure it's always available. No need I think to ditch BACKLIGHT_CLASS_DEVICE only

Re: [PATCH] drivers: depend on instead of select BACKLIGHT_CLASS_DEVICE and ACPI_VIDEO

On 27/10/14 13:59, Jani Nikula wrote: While doing 'depends on' instead of 'select' is an easy fix for this, I do dislike it quite a bit. It's a major pain to go around the kernel config, trying to find all the dependencies that a particular driver wants. If I need fb-foobar, I should just be

Re: [PATCH 03/15] fbdev: aty128fb: replace PPC_OF with PPC

On 27/02/15 03:05, Kevin Hao wrote: On Fri, Feb 27, 2015 at 11:11:15AM +1100, Benjamin Herrenschmidt wrote: On Sat, 2015-01-31 at 21:47 +0800, Kevin Hao wrote: The PPC_OF is a ppc specific option which is used to mean that the firmware device tree access functions are available. Since all the

Re: [PATCH 03/15] fbdev: aty128fb: replace PPC_OF with PPC

On 11/03/15 06:38, Kevin Hao wrote: On Tue, Mar 10, 2015 at 02:23:12PM +0200, Tomi Valkeinen wrote: I just sent out a v2 [1] a few hours earlier with some minor updates. We plan to merge this patch series via the powerpc tree in 4.1 cycle if I can collect all the acks from

Re: [PATCH v2] video: fbdev: fsl: Fix the sleep function for FSL DIU module

On 24/09/15 13:02, Wang Dongsheng wrote: > Hi Tomi, > > Could you apply this patch? > >>> For deep sleep, the diu module will power off, when wake up from the >>> deep sleep, the registers need to be reinitialized. >>> >>> Signed-off-by: Jason Jin >>> Signed-off-by:

Re: [PATCH] Fix loading of module radeonfb on PowerMac

On 08/10/16 15:09, Mathieu Malaterre wrote: > When the linux kernel is build with (typical kernel ship with Debian > installer): > > CONFIG_FB_OF=y > CONFIG_VT_HW_CONSOLE_BINDING=y > CONFIG_FB_RADEON=m > > The offb driver takes precedence over module radeonfb. It is then > impossible to load the

Re: [PATCH v2] Fix loading of module radeonfb on PowerMac

Hi, On 14/11/16 21:59, Mathieu Malaterre wrote: > When the linux kernel is build with (typical kernel ship with Debian > installer): > > CONFIG_FB_OF=y > CONFIG_VT_HW_CONSOLE_BINDING=y > CONFIG_FB_RADEON=m > > The offb driver takes precedence over module radeonfb. It is then > impossible to

Re: [PATCH] Fix loading of module radeonfb on PowerMac

On 08/10/16 15:09, Mathieu Malaterre wrote: > When the linux kernel is build with (typical kernel ship with Debian > installer): > > CONFIG_FB_OF=y > CONFIG_VT_HW_CONSOLE_BINDING=y > CONFIG_FB_RADEON=m > > The offb driver takes precedence over module radeonfb. It is then > impossible to load the