Re: [PATCH 1/1] powerpc: fix a memory leak

2023-09-14 Thread Tyrel Datwyler
On 9/14/23 02:46, Yuanjun Gong wrote: > When one of the methods xive_native_alloc_irq_on_chip, irq_create_mapping > or irq_get_handler_data fails, the function will directly return without > disposing vinst->name and vinst. Fix it. > > Fixes: c20e1e299d93 ("powerpc/vas: Alloc and setup IRQ and

Re: [PATCH] powerpc/pci: Remove useless null check before call of_node_put()

2022-04-22 Thread Tyrel Datwyler
On 4/20/22 19:52, Haowen Bai wrote: > No need to add null check before call of_node_put(), since the > implementation of of_node_put() has done it. > > Signed-off-by: Haowen Bai > --- > arch/powerpc/kernel/pci_dn.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH] powerpc/pci: Remove useless null check before call of_node_put()

2022-04-25 Thread Tyrel Datwyler
On 4/23/22 07:32, Michael Ellerman wrote: > Tyrel Datwyler writes: >> On 4/20/22 19:52, Haowen Bai wrote: >>> No need to add null check before call of_node_put(), since the >>> implementation of of_node_put() has done it. >>> >>> Signed-off-by:

Re: [PATCH 1/3] of: dynamic: add of_property_alloc() and of_property_free()

2022-06-02 Thread Tyrel Datwyler
On 6/2/22 07:06, Rob Herring wrote: > On Wed, Jun 1, 2022 at 5:31 PM Tyrel Datwyler wrote: >> >> On 5/5/22 12:37, Rob Herring wrote: >>> On Wed, May 04, 2022 at 05:40:31PM +0200, Clément Léger wrote: >>>> Add function which allows to dynamically al

Re: [PATCH v2 2/4] of: dynamic: add of_property_alloc() and of_property_free()

2022-06-02 Thread Tyrel Datwyler
On 6/1/22 23:58, Clément Léger wrote: > Le Wed, 1 Jun 2022 15:32:29 -0700, > Tyrel Datwyler a écrit : > >>> /** >>> - * __of_prop_dup - Copy a property dynamically. >>> - * @prop: Property to copy >>> + * of_property_free - Free a property al

Re: [PATCH 1/3] of: dynamic: add of_property_alloc() and of_property_free()

2022-06-01 Thread Tyrel Datwyler
On 5/5/22 12:37, Rob Herring wrote: > On Wed, May 04, 2022 at 05:40:31PM +0200, Clément Léger wrote: >> Add function which allows to dynamically allocate and free properties. >> Use this function internally for all code that used the same logic >> (mainly __of_prop_dup()). >> >> Signed-off-by:

Re: [PATCH v2 2/4] of: dynamic: add of_property_alloc() and of_property_free()

2022-06-01 Thread Tyrel Datwyler
On 6/1/22 01:17, Clément Léger wrote: > Add function which allows to dynamically allocate and free properties. > Use this function internally for all code that used the same logic > (mainly __of_prop_dup()). > > Signed-off-by: Clément Léger > --- > drivers/of/dynamic.c| 82

Re: [PATCH] powerpc: kernel: pci_dn: Add missing of_node_put() for of_get_xx API

2022-07-01 Thread Tyrel Datwyler
On 7/1/22 06:17, Liang He wrote: > In pci_add_device_node_info(), we should use of_node_put() for the > reference 'parent' returned by of_get_parent() to keep refcount > balance. > > Fixes: cca87d303c85 ("powerpc/pci: Refactor pci_dn") > Co-authored-by: Miaoqian Lin > Signed-off-by: Liang He >

Re: [PATCH] powerpc: kernel: pci_dn: Add missing of_node_put() for of_get_xx API

2022-07-01 Thread Tyrel Datwyler
On 7/1/22 12:47, Tyrel Datwyler wrote: > On 7/1/22 06:17, Liang He wrote: >> In pci_add_device_node_info(), we should use of_node_put() for the >> reference 'parent' returned by of_get_parent() to keep refcount >> balance. >> >> Fixes: cca87d303c85 ("powerpc

Re: [PATCH] powerpc/pci: Add config option for using OF 'reg' for PCI domain

2022-06-09 Thread Tyrel Datwyler
On 6/9/22 13:21, Guilherme G. Piccoli wrote: > First of all, thanks for looping me Bjorn! Much appreciated. > I'm also CCing Ben and Gavin, that know a lot of PPC PCI stuff. > > > On 09/06/2022 16:34, Bjorn Helgaas wrote: >> [...] >>> Upgrading powerpc kernels from LTS 4.4 version (which

Re: [PATCH v2 0/4] pseries-wdt: initial support for H_WATCHDOG-based watchdog timers

2022-06-16 Thread Tyrel Datwyler
On 6/15/22 18:43, Daniel Henrique Barboza wrote: > Hi, > > I tried this series out with mainline QEMU built with Alexey's patch [1] > and I wasn't able to get it to work. I'm using a simple QEMU command line > booting a fedora36 guest in a Power9 boston host: I would assume the H_WATCHDOG

[PATCH] ibmvfc: multiqueue bug fixes

2022-06-16 Thread Tyrel Datwyler
Fixes for a couple observed crashes of the ibmvfc driver when in MQ mode. Tyrel Datwyler (2): ibmvfc: store vhost pointer during subcrq allocation ibmvfc: alloc/free queue resource only during probe/remove drivers/scsi/ibmvscsi/ibmvfc.c | 82 ++ drivers/scsi

[PATCH] ibmvfc: store vhost pointer during subcrq allocation

2022-06-16 Thread Tyrel Datwyler
] ibmvfc_init_crq+0x160/0x280 [ibmvfc] [c000146235f0] [c0080321a9cc] ibmvfc_probe+0x2a4/0x530 [ibmvfc] Fixes: 3034ebe263897 ("scsi: ibmvfc: Add alloc/dealloc routines for SCSI Sub-CRQ Channels") Cc: sta...@vger.kernel.org Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- dr

[PATCH] ibmvfc: alloc/free queue resource only during probe/remove

2022-06-16 Thread Tyrel Datwyler
nstead during connection resets to sanitize and reconfigure the queues. Fixes: 3034ebe26389 ("scsi: ibmvfc: Add alloc/dealloc routines for SCSI Sub-CRQ Channels") Cc: sta...@vger.kernel.org Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King --- drivers/scsi/ibmvsc

Re: [PATCH] powerpc/rtas: Allow ibm,platform-dump RTAS call with null buffer address

2022-06-14 Thread Tyrel Datwyler
; Fixes: bd59380c5ba4 ("powerpc/rtas: Restrict RTAS requests from userspace") > Cc: sta...@vger.kernel.org > Reported-by: Sathvika Vasireddy > Signed-off-by: Andrew Donnellan Similar to what is done for ibm,configure-connector with idx_buf2 and a NULL address. Reviewed-by: Ty

Re: [PATCH] powerpc/eeh: Drop redundant spinlock initialization

2022-05-10 Thread Tyrel Datwyler
On 5/10/22 02:53, Haowen Bai wrote: > slot_errbuf_lock has declared and initialized by DEFINE_SPINLOCK, > so we don't need to spin_lock_init again, drop it. > > Signed-off-by: Haowen Bai > --- > arch/powerpc/platforms/pseries/eeh_pseries.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH] powerpc/pci: Add config option for using OF 'reg' for PCI domain

2022-05-05 Thread Tyrel Datwyler
On 5/5/22 02:31, Pali Rohár wrote: > Hello! > > On Thursday 05 May 2022 07:16:40 Christophe Leroy wrote: >> Le 04/05/2022 à 19:57, Pali Rohár a écrit : >>> Since commit 63a72284b159 ("powerpc/pci: Assign fixed PHB number based on >>> device-tree properties"), powerpc kernel always fallback to PCI

Re: [PATCH] scsi: ibmvscsi: Replace all non-returning strlcpy with strscpy

2023-05-17 Thread Tyrel Datwyler
py() completely [2], replace > strlcpy() here with strscpy(). > No return values were used, so direct replacement is safe. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy > [2] https://github.com/KSPP/linux/issues/89 > > Signed-off-by: Azeem Shaikh Acked-by: Tyrel Datwyler

Re: [PATCH 25/42] drivers/scsi/ibmvscsi: Convert snprintf to sysfs_emit

2024-01-16 Thread Tyrel Datwyler
/scsi/ibmvscsi/ibmvfc.c:3513:8-16: WARNING: please use sysfs_emit >> ./drivers/scsi/ibmvscsi/ibmvfc.c:3522:8-16: WARNING: please use sysfs_emit >> ./drivers/scsi/ibmvscsi/ibmvfc.c:3530:8-16: WARNING: please use sysfs_emit > > No functional change intended > > CC: Tyrel Datwyle

<    2   3   4   5   6   7